Menu

#1380 Add a "Find Previous" button to the Search window

future
open
nobody
None
5
1 day ago
2018-03-08
No

suggest the following changes to the filtered Editor pane (after having clicked "Replace" in the Replacement dialog):

  1. Change the "Replace Next" button to "Replace Current/Find Next", but keep the button's function the same.
  2. Change the "Skip" button to "Find Next", and make sure it's function is to select the next instance of the found text.
  3. Add a "Find Previous" button, which selects the previous instance of the found text.

This would make more sense to me, and would enable me to use keyboard shortcuts to move between found instances so as to select the appropriate one before performing the replacement.

Discussion

  • Jean-Christophe Helary

    • Group: 4.1 --> 5.8
     
  • Jean-Christophe Helary

    Please see the comment in https://sourceforge.net/p/omegat/feature-requests/1379/. I don't think we can add a button for 5.8 but we can probably adapt the button labels.

     
  • Jean-Christophe Helary

    • assigned_to: Jean-Christophe Helary
     
  • Jean-Christophe Helary

    • summary: Additional buttons in the Replace function --> Add a "Find Previous" button to the Search window
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,7 +1,7 @@
    -I suggest the following changes to the filtered Editor pane (after having clicked "Replace" in the Replacement dialog):
    +<s> suggest the following changes to the filtered Editor pane (after having clicked "Replace" in the Replacement dialog):
    
    
     1. Change the "Replace Next" button to "Replace Current/Find Next", but keep the button's function the same.
    -2. Change the "Skip" button to "Find Next", and make sure it's function is to select the next instance of the found text.
    +2. Change the "Skip" button to "Find Next", and make sure it's function is to select the next instance of the found text.</s>
     3. Add a "Find Previous" button, which selects the previous instance of the found text.
    
     This would make more sense to me, and would enable me to use keyboard shortcuts to move between found instances so as to select the appropriate one before performing the replacement.
    
     
  • Jean-Christophe Helary

    • assigned_to: Jean-Christophe Helary --> nobody
    • Group: 5.8 --> 6.1
     
  • Jean-Christophe Helary

    • Group: 6.1 --> future
     
  • Jean-Christophe Helary

    This "Find previous" "Find next" was about the "Replace" window, not about the "Search" window.

    In the search window we already have the C+N / C+P shortcuts that do that. We don’t need extra buttons.

     
    • st. pakebusch

      st. pakebusch - 2 days ago

      (Shift+)F3 does not duplicate the documented Ctrl+N / Ctrl+P:

      • Ctrl+N/P binds to results list only, needs focus there; F3 works from anywhere in Search window, incl. search field
      • Ctrl+N/P stops at list end; F3 wraps around
      • Ctrl+N/P syncs editor only with "Auto-sync" enabled; F3 always shows segment in editor without loosing focus of search window

      the title of the ticket seems to indicate "search" window and not "replace" window

       
      • Jean-Christophe Helary

        Why not add the F3 "functionality" to the existing C-n/C-p ?

        As for auto-sync, we could solve that more elegantly by using a key modifier.

        C-n/C-p vs S-C-n / S-C-p

        In any case, that a UX discussion that we need to have.

         

Log in to post a comment.