#3371 veteran soldier promoted to colonial regular while in college

[Bernat]

Hello!

After declaring independence veteran soldier promoted to regular colonial while teaching at college
Attached is the game just before declaring independence. I think the soldier should not be promoted if he is in college or he should stop teaching.
Steps to reproduce

load first game, declare independence
In Miquelon veteran soldier have been promoted to regular, while teaching (see second save game)
the second save game is the result

Version of the game 1.2.0 commit 5a4ae5e47b0b3dcadb2ce5613c3b048b5130b35c of 2024-09-30

Thanks for the great work!

PD .- for some reason after some turns the game freezes, but I don't have the logs at this moment

[Stian Grenborgen]

The code for the continental army muster includes veteran soldiers that are working inside a colony. I think this is a good idea since the player would otherwise have to temporarily move all veteran soldiers that are teaching out to the front of the colony in order to maximize the number of colonial regulars created.

Note that a colonial regular that is teaching will still only produce veteran soldiers.

[Bernat]

checked soldier teach works perfectly

[Stian Grenborgen]

PD .- for some reason after some turns the game freezes, but I don't have the logs at this moment

I'm not getting a freeze when just ending the turns. However, the first REF turn takes way too much time. In addition, executing the goto orders takes so much time that the interface seem frozen for some seconds as well. Perhaps one of these is what you experienced?

[Bernat]

Hello Stian

upppps I am completely wrong about the cause of the crash
I think I got the trick
It only happens if before press the end of the turn I attack with the Privater of Sint Catherina the enemy Man of war near Paraná (tupi settlement in a island)
Then I try to end the turn but I can't
I got in the log an
" The network request timed out: 30000"
I wait two minutes and I recover the control, but still can't end the turn
Sorry for the mistake

[Bernat]

Hello!
Please after you attack Man-of-war, select "none" and "OK" to the load cargo panel (Dump the cargo to the sea)
Attack with Sint Catherina Privater

[Bernat]

Here a minimized scenario, attack man-of-war an dump cargo to the sea, and press enter
I thought it was already uploaded

[Stian Grenborgen]

The problem has now been fixed.

Workaround when playing on an old version:
Just do a "Game > Reconnect"

The bug was caused by a non-resolved loot-cargo-session since no goods capture was ignored.

[Bernat]

thanks!!!!