From: Nathan V. G. <na...@va...> - 2015-02-16 01:13:06
|
Some updates. On Sun, Feb 15, 2015 at 7:05 PM, David Glick (Plone) <dav...@pl...> wrote: > On 2/9/15 7:48 AM, Nathan Van Gheem wrote: > >> Hi all, >> >> The last couple days I've been looking at our final js issues. We're >> actually pretty close to being done. >> >> Here are a few thoughts on what is left and I'm hoping I get some >> responses in anyone has disagreements: >> >> - let's not get hung up on getting EVERYTHING into "patterns". We should >> be okay with having non-pattern js files in our code. Those non-pattern >> js-files should utilize/work with requirejs and our other patterns. I'm >> thinking of things like reqistry control panel/plone.app.event/etc. I think >> some of these js files don't fit easier into "pattern" space. >> > I'll have to recheck but almost everything is updated now. > >> - we should try and get rid of plone.app.jquerytools >> > > Where are we still using it? Having a list would be a helpful starting > point for getting people to help update it to patterns. The big place we're still using it is the recurrence widget. I looked into this widget but it's rather insane. We might not be able to get rid of plone.app.jquerytools until Plone 5.1 > > > >> - we need to get rid of plone_javascript_variables--all that data should >> be on the body attrs now >> > This is done. > >> - it's hard to reproduce consistently, but I think we might have an >> ordering issue with legacy js/css import step >> > I think we're fine here too. > >> - theming control panel is broken, needs lots of js love and some css >> love(since it's "unthemed") >> > No longer broken but the theme mapper definitely needs more work yet. > >> - Dexterity Types editor will need some re-work. >> >> I did some work on this and made 2 pull requests: > https://github.com/plone/plone.schemaeditor/pull/20 > https://github.com/plone/plone.app.dexterity/pull/149 Merged. -- Nathan Van Gheem Solutions Architect Wildcard Corp |