From: Jacob C. <jac...@gm...> - 2004-06-25 00:38:36
|
On Thu, 24 Jun 2004 16:15:09 -0700, Mitch (WebCob) <mi...@we...> wrote: > While we are on the subject of colors - which leads me to workflows, are you > aware of anything that specifically defines and documents the flow through > that rainbow of color states? I'm trying to write something for clients, and > wondered if you'd seen anything... I'm not really sure what you're asking. > > Couple of suggestions: > > > > + $specific_where = ' '.$id_name.' in (' > > + . join(',',user_get_accessible_projects( > > $g_cache_current_user_id )) > > > > can become > > + $specific_where = ' '.$id_name.' in (' > > + . $my_project_list > > + . ')'; > > > > Not a biggie, but it can help reduce the load on the webserver. > > Are you suggesting caching the list somehow? How does the existing cache > work - doesn't this function already use it? I thought most of the functions > did... No, no. I was pointing out you assign $my_project_list = join(...) earlier in the function. I didn't see any reason to rebuild that string later on if $my_project_list != "", so I was noting that you could simply reuse $my_project_list. It also can (help) prevent some weird edge cases where user_get_accessible_projects() could return two different values between callings. |