[Mantisbt-cvs] mantisbt manage_proj_cat_update.php,1.16,1.17

[<jfi...@us...>]

Update of /cvsroot/mantisbt/mantisbt
In directory usw-pr-cvs1:/tmp/cvs-serv560

Modified Files:
	manage_proj_cat_update.php 
Log Message:
Fix #2434:  Categories of ALL projects get overwritten when changing a single Category

Cleaned up the file a little while I was there

Thanks to marc for finding the solution


Index: manage_proj_cat_update.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/manage_proj_cat_update.php,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -d -r1.16 -r1.17
--- manage_proj_cat_update.php	25 Aug 2002 21:04:57 -0000	1.16
+++ manage_proj_cat_update.php	30 Aug 2002 07:53:49 -0000	1.17
@@ -10,14 +10,10 @@
 <?php
 	check_access( MANAGER );
 
-	if ( empty( $f_category ) ) {
-		print_mantis_error( ERROR_EMPTY_FIELD );
-	}
-	
-	check_varset( $f_assigned_to, '0' );
-
-	$f_category = urldecode( $f_category );
-	$f_orig_category = urldecode( stripslashes( $f_orig_category ) );
+	$f_project_id		= gpc_get_int( 'f_project_id' );
+	$f_category			= gpc_get_string( 'f_category' );
+	$f_orig_category	= gpc_get_string( 'f_orig_category' );
+	$f_assigned_to		= gpc_get_int( 'f_assigned_to', 0 );
 
 	$result = 0;
 	$query = '';
@@ -29,12 +25,14 @@
 			break;
 		}
 
-		$c_category			= addslashes($f_category);
-		$c_orig_category	= addslashes($f_orig_category);
+		$c_category			= db_prepare_string( $f_category );
+		$c_orig_category	= db_prepare_string( $f_orig_category );
+		$c_project_id		= db_prepare_int( $f_project_id );
 
 		$query = "UPDATE $g_mantis_bug_table
 				SET category='$c_category'
-				WHERE category='$c_orig_category'";
+				WHERE category='$c_orig_category'
+				  AND project_id='$c_project_id'";
 	   	$result = db_query( $query );
 	}