Re: [Mantisbt-dev] Patches : broken french translation, phpmailer with SMTP Authentication

[Julian F. <ju...@be...>]

Laurent,

I'll apply your french patch immediately.  With regard to the other 
portion, a few comments:

- instead of having another parameter to turn this feature on, couldn't 
we just check whether the username is empty or not?
- if we were going to keep the boolean parameter, we use ON and OFF 
rather than true and false (both will work, but for consistency, your 
patch should use the same as the rest of the code)
- in general we try not to add code that uses config globals directly 
anymore.  In this case, you're just copying the existing code in that 
function so it's not the end of the world, but if you felt like 
converting that function while you were at it, that would be great.

On Monday, February 3, 2003, at 01:05  PM, Laurent PETIT wrote:

> Hello,
>
> Here are some patches.
>
> First one is for the french translation file which is currently broken 
> due
> to a single quote inserted into a single quoted string, plus a few of 
> extra
> translations / corrections. (Other one may follow as quickly as I can).
>
> Second one is for those who like us must use a SMTP authentication 
> while
> working with phpmailer.
> The patch is very simple, does not break anything :
> - an addon in email_api.php to check 3 more global variables : 
> $g_smtp_auth,
> $g_smtp_username, $g_smtp_password.
> - a modification on config_defaults_inc.php to comment the use of 
> those 3
> new variables.
>
> cu,
>
> (I've made the cvs diff -u for each file, but if you prefer a global 
> cvs
> diff from the root of the project, please tell me)
> --
> Laurent.
> <strings_french.diff><email_api.diff><config_defaults_inc.diff>