Re: [Mantisbt-dev] First contribution, first questions

[Julian F. <ju...@be...>]

Olyves wrote:

> I have installed Mantis three months ago to offer support to our customers
> (in french and german at www.catalliances.net)
> It works really great and I would like first thank all contributors 
> for they
> very good work
>
> I made some small changes to the code and would like to submit them to the
> list. This one adds a link "Send by mail" on bug_view_page and
> bug_view_advanced_page so you can send a link to a bug at any moment as a
> reminder or to ask additional information
>
> I have another modification (in progress) to manage the language 
> associated
> with the news (we are working with foreign users and each one must see the
> news in his own language)
>
> Some questions now :
> . I am working with windows/wincvs (nobody's perfect) can you read and use
>   the attached files ?

Yes, though I would very much prefer a unified diff if you can produce 
one (use the -u parameter for GNU diff... dunno if wincvs lets you do 
that) - it's the one with lines that start with + and - instead of >

If you're able to repost that way, that would be great, otherwise I can 
review this as it is (just means I have to actuall file in and diff myself)

> . can someone integrate the present contribution (if you find some 
> interest)

I'll take a look at soon but as I just wrote in my last message, I've 
been called for jury duty so this week will be a bit of a mess.

> . may I apply for a developer acces to cvs (my login : olyves)

Ideally, we like to take a few patches first.  This serves two purposes:
1) makes sure new developers are familiar with the coding standards, 
practices, etc
2) makes sure people are actually hanging around for a bit rather than 
just disappearing (becomes a pain having to constantly figure out who's 
disappeared, etc)

This isn't a particularly stringent test or anything, we're not trying 
to keep people from contributing.  As soon as I find time I'm going to 
start marking some issues that are good places for new developers to 
jump in but feel free to grab anything that interests you and submit 
patches.

> . are modifications on the database welcome?

Mmm... you'll need to hurry and they'll have to be discussed.  Version 
0.18 (the next release) will include DB changes but after that the DB 
won't change until 0.19.  And DB changes will definitely require 
discussion first.  So throw your proposals out there but I can't 
guarantee anything.

>
> . can you give me some advice on the news language management, my
>   suggestions are :
>   - create a "language" field in mantis_news_table with the language 
> name or
>     "All" (as default) for news displayed in all languages
>   - (optional) create a "scope" field in mantis_news_table with value 0(as
>     default)/1(for general news available in all projets)

You're talking about having the same news posting in multiple languages? 
  I don't know the news code very well unfortunately.  Hopefully Ken 
will jump in with some opinions on this.  If not, you could find us in 
the IRC channel (#mantishelp on openprojects)... Ken's much better at 
following discussion in there.

> . when is the best time for strings_ files translation?

Again, Ken's your man on internationalization stuff.  He's actually been 
revamping the process but I haven't seen the new stuff yet so I can't 
provide any insight here.

>
> Yves
> --
> hu...@ol...

I'll file this away to look at as soon as I get a chance but if you can 
find a way to send a unified diff format in the meantime I would 
appreciate it.

Cheers,

Julian

-- 
ju...@be...
Beta4 Productions (http://www.beta4.com)