[mantisbt-commits] [mantisbt/mantisbt] e2e0a9: Install: special processing for pgsql boolean colu...

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/mantisbt/mantisbt
  Commit: e2e0a9d4ff48eb6d2220ed031af7b835da866951
      https://github.com/mantisbt/mantisbt/commit/e2e0a9d4ff48eb6d2220ed031af7b835da866951
  Author: Damien Regad <dr...@ma...>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M admin/install.php
    M core/install_helper_functions_api.php

  Log Message:
  -----------
  Install: special processing for pgsql boolean columns

The upgrade of ADOdb library to version 4.96 with Mantis release
1.1.0 introduced a change in the way type 'L' columns are created
(SMALLINT before, BOOLEAN after).

This requires special handling to fix the database schema, because the
normal schema upgrade steps do not cover it (since from the MantisBT
installer's perspective the column type has not changed).

Fixes #16392


  Commit: ddba1d9fd685f0d58a63e50ee8cbb36aa472adac
      https://github.com/mantisbt/mantisbt/commit/ddba1d9fd685f0d58a63e50ee8cbb36aa472adac
  Author: Damien Regad <dr...@ma...>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M admin/install.php
    M core/install_helper_functions_api.php

  Log Message:
  -----------
  Install: pgsql bool check now handles nullable columns

Issue #16392


  Commit: 592cbb9c753a6f3593a3958448ac9f17f6d6bdcd
      https://github.com/mantisbt/mantisbt/commit/592cbb9c753a6f3593a3958448ac9f17f6d6bdcd
  Author: Damien Regad <dr...@ma...>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M core/custom_field_api.php
    M core/database_api.php
    M core/user_api.php

  Log Message:
  -----------
  Fix travis build errors for PostgreSQL

The errors were caused by executing queries with params in wrong order.

To fix the problem, this commit adds Database API functions to push the
current parameter number onto a stack and pop the value after query
execution, allowing build of multiple queries concurrently.

The caller can call db_param_push() when needed prior to starting the
build of a new query while another one is still pending execution.
db_query_bound() will call db_param_pop() after running the query.

Fixes #14398


  Commit: 8bdc9697f45f4b54be4a7a4e3f2ba2f4364f375a
      https://github.com/mantisbt/mantisbt/commit/8bdc9697f45f4b54be4a7a4e3f2ba2f4364f375a
  Author: Damien Regad <dr...@ma...>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M core/database_api.php

  Log Message:
  -----------
  Move parameter count management to a class

The MantisDbParam class handles the logic for:
- assignment of parameters, db_param() calls
- push onto stack, db_param_push() calls
- pop stack


  Commit: 2b5a7005c76ef5eb4b78e501ae5c5b759575d71a
      https://github.com/mantisbt/mantisbt/commit/2b5a7005c76ef5eb4b78e501ae5c5b759575d71a
  Author: Damien Regad <dr...@ma...>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M library/adodb

  Log Message:
  -----------
  Update ADOdb to latest 5.19dev


  Commit: 21d0f53188eb7ee51d3bdc1f77dd0fcf09e9bc20
      https://github.com/mantisbt/mantisbt/commit/21d0f53188eb7ee51d3bdc1f77dd0fcf09e9bc20
  Author: Damien Regad <dr...@ma...>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M scripts/travis_before_script.sh

  Log Message:
  -----------
  Travis before script: use variable for port number

This facilitates local debugging using the PHP built-in web server when
there is another one running on default port 80.


  Commit: e5ab6ea7b39eb72e68f92b4c324c05e8147deb3a
      https://github.com/mantisbt/mantisbt/commit/e5ab6ea7b39eb72e68f92b4c324c05e8147deb3a
  Author: Damien Regad <dr...@ma...>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Travis: stop ignoring build failures for PostgreSQL


  Commit: 37e5732727593215ea3d222fc7f70fc709dfa93e
      https://github.com/mantisbt/mantisbt/commit/37e5732727593215ea3d222fc7f70fc709dfa93e
  Author: Damien Regad <dr...@ma...>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M admin/install.php

  Log Message:
  -----------
  Coding guidelines

- $v_ prefix for extracted variables
- $t_ prefix for other local variables


  Commit: b5194d98fd7512506be8384e2ac05ec499e05f8e
      https://github.com/mantisbt/mantisbt/commit/b5194d98fd7512506be8384e2ac05ec499e05f8e
  Author: Damien Regad <dr...@ma...>
  Date:   2014-03-24 (Mon, 24 Mar 2014)

  Changed paths:
    M .travis.yml
    M admin/install.php
    M core/custom_field_api.php
    M core/database_api.php
    M core/install_helper_functions_api.php
    M core/user_api.php
    M library/adodb
    M scripts/travis_before_script.sh

  Log Message:
  -----------
  Merge PostgreSQL fixes branch

This covers several fixes to (re-)enable support for pgsql database in
master branch, which has been broken since upgrade to unpatched ADOdb
5.11 several years ago. With these, PostgreSQL should now be
operational:

- Correct handling for booleans, including fix of installer/upgrade
  process to convert pre 1.1.0 instances SMALLINT columns to BOOLEAN
- Finally fixing the broken Travis builds. This required new DB API
  calls to push/pop the parameter count to a stack, to enable concurrent
  build of multiple queries (required as pgsql uses positional
  parameters). Initial implementation 124f79e was procedural, then I moved
  this to a simple class in d09d5ad
- ADOdb update to latest development head (includes a required fix to
  ADODB_postgres64->Param() )

Also includes .travis.yml changes to stop ignoring pgsql build failures.

Pull request #143


Compare: https://github.com/mantisbt/mantisbt/compare/2d4072892423...b5194d98fd75