From: Paul R. <pa...@ma...> - 2014-01-13 19:14:33
|
Avatar threshold: https://github.com/mantisbt/mantisbt/pull/104 You posted that 11 hours ago That's less then 24 hours - and last time I checked we had people located in different timezones in the 'team' So arguing that you've asked everyone and got feedback from everyone with a pull request that is open for <10 hours does not really give everyone ample to think about it. Even in the request itself, Robert queried a security question (which wasn't answered) - albeit, I doubt there's a security issue. On Mon, Jan 13, 2014 at 6:55 PM, Victor Boctor <vb...@gm...> wrote: > The change to the footer was discussed with the team on the DL and was > reviewed in a pull request. > > The change to remove the avatar threshold was reviewed by everyone in the > team except you, since you are not using github the way the rest of the > team does. > > As discussed before, I'm OK with you forking. I think this will be more > fun for you and will enable the rest of the team to get out of the "wait... > stay on hold" mode that they have been on for a while, because you always > had stuff that is coming at one point. I think we will both end up being > more productive. > > > On Mon, Jan 13, 2014 at 10:27 AM, Paul Richards <pa...@ma...>wrote: > >> I've spent a chunk of time in december looking at notifications as I >> needed to get them implemented at work. >> >> Unfortunately, the team decision not to support (or allow) mssql support >> in the 1.3 release means that things need to be ported, and also paralyzes >> my ability to add features to mantis >> >> I noticed today that the reference to GPL in the footer (originally >> added) by dhx was removed - interesting that the removal of the opensource >> license is done by the person promoting commercialization, and that the >> avatar_threshold which I also make use of at work was dropped. >> >> I'm going to have a think about my future with mantis - It's becoming >> fairly clear that the commercial direction that Mantis is headed is not >> something that I feel strongly about. I'd actually get more enjoyment atm >> from a fork - at least, it would be less work. >> >> Paul >> >> >> >> >> On Mon, Jan 13, 2014 at 6:01 PM, Victor Boctor <vb...@gm...> wrote: >> >>> Paul, I think as a team to be effective we have to use github.com for >>> more than just a plain source repository. You should use pull requests and >>> respond to comments relating to your checkins over there. That is how the >>> team work. I've also added comments to your checkins related to >>> email_generic() since it goes against the changes I'm proposing / >>> implementing with notifications on which the whole team was engaged. Please >>> don't do any further checkins in this area directly to master. We can have >>> the discussion on the pull request I submitted earlier for feedback or the >>> mailing list discussion about notifications on which you replied with a >>> one-liner to not do anything since you have something. Effectively what is >>> happening is that this is paralyzing the whole team. And I got such >>> feedback from others. >>> >>> >>> https://github.com/mantisbt/mantisbt/commit/03c5a5d18cfef07dec45a1025072981f24a5f07c#commitcomment-5052975 >>> >>> For code reviews, I think the important thing is to do them effectively. >>> I wouldn't be concerned about what happens if we move in the future. We >>> can always keep the code + code reviews in github for history and use the >>> new infrastructure for new development and reviews. >>> >>> I would like to lock down direct checkins into master without pull >>> requests. So all changes are to be submitted as pull requests and only get >>> included in master when complete and approved. Simple bug fixes can >>> by-pass this process and go directly into master. This doesn't include new >>> features, removal of features, code refactoring, etc. >>> >>> Thoughts? >>> >>> >>> >>> On Sun, Jan 12, 2014 at 8:39 AM, Gianluca Sforna <gi...@gm...>wrote: >>> >>>> On Sun, Jan 12, 2014 at 2:14 PM, Roland Becker <ro...@at...> wrote: >>>> > I really like the comment functionality of GitHub. >>>> > But I don't like that the comments are lost if we ever decide to move >>>> to another >>>> > git hosting. >>>> >>>> That's unfortunate, but of course part of the lock-in you get from all >>>> similar git hosting sites. >>>> >>>> Probably, one solution could be to use another open source service for >>>> code reviews. Last time I checked there was plenty of choice in the >>>> field, but I am not sure if there is one with a viable hosted option. >>>> >>>> >>>> -- >>>> Gianluca Sforna >>>> >>>> http://morefedora.blogspot.com >>>> http://identi.ca/giallu - http://twitter.com/giallu >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >>>> Learn Why More Businesses Are Choosing CenturyLink Cloud For >>>> Critical Workloads, Development Environments & Everything In Between. >>>> Get a Quote or Start a Free Trial Today. >>>> >>>> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >>>> _______________________________________________ >>>> mantisbt-dev mailing list >>>> man...@li... >>>> https://lists.sourceforge.net/lists/listinfo/mantisbt-dev >>>> >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >>> Learn Why More Businesses Are Choosing CenturyLink Cloud For >>> Critical Workloads, Development Environments & Everything In Between. >>> Get a Quote or Start a Free Trial Today. >>> >>> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> mantisbt-dev mailing list >>> man...@li... >>> https://lists.sourceforge.net/lists/listinfo/mantisbt-dev >>> >>> >> >> >> ------------------------------------------------------------------------------ >> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >> Learn Why More Businesses Are Choosing CenturyLink Cloud For >> Critical Workloads, Development Environments & Everything In Between. >> Get a Quote or Start a Free Trial Today. >> >> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >> _______________________________________________ >> mantisbt-dev mailing list >> man...@li... >> https://lists.sourceforge.net/lists/listinfo/mantisbt-dev >> >> > > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > mantisbt-dev mailing list > man...@li... > https://lists.sourceforge.net/lists/listinfo/mantisbt-dev > > |