Re: [mantisbt-dev] Reminders functionality in 1.2.15 and future versions (Damien Regad)

[Tamás G. <gt...@gt...>]

Hi,

From: Damien Regad <dam...@me...>
> Subject: Re: [mantisbt-dev] Reminders functionality in 1.2.15 and
>         future  versions
> To: Man...@li...
> Message-ID: <loo...@po...>
> Content-Type: text/plain; charset=utf-8
>
> Glenn Henshaw <thraxisp@...> writes:
> > > 2. We should have a configurable limit on number of people who can be
> > > reminded with a default of 5-10. this is to avoid spam.
> > ? This was in the original implementation.
>
> Thanks for the feedback Glenn
>
> I didn't go all the way back to 0.18, but in the original 1.2.x code before
> I messed with it, there was only a *hardcoded* limit of 50 recipients.
>
> IMO that is much too high, and furthermore (to Victor's point) the number
> is
> not configurable.
>
> > > 3. If we are to have a history entry, we should have one with the first
> > > N users notified to fit within the field size.
> > ? This was also in the original implementation.
>
> Right, but depending on the number of users in the system (i.e. length of
> user_id), the list could overflow the DB field's size resulting in a
> truncated list of recipients.
>
>
>
> Following up on my earlier post - after reverting the change [1], I did
> some
> testing to confirm all was working as expected.
>
> That's when I realized that a bugnote is actually NOT created when the
> reminder text is empty, even if $g_store_reminders = ON. After a quick
> investigation, this is due to bugnote_add() returning false when
> $p_bugnote_text is blank as the code does not take REMINDER notes into
> consideration. Looks like a regression introduced by [2].
>
> With a quick fix to the bugnote api, we can ensure that a reminder bugnote
> (and the corresponding history entry!) is always created, even when there
> is
> no reminder text. This effectively makes adding reminders and recipients
> list in the bug history completely redundant, although as a nice-to-have we
> might want to differentiate the history message.
>
> That leaves us with (from Victor's points)
>
> 2. limiting how many reminders can be sent simultaneously
> 4. removing $g_store_reminders config option (i.e. don't allow "silent"
> reminders, always log them as bugnotes)
>
> Damien
>
>
> [1] http://github.com/mantisbt/mantisbt/commit/f4753ec5
> [2] http://github.com/mantisbt/mantisbt/commit/bda0f406
>
>
 I DO use this feature: a very convenient way to add monitors to the issue
is to "send" an empty notification to them - so please make it configurable
at least!

Tamás Gulácsi (gthomas)