[mantisbt-commits] [mantisbt/mantisbt] 5273c4: SOAP API: calling mc_issue_update unduly updated b...

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/mantisbt/mantisbt
  Commit: 5273c401e406b8006dc0f6edd54215ea9a828ca0
      https://github.com/mantisbt/mantisbt/commit/5273c401e406b8006dc0f6edd54215ea9a828ca0
  Author: Damien Regad <dam...@me...>
  Date:   2012-07-02 (Mon, 02 Jul 2012)

  Changed paths:
    M api/soap/mc_issue_api.php

  Log Message:
  -----------
  SOAP API: calling mc_issue_update unduly updated bugnotes

History shows 'Note View State changed' even though it has not been
modified, and if time tracking is enabled the bugnote's last_updated
date is changed.

This was caused by a type-strict comparison of the value returned by the
api (string) to an integer.

Fixes #14412


  Commit: aca7cf7dbfc085c695dc2dd162df598a8e0caac9
      https://github.com/mantisbt/mantisbt/commit/aca7cf7dbfc085c695dc2dd162df598a8e0caac9
  Author: Damien Regad <dam...@me...>
  Date:   2012-07-02 (Mon, 02 Jul 2012)

  Changed paths:
    M core/user_api.php

  Log Message:
  -----------
  LDAP binding calls are made even if $g_login_method <> LDAP

If for some reason $g_use_ldap_email or $g_use_ldap_realname are ON with
$g_login_method <> 'LDAP', binding calls are attempted when retrieving
the user's e-mail or real name.

Adding a check on $g_login_method to avoid this unwanted behavior.

Fixes #14442


Compare: https://github.com/mantisbt/mantisbt/compare/21e1a24b21b2...aca7cf7dbfc0