From: David H. <d...@hx...> - 2011-08-11 10:34:31
|
On Tue, 2011-08-09 at 14:06 +0200, Damien Regad wrote: > That's when I realized that the message for the check is "configuration > option does not point to a valid **and accessible** directory", yet the > check is only for is_dir (and not is_readable). Agreed with adding an is_readable check. > Should I change the code to add the check to the existing for loop, or > create a new, separate one to check for accessibility ? Not too bothered with either approach. However I think a second check for permissions would be better than merging it with the existing is_dir check. The reason being that users will at least know whether it's a problem with symlinks/whatever other interesting directory paths they're using vs. a permissions issue on the final path. |