From: Damien R. <dam...@me...> - 2011-07-25 15:26:20
|
On 07/25/2011 03:54 PM, Daryn Warriner wrote: > I have looked at this very issue before. It is definitely a much deeper > problem than just changing the query sort. Yep... > I do think we need to fix > this but not in the current state. These fields have been sorted in > this manner since the day they were added. I suggest we focus on > rewriting MantisBT (see the `next` branch). Since correcting the sort order for Categories and Projects, as well as the "normal cases" for Users (i.e. ignoring the cases of missing realnames and deleted users) would be quite simple to implement with about a dozen lines of code, I would rather go for the quick win and fix it now, unless someone objects. In my opinion, the fact that the fields are incorrectly sorted since they were added does not really justify keeping the bug around if we have a fix for it - even if it's a partial one. The "perfect" solution covering all cases can then come in the next branch, whenever it is ready. > As for as the duplicate_id field. I suggest someone look thoroughly at > the code before deprecating and removing it. I thought it had been > deprecated as well but it seems that I found some code depending on it > at some point. I don't recall but I believe it was in the relationship api. Did not see anything in relationship api, but I found this comment in bug_api.php: # log changes except for duplicate_id which is obsolete and should be removed in # MantisBT 1.3. Definitely something that needs to be looked at carefully. Damien |