From: Paul R. <pa...@ma...> - 2009-05-02 09:42:37
|
We only log queries if show_queries_count is ON In terms of schema updates - I patched install_functions.php in the date's branch to disable showing queries for both the category updates (we have now) and the new dates update. We currently show: a) ram usage b) page time c) db queries count d) unique queries count Personally, I think we should drop the unique queries count unless querylist is also on Paul ----- Original Message ----- From: "John Reese" <jr...@le...> To: "Paul Richards" <pa...@ma...>, "developer discussions" <man...@li...> Sent: Friday, May 1, 2009 8:26:26 PM GMT +00:00 GMT Britain, Ireland, Portugal Subject: Logging DB Queries Paul, I've just hit upon a problem with how we handle db query logging. It seems that even with $g_show_queries_list = OFF, Mantis will still log every database query made, even though (IMO) the data is not necessary to keep. This problem crops up during pages that make a lot of database queries, and ends causing an OOM issue. This could be the problem that Daryn was having with your dates schema upgrade, and I personally hit it with some extended processing and importing pages that I'm developing in plugins for my employer. Is there any sane reason that we should be logging all these queries if we're not going to show them? I know I could just explicitly turn off the query logging for these pages, but I don't like that solution as it seems kludgy, and I'd prefer that the db_api just be smart enough to discard queries if it's not actually going to be displaying them... Cheers -- John Reese LeetCode.net |