From: <chr...@td...> - 2005-10-02 17:04:50
|
Hey all, I finally found your project this last week and got the code from CVS on Thursday(?), and I tried out a game and then made a lot of changes. I don't especially like mailing lists (is this one high-traffic?), but I would like to know if there is any interest, and if so what I need to do to get these changes into your codebase. In particular I'm asking because the code seems to have some very particular coding standards which I didn't necessarily follow, sometimes in the hopes of making things faster. And you also have some very clean code (if jumbled conditionals) which I don't want to step on. I used Eclipse 3.0 with Java 1.4.2_02 for the current changse. Also, a couple changes are more on the draft-level because I didn't want to put too much time in if y'all just rejected me :) Anyways, over the last 24 hours I've done the following: Colony Panel 1. Added the colony name to the bottom (I'll move it to the top if you accept this change), curently a 24-point black bold font. 2. Warehouse box now shows the Goods Icon, and below it are the current amount and change amount (vertical stack) 3. Hammers now has a +X if it is being worked on, eg. 16+3/52 4. Buildings section now has a column indicating what it produces (and what it takes in, if any), but this looks a little crowded and the build names always trail off to "..." - I did put the full names in the tooltiptext though. 5. Numbers show up on Goods in the TilePanel and in the Food/Crosses section and the Buildings section (production) It is based on a new inner class UserPreference - currently only defaults (set low how I like them), but should be extracted and associated with a menu/options dialog. Random 6. Fixed one or two spelling things in the properties file 7. Added to View menu option for displaying tile resources (current) They don't draw perfectly, and are obscurred by units, but it is a decent start. Good/Bad? Also draws those details in the Colony screen's TilePanel. 8. I did several minor coding changes: 8.1. Moved at least 2 major arrays outside of the methods they were in, that should improve performance. 8.2. Filtered out some large (and small) conditionals from if statements to be more understandable - I think my naming also makes it obvious that they should be methods on other objects, too. 8.3. Made some extra methods for 1-8 and a new class (needs a name): GoodsLabelTall 9. Added a draft Founding Fathers status panel Please let me know both if you want/how to integrate these changes, and how I can better add/fix stuff in the future. Thanks! -Chris |