Re: [Freecol-developers] Removing units from active panels

[Michael P. <mp...@co...>]

On Sat, 30 May 2009 17:57:41 Michael Burschik wrote:
> The whole transfer of labels between different panels is an ugly mess.
> I'm not sure it has improved since I tried to use property change
> listeners rather than special case handlers for different source panels,
> etc. This should really be cleaned up (somehow).

What I need here is a word to convey strong endorsement of this statement 
simultaneous with running away and hiding.  An ugly mess indeed.

> I think I have fixed
> the cases you describe,

For which much thanks.  I was dreading another encounter with 
DefaultTransferHandler.

> but on the other hand I noticed that dragging a
> unit from a building to the outside colony panel doesn't work reliably.
> Sometimes the unit is removed from the building, sometimes it isn't.

I am regularly seeing duplicated unit labels, with the outside colony panel 
the main offender but also the cargo panel/s.  Close/reopen always fixes the 
problem so I have been ignoring it for now.

> The big question is how can this situation be improved? Should all the
> logic be put in the transfer handler, rather than being scattered all
> over the place? In this case, it should be possible to reduce most of
> the panels to simple JPanels without any special logic.

That would certainly be an improvement.  It may not be particularly OO, but a 
whacking big crossbar on source and destination panel types would be less 
confusing.  Its either that or the dual of trying to chase all the 
"instanceof" logic out of the transfer handler.  Neither looks easy.

Cheers,
Mike Pope