From: Christiaan H. <cmh...@gm...> - 2009-06-30 23:39:36
|
On Jul 1, 2009, at 1:09 AM, Maxwell, Adam R wrote: > Last time I tried to fix that leak, I couldn't figure out what was > going on > with the copy of name; somehow it must end up in the bt_name > structure, > since the obvious fix of calling free() before exiting causes a crash. > Calling free() immediately before the first exit point is almost > certainly > correct, but I think I left it alone since it's such a small leak. Yea, I think it's only a single char over the whole launch time, as it only happens for the emptyAuthor. The annoying thing is that 'name' is duplicated in bt_split_name(), but it's assigned to the bt_name struct in find_tokens(). The line that's commented out in that functions would actually be the correct place to use strdup, but using it would require a few other changes as well. Christiaan > There's another leak noted in bt_postprocess_value(); I've seen it > under > some conditions, but was never able to fix it. It's so small that > it really > doesn't matter from the standpoint of memory overhead. > > On 06/30/09 10:07, "Christiaan Hofman" <cmh...@gm...> wrote: > >> OK, I found the problem. When the name is an empty string, the copied >> characters in 'name' are leaked. Memory management is really opaque >> in that >> file. >> >> Christiaan >> >> On Tue, Jun 30, 2009 at 6:00 PM, Christiaan Hofman <cmh...@gm... >> > wrote: >>> I am getting a consistent leak in btparse. Leaks points to line >>> 808 in >>> names.c, in bt_split_name(). I really don't understand the memory >>> management >>> here. AFAIK strdup allocates memory, but I don't see the memory >>> allocated in >>> this line being freed anywhere. However adding a free is not >>> correct. Anyone >>> has an idea? >>> >>> Christiaan >>> >> >> >> >> ------------------------------------------------------------------------------ >> >> _______________________________________________ >> Bibdesk-develop mailing list >> Bib...@li... >> https://lists.sourceforge.net/lists/listinfo/bibdesk-develop > > > ------------------------------------------------------------------------------ > _______________________________________________ > Bibdesk-develop mailing list > Bib...@li... > https://lists.sourceforge.net/lists/listinfo/bibdesk-develop |