webadmin-devel — The webmin development mailing list

Re: [webmin-devel] [feature request] new password type for modules' configuration

[Martin M. <mm...@me...>]

Hi,

Jamie Cameron wrote:

> You'll have to ask the module author who requested this feature about
> this one :-)  However, none of the core Webmin modules will use this new
> type, for the reasons you mentioned ..

On behalf of the module writer (wbmtranslator):

There is a new module configuration possible to send out eMails to 
tra...@we... using smtp-auth.

If we would use type 12 the configuration would look like

smtp-password: [ ] Leave as is [ ] this one _____________

This would be confusing in this area, because the translator may did not 
know what "leave as is" means. If we would use the "Read Mail" 
functionality it would definetely make more sense, because we could tell 
it to the customer:

######################################################################

Use ReadMail-Module-Settings for sending eMails [X] Yes, default [ ] No

smtp-login   : ________________
smtp-password: [ ] Leave as is [ ] this one _____________

This has been extracted from the currently installed Read-Mail-Module. 
If you change the password here, the smtp-password would be changed for 
the Read-Mail-Module as well. If you do not want to use the Settings of 
the Read-Mail-Module, please deselect it in this module configuration, 
save this setting once. Then come back here and type in your settings 
which would only be suitable for this particular area.

[Setting to No] - [Save] - [Coming back]

Use ReadMail-Module-Settings for sending eMails [ ] Yes, default [X] No

smtp-login   : ________________
smtp-password: ________________
Please indicate a smtp-login and -password for this particular area.

######################################################################

Of course this is a design study only :-)


bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/	| Webbased Administration Tool for
http://webmin.mamemu.de/| Unixoid Systems :-)
Official Webmin/Usermin Translation Co-Ordinator 2003/2004
######################################################################

Re: [webmin-devel] [feature request] new password type for modules' configuration

[<ra...@si...>]

> > BTW, I am trying to understand why, as a configuration
> > option, the current mechanism isn't suitable, as the configuration isn't
> > intended to be called on each invocation of the module?
>
> You'll have to ask the module author who requested this feature about
> this one :-)  However, none of the core Webmin modules will use this new
> type, for the reasons you mentioned ..
>

  I was hoping to get a response on this from the module author(s), but to
make things clean, this is an official request.  Given the interesting
programatic and security issues with this feature, as well as previous
posts on the subject, why cannot the current mechanism be used, and if it
is just because the form is confusing, what would make the form clear?

  I would hate to have an insecure feature implemented when all that was
needed was better language or structure.

  Cheers!


	---- Randy

Re: [webmin-devel] [feature request] new password type for modules' configuration

[Jamie C. <jca...@we...>]

On Mon, 2004-10-18 at 12:42, ra...@si... wrote:
> On Sun, 18 Oct 2004, Jamie Cameron wrote:
> 
> > On Mon, 2004-10-18 at 01:03, Emmanuel Saracco wrote:
> > > hi jamie,
> > >
> > > could it be possible to have a simple password field for modules
> > > configuration section (other than 12, which is sometime confusing for
> > > the user).
> > >
> > > "simple", that means: only a <input type="password" name="var"
> > > value="">, and nothing else (no radios for exemple :-) ).
> > >
> > > is this type already exist (I did not see it)?
> >
> > I can't see any harm in a new config type 16 being added which just
> > displays a password field, with no 'dont change' option. However, I
> > would recommend the use of type 12 in general for password fields, as it
> > is a little more secure as the current password is not included in the
> > HTML..
> >
> >  - Jamie
> >
> 
>   I know that this is mostly just my opinion, but would think that a prime
> reason would be how would the module know that the password has been
> changed legitimately, and not ignored and inadvertantly left blank.  And a
> significant second would be that if it was passed as part of the
> configuration, then it isn't very secure as it would be part of the form,
> and then easily seen (just display the source).
> 
>   As much as it seems like there is value, I personally think that it
> would be a better solution to identify what is confusing, and make it no
> longer confusing.  BTW, I am trying to understand why, as a configuration
> option, the current mechanism isn't suitable, as the configuration isn't
> intended to be called on each invocation of the module?

You'll have to ask the module author who requested this feature about
this one :-)  However, none of the core Webmin modules will use this new
type, for the reasons you mentioned ..

>   However, if there is a new type, I would also like to request that this
> be identified as an insecure type, and allow the core to disallow any
> insecure types, or turn them into a (more) secure type (i.e. change a 16
> into a 12).

I will add support for a hidden option in /etc/webmin/config called
config_16_insecure , which if set to 1 will convert all type 16 inputs
into type 12.

 - Jamie

Re: [webmin-devel] [feature request] new password type for modules' configuration

[<ra...@si...>]

On Sun, 18 Oct 2004, Jamie Cameron wrote:

> On Mon, 2004-10-18 at 01:03, Emmanuel Saracco wrote:
> > hi jamie,
> >
> > could it be possible to have a simple password field for modules
> > configuration section (other than 12, which is sometime confusing for
> > the user).
> >
> > "simple", that means: only a <input type="password" name="var"
> > value="">, and nothing else (no radios for exemple :-) ).
> >
> > is this type already exist (I did not see it)?
>
> I can't see any harm in a new config type 16 being added which just
> displays a password field, with no 'dont change' option. However, I
> would recommend the use of type 12 in general for password fields, as it
> is a little more secure as the current password is not included in the
> HTML..
>
>  - Jamie
>

  I know that this is mostly just my opinion, but would think that a prime
reason would be how would the module know that the password has been
changed legitimately, and not ignored and inadvertantly left blank.  And a
significant second would be that if it was passed as part of the
configuration, then it isn't very secure as it would be part of the form,
and then easily seen (just display the source).

  As much as it seems like there is value, I personally think that it
would be a better solution to identify what is confusing, and make it no
longer confusing.  BTW, I am trying to understand why, as a configuration
option, the current mechanism isn't suitable, as the configuration isn't
intended to be called on each invocation of the module?

  However, if there is a new type, I would also like to request that this
be identified as an insecure type, and allow the core to disallow any
insecure types, or turn them into a (more) secure type (i.e. change a 16
into a 12).


	---- Randy

Re: [webmin-devel] good security practice for developping modules ?

[Jamie C. <jca...@we...>]

On Mon, 2004-10-18 at 03:15, kardiac wrote:
> Hi,
> 
> 	I am not really a developer (so my question is maybe obvious) but i 
> develop actually a webmin module. And i would know if it has anywhere a 
> document describing how securing a webmin module or some good practice 
> to respect?
> I have too read (in perl cookbook by example) than for  writing a secure 
> perl CGI it's preferable to use "use strict;" and -w and -T flag on #! 
> line (at minimum).
> I have check in  webmin modules and i have see it didn't use that and i 
> don't know why. It's because webmin work with ACL and if user has ACL 
> rights then no need for enforcing security in modules ?

The biggest security concern is allowing un-trusted users access to a
module with limited privileges. If you module has an acl_security.pl
script that allows individual Webmin logins to be given different access
rights, you need to be very careful in your code that restricted users
cannot exceed their granted privileges. This means that all form input
has to be carefully checked, to ensure that it cannot be manipulated to
access arbitrary files on the system or run commands.

For example, if your module contained a form that allowed some file in
/usr/local/blah to be deleted, code like this could be dangerous :

&ReadParse();
system("rm -f /usr/local/blah/$in{'file'}");

Because a filename with .. in it could be used to delete any file on the
system. And a filename with 

better to use code like this :

&ReadParse();
$in{'file'} !~ /\.\./ && $in{'file'} !~ /\// || &error("Invalid
filename");
unlink("/usr/local/blah/$in{'file'}");

 - Jamie

Re: [webmin-devel] [feature request] new password type for modules' configuration

[Jamie C. <jca...@we...>]

On Mon, 2004-10-18 at 01:24, Martin Mewes wrote:
> Hi Emmanuel, hi Jamie
> 
> Emmanuel Saracco wrote:
> 
> > "simple", that means: only a <input type="password" name="var"
> > value="">, and nothing else (no radios for exemple :-) ).
> 
> This problem comes up in the module configurationof the current 
> wbmtranslator as it is able to use smtp-auth to a remote system.
> 
> The current "12" shows something like this ...
> 
> [ ] no change [ ] set to ___________________
> 
> which is really confusing, because it does not make sense i this 
> particular section.
> 
> What wbmtranslator needs is just something like
> 
> SMTP-Password: ____________________
> 
> or to be just able to read the settings from the "Read Mail"-Module.
> 
> Jamie, can you please point us into the direction for the inclusion of 
> the "Read Mail"-Module? This would make things easier I think.

The best way for another module to send email is to use code like this :

&foreign_require("mailboxes", "mailboxes-lib.pl");
$mail = { 'headers' => [ [ 'From', 'fo...@ba...' ],
			 [ 'To', $destination ],
			 [ 'Subject', 'Your subject here' ]
			 ],
	  'attach' => [ { 'headers' => [ [ 'Content-type', 'text/html' ]
				       ], 
			  'data' => 'Message body here' } ]
	};
&mailboxes::send_mail($mail);

This will make use of the Read User Mail module's configuration for
sending, including any SMTP server or authentication set on its Module
Config page.

 - Jamie

Re: [webmin-devel] [feature request] new password type for modules' configuration

[Jamie C. <jca...@we...>]

On Mon, 2004-10-18 at 01:03, Emmanuel Saracco wrote:
> hi jamie,
> 
> could it be possible to have a simple password field for modules
> configuration section (other than 12, which is sometime confusing for
> the user).
> 
> "simple", that means: only a <input type="password" name="var"
> value="">, and nothing else (no radios for exemple :-) ).
> 
> is this type already exist (I did not see it)?

I can't see any harm in a new config type 16 being added which just
displays a password field, with no 'dont change' option. However, I
would recommend the use of type 12 in general for password fields, as it
is a little more secure as the current password is not included in the
HTML..

 - Jamie

Re: [webmin-devel] [feature request] new password type for modules' configuration

[<ra...@si...>]

On Sun, 17 Oct 2004, Martin Mewes wrote:

> Hi Emmanuel, hi Jamie
>
> Emmanuel Saracco wrote:
>
> > "simple", that means: only a <input type="password" name="var"
> > value="">, and nothing else (no radios for exemple :-) ).
>
> This problem comes up in the module configurationof the current
> wbmtranslator as it is able to use smtp-auth to a remote system.
>
> The current "12" shows something like this ...
>
> [ ] no change [ ] set to ___________________
>
> which is really confusing, because it does not make sense i this
> particular section.
>
> What wbmtranslator needs is just something like
>
> SMTP-Password: ____________________
>
> or to be just able to read the settings from the "Read Mail"-Module.
>
> Jamie, can you please point us into the direction for the inclusion of
> the "Read Mail"-Module? This would make things easier I think.
>
>
> bis dahin - kind regards
>
> Martin Mewes
>

  No, I think that it still makes sense because of the reasons I outlined
in my previous post.  The password that might be used in "Module
Configuration"  is saved in the current module's configuration space so it
can be used when the module is run.  The module still needs to know that
the user intended to change the password.

  If the password is only relevant in this current session, then it might
be more practical to have a way for the user to enter a password upon
entering the module, or build it into the ACL list so it can be different
for each user.

  Or even thinking about this some while writting this message, would be a
password setting that can be different for each webmin user, and would be
changed based on the $remote_user value when the module configuration is
called (this might be the better feature request - and something that I
have thought about for the MySQL module for a while, maybe I can
prototype this feature for this module).


	---- Randy

Re: [webmin-devel] [feature request] new password type for modules' configuration

[<ra...@si...>]

On Sun, 17 Oct 2004, Emmanuel Saracco wrote:

> hi jamie,
>
> could it be possible to have a simple password field for modules
> configuration section (other than 12, which is sometime confusing for
> the user).
>
> "simple", that means: only a <input type="password" name="var"
> value="">, and nothing else (no radios for exemple :-) ).
>
> is this type already exist (I did not see it)?
>
> thanks,
>
> bye
>

If I am reading this correctly (and let me know if this is wrong), that
the request is that there be a line in the config.info like:
   pass=Password,<some_number_that_is_not_12>

that will generate a line in the module's configuration page like:
   Password	[   <blank text>    ]

instead of (if the number 12 is used above):
   Password     [X] Don't Change    [ ] Set to  [   <blank text>    ]


Besides the potential security issues, it makes it extremely difficult
to differentiate between the following:
     I didn't want to change the password
     I didn't want to change the password, but typed something there
           accidentally
     I intended to change the password to the NULL string
     I intended to change the password to this new value
     I didn't want to change the password, but was unsure and typed
           the original password which might reset the expiration date
     I wanted to update the expiration date, but not change the
           password, so I entered the same password

With the radio buttons, it comes down to a simple case of:
     I didn't want to change the password, so ignore anything in the
           password box.
or
     I intended to change the password, so use whatever is in the
           password box, even if it is NULL or the same as the previous
           password.


  The best answer is to understand the confusion, and change the way this
line is displayed so that is is not confusing.  So given that it is
important to know if the user intended to change/set a password, what
wording or display organization do you think would make it less confusing,
or (hopefully) totally undestandable?


  Cheers!

	---- Randy

Re: [webmin-devel] good security practice for developping modules ?

[kardiac <kar...@kr...>]

Martin Mewes wrote:

> Hi,
>
> kardiac wrote:
>
>> Martin Mewes wrote:
>>
>>> If you need help in translating this module to at least german, 
>>> please come back to me :-)
>>
>> Thanks, i will remember it if i finish this module (i hope :-)
>
>
> Can you please give me a hint on what kind of module your are working 
> on? Maybe there is something in place and it may would be more easier 
> for you to join a particular development instead of reinventing the 
> wheel.
>
>> I will like some input on forged values in form submission too. I use 
>> that actually:
>>
>> unless ($value =~ m#^([\w.-_]+)$#) {                     error( 
>> "$value has invalid characters.\n");
>> }
>>
>> It's enough ? Best way to do it exist ?
>
>
> I am just a translator and a lousy programmer, so I may leave this to 
> the coders here.
>
> bis dahin - kind regards
>
> Martin Mewes
>
I work on a module for Cyrus-imap. I have started from IMAPv4 Server 
module but i have mostly completely rewrited it. I needed 
internationalization support (French specially) and more 
features(support for different hierarchy separator, cascading delete, 
editing configuration file...) . 
I don't needed to rewrite all but i have a lot of fun to do it :-). 
Actually internationalization and  hierarchy separator are ok. I have 
changed to Cyrus::IMAP::Admin instead NET::IMAP::Admin perl module  ( 
maybe a not so good idea but i will see now).

kind regards

Kardiac

Re: [webmin-devel] good security practice for developping modules ?

[Martin M. <mm...@me...>]

Hi,

kardiac wrote:

> Martin Mewes wrote:
>> If you need help in translating this module to at least german, please 
>> come back to me :-)
> Thanks, i will remember it if i finish this module (i hope :-)

Can you please give me a hint on what kind of module your are working 
on? Maybe there is something in place and it may would be more easier 
for you to join a particular development instead of reinventing the wheel.

> I will like some input on forged values in form submission too. I use 
> that actually:
> 
> unless ($value =~ m#^([\w.-_]+)$#) {                     error( "$value 
> has invalid characters.\n");
> }
> 
> It's enough ? Best way to do it exist ?

I am just a translator and a lousy programmer, so I may leave this to 
the coders here.

bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/	| Webbased Administration Tool for
http://webmin.mamemu.de/| Unixoid Systems :-)
Official Webmin/Usermin Translation Co-Ordinator 2003/2004
######################################################################

Re: [webmin-devel] good security practice for developping modules ?

[kardiac <kar...@kr...>]

Martin Mewes wrote:

> Hi,
>
> kardiac wrote:
>
>>     I am not really a developer (so my question is maybe obvious) but 
>> i develop actually a webmin module. And i would know if it has 
>> anywhere a document describing how securing a webmin module or some 
>> good practice to respect?
>
>
> If you need help in translating this module to at least german, please 
> come back to me :-)

Thanks, i will remember it if i finish this module (i hope :-)

>
>> I have too read (in perl cookbook by example) than for  writing a 
>> secure perl CGI it's preferable to use "use strict;" and -w and -T 
>> flag on #! line (at minimum).
>
>
> As always this goes together, that someone is preferring what you 
> wrote and others may say these things are useless. I think it is 
> always the maintainers choice on how he is developing things.
>
> I remember someone who did harden a webmin-module and gave this back 
> to the maintainer, so do not let me be someone who stops you in this ;-)
>
> bis dahin - kind regards
>
> Martin Mewes
>
Ok i see. It's not really restraining ;-)

I will like some input on forged values in form submission too. I use 
that actually:

unless ($value =~ m#^([\w.-_]+)$#) {                  
    error( "$value has invalid characters.\n");
}

It's enough ? Best way to do it exist ?

I have already said but all advices welcome :-) 

Kardiac

Re: [webmin-devel] good security practice for developping modules ?

[Martin M. <mm...@me...>]

Hi,

kardiac wrote:

>     I am not really a developer (so my question is maybe obvious) but i 
> develop actually a webmin module. And i would know if it has anywhere a 
> document describing how securing a webmin module or some good practice 
> to respect?

If you need help in translating this module to at least german, please 
come back to me :-)

> I have too read (in perl cookbook by example) than for  writing a secure 
> perl CGI it's preferable to use "use strict;" and -w and -T flag on #! 
> line (at minimum).

As always this goes together, that someone is preferring what you wrote 
and others may say these things are useless. I think it is always the 
maintainers choice on how he is developing things.

I remember someone who did harden a webmin-module and gave this back to 
the maintainer, so do not let me be someone who stops you in this ;-)

bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/	| Webbased Administration Tool for
http://webmin.mamemu.de/| Unixoid Systems :-)
Official Webmin/Usermin Translation Co-Ordinator 2003/2004
######################################################################

[webmin-devel] good security practice for developping modules ?

[kardiac <kar...@kr...>]

Hi,

	I am not really a developer (so my question is maybe obvious) but i 
develop actually a webmin module. And i would know if it has anywhere a 
document describing how securing a webmin module or some good practice 
to respect?
I have too read (in perl cookbook by example) than for  writing a secure 
perl CGI it's preferable to use "use strict;" and -w and -T flag on #! 
line (at minimum).
I have check in  webmin modules and i have see it didn't use that and i 
don't know why. It's because webmin work with ACL and if user has ACL 
rights then no need for enforcing security in modules ?

Thanks by advance for all advice,

Kardiac

Re: [webmin-devel] [feature request] new password type for modules' configuration

[Martin M. <mm...@me...>]

Hi Emmanuel, hi Jamie

Emmanuel Saracco wrote:

> "simple", that means: only a <input type="password" name="var"
> value="">, and nothing else (no radios for exemple :-) ).

This problem comes up in the module configurationof the current 
wbmtranslator as it is able to use smtp-auth to a remote system.

The current "12" shows something like this ...

[ ] no change [ ] set to ___________________

which is really confusing, because it does not make sense i this 
particular section.

What wbmtranslator needs is just something like

SMTP-Password: ____________________

or to be just able to read the settings from the "Read Mail"-Module.

Jamie, can you please point us into the direction for the inclusion of 
the "Read Mail"-Module? This would make things easier I think.


bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/	| Webbased Administration Tool for
http://webmin.mamemu.de/| Unixoid Systems :-)
Official Webmin/Usermin Translation Co-Ordinator 2003/2004
######################################################################

[webmin-devel] [feature request] new password type for modules' configuration

[Emmanuel S. <esa...@us...>]

hi jamie,

could it be possible to have a simple password field for modules
configuration section (other than 12, which is sometime confusing for
the user).

"simple", that means: only a <input type="password" name="var"
value="">, and nothing else (no radios for exemple :-) ).

is this type already exist (I did not see it)?

thanks,

bye

[webmin-devel] [FAQ] Webmin/Usermin/Virtualmin - On the fly updates

[Martin M. <mm...@me...>]

######################################################################

History:
--------

15.10.2004
Usermin-Development-Version 1.093 released

13.10.2004
Virtualmin-Development-Version 2.31 released

11.10.2004
Webmin-Development-Version 1.163 released

07.10.2004
Virtualmin-Version 2.30 released as stable

06.09.2004
Webmin-Version 1.160 released as stable
Usermin-Version 1.090 released as stable

######################################################################

Current Stable Release for Webmin is 1.160
http://webmin.mamemu.de/devel/tarballs/webmin-1.160.tar.gz
http://webmin.mamemu.de/devel/tarballs/webmin-1.160-1.noarch.rpm
http://webmin.mamemu.de/devel/tarballs/webmin-1.160-minimal.tar.gz

Current Development Release for Webmin is 1.163
http://webmin.mamemu.de/devel/tarballs/webmin-1.163.tar.gz

Current Stable Release for Usermin is 1.090
http://webmin.mamemu.de/devel/tarballs/usermin-1.090.tar.gz
http://webmin.mamemu.de/devel/tarballs/usermin-1.090-1.noarch.rpm

Current Development Release for Usermin is 1.093
http://webmin.mamemu.de/devel/tarballs/usermin-1.093.tar.gz

Current Stable Release for VirtualMin is 2.30
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.30.wbm.gz

Current Development Release for VirtualMin is 2.31
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.31.wbm.gz
	
######################################################################

If you are anoyed by these post you can filter this with procmail
scanning for

X-Webmin: update

in the header.

bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/		| Webbased Administration Tool for
http://webmin.mamemu.de/	| Unixoid Systems :-)
Official Webmin/Usermin Translation Co-Ordinator 2003/2004
######################################################################

Re: [webmin-devel] Backup-Config-Module

[Martin M. <mm...@me...>]

Hi Jamie,

Jamie Cameron wrote:

>>>Undefined subroutine &main::foreign_defined called at ./backup-config-lib.pl
>>>line 233.

> That function should be in web-lib.pl in Webmin version 1.163 ..

Which is installed ;-)
Curiously after reinstallation the error goes to /dev/null.
Hmm ...

btw ... you did not attach any images in that module ;-)


bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/	| Webbased Administration Tool for
http://webmin.mamemu.de/| Unixoid Systems :-)
Official Webmin/Usermin Translation Co-Ordinator 2003/2004
######################################################################

Re: [webmin-devel] Backup-Config-Module

[Jamie C. <jca...@we...>]

On Thu, 2004-10-14 at 16:34, Martin Mewes wrote:
> Hi all,
> 
> Cron Daemon wrote ..
> > Undefined subroutine &main::foreign_defined called at ./backup-config-lib.pl
> > line 233.
> 
> ???
> 
> This is new to me, because after the last manually test everything worked out great.

That function should be in web-lib.pl in Webmin version 1.163 ..

 - Jamie

[webmin-devel] Backup-Config-Module

[Martin M. <mm...@me...>]

Hi all,

Cron Daemon wrote ..
> Undefined subroutine &main::foreign_defined called at ./backup-config-lib.pl
> line 233.

???

This is new to me, because after the last manually test everything worked out great.

bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/	| Webbased Administration Tool for
http://webmin.mamemu.de/| Unixoid Systems :-)
Official Webmin/Usermin Translation Co-Ordinator 2003/2004
######################################################################

RE: [webmin-devel] Sorting The Order of Modules in a Category

[Michael W. <mw...@ai...>]

Found Another Way...As part of the Description I can put an HTML Comment
which isn't displayed, but is used for sorting, so in module.info my desc=
line looks something like:

desc=<!--00-->Module Doing This


It's a cheap trick but it works.

-----Original Message-----
From: web...@li...
[mailto:web...@li...]On Behalf Of Jamie
Cameron
Sent: Tuesday, October 12, 2004 5:54 PM
To: web...@li...
Subject: Re: [webmin-devel] Sorting The Order of Modules in a Category


On Wed, 2004-10-13 at 03:45, Michael Wray wrote:
> Aside from hacking my borrowed theme, is there a way to control the order
> Modules are listed in aside from the Display Name.  It appears to me that
> the Display Name is what they are sorted on in every Theme I've used, and
I
> would prefer they be sorted on some other item, such as the actual Module
> Name, so that I can control what order they appear in in the same fashion
I
> do my Categories.

The only way to do this is to modify the theme code..
It would be a trivial change though, something like

@mods = &get_all_module_infos();
@mods = sort { $a->{'dir'} cmp $b->{'dir'} } @mods;

 - Jamie




-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
-
Forwarded by the Webmin development list at web...@we...
To remove yourself from this list, go to
http://lists.sourceforge.net/lists/listinfo/webadmin-devel

[webmin-devel] [FAQ] Webmin/Usermin/Virtualmin - On the fly updates

[Martin M. <mm...@me...>]

######################################################################

History:
--------

13.10.2004
Virtualmin-Development-Version 2.31 released

11.10.2004
Webmin-Development-Version 1.163 released

07.10.2004
Virtualmin-Version 2.30 released as stable

21.09.2004
Usermin-Development-Version 1.091 released

06.09.2004
Webmin-Version 1.160 released as stable
Usermin-Version 1.090 released as stable

######################################################################

Current Stable Release for Webmin is 1.160
http://webmin.mamemu.de/devel/tarballs/webmin-1.160.tar.gz
http://webmin.mamemu.de/devel/tarballs/webmin-1.160-1.noarch.rpm
http://webmin.mamemu.de/devel/tarballs/webmin-1.160-minimal.tar.gz

Current Development Release for Webmin is 1.163
http://webmin.mamemu.de/devel/tarballs/webmin-1.163.tar.gz

Current Stable Release for Usermin is 1.090
http://webmin.mamemu.de/devel/tarballs/usermin-1.090.tar.gz
http://webmin.mamemu.de/devel/tarballs/usermin-1.090-1.noarch.rpm

Current Development Release for Usermin is 1.091
http://webmin.mamemu.de/devel/tarballs/usermin-1.091.tar.gz

Current Stable Release for VirtualMin is 2.30
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.30.wbm.gz

Current Development Release for VirtualMin is 2.31
http://webmin.mamemu.de/download/virtualmin/virtual-server-2.31.wbm.gz
	
######################################################################

If you are anoyed by these post you can filter this with procmail
scanning for

X-Webmin: update

in the header.

bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/		| Webbased Administration Tool for
http://webmin.mamemu.de/	| Unixoid Systems :-)
Official Webmin/Usermin Translation Co-Ordinator 2003/2004
######################################################################

Re: [webmin-devel] Backup Configuration Module

[Jamie C. <jca...@we...>]

On Wed, 2004-10-13 at 16:23, Martin Mewes wrote:
> Dear Jamie,
> 
> this is what happens when I try to invoke the Backup Module for Configuration Data.
> 
> > Fehler
> > -----
> > require bind8/backup_config.pl failed : <pre>syntax error at /usr/libexec/webmin/bind8/backup_config.pl
> > line 61, near ") {"
> > syntax error at /usr/libexec/webmin/bind8/backup_config.pl line 65, near
> > "}"
> > </pre>
> > -----
> 
> Looking at the code
> 
> # post_restore(&files)
> # Called after the files are restored from a backup
> sub post_restore
> {
> local $pidfile = &get_pid_file();
> if (&check_pid_file(&make_chroot($pidfile)) {
>         return &restart_bind();
>         }
> return undef;
> }
> 
> I think it should be
> 
> if (&check_pid_file(&make_chroot($pidfile))) {
> 
> because you open three '(' but only closing two ')'
> 
> I manually changed the code and after a test at my place everything works ok now.

Thanks for pointing that out .. I'll fix it for the next development
release.

 - Jamie

[webmin-devel] Backup Configuration Module

[Martin M. <mm...@me...>]

Dear Jamie,

this is what happens when I try to invoke the Backup Module for Configuration Data.

> Fehler
> -----
> require bind8/backup_config.pl failed : <pre>syntax error at /usr/libexec/webmin/bind8/backup_config.pl
> line 61, near ") {"
> syntax error at /usr/libexec/webmin/bind8/backup_config.pl line 65, near
> "}"
> </pre>
> -----

Looking at the code

# post_restore(&files)
# Called after the files are restored from a backup
sub post_restore
{
local $pidfile = &get_pid_file();
if (&check_pid_file(&make_chroot($pidfile)) {
        return &restart_bind();
        }
return undef;
}

I think it should be

if (&check_pid_file(&make_chroot($pidfile))) {

because you open three '(' but only closing two ')'

I manually changed the code and after a test at my place everything works ok now.

bis dahin - kind regards

Martin Mewes

-- 
######################################################################
http://www.webmin.com/	| Webbased Administration Tool for
http://webmin.mamemu.de/| Unixoid Systems :-)
Official Webmin/Usermin Translation Co-Ordinator 2003/2004
######################################################################

Re: [webmin-devel] Sorting The Order of Modules in a Category

[Jamie C. <jca...@we...>]

On Wed, 2004-10-13 at 03:45, Michael Wray wrote:
> Aside from hacking my borrowed theme, is there a way to control the order
> Modules are listed in aside from the Display Name.  It appears to me that
> the Display Name is what they are sorted on in every Theme I've used, and I
> would prefer they be sorted on some other item, such as the actual Module
> Name, so that I can control what order they appear in in the same fashion I
> do my Categories.

The only way to do this is to modify the theme code..
It would be a trivial change though, something like

@mods = &get_all_module_infos();
@mods = sort { $a->{'dir'} cmp $b->{'dir'} } @mods;

 - Jamie