Menu
▾
▴
tsheetx-developers — Timesheet Next Gen - Developer's mailing list
You can subscribe to this list here.
| 2008 |
Jan
|
Feb
(1) |
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
(3) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(1) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2009 |
Jan
(1) |
Feb
|
Mar
|
Apr
(4) |
May
(3) |
Jun
|
Jul
(1) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2010 |
Jan
|
Feb
|
Mar
|
Apr
(6) |
May
(10) |
Jun
(1) |
Jul
(3) |
Aug
(19) |
Sep
(52) |
Oct
(5) |
Nov
(15) |
Dec
|
| 2011 |
Jan
|
Feb
(65) |
Mar
(53) |
Apr
(55) |
May
(37) |
Jun
|
Jul
(1) |
Aug
(17) |
Sep
(28) |
Oct
(7) |
Nov
|
Dec
|
| 2012 |
Jan
(3) |
Feb
|
Mar
(2) |
Apr
|
May
(4) |
Jun
(3) |
Jul
(1) |
Aug
|
Sep
|
Oct
(1) |
Nov
(1) |
Dec
(1) |
| 2013 |
Jan
|
Feb
|
Mar
(1) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(3) |
| 2014 |
Jan
|
Feb
(2) |
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2015 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(1) |
|
From: Scott M. <sco...@gm...> - 2010-07-12 15:00:27
|
Do we have any graphic artist types that might be willing to submit a favicon or two for the Timesheet Next Gen project? If so, please send entries to this email list, thanks! -Scott |
|
From: Scott M. <sco...@gm...> - 2010-06-22 22:47:12
|
Revision 123: I've added the fix in which projects added under the default client weren't picked up correctly when using the daily forms. I also added the working excel export functionality to the project and user reports, and fixed the export on the user summary report to use decimal number of hours for the excel spreadsheet so calculations could be done more easily on the resulting spreadsheets. -Scott |
|
From: Scott M. <sco...@gm...> - 2010-05-25 19:47:04
|
I added an option within the task_maint.php file that allows those with task editing options to quickly assign all tasks to all members of each project. We allow every user to see and use every task that is defined under the projects, and suspect that many others may do the same. Do not use this script if you need to keep certain users from seeing certain tasks under projects of which they are members; you'll probably want to lock down which users can edit tasks so someone else doesn't use that script either. Introduced in SVN Revision 119 -Scott |
|
From: Scott M. <sco...@gm...> - 2010-05-25 19:38:27
|
In the bug tracking system, Markle wrote: I've taken a look at this and can't really get my head around it. I've made some changes to the files timesheet_face_part_1.inc timesheet_face_part_2.inc Which i've uploaded here. These changes soothe the problem but don't completely solve it. It involves removing one of the internal corner graphics. I've also attached, an image of how this looks when rendered in Google Chrome, I've circled the problem area of this "fix". buschbeck perhaps you can take it from here? The updates provided by Markle have been checked into SVN, revision 120 -Scott |
|
From: Scott M. <Sco...@pr...> - 2010-05-17 15:17:50
|
David, all, Peter Lazarus has reported an issue where the ending times are not displaying properly without a code modification. The code modification he's made will, however, break the ability of the system to calculate the correct amounts of time during a DST change. So, is this an isolated event or are others having the same issue? I am unable to replicate his exact problem, but have discovered that if the system's time zone info doesn't match the time zone info within the timesheet configuration, both the start and ending times are shifted an amount equal to the difference in those settings. Ideally, those settings shouldn't have to match, but I'm not quite sure how to go about fixing this problem, and I'm fairly certain it's not going to be simple or easy to solve. On the other hand, I'm admittedly feeling a bit off, so, I may not be thinking as clearly about the problem as I could. If Peter's issue is an isolated case, and we don't get a simple patch within the next day or so to fix the "non-matching timezone" issue, I would suggest that we make the existing trunk head in SVN the official 1.5.0 release. -Scott ________________________________ From: Scott Miller [mailto:Sco...@pr...] Sent: Wednesday, May 05, 2010 9:11 AM To: David Thompson; tsh...@li... Subject: Re: [Tsheetx-developers] TSNG Version 1.5.0 ready? I checked in a couple more minor fixes and changes yesterday. One issue was with the user summary report, where the 2nd bi-monthly ending date was set to 31 rather than calculated. And another change was to remove the "All Clients" drop down option on the clock on/off forms, and have those forms automatically select the first valid client/project/task for the user. A user selectable default would be nice, see the last paragraph below. I've not yet heard any bug reports from the forum poster who claimed the system was still "very buggy", and we've not run into any big issues yet; I rolled it into production last Friday evening, April 30th, 2010. So, I think it is very close at this point. I am still hopeful that someone else out there has installed it and is working with it to help us determine it is ready. So, if you're using it, please chime in. I'll suggest we make 1.5.0 official May 12th barring any big problems. On a separate note: I've been attempting to figure out how to allow the user to select a default client/project/task for the clock on/off forms, and also to have a default set of client/project/task/times for each day and/or week (daily, simple forms). But so far I've not been able to visualize an easy UI to make that happen. If anyone thinks they know what that should look like, I'm looking for guidance. Note that this functionality will not be something that makes it into 1.5.0. -Scott ________________________________ From: David Thompson [mailto:tom...@us...] Sent: Wednesday, May 05, 2010 12:46 AM To: tsh...@li... Subject: [Tsheetx-developers] TSNG Version 1.5.0 ready? What is the status of the 1.5.0 candidate, is it good enough to release? Opinions, please! ________________________________ Subject: RE: [Tsheetx-developers] Testing for TSNG Version 1.5.0 Date: Mon, 26 Apr 2010 17:09:22 -0500 From: Sco...@pr... To: tom...@us... CC: tsh...@li... Ok, I just finished checking in SVN revision 104. Since the initial check in which was, 94 if my notes are correct, several functionality "upgrades" have been introduced. You can peruse the "tracking" system at http://bugs.timesheetng.org <http://bugs.timesheetng.org/> to review the changes or look at the SVN comments at http://tsheetx.svn.sourceforge.net/viewvc/tsheetx/trunk. There have been some DB changes made between revisions 94 and 104, if you've upgraded to a previous 1.5.0 revision, and wish to upgrade to the latest, you can now execute the smallish php script: .update-1.5.0-beta.php from within the active website directory. It will make only those DB changes needed to get you current. Also, I promised to publish the list of things that have been fixed when I first checked it in, this document is now located within the new wiki hosted on sourceforge: https://sourceforge.net/apps/mediawiki/tsheetx/index.php?title=Main_Page If you've installed/upgraded to the new version, please let us know how things are going. -Scott L. Miller ________________________________ Hotmail: Powerful Free email with security by Microsoft. Get it now. <https://signup.live.com/signup.aspx?id=60969> |
|
From: Scott M. <sco...@gm...> - 2010-05-12 15:32:39
|
Hello all, In our bug tracking system, there is a report of the GUI not looking perfect in several browsers. If anyone reading this, has the skills to get the GUI to function correctly for multiple browsers, please send in patches to this email list. Thank you, -Scott |
|
From: Scott M. <sco...@gm...> - 2010-05-11 16:14:51
|
So, if I'm getting the correct message, the info in the database is correct,
but the ending date/time is mangled when printed? And from the info below,
the totals are correct (the greyish numbers), but the ending date/times are,
again, mucked up.
Here's the flow of what happens when the data is read:
1. If there is a valid duration, the ending times calculated from the
start time and the duration
2. the original end time is compared with the calculated end time. If
they don't agree, the calculated end time is written to the database.
3. If there's not a valid duration, the duration is calculated from the
beginning and ending times (this should only happen upon reading data that
was entered with a previous version of the Timesheet System) and that
duration is written to the database.
So, I'm going to guess that somewhere during the end time calculations, a
UTC to local timezone conversion is taking place. There is a debuglog.php
file that helps to debug things. Using it, will result in data being
written to a static file /tmp/php-debug.log. In, for instance, the file
user_action.php, you can find the following lines commented out:
require("debuglog.php");
$debug = new logfile();
$debug->write("status = \"$status\"
isActive=\"".$_REQUEST["isActive"]."\"\n");
I would suggest putting these lines within the fixStartEndDuration()
function to print out what the beginning times, ending times, and durations
are for each step within that routine to help narrow down exactly when this
incorrect conversion is happening.
Please report what you find out.
-Scott
On Tue, May 11, 2010 at 7:54 AM, Peter Lazarus <pal...@gm...> wrote:
> Scott,
> thanks for the comments. I have done a little further investigation today,
> and the results are stranger than previously reported.
>
> The times for the start_time and stop_time in the _times database are
> showing correctly. When I run the query get_time_records from common.inc
> the times and duration are also shown correctly, including the unix
> timestamps. (SELECT start_time AS start_time_str, end_time AS end_time_str
> , unix_timestamp( start_time ) AS start_stamp, unix_timestamp( end_time )
> AS end_stamp, duration FROM ts1_times) So that says to me that mysql is
> not stuffing up, nor is the start/stop clock panel in collecting and posting
> the times in the database.
>
> Now this is where it gets strange. In the daily timesheet display, all the
> Start times are correct. All the Stop times are into the next day. When I
> look at the code in daily.php, it looks like both Start and End times are
> being formatted exactly the same way.
>
> Now I just noticed in the paste of the web page below that the Total
> consists of two parts, and the "of nh nnm" is correct e.g second last row
> where start time is 16:32 and end time was set to 16:35, the duration of 0h
> 3m is correct.
>
> Does this suggest anything?
>
> Peter
>
> Client Project Task Start End Total *Actions* Lazarus Household Update
> Ubuntu Application Development 10:00 *7:35,12-May<http://localhost/tsng15/daily.php?&year=2010&month=5&day=12&proj_id=0>
> * 14h 0m* of 6h 35m* Details<http://localhost/tsng15/edit.php?client_id=0&proj_id=0&task_id=0&trans_num=33&year=2010&month=5&day=11>,
> Delete Lazarus Household Update Ubuntu Application Development 10:00 *
> 8:21,12-May<http://localhost/tsng15/daily.php?&year=2010&month=5&day=12&proj_id=0>
> * 14h 0m* of 7h 21m* Details<http://localhost/tsng15/edit.php?client_id=0&proj_id=0&task_id=0&trans_num=34&year=2010&month=5&day=11>,
> Delete Lazarus Household Update Ubuntu Application Development 16:25 *
> 7:33,12-May<http://localhost/tsng15/daily.php?&year=2010&month=5&day=12&proj_id=0>
> * 7h 35m* of 0h 8m* Details<http://localhost/tsng15/edit.php?client_id=0&proj_id=0&task_id=0&trans_num=31&year=2010&month=5&day=11>,
> Delete Lazarus Household Update Ubuntu Application Development 16:32 *
> 7:35,12-May<http://localhost/tsng15/daily.php?&year=2010&month=5&day=12&proj_id=0>
> * 7h 28m* of 0h 3m* Details<http://localhost/tsng15/edit.php?client_id=0&proj_id=0&task_id=0&trans_num=30&year=2010&month=5&day=11>,
> Delete Lazarus Household Update Ubuntu Application Development 16:34 *
> 8:00,12-May<http://localhost/tsng15/daily.php?&year=2010&month=5&day=12&proj_id=0>
> * 7h 26m* of 0h 26m*
>
> On 05/11/2010 01:20 AM, Scott Miller wrote:
>
> In the forum at SourceForge, Peter Lazarus has reported the following:
>
> 2010-05-09 22:44:37 CDT
>
> I have tried the 1.5 and found something odd about the times entered into
> the system by the clock on/clock off process. When I started at 10am and
> ended at 1pm, the end time for that task appears as 4am the next day, and
> the duration is shown as 14hours. I set a clockon/off time for the default
> task, clocking on at 1am and off at 2am. The duration shows 1 hour
> correctly, but the end time is 5pm. Under config, the timezone is set to
> Australia/Melbourne, but no locale is set. So I just now in configuration
> changed locale to en_AU, with no change to the results. My system clock is
> UTC. My php.ini doesn't have intl.default_locale set, but does have
> date.timezone set.
>
>
>
> I have attempted to replicate the problem. My TSNG config has been set to
> US/Central, the php.ini file had the date.timezone setting commented out. I
> tried changing the php.ini setting to US/Central, restarted apache, but the
> dates/times entered via the clockon/off process were set as expected in the
> database, and then read correctly when the page was reloaded. I then tried
> changing the php.ini to something completely different, “Europe/Zurich”,
> with no difference in date storage or retrieval.
>
>
>
> Since I was unable to replicate your problem, allow me to speculate where
> your problem may lie. MySQL has the capability to attempt to convert
> dates/times automatically for you, and php can be configured to attempt to
> automatically convert dates/times when communicating with MySQL. I would
> have to guess your problem lies either with the MySQL configuration, or
> within the communications between MySQL and PHP.
>
>
>
> -Scott
>
>
>
> ------------------------------------------------------------------------------
>
>
> _______________________________________________
> Tsheetx-developers mailing list
> Tsh...@li...
> https://lists.sourceforge.net/lists/listinfo/tsheetx-developers
>
>
|
|
From: Peter L. <pal...@gm...> - 2010-05-11 08:10:41
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Scott,<br>
thanks for the comments. I have done a little further investigation
today, and the results are stranger than previously reported.<br>
<br>
The times for the start_time and stop_time in the _times database are
showing correctly. When I run the query get_time_records from
common.inc the times and duration are also shown correctly, including
the unix timestamps. (<code class="sql"><span class="syntax"><span
class="syntax_alpha syntax_alpha_reservedWord">SELECT</span> <span
class="syntax_alpha syntax_alpha_identifier">start_time</span> <span
class="syntax_alpha syntax_alpha_reservedWord">AS</span> <span
class="syntax_alpha syntax_alpha_identifier">start_time_str</span><span
class="syntax_punct syntax_punct_listsep">,</span> <span
class="syntax_alpha syntax_alpha_identifier">end_time</span> <span
class="syntax_alpha syntax_alpha_reservedWord">AS</span> <span
class="syntax_alpha syntax_alpha_identifier">end_time_str</span><span
class="syntax_punct syntax_punct_listsep">,</span> <span
class="syntax_alpha syntax_alpha_functionName">unix_timestamp</span><span
class="syntax_punct syntax_punct_bracket_open_round">(</span> <span
class="syntax_alpha syntax_alpha_identifier">start_time</span> <span
class="syntax_punct syntax_punct_bracket_close_round">)</span> <span
class="syntax_alpha syntax_alpha_reservedWord">AS</span> <span
class="syntax_alpha syntax_alpha_identifier">start_stamp</span><span
class="syntax_punct syntax_punct_listsep">,</span> <span
class="syntax_white syntax_white_newline"></span><span
class="syntax_alpha syntax_alpha_functionName">unix_timestamp</span><span
class="syntax_punct syntax_punct_bracket_open_round">(</span> <span
class="syntax_alpha syntax_alpha_identifier">end_time</span> <span
class="syntax_punct syntax_punct_bracket_close_round">)</span> <span
class="syntax_alpha syntax_alpha_reservedWord">AS</span> <span
class="syntax_alpha syntax_alpha_identifier">end_stamp</span><span
class="syntax_punct syntax_punct_listsep">,</span> <span
class="syntax_white syntax_white_newline"></span><span
class="syntax_alpha syntax_alpha_identifier">duration </span><span
class="syntax_alpha syntax_alpha_reservedWord">FROM</span> <span
class="syntax_alpha syntax_alpha_identifier">ts1_times) </span></span></code>So
that says to me that mysql is not stuffing up, nor is the start/stop
clock panel in collecting and posting the times in the database. <br>
<br>
Now this is where it gets strange. In the daily timesheet display, all
the Start times are correct. All the Stop times are into the next day.
When I look at the code in daily.php, it looks like both Start and End
times are being formatted exactly the same way. <br>
<br>
Now I just noticed in the paste of the web page below that the Total
consists of two parts, and the "of nh nnm" is correct e.g second last
row where start time is 16:32 and end time was set to 16:35, the
duration of 0h 3m is correct. <br>
<br>
Does this suggest anything? <br>
<br>
Peter<br>
<br>
<table class="table_body" border="0" cellpadding="0" cellspacing="0"
width="100%">
<tbody>
<tr class="inner_table_head">
<td class="inner_table_column_heading" align="center">Client</td>
<td class="inner_table_column_heading" align="center">Project</td>
<td class="inner_table_column_heading" align="center">Task</td>
<td class="inner_table_column_heading" width="10%" align="center">Start</td>
<td class="inner_table_column_heading" width="10%" align="center">End</td>
<td class="inner_table_column_heading" width="10%" align="center">Total</td>
<td class="inner_table_column_heading" width="15%" align="center"><i>Actions</i></td>
</tr>
<tr>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('client_info.php?client_id=3','Client Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=500,height=200')">Lazarus
Household</a></td>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('proj_info.php?proj_id=4','Project Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=500,height=200')">Update
Ubuntu</a></td>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('task_info.php?task_id=62','Task Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=300,height=150')">Application
Development</a></td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right">10:00</td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right"><font
color="#909090"><i>7:35,<a
href="http://localhost/tsng15/daily.php?&year=2010&month=5&day=12&proj_id=0"><i>12-May</i></a></i></font></td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right">14h
0m<font color="#909090"><i> of 6h 35m</i></font></td>
<td class="calendar_cell_disabled_right" nowrap="nowrap"
align="right"> <a
href="http://localhost/tsng15/edit.php?client_id=0&proj_id=0&task_id=0&trans_num=33&year=2010&month=5&day=11"
class="action_link">Details</a>, <a
href="javascript:delete_entry(33);" class="action_link">Delete</a>
</td>
</tr>
<tr class="diff">
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('client_info.php?client_id=3','Client Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=500,height=200')">Lazarus
Household</a></td>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('proj_info.php?proj_id=4','Project Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=500,height=200')">Update
Ubuntu</a></td>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('task_info.php?task_id=62','Task Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=300,height=150')">Application
Development</a></td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right">10:00</td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right"><font
color="#909090"><i>8:21,<a
href="http://localhost/tsng15/daily.php?&year=2010&month=5&day=12&proj_id=0"><i>12-May</i></a></i></font></td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right">14h
0m<font color="#909090"><i> of 7h 21m</i></font></td>
<td class="calendar_cell_disabled_right" nowrap="nowrap"
align="right"> <a
href="http://localhost/tsng15/edit.php?client_id=0&proj_id=0&task_id=0&trans_num=34&year=2010&month=5&day=11"
class="action_link">Details</a>, <a
href="javascript:delete_entry(34);" class="action_link">Delete</a>
</td>
</tr>
<tr>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('client_info.php?client_id=3','Client Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=500,height=200')">Lazarus
Household</a></td>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('proj_info.php?proj_id=4','Project Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=500,height=200')">Update
Ubuntu</a></td>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('task_info.php?task_id=62','Task Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=300,height=150')">Application
Development</a></td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right">16:25</td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right"><font
color="#909090"><i>7:33,<a
href="http://localhost/tsng15/daily.php?&year=2010&month=5&day=12&proj_id=0"><i>12-May</i></a></i></font></td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right">7h
35m<font color="#909090"><i> of 0h 8m</i></font></td>
<td class="calendar_cell_disabled_right" nowrap="nowrap"
align="right"> <a
href="http://localhost/tsng15/edit.php?client_id=0&proj_id=0&task_id=0&trans_num=31&year=2010&month=5&day=11"
class="action_link">Details</a>, <a
href="javascript:delete_entry(31);" class="action_link">Delete</a>
</td>
</tr>
<tr class="diff">
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('client_info.php?client_id=3','Client Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=500,height=200')">Lazarus
Household</a></td>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('proj_info.php?proj_id=4','Project Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=500,height=200')">Update
Ubuntu</a></td>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('task_info.php?task_id=62','Task Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=300,height=150')">Application
Development</a></td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right">16:32</td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right"><font
color="#909090"><i>7:35,<a
href="http://localhost/tsng15/daily.php?&year=2010&month=5&day=12&proj_id=0"><i>12-May</i></a></i></font></td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right">7h
28m<font color="#909090"><i> of 0h 3m</i></font></td>
<td class="calendar_cell_disabled_right" nowrap="nowrap"
align="right"> <a
href="http://localhost/tsng15/edit.php?client_id=0&proj_id=0&task_id=0&trans_num=30&year=2010&month=5&day=11"
class="action_link">Details</a>, <a
href="javascript:delete_entry(30);" class="action_link">Delete</a>
</td>
</tr>
<tr>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('client_info.php?client_id=3','Client Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=500,height=200')">Lazarus
Household</a></td>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('proj_info.php?proj_id=4','Project Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=500,height=200')">Update
Ubuntu</a></td>
<td class="calendar_cell_middle"><a href="javascript:void(0)"
onclick="javascript:window.open('task_info.php?task_id=62','Task Info','location=0,directories=no,status=no,scrollbar=yes,menubar=no,resizable=1,width=300,height=150')">Application
Development</a></td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right">16:34</td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right"><font
color="#909090"><i>8:00,<a
href="http://localhost/tsng15/daily.php?&year=2010&month=5&day=12&proj_id=0"><i>12-May</i></a></i></font></td>
<td class="calendar_cell_middle" nowrap="nowrap" align="right">7h
26m<font color="#909090"><i> of 0h 26m</i></font></td>
</tr>
</tbody>
</table>
<br>
<br>
On 05/11/2010 01:20 AM, Scott Miller wrote:
<blockquote
cite="mid:046...@pt..."
type="cite">
<meta http-equiv="Content-Type"
content="text/html; charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 11 (filtered medium)">
<!--[if !mso]>
<style>
v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style>
<![endif]-->
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:blue;
text-decoration:underline;}
p
{mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:Arial;
color:navy;}
@page Section1
{size:8.5in 11.0in;
margin:.7in .35in .7in .35in;}
div.Section1
{page:Section1;}
-->
</style>
<div class="Section1">
<p class="MsoNormal"><font color="navy" face="Arial" size="2"><span
style="font-size: 10pt; font-family: Arial; color: navy;">In the forum
at SourceForge, Peter Lazarus
has reported the following:<o:p></o:p></span></font></p>
<p class="MsoNormal" style="margin-left: 0.5in;"><font
face="Times New Roman" size="3"><span style="font-size: 12pt;">2010-05-09
22:44:37 CDT<o:p></o:p></span></font></p>
<p class="MsoNormal" style="margin-left: 0.5in;"><font
face="Times New Roman" size="3"><span style="font-size: 12pt;">I have
tried the 1.5 and found something odd about the
times entered into the system by the clock on/clock off process. When I
started
at 10am and ended at 1pm, the end time for that task appears as 4am the
next
day, and the duration is shown as 14hours. I set a clockon/off time for
the
default task, clocking on at 1am and off at 2am. The duration shows 1
hour
correctly, but the end time is 5pm. Under config, the timezone is set
to
Australia/Melbourne, but no locale is set. So I just now in
configuration
changed locale to en_AU, with no change to the results. My system clock
is UTC.
My php.ini doesn't have intl.default_locale set, but does have
date.timezone
set.<o:p></o:p></span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial" size="2"><span
style="font-size: 10pt; font-family: Arial; color: navy;"><o:p> </o:p></span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial" size="2"><span
style="font-size: 10pt; font-family: Arial; color: navy;">I have
attempted to replicate the
problem. My TSNG config has been set to US/Central, the php.ini file
had the
date.timezone setting commented out. I tried changing the php.ini
setting to
US/Central, restarted apache, but the dates/times entered via the
clockon/off
process were set as expected in the database, and then read correctly
when the
page was reloaded. I then tried changing the php.ini to something
completely
different, “Europe/Zurich”, with no difference in date storage or
retrieval.<o:p></o:p></span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial" size="2"><span
style="font-size: 10pt; font-family: Arial; color: navy;"><o:p> </o:p></span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial" size="2"><span
style="font-size: 10pt; font-family: Arial; color: navy;">Since I was
unable to replicate your
problem, allow me to speculate where your problem may lie. MySQL has
the
capability to attempt to convert dates/times automatically for you, and
php can
be configured to attempt to automatically convert dates/times when
communicating with MySQL. I would have to guess your problem lies
either with
the MySQL configuration, or within the communications between MySQL and
PHP.<o:p></o:p></span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial" size="2"><span
style="font-size: 10pt; font-family: Arial; color: navy;"><o:p> </o:p></span></font></p>
<p class="MsoNormal"><font color="navy" face="Arial" size="2"><span
style="font-size: 10pt; font-family: Arial; color: navy;">-Scott</span></font></p>
</div>
<br>
</blockquote>
</body>
</html>
|
|
From: Scott M. <Sco...@pr...> - 2010-05-10 15:20:29
|
In the forum at SourceForge, Peter Lazarus has reported the following: 2010-05-09 22:44:37 CDT I have tried the 1.5 and found something odd about the times entered into the system by the clock on/clock off process. When I started at 10am and ended at 1pm, the end time for that task appears as 4am the next day, and the duration is shown as 14hours. I set a clockon/off time for the default task, clocking on at 1am and off at 2am. The duration shows 1 hour correctly, but the end time is 5pm. Under config, the timezone is set to Australia/Melbourne, but no locale is set. So I just now in configuration changed locale to en_AU, with no change to the results. My system clock is UTC. My php.ini doesn't have intl.default_locale set, but does have date.timezone set. I have attempted to replicate the problem. My TSNG config has been set to US/Central, the php.ini file had the date.timezone setting commented out. I tried changing the php.ini setting to US/Central, restarted apache, but the dates/times entered via the clockon/off process were set as expected in the database, and then read correctly when the page was reloaded. I then tried changing the php.ini to something completely different, "Europe/Zurich", with no difference in date storage or retrieval. Since I was unable to replicate your problem, allow me to speculate where your problem may lie. MySQL has the capability to attempt to convert dates/times automatically for you, and php can be configured to attempt to automatically convert dates/times when communicating with MySQL. I would have to guess your problem lies either with the MySQL configuration, or within the communications between MySQL and PHP. -Scott ________________________________ From: David Thompson [mailto:tom...@us...] Sent: Sunday, May 09, 2010 11:58 PM To: tsh...@li... Subject: [Tsheetx-developers] FW: Mailing lists are read-only Peter, I am forwarding this to the mailing-list (you can do this too, just mail to the above address). Mails on this list then are archived for posterity (and for new developers!), as opposed to direct e-mails that just get lost. We currently are using Mantis on http://bugs.timesheetng.org to record issues (the address may change in the future). Cheers > To: tom...@us... > From: pet...@us... > CC: pet...@us... > Subject: Mailing lists are read-only > Date: Mon, 10 May 2010 03:47:32 +0000 > > > Message body follows: > > Hi Dave, > mailing lists are read-only. Is that the correct status? > > I added a comment to the forum about release 1.5 and the > clock on/clock off button thingy not working correctly. > Peter > ________________________________ Your E-mail and More On-the-Go. Get Windows Live Hotmail Free. Sign up now. <https://signup.live.com/signup.aspx?id=60969> |
|
From: David T. <tom...@us...> - 2010-05-10 04:57:55
|
Peter, I am forwarding this to the mailing-list (you can do this too, just mail to the above address). Mails on this list then are archived for posterity (and for new developers!), as opposed to direct e-mails that just get lost. We currently are using Mantis on http://bugs.timesheetng.org to record issues (the address may change in the future). Cheers > To: tom...@us... > From: pet...@us... > CC: pet...@us... > Subject: Mailing lists are read-only > Date: Mon, 10 May 2010 03:47:32 +0000 > > > Message body follows: > > Hi Dave, > mailing lists are read-only. Is that the correct status? > > I added a comment to the forum about release 1.5 and the > clock on/clock off button thingy not working correctly. > Peter > _________________________________________________________________ Your E-mail and More On-the-Go. Get Windows Live Hotmail Free. https://signup.live.com/signup.aspx?id=60969 |
|
From: Scott M. <Sco...@pr...> - 2010-05-05 14:11:07
|
I checked in a couple more minor fixes and changes yesterday. One issue was with the user summary report, where the 2nd bi-monthly ending date was set to 31 rather than calculated. And another change was to remove the "All Clients" drop down option on the clock on/off forms, and have those forms automatically select the first valid client/project/task for the user. A user selectable default would be nice, see the last paragraph below. I've not yet heard any bug reports from the forum poster who claimed the system was still "very buggy", and we've not run into any big issues yet; I rolled it into production last Friday evening, April 30th, 2010. So, I think it is very close at this point. I am still hopeful that someone else out there has installed it and is working with it to help us determine it is ready. So, if you're using it, please chime in. I'll suggest we make 1.5.0 official May 12th barring any big problems. On a separate note: I've been attempting to figure out how to allow the user to select a default client/project/task for the clock on/off forms, and also to have a default set of client/project/task/times for each day and/or week (daily, simple forms). But so far I've not been able to visualize an easy UI to make that happen. If anyone thinks they know what that should look like, I'm looking for guidance. Note that this functionality will not be something that makes it into 1.5.0. -Scott ________________________________ From: David Thompson [mailto:tom...@us...] Sent: Wednesday, May 05, 2010 12:46 AM To: tsh...@li... Subject: [Tsheetx-developers] TSNG Version 1.5.0 ready? What is the status of the 1.5.0 candidate, is it good enough to release? Opinions, please! ________________________________ Subject: RE: [Tsheetx-developers] Testing for TSNG Version 1.5.0 Date: Mon, 26 Apr 2010 17:09:22 -0500 From: Sco...@pr... To: tom...@us... CC: tsh...@li... Ok, I just finished checking in SVN revision 104. Since the initial check in which was, 94 if my notes are correct, several functionality "upgrades" have been introduced. You can peruse the "tracking" system at http://bugs.timesheetng.org <http://bugs.timesheetng.org/> to review the changes or look at the SVN comments at http://tsheetx.svn.sourceforge.net/viewvc/tsheetx/trunk. There have been some DB changes made between revisions 94 and 104, if you've upgraded to a previous 1.5.0 revision, and wish to upgrade to the latest, you can now execute the smallish php script: .update-1.5.0-beta.php from within the active website directory. It will make only those DB changes needed to get you current. Also, I promised to publish the list of things that have been fixed when I first checked it in, this document is now located within the new wiki hosted on sourceforge: https://sourceforge.net/apps/mediawiki/tsheetx/index.php?title=Main_Page If you've installed/upgraded to the new version, please let us know how things are going. -Scott L. Miller ________________________________ Hotmail: Powerful Free email with security by Microsoft. Get it now. <https://signup.live.com/signup.aspx?id=60969> |
|
From: David T. <tom...@us...> - 2010-05-05 05:46:31
|
What is the status of the 1.5.0 candidate, is it good enough to release? Opinions, please! Subject: RE: [Tsheetx-developers] Testing for TSNG Version 1.5.0 Date: Mon, 26 Apr 2010 17:09:22 -0500 From: Sco...@pr... To: tom...@us... CC: tsh...@li... Ok, I just finished checking in SVN revision 104. Since the initial check in which was, 94 if my notes are correct, several functionality “upgrades” have been introduced. You can peruse the “tracking” system at http://bugs.timesheetng.org to review the changes or look at the SVN comments at http://tsheetx.svn.sourceforge.net/viewvc/tsheetx/trunk. There have been some DB changes made between revisions 94 and 104, if you’ve upgraded to a previous 1.5.0 revision, and wish to upgrade to the latest, you can now execute the smallish php script: .update-1.5.0-beta.php from within the active website directory. It will make only those DB changes needed to get you current. Also, I promised to publish the list of things that have been fixed when I first checked it in, this document is now located within the new wiki hosted on sourceforge: https://sourceforge.net/apps/mediawiki/tsheetx/index.php?title=Main_Page If you’ve installed/upgraded to the new version, please let us know how things are going. -Scott L. Miller _________________________________________________________________ Hotmail: Powerful Free email with security by Microsoft. https://signup.live.com/signup.aspx?id=60969 |
|
From: Scott M. <Sco...@pr...> - 2010-04-26 22:09:35
|
Ok, I just finished checking in SVN revision 104. Since the initial check in which was, 94 if my notes are correct, several functionality "upgrades" have been introduced. You can peruse the "tracking" system at http://bugs.timesheetng.org <http://bugs.timesheetng.org/> to review the changes or look at the SVN comments at http://tsheetx.svn.sourceforge.net/viewvc/tsheetx/trunk. There have been some DB changes made between revisions 94 and 104, if you've upgraded to a previous 1.5.0 revision, and wish to upgrade to the latest, you can now execute the smallish php script: .update-1.5.0-beta.php from within the active website directory. It will make only those DB changes needed to get you current. Also, I promised to publish the list of things that have been fixed when I first checked it in, this document is now located within the new wiki hosted on sourceforge: https://sourceforge.net/apps/mediawiki/tsheetx/index.php?title=Main_Page If you've installed/upgraded to the new version, please let us know how things are going. -Scott L. Miller |
|
From: Scott M. <Sco...@pr...> - 2010-04-21 20:08:46
|
Ah, yes, either works for me, so, I would not be surprised if there are a number of those <? guys running around the code. I tried to always use <?php, but, I don't know how successful I was with that. What is claiming the gif files aren't gif files? They work just fine for me, and my stuff doesn't think they're not gif files... I just found a pretty large bug in the monthly.php code. When viewing the month with tasks that haven't had their "duration" fixed, only the first task for each day is "fixed" and and therefore only the first task has a duration for which to add to the total time. As soon as you view those days using any other view, all the tasks' duration fields are filled, so the next time the month view's totals are correct. The fix is to add a single line of code. One of the things I had added for our installation was the ability for an administrator to view (and edit) other user's time entries. Since we only use the simple.php form, I'd originally just added that functionality to that form. Today, I finished adding that ability to the menu bar. After the "logout" menu item, if you are an administrator, a drop down list appears with the label "context user:". Changing that, changes the session's contextUser variable. If you're not an administrator, that item doesn't show up at all. Adding that, has meant nearly all the other forms have had to be modified, because we can't set the $contextUser variable until after the timesheet_menu.inc is included, because the code that changes the session variable is in the timesheet_menu.inc file. I had a few modifications to the menu class and the common.inc to support this change. I'll be checking this code in within the hour. -Scott ________________________________ From: tom...@ho... [mailto:tom...@ho...] On Behalf Of David Thompson Sent: Wednesday, April 21, 2010 2:19 PM To: Scott Miller Subject: RE: Testing for TSNG Version 1.5.0 Hi Scott I fixed the problem I had with the install script (revision 98), and found some more interesting things due to the same problem (revision 99). But now it looks good. Use "<?php" not "<?". Just one thing, the two GIFs for project and user rates are not GIF files! Can you find the files you wanted? Cheers Dave ________________________________ Subject: RE: "Release notes" for TSNG Version 1.5.0 Date: Wed, 21 Apr 2010 09:19:37 -0500 From: Sco...@pr... To: tom...@us... Well, I am developing on Linux under PHP 5.1.6 (don't know about EasyPHP, so I don't know how that maps to your version), so, no I don't get that error. In my install/index.php, the last line is 1176, and that is actually just a comment, but it helps set up VIM (VI iMproved editor) the way I like it... -Scott ________________________________ Hotmail: Powerful Free email with security by Microsoft. Get it now. <https://signup.live.com/signup.aspx?id=60969> |
|
From: Scott M. <Sco...@pr...> - 2010-04-19 13:53:49
|
Well, I've done my best to make it as stable as possible, and tested the upgrade process starting from 1.2.1 (our still current "production" system) and the installation process probably 10 times each. But, I'm only one guy with one environment... I would like to see a ZIP file on sourceforge, but should we call it a "release candidate", or "beta" just to keep people cautious? And then we could re-evaluate in a month to see if there are issues to resolve, or if we just need to remove the label. I'm up for suggestions, and I'm anxiously awaiting feedback :-) -Scott ________________________________ From: David Thompson [mailto:tom...@us...] Sent: Monday, April 19, 2010 6:02 AM To: tsh...@li... Subject: Re: [Tsheetx-developers] Version 1.5.0 has been checked in Thanks, Scott for your superb work, I will be looking at this... Do we need a period of testing, or should we release this as a ZIP on sourceforge? Depends on how stable it is, and problems expected wehn upgrading from 1.4.1. Cheers ________________________________ Date: Fri, 16 Apr 2010 15:20:23 -0500 From: Sco...@pr... To: tsh...@li... Subject: [Tsheetx-developers] Version 1.5.0 has been checked in Many changes and improvements have gone into this new version of the TimesheetNextGen system. I have previously sent out a partial list of what had been changed. I won't place the final list here, but I will publish that list somewhere on the web site(s). The main thing to note if you plan to upgrade: It is strongly suggested that you look at any reports you or others at your company have built, and look at upgrading your reports to take advantage of the routines to "fix" the day light savings time issues and to split tasks that may now span date boundaries into a set of discrete dates. Please let me know of any issues you run into, I'll do my best to help resolve them. This revision can be checked out via: svn co https://tsheetx.svn.sourceforge.net/svnroot/tsheetx/trunk </your/path/> -Scott L. Miller ________________________________ Your E-mail and More On-the-Go. Get Windows Live Hotmail Free. Sign up now. <https://signup.live.com/signup.aspx?id=60969> |
|
From: David T. <tom...@us...> - 2010-04-19 11:01:53
|
Thanks, Scott for your superb work, I will be looking at this... Do we need a period of testing, or should we release this as a ZIP on sourceforge? Depends on how stable it is, and problems expected wehn upgrading from 1.4.1. Cheers Date: Fri, 16 Apr 2010 15:20:23 -0500 From: Sco...@pr... To: tsh...@li... Subject: [Tsheetx-developers] Version 1.5.0 has been checked in Many changes and improvements have gone into this new version of the TimesheetNextGen system. I have previously sent out a partial list of what had been changed. I won’t place the final list here, but I will publish that list somewhere on the web site(s). The main thing to note if you plan to upgrade: It is strongly suggested that you look at any reports you or others at your company have built, and look at upgrading your reports to take advantage of the routines to “fix” the day light savings time issues and to split tasks that may now span date boundaries into a set of discrete dates. Please let me know of any issues you run into, I’ll do my best to help resolve them. This revision can be checked out via: svn co https://tsheetx.svn.sourceforge.net/svnroot/tsheetx/trunk </your/path/> -Scott L. Miller _________________________________________________________________ Your E-mail and More On-the-Go. Get Windows Live Hotmail Free. https://signup.live.com/signup.aspx?id=60969 |
|
From: Scott M. <Sco...@pr...> - 2010-04-16 20:20:40
|
Many changes and improvements have gone into this new version of the TimesheetNextGen system. I have previously sent out a partial list of what had been changed. I won't place the final list here, but I will publish that list somewhere on the web site(s). The main thing to note if you plan to upgrade: It is strongly suggested that you look at any reports you or others at your company have built, and look at upgrading your reports to take advantage of the routines to "fix" the day light savings time issues and to split tasks that may now span date boundaries into a set of discrete dates. Please let me know of any issues you run into, I'll do my best to help resolve them. This revision can be checked out via: svn co https://tsheetx.svn.sourceforge.net/svnroot/tsheetx/trunk </your/path/> -Scott L. Miller |
|
From: Scott M. <Sco...@pr...> - 2010-04-08 19:00:46
|
Hi everyone,
I've been using the original Timesheet system at our company for about 4
years now, and since the original open source project had died, we began
improving our system basically since we started using it. I then
learned about the resurrection under the "new generation" moniker, and
have been conversing with Tommo (Dave) off and on over the past several
months. During that time, when I've had time, I've been working hard on
improving the system, incorporating many improvements we've made, fixing
the DST inconsistencies, and making other improvements as I've seen fit.
I'm currently working on adding a couple of the reports we've created to
the new system, and once I get that done, I'll need to fix up the
installation and updating routines. I'll then be ready to check
everything in. After discussing with Tommo, the version number will
change to 1.5.0.
Here's a copy of the log I've kept of what I've been doing:
Scott Miller's Timesheet NG Release Notes
April, 2010
A new navigational calendar is included on all the time
entry forms, and the original "prev / next" buttons have been removed.
The navigational calendars are implemented using a set of include files.
I've consolidated the clock on and off form on the
daily, popup and stopwatch forms by placing the "core" of clock on/off
form into a set of include files (a single include file didn't quite cut
it).
On the daily form, I've placed both the navigation
calendar and the clock on/off forms next to each other above the
task/time display form.
Previous versions of this system did not calculate the
ending timestamps correctly. If we work from midnight to midnight,
we've worked for 24 hours (disregarding DST issues), not 23 hours, 59
minutes and 59 seconds. An ending timestamp of midnight is now perfectly
acceptable and is handled correctly.
Several functions were modified or added to the
common.inc file, and a few were removed:
* get_month_times() has been renamed and broadened in scope to
become get_time_records()
* get_last_day() function was modified to use "date('t',
strtotime("$year-$month-1"));"
* get_dst_adjustment() added to help deal with DST adjustments
when needed
* get_duration() added to calculate number of minutes between
start and end stamps
* get_end_date_time() added to calculate the end stamp given start
stamp and duration in minutes
* fix_entry_duration() added to fix db items in which duration
column is NULL
* fix_entry_endstamp() added to fix db items in which calculated
endstamp doesn't match endstamp in the db
* formatMinutes() added to create better human readable format for
durations in minutes similar to formatSeconds
* get_trans_info() modified to get additional DB fields (duration,
trans_num), and renamed start/end_time to start/end_stamp
* year_button() used to only count up from the context date, which
made it difficult to go back, it now generates a pull down with the
previous 5 years and the next 5 years.
* setReportDate() was removed, as it was no longer needed
* printPrevNext() was removed, as it was no longer needed
* split_data_into_discrete_days() added, see below for further
discussion
* __put_data_in_array() helper for split_data_into_discrete_days()
* fixStartEndDuration() helps to ensure time/date data from DB is
as accurate as we can, and keeps duration and end_time columns in a
consistent state. See Daylight Savings time discussion below for
further information.
A new subdirectory was added for the Navigational
calendar items called 'navigational'. Within that subdirectory another
file called 'common.inc' was created, functions moved to or otherwise
included in this file are:
* getNextMonth() added to calculate the next month's context date,
keeping the resulting context day of the month as close to the original
context day of the month as it can.
* getPrevNextMonth() added to calculate the previous and next
month context dates keeping the resulting context day of the month as
close to the current context day of the month as it can.
* getPrevNextYear() does the same thing as getPrevNextMonth() only
for next/previous years
* draw_month_year_navigation() prints out a single monthly/yearly
navigational table
* __print_month_name() helper for above function, prints out a 3
letter month abbreviation link with all needed "$post" variables.
* draw_month_year_navigation_with_end_dates() prints out a single
monthly/yearly navigational table for report tables that allow user to
select both a start_time and an end_time.
* __print_month_name_with_end_date () helper for above function,
prints out a 3 letter month abbreviation link with all needed "$post"
variables.
All data entry forms have been modified to use the
get_time_records() function instead of each having their own times table
query.
The file calendar.php has been renamed to monthly.php;
the menu item "Calendar" has been renamed to "View Month", and the
aclCalendar database item has been renamed to aclMonthly, and the config
database column startPage has been modified from an enum with 'calendar'
in the definition to an enum with 'monthly' in the definition. All files
referencing any of these items were modified to reference the new
'monthly' names.
Daylight Savings time (DST) threw a big wrench into the
way the timesheet application did most date/time calculations. If users
enter their time using dates/times (daily/pop-up screens), DST
adjustments have always been made automatically. If users enter time
using the simple form, however, DST adjustments were not performed when
storing the data, but upon retrieval, DST adjustments were made, and
thus made incorrectly. Two things have been done to fix this problem:
1) The database schema has changed to include a
"duration" column in the times table. All forms now populate the
duration column, but if it is null, it is calculated, and written to the
database. If the duration column is a positive integer, the end_time
column information is ignored, and is calculated using the start_time
and duration. If the calculated end_time does not agree with database
end_time, the database end_time is set to the calculated time.
2) In the simple.php form, if the duration is
missing, and the start date begins at midnight, and the start_time and
end_time are not in the same DST state (ie. one is summer time, the
other standard time), then it is assumed the entry was created by a
previous instance of simple.php, and the incorrect automatic DST
adjustment is reversed. In the new version, the duration column
eliminates the need to perform the DST calculations and adjustments.
Unfortunately it is inherently ambiguous to use
the datetime SQL datatype to store dates unless extreme care is taken to
cast date information into and out of the UTC timezone when writing to
and reading from the database. The timesheet system has never cast the
time info at all, and without these casts the datetime datatype cannot
unambiguously represent, for example, the US fall DST adjustment hour
between 1am and 2am (where time goes from 1:59:59am back to 1:00:00am
the first time through, and then goes to 2:00:00 the second time
through). I'm sure there are other examples of this problem in other
zones that observe some form of DST. I plan to further move the
Timesheet NG away from this problem, by replacing the datetime datatype
with a 64 bit integer which will store unix timestamps, but I've decided
I cannot complete that work in this iteration.
For more info about the SQL datetime problems,
see: http://jokke.dk/blog/2007/07/timezones_in_mysql_and_php
and read the comments by Miles Nordin and Joakim
Nygard.
I also think the end_time column could be
deprecated by automatically taking tasks that extend past a day boundary
(ie. midnight), and splitting that task up into separate entries for
each day that is involved. This has also not been done for this
iteration.
I've attempted to reduce the number of times that the
date functions were called. For instance, there used to be many cases
where date was called repeatedly to get first the year, then the month,
and then the day, I've replaced many of those instances with a single
call to getdate, and then pulled the 3 variables out of the resulting
array.
All the reports have been modified to make use of the
duration field to override the end_time, many have been modified to
allow different sorting options by clicking on some of the table
headers, and additional reports that we have found useful have been
added to the list of available reports. All reports now also make use of
the get_time_records() function to read user time entries.
A "select client" drop down was added to the
'report_specific_user.php' script, thereby eliminating the need for the
report_specific_client_user.php report file.
Report files have been renamed to remove the "specific"
portion of their names. Ie. report_specific_user.php =>
report_user.php, report_specific_project.php => report_project.php, etc.
Also, the recently added "summary" report,
report_summary_client_user.php, was renamed to
report_grid_client_user.php. Most report descriptions in reports.php
have been modified to read slightly more clearly.
In order to attempt to keep the current context accurate
where ever possible, the links in the navigational calendars include a
new global variable "$post". Each form is responsible for placing all
context variables needed into $post to keep the rest of the context
accurate when changing context dates. For example, if we're on a report
page, and are sorting by date, $post needs to have the string
"&orderby=date" included, or navigating to a different date would revert
back to the default sort order.
Changing which user form was being viewed (simple,
daily, weekly, monthly) used to reset the views to use the actual
current date; this has also been changed so that $post is used for those
links as well so that changing which form is being viewed now preserves
the current context date being viewed.
I added a dollar sign ($) icon for the rate menu items.
The function(s) to create the Previous / Next navigation
links within reports have been eliminated to use the new navigational
calendars. This has helped eliminate the need for the "setReportDate"
function which tended to modify the "current context" date, which
irritated me.
Since most reports usually want task times broken into
discrete daily time periods, a set of functions were created to do that
work for us. The main function is called split_data_into_discrete_days()
takes one database result at a time, which has a task with a start time
and duration, and could span date boundaries (ie. start on one day and
end on subsequent day) and splits that task into discrete days, and adds
those entries into a new array. To get the data ordered as we want, the
calling script must have a function called make_index() defined to
create the array keys with which the data is added to the new array.
The task of copying the needed data to the new array is given to yet
another function called __put_data_in_array()
-Scott L. Miller
|
|
From: David T. <tom...@us...> - 2009-07-22 09:34:25
|
Hi I have been working on getting a v1.4.1 candidate stable, /branches/timesheetNG-v1.4.x and /trunk have been synchronised with this version. It needs some testing, but it should be good to go. Works with PHP4 and PHP5, and improved SQL for MySQL5. The question is, has anyone else got plans to change things or more debugging before we release? Cheers _________________________________________________________________ Show them the way! Add maps and directions to your party invites. http://www.microsoft.com/windows/windowslive/products/events.aspx |
|
From: David T. <tom...@us...> - 2009-05-20 12:39:50
|
I looked at the changes and tried it out, yesterday. Some thoughts: 1. The reminder message part is clearly too specific, but I see your need for some kind of "Message of the Day", this could be implemented as a new field in the config table, and the text placed somewhere flexibly. 2. The clickable calendar widget is cool and quick to navigate. Much better than the simple Next/Previous concept that we currently have. 3. This would be a useful addition to daily & weekly timesheets too. 4. Yes, its location is not good. Screen design is not my priority at the moment (1.5 or 2.0 rewrite), but you might have different priorities. Suggestions: a. Keep it where it is and see if any users don't like the waste of space (or use the space for your MOTD). b. As you said, put it up next to the logo, but don't forget this header stuff is configurable. c. Replace the Next/Previous links with this. I would tend to go for c. because then you fit it into the existing design, improving the date navigation, and could extend it onto weekly/daily timesheets. Cheers Subject: RE: Monthly Calendar on simple timesheet Was RE: Patches? Date: Tue, 19 May 2009 08:30:12 -0600 From: Sco...@pr... To: tom...@us...; tsh...@li... Considering the calendar is active and allows people to just click on some day of the week to jump to that week's entries, and has month back and month forward buttons, I personally think it's a very handy item to have. My only / biggest question is where to put that calendar. It's currently taking up about 2 inches vertically on my screen (obviously, that will be different depending on screen resolution and size) between the menu bar and the actual timesheet right now. We make use of the space to the right of the calendar to put a reminder message about when people need to get their time reported. So, one option I’ve thought of is to place that within the icon/banner bar on the left? I like giving people options. If it’s easy enough to make optional, make it optional. I’m sure someone, somewhere will hate it… -Scott _________________________________________________________________ Show them the way! Add maps and directions to your party invites. http://www.microsoft.com/windows/windowslive/products/events.aspx |
|
From: Scott M. <Sco...@pr...> - 2009-05-19 14:52:14
|
Ok, I'm subscribed to the developer list now too; I had already subscribed to the general list and that does get emails from the bug ticketing system. Did you ever get a chance to look at the version of the simple timesheet with the embedded monthly calendar I'd sent out several weeks ago? -Scott ________________________________ From: tom...@ho... [mailto:tom...@ho...] On Behalf Of David Thompson Sent: Tuesday, May 19, 2009 1:56 AM To: Scott Miller Subject: RE: Patches? Hello Scott Thanks for the update, I saw the check-ins on the project activity. It's great to have a new contributor! In the future send your development-related mails to the mailing list (tsh...@li...), that way they get centrally archived and everyone who is subscribed to the list gets the mail. I guess that only Rob and myself are subscribed at the moment, but the central archive is also important (for furture new developers). You should go to https://sourceforge.net/mail/?group_id=215962 and subscribe to the tsheetx-developers list (we don't use the tsheetx-general list at the moment). My progress is slow, but the v1.4.x branch has a cleaner web-install. What I want to do is a cleaner web-upgrade process. Cheers ________________________________ Subject: RE: Patches? Date: Thu, 14 May 2009 16:30:10 -0600 From: Sco...@pr... To: tom...@us... Well, I finally got a bit of time today to get my feet wet committing my first change. I fixed the 2 bugs keeping trunk from installing correctly and running. I also finally checked out the 1.4.x branch. As time permits, I'll attempt to install and play with that instance. -Scott ________________________________ What can you do with the new Windows Live? Find out <http://www.microsoft.com/windows/windowslive/default.aspx> |
|
From: David T. <tom...@us...> - 2009-05-19 14:12:58
|
I am sad to say it is still in my inbox, I will try to look at it tonight. Do you think it is generally an improvement, or some people won't want it? That defines whether we build it straight in or make it optional. Cheers Subject: RE: Patches? Date: Tue, 19 May 2009 07:56:11 -0600 From: Sco...@pr... To: tom...@us...; tsh...@li... Ok, I’m subscribed to the developer list now too; I had already subscribed to the general list and that does get emails from the bug ticketing system. Did you ever get a chance to look at the version of the simple timesheet with the embedded monthly calendar I’d sent out several weeks ago? -Scott From: tom...@ho... [mailto:tom...@ho...] On Behalf Of David Thompson Sent: Tuesday, May 19, 2009 1:56 AM To: Scott Miller Subject: RE: Patches? Hello Scott Thanks for the update, I saw the check-ins on the project activity. It's great to have a new contributor! In the future send your development-related mails to the mailing list (tsh...@li...), that way they get centrally archived and everyone who is subscribed to the list gets the mail. I guess that only Rob and myself are subscribed at the moment, but the central archive is also important (for furture new developers). You should go to https://sourceforge.net/mail/?group_id=215962 and subscribe to the tsheetx-developers list (we don't use the tsheetx-general list at the moment). My progress is slow, but the v1.4.x branch has a cleaner web-install. What I want to do is a cleaner web-upgrade process. Cheers Subject: RE: Patches? Date: Thu, 14 May 2009 16:30:10 -0600 From: Sco...@pr... To: tom...@us... Well, I finally got a bit of time today to get my feet wet committing my first change. I fixed the 2 bugs keeping trunk from installing correctly and running. I also finally checked out the 1.4.x branch. As time permits, I’ll attempt to install and play with that instance. -Scott What can you do with the new Windows Live? Find out _________________________________________________________________ More than messages–check out the rest of the Windows Live™. http://www.microsoft.com/windows/windowslive/ |
|
From: David T. <tom...@ho...> - 2009-04-15 07:54:55
|
> Please play around, hack, fix, continue etc. > > On thing I'm not too keen on is the naming conventions I've come up > with, e.g. Module and Controller is: > Module_ControllerName > > Module and Model is: > Module_ModelName > > You can have sub directories, e.g: > Core_ORM_Iterator which loads in core/models/ORM/Iterator.php > > But this can start to get messy, e.g. model called Calendar_Calendar() > > Would be much better to use name spaces, but this is not out till 5.3 > (currently at RC1) > http://www.php.net/language.namespaces > We have to decide naming conventions and stick to them. Changing later will be problematic. So it is worth playing with all your options now, to get a feel for what is right, before deciding. I will start looking at this at soon as I can... _________________________________________________________________ News, entertainment and everything you care about at Live.com. Get it now! http://www.live.com/getstarted.aspx |
|
From: David T. <tom...@ho...> - 2009-04-15 07:49:04
|
Hi everyone ;) I have been working, off and on, on fixing some bugs from V1.3.1 and at the same time testing with PHP/MySQL 5. Everything runs good on my PHP5 installation now, the only thing I haven't tested in detail is the web-installer. Originally I planned to release a bug-fix for V1.3.1 (V1.3.2) and a PHP5 branch (V1.4.2?). But I have tried the PHP5 compatible version on my PHP4 installation and seen that it runs without complaining. So my question is, should we keep the idea of two branches, or just release one version (V1.4.1?) that is a bug-fix and upgrade to PHP5? I think one release would make more sense, but it will need testing on PHP 4 and 5. Thoughts, anyone? tommo _________________________________________________________________ More than messages–check out the rest of the Windows Live™. http://www.microsoft.com/windows/windowslive/ |
|
From: Rob S. <ib...@us...> - 2009-04-10 16:11:49
|
Hi All, Just to let you know I have committed my hackings to the SVN at SourceForge: https://tsheetx.svn.sourceforge.net/svnroot/tsheetx/branches/timesheet.ng-1.5 It's a bit messy at the moment, but some important features are working: 1. URL - can decide what controller and method to use based on the URL, eg: http://<your-host>/calendar/ http://<your-host>/calendar/add 2. Database and ORM - this is lifted directly from KohanaPHP, only MySQL driver is working at the moment, but the ORM seems to be working ok 3. Unit Testing, for an example go to: http://<your-host>/unit-test/ Please play around, hack, fix, continue etc. On thing I'm not too keen on is the naming conventions I've come up with, e.g. Module and Controller is: Module_ControllerName Module and Model is: Module_ModelName You can have sub directories, e.g: Core_ORM_Iterator which loads in core/models/ORM/Iterator.php But this can start to get messy, e.g. model called Calendar_Calendar() Would be much better to use name spaces, but this is not out till 5.3 (currently at RC1) http://www.php.net/language.namespaces As ever, thoughts, suggestions welcome/needed! Have a great Easter Rob |
29 messages has been excluded from this view by a project administrator.
