Out of bounds access of keybindings

A modern, cross-platform Quake game engine based on FitzQuake.

Brought to you by: ewasylishen, sezero, stevenaaus

#14 Out of bounds access of keybindings

Milestone: None

Status: closed-fixed

Owner: nobody

Labels: None

Priority: 5

Updated: 2016-08-21

Created: 2016-08-21

Creator: Axel Gneiting

Private: No

K_PAUSE is 255, but MAX_KEYS is 253, leading to an out of bounds access of keybindings in Key_SetBinding via Key_Bind_f where Key_StringToKeynum returns 255 for "PAUSE"

See https://github.com/Novum/vkQuake/commit/b12e57647124624b38e74006f59f5c88aee6f69a

Discussion

Ozkan Sezer - 2016-08-21

Thanks. However your solution seems off by one: is it not supposed to be 256?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Axel Gneiting - 2016-08-21

Yeah, I'm stupid today.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ozkan Sezer - 2016-08-21

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ozkan Sezer - 2016-08-21

Fixed in the svn as of r1336' thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Out of bounds access of keybindings

A modern, cross-platform Quake game engine based on FitzQuake.

Milestone

Searches

Help

#14 Out of bounds access of keybindings

Discussion