Menu
▾
▴
pidgin-patches — Updates to the Gaim patches tracker
You can subscribe to this list here.
| 2004 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(435) |
Dec
(252) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2005 |
Jan
(177) |
Feb
(157) |
Mar
(187) |
Apr
(168) |
May
(127) |
Jun
(291) |
Jul
(38) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: SourceForge.net <no...@so...> - 2005-06-23 16:08:50
|
Patches item #1180490, was opened at 2005-04-11 00:10 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Mark Doliner (thekingant) Summary: Autocomplete Screennames in Dialogs Based on Logs Initial Comment: Here it is, the much anticipated (or not) patch to autocomplete screennames based on the logs on the disk. Additionally... 1. It fixes the bug where the View User Log box only had screennames for accounts which are currently online. It lists all accounts, so it should have all screennames as possible completions. 2. It fixes the name of the View User Log box to be "View User Log" instead of "Get User Log". This was done so it matched the menu item. 3. It brings the gaim_log_logger_new function in sync with the GaimLogLogger struct. 4. Some other minor documentation fixes. 5. A ChangeLog.API entry for the removal (by Nathan) of the gaim_find_conversation function. The only reason this is included is that no matter how I submitted the separate patches, you'd end up with separate conflicts because this patch has to add a ChangeLog.API line. This really shouldn't be a big deal, but I'm mentioning it for completeness. ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-06-23 11:08 Message: Logged In: YES user_id=156487 Yes. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-23 07:33 Message: Logged In: YES user_id=20979 Say I have the screen name "IStealCellPhones" in my buddy list, and I set their alias to "BlahBlah." If I type "bla" in the New Instant Message window, does it suggest "BlahBlah"? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-23 00:50 Message: Logged In: YES user_id=156487 What do you mean "show matching aliases"? ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 22:05 Message: Logged In: YES user_id=20979 deryni pointed out that the assertions were there before your patch, sorry about that. This looks good so I applied it. Would it be hard to also show matching aliases in the autocomplete? ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 20:41 Message: Logged In: YES user_id=20979 When testing this, I see a bajillion "GLib: g_str_has_prefix: assertion `str != NULL' failed" messages printed to the console when typing letters into the "New Instant Message" request dialog. I started Gaim with "gaim -d," I'm not sure if that'll make a difference. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-04 14:31 Message: Logged In: YES user_id=156487 Posting a new version of this patch. It will now apply cleanly against HEAD. It's exactly the same as what Sean reviewed, except: 1. I added another entry to the ChangeLog.API file to mark the additions this patch makes. The previous version of the patch only marked the changed function and not the additions. 2. I added an entry to the ChangeLog file for this feature addition. I hope I'm not being too presumptuous in adding this entry to the patch. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-04 13:32 Message: Logged In: YES user_id=199625 Mark: This looks pretty good to me, but I can't commit anything right now. Could you handle this patch when you get the chance? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-17 23:05 Message: Logged In: YES user_id=156487 Here's a new version of the patch that takes into account the common logger changes from 1180568. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 10:55 Message: Logged In: YES user_id=156487 If 1180568 is accepted, I'll need to make a couple changes to this patch. If they're both going to be accepted, either accept that one first and ask me to change this one or accept both and I'll submit another small patch to make the required changes. ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-04-11 09:55 Message: Logged In: YES user_id=28833 Sean, Apparently, you asked for this, I'm not sure what I think of the change. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 00:35 Message: Logged In: YES user_id=156487 6. This patch sorts the completions by screenname. They were previously unsorted. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 15:51:53
|
Patches item #1226022, was opened at 2005-06-23 01:06 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Reload modified plugins at runtime Initial Comment: Hello. When gaim is running, an updated .so-plugin is not reloaded (I am told script-plugins are reloaded though). So if anyone has re-installed a `native-plugin', he has to restart gaim to get that modified plugin to work. This patch allows a plugin to be reloaded at runtime. However, it reloads only when the plugin is not being used (ie, not loaded) and about to be used (ie, the user has checked the box at the preference-dialog) to make sure things don't go crazy. It makes life easier especially for people who create plugins. And makes thing somewhat consistent in the sense that plugins written in any language can be reloaded at runtime. This patch is against oldstatus. I took a look at HEAD, and I think little modifications will allow for this patch to go with HEAD as well. So if this way of doing things is OK, then I can create a patch against HEAD. -- Adil ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-23 11:51 Message: Logged In: YES user_id=20979 If gaim_plugin_reload() is never used then I get the feeling its original intention was to do what you're trying to do, and it would be better to change/replace it with your version. ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-06-23 09:00 Message: Logged In: YES user_id=1132702 I have now used g_stat (and updated the patch). grep tells me gaim_plugin_reload() is never called from anywhere (unless some plugin uses it). So changing/replacing it probably won't have any side-effects. -- Adil ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-23 08:38 Message: Logged In: YES user_id=20979 Definitely no configure flag (why would you ever want to disable this?) Is it possible to use g_stat or g_file_get_timestamp or something and avoid the use of stat? Could the plugin API reload a plugin automatically if it has changed, instead of making the preferences API deal with it? When is gaim_plugin_reload() used? Could it be changed to always do the "hard" reload? What side-effects would this have? ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-06-23 07:45 Message: Logged In: YES user_id=1132702 I added the stuff to work with prpl-s. Added the stuff in gaim_find_prpl (prpl.c) which seemed the most appropriate place to do it. I did a very simple check whether this works or not (changed a few strings in msn/session.c :-) ), and it seemed to work OK. But it'd be great if someone else checked these out and let me know the results. -- Adil ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-06-23 04:55 Message: Logged In: YES user_id=1132702 Perhaps I should reload only the modified *native* plugins? I am looking at prpl-s now. And it seems reloading the modified protocol-plugin can be done at gaim_connection_connect (connection.c) (it will of course, need to be made sure that no other account using that prpl is active) Perhaps this feature can/should be added with some configure-flags so that only the concerned people (the developers) have anything to do with it? -- Adil ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 15:50:15
|
Patches item #1224386, was opened at 2005-06-20 16:21 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Ethan Blanton (eblanton) Summary: Global pref for keepalive ping Initial Comment: Patch to ping IRC servers at arbitrary intervals in order to prevent connections from dropping. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-23 11:50 Message: Logged In: YES user_id=20979 I think timing out connections within 30 seconds constitutes a broken network, and I don't think the addition of this preference is really justified. If you want opinions from more people, feel free to raise the issue on gaim-devel. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-23 11:38 Message: Logged In: YES user_id=644705 OK, this run is as a global network pref, and uses gc->keepalive. On a decent network, the default *should* be fine, but there are some networks bad enough where this is not the case. Screenshot at http://bard.sytes.net/global_ping_again.jpg ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-22 13:40 Message: Logged In: YES user_id=199625 I don't actually mean to make it a preference, but if you *did*, it would be a single option in Network, not multiple options for each protocol. Regardless, there is no NAT device that can't keep a connection open for at least a minute. Leaving it unconfigurable should be fine. -s. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-22 13:37 Message: Logged In: YES user_id=644705 The point of this is that the buddy list keepalive isn't often enough in some circumstances. (Yes, the NAT is misconfigured, but it's not my NAT and I can't fix it!) I could add a global keepalive interval in GaimConnection, and let prpl maintainers use it or not at their whim, if that would be preferable. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 13:33 Message: Logged In: YES user_id=20979 Er, well it seems like you could add a preference to the preferences window... But I'm not sure that's really needed. After what Sean wrote, it sounds like maybe you could just implement gc->keepalive for IRC and make it so that it only sends the keepalive packet if your buddy list is empty. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-22 09:54 Message: Logged In: YES user_id=644705 If I add this option globally, it will require another field on the account options for EVERY builtin prpl. Will that really be acceptable? ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-21 17:41 Message: Logged In: YES user_id=199625 It took me a while to figure out why I was getting booted from Freenode, and then I discovered it was because my NAT wasn't keeping the connection open. Adding Nickserv to my buddy list *did* serve as a decent workaround. If that was the problem, you would be constantly kicked off other protocols such as AIM, as well, which would likewise need modification. gc->keepalive is certainly the correct place to send keepalive packets. -s. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-21 17:35 Message: Logged In: YES user_id=20979 I agree with Sean and Luke. I'm going to close this for now. If you take another stab at it, you may want to look into using gc->keepalive ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-06-21 10:16 Message: Logged In: YES user_id=28833 Sean is right. one minute *should* be enough. your NAT is badly configured ;-) that being said, I really have no basis on which to comment on this patch from a technical standpoint. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-21 09:17 Message: Logged In: YES user_id=644705 Once a minute is NOT enough, as evidenced by the fact that the workaround of putting someone on your buddy list isn't enough in several instances. It's on a per-irc-server basis now, because servers are *supposed* to ping their clients often enough to keep them alive; however, some (freenode) don't. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:56 Message: Logged In: YES user_id=199625 This function has no need to be configurable; once a minute should be plenty often enough to keep a NAT tunnel open, and if not the feature should be globally configurable so that AIM server pings happen more frequently as well. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-20 16:46 Message: Logged In: YES user_id=644705 The existing ison functionality isn't at adjustable intervals, and I thought it would be better to allow increasing the frequency of a single ping rather than whatever arbitrary number of buddies the user happens to have for each connection. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:26 Message: Logged In: YES user_id=199625 This is great, but implemented wrong. Find the existing IRC keepalive function, currently used solely to poll the buddy list with a RNG command, and if there is no buddy list, send a PNG command instead. -s. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 15:38:51
|
Patches item #1224386, was opened at 2005-06-20 16:21 Message generated for change (Comment added) made by tak_tak You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Ethan Blanton (eblanton) >Summary: Global pref for keepalive ping Initial Comment: Patch to ping IRC servers at arbitrary intervals in order to prevent connections from dropping. ---------------------------------------------------------------------- >Comment By: Levi Bard (tak_tak) Date: 2005-06-23 11:38 Message: Logged In: YES user_id=644705 OK, this run is as a global network pref, and uses gc->keepalive. On a decent network, the default *should* be fine, but there are some networks bad enough where this is not the case. Screenshot at http://bard.sytes.net/global_ping_again.jpg ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-22 13:40 Message: Logged In: YES user_id=199625 I don't actually mean to make it a preference, but if you *did*, it would be a single option in Network, not multiple options for each protocol. Regardless, there is no NAT device that can't keep a connection open for at least a minute. Leaving it unconfigurable should be fine. -s. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-22 13:37 Message: Logged In: YES user_id=644705 The point of this is that the buddy list keepalive isn't often enough in some circumstances. (Yes, the NAT is misconfigured, but it's not my NAT and I can't fix it!) I could add a global keepalive interval in GaimConnection, and let prpl maintainers use it or not at their whim, if that would be preferable. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 13:33 Message: Logged In: YES user_id=20979 Er, well it seems like you could add a preference to the preferences window... But I'm not sure that's really needed. After what Sean wrote, it sounds like maybe you could just implement gc->keepalive for IRC and make it so that it only sends the keepalive packet if your buddy list is empty. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-22 09:54 Message: Logged In: YES user_id=644705 If I add this option globally, it will require another field on the account options for EVERY builtin prpl. Will that really be acceptable? ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-21 17:41 Message: Logged In: YES user_id=199625 It took me a while to figure out why I was getting booted from Freenode, and then I discovered it was because my NAT wasn't keeping the connection open. Adding Nickserv to my buddy list *did* serve as a decent workaround. If that was the problem, you would be constantly kicked off other protocols such as AIM, as well, which would likewise need modification. gc->keepalive is certainly the correct place to send keepalive packets. -s. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-21 17:35 Message: Logged In: YES user_id=20979 I agree with Sean and Luke. I'm going to close this for now. If you take another stab at it, you may want to look into using gc->keepalive ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-06-21 10:16 Message: Logged In: YES user_id=28833 Sean is right. one minute *should* be enough. your NAT is badly configured ;-) that being said, I really have no basis on which to comment on this patch from a technical standpoint. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-21 09:17 Message: Logged In: YES user_id=644705 Once a minute is NOT enough, as evidenced by the fact that the workaround of putting someone on your buddy list isn't enough in several instances. It's on a per-irc-server basis now, because servers are *supposed* to ping their clients often enough to keep them alive; however, some (freenode) don't. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:56 Message: Logged In: YES user_id=199625 This function has no need to be configurable; once a minute should be plenty often enough to keep a NAT tunnel open, and if not the feature should be globally configurable so that AIM server pings happen more frequently as well. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-20 16:46 Message: Logged In: YES user_id=644705 The existing ison functionality isn't at adjustable intervals, and I thought it would be better to allow increasing the frequency of a single ping rather than whatever arbitrary number of buddies the user happens to have for each connection. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:26 Message: Logged In: YES user_id=199625 This is great, but implemented wrong. Find the existing IRC keepalive function, currently used solely to poll the buddy list with a RNG command, and if there is no buddy list, send a PNG command instead. -s. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 13:00:30
|
Patches item #1226022, was opened at 2005-06-23 11:06 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Reload modified plugins at runtime Initial Comment: Hello. When gaim is running, an updated .so-plugin is not reloaded (I am told script-plugins are reloaded though). So if anyone has re-installed a `native-plugin', he has to restart gaim to get that modified plugin to work. This patch allows a plugin to be reloaded at runtime. However, it reloads only when the plugin is not being used (ie, not loaded) and about to be used (ie, the user has checked the box at the preference-dialog) to make sure things don't go crazy. It makes life easier especially for people who create plugins. And makes thing somewhat consistent in the sense that plugins written in any language can be reloaded at runtime. This patch is against oldstatus. I took a look at HEAD, and I think little modifications will allow for this patch to go with HEAD as well. So if this way of doing things is OK, then I can create a patch against HEAD. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-06-23 19:00 Message: Logged In: YES user_id=1132702 I have now used g_stat (and updated the patch). grep tells me gaim_plugin_reload() is never called from anywhere (unless some plugin uses it). So changing/replacing it probably won't have any side-effects. -- Adil ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-23 18:38 Message: Logged In: YES user_id=20979 Definitely no configure flag (why would you ever want to disable this?) Is it possible to use g_stat or g_file_get_timestamp or something and avoid the use of stat? Could the plugin API reload a plugin automatically if it has changed, instead of making the preferences API deal with it? When is gaim_plugin_reload() used? Could it be changed to always do the "hard" reload? What side-effects would this have? ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-06-23 17:45 Message: Logged In: YES user_id=1132702 I added the stuff to work with prpl-s. Added the stuff in gaim_find_prpl (prpl.c) which seemed the most appropriate place to do it. I did a very simple check whether this works or not (changed a few strings in msn/session.c :-) ), and it seemed to work OK. But it'd be great if someone else checked these out and let me know the results. -- Adil ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-06-23 14:55 Message: Logged In: YES user_id=1132702 Perhaps I should reload only the modified *native* plugins? I am looking at prpl-s now. And it seems reloading the modified protocol-plugin can be done at gaim_connection_connect (connection.c) (it will of course, need to be made sure that no other account using that prpl is active) Perhaps this feature can/should be added with some configure-flags so that only the concerned people (the developers) have anything to do with it? -- Adil ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 12:38:38
|
Patches item #1226022, was opened at 2005-06-23 01:06 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Reload modified plugins at runtime Initial Comment: Hello. When gaim is running, an updated .so-plugin is not reloaded (I am told script-plugins are reloaded though). So if anyone has re-installed a `native-plugin', he has to restart gaim to get that modified plugin to work. This patch allows a plugin to be reloaded at runtime. However, it reloads only when the plugin is not being used (ie, not loaded) and about to be used (ie, the user has checked the box at the preference-dialog) to make sure things don't go crazy. It makes life easier especially for people who create plugins. And makes thing somewhat consistent in the sense that plugins written in any language can be reloaded at runtime. This patch is against oldstatus. I took a look at HEAD, and I think little modifications will allow for this patch to go with HEAD as well. So if this way of doing things is OK, then I can create a patch against HEAD. -- Adil ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-23 08:38 Message: Logged In: YES user_id=20979 Definitely no configure flag (why would you ever want to disable this?) Is it possible to use g_stat or g_file_get_timestamp or something and avoid the use of stat? Could the plugin API reload a plugin automatically if it has changed, instead of making the preferences API deal with it? When is gaim_plugin_reload() used? Could it be changed to always do the "hard" reload? What side-effects would this have? ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-06-23 07:45 Message: Logged In: YES user_id=1132702 I added the stuff to work with prpl-s. Added the stuff in gaim_find_prpl (prpl.c) which seemed the most appropriate place to do it. I did a very simple check whether this works or not (changed a few strings in msn/session.c :-) ), and it seemed to work OK. But it'd be great if someone else checked these out and let me know the results. -- Adil ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-06-23 04:55 Message: Logged In: YES user_id=1132702 Perhaps I should reload only the modified *native* plugins? I am looking at prpl-s now. And it seems reloading the modified protocol-plugin can be done at gaim_connection_connect (connection.c) (it will of course, need to be made sure that no other account using that prpl is active) Perhaps this feature can/should be added with some configure-flags so that only the concerned people (the developers) have anything to do with it? -- Adil ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 12:33:27
|
Patches item #1180490, was opened at 2005-04-11 01:10 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Mark Doliner (thekingant) Summary: Autocomplete Screennames in Dialogs Based on Logs Initial Comment: Here it is, the much anticipated (or not) patch to autocomplete screennames based on the logs on the disk. Additionally... 1. It fixes the bug where the View User Log box only had screennames for accounts which are currently online. It lists all accounts, so it should have all screennames as possible completions. 2. It fixes the name of the View User Log box to be "View User Log" instead of "Get User Log". This was done so it matched the menu item. 3. It brings the gaim_log_logger_new function in sync with the GaimLogLogger struct. 4. Some other minor documentation fixes. 5. A ChangeLog.API entry for the removal (by Nathan) of the gaim_find_conversation function. The only reason this is included is that no matter how I submitted the separate patches, you'd end up with separate conflicts because this patch has to add a ChangeLog.API line. This really shouldn't be a big deal, but I'm mentioning it for completeness. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-23 08:33 Message: Logged In: YES user_id=20979 Say I have the screen name "IStealCellPhones" in my buddy list, and I set their alias to "BlahBlah." If I type "bla" in the New Instant Message window, does it suggest "BlahBlah"? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-23 01:50 Message: Logged In: YES user_id=156487 What do you mean "show matching aliases"? ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 23:05 Message: Logged In: YES user_id=20979 deryni pointed out that the assertions were there before your patch, sorry about that. This looks good so I applied it. Would it be hard to also show matching aliases in the autocomplete? ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 21:41 Message: Logged In: YES user_id=20979 When testing this, I see a bajillion "GLib: g_str_has_prefix: assertion `str != NULL' failed" messages printed to the console when typing letters into the "New Instant Message" request dialog. I started Gaim with "gaim -d," I'm not sure if that'll make a difference. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-04 15:31 Message: Logged In: YES user_id=156487 Posting a new version of this patch. It will now apply cleanly against HEAD. It's exactly the same as what Sean reviewed, except: 1. I added another entry to the ChangeLog.API file to mark the additions this patch makes. The previous version of the patch only marked the changed function and not the additions. 2. I added an entry to the ChangeLog file for this feature addition. I hope I'm not being too presumptuous in adding this entry to the patch. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-04 14:32 Message: Logged In: YES user_id=199625 Mark: This looks pretty good to me, but I can't commit anything right now. Could you handle this patch when you get the chance? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-18 00:05 Message: Logged In: YES user_id=156487 Here's a new version of the patch that takes into account the common logger changes from 1180568. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 11:55 Message: Logged In: YES user_id=156487 If 1180568 is accepted, I'll need to make a couple changes to this patch. If they're both going to be accepted, either accept that one first and ask me to change this one or accept both and I'll submit another small patch to make the required changes. ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-04-11 10:55 Message: Logged In: YES user_id=28833 Sean, Apparently, you asked for this, I'm not sure what I think of the change. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 01:35 Message: Logged In: YES user_id=156487 6. This patch sorts the completions by screenname. They were previously unsorted. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 11:46:02
|
Patches item #1226022, was opened at 2005-06-23 11:06 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Reload modified plugins at runtime Initial Comment: Hello. When gaim is running, an updated .so-plugin is not reloaded (I am told script-plugins are reloaded though). So if anyone has re-installed a `native-plugin', he has to restart gaim to get that modified plugin to work. This patch allows a plugin to be reloaded at runtime. However, it reloads only when the plugin is not being used (ie, not loaded) and about to be used (ie, the user has checked the box at the preference-dialog) to make sure things don't go crazy. It makes life easier especially for people who create plugins. And makes thing somewhat consistent in the sense that plugins written in any language can be reloaded at runtime. This patch is against oldstatus. I took a look at HEAD, and I think little modifications will allow for this patch to go with HEAD as well. So if this way of doing things is OK, then I can create a patch against HEAD. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-06-23 17:45 Message: Logged In: YES user_id=1132702 I added the stuff to work with prpl-s. Added the stuff in gaim_find_prpl (prpl.c) which seemed the most appropriate place to do it. I did a very simple check whether this works or not (changed a few strings in msn/session.c :-) ), and it seemed to work OK. But it'd be great if someone else checked these out and let me know the results. -- Adil ---------------------------------------------------------------------- Comment By: Sadrul H C (sadrul) Date: 2005-06-23 14:55 Message: Logged In: YES user_id=1132702 Perhaps I should reload only the modified *native* plugins? I am looking at prpl-s now. And it seems reloading the modified protocol-plugin can be done at gaim_connection_connect (connection.c) (it will of course, need to be made sure that no other account using that prpl is active) Perhaps this feature can/should be added with some configure-flags so that only the concerned people (the developers) have anything to do with it? -- Adil ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 08:55:37
|
Patches item #1226022, was opened at 2005-06-23 11:06 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Reload modified plugins at runtime Initial Comment: Hello. When gaim is running, an updated .so-plugin is not reloaded (I am told script-plugins are reloaded though). So if anyone has re-installed a `native-plugin', he has to restart gaim to get that modified plugin to work. This patch allows a plugin to be reloaded at runtime. However, it reloads only when the plugin is not being used (ie, not loaded) and about to be used (ie, the user has checked the box at the preference-dialog) to make sure things don't go crazy. It makes life easier especially for people who create plugins. And makes thing somewhat consistent in the sense that plugins written in any language can be reloaded at runtime. This patch is against oldstatus. I took a look at HEAD, and I think little modifications will allow for this patch to go with HEAD as well. So if this way of doing things is OK, then I can create a patch against HEAD. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-06-23 14:55 Message: Logged In: YES user_id=1132702 Perhaps I should reload only the modified *native* plugins? I am looking at prpl-s now. And it seems reloading the modified protocol-plugin can be done at gaim_connection_connect (connection.c) (it will of course, need to be made sure that no other account using that prpl is active) Perhaps this feature can/should be added with some configure-flags so that only the concerned people (the developers) have anything to do with it? -- Adil ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 08:48:26
|
Patches item #1222650, was opened at 2005-06-17 14:18 Message generated for change (Comment added) made by gabbath You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222650&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Gabbath (gabbath) Assigned to: Nobody/Anonymous (nobody) Summary: small & useful buddylist tweaks (more Yahoo-like) Initial Comment: I diffed against official release 1.3.1 because i couldn't get cvs to work. very sorry, but it's a very small patch for gtkblist.c Changes: src/gtkblist.c -> added ctrl+h toggle for showing offline contacts or not -> changed the status message length to 40 instead of just 20 (ok, 40 may be a little too much, but 30-35 is really okay) -> changed buddy list small icon view to format "buddy - status", with status grayed out and buddy name bolded if online (bold+dim if idle... if checked in prefs of course) - very very similar to yahoo messenger's buddy list Description: uh, i'm too much of a yahoo user to not do this. but i think it's really useful. i've always liked a compact list, without buddy icons. but in small view i couldn't see my buddies' statuses. so i did this. i also made the status text longer because it was a bit short imho... ---------------------------------------------------------------------- >Comment By: Gabbath (gabbath) Date: 2005-06-23 08:48 Message: Logged In: YES user_id=1298580 indeed, auto-ellipsizing is the best idea. it was definetly my first choice but as a beginner i don't quite know where to start on implementing it. but as for the other stuff... i have a lot of friends using gaim and they share the same annoyance i do about not being able to see their statuses. the only reason they use big view is so that they can see the statuses. so showing status in small view can be useful too, and besides, with auto-ellipsizing and having the status text grayed out, the people you talk about (who want it compact etc) won't even notice it's there. i can't recall all the times i had to hover over a friend (in small view) just to see their status... really annoying. also, as a (former) yahoo user, i've found myself many times wanting to leave a message to someone offline and just thinking 'oh damn, gotta use the mouse again' (btw, i didn't say anything about toggling empty groups). and how much can a CTRL+O mapping annoy someone who didn't want it? he just won't use it. oh the other hand, i fully respect the fact that gaim should have its own personality, but still, users switching to gaim from their default msn, yahoo etc clients need to feel at home with gaim and so they need to have as many of the features they were used to as possible. in conclusion, all i ask is that you take into consideration that some people would/may like these features (not necessarily in the form i've submitted them). ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-23 02:49 Message: Logged In: YES user_id=20979 I definitely don't like having a keyboard shortcut to toggle showing offline buddies and empty groups. In fact, I'm going to remove that from CVS HEAD. I think changing 20 to 30 might cause people to complain that their buddy list is too wide, and I don't think I want to change that. However, it might be possible to have gtk auto ellipsize this. And as for showing the status text in the small buddy list... I think this is a bad idea. The small buddy list should be small and simple and the big buddy list should be compact. From what I've seen, people who use the compact layout tend to REALLY like things to be compact and useless, and I'm not sure changing that is a good idea. ---------------------------------------------------------------------- Comment By: Gabbath (gabbath) Date: 2005-06-19 10:03 Message: Logged In: YES user_id=1298580 uh, text got deleted just before i wanted to send: 1. Agreed, I had no preference for CTRL+H, just wanted a shortcut and yahoo messenger suggested that one... so CTRL+O it is :) 2. 40 is a bit long, but 30 is really OK. It's not critical info, but I just found myself hovering over the buddylist and waiting for tooltips to appear so I'm guessing it should be a little longer. Besides, lots of people display the song from winamp in yahoo messenger and with 20 chars you just see the artist :P 3. Agree here too. Didn't really like the bold, but those dim icons are a bit hard to tell apart, so i thought the text should be somewhat different too. In conclusion, here's a new diff for gtkblist, with CTRL+O, 30 chars and no bold (aah, much better). But still, the status showing in both big & small view should be a good idea (actually this was one thing that bugged me with gaim as i liked small view but wanted to also see my friends' statuses) ---------------------------------------------------------------------- Comment By: Gabbath (gabbath) Date: 2005-06-19 10:03 Message: Logged In: YES user_id=1298580 uh, text got deleted just before i wanted to send: 1. Agreed, I had no preference for CTRL+H, just wanted a shortcut and yahoo messenger suggested that one... so CTRL+O it is :) 2. 40 is a bit long, but 30 is really OK. It's not critical info, but I just found myself hovering over the buddylist and waiting for tooltips to appear so I'm guessing it should be a little longer. Besides, lots of people display the song from winamp in yahoo messenger and with 20 chars you just see the artist :P 3. Agree here too. Didn't really like the bold, but those dim icons are a bit hard to tell apart, so i thought the text should be somewhat different too. In conclusion, here's a new diff for gtkblist, with CTRL+O, 30 chars and no bold (aah, much better). But still, the status showing in both big & small view should be a good idea (actually this was one thing that bugged me with gaim as i liked small view but wanted to also see my friends' statuses) ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-19 08:08 Message: Logged In: YES user_id=407708 A few comments: 1. CTRL+O is mapped for showing offline buddies in HEAD. I suggest leaving CTRL+H alone, as H would tend to infer (H)elp. It'd be best if you just prepare a backport of the HEAD cvs code, rather than have different code. 2. Why is 20 insufficient? What critical infomation might one miss between chars 20-40? 3. 'Offline' status is indicated by a different protocol icon (in Y!'s case, the Y! happy face with a 'no entry' type indicator over it). As this icon is not used to indicate any form of online buddy, I don't see the need for the additional hacking you've done. ---------------------------------------------------------------------- Comment By: Gabbath (gabbath) Date: 2005-06-18 09:05 Message: Logged In: YES user_id=1298580 i made online buddies bold so that you can tell dimmed idle buddies from offline buddies. if anyone has a better idea for this, feel free to tell me. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222650&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 05:50:51
|
Patches item #1180490, was opened at 2005-04-11 00:10 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Mark Doliner (thekingant) Summary: Autocomplete Screennames in Dialogs Based on Logs Initial Comment: Here it is, the much anticipated (or not) patch to autocomplete screennames based on the logs on the disk. Additionally... 1. It fixes the bug where the View User Log box only had screennames for accounts which are currently online. It lists all accounts, so it should have all screennames as possible completions. 2. It fixes the name of the View User Log box to be "View User Log" instead of "Get User Log". This was done so it matched the menu item. 3. It brings the gaim_log_logger_new function in sync with the GaimLogLogger struct. 4. Some other minor documentation fixes. 5. A ChangeLog.API entry for the removal (by Nathan) of the gaim_find_conversation function. The only reason this is included is that no matter how I submitted the separate patches, you'd end up with separate conflicts because this patch has to add a ChangeLog.API line. This really shouldn't be a big deal, but I'm mentioning it for completeness. ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-06-23 00:50 Message: Logged In: YES user_id=156487 What do you mean "show matching aliases"? ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 22:05 Message: Logged In: YES user_id=20979 deryni pointed out that the assertions were there before your patch, sorry about that. This looks good so I applied it. Would it be hard to also show matching aliases in the autocomplete? ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 20:41 Message: Logged In: YES user_id=20979 When testing this, I see a bajillion "GLib: g_str_has_prefix: assertion `str != NULL' failed" messages printed to the console when typing letters into the "New Instant Message" request dialog. I started Gaim with "gaim -d," I'm not sure if that'll make a difference. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-04 14:31 Message: Logged In: YES user_id=156487 Posting a new version of this patch. It will now apply cleanly against HEAD. It's exactly the same as what Sean reviewed, except: 1. I added another entry to the ChangeLog.API file to mark the additions this patch makes. The previous version of the patch only marked the changed function and not the additions. 2. I added an entry to the ChangeLog file for this feature addition. I hope I'm not being too presumptuous in adding this entry to the patch. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-04 13:32 Message: Logged In: YES user_id=199625 Mark: This looks pretty good to me, but I can't commit anything right now. Could you handle this patch when you get the chance? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-17 23:05 Message: Logged In: YES user_id=156487 Here's a new version of the patch that takes into account the common logger changes from 1180568. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 10:55 Message: Logged In: YES user_id=156487 If 1180568 is accepted, I'll need to make a couple changes to this patch. If they're both going to be accepted, either accept that one first and ask me to change this one or accept both and I'll submit another small patch to make the required changes. ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-04-11 09:55 Message: Logged In: YES user_id=28833 Sean, Apparently, you asked for this, I'm not sure what I think of the change. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 00:35 Message: Logged In: YES user_id=156487 6. This patch sorts the completions by screenname. They were previously unsorted. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 05:06:28
|
Patches item #1226022, was opened at 2005-06-23 11:06 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Reload modified plugins at runtime Initial Comment: Hello. When gaim is running, an updated .so-plugin is not reloaded (I am told script-plugins are reloaded though). So if anyone has re-installed a `native-plugin', he has to restart gaim to get that modified plugin to work. This patch allows a plugin to be reloaded at runtime. However, it reloads only when the plugin is not being used (ie, not loaded) and about to be used (ie, the user has checked the box at the preference-dialog) to make sure things don't go crazy. It makes life easier especially for people who create plugins. And makes thing somewhat consistent in the sense that plugins written in any language can be reloaded at runtime. This patch is against oldstatus. I took a look at HEAD, and I think little modifications will allow for this patch to go with HEAD as well. So if this way of doing things is OK, then I can create a patch against HEAD. -- Adil ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1226022&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 03:05:26
|
Patches item #1180490, was opened at 2005-04-11 01:10 Message generated for change (Settings changed) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Mark Doliner (thekingant) Summary: Autocomplete Screennames in Dialogs Based on Logs Initial Comment: Here it is, the much anticipated (or not) patch to autocomplete screennames based on the logs on the disk. Additionally... 1. It fixes the bug where the View User Log box only had screennames for accounts which are currently online. It lists all accounts, so it should have all screennames as possible completions. 2. It fixes the name of the View User Log box to be "View User Log" instead of "Get User Log". This was done so it matched the menu item. 3. It brings the gaim_log_logger_new function in sync with the GaimLogLogger struct. 4. Some other minor documentation fixes. 5. A ChangeLog.API entry for the removal (by Nathan) of the gaim_find_conversation function. The only reason this is included is that no matter how I submitted the separate patches, you'd end up with separate conflicts because this patch has to add a ChangeLog.API line. This really shouldn't be a big deal, but I'm mentioning it for completeness. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 23:05 Message: Logged In: YES user_id=20979 deryni pointed out that the assertions were there before your patch, sorry about that. This looks good so I applied it. Would it be hard to also show matching aliases in the autocomplete? ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 21:41 Message: Logged In: YES user_id=20979 When testing this, I see a bajillion "GLib: g_str_has_prefix: assertion `str != NULL' failed" messages printed to the console when typing letters into the "New Instant Message" request dialog. I started Gaim with "gaim -d," I'm not sure if that'll make a difference. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-04 15:31 Message: Logged In: YES user_id=156487 Posting a new version of this patch. It will now apply cleanly against HEAD. It's exactly the same as what Sean reviewed, except: 1. I added another entry to the ChangeLog.API file to mark the additions this patch makes. The previous version of the patch only marked the changed function and not the additions. 2. I added an entry to the ChangeLog file for this feature addition. I hope I'm not being too presumptuous in adding this entry to the patch. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-04 14:32 Message: Logged In: YES user_id=199625 Mark: This looks pretty good to me, but I can't commit anything right now. Could you handle this patch when you get the chance? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-18 00:05 Message: Logged In: YES user_id=156487 Here's a new version of the patch that takes into account the common logger changes from 1180568. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 11:55 Message: Logged In: YES user_id=156487 If 1180568 is accepted, I'll need to make a couple changes to this patch. If they're both going to be accepted, either accept that one first and ask me to change this one or accept both and I'll submit another small patch to make the required changes. ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-04-11 10:55 Message: Logged In: YES user_id=28833 Sean, Apparently, you asked for this, I'm not sure what I think of the change. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 01:35 Message: Logged In: YES user_id=156487 6. This patch sorts the completions by screenname. They were previously unsorted. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 02:49:20
|
Patches item #1222650, was opened at 2005-06-17 10:18 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222650&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Rejected Priority: 5 Submitted By: Gabbath (gabbath) Assigned to: Nobody/Anonymous (nobody) Summary: small & useful buddylist tweaks (more Yahoo-like) Initial Comment: I diffed against official release 1.3.1 because i couldn't get cvs to work. very sorry, but it's a very small patch for gtkblist.c Changes: src/gtkblist.c -> added ctrl+h toggle for showing offline contacts or not -> changed the status message length to 40 instead of just 20 (ok, 40 may be a little too much, but 30-35 is really okay) -> changed buddy list small icon view to format "buddy - status", with status grayed out and buddy name bolded if online (bold+dim if idle... if checked in prefs of course) - very very similar to yahoo messenger's buddy list Description: uh, i'm too much of a yahoo user to not do this. but i think it's really useful. i've always liked a compact list, without buddy icons. but in small view i couldn't see my buddies' statuses. so i did this. i also made the status text longer because it was a bit short imho... ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 22:49 Message: Logged In: YES user_id=20979 I definitely don't like having a keyboard shortcut to toggle showing offline buddies and empty groups. In fact, I'm going to remove that from CVS HEAD. I think changing 20 to 30 might cause people to complain that their buddy list is too wide, and I don't think I want to change that. However, it might be possible to have gtk auto ellipsize this. And as for showing the status text in the small buddy list... I think this is a bad idea. The small buddy list should be small and simple and the big buddy list should be compact. From what I've seen, people who use the compact layout tend to REALLY like things to be compact and useless, and I'm not sure changing that is a good idea. ---------------------------------------------------------------------- Comment By: Gabbath (gabbath) Date: 2005-06-19 06:03 Message: Logged In: YES user_id=1298580 uh, text got deleted just before i wanted to send: 1. Agreed, I had no preference for CTRL+H, just wanted a shortcut and yahoo messenger suggested that one... so CTRL+O it is :) 2. 40 is a bit long, but 30 is really OK. It's not critical info, but I just found myself hovering over the buddylist and waiting for tooltips to appear so I'm guessing it should be a little longer. Besides, lots of people display the song from winamp in yahoo messenger and with 20 chars you just see the artist :P 3. Agree here too. Didn't really like the bold, but those dim icons are a bit hard to tell apart, so i thought the text should be somewhat different too. In conclusion, here's a new diff for gtkblist, with CTRL+O, 30 chars and no bold (aah, much better). But still, the status showing in both big & small view should be a good idea (actually this was one thing that bugged me with gaim as i liked small view but wanted to also see my friends' statuses) ---------------------------------------------------------------------- Comment By: Gabbath (gabbath) Date: 2005-06-19 06:03 Message: Logged In: YES user_id=1298580 uh, text got deleted just before i wanted to send: 1. Agreed, I had no preference for CTRL+H, just wanted a shortcut and yahoo messenger suggested that one... so CTRL+O it is :) 2. 40 is a bit long, but 30 is really OK. It's not critical info, but I just found myself hovering over the buddylist and waiting for tooltips to appear so I'm guessing it should be a little longer. Besides, lots of people display the song from winamp in yahoo messenger and with 20 chars you just see the artist :P 3. Agree here too. Didn't really like the bold, but those dim icons are a bit hard to tell apart, so i thought the text should be somewhat different too. In conclusion, here's a new diff for gtkblist, with CTRL+O, 30 chars and no bold (aah, much better). But still, the status showing in both big & small view should be a good idea (actually this was one thing that bugged me with gaim as i liked small view but wanted to also see my friends' statuses) ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-19 04:08 Message: Logged In: YES user_id=407708 A few comments: 1. CTRL+O is mapped for showing offline buddies in HEAD. I suggest leaving CTRL+H alone, as H would tend to infer (H)elp. It'd be best if you just prepare a backport of the HEAD cvs code, rather than have different code. 2. Why is 20 insufficient? What critical infomation might one miss between chars 20-40? 3. 'Offline' status is indicated by a different protocol icon (in Y!'s case, the Y! happy face with a 'no entry' type indicator over it). As this icon is not used to indicate any form of online buddy, I don't see the need for the additional hacking you've done. ---------------------------------------------------------------------- Comment By: Gabbath (gabbath) Date: 2005-06-18 05:05 Message: Logged In: YES user_id=1298580 i made online buddies bold so that you can tell dimmed idle buddies from offline buddies. if anyone has a better idea for this, feel free to tell me. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222650&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 02:48:22
|
Patches item #1224919, was opened at 2005-06-21 21:26 Message generated for change (Comment added) made by sadrul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224919&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Backport: Adding `Show Buddy Icon' in the conv-window menu Initial Comment: Hello. Copied the changes from HEAD. -- Adil ---------------------------------------------------------------------- >Comment By: Sadrul H C (sadrul) Date: 2005-06-23 08:48 Message: Logged In: YES user_id=1132702 This is not urgently needed in oldstatus :-) A couple of people asked about this at #gaim on the same day, and I was in a `PATH MODE' ;). And considering there's no saying which year HEAD is going to release, I saw no harm backporting this :-) -- Adil ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-23 04:15 Message: Logged In: YES user_id=20979 I'd rather not get into the habit of backporting everything from HEAD. This doesn't seem like it's something that is urgently needed in oldstatus. Unless you can convince me otherwise? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224919&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 02:37:35
|
Patches item #1217958, was opened at 2005-06-10 01:00 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Plugins Group: None >Status: Closed >Resolution: Postponed Priority: 5 Submitted By: Tim Hentenaar (matriarktervel) Assigned to: Nobody/Anonymous (nobody) Summary: New Prpl Initial Comment: This prpl implements the PalTalk Protocol in oldstatus CVS. I did most of the reverse engineering with PalTalk 5.x about a year ago, and finally got around to writing a prpl for it. I have updated it to be compatible with the new PalTalk 8.x clients [there were some protocol changes in between]. I'm planning to port this up to head once it becomes a bit more stable. I have tested this with gaim 1.3.0 stable and oldstatus. The attached file contains a diff against this evening's oldstatus (6/9), and the additional files. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 22:37 Message: Logged In: YES user_id=20979 I agree that maintaining this separately is a good idea for now. If demand for the protocol increases we'll reconsider including it. But this way it'll be easy for you to continue developing it. If you set up a web page somewhere we can add a link to you from http://gaim.sourceforge.net/plugins.php Also, any voice/video code should go into gaim-vv for now. It would be awesome if you worked with them. Once that project has matured some the voice/video code will be merged back into Gaim proper. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-21 22:07 Message: Logged In: YES user_id=156487 It would be much better if you'd actively work with the gaim-vv team on the design. That way, you could end up with code that works for both of you. This is good for both parties because it increases the number of developers for the code, reduces code duplication (your plugin can use the sound subsystem you wrote which would be merged into gaim-vv and eventually gaim), and shows that you're willing to cooperate. It likely won't take much extra time, and you'll probably get good ideas from the gaim-vv guys in the process. ---------------------------------------------------------------------- Comment By: Tim Hentenaar (matriarktervel) Date: 2005-06-21 20:44 Message: Logged In: YES user_id=634325 If they would like to use my sound code, once I get it stable, they're more than welcome to. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-21 20:31 Message: Logged In: YES user_id=407708 It's a pity you have decided to implement your own sound subsystem rather than help out the gaim-vv team, whether it uses gstreamer or not. ---------------------------------------------------------------------- Comment By: Tim Hentenaar (matriarktervel) Date: 2005-06-21 20:20 Message: Logged In: YES user_id=634325 I deleted the attachement because the code was a bit more buggy than I would have liked. I've since fixed it, and I've been implementing some features that aren't already present in gaim (i.e. audio support, yes I know about gaim-vv, but they don't have audio support yet, and I don't really like how buggy gstreamer is.) I've been maintaining it in a private CVS that I've been keeping in step with oldstatus-cvs. My code could still be integrated into oldstatus, with a few modifications. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-21 18:08 Message: Logged In: YES user_id=407708 What happened to the attachment? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-11 17:56 Message: Logged In: YES user_id=156487 I'd recommend maintaining this separate of Gaim. See meanwhile.sf.net as an example. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 02:34:25
|
Patches item #1218075, was opened at 2005-06-10 05:58 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1218075&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Stanislav Brabec (sbrabec) Assigned to: Mark Doliner (thekingant) Summary: strict aliasing fix Initial Comment: Attached patch fixed code to conform GCC strict aliasing rules. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 22:34 Message: Logged In: YES user_id=20979 Thanks ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1218075&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 02:23:52
|
Patches item #1222377, was opened at 2005-06-17 01:39 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222377&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Evan Schoenberg (evands) Assigned to: Mark Doliner (thekingant) Summary: [OSCAR] Improve buddy icon retrieval Initial Comment: When retrieving the userinfo and then using that data to request a buddy icon, a value in Gaim was previously hardcoded to 0x01. It's called "number" in locate.c... seems that it is unclear what exactly it means. In any vase, buddy icon checksums had to have a "number" of 0x01. However, 0x00 is also a valid "number." Fire calls this field iconcsumtype, so I've used that name for it. iconcsumtype is passed back to aim_bart_request() where it is used [it will be either 0x00 or 0x01, whereas Gaim was always assuming it was 0x01]. The result: Certain buddy icons which Gaim previously could not retrieve are now retrieveable. I believe that these are primarily coming from old clients; a clear example (and my test case for finding this fix) is the AOLYellowPages buddy, run by the AIM server. Before the patch, no icon; with the patch, the icon as properly retrieved by the official client. This patch is ported... sideported?... from Fire's modified libfaim; I noticed Fire was doing a better job retrieving buddy icons than Gaim was, and hunted down the cause. Applies against oldstatus and HEAD. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 22:23 Message: Logged In: YES user_id=20979 Nicely done, thanks ---------------------------------------------------------------------- Comment By: Evan Schoenberg (evands) Date: 2005-06-22 18:51 Message: Logged In: YES user_id=669684 The problem was that we were being overzealous with getting icons, in a sense... some AIM clients send a blank GIF if no icon is set, presumably because this used to be necessary, using that 0x00 iconcsumtype. The attached patch now avoids treating these as actual buddy icons; the commonality is that they have a iconlen of 90, which is not something that any real buddy icon would be likely to have, so we just ignore them. ---------------------------------------------------------------------- Comment By: Evan Schoenberg (evands) Date: 2005-06-20 13:21 Message: Logged In: YES user_id=669684 Clarification: I meant certain other icons, not all other icons. Expansion: This patch also lets Gaim retrieve icons from users of recent versions of AOL for Windows, which was not possible before. ---------------------------------------------------------------------- Comment By: Evan Schoenberg (evands) Date: 2005-06-19 14:13 Message: Logged In: YES user_id=669684 Hmm... further testing shows that this seems to cause OTHER icons not to appear properly; Gaim gets an icon, but it is blank. I'll investigate this further... any suggestions as to the cause would be much appreciated. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222377&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-23 01:41:39
|
Patches item #1180490, was opened at 2005-04-11 01:10 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Mark Doliner (thekingant) Summary: Autocomplete Screennames in Dialogs Based on Logs Initial Comment: Here it is, the much anticipated (or not) patch to autocomplete screennames based on the logs on the disk. Additionally... 1. It fixes the bug where the View User Log box only had screennames for accounts which are currently online. It lists all accounts, so it should have all screennames as possible completions. 2. It fixes the name of the View User Log box to be "View User Log" instead of "Get User Log". This was done so it matched the menu item. 3. It brings the gaim_log_logger_new function in sync with the GaimLogLogger struct. 4. Some other minor documentation fixes. 5. A ChangeLog.API entry for the removal (by Nathan) of the gaim_find_conversation function. The only reason this is included is that no matter how I submitted the separate patches, you'd end up with separate conflicts because this patch has to add a ChangeLog.API line. This really shouldn't be a big deal, but I'm mentioning it for completeness. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 21:41 Message: Logged In: YES user_id=20979 When testing this, I see a bajillion "GLib: g_str_has_prefix: assertion `str != NULL' failed" messages printed to the console when typing letters into the "New Instant Message" request dialog. I started Gaim with "gaim -d," I'm not sure if that'll make a difference. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-04 15:31 Message: Logged In: YES user_id=156487 Posting a new version of this patch. It will now apply cleanly against HEAD. It's exactly the same as what Sean reviewed, except: 1. I added another entry to the ChangeLog.API file to mark the additions this patch makes. The previous version of the patch only marked the changed function and not the additions. 2. I added an entry to the ChangeLog file for this feature addition. I hope I'm not being too presumptuous in adding this entry to the patch. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-04 14:32 Message: Logged In: YES user_id=199625 Mark: This looks pretty good to me, but I can't commit anything right now. Could you handle this patch when you get the chance? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-18 00:05 Message: Logged In: YES user_id=156487 Here's a new version of the patch that takes into account the common logger changes from 1180568. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 11:55 Message: Logged In: YES user_id=156487 If 1180568 is accepted, I'll need to make a couple changes to this patch. If they're both going to be accepted, either accept that one first and ask me to change this one or accept both and I'll submit another small patch to make the required changes. ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-04-11 10:55 Message: Logged In: YES user_id=28833 Sean, Apparently, you asked for this, I'm not sure what I think of the change. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 01:35 Message: Logged In: YES user_id=156487 6. This patch sorts the completions by screenname. They were previously unsorted. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 23:26:19
|
Patches item #1222074, was opened at 2005-06-16 13:17 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222074&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Rejected Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Nobody/Anonymous (nobody) Summary: Proposed gnome browser pref patch Initial Comment: Proposed gnome browser pref patch ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 19:26 Message: Logged In: YES user_id=20979 I agree with rlaager, but I have a feeling Sean would veto this even if you managed to produce something that I thought was acceptable. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-19 00:37 Message: Logged In: YES user_id=156487 If the screenshot matches the code, I renew my suggestion that this be formatted like this: Browser: <the link> There is no need for the two unsensitive (greyed out) options and the drop-down with GNOME default should not be sensitive when you can't do anything with it. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-17 09:10 Message: Logged In: YES user_id=644705 Screenshot at http://bard.sytes.net/gaim-gnome-browser-pref.jpg ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-16 17:24 Message: Logged In: YES user_id=20979 Do you think you could post a screen shot of the pref window? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222074&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 23:23:19
|
Patches item #1223459, was opened at 2005-06-19 01:09 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223459&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Fix "Last Seen" in HEAD Initial Comment: The Last Seen feature has been broken for quite a while, perhaps since it was first forward-ported to HEAD from my patch. It was designed to show in the tooltip for offline buddies and buddies who had just signed on. It is of no use for a buddy who is currently online. Since GAIM_BUDDY_SIGNING_ON seems to be going away, I removed it from the conditional. Also, I've updated the Last Seen feature to take contacts into account. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 19:23 Message: Logged In: YES user_id=20979 Pretty ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223459&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 23:20:24
|
Patches item #896804, was opened at 2004-02-13 16:38 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=896804&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Jonas Birmé (birme) Assigned to: Ethan Blanton (eblanton) Summary: DIRCProxy support Initial Comment: Added some support for anyone connected to a Detachable IRC Proxy (www.dircproxy.net). For example, it now detaches from the proxy when the chat-window is closed. And /dircproxy commands can be sent without using the /quote command. Added a config option for the IRC protocol to specify whether the IRC server connected to is a DIRC proxy. This was of quite personal interest, but I thought maybe someone else was interested too. /Jonas ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-22 18:20 Message: Logged In: YES user_id=156487 Is this something that could be implemented as a plugin? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=896804&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 23:12:44
|
Patches item #1224555, was opened at 2005-06-21 01:50 Message generated for change (Comment added) made by enix You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224555&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Enix (enix) Assigned to: Nobody/Anonymous (nobody) Summary: [HEAD, Oldstatus] Tooltip appears over gtkblist context menu Initial Comment: When the gtkblist context menu is displayed, the tooltip timeout is not removed. This results in the tooltip displaying over the context menu when the timeout occurs. Included is a short patch to remove the timeout before displaying the context menu. Applies against HEAD and Oldstatus. ---------------------------------------------------------------------- >Comment By: Enix (enix) Date: 2005-06-22 23:12 Message: Logged In: YES user_id=17877 i just attached a screenshot of the problem on windows XP ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 22:35 Message: Logged In: YES user_id=20979 I can't reproduce the problem you're describing. Do you only have this problem when using MS Windows? Could you take a screen shot? I'm not opposed to fixing this, but it sounds like it might be something we'll want to file a gtk bug about (I'm thinking that when the context menu is open then the blist should not have focus, and should therefore not display the tooltip). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224555&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 23:11:02
|
Patches item #1223463, was opened at 2005-06-19 01:40 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223463&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: buddy-icon-cached Signal Documentation Initial Comment: I forgot to document the buddy-icon-cached signal in the patch I submitted which added it. This patch adds the entry in ChangeLog.API as well as Doxygen documentation. This creates a new file which will need to be cvs added: doc/buddyicon-signals.dox ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 19:11 Message: Logged In: YES user_id=20979 Radical ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223463&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 23:08:21
|
Patches item #1224610, was opened at 2005-06-21 00:49 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224610&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Buddy Icons Not Being Removed Initial Comment: Buddy icon cache files are removed when replacing icons but not when unsetting the icon. This patch corrects that. I think this fixes the only case where buddy icon cache files are not being deleted when they should be. I'd like to hear if anyone is seeing otherwise after this patch is applied. ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-06-22 18:08 Message: Logged In: YES user_id=156487 I thought about adding a function to buddylist.c to delete the icon file. With the current architecture, that spot in blist.c is the only non-buddyicon.c code to delete a buddy icon cache file. I wasn't sure that it justified adding another public function. Also, there's the issue of increasing the minor version on oldstatus. It sounds like you'd have no objections to a new function in buddylist.c, so I'll rework the patch to add one. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 17:27 Message: Logged In: YES user_id=20979 It looks like gaim_buddy_icon_cache() in src/buddylist.c is responsible for writing the buddy icon file? Would it make more sense if blist.c called a buddylist.c function to delete the icon file? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224610&group_id=235 |
3 messages has been excluded from this view by a project administrator.
