From: SourceForge.net <no...@so...> - 2005-06-23 12:33:27
|
Patches item #1180490, was opened at 2005-04-11 01:10 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Mark Doliner (thekingant) Summary: Autocomplete Screennames in Dialogs Based on Logs Initial Comment: Here it is, the much anticipated (or not) patch to autocomplete screennames based on the logs on the disk. Additionally... 1. It fixes the bug where the View User Log box only had screennames for accounts which are currently online. It lists all accounts, so it should have all screennames as possible completions. 2. It fixes the name of the View User Log box to be "View User Log" instead of "Get User Log". This was done so it matched the menu item. 3. It brings the gaim_log_logger_new function in sync with the GaimLogLogger struct. 4. Some other minor documentation fixes. 5. A ChangeLog.API entry for the removal (by Nathan) of the gaim_find_conversation function. The only reason this is included is that no matter how I submitted the separate patches, you'd end up with separate conflicts because this patch has to add a ChangeLog.API line. This really shouldn't be a big deal, but I'm mentioning it for completeness. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-23 08:33 Message: Logged In: YES user_id=20979 Say I have the screen name "IStealCellPhones" in my buddy list, and I set their alias to "BlahBlah." If I type "bla" in the New Instant Message window, does it suggest "BlahBlah"? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-23 01:50 Message: Logged In: YES user_id=156487 What do you mean "show matching aliases"? ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 23:05 Message: Logged In: YES user_id=20979 deryni pointed out that the assertions were there before your patch, sorry about that. This looks good so I applied it. Would it be hard to also show matching aliases in the autocomplete? ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 21:41 Message: Logged In: YES user_id=20979 When testing this, I see a bajillion "GLib: g_str_has_prefix: assertion `str != NULL' failed" messages printed to the console when typing letters into the "New Instant Message" request dialog. I started Gaim with "gaim -d," I'm not sure if that'll make a difference. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-04 15:31 Message: Logged In: YES user_id=156487 Posting a new version of this patch. It will now apply cleanly against HEAD. It's exactly the same as what Sean reviewed, except: 1. I added another entry to the ChangeLog.API file to mark the additions this patch makes. The previous version of the patch only marked the changed function and not the additions. 2. I added an entry to the ChangeLog file for this feature addition. I hope I'm not being too presumptuous in adding this entry to the patch. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-04 14:32 Message: Logged In: YES user_id=199625 Mark: This looks pretty good to me, but I can't commit anything right now. Could you handle this patch when you get the chance? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-18 00:05 Message: Logged In: YES user_id=156487 Here's a new version of the patch that takes into account the common logger changes from 1180568. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 11:55 Message: Logged In: YES user_id=156487 If 1180568 is accepted, I'll need to make a couple changes to this patch. If they're both going to be accepted, either accept that one first and ask me to change this one or accept both and I'll submit another small patch to make the required changes. ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-04-11 10:55 Message: Logged In: YES user_id=28833 Sean, Apparently, you asked for this, I'm not sure what I think of the change. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-04-11 01:35 Message: Logged In: YES user_id=156487 6. This patch sorts the completions by screenname. They were previously unsorted. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1180490&group_id=235 |