pidgin-patches Mailing List for Pidgin IM (Page 74)

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Patches item #1062630, was opened at 2004-11-08 20:51
Message generated for change (Comment added) made by alceste
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1062630&group_id=235

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Alceste Scalas (alceste)
Assigned to: Sean Egan (seanegan)
Summary: Better drag'n'drop and .desktop file support

Initial Comment:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

here's quite a big patch that adds some functionality
to drag'n'drop
of files in Gaim.

ChangeLog:

* the code for d'n'd of files is now contained in two
new files
  (dnd-file.[ch]), used by both gtkblist.c and gtkconv.c;

* more information is given in case of failure when
sending files
  (users trying to send files will be warned when the
operation is not
  suppported, when the recipient can't receive files,
etc.);

* when users drag'n'drop an image, they will be asked
whether they
  want to send it, insert it in the conversation (if
protocol supports
  it) or use it as a custom buddy icon;

* more feedback when users try d'n'd operations that
don't actually
  work (sending folders, sending files in chat rooms
instead of
  one-to-one conversations, etc.);

* .desktop file support: part of the GNOME code for
.desktop files
  parsing has been ported in two new files
(gaim-desktop-item.[ch]).
  When users drag'n'drop a desktop launcher, they will
be asked
  whether they want to insert the URL of the launcher
(if any) in the
  conversation, send the .desktop file icon, or send
the .desktop file
  itself.

The last point should apply for this GNOME bounty:

    "Gaim drag and drop file transfer"
    http://www.gnome.org/bounties/IM.html#127547

Does it apply?  Basic d'n'd file transfer was still
implemented in
Gaim, but the whole .desktop file management needed to
be done...

Anyway...  Here's the patch (see attachment).  The
archive contains a
.diff and 4 new files to be added in the src/ folder in
Gaim source
tree.

Have fun!

sha1sum:
d31cd7db5abaf5f9546b35a11d9d23292e2c5a8b 
gaim-dnd-desktop-patch.tar.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBj8yDjNQAc7KwCn8RAvZRAJ423xeAb0f7C6BdncBGn7wf1TjiqwCfY44h
UyuMu1wCvFFWxjabqSkMWcQ=
=9jua
-----END PGP SIGNATURE-----

----------------------------------------------------------------------

>Comment By: Alceste Scalas (alceste)
Date: 2004-11-15 00:57

Message:
Logged In: YES 
user_id=579277

Regarding the "drag_move" change: you want to make the
widgets cancel the drop *and* then warn the user with a dialog?

I ask it because i've added some warning dialogs in
serv_send_file() just to make users aware when a file
transfer couldn't be accomplished for some reason. Just
disallowing a drag'n'drop without a further notice wouldn't
make things more clear IMHO (well, i'm not an usability
expert at all, anyway).

Regarding sending .desktop files, i can see the following
scenario: Joe Sixpack installs some application that doesn't
have a menu icon; then he asks for help on #newbies, and
Andrew Average sends him a .desktop file ready to be
drag'n'dropped in the applications:// Nautilus window.

It may be useful expecially if the .desktop file executes
some complicated command (e.g. 'env LANG=C VAR1=1 VAR2=2
progname param1 param2...').

Well, maybe sending a .desktop file is an operation for
medium/advanced users only. Furthermore, medium/advanced
users can also right-click on a buddy, select "Send file"
and browse to their .desktop files --- so drag'n'drop'n'send
of .desktop file is not fundamental anyway... even if it may
be useful... ?:-.

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2004-11-14 20:04

Message:
Logged In: YES 
user_id=199625

One more nicety maybe you can work on until I have some time:

It would be cool if drag_move was changed such that it will
only allow a drop  if file transfer is supported.

I'm pretty sure this is impossible now that we'd have to
check if the file is an image before knowing whether we can
accept it or not, but if you can think of a clever way to do
this, that would be awesome.

-s.

----------------------------------------------------------------------

Comment By: Sean Egan (seanegan)
Date: 2004-11-14 19:48

Message:
Logged In: YES 
user_id=199625

A patch to a patch?  ew.

I'm looking it over right now.  I'm not sure this warrents a
new source file to be added for dnd-file; the obvious place
to put it is gtkutils.c.

gaim-desktop-item will probably stay that way just because
it's from elsewhere and would be easier to maintain that way.

There are a few other things I'll change.  For instance, I
can't think of any concievable reason someone would actually
really want to send a .desktop file, so I'll probably remove
that stuff (unless you can think of a good reason).

For the most part, everything looks really good.  I'll make
a few minor edits, commit it, and you should be able to
collect the bounty.

-s.

----------------------------------------------------------------------

Comment By: Alceste Scalas (alceste)
Date: 2004-11-12 17:04

Message:
Logged In: YES 
user_id=579277

Oops! Here's a small patch that fixes two quirks in the
previous one (a misleading comment and a missing g_rand_free()).

It should be applied in the src/ directory, just after the
previous patch and a fresh (as of today) CVS update.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1062630&group_id=235

2004	Jan	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep	Oct	Nov (435)	Dec (252)
2005	Jan (177)	Feb (157)	Mar (187)	Apr (168)	May (127)	Jun (291)	Jul (38)	Aug	Sep	Oct	Nov	Dec

pidgin-patches Mailing List for Pidgin IM (Page 74)

A universal instant messaging (IM) program

pidgin-patches — Updates to the Gaim patches tracker