Menu
▾
▴
pidgin-patches — Updates to the Gaim patches tracker
You can subscribe to this list here.
| 2004 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(435) |
Dec
(252) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2005 |
Jan
(177) |
Feb
(157) |
Mar
(187) |
Apr
(168) |
May
(127) |
Jun
(291) |
Jul
(38) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: SourceForge.net <no...@so...> - 2005-06-22 23:07:35
|
Patches item #1223465, was opened at 2005-06-19 00:47 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223465&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: MSN Buddy Icon File Existence Check Initial Comment: The MSN prpl considers the existence of a buddy_icon setting for a buddy in blist.xml to mean that a buddy icon exists. If the cache file has been deleted, this causes Gaim to fail to retrieve a new buddy icon. Why would an icon be missing from the cache folder? For me, it was because I work with multiple running copies of Gaim while developing. They step on each other's toes. For others, this situation could happen if the cache folder was purged by the user (or one of his scripts) or if the user is synchronizing ~/.gaim but excludes the icons folder (e.g. for size reasons). I realize these scenarios aren't very common, but this is a one-line patch that shouldn't cause any problems. ---------------------------------------------------------------------- >Comment By: Richard Laager (rlaager) Date: 2005-06-22 18:07 Message: Logged In: YES user_id=156487 I see you changed it. I was trying to avoid having too many conditions on one line, but this looks fine. In oldstatus, you'd need to use buddy->name. It's not really a big deal if this goes into oldstatus or not. Users should rarely hit this. On the other hand, it'll only take a second to add this to oldstatus. You're the one with commit access, so it's your call. ;-) ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 17:59 Message: Logged In: YES user_id=20979 I changed this around a tad bit, but it should have the same effect. Thanks Oh, and I only applied it to head. gaim_buddy_get_name doesn't exist in oldstatus. But it seems like this is pretty minor, so that shouldn't matter too much? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223465&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 23:03:17
|
Patches item #1223464, was opened at 2005-06-19 01:43 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223464&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Buddy Icon File Creation Error Logging Initial Comment: This code logs an entry to the Gaim debug log when the creation of a buddy icon cache file fails. I added this code to my local copy when I was debugging a problem with buddy icons existing in the blist.xml file but not existing in the cache directory. It turned out this wasn't the problem, but I see no harm in having this as a debugging notice, so I'm submitting it as a patch. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 19:03 Message: Logged In: YES user_id=20979 Excelsior! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223464&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 22:59:58
|
Patches item #1223465, was opened at 2005-06-19 01:47 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223465&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: MSN Buddy Icon File Existence Check Initial Comment: The MSN prpl considers the existence of a buddy_icon setting for a buddy in blist.xml to mean that a buddy icon exists. If the cache file has been deleted, this causes Gaim to fail to retrieve a new buddy icon. Why would an icon be missing from the cache folder? For me, it was because I work with multiple running copies of Gaim while developing. They step on each other's toes. For others, this situation could happen if the cache folder was purged by the user (or one of his scripts) or if the user is synchronizing ~/.gaim but excludes the icons folder (e.g. for size reasons). I realize these scenarios aren't very common, but this is a one-line patch that shouldn't cause any problems. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 18:59 Message: Logged In: YES user_id=20979 I changed this around a tad bit, but it should have the same effect. Thanks Oh, and I only applied it to head. gaim_buddy_get_name doesn't exist in oldstatus. But it seems like this is pretty minor, so that shouldn't matter too much? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223465&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 22:51:12
|
Patches item #1222377, was opened at 2005-06-17 00:39 Message generated for change (Comment added) made by evands You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222377&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Evan Schoenberg (evands) Assigned to: Mark Doliner (thekingant) Summary: [OSCAR] Improve buddy icon retrieval Initial Comment: When retrieving the userinfo and then using that data to request a buddy icon, a value in Gaim was previously hardcoded to 0x01. It's called "number" in locate.c... seems that it is unclear what exactly it means. In any vase, buddy icon checksums had to have a "number" of 0x01. However, 0x00 is also a valid "number." Fire calls this field iconcsumtype, so I've used that name for it. iconcsumtype is passed back to aim_bart_request() where it is used [it will be either 0x00 or 0x01, whereas Gaim was always assuming it was 0x01]. The result: Certain buddy icons which Gaim previously could not retrieve are now retrieveable. I believe that these are primarily coming from old clients; a clear example (and my test case for finding this fix) is the AOLYellowPages buddy, run by the AIM server. Before the patch, no icon; with the patch, the icon as properly retrieved by the official client. This patch is ported... sideported?... from Fire's modified libfaim; I noticed Fire was doing a better job retrieving buddy icons than Gaim was, and hunted down the cause. Applies against oldstatus and HEAD. ---------------------------------------------------------------------- >Comment By: Evan Schoenberg (evands) Date: 2005-06-22 17:51 Message: Logged In: YES user_id=669684 The problem was that we were being overzealous with getting icons, in a sense... some AIM clients send a blank GIF if no icon is set, presumably because this used to be necessary, using that 0x00 iconcsumtype. The attached patch now avoids treating these as actual buddy icons; the commonality is that they have a iconlen of 90, which is not something that any real buddy icon would be likely to have, so we just ignore them. ---------------------------------------------------------------------- Comment By: Evan Schoenberg (evands) Date: 2005-06-20 12:21 Message: Logged In: YES user_id=669684 Clarification: I meant certain other icons, not all other icons. Expansion: This patch also lets Gaim retrieve icons from users of recent versions of AOL for Windows, which was not possible before. ---------------------------------------------------------------------- Comment By: Evan Schoenberg (evands) Date: 2005-06-19 13:13 Message: Logged In: YES user_id=669684 Hmm... further testing shows that this seems to cause OTHER icons not to appear properly; Gaim gets an icon, but it is blank. I'll investigate this further... any suggestions as to the cause would be much appreciated. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1222377&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 22:46:29
|
Patches item #1223530, was opened at 2005-06-19 05:23 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223530&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: GtkImHtml Image Save Error Dialogs Initial Comment: When saving an image from a GtkImHtml, a couple different errors can occur. The existing code creates a dialog for these situations, but never shows it. This patch fixes that and also improves the formatting of the dialogs. The moral of the story? Don't think about using code from Gaim in your plugin because you'll just find the Gaim code is broken and then you have to submit a patch. ;-) ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 18:46 Message: Logged In: YES user_id=20979 Superb! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223530&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 22:41:51
|
Patches item #1223909, was opened at 2005-06-20 01:36 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223909&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: New Accessor Method: gaim_gtk_blist_node_is_contact_expanded Initial Comment: This patch adds a new accessor method that tells whether or not a blist node is part of an expanded contact. This was necessary to get proper right-click behavior for a plugin I wrote. The plugin is gaim-album and it archives buddy icons. I wanted the View Buddy Icons menu item to behave like View Log does in HEAD. It always gives you the icons for the entire contact, except when you right-click on a buddy that's in an expanded contact, in which case you get the icons for just that buddy. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 18:41 Message: Logged In: YES user_id=20979 Looks ok to me, thanks. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1223909&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 22:35:44
|
Patches item #1224555, was opened at 2005-06-20 21:50 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224555&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Enix (enix) Assigned to: Nobody/Anonymous (nobody) Summary: [HEAD, Oldstatus] Tooltip appears over gtkblist context menu Initial Comment: When the gtkblist context menu is displayed, the tooltip timeout is not removed. This results in the tooltip displaying over the context menu when the timeout occurs. Included is a short patch to remove the timeout before displaying the context menu. Applies against HEAD and Oldstatus. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 18:35 Message: Logged In: YES user_id=20979 I can't reproduce the problem you're describing. Do you only have this problem when using MS Windows? Could you take a screen shot? I'm not opposed to fixing this, but it sounds like it might be something we'll want to file a gtk bug about (I'm thinking that when the context menu is open then the blist should not have focus, and should therefore not display the tooltip). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224555&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 22:27:15
|
Patches item #1224610, was opened at 2005-06-21 01:49 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224610&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Richard Laager (rlaager) Assigned to: Nobody/Anonymous (nobody) Summary: Buddy Icons Not Being Removed Initial Comment: Buddy icon cache files are removed when replacing icons but not when unsetting the icon. This patch corrects that. I think this fixes the only case where buddy icon cache files are not being deleted when they should be. I'd like to hear if anyone is seeing otherwise after this patch is applied. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 18:27 Message: Logged In: YES user_id=20979 It looks like gaim_buddy_icon_cache() in src/buddylist.c is responsible for writing the buddy icon file? Would it make more sense if blist.c called a buddylist.c function to delete the icon file? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224610&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 22:15:55
|
Patches item #1224919, was opened at 2005-06-21 11:26 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224919&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Rejected Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Backport: Adding `Show Buddy Icon' in the conv-window menu Initial Comment: Hello. Copied the changes from HEAD. -- Adil ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 18:15 Message: Logged In: YES user_id=20979 I'd rather not get into the habit of backporting everything from HEAD. This doesn't seem like it's something that is urgently needed in oldstatus. Unless you can convince me otherwise? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224919&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 22:11:33
|
Patches item #1225691, was opened at 2005-06-22 13:56 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1225691&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Levi Bard (tak_tak) >Assigned to: Ethan Blanton (eblanton) Summary: Implements gc->keepalive for irc Initial Comment: Implements gc->keepalive for irc - no more, no less ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 18:11 Message: Logged In: YES user_id=20979 This looks ok to me, but I don't really know the IRC protocol. Ethan? (If you have time to look at it but not apply it, I can do that for you, if you want.) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1225691&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 17:56:14
|
Patches item #1225691, was opened at 2005-06-22 13:56 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1225691&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Nobody/Anonymous (nobody) Summary: Implements gc->keepalive for irc Initial Comment: Implements gc->keepalive for irc - no more, no less ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1225691&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 17:40:49
|
Patches item #1224386, was opened at 2005-06-20 16:21 Message generated for change (Comment added) made by seanegan You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Ethan Blanton (eblanton) Summary: IRC keepalive ping Initial Comment: Patch to ping IRC servers at arbitrary intervals in order to prevent connections from dropping. ---------------------------------------------------------------------- >Comment By: Sean Egan (seanegan) Date: 2005-06-22 13:40 Message: Logged In: YES user_id=199625 I don't actually mean to make it a preference, but if you *did*, it would be a single option in Network, not multiple options for each protocol. Regardless, there is no NAT device that can't keep a connection open for at least a minute. Leaving it unconfigurable should be fine. -s. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-22 13:37 Message: Logged In: YES user_id=644705 The point of this is that the buddy list keepalive isn't often enough in some circumstances. (Yes, the NAT is misconfigured, but it's not my NAT and I can't fix it!) I could add a global keepalive interval in GaimConnection, and let prpl maintainers use it or not at their whim, if that would be preferable. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 13:33 Message: Logged In: YES user_id=20979 Er, well it seems like you could add a preference to the preferences window... But I'm not sure that's really needed. After what Sean wrote, it sounds like maybe you could just implement gc->keepalive for IRC and make it so that it only sends the keepalive packet if your buddy list is empty. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-22 09:54 Message: Logged In: YES user_id=644705 If I add this option globally, it will require another field on the account options for EVERY builtin prpl. Will that really be acceptable? ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-21 17:41 Message: Logged In: YES user_id=199625 It took me a while to figure out why I was getting booted from Freenode, and then I discovered it was because my NAT wasn't keeping the connection open. Adding Nickserv to my buddy list *did* serve as a decent workaround. If that was the problem, you would be constantly kicked off other protocols such as AIM, as well, which would likewise need modification. gc->keepalive is certainly the correct place to send keepalive packets. -s. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-21 17:35 Message: Logged In: YES user_id=20979 I agree with Sean and Luke. I'm going to close this for now. If you take another stab at it, you may want to look into using gc->keepalive ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-06-21 10:16 Message: Logged In: YES user_id=28833 Sean is right. one minute *should* be enough. your NAT is badly configured ;-) that being said, I really have no basis on which to comment on this patch from a technical standpoint. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-21 09:17 Message: Logged In: YES user_id=644705 Once a minute is NOT enough, as evidenced by the fact that the workaround of putting someone on your buddy list isn't enough in several instances. It's on a per-irc-server basis now, because servers are *supposed* to ping their clients often enough to keep them alive; however, some (freenode) don't. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:56 Message: Logged In: YES user_id=199625 This function has no need to be configurable; once a minute should be plenty often enough to keep a NAT tunnel open, and if not the feature should be globally configurable so that AIM server pings happen more frequently as well. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-20 16:46 Message: Logged In: YES user_id=644705 The existing ison functionality isn't at adjustable intervals, and I thought it would be better to allow increasing the frequency of a single ping rather than whatever arbitrary number of buddies the user happens to have for each connection. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:26 Message: Logged In: YES user_id=199625 This is great, but implemented wrong. Find the existing IRC keepalive function, currently used solely to poll the buddy list with a RNG command, and if there is no buddy list, send a PNG command instead. -s. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 17:37:20
|
Patches item #1224386, was opened at 2005-06-20 16:21 Message generated for change (Comment added) made by tak_tak You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Ethan Blanton (eblanton) Summary: IRC keepalive ping Initial Comment: Patch to ping IRC servers at arbitrary intervals in order to prevent connections from dropping. ---------------------------------------------------------------------- >Comment By: Levi Bard (tak_tak) Date: 2005-06-22 13:37 Message: Logged In: YES user_id=644705 The point of this is that the buddy list keepalive isn't often enough in some circumstances. (Yes, the NAT is misconfigured, but it's not my NAT and I can't fix it!) I could add a global keepalive interval in GaimConnection, and let prpl maintainers use it or not at their whim, if that would be preferable. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-22 13:33 Message: Logged In: YES user_id=20979 Er, well it seems like you could add a preference to the preferences window... But I'm not sure that's really needed. After what Sean wrote, it sounds like maybe you could just implement gc->keepalive for IRC and make it so that it only sends the keepalive packet if your buddy list is empty. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-22 09:54 Message: Logged In: YES user_id=644705 If I add this option globally, it will require another field on the account options for EVERY builtin prpl. Will that really be acceptable? ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-21 17:41 Message: Logged In: YES user_id=199625 It took me a while to figure out why I was getting booted from Freenode, and then I discovered it was because my NAT wasn't keeping the connection open. Adding Nickserv to my buddy list *did* serve as a decent workaround. If that was the problem, you would be constantly kicked off other protocols such as AIM, as well, which would likewise need modification. gc->keepalive is certainly the correct place to send keepalive packets. -s. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-21 17:35 Message: Logged In: YES user_id=20979 I agree with Sean and Luke. I'm going to close this for now. If you take another stab at it, you may want to look into using gc->keepalive ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-06-21 10:16 Message: Logged In: YES user_id=28833 Sean is right. one minute *should* be enough. your NAT is badly configured ;-) that being said, I really have no basis on which to comment on this patch from a technical standpoint. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-21 09:17 Message: Logged In: YES user_id=644705 Once a minute is NOT enough, as evidenced by the fact that the workaround of putting someone on your buddy list isn't enough in several instances. It's on a per-irc-server basis now, because servers are *supposed* to ping their clients often enough to keep them alive; however, some (freenode) don't. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:56 Message: Logged In: YES user_id=199625 This function has no need to be configurable; once a minute should be plenty often enough to keep a NAT tunnel open, and if not the feature should be globally configurable so that AIM server pings happen more frequently as well. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-20 16:46 Message: Logged In: YES user_id=644705 The existing ison functionality isn't at adjustable intervals, and I thought it would be better to allow increasing the frequency of a single ping rather than whatever arbitrary number of buddies the user happens to have for each connection. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:26 Message: Logged In: YES user_id=199625 This is great, but implemented wrong. Find the existing IRC keepalive function, currently used solely to poll the buddy list with a RNG command, and if there is no buddy list, send a PNG command instead. -s. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 17:33:55
|
Patches item #1224386, was opened at 2005-06-20 16:21 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Ethan Blanton (eblanton) Summary: IRC keepalive ping Initial Comment: Patch to ping IRC servers at arbitrary intervals in order to prevent connections from dropping. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-22 13:33 Message: Logged In: YES user_id=20979 Er, well it seems like you could add a preference to the preferences window... But I'm not sure that's really needed. After what Sean wrote, it sounds like maybe you could just implement gc->keepalive for IRC and make it so that it only sends the keepalive packet if your buddy list is empty. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-22 09:54 Message: Logged In: YES user_id=644705 If I add this option globally, it will require another field on the account options for EVERY builtin prpl. Will that really be acceptable? ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-21 17:41 Message: Logged In: YES user_id=199625 It took me a while to figure out why I was getting booted from Freenode, and then I discovered it was because my NAT wasn't keeping the connection open. Adding Nickserv to my buddy list *did* serve as a decent workaround. If that was the problem, you would be constantly kicked off other protocols such as AIM, as well, which would likewise need modification. gc->keepalive is certainly the correct place to send keepalive packets. -s. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-21 17:35 Message: Logged In: YES user_id=20979 I agree with Sean and Luke. I'm going to close this for now. If you take another stab at it, you may want to look into using gc->keepalive ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-06-21 10:16 Message: Logged In: YES user_id=28833 Sean is right. one minute *should* be enough. your NAT is badly configured ;-) that being said, I really have no basis on which to comment on this patch from a technical standpoint. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-21 09:17 Message: Logged In: YES user_id=644705 Once a minute is NOT enough, as evidenced by the fact that the workaround of putting someone on your buddy list isn't enough in several instances. It's on a per-irc-server basis now, because servers are *supposed* to ping their clients often enough to keep them alive; however, some (freenode) don't. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:56 Message: Logged In: YES user_id=199625 This function has no need to be configurable; once a minute should be plenty often enough to keep a NAT tunnel open, and if not the feature should be globally configurable so that AIM server pings happen more frequently as well. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-20 16:46 Message: Logged In: YES user_id=644705 The existing ison functionality isn't at adjustable intervals, and I thought it would be better to allow increasing the frequency of a single ping rather than whatever arbitrary number of buddies the user happens to have for each connection. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:26 Message: Logged In: YES user_id=199625 This is great, but implemented wrong. Find the existing IRC keepalive function, currently used solely to poll the buddy list with a RNG command, and if there is no buddy list, send a PNG command instead. -s. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 13:54:47
|
Patches item #1224386, was opened at 2005-06-20 16:21 Message generated for change (Comment added) made by tak_tak You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Ethan Blanton (eblanton) Summary: IRC keepalive ping Initial Comment: Patch to ping IRC servers at arbitrary intervals in order to prevent connections from dropping. ---------------------------------------------------------------------- >Comment By: Levi Bard (tak_tak) Date: 2005-06-22 09:54 Message: Logged In: YES user_id=644705 If I add this option globally, it will require another field on the account options for EVERY builtin prpl. Will that really be acceptable? ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-21 17:41 Message: Logged In: YES user_id=199625 It took me a while to figure out why I was getting booted from Freenode, and then I discovered it was because my NAT wasn't keeping the connection open. Adding Nickserv to my buddy list *did* serve as a decent workaround. If that was the problem, you would be constantly kicked off other protocols such as AIM, as well, which would likewise need modification. gc->keepalive is certainly the correct place to send keepalive packets. -s. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-21 17:35 Message: Logged In: YES user_id=20979 I agree with Sean and Luke. I'm going to close this for now. If you take another stab at it, you may want to look into using gc->keepalive ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-06-21 10:16 Message: Logged In: YES user_id=28833 Sean is right. one minute *should* be enough. your NAT is badly configured ;-) that being said, I really have no basis on which to comment on this patch from a technical standpoint. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-21 09:17 Message: Logged In: YES user_id=644705 Once a minute is NOT enough, as evidenced by the fact that the workaround of putting someone on your buddy list isn't enough in several instances. It's on a per-irc-server basis now, because servers are *supposed* to ping their clients often enough to keep them alive; however, some (freenode) don't. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:56 Message: Logged In: YES user_id=199625 This function has no need to be configurable; once a minute should be plenty often enough to keep a NAT tunnel open, and if not the feature should be globally configurable so that AIM server pings happen more frequently as well. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-20 16:46 Message: Logged In: YES user_id=644705 The existing ison functionality isn't at adjustable intervals, and I thought it would be better to allow increasing the frequency of a single ping rather than whatever arbitrary number of buddies the user happens to have for each connection. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:26 Message: Logged In: YES user_id=199625 This is great, but implemented wrong. Find the existing IRC keepalive function, currently used solely to poll the buddy list with a RNG command, and if there is no buddy list, send a PNG command instead. -s. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 02:07:11
|
Patches item #1217958, was opened at 2005-06-10 00:00 Message generated for change (Comment added) made by rlaager You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Plugins Group: None Status: Open Resolution: None Priority: 5 Submitted By: Tim Hentenaar (matriarktervel) Assigned to: Nobody/Anonymous (nobody) Summary: New Prpl Initial Comment: This prpl implements the PalTalk Protocol in oldstatus CVS. I did most of the reverse engineering with PalTalk 5.x about a year ago, and finally got around to writing a prpl for it. I have updated it to be compatible with the new PalTalk 8.x clients [there were some protocol changes in between]. I'm planning to port this up to head once it becomes a bit more stable. I have tested this with gaim 1.3.0 stable and oldstatus. The attached file contains a diff against this evening's oldstatus (6/9), and the additional files. ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-21 21:07 Message: Logged In: YES user_id=156487 It would be much better if you'd actively work with the gaim-vv team on the design. That way, you could end up with code that works for both of you. This is good for both parties because it increases the number of developers for the code, reduces code duplication (your plugin can use the sound subsystem you wrote which would be merged into gaim-vv and eventually gaim), and shows that you're willing to cooperate. It likely won't take much extra time, and you'll probably get good ideas from the gaim-vv guys in the process. ---------------------------------------------------------------------- Comment By: Tim Hentenaar (matriarktervel) Date: 2005-06-21 19:44 Message: Logged In: YES user_id=634325 If they would like to use my sound code, once I get it stable, they're more than welcome to. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-21 19:31 Message: Logged In: YES user_id=407708 It's a pity you have decided to implement your own sound subsystem rather than help out the gaim-vv team, whether it uses gstreamer or not. ---------------------------------------------------------------------- Comment By: Tim Hentenaar (matriarktervel) Date: 2005-06-21 19:20 Message: Logged In: YES user_id=634325 I deleted the attachement because the code was a bit more buggy than I would have liked. I've since fixed it, and I've been implementing some features that aren't already present in gaim (i.e. audio support, yes I know about gaim-vv, but they don't have audio support yet, and I don't really like how buggy gstreamer is.) I've been maintaining it in a private CVS that I've been keeping in step with oldstatus-cvs. My code could still be integrated into oldstatus, with a few modifications. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-21 17:08 Message: Logged In: YES user_id=407708 What happened to the attachment? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-11 16:56 Message: Logged In: YES user_id=156487 I'd recommend maintaining this separate of Gaim. See meanwhile.sf.net as an example. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 00:44:37
|
Patches item #1217958, was opened at 2005-06-10 01:00 Message generated for change (Comment added) made by matriarktervel You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Plugins Group: None Status: Open Resolution: None Priority: 5 Submitted By: Tim Hentenaar (matriarktervel) Assigned to: Nobody/Anonymous (nobody) Summary: New Prpl Initial Comment: This prpl implements the PalTalk Protocol in oldstatus CVS. I did most of the reverse engineering with PalTalk 5.x about a year ago, and finally got around to writing a prpl for it. I have updated it to be compatible with the new PalTalk 8.x clients [there were some protocol changes in between]. I'm planning to port this up to head once it becomes a bit more stable. I have tested this with gaim 1.3.0 stable and oldstatus. The attached file contains a diff against this evening's oldstatus (6/9), and the additional files. ---------------------------------------------------------------------- >Comment By: Tim Hentenaar (matriarktervel) Date: 2005-06-21 20:44 Message: Logged In: YES user_id=634325 If they would like to use my sound code, once I get it stable, they're more than welcome to. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-21 20:31 Message: Logged In: YES user_id=407708 It's a pity you have decided to implement your own sound subsystem rather than help out the gaim-vv team, whether it uses gstreamer or not. ---------------------------------------------------------------------- Comment By: Tim Hentenaar (matriarktervel) Date: 2005-06-21 20:20 Message: Logged In: YES user_id=634325 I deleted the attachement because the code was a bit more buggy than I would have liked. I've since fixed it, and I've been implementing some features that aren't already present in gaim (i.e. audio support, yes I know about gaim-vv, but they don't have audio support yet, and I don't really like how buggy gstreamer is.) I've been maintaining it in a private CVS that I've been keeping in step with oldstatus-cvs. My code could still be integrated into oldstatus, with a few modifications. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-21 18:08 Message: Logged In: YES user_id=407708 What happened to the attachment? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-11 17:56 Message: Logged In: YES user_id=156487 I'd recommend maintaining this separate of Gaim. See meanwhile.sf.net as an example. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 00:31:50
|
Patches item #1217958, was opened at 2005-06-10 15:00 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Plugins Group: None Status: Open Resolution: None Priority: 5 Submitted By: Tim Hentenaar (matriarktervel) Assigned to: Nobody/Anonymous (nobody) Summary: New Prpl Initial Comment: This prpl implements the PalTalk Protocol in oldstatus CVS. I did most of the reverse engineering with PalTalk 5.x about a year ago, and finally got around to writing a prpl for it. I have updated it to be compatible with the new PalTalk 8.x clients [there were some protocol changes in between]. I'm planning to port this up to head once it becomes a bit more stable. I have tested this with gaim 1.3.0 stable and oldstatus. The attached file contains a diff against this evening's oldstatus (6/9), and the additional files. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-22 10:31 Message: Logged In: YES user_id=407708 It's a pity you have decided to implement your own sound subsystem rather than help out the gaim-vv team, whether it uses gstreamer or not. ---------------------------------------------------------------------- Comment By: Tim Hentenaar (matriarktervel) Date: 2005-06-22 10:20 Message: Logged In: YES user_id=634325 I deleted the attachement because the code was a bit more buggy than I would have liked. I've since fixed it, and I've been implementing some features that aren't already present in gaim (i.e. audio support, yes I know about gaim-vv, but they don't have audio support yet, and I don't really like how buggy gstreamer is.) I've been maintaining it in a private CVS that I've been keeping in step with oldstatus-cvs. My code could still be integrated into oldstatus, with a few modifications. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-22 08:08 Message: Logged In: YES user_id=407708 What happened to the attachment? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-12 07:56 Message: Logged In: YES user_id=156487 I'd recommend maintaining this separate of Gaim. See meanwhile.sf.net as an example. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-22 00:20:31
|
Patches item #1217958, was opened at 2005-06-10 01:00 Message generated for change (Comment added) made by matriarktervel You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Plugins Group: None Status: Open Resolution: None Priority: 5 Submitted By: Tim Hentenaar (matriarktervel) Assigned to: Nobody/Anonymous (nobody) Summary: New Prpl Initial Comment: This prpl implements the PalTalk Protocol in oldstatus CVS. I did most of the reverse engineering with PalTalk 5.x about a year ago, and finally got around to writing a prpl for it. I have updated it to be compatible with the new PalTalk 8.x clients [there were some protocol changes in between]. I'm planning to port this up to head once it becomes a bit more stable. I have tested this with gaim 1.3.0 stable and oldstatus. The attached file contains a diff against this evening's oldstatus (6/9), and the additional files. ---------------------------------------------------------------------- >Comment By: Tim Hentenaar (matriarktervel) Date: 2005-06-21 20:20 Message: Logged In: YES user_id=634325 I deleted the attachement because the code was a bit more buggy than I would have liked. I've since fixed it, and I've been implementing some features that aren't already present in gaim (i.e. audio support, yes I know about gaim-vv, but they don't have audio support yet, and I don't really like how buggy gstreamer is.) I've been maintaining it in a private CVS that I've been keeping in step with oldstatus-cvs. My code could still be integrated into oldstatus, with a few modifications. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-21 18:08 Message: Logged In: YES user_id=407708 What happened to the attachment? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-11 17:56 Message: Logged In: YES user_id=156487 I'd recommend maintaining this separate of Gaim. See meanwhile.sf.net as an example. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-21 22:08:53
|
Patches item #1217958, was opened at 2005-06-10 15:00 Message generated for change (Comment added) made by bleeter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Plugins Group: None Status: Open Resolution: None Priority: 5 Submitted By: Tim Hentenaar (matriarktervel) Assigned to: Nobody/Anonymous (nobody) Summary: New Prpl Initial Comment: This prpl implements the PalTalk Protocol in oldstatus CVS. I did most of the reverse engineering with PalTalk 5.x about a year ago, and finally got around to writing a prpl for it. I have updated it to be compatible with the new PalTalk 8.x clients [there were some protocol changes in between]. I'm planning to port this up to head once it becomes a bit more stable. I have tested this with gaim 1.3.0 stable and oldstatus. The attached file contains a diff against this evening's oldstatus (6/9), and the additional files. ---------------------------------------------------------------------- Comment By: Bleeter Yaluser (bleeter) Date: 2005-06-22 08:08 Message: Logged In: YES user_id=407708 What happened to the attachment? ---------------------------------------------------------------------- Comment By: Richard Laager (rlaager) Date: 2005-06-12 07:56 Message: Logged In: YES user_id=156487 I'd recommend maintaining this separate of Gaim. See meanwhile.sf.net as an example. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1217958&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-21 21:41:23
|
Patches item #1224386, was opened at 2005-06-20 16:21 Message generated for change (Comment added) made by seanegan You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Rejected Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Ethan Blanton (eblanton) Summary: IRC keepalive ping Initial Comment: Patch to ping IRC servers at arbitrary intervals in order to prevent connections from dropping. ---------------------------------------------------------------------- >Comment By: Sean Egan (seanegan) Date: 2005-06-21 17:41 Message: Logged In: YES user_id=199625 It took me a while to figure out why I was getting booted from Freenode, and then I discovered it was because my NAT wasn't keeping the connection open. Adding Nickserv to my buddy list *did* serve as a decent workaround. If that was the problem, you would be constantly kicked off other protocols such as AIM, as well, which would likewise need modification. gc->keepalive is certainly the correct place to send keepalive packets. -s. ---------------------------------------------------------------------- Comment By: Mark Doliner (thekingant) Date: 2005-06-21 17:35 Message: Logged In: YES user_id=20979 I agree with Sean and Luke. I'm going to close this for now. If you take another stab at it, you may want to look into using gc->keepalive ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-06-21 10:16 Message: Logged In: YES user_id=28833 Sean is right. one minute *should* be enough. your NAT is badly configured ;-) that being said, I really have no basis on which to comment on this patch from a technical standpoint. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-21 09:17 Message: Logged In: YES user_id=644705 Once a minute is NOT enough, as evidenced by the fact that the workaround of putting someone on your buddy list isn't enough in several instances. It's on a per-irc-server basis now, because servers are *supposed* to ping their clients often enough to keep them alive; however, some (freenode) don't. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:56 Message: Logged In: YES user_id=199625 This function has no need to be configurable; once a minute should be plenty often enough to keep a NAT tunnel open, and if not the feature should be globally configurable so that AIM server pings happen more frequently as well. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-20 16:46 Message: Logged In: YES user_id=644705 The existing ison functionality isn't at adjustable intervals, and I thought it would be better to allow increasing the frequency of a single ping rather than whatever arbitrary number of buddies the user happens to have for each connection. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:26 Message: Logged In: YES user_id=199625 This is great, but implemented wrong. Find the existing IRC keepalive function, currently used solely to poll the buddy list with a RNG command, and if there is no buddy list, send a PNG command instead. -s. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-21 21:35:32
|
Patches item #1224386, was opened at 2005-06-20 16:21 Message generated for change (Comment added) made by thekingant You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Rejected Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Ethan Blanton (eblanton) Summary: IRC keepalive ping Initial Comment: Patch to ping IRC servers at arbitrary intervals in order to prevent connections from dropping. ---------------------------------------------------------------------- >Comment By: Mark Doliner (thekingant) Date: 2005-06-21 17:35 Message: Logged In: YES user_id=20979 I agree with Sean and Luke. I'm going to close this for now. If you take another stab at it, you may want to look into using gc->keepalive ---------------------------------------------------------------------- Comment By: Luke Schierer (lschiere) Date: 2005-06-21 10:16 Message: Logged In: YES user_id=28833 Sean is right. one minute *should* be enough. your NAT is badly configured ;-) that being said, I really have no basis on which to comment on this patch from a technical standpoint. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-21 09:17 Message: Logged In: YES user_id=644705 Once a minute is NOT enough, as evidenced by the fact that the workaround of putting someone on your buddy list isn't enough in several instances. It's on a per-irc-server basis now, because servers are *supposed* to ping their clients often enough to keep them alive; however, some (freenode) don't. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:56 Message: Logged In: YES user_id=199625 This function has no need to be configurable; once a minute should be plenty often enough to keep a NAT tunnel open, and if not the feature should be globally configurable so that AIM server pings happen more frequently as well. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-20 16:46 Message: Logged In: YES user_id=644705 The existing ison functionality isn't at adjustable intervals, and I thought it would be better to allow increasing the frequency of a single ping rather than whatever arbitrary number of buddies the user happens to have for each connection. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:26 Message: Logged In: YES user_id=199625 This is great, but implemented wrong. Find the existing IRC keepalive function, currently used solely to poll the buddy list with a RNG command, and if there is no buddy list, send a PNG command instead. -s. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-21 17:22:43
|
Patches item #1224919, was opened at 2005-06-21 21:26 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224919&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Sadrul H C (sadrul) Assigned to: Nobody/Anonymous (nobody) Summary: Backport: Adding `Show Buddy Icon' in the conv-window menu Initial Comment: Hello. Copied the changes from HEAD. -- Adil ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224919&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-21 16:58:43
|
Patches item #1224386, was opened at 2005-06-20 16:21 Message generated for change (Comment added) made by tak_tak You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Levi Bard (tak_tak) Assigned to: Nobody/Anonymous (nobody) Summary: IRC keepalive ping Initial Comment: Patch to ping IRC servers at arbitrary intervals in order to prevent connections from dropping. ---------------------------------------------------------------------- >Comment By: Levi Bard (tak_tak) Date: 2005-06-21 09:17 Message: Logged In: YES user_id=644705 Once a minute is NOT enough, as evidenced by the fact that the workaround of putting someone on your buddy list isn't enough in several instances. It's on a per-irc-server basis now, because servers are *supposed* to ping their clients often enough to keep them alive; however, some (freenode) don't. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:56 Message: Logged In: YES user_id=199625 This function has no need to be configurable; once a minute should be plenty often enough to keep a NAT tunnel open, and if not the feature should be globally configurable so that AIM server pings happen more frequently as well. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-20 16:46 Message: Logged In: YES user_id=644705 The existing ison functionality isn't at adjustable intervals, and I thought it would be better to allow increasing the frequency of a single ping rather than whatever arbitrary number of buddies the user happens to have for each connection. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:26 Message: Logged In: YES user_id=199625 This is great, but implemented wrong. Find the existing IRC keepalive function, currently used solely to poll the buddy list with a RNG command, and if there is no buddy list, send a PNG command instead. -s. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 |
|
From: SourceForge.net <no...@so...> - 2005-06-21 16:39:35
|
Patches item #1224386, was opened at 2005-06-20 16:21 Message generated for change (Comment added) made by lschiere You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Levi Bard (tak_tak) >Assigned to: Ethan Blanton (eblanton) Summary: IRC keepalive ping Initial Comment: Patch to ping IRC servers at arbitrary intervals in order to prevent connections from dropping. ---------------------------------------------------------------------- >Comment By: Luke Schierer (lschiere) Date: 2005-06-21 10:16 Message: Logged In: YES user_id=28833 Sean is right. one minute *should* be enough. your NAT is badly configured ;-) that being said, I really have no basis on which to comment on this patch from a technical standpoint. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-21 09:17 Message: Logged In: YES user_id=644705 Once a minute is NOT enough, as evidenced by the fact that the workaround of putting someone on your buddy list isn't enough in several instances. It's on a per-irc-server basis now, because servers are *supposed* to ping their clients often enough to keep them alive; however, some (freenode) don't. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:56 Message: Logged In: YES user_id=199625 This function has no need to be configurable; once a minute should be plenty often enough to keep a NAT tunnel open, and if not the feature should be globally configurable so that AIM server pings happen more frequently as well. ---------------------------------------------------------------------- Comment By: Levi Bard (tak_tak) Date: 2005-06-20 16:46 Message: Logged In: YES user_id=644705 The existing ison functionality isn't at adjustable intervals, and I thought it would be better to allow increasing the frequency of a single ping rather than whatever arbitrary number of buddies the user happens to have for each connection. ---------------------------------------------------------------------- Comment By: Sean Egan (seanegan) Date: 2005-06-20 16:26 Message: Logged In: YES user_id=199625 This is great, but implemented wrong. Find the existing IRC keepalive function, currently used solely to poll the buddy list with a RNG command, and if there is no buddy list, send a PNG command instead. -s. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300235&aid=1224386&group_id=235 |
3 messages has been excluded from this view by a project administrator.
