phpwiki-talk

[Phpwiki-talk] Page name checker

[Adam P. <ad...@dw...>]

Hello,

I would like to add some sort of 'Page name checker' code to our Wiki. This is because some users still use spaces when naming
pages. We would like to stop this as it causes problems when linking to pages from emails. 

It would be great if I could add a quick preg_match() and preg_replace() somewhere in Wiki to strip out all white space from newly
created page titles and name them correctly with capitals indicating a new word, e.g. ThisIsANewPage.

But, I'm not sure where to add this code, if it's even possible? Or is there a better way of going about this? 

We use PHPWiki on our intranet so unfortunately I can't provide a link.

Thank you,

Adam Palmer

Re: [Phpwiki-talk] Better SQL backend for Mysql

[Manuel V. <man...@gm...>]

2006/3/4, Reini Urban <ru...@x-...>:
> Manuel Vacelet schrieb:
> > 2006/3/2, Reini Urban <ru...@x-...>:
> >> Manuel Vacelet schrieb:
> >>> I'm about to upgrade my phpwiki installation from 1.3.10 to, at least=
,
> >>> 1.3.11p1 or upcoming 1.3.12.
> >>>
> >>> I currently using PearDb backend and I'm reaching -sometimes- speed
> >>> problems (I guess this is due to table locking).
> >> Probably more due to caching, unless you use a real database, not just
> >> mysql. There true transactions gain a lot.
> >
> > And what about Mysql transaction capabilities via Innodb ?
>
> Then you have to use the mysqlt driver of ADODB and maybe extend the
> PearDB backend to support this. I haven't yet tested it.
> PDO (php5) also fully supports transactions, so should only be used with
> transaction capable database.
>
> Generally, ADODB pulls in all available ADODB drivers automatically.
> So it's great for testing new databases.
> PeadDB needs for every database a special PearDB_<driver>.php file,
> otherwise it will fail to load. This is the conservative and more stable
> backend.

Thank you for all these informations.
I will keep you inform about my tests.

--Manuel

Re: [Phpwiki-talk] Fatal error: lib/WikiUserNew.php on line 1842

[Reini U. <ru...@x-...>]

joel schaubert schrieb:
> I'm getting an error page under specific conditions
> 
> Wiki phpwiki-1.3.12_rc1
> os  gentoo
> database   file
> 
> After being logged in as admin, then I click the button to "sign out".
> Then I see this error on url  /index.php/HomePage
> 
> *Fatal error*: Cannot access empty property in
> */var/www/localhost/htdocs/tech/wiki/lib/WikiUserNew.php* on line *1842
> 
> *Is this a known bug?

Not yet, thanks. Very good catch! Wonder why this slipped through and
got undetected for some years. In WikiUser.php I did it differently.

> for context,  line 1842 of WikiUserNew.php is the first uncommented line
> shown here
>         if (!isset($pref->{$value}) or $pref->{$value} !=
> $pref->default_value) {

Fix:
        if ((!$value and $pref->default_value)
            or ($value and !isset($pref->$value))
            or ($value and ($pref->$value != $pref->default_value)))
        {

-- 
Reini Urban
http://phpwiki.org/
http://helsinki.at/  http://spacemovie.mur.at/

Re: [Phpwiki-talk] Better SQL backend for Mysql

[Reini U. <ru...@x-...>]

Manuel Vacelet schrieb:
> 2006/3/2, Reini Urban <ru...@x-...>:
>> Manuel Vacelet schrieb:
>>> I'm about to upgrade my phpwiki installation from 1.3.10 to, at least,
>>> 1.3.11p1 or upcoming 1.3.12.
>>>
>>> I currently using PearDb backend and I'm reaching -sometimes- speed
>>> problems (I guess this is due to table locking).
>> Probably more due to caching, unless you use a real database, not just
>> mysql. There true transactions gain a lot.
> 
> And what about Mysql transaction capabilities via Innodb ?

Then you have to use the mysqlt driver of ADODB and maybe extend the
PearDB backend to support this. I haven't yet tested it.
PDO (php5) also fully supports transactions, so should only be used with
transaction capable database.

Generally, ADODB pulls in all available ADODB drivers automatically.
So it's great for testing new databases.
PeadDB needs for every database a special PearDB_<driver>.php file,
otherwise it will fail to load. This is the conservative and more stable
backend.
-- 
Reini Urban
http://phpwiki.org/
http://helsinki.at/  http://spacemovie.mur.at/

RE: [Phpwiki-talk] Fatal error: lib/WikiUserNew.php on line 1842

[Jim F. <ja...@wa...>]

 After being logged in as admin, then I click the button to "sign out".
 Then I see this error on url  /index.php/HomePage
 
 *Fatal error*: Cannot access empty property in *
 /var/www/localhost/htdocs/tech/wiki/lib/WikiUserNew.php* on line *1842
 
 *Is this a known bug?
 
 It's one I'm also experiencing - and was about to post! I'll be interested in any fixes.

Jim Ford

[Phpwiki-talk] Fatal error: lib/WikiUserNew.php on line 1842

[joel s. <fox...@gm...>]

I'm getting an error page under specific conditions

Wiki phpwiki-1.3.12_rc1
os  gentoo
database   file

After being logged in as admin, then I click the button to "sign out".
Then I see this error on url  /index.php/HomePage

*Fatal error*: Cannot access empty property in *
/var/www/localhost/htdocs/tech/wiki/lib/WikiUserNew.php* on line *1842

*Is this a known bug?

Joel



for context,  line 1842 of WikiUserNew.php is the first uncommented line
shown here
        /*
        if ($name =3D=3D 'theme' and $value =3D=3D '')
           return true;
        */
        if (!isset($pref->{$value}) or $pref->{$value} !=3D
$pref->default_value) {
            if ($name =3D=3D 'emailVerified') $newvalue =3D $value;
            else $newvalue =3D $pref->sanify($value);
            $pref->set($name, $newvalue);

Re: [Phpwiki-talk] Better SQL backend for Mysql

[Stefan <son...@ba...>]

Dba support maybe faster when loading a page without plugin which uses 
searchfunctions etc.
Fulltextsearch and most cpu intensiv plugins are much, much faster with 
mysql.

Stefan

Oliver Betz schrieb:

>Reini Urban wrote:
>
>[...]
>
>  
>
>>But fastest is by far the dba backend, because of the communication
>>overhead with the SQL server.
>>    
>>
>
>is the "user can't login anymore after storing preferences" (with 
>ENABLE_USER_NEW = true) error related to dba? If so, one wouldn't use 
>dba.
>
>Oliver
>  
>

Re: [Phpwiki-talk] Better SQL backend for Mysql

[Oliver B. <li...@gm...>]

Reini Urban wrote:

[...]

> But fastest is by far the dba backend, because of the communication
> overhead with the SQL server.

is the "user can't login anymore after storing preferences" (with 
ENABLE_USER_NEW = true) error related to dba? If so, one wouldn't use 
dba.

Oliver
-- 
Oliver Betz, Muenchen

Re: [Phpwiki-talk] Better SQL backend for Mysql

[Manuel V. <man...@gm...>]

2006/3/2, Reini Urban <ru...@x-...>:
> Manuel Vacelet schrieb:
> > I'm about to upgrade my phpwiki installation from 1.3.10 to, at least,
> > 1.3.11p1 or upcoming 1.3.12.
> >
> > I currently using PearDb backend and I'm reaching -sometimes- speed
> > problems (I guess this is due to table locking).
>
> Probably more due to caching, unless you use a real database, not just
> mysql. There true transactions gain a lot.

And what about Mysql transaction capabilities via Innodb ?

> But fastest is by far the dba backend, because of the communication
> overhead with the SQL server.

I've already noticed this in your mails, but I wish to limit as much
as possible different storage format on my server (and I already have
~120 PhpWikis that run mysql backend).

I thank you for all your helpful responses and for great software !
--Manuel

Re: [Phpwiki-talk] SQL.php:97: Notice: Only variables should be assigned by reference

[Reini U. <ru...@x-...>]

William Leader schrieb:
> For this exact notice, I have been able to make a tiny change to SQL.php
> that makes it go away. It doesn't seem to have any ill effects yet on my
> installation.
> 
> In lib/DbSession/SQL.php
>    Change line 97
>    From:
>        $dbh = &$this->_connect();
>    To:
>        $dbh = $this->_connect();

All those fixes and many more are already in 1.3.12_rc2

-- 
Reini Urban
http://phpwiki.org/
http://helsinki.at/  http://spacemovie.mur.at/

Re: [Phpwiki-talk] SQL.php:97: Notice: Only variables should be assigned by reference

[William L. <le...@k2...>]

For this exact notice, I have been able to make a tiny change to SQL.php 
that makes it go away. It doesn't seem to have any ill effects yet on my 
installation.

In lib/DbSession/SQL.php
    Change line 97
    From:
        $dbh = &$this->_connect();
    To:
        $dbh = $this->_connect();

-William Leader

joel schaubert wrote:
> For your second issue in lib/DbSession/SQL.php:97 try looking near the 
> bottom of this known bugs page.  A couple others have found and 
> resolved similar issues.
>
> http://phpwiki.sourceforge.net/phpwiki/KnownBugs
>
>
>

Re: [Phpwiki-talk] Better SQL backend for Mysql

[Reini U. <ru...@x-...>]

Manuel Vacelet schrieb:
> I'm about to upgrade my phpwiki installation from 1.3.10 to, at least,
> 1.3.11p1 or upcoming 1.3.12.
> 
> I currently using PearDb backend and I'm reaching -sometimes- speed
> problems (I guess this is due to table locking).

Probably more due to caching, unless you use a real database, not just
mysql. There true transactions gain a lot.
But fastest is by far the dba backend, because of the communication
overhead with the SQL server.

> I started to read Adodb backend sources and it appears that this one
> seems to be better than PearDB, so I have a couple of question:
> * is it possible to switch from a backend to another one ?

sure.

> * should I use Adodb backend instead of PearDb backend ?

why not?

> * how mature/stable is Adodb backend ?

Stable. With 1.3.12_rc2 I see some asymetries in the transaction logs
with postgresql, but it's not critical.

> * is Adodb really faster than PearDb ?

Yes.

> And in a more long term approach:

> * Why keeping 2 backends for the same storage medium ?

We have more than two. PDO is similar, and there are some more.

> * Do you plan to remove one of them ?

No.
-- 
Reini Urban
http://phpwiki.org/
http://helsinki.at/  http://spacemovie.mur.at/

[Phpwiki-talk] Better SQL backend for Mysql

[Manuel V. <man...@gm...>]

Hi all,

I'm about to upgrade my phpwiki installation from 1.3.10 to, at least,
1.3.11p1 or upcoming 1.3.12.

I currently using PearDb backend and I'm reaching -sometimes- speed
problems (I guess this is due to table locking).

I started to read Adodb backend sources and it appears that this one
seems to be better than PearDB, so I have a couple of question:
* is it possible to switch from a backend to another one ?
* should I use Adodb backend instead of PearDb backend ?
* how mature/stable is Adodb backend ?
* is Adodb really faster than PearDb ?

And in a more long term approach:
* Why keeping 2 backends for the same storage medium ?
* Do you plan to remove one of them ?

Thanks for your input,
Manuel

Re: [Phpwiki-talk] Correct way to make wiki visible?

[Jim F. <ja...@wa...>]

Matt Brown wrote:

>On Wed, 2006-03-01 at 14:10 +0000, Jim Ford wrote:
>  
>
>>I've finally got Phpwiki working O.K.. I've made it visible to users by 
>>making a soft link in the web site directory to my installation 
>>directory /usr/share/phpwiki-1.3.11p1. I understand that this is not the 
>>'proper' way to do it, and I should use an apache alias. Could someone 
>>tell me how I should make the alias, please?
>>    
>>
>
>There is some documentation on the wiki at:
>
>However so many people have added stuff to that page overtime that it's
>hideously confusing!
>
>So, I'll tell you how I do it in the Debian package (which installs
>phpwiki to /usr/share/phpwiki), which seems to work well with Apache
>1/2 
>
>Alias /phpwikidata              /usr/share/phpwiki/
>Alias $docroot                  /usr/share/phpwiki/index.php
>
><Directory /usr/share/phpwiki/>
>    DirectoryIndex index.php
>    Options +FollowSymLinks
>    AllowOverride None
>    Order allow,deny
>    allow from all
></Directory>
>
>Where $docroot is the location you want the wiki to appear at
>(ie. /, /phpwiki, /wiki, etc.)
>
>The magic you need to make this work inside the PHPwiki config is simply
>DATA_PATH=/phpwikidata
>
>All other path related options should be left commented out at their
>defaults.
>
>  
>
Thanks Matt - it works fine now.

Jim Ford

Re: [Phpwiki-talk] Version 1.3.7 php warnings

[Matt B. <ma...@ma...>]

On Thu, 2006-03-02 at 10:03 +0000, Jim Ford wrote:

> Now claim your $10 Matt!

I'm waiting for confirmation that the fix works with the old version :P

Cheers

--=20
Matt Brown
ma...@ma...
Mob +64 21 611 544 www.mattb.net.nz

Re: [Phpwiki-talk] Version 1.3.7 php warnings

[Jim F. <ja...@wa...>]

Matt Brown wrote:

>On Wed, 2006-03-01 at 16:02 -0700, Tom Haws at Hubbard Engineering
>wrote:
>  
>
>>I will gladly donate $10 to the person who helps me suppress or fix 
>>these messages at http://www.hawsedc.com/thomas
>>    
>>
>
>The following patch is used in the Debian package to suppress the few
>remaining instances of this error that are not fixed in 1.3.11p1. 
>  
>
Now claim your $10 Matt!

Jim Ford

Re: [Phpwiki-talk] Version 1.3.7 php warnings

[Matt B. <ma...@ma...>]

On Wed, 2006-03-01 at 16:02 -0700, Tom Haws at Hubbard Engineering
wrote:
> I will gladly donate $10 to the person who helps me suppress or fix=20
> these messages at http://www.hawsedc.com/thomas

The following patch is used in the Debian package to suppress the few
remaining instances of this error that are not fixed in 1.3.11p1.=20

http://svn.mattb.net.nz/viewcvs/debian/phpwiki/trunk/lib/main.php?rev=3D83&=
r1=3D59&r2=3D83

I assume that there is a good reason why you can't just upgrade to the
latest version which fixes most of these messages the proper way?

Cheers

--=20
Matt Brown
ma...@ma...
Mob +64 21 611 544 www.mattb.net.nz

Re: [Phpwiki-talk] 1.3.12_rc2 and postgresql

[Reini U. <ru...@x-...>]

Alfredo Amontagna schrieb:
> Hi all,
> I have some problem with phpwiki 1.3.12_rc2
> 
> The first one is probably caused by a little bug in the backend code for
> postgresql.
> 
> Trying to "sign in" I receive the following fatal error:
> 
> |/usr/local/share/phpwiki-1.3.12_rc2/lib/WikiDB/backend/PearDB.php:1024:
> |	Error: wikidb_backend_peardb_pgsql: fatal database error
> |
> |   * DB Error: no such table
> |   * (SELECT prefs FROM pref WHERE userid='AlfredoAmontagna' [nativecode=ERROR: relation "pref" does not exist])
> |   *
> |
> |Notice: Undefined property: _user in /usr/local/share/phpwiki-1.3.12_rc2/lib/main.php on line 734
> 
> I think that in the code is missed the prefix defined in the config
> file:
> define('DATABASE_PREFIX', 'italt_');
> 
> Infact after creating the table "pref" (without prefix) the problem
> seems solved.

good point. thanks.
The correct way is to fix the config.ini DBAUTH SQL statements (the pref
tablename) for your prefix.

We want to be independent and allow external prefs and auth (external
databases and hosts), but for prefs it would be the best that we add the
table prefix for the default setup.

 > |CREATE TABLE pref (
> |        userid  CHAR(48) PRIMARY KEY,
> |        prefs   TEXT NULL DEFAULT '',
> |        passwd  CHAR(48) DEFAULT '',
> |        groupname CHAR(48) DEFAULT 'users'
> |);
> |GRANT SELECT,INSERT,UPDATE,DELETE ON pref TO "www-data";
> 
> I'm sorry, but I'm not a coder and I'm not able to check.
> 
> The second problem is very strange for me, and I cannot reproduce it :-(
> Sometime trying to modify a page, after giving "?action=edit" the
> browser receive a blank (empty) page.
> 
> This strange problem happens also with other backend type.
> 
> Can someone point me to some setting or to something to check to give
> more information?

Yes, this was a known problem some years ago.
Play with the redirect settings: DISABLE_HTTP_REDIRECT = true

Or try to mess with the redirect template as posted some weeks ago here
on this list.
This is server specific.
-- 
Reini Urban
http://phpwiki.org/
http://helsinki.at/  http://spacemovie.mur.at/

[Phpwiki-talk] Version 1.3.7 php warnings

[Tom H. at H. E. <th...@hu...>]

I will gladly donate $10 to the person who helps me suppress or fix 
these messages at http://www.hawsedc.com/thomas


        PHP Warnings

phpwiki/lib/pear/DB/common.php:741: Notice[8]: Only variable references 
should be returned by reference

phpwiki/lib/pear/DB/common.php:881: Notice[8]: Only variable references 
should be returned by reference

phpwiki/lib/WikiUser.php:59: Notice[8]: Only variables should be 
assigned by reference

phpwiki/lib/pear/DB/common.php:741: Notice[8]: Only variable references 
should be returned by reference

phpwiki/lib/pear/DB/common.php:741: Notice[8]: Only variable references 
should be returned by reference

phpwiki/lib/pear/DB/common.php:881: Notice[8]: Only variable references 
should be returned by reference

phpwiki/lib/pear/DB/common.php:741: Notice[8]: Only variable references 
should be returned by reference

phpwiki/lib/Template.php:112: Notice[8]: Only variables should be 
assigned by reference



I am running:
Operating System 	Linux
Kernel Version 	2.4.29-grsec
Apache Version 	1.3.34 (Unix)
Perl Version 
<http://constructionnotesmanager.com:2082/frontend/jaguarpc/index.html#> 
5.8.1
PHP Version 
<http://constructionnotesmanager.com:2082/frontend/jaguarpc/index.html#> 
4.4.2
MySQL Version 	4.0.25-standard
Path to Perl 	/usr/bin/perl
Path to sendmail 	/usr/sbin/sendmail
Jaguar Panel Version 	3.1
Cpanel Version 	10.8.1-STABLE 114

 


-- 

Tom Haws, P.E.
HUBBARD ENGINEERING
Civil Engineers and Land Surveyors
625 N. Gilbert Road, Suite 106
Gilbert, Arizona 85234
Tel 480 892-3313
Fax 480 892-7051
th...@hu...

Re: [Phpwiki-talk] Correct way to make wiki visible?

[Matt B. <ma...@ma...>]

On Wed, 2006-03-01 at 14:10 +0000, Jim Ford wrote:
> I've finally got Phpwiki working O.K.. I've made it visible to users by=20
> making a soft link in the web site directory to my installation=20
> directory /usr/share/phpwiki-1.3.11p1. I understand that this is not the=20
> 'proper' way to do it, and I should use an apache alias. Could someone=20
> tell me how I should make the alias, please?

There is some documentation on the wiki at:

However so many people have added stuff to that page overtime that it's
hideously confusing!

So, I'll tell you how I do it in the Debian package (which installs
phpwiki to /usr/share/phpwiki), which seems to work well with Apache
1/2=20

Alias /phpwikidata              /usr/share/phpwiki/
Alias $docroot                  /usr/share/phpwiki/index.php

<Directory /usr/share/phpwiki/>
    DirectoryIndex index.php
    Options +FollowSymLinks
    AllowOverride None
    Order allow,deny
    allow from all
</Directory>

Where $docroot is the location you want the wiki to appear at
(ie. /, /phpwiki, /wiki, etc.)

The magic you need to make this work inside the PHPwiki config is simply
DATA_PATH=3D/phpwikidata

All other path related options should be left commented out at their
defaults.

HTH.

Cheers

--=20
Matt Brown
ma...@ma...
Mob +64 21 611 544 www.mattb.net.nz

[Phpwiki-talk] 1.3.12_rc2 and postgresql

[Alfredo A. <alf...@li...>]

Hi all,
I have some problem with phpwiki 1.3.12_rc2

The first one is probably caused by a little bug in the backend code for
postgresql.

Trying to "sign in" I receive the following fatal error:

|/usr/local/share/phpwiki-1.3.12_rc2/lib/WikiDB/backend/PearDB.php:1024:
|	Error: wikidb_backend_peardb_pgsql: fatal database error
|
|   * DB Error: no such table
|   * (SELECT prefs FROM pref WHERE userid='AlfredoAmontagna' [nativecode=ERROR: relation "pref" does not exist])
|   *
|
|Notice: Undefined property: _user in /usr/local/share/phpwiki-1.3.12_rc2/lib/main.php on line 734

I think that in the code is missed the prefix defined in the config
file:
define('DATABASE_PREFIX', 'italt_');

Infact after creating the table "pref" (without prefix) the problem
seems solved.

|CREATE TABLE pref (
|        userid  CHAR(48) PRIMARY KEY,
|        prefs   TEXT NULL DEFAULT '',
|        passwd  CHAR(48) DEFAULT '',
|        groupname CHAR(48) DEFAULT 'users'
|);
|GRANT SELECT,INSERT,UPDATE,DELETE ON pref TO "www-data";

I'm sorry, but I'm not a coder and I'm not able to check.




The second problem is very strange for me, and I cannot reproduce it :-(
Sometime trying to modify a page, after giving "?action=edit" the
browser receive a blank (empty) page.

This strange problem happens also with other backend type.

Can someone point me to some setting or to something to check to give
more information?

TIA
-- 
Bye,
Alfredo

[Phpwiki-talk] Correct way to make wiki visible?

[Jim F. <ja...@wa...>]

I've finally got Phpwiki working O.K.. I've made it visible to users by 
making a soft link in the web site directory to my installation 
directory /usr/share/phpwiki-1.3.11p1. I understand that this is not the 
'proper' way to do it, and I should use an apache alias. Could someone 
tell me how I should make the alias, please?

Jim Ford

Re: [Phpwiki-talk] SiteMap.php

[Stefan <son...@ba...>]

Hello Reini,

i didn't understand the code at all so it was a quick fix that works 
without known problems for us.

One thing more in the original code, needle and heystack has to be 
changed i think?
&& !preg_match("/$this->ExcludePages/", $linkpagename))  {

Stefan

Reini Urban schrieb:

>Stefan schrieb:
>  
>
>>SORRY FORGOT TO DELETE ONE ECHO WITHIN THE FILE
>>here is the corrected Version
>>Stefan
>>
>>------
>>I've done some changes to SiteMap.php to eleminate a lot of errors and
>>warnings. The function preg_match was used wrong so i replaced it by a
>>few lines of code and now it works without error. SiteMap is used from
>>IncludeSiteMap.php which now works with page names including white space
>>etc ...
>>    
>>
>
>Sorry, your version is not all correct.
>Your problem is that you assume that
>  $this->ExcludedPages = join("|", $exclude);
>but
>  $this->ExcludedPages = "^(?:" . join("|", $exclude) . ")";
>
>$exclude is a user regular expression, which must be passed to preg_match.
>But $exclude could be PageList also, if taken from a <!plugin-list !>,
>so the real fix will be expand a possible pagelist.
>
>And of course to quote the linkname as plugin arg as your did, thanks!
>  
>

Re: [Phpwiki-talk] SiteMap.php

[Reini U. <ru...@x-...>]

Stefan schrieb:
> SORRY FORGOT TO DELETE ONE ECHO WITHIN THE FILE
> here is the corrected Version
> Stefan
> 
> ------
> I've done some changes to SiteMap.php to eleminate a lot of errors and
> warnings. The function preg_match was used wrong so i replaced it by a
> few lines of code and now it works without error. SiteMap is used from
> IncludeSiteMap.php which now works with page names including white space
> etc ...

Sorry, your version is not all correct.
Your problem is that you assume that
  $this->ExcludedPages = join("|", $exclude);
but
  $this->ExcludedPages = "^(?:" . join("|", $exclude) . ")";

$exclude is a user regular expression, which must be passed to preg_match.
But $exclude could be PageList also, if taken from a <!plugin-list !>,
so the real fix will be expand a possible pagelist.

And of course to quote the linkname as plugin arg as your did, thanks!
-- 
Reini Urban
http://phpwiki.org/
http://helsinki.at/  http://spacemovie.mur.at/

[Phpwiki-talk] SiteMap.php

[Stefan <son...@ba...>]

SORRY FORGOT TO DELETE ONE ECHO WITHIN THE FILE

here is the corrected Version
Stefan

------
I've done some changes to SiteMap.php to eleminate a lot of errors and
warnings. The function preg_match was used wrong so i replaced it by a
few lines of code and now it works without error. SiteMap is used from
IncludeSiteMap.php which now works with page names including white space
etc ...

File is attached
Stefan