Re: [Phpwiki-talk] Fatal error: lib/WikiUserNew.php on line 1842

[Reini U. <ru...@x-...>]

joel schaubert schrieb:
> I'm getting an error page under specific conditions
> 
> Wiki phpwiki-1.3.12_rc1
> os  gentoo
> database   file
> 
> After being logged in as admin, then I click the button to "sign out".
> Then I see this error on url  /index.php/HomePage
> 
> *Fatal error*: Cannot access empty property in
> */var/www/localhost/htdocs/tech/wiki/lib/WikiUserNew.php* on line *1842
> 
> *Is this a known bug?

Not yet, thanks. Very good catch! Wonder why this slipped through and
got undetected for some years. In WikiUser.php I did it differently.

> for context,  line 1842 of WikiUserNew.php is the first uncommented line
> shown here
>         if (!isset($pref->{$value}) or $pref->{$value} !=
> $pref->default_value) {

Fix:
        if ((!$value and $pref->default_value)
            or ($value and !isset($pref->$value))
            or ($value and ($pref->$value != $pref->default_value)))
        {

-- 
Reini Urban
http://phpwiki.org/
http://helsinki.at/  http://spacemovie.mur.at/