Menu
▾
▴
phpbt-dev — Developer's mailing list and cvs commits
You can subscribe to this list here.
| 2001 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(34) |
Aug
(215) |
Sep
(180) |
Oct
(135) |
Nov
(105) |
Dec
(81) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2002 |
Jan
(76) |
Feb
(22) |
Mar
(154) |
Apr
(149) |
May
(128) |
Jun
(94) |
Jul
(14) |
Aug
(24) |
Sep
(77) |
Oct
(52) |
Nov
(22) |
Dec
(6) |
| 2003 |
Jan
(4) |
Feb
(10) |
Mar
(6) |
Apr
(29) |
May
(10) |
Jun
(37) |
Jul
(39) |
Aug
(13) |
Sep
(23) |
Oct
(3) |
Nov
(7) |
Dec
(2) |
| 2004 |
Jan
|
Feb
(10) |
Mar
(4) |
Apr
|
May
(35) |
Jun
(4) |
Jul
(17) |
Aug
(6) |
Sep
(14) |
Oct
(18) |
Nov
(2) |
Dec
(14) |
| 2005 |
Jan
(9) |
Feb
(30) |
Mar
(6) |
Apr
|
May
(38) |
Jun
(23) |
Jul
(21) |
Aug
(76) |
Sep
(50) |
Oct
(51) |
Nov
(13) |
Dec
|
|
From: Ben C. <php...@be...> - 2002-06-11 12:42:01
|
I think what would be better in this case is to have a user option controlling it, rather than an admin option. On Tue, Jun 11, 2002 at 10:22:13AM -0000, Jirka Pech wrote: > > Thanks for the ideas. I've just committed the changes to put the saved > > queries on the simple query form. I'm thinking that we don't really > > need an option in the admin interface for whether to show the saved > > queries on the home page -- if an admin doesn't want it he could remove > > the section from index.html. Does anyone have thoughts on this? > > I think, that to have an easy to switch option is better, because you sometimes want to upgrade (or do anything else) and when you have not to check the code again and comment/remove something, it better. Or not? > > _______________________________________________________________ > > Don't miss the 2002 Sprint PCS Application Developer's Conference > August 25-28 in Las Vegas - http://devcon.sprintpcs.com/adp/index.cfm?source=osdntextlink > > _______________________________________________ > phpbt-dev mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpbt-dev |
|
From: Jirka P. <fi...@us...> - 2002-06-11 10:22:23
|
> Thanks for the ideas. I've just committed the changes to put the saved > queries on the simple query form. I'm thinking that we don't really > need an option in the admin interface for whether to show the saved > queries on the home page -- if an admin doesn't want it he could remove > the section from index.html. Does anyone have thoughts on this? I think, that to have an easy to switch option is better, because you somet= imes want to upgrade (or do anything else) and when you have not to check t= he code again and comment/remove something, it better. Or not? |
|
From: Benjamin C. <bc...@us...> - 2002-06-10 12:52:39
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv1467/templates/default
Modified Files:
index.html
Log Message:
Show the saved queries on the home page (Adi Sieker)
Index: index.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/index.html,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- index.html 18 May 2002 03:00:50 -0000 1.9
+++ index.html 10 Jun 2002 12:52:35 -0000 1.10
@@ -17,6 +17,15 @@
{sectionelse}
{$STRING.nobugs}
{/section}
+ {if count($queries)}
+ <br>
+ <br>
+ <b>Saved Queries</b>
+ <br>
+ {section name=query loop=$queries}
+ <a href="{$smarty.server.PHP_SELF}?{$queries[query].saved_query_string}">{$queries[query].saved_query_name}</a><br>
+ {/section}
+ {/if}
</td>
<td valign="top">
{if USE_JPGRAPH}
|
|
From: Benjamin C. <bc...@us...> - 2002-06-10 12:52:39
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv1467
Modified Files:
index.php
Log Message:
Show the saved queries on the home page (Adi Sieker)
Index: index.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/index.php,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- index.php 18 May 2002 02:59:32 -0000 1.32
+++ index.php 10 Jun 2002 12:52:35 -0000 1.33
@@ -137,6 +137,12 @@
" and changed_field = 'status' and new_value = 'Closed'".
' and b.project_id = p.project_id order by h.created_date desc', 0, 5)));
+if ($u != 'nobody') {
+ // Grab the saved queries if there are any
+ $t->assign('queries',
+ $db->getAll("select * from ".TBL_SAVED_QUERY." where user_id = '$u'"));
+}
+
$t->wrap('index.html', 'home');
?>
|
|
From: Benjamin C. <bc...@us...> - 2002-06-08 20:28:58
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv19485/templates/default
Modified Files:
queryform.html queryform-simple.html
Log Message:
Return to the correct query page when deleting a saved query
Index: queryform.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/queryform.html,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- queryform.html 8 Jun 2002 20:13:21 -0000 1.12
+++ queryform.html 8 Jun 2002 20:28:52 -0000 1.13
@@ -225,7 +225,7 @@
<b>Saved Queries</b>
<br>
{section name=query loop=$queries}
- <a href="{$smarty.server.PHP_SELF}?{$queries[query].saved_query_string}">{$queries[query].saved_query_name}</a> (<a href="{$smarty.server.PHP_SELF}?op=delquery&queryid={$queries[query].saved_query_id}" onClick="return confirm('Are you sure you want to delete this saved query?');">Delete</a>)<br>
+ <a href="{$smarty.server.PHP_SELF}?{$queries[query].saved_query_string}">{$queries[query].saved_query_name}</a> (<a href="{$smarty.server.PHP_SELF}?op=delquery&queryid={$queries[query].saved_query_id}&form=advanced" onClick="return confirm('Are you sure you want to delete this saved query?');">Delete</a>)<br>
{/section}
{/if}
</form>
Index: queryform-simple.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/queryform-simple.html,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- queryform-simple.html 8 Jun 2002 20:13:04 -0000 1.5
+++ queryform-simple.html 8 Jun 2002 20:28:52 -0000 1.6
@@ -93,7 +93,7 @@
<b>Saved Queries</b>
<br>
{section name=query loop=$queries}
- <a href="{$smarty.server.PHP_SELF}?{$queries[query].saved_query_string}">{$queries[query].saved_query_name}</a> (<a href="{$smarty.server.PHP_SELF}?op=delquery&queryid={$queries[query].saved_query_id}" onClick="return confirm('Are you sure you want to delete this saved query?');">Delete</a>)<br>
+ <a href="{$smarty.server.PHP_SELF}?{$queries[query].saved_query_string}">{$queries[query].saved_query_name}</a> (<a href="{$smarty.server.PHP_SELF}?op=delquery&queryid={$queries[query].saved_query_id}&form=simple" onClick="return confirm('Are you sure you want to delete this saved query?');">Delete</a>)<br>
{/section}
{/if}
</form>
|
|
From: Benjamin C. <bc...@us...> - 2002-06-08 20:28:33
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv19416
Modified Files:
query.php
Log Message:
Fix a bug with the saved queries on windows, and return to the correct query page when deleting a saved query
Index: query.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/query.php,v
retrieving revision 1.75
retrieving revision 1.76
diff -u -r1.75 -r1.76
--- query.php 8 Jun 2002 20:13:03 -0000 1.75
+++ query.php 8 Jun 2002 20:28:30 -0000 1.76
@@ -25,11 +25,15 @@
include 'include.php';
function delete_saved_query($queryid) {
- global $db, $u, $me;
+ global $db, $u, $me, $_gv;
$db->query("delete from ".TBL_SAVED_QUERY." where user_id = $u
and saved_query_id = $queryid");
- header("Location: $me?op=query&form=advanced");
+ if (!empty($_gv['form']) and $_gv['form'] == 'advanced') {
+ header("Location: $me?op=query&form=advanced");
+ } else {
+ header("Location: $me?op=query");
+ }
}
function show_query() {
@@ -220,7 +224,7 @@
}
// Save the query if requested
if (!empty($savedqueryname)) {
- $savedquerystring = ereg_replace('&savedqueryname=.*(&?)', '\\1', $HTTP_SERVER_VARS['QUERY_STRING']);
+ $savedquerystring = ereg_replace('&savedqueryname=.*(&?)', '\1', $HTTP_SERVER_VARS['QUERY_STRING']);
$nextid = $db->getOne("select max(saved_query_id)+1 from ".TBL_SAVED_QUERY." where user_id = $u");
$nextid = $nextid ? $nextid : 1;
$db->query("insert into ".TBL_SAVED_QUERY.
|
|
From: Ben C. <php...@be...> - 2002-06-08 20:18:58
|
Thanks for the ideas. I've just committed the changes to put the saved queries on the simple query form. I'm thinking that we don't really need an option in the admin interface for whether to show the saved queries on the home page -- if an admin doesn't want it he could remove the section from index.html. Does anyone have thoughts on this? On Fri, May 24, 2002 at 04:36:52PM +0100, Adi Sieker wrote: > Hi, > > > I added two things to phpBT. > > 1. saved queries are also shown on the simple query page. > The saved queries are always shown, just as on the advanced > query page. > you can get the neccesary files here: > > http://www.l33tless.org/file.php?f=/code/files/show_saved_queries_on_simple_for > m.zip > > 2. show saved queries in the home page when a user is logged in. > This feature is optional and can be set via the configuration screen > in the admin section. > you can get the neccesary files here: > > http://www.l33tless.org/file.php?f=/code/files/show_saved_queries_on_home.zip > > BTW, I like the way phpBT is structured it's very easy to understand and > simle things like this are a breeze. > > Regards > Adi > > _______________________________________________________________ > > Don't miss the 2002 Sprint PCS Application Developer's Conference > August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm > > _______________________________________________ > phpbt-dev mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpbt-dev |
|
From: Benjamin C. <bc...@us...> - 2002-06-08 20:13:24
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv16501/templates/default
Modified Files:
queryform.html
Log Message:
Changed the look of the saved queries a little
Index: queryform.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/queryform.html,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- queryform.html 24 May 2002 15:19:16 -0000 1.11
+++ queryform.html 8 Jun 2002 20:13:21 -0000 1.12
@@ -214,12 +214,14 @@
</nobr>
<br>
<br>
- <input type="reset" value="Reset back to the default query">
- <input type="submit" value="Submit query">
{if $smarty.session.uid}
- <br>
Save this query as: <input maxlength="40" type="text" name="savedqueryname">
- <hr align="left" size="1" width="100%">
+ <br><br>
+ {/if}
+ <input type="reset" value="Reset back to the default query">
+ <input type="submit" value="Submit query">
+ {if count($queries)}
+ <br><br>
<b>Saved Queries</b>
<br>
{section name=query loop=$queries}
|
|
From: Benjamin C. <bc...@us...> - 2002-06-08 20:13:07
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv16414
Modified Files:
query.php
Log Message:
Added saved queries to simple query page (Adi Sieker)
Index: query.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/query.php,v
retrieving revision 1.74
retrieving revision 1.75
diff -u -r1.74 -r1.75
--- query.php 18 May 2002 16:21:12 -0000 1.74
+++ query.php 8 Jun 2002 20:13:03 -0000 1.75
@@ -35,17 +35,19 @@
function show_query() {
global $db, $t, $TITLE, $u, $_gv;
+ if ($u != 'nobody') {
+ // Grab the saved queries if there are any
+ $t->assign('queries',
+ $db->getAll("select * from ".TBL_SAVED_QUERY." where user_id = '$u'"));
+ }
+
// Show the advanced query form
if (!empty($_gv['form']) and $_gv['form'] == 'advanced') {
- if ($u != 'nobody') {
- // Grab the saved queries if there are any
- $t->assign('queries',
- $db->getAll("select * from ".TBL_SAVED_QUERY." where user_id = '$u'"));
- }
$t->wrap('queryform.html', 'bugquery');
} else { // or show the simple one
$t->wrap('queryform-simple.html', 'bugquery');
}
+
}
function build_query($assignedto, $reportedby, $open) {
|
|
From: Benjamin C. <bc...@us...> - 2002-06-08 20:13:06
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv16414/templates/default
Modified Files:
queryform-simple.html
Log Message:
Added saved queries to simple query page (Adi Sieker)
Index: queryform-simple.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/queryform-simple.html,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- queryform-simple.html 18 May 2002 03:00:50 -0000 1.4
+++ queryform-simple.html 8 Jun 2002 20:13:04 -0000 1.5
@@ -81,9 +81,21 @@
</table>
<br>
<br>
+ {if $smarty.session.uid}
+ Save this query as: <input maxlength="40" type="text" name="savedqueryname">
+ <br><br>
+ {/if}
<input type="hidden" name="op" value="doquery">
<input type="reset" value="Reset back to the default query">
<input type="submit" value="Submit query">
+ {if count($queries)}
+ <br><br>
+ <b>Saved Queries</b>
+ <br>
+ {section name=query loop=$queries}
+ <a href="{$smarty.server.PHP_SELF}?{$queries[query].saved_query_string}">{$queries[query].saved_query_name}</a> (<a href="{$smarty.server.PHP_SELF}?op=delquery&queryid={$queries[query].saved_query_id}" onClick="return confirm('Are you sure you want to delete this saved query?');">Delete</a>)<br>
+ {/section}
+ {/if}
</form>
<br>
Go to the <a href="{$smarty.server.PHP_SELF}?op=query&form=advanced">advanced query page</a>
|
|
From: Jirka P. <fi...@us...> - 2002-06-05 15:25:12
|
Update of /cvsroot/phpbt/phpbt/inc
In directory usw-pr-cvs1:/tmp/cvs-serv15455/phpbt/inc
Modified Files:
functions.php
Log Message:
Added NONE to database list in build_select. Maybe ALL will be better, I don't know.
Index: functions.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- functions.php 21 May 2002 11:20:17 -0000 1.29
+++ functions.php 5 Jun 2002 15:25:08 -0000 1.30
@@ -124,6 +124,7 @@
}
break;
case 'database' :
+ $text = '<option value="0">None</option>';
$rs = $db->query($queries[$box]);
while ($rs->fetchInto($row)) {
if ($selected == $row[$box.'_id'] and $selected != '') $sel = ' selected';
|
|
From: Jirka P. <fi...@us...> - 2002-05-30 15:04:27
|
Update of /cvsroot/phpbt/phpbt/inc/db In directory usw-pr-cvs1:/tmp/cvs-serv14713/phpbt/inc/db Modified Files: mysql.php Log Message: Adding some columns (versions, database ...). Ben, please check it and make changes to pgsql file. I will then make changes to oci8 file. And of course I will add columns to other queries not only this one. Later. Index: mysql.php =================================================================== RCS file: /cvsroot/phpbt/phpbt/inc/db/mysql.php,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- mysql.php 19 May 2002 13:25:48 -0000 1.7 +++ mysql.php 30 May 2002 15:04:22 -0000 1.8 @@ -126,7 +126,10 @@ 'left join '.TBL_AUTH_USER.' owner on b.assigned_to = owner.user_id '. 'left join '.TBL_AUTH_USER.' reporter on b.created_by = reporter.user_id '. 'left join '.TBL_AUTH_USER.' lastmodifier on b.last_modified_by = lastmodifier.user_id '. - 'left join '.TBL_RESOLUTION.' resolution on b.resolution_id = resolution.resolution_id, '. + 'left join '.TBL_RESOLUTION.' resolution on b.resolution_id = resolution.resolution_id '. + 'left join '.TBL_DATABASE.' on b.database_id = '.TBL_DATABASE.'.database_id '. + 'left join '.TBL_VERSION.' version2 on b.to_be_closed_in_version_id = version2.version_id '. + 'left join '.TBL_VERSION.' version3 on b.closed_in_version_id = version3.version_id, '. TBL_SEVERITY.' severity, '.TBL_STATUS.' status, '.TBL_OS.' os, '. TBL_VERSION.' version, '.TBL_COMPONENT.' component, '.TBL_PROJECT.' project '. 'where b.severity_id = severity.severity_id '. |
|
From: Ben C. <php...@be...> - 2002-05-25 21:18:22
|
Ok, I've reread the original email a couple of times now, and the impression that have is that this might be an endeavor more suitable for after 1.0. The reason I asked about the means you would use for avoiding altering the bug table is that I don't think it was completely addressed in the original post. For example, let's say that I take the current schema and want to add a new module for tracking: Language. Language lookup table: lang_id, lang_name 1, 'English' 2, 'French' 3, 'Czech' Then I add Language to my list of modules: module_id, module_name 1, 'Language' Now I want language tracking of component 2 which is associated with project 12 (component -> module table): component_id, module_id 2, 1 Now when I create a new bug for component 2 and select the French language I need to store the bug_id -> module_id somewhere. Currently that would be done by adding module_id to the bug table. However, to avoid making changes to the bug table we need to use a separate table with the information: bug_id, module_id, module_value 33, 1, 2 Now, this level of table joining (bug -> component_module -> language, db, environment, etc.) becomes a problem when trying to show a list of bugs that are using all, some, or none of these modules. All of a sudden there are a lot more queries to get that columnar information when before only one was required. That is why I'm thinking this may need to wait a while, and why this may not be the best approach (though it may turn out to be). Thoughts? On Mon, May 20, 2002 at 07:14:27AM -0000, Jirka Pech wrote: > > This sounds like a great start to a good idea. It would definitely be > > nice to enable the admin to choose which options will be used (and yes, > > by component makes sense to me -- especially when considering large > > projects/products). The only thing I didn't understand clearly from > > your email was if there was a way to avoid having to add columns to the > > bug table for each link (database_id, os_id, etc.). Did I just miss it, > > or do we need to come up with a way? > > There is a way to avoid having to add columns. It's described in an e-mail you are responding to. I tryied to explain, what I'm prepared to do (create some tables and so) and I've requested comments and ideas before I will start. > > John wrote it's a good idea, but with lot of template work. I know it and I asked if you are ready for this work, because I'm not 100% able to understand the smarty templates logic now. I will need your helping hand when I will start. And I will never start before everything will be 100% understood. > > Is it clearer now? > > Jirka > > _______________________________________________________________ > Hundreds of nodes, one monster rendering program. > Now that's a super model! Visit http://clustering.foundries.sf.net/ > > _______________________________________________ > phpbt-dev mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpbt-dev |
|
From: Alessandro P. (T. / J578) <al...@ti...> - 2002-05-24 15:21:33
|
On Fri, 2002-05-24 at 16:56, Ben Curtis wrote: > You're probably right. Way back when the templates were all set to a > width of 640, but with the transition to smarty I started switching the > tables to a width of 100%. I haven't done a thorough review of all the > templates to see if any more conversion needs to be done. I guess I > will ample opportunity to look at this when I take all the literal text > out of the templates for translation purposes. :) Okay...meanwhile i fixed some of them: 640 is now 100% there still are some pixel-based width, like some popups (150-pixels and 300-pixels), but they need some careful inspection ... so i leave them to you :) Bye Alessandro -- Alessandro "TXM" Pisani - alextxm at tin dot it - ICQ: #2209087 "I will carry you through, kicking and screaming, and in the end you will thank me" - Tyler Durden [from "Fight Club"] |
|
From: Alessandro P. <al...@us...> - 2002-05-24 15:19:20
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv24623
Modified Files:
badgroup.html badperm.html bugdisplay-printable.html
bugdisplay.html error.html install-complete.html install.html
newaccount-disabled.html newaccountsuccess.html queryform.html
Log Message:
switch table width to percent-size
Index: badgroup.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/badgroup.html,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- badgroup.html 24 May 2002 12:44:35 -0000 1.3
+++ badgroup.html 24 May 2002 15:19:16 -0000 1.4
@@ -1,4 +1,4 @@
-<table border="0" width="640">
+<table border="0" width="100%">
<tr>
<td align="center">
<br>
Index: badperm.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/badperm.html,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- badperm.html 24 May 2002 12:44:35 -0000 1.5
+++ badperm.html 24 May 2002 15:19:16 -0000 1.6
@@ -1,4 +1,4 @@
-<table border="0" width="640">
+<table border="0" width="100%">
<tr>
<td align="center">
<br>
Index: bugdisplay-printable.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugdisplay-printable.html,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- bugdisplay-printable.html 18 May 2002 03:00:50 -0000 1.7
+++ bugdisplay-printable.html 24 May 2002 15:19:16 -0000 1.8
@@ -1,4 +1,4 @@
-<table border='0' width="640">
+<table border='0' width="100%">
<tr>
<td width="210" colspan="2">
Bug <b>#{$bug_id}</b>
@@ -56,7 +56,7 @@
</td>
</tr>
</table>
-<table border="0" cellpadding="2" cellspacing="0" width="640">
+<table border="0" cellpadding="2" cellspacing="0" width="100%">
<tr>
<td>Assigned To:</td>
<td><b>{$owner|maskemail}</td>
@@ -84,7 +84,7 @@
</table>
<br>
<br>
-<table border="0" cellpadding="2" cellspacing="0" width="640">
+<table border="0" cellpadding="2" cellspacing="0" width="100%">
<tr>
<td>
Bug Dependencies: {$bug_dependencies}
Index: bugdisplay.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugdisplay.html,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- bugdisplay.html 21 May 2002 13:35:10 -0000 1.32
+++ bugdisplay.html 24 May 2002 15:19:16 -0000 1.33
@@ -147,7 +147,7 @@
</td>
</tr>
</table>
-<table border="0" cellpadding="2" cellspacing="0" width="640">
+<table border="0" cellpadding="2" cellspacing="0" width="100%">
<tr>
<td valign="top">
Additional Comments:
@@ -234,7 +234,7 @@
</div>
<br>
<br>
-<table border="0" cellpadding="2" cellspacing="0" width="640">
+<table border="0" cellpadding="2" cellspacing="0" width="100%">
<tr>
<td>
Comments:
Index: error.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/error.html,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- error.html 24 May 2002 12:44:35 -0000 1.3
+++ error.html 24 May 2002 15:19:16 -0000 1.4
@@ -1,4 +1,4 @@
-<table width="640">
+<table width="100%">
<tr>
<td align="center">
{if $iserror}
Index: install-complete.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/install-complete.html,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- install-complete.html 11 Apr 2002 20:29:34 -0000 1.5
+++ install-complete.html 24 May 2002 15:19:16 -0000 1.6
@@ -3,7 +3,7 @@
<link rel="StyleSheet" href="styles/default.css" type="text/css">
</head>
<body bgcolor="#ffffff" link="#006699" vlink="#006699" alink="#006699">
-<table border="0" cellpadding="0" cellspacing="0" width="640">
+<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr>
<td width="200" valign="top"><br><img src="logo.jpg"></td>
<td valign="top">
Index: install.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/install.html,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- install.html 8 May 2002 01:10:00 -0000 1.7
+++ install.html 24 May 2002 15:19:16 -0000 1.8
@@ -4,7 +4,7 @@
</head>
<body bgcolor="#ffffff" link="#006699" vlink="#006699" alink="#006699">
<form action="{$smarty.server.PHP_SELF}" method="post">
-<table border="0" cellpadding="0" cellspacing="0" width="640">
+<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr>
<td width="200" valign="top"><br><img src="logo.jpg"></td>
<td valign="top" align="center">
Index: newaccount-disabled.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/newaccount-disabled.html,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- newaccount-disabled.html 18 May 2002 03:00:50 -0000 1.3
+++ newaccount-disabled.html 24 May 2002 15:19:16 -0000 1.4
@@ -1,4 +1,4 @@
-<table width="640" border="0">
+<table width="100%" border="0">
<tr>
<td align="center">
Sorry, but the self-creation of new accounts has been disabled. Please
Index: newaccountsuccess.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/newaccountsuccess.html,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- newaccountsuccess.html 18 May 2002 03:00:50 -0000 1.3
+++ newaccountsuccess.html 24 May 2002 15:19:16 -0000 1.4
@@ -1,6 +1,6 @@
<br>
<br>
-<table border="0" width="640" align="center">
+<table border="0" width="100%" align="center">
<tr>
<td>
Thanks for creating an account. Check your email for your password.
Index: queryform.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/queryform.html,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- queryform.html 18 May 2002 03:00:50 -0000 1.10
+++ queryform.html 24 May 2002 15:19:16 -0000 1.11
@@ -163,7 +163,7 @@
</tr>
</table>
- <hr align="left" width="640">
+ <hr align="left" width="100%">
<table>
<tr>
<td><b>Project:</b></td>
@@ -187,7 +187,7 @@
</td>
</tr>
</table>
- <hr align="left" width="640">
+ <hr align="left" width="100%">
<input type="hidden" name="op" value="doquery">
<nobr><b>Sort By:</b>
<select name="order">
@@ -219,7 +219,7 @@
{if $smarty.session.uid}
<br>
Save this query as: <input maxlength="40" type="text" name="savedqueryname">
- <hr align="left" size="1" width="640">
+ <hr align="left" size="1" width="100%">
<b>Saved Queries</b>
<br>
{section name=query loop=$queries}
|
|
From: Alessandro P. <al...@us...> - 2002-05-24 15:19:20
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory usw-pr-cvs1:/tmp/cvs-serv24623/admin
Modified Files:
badperm.html configure.html
Log Message:
switch table width to percent-size
Index: badperm.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/badperm.html,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- badperm.html 11 Oct 2001 14:24:04 -0000 1.1
+++ badperm.html 24 May 2002 15:19:16 -0000 1.2
@@ -1,4 +1,4 @@
-<table border="0" width="640">
+<table border="0" width="100%">
<tr>
<td align="center">
<font color="#ff0000">
Index: configure.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/configure.html,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- configure.html 18 May 2002 03:00:50 -0000 1.5
+++ configure.html 24 May 2002 15:19:16 -0000 1.6
@@ -1,5 +1,5 @@
<form action="{$smarty.server.PHP_SELF}" method="post">
-<table border="0" width="640">
+<table border="0" width="100%">
<tr>
<td valign="top">
<b> {$page_title}</b>
|
|
From: Ben C. <php...@be...> - 2002-05-24 14:56:35
|
You're probably right. Way back when the templates were all set to a width of 640, but with the transition to smarty I started switching the tables to a width of 100%. I haven't done a thorough review of all the templates to see if any more conversion needs to be done. I guess I will ample opportunity to look at this when I take all the literal text out of the templates for translation purposes. :) On Fri, May 24, 2002 at 03:35:39PM +0200, Alessandro Pisani (TXM / J578) wrote: > I've just noticed there are a lot of tables created in fixed pixel size > like: > > <table border="0" width="640"> > > wouldn't be better to use percentual size instead? so we could have a > uniform look&feel despite different monitor settings.... or there is > somethings wrong in this? > > Alessandro > > -- > Alessandro "TXM" Pisani - alextxm at tin dot it - ICQ: #2209087 > > "I will carry you through, kicking and screaming, > and in the end you will thank me" > - Tyler Durden [from "Fight Club"] > > > _______________________________________________________________ > > Don't miss the 2002 Sprint PCS Application Developer's Conference > August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm > > _______________________________________________ > phpbt-dev mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpbt-dev |
|
From: Adi S. <ad...@l3...> - 2002-05-24 14:37:23
|
Hi, I added two things to phpBT. 1. saved queries are also shown on the simple query page. The saved queries are always shown, just as on the advanced query page. you can get the neccesary files here: http://www.l33tless.org/file.php?f=/code/files/show_saved_queries_on_simple_for m.zip 2. show saved queries in the home page when a user is logged in. This feature is optional and can be set via the configuration screen in the admin section. you can get the neccesary files here: http://www.l33tless.org/file.php?f=/code/files/show_saved_queries_on_home.zip BTW, I like the way phpBT is structured it's very easy to understand and simle things like this are a breeze. Regards Adi |
|
From: Alessandro P. (T. / J578) <al...@ti...> - 2002-05-24 13:37:48
|
I've just noticed there are a lot of tables created in fixed pixel size like: <table border="0" width="640"> wouldn't be better to use percentual size instead? so we could have a uniform look&feel despite different monitor settings.... or there is somethings wrong in this? Alessandro -- Alessandro "TXM" Pisani - alextxm at tin dot it - ICQ: #2209087 "I will carry you through, kicking and screaming, and in the end you will thank me" - Tyler Durden [from "Fight Club"] |
|
From: Ben C. <php...@be...> - 2002-05-24 12:48:52
|
What version of php are you using?
On Fri, May 24, 2002 at 12:41:27PM +0100, Adi Sieker wrote:
> Hi,
>
> the saved queries weren't working for me.
> I had to change the line
> 221 in query.php from:
> $savedquerystring = ereg_replace('&savedqueryname=.*(&?)', "\\1",
> $HTTP_SERVER_VARS['QUERY_STRING']);
>
> to:
> $savedquerystring = ereg_replace('&savedqueryname=.*(&?)', "\1",
> $HTTP_SERVER_VARS['QUERY_STRING']);
>
> notice the one missing \
>
> Regards
> Adi
>
> _______________________________________________________________
>
> Don't miss the 2002 Sprint PCS Application Developer's Conference
> August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm
>
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev
|
|
From: Ben C. <php...@be...> - 2002-05-24 12:48:21
|
Thanks for the heads up. I didn't see the problems with the auth isset checks, but I put the @'s in anyway. The templates have also been updated and committed to cvs. On Fri, May 24, 2002 at 11:20:11AM +0100, Adi Sieker wrote: > Hi all, > > I just installed phpBugTracker today for the first time. > Nice piece of software, just what we need. > After having found a couple of bugs in the 0.8.2 release, I went and > got the latest from CVS into a clean directory. > With the current source in CVS there are still some errors with > the switch to the wrap function. > Attached is a zip with a new auth.php, this now utilises the wrap function > as well, instead of the display function. I also added @ in front of isset on > lines 135, 141 and 146. This is will remove some php notices when you are not > logged > in and try to access the bug.php while PHP is running with error reporting set > to > E_ALL. > Also the templates error.html, badgroup.html and badperm.html were still > including > the templates header.html and footer.html. > > Regards > Adi |
|
From: Benjamin C. <bc...@us...> - 2002-05-24 12:47:36
|
Update of /cvsroot/phpbt/phpbt/inc
In directory usw-pr-cvs1:/tmp/cvs-serv8995/inc
Modified Files:
auth.php
Log Message:
Clobber warnings for auth checks
Index: auth.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/auth.php,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- auth.php 24 May 2002 12:44:35 -0000 1.16
+++ auth.php 24 May 2002 12:47:33 -0000 1.17
@@ -132,18 +132,18 @@
global $HTTP_SESSION_VARS;
// Administrators always pass
- if (isset($HTTP_SESSION_VARS[$auth_var]['Admin'])) {
+ if (@isset($HTTP_SESSION_VARS[$auth_var]['Admin'])) {
return true;
}
if (is_array($reqs)) {
foreach ($reqs as $req) {
- if (!isset($HTTP_SESSION_VARS[$auth_var][$req])) {
+ if (!@isset($HTTP_SESSION_VARS[$auth_var][$req])) {
return false;
}
}
} else {
- if (!isset($HTTP_SESSION_VARS[$auth_var][$reqs])) {
+ if (!@isset($HTTP_SESSION_VARS[$auth_var][$reqs])) {
return false;
}
}
|
|
From: Benjamin C. <bc...@us...> - 2002-05-24 12:44:38
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv8001/templates/default
Modified Files:
badgroup.html badperm.html error.html
Log Message:
Moving from header/footer to wrap
Index: badgroup.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/badgroup.html,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- badgroup.html 3 Apr 2002 00:57:50 -0000 1.2
+++ badgroup.html 24 May 2002 12:44:35 -0000 1.3
@@ -1,4 +1,3 @@
-{include file="header.html"}
<table border="0" width="640">
<tr>
<td align="center">
@@ -9,4 +8,3 @@
</td>
</tr>
</table>
-{include file="footer.html"}
Index: badperm.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/badperm.html,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- badperm.html 3 Apr 2002 00:57:50 -0000 1.4
+++ badperm.html 24 May 2002 12:44:35 -0000 1.5
@@ -1,4 +1,3 @@
-{include file="header.html"}
<table border="0" width="640">
<tr>
<td align="center">
@@ -9,4 +8,3 @@
</td>
</tr>
</table>
-{include file="footer.html"}
Index: error.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/error.html,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- error.html 3 Apr 2002 00:57:51 -0000 1.2
+++ error.html 24 May 2002 12:44:35 -0000 1.3
@@ -1,4 +1,3 @@
-{include file="header.html" page_title="Error"}
<table width="640">
<tr>
<td align="center">
@@ -13,4 +12,3 @@
</td>
</tr>
</table>
-{include file="footer.html"}
|
|
From: Benjamin C. <bc...@us...> - 2002-05-24 12:44:38
|
Update of /cvsroot/phpbt/phpbt/inc
In directory usw-pr-cvs1:/tmp/cvs-serv8001/inc
Modified Files:
auth.php
Log Message:
Moving from header/footer to wrap
Index: auth.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/auth.php,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- auth.php 29 Apr 2002 06:36:46 -0000 1.15
+++ auth.php 24 May 2002 12:44:35 -0000 1.16
@@ -166,7 +166,7 @@
function perm_invalid($actual_perms, $required_perms) {
global $t;
- $t->display('badperm.html');
+ $t->wrap('badperm.html');
}
function check_group($group) {
@@ -174,7 +174,7 @@
if (!$this->check_auth('group', $group)) {
$t->assign('group', $group);
- $t->display('badgroup.html');
+ $t->wrap('badgroup.html');
exit();
}
}
|
|
From: Adi S. <ad...@l3...> - 2002-05-24 10:42:00
|
Hi,
the saved queries weren't working for me.
I had to change the line
221 in query.php from:
$savedquerystring = ereg_replace('&savedqueryname=.*(&?)', "\\1",
$HTTP_SERVER_VARS['QUERY_STRING']);
to:
$savedquerystring = ereg_replace('&savedqueryname=.*(&?)', "\1",
$HTTP_SERVER_VARS['QUERY_STRING']);
notice the one missing \
Regards
Adi
|
2 messages has been excluded from this view by a project administrator.
