Menu
▾
▴
phpbt-dev — Developer's mailing list and cvs commits
You can subscribe to this list here.
| 2001 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(34) |
Aug
(215) |
Sep
(180) |
Oct
(135) |
Nov
(105) |
Dec
(81) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2002 |
Jan
(76) |
Feb
(22) |
Mar
(154) |
Apr
(149) |
May
(128) |
Jun
(94) |
Jul
(14) |
Aug
(24) |
Sep
(77) |
Oct
(52) |
Nov
(22) |
Dec
(6) |
| 2003 |
Jan
(4) |
Feb
(10) |
Mar
(6) |
Apr
(29) |
May
(10) |
Jun
(37) |
Jul
(39) |
Aug
(13) |
Sep
(23) |
Oct
(3) |
Nov
(7) |
Dec
(2) |
| 2004 |
Jan
|
Feb
(10) |
Mar
(4) |
Apr
|
May
(35) |
Jun
(4) |
Jul
(17) |
Aug
(6) |
Sep
(14) |
Oct
(18) |
Nov
(2) |
Dec
(14) |
| 2005 |
Jan
(9) |
Feb
(30) |
Mar
(6) |
Apr
|
May
(38) |
Jun
(23) |
Jul
(21) |
Aug
(76) |
Sep
(50) |
Oct
(51) |
Nov
(13) |
Dec
|
|
From: Adi S. <ad...@l3...> - 2002-05-24 09:20:56
|
Hi all, I just installed phpBugTracker today for the first time. Nice piece of software, just what we need. After having found a couple of bugs in the 0.8.2 release, I went and got the latest from CVS into a clean directory. With the current source in CVS there are still some errors with the switch to the wrap function. Attached is a zip with a new auth.php, this now utilises the wrap function as well, instead of the display function. I also added @ in front of isset on lines 135, 141 and 146. This is will remove some php notices when you are not logged in and try to access the bug.php while PHP is running with error reporting set to E_ALL. Also the templates error.html, badgroup.html and badperm.html were still including the templates header.html and footer.html. Regards Adi |
|
From: Ben C. <php...@be...> - 2002-05-22 12:36:06
|
I need to reread the email to make sure I'm catching everything -- it's taking me a while to catch up. On Wed, May 22, 2002 at 07:22:12AM -0000, Jirka Pech wrote: > > Words like database, table, order, etc., are sql reserved words, so it's > > not a good idea to use them for table names. > > OK, I didn't take care about empty 'table prefix'. Thank you. > > What do you think about 'module tables' we discussed last on monday? > > Jirka |
|
From: Jirka P. <fi...@us...> - 2002-05-22 07:22:21
|
> Words like database, table, order, etc., are sql reserved words, so it's > not a good idea to use them for table names. OK, I didn't take care about empty 'table prefix'. Thank you. What do you think about 'module tables' we discussed last on monday? Jirka |
|
From: Ben C. <php...@be...> - 2002-05-22 02:45:25
|
Words like database, table, order, etc., are sql reserved words, so it's not a good idea to use them for table names. On Tue, May 21, 2002 at 12:50:53PM -0000, Jirka Pech wrote: > > Update of /cvsroot/phpbt/phpbt > > In directory usw-pr-cvs1:/tmp/cvs-serv23268 > > > > Modified Files: > > config-dist.php config.php > > Log Message: > > 'Database' by itself won't work as a table name > > Oooops, I don't understand it. Please, can you explain it somehow for me? > > _______________________________________________________________ > > Don't miss the 2002 Sprint PCS Application Developer's Conference > August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm > > _______________________________________________ > phpbt-dev mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpbt-dev |
|
From: Jirka P. <fi...@us...> - 2002-05-21 13:37:03
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv10754/phpbt
Modified Files:
bug.php
Log Message:
Bug update handle for database_id and to_be_closed_in_version_id.
Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.106
retrieving revision 1.107
diff -u -r1.106 -r1.107
--- bug.php 18 May 2002 02:59:32 -0000 1.106
+++ bug.php 21 May 2002 13:37:00 -0000 1.107
@@ -150,6 +150,7 @@
'component' => TBL_COMPONENT,
'status' => TBL_STATUS,
'resolution' => TBL_RESOLUTION,
+ 'database' => TBL_DATABASE,
'severity' => TBL_SEVERITY,
'os' => TBL_OS,
'version' => TBL_VERSION
@@ -373,6 +374,7 @@
$db->query("update ".TBL_BUG." set title = ".$db->quote(stripslashes($title)).
', url = '.$db->quote(stripslashes($url)).", severity_id = $severity_id, ".
"priority = $priority, status_id = $status_id, ".
+ "database_id = $database_id, to_be_closed_in_version_id = $to_be_closed_in_version_id, ".
"resolution_id = $resolution_id, assigned_to = $assigned_to, ".
"project_id = $project_id, version_id = $version_id, ".
"component_id = $component_id, os_id = $os_id, last_modified_by = $u, ".
|
|
From: Jirka P. <fi...@us...> - 2002-05-21 13:35:12
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv9944/phpbt/templates/default
Modified Files:
bugdisplay.html
Log Message:
Added "to be closed in version" field and database field. Ben, please add permission checks and rearange the form, if necessary. What do you think about '/' between "Reported in" and "To be closed in" versions?
Index: bugdisplay.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugdisplay.html,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- bugdisplay.html 18 May 2002 03:00:50 -0000 1.31
+++ bugdisplay.html 21 May 2002 13:35:10 -0000 1.32
@@ -90,16 +90,25 @@
</tr>
<tr>
<td>
- Version:
+ {$STRING.version}:
</td>
<td>
- <select name="version_id">{build_select box=version selected=$version_id project=$project_id}</select>
+ <select name="version_id">{build_select box=version selected=$version_id project=$project_id}</select> /
+ <select name="to_be_closed_in_version_id">{build_select box=version selected=$to_be_closed_in_version_id project=$project_id}</select>
</td>
- <td>
+ <td rowspan="2">
OS:
</td>
- <td>
+ <td rowspan="2">
<select name="os_id">{build_select box=os selected=$os_id}</select>
+ </td>
+ </tr>
+ <tr>
+ <td>
+ {$STRING.database}:
+ </td>
+ <td>
+ <select name="database_id">{build_select box=database selected=$database_id}</select>
</td>
</tr>
<tr>
|
|
From: Benjamin C. <bc...@us...> - 2002-05-21 12:52:04
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory usw-pr-cvs1:/tmp/cvs-serv25446/templates/default/admin
Modified Files:
databaselist.html
Log Message:
The item count spans 4 columns rather than 3
Index: databaselist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/databaselist.html,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- databaselist.html 21 May 2002 09:53:18 -0000 1.2
+++ databaselist.html 21 May 2002 12:52:01 -0000 1.3
@@ -34,7 +34,7 @@
</tr>
{/section}
<tr>
- <td colspan="3" align="center">
+ <td colspan="4" align="center">
<br>
{$first} - {$last} of {$total}
<br>
|
|
From: Benjamin C. <bc...@us...> - 2002-05-21 12:51:06
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory usw-pr-cvs1:/tmp/cvs-serv24949/templates/default/admin
Modified Files:
database-edit.html
Log Message:
Changed the version textarea to a textbox and changed the field limits to match the database
Index: database-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/database-edit.html,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- database-edit.html 21 May 2002 09:25:47 -0000 1.1
+++ database-edit.html 21 May 2002 12:51:03 -0000 1.2
@@ -11,11 +11,11 @@
{/if}
<tr>
<td align="right" valign="top">Name:</td>
- <td><input type="text" size="20" maxlength="40" name="database_name" value="{$database_name|stripslashes|htmlspecialchars}"></td>
+ <td><input type="text" size="20" maxlength="30" name="database_name" value="{$database_name|stripslashes|htmlspecialchars}"></td>
</tr>
<tr>
<td align="right" valign="top">Version:</td>
- <td><textarea name="database_version" cols=20 rows=5 wrap=virtual>{$database_version|stripslashes|htmlspecialchars}</textarea></td>
+ <td><input type="text" size="10" maxlength="10" name="database_version" value="{$database_version|stripslashes|htmlspecialchars}"></td>
</tr>
<tr>
<td align="right" valign="top">Sort Order:</td>
|
|
From: Jirka P. <fi...@us...> - 2002-05-21 12:51:05
|
> Update of /cvsroot/phpbt/phpbt > In directory usw-pr-cvs1:/tmp/cvs-serv23268 > > Modified Files: > =09config-dist.php config.php > Log Message: > 'Database' by itself won't work as a table name Oooops, I don't understand it. Please, can you explain it somehow for me? |
|
From: Benjamin C. <bc...@us...> - 2002-05-21 12:45:02
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv23268
Modified Files:
config-dist.php config.php
Log Message:
'Database' by itself won't work as a table name
Index: config-dist.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/config-dist.php,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- config-dist.php 17 May 2002 15:23:47 -0000 1.16
+++ config-dist.php 21 May 2002 12:44:58 -0000 1.17
@@ -63,7 +63,7 @@
define ('TBL_USER_PREF', TBL_PREFIX.'user_pref');
define ('TBL_VERSION', TBL_PREFIX.'version');
define ('TBL_PROJECT_GROUP', TBL_PREFIX.'project_group');
-define ('TBL_DATABASE', TBL_PREFIX.'database');
+define ('TBL_DATABASE', TBL_PREFIX.'database_server');
define ('ONEDAY', 86400);
Index: config.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/config.php,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -r1.30 -r1.31
--- config.php 17 May 2002 15:23:47 -0000 1.30
+++ config.php 21 May 2002 12:44:58 -0000 1.31
@@ -65,7 +65,7 @@
define ('TBL_USER_PREF', TBL_PREFIX.'user_pref');
define ('TBL_VERSION', TBL_PREFIX.'version');
define ('TBL_PROJECT_GROUP', TBL_PREFIX.'project_group');
-define ('TBL_DATABASE', TBL_PREFIX.'database');
+define ('TBL_DATABASE', TBL_PREFIX.'database_server');
define ('ONEDAY', 86400);
|
|
From: Jirka P. <fi...@us...> - 2002-05-21 11:20:21
|
Update of /cvsroot/phpbt/phpbt/inc
In directory usw-pr-cvs1:/tmp/cvs-serv18055/phpbt/inc
Modified Files:
functions.php
Log Message:
Modified build_select to handle database tracking.
Index: functions.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- functions.php 19 May 2002 12:24:42 -0000 1.28
+++ functions.php 21 May 2002 11:20:17 -0000 1.29
@@ -58,17 +58,19 @@
'status' => TBL_STATUS,
'resolution' => TBL_RESOLUTION,
'severity' => TBL_SEVERITY,
- 'version' => TBL_VERSION
+ 'version' => TBL_VERSION,
+ 'database' => TBL_DATABASE,
);
$text = '';
if (isset($cfgDatabase[$box])) {
$querystart = "select {$box}_id, {$box}_name from $cfgDatabase[$box]";
+ $querymid = ' where sort_order > 0 order by sort_order';
$queries = array(
'group' => $querystart.' where group_name <> \'User\' order by group_name',
- 'severity' => $querystart.' where sort_order > 0 order by sort_order',
- 'status' => $querystart.' where sort_order > 0 order by sort_order',
- 'resolution' => $querystart.' where sort_order > 0 order by sort_order',
+ 'severity' => $querystart.$querymid,
+ 'status' => $querystart.$querymid,
+ 'resolution' => $querystart.$querymid,
'project' => $perm->have_perm('Admin')
? $querystart." where ".
($selected ? "(active > 0 or project_id in ($selected))" : 'active > 0').
@@ -78,7 +80,8 @@
($selected ? " (active > 0 or project_id in ($selected))" : 'active > 0').
" order by {$box}_name",
'component' => $querystart." where project_id = $project and active = 1 order by {$box}_name",
- 'version' => $querystart." where project_id = $project and active = 1 order by {$box}_id desc"
+ 'version' => $querystart." where project_id = $project and active = 1 order by {$box}_id desc",
+ 'database' => "select {$box}_id, {$box}_name, {$box}_version from $cfgDatabase[$box]".$querymid
);
}
@@ -120,6 +123,15 @@
$row[$box.'_id']."\"$sel>".$row[$box.'_name'].'</option>';
}
break;
+ case 'database' :
+ $rs = $db->query($queries[$box]);
+ while ($rs->fetchInto($row)) {
+ if ($selected == $row[$box.'_id'] and $selected != '') $sel = ' selected';
+ else $sel = '';
+ $text .= '<option value="'.
+ $row[$box.'_id'].'"'.$sel.'>'.$row[$box.'_name'].' '.$row[$box.'_version'].'</option>';
+ }
+ break;
case 'os' :
$rs = $db->query("select {$box}_id, {$box}_name, regex from ".TBL_OS." where sort_order > 0 order by sort_order");
while ($rs->fetchInto($row)) {
|
|
From: Jirka P. <fi...@us...> - 2002-05-21 10:05:05
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory usw-pr-cvs1:/tmp/cvs-serv26360/phpbt/templates/default/admin
Modified Files:
wrap-popup.html wrap.html
Log Message:
Added database tracking administration and cleaned suspect meta from the end.
Index: wrap-popup.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/wrap-popup.html,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- wrap-popup.html 18 May 2002 03:01:22 -0000 1.1
+++ wrap-popup.html 21 May 2002 10:05:01 -0000 1.2
@@ -15,4 +15,3 @@
</table>
</body>
</html>
-<head><meta HTTP-EQUIV="PRAGMA" CONTENT="NO-CACHE"></head>
Index: wrap.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/wrap.html,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- wrap.html 18 May 2002 03:01:22 -0000 1.11
+++ wrap.html 21 May 2002 10:05:01 -0000 1.12
@@ -46,6 +46,9 @@
<div class="navbox" onMouseOver="this.className='navboxselected'" onMouseOut="this.className='navbox'" onClick="document.location.href='os.php'">
<a href="os.php" class="sidenavlink">OSes</a>
</div>
+ <div class="navbox" onMouseOver="this.className='navboxselected'" onMouseOut="this.className='navbox'" onClick="document.location.href='database.php'">
+ <a href="database.php" class="sidenavlink">{$STRING.databases}</a>
+ </div>
<div class="navbox" onMouseOver="this.className='navboxselected'" onMouseOut="this.className='navbox'" onClick="document.location.href='../docs/html/userguide.html'">
<a href="../docs/html/userguide.html" class="sidenavlink">Read Documentation</a>
</div>
@@ -93,4 +96,3 @@
</table>
</body>
</html>
-<head><meta HTTP-EQUIV="PRAGMA" CONTENT="NO-CACHE"></head>
|
|
From: Jirka P. <fi...@us...> - 2002-05-21 09:53:22
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory usw-pr-cvs1:/tmp/cvs-serv23792/phpbt/templates/default/admin
Modified Files:
databaselist.html
Log Message:
Only updated $STRING's key.
Index: databaselist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/databaselist.html,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- databaselist.html 21 May 2002 09:25:47 -0000 1.1
+++ databaselist.html 21 May 2002 09:53:18 -0000 1.2
@@ -28,7 +28,7 @@
<td align="center">{$databases[database].sort_order}</td>
<td align="center">
{if not $databases[database].bug_count}
- <a href="{$SCRIPT_NAME}?op=del&database_id={$databases[database].database_id}" onClick="return confirm('{$STRING.suredelete} {$STRING.database}?')">{$STRING.delete}</a>
+ <a href="{$SCRIPT_NAME}?op=del&database_id={$databases[database].database_id}" onClick="return confirm('{$STRING.suredeletedb}')">{$STRING.delete}</a>
{/if}
</td>
</tr>
|
|
From: Jirka P. <fi...@us...> - 2002-05-21 09:50:22
|
Update of /cvsroot/phpbt/phpbt/languages In directory usw-pr-cvs1:/tmp/cvs-serv22940/phpbt/languages Modified Files: cz_iso-8859-2.php cz.php en.php Log Message: Please somebody update other languages. Index: cz_iso-8859-2.php =================================================================== RCS file: /cvsroot/phpbt/phpbt/languages/cz_iso-8859-2.php,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- cz_iso-8859-2.php 19 May 2002 12:06:56 -0000 1.5 +++ cz_iso-8859-2.php 21 May 2002 09:50:19 -0000 1.6 @@ -77,6 +77,15 @@ 'image_path_not_writeable' => 'Webprocess nemù¾e zapisovat do podadresáøe "jpgimages", pøehledový obrázek nemù¾e být vygenerován.', 'password_changed' => 'Va¹e heslo bylo zmìnìno', 'prefs_changed' => 'Va¹e nastavení byla zmìnìna', + 'databaselist' => 'Seznam databází', + 'database' => 'Databáze', + 'databases' => 'Databáze', + 'name' => 'Název', + 'description' => 'Popis', + 'sortorder' => 'Poøadí tøídìní', + 'suredeletedb' => 'Opravdu chcete odstranit tuto databázi?', + 'delete' => 'Odstranit', + 'version' => 'Verze' ); // Page titles @@ -121,5 +130,8 @@ 'editgroup' => 'Zmìnit Skupinu', 'addgroup' => 'Pøidat Skupinu', 'configuration' => 'Nastavení', + 'adddatabase' => 'Pøidat databázi', + 'editdatabase' => 'Upravit databázi', + 'database' => 'Databáze' ); ?> Index: cz.php =================================================================== RCS file: /cvsroot/phpbt/phpbt/languages/cz.php,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- cz.php 19 May 2002 12:06:56 -0000 1.8 +++ cz.php 21 May 2002 09:50:19 -0000 1.9 @@ -77,6 +77,15 @@ 'image_path_not_writeable' => 'Webprocess nemùe zapisovat do podadresáøe "jpgimages", pøehledový obrázek nemùe být vygenerován.', 'password_changed' => 'Vae heslo bylo zmìnìno', 'prefs_changed' => 'Vae nastavení byla zmìnìna', + 'databaselist' => 'Seznam databází', + 'database' => 'Databáze', + 'databases' => 'Databáze', + 'name' => 'Název', + 'description' => 'Popis', + 'sortorder' => 'Poøadí tøídìní', + 'suredeletedb' => 'Opravdu chcete odstranit tuto databázi?', + 'delete' => 'Odstranit', + 'version' => 'Verze' ); // Page titles @@ -121,5 +130,8 @@ 'editgroup' => 'Zmìnit Skupinu', 'addgroup' => 'Pøidat Skupinu', 'configuration' => 'Nastavení', + 'adddatabase' => 'Pøidat databázi', + 'editdatabase' => 'Upravit databázi', + 'database' => 'Databáze' ); ?> Index: en.php =================================================================== RCS file: /cvsroot/phpbt/phpbt/languages/en.php,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- en.php 18 May 2002 15:40:19 -0000 1.17 +++ en.php 21 May 2002 09:50:19 -0000 1.18 @@ -77,6 +77,15 @@ 'image_path_not_writeable' => 'The subdirectory "jpgimages" is not writeable by the web process, so the summary image can not be rendered', 'password_changed' => 'Your password has been changed', 'prefs_changed' => 'Your preferences have been changed', + 'databaselist' => 'Database list', + 'database' => 'Database', + 'databases' => 'Databases', + 'name' => 'Name', + 'description' => 'Description', + 'sortorder' => 'Sort order', + 'suredeletedb' => 'Are you sure to delete this database?', + 'delete' => 'Delete', + 'version' => 'Version' ); // Page titles @@ -121,6 +130,9 @@ 'editgroup' => 'Edit Group', 'addgroup' => 'Add Group', 'configuration' => 'Configuration', + 'adddatabase' => 'Add Database', + 'editdatabase' => 'Edit Database', + 'database' => 'Databases' ); ?> |
|
From: Jirka P. <fi...@us...> - 2002-05-21 09:25:49
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory usw-pr-cvs1:/tmp/cvs-serv16438/phpbt/templates/default/admin
Added Files:
databaselist.html database-edit.html
Log Message:
First step in database tracking templates. Language files (en.php, cz.php, cz_iso-8859-2.php) with proper values will follow. Please check it all.
--- NEW FILE: databaselist.html ---
<script language="JavaScript">
<!--
var me = '{$SCRIPT_NAME}';
{literal}
function popupDatabase(id) {
window.open(me + '?op=edit&use_js=1&database_id='+id, 'ewin', 'dependent=yes,width=350,height=300,scrollbars=1');
}
{/literal}
// -->
</script>
<table border="0" width="100%">
<tr>
<td valign="top">
<b> {$STRING.databaselist'}</b> - <a href="{$SCRIPT_NAME}?op=edit&database_id=0" onClick="popupDatabase(0); return false;">{$STRING.addnew} {$STRING.database}</a>
<hr size="1">
<table border="0" cellpadding="2" cellspacing="1" width="100%">
<tr>
<th class="{$headers.name.class}"><a href="{$headers.name.url}">{$STRING.name}</a></th>
<th class="{$headers.version.class}"><a href="{$headers.version.url}">{$STRING.version}</a></th>
<th class="{$headers.sortorder.class}"><a href="{$headers.sortorder.url}">{$STRING.sortorder}</a></th>
<th>Delete</th>
</tr>
{section name=database loop=$databases}
<tr{if $smarty.section.database.iteration is even} class="alt"{/if}>
<td><a href="{$SCRIPT_NAME}?op=edit&database_id={$databases[database].database_id}" onClick="popupDatabase({$databases[database].database_id}); return false;">{$databases[database].database_name|stripslashes}</a></td>
<td> {$databases[database].database_version}</td>
<td align="center">{$databases[database].sort_order}</td>
<td align="center">
{if not $databases[database].bug_count}
<a href="{$SCRIPT_NAME}?op=del&database_id={$databases[database].database_id}" onClick="return confirm('{$STRING.suredelete} {$STRING.database}?')">{$STRING.delete}</a>
{/if}
</td>
</tr>
{/section}
<tr>
<td colspan="3" align="center">
<br>
{$first} - {$last} of {$total}
<br>
{if $pages ne "1"}[ {$pages} ]{/if}
<br>
</td>
</tr>
</table>
<br>
</td>
</tr>
</table>
--- NEW FILE: database-edit.html ---
<b>{$page_title} </b>
<hr size="1">
<form action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="database_id" value="{$database_id}">
<input type="hidden" name="use_js" value="{$smarty.request.use_js}">
<table border='0'>
{if $error}
<tr>
<td colspan="2" class="error">{$error}</td>
</tr>
{/if}
<tr>
<td align="right" valign="top">Name:</td>
<td><input type="text" size="20" maxlength="40" name="database_name" value="{$database_name|stripslashes|htmlspecialchars}"></td>
</tr>
<tr>
<td align="right" valign="top">Version:</td>
<td><textarea name="database_version" cols=20 rows=5 wrap=virtual>{$database_version|stripslashes|htmlspecialchars}</textarea></td>
</tr>
<tr>
<td align="right" valign="top">Sort Order:</td>
<td><input type="text" size="3" maxlength="3" name="sort_order" value="{$sort_order}"></td>
</tr>
</table>
<br>
<input type='submit' name='submit' value='Submit'>
</form>
|
|
From: Jirka P. <fi...@us...> - 2002-05-21 08:57:21
|
Update of /cvsroot/phpbt/phpbt/admin
In directory usw-pr-cvs1:/tmp/cvs-serv7397/phpbt/admin
Added Files:
database.php
Log Message:
First steps in "database tracking" administration. Templates will follow.
--- NEW FILE: database.php ---
<?php
// database.php - Interface to the database table
// ------------------------------------------------------------------------
// Copyright (c) 2001, 2002 The phpBugTracker Group
// ------------------------------------------------------------------------
// This file is part of phpBugTracker
//
// phpBugTracker is free software; you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation; either version 2 of the License, or
// (at your option) any later version.
//
// phpBugTracker is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with phpBugTracker; if not, write to the Free Software Foundation,
// Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
// ------------------------------------------------------------------------
// $Id: database.php,v 1.1 2002/05/21 08:57:15 firma Exp $
chdir('..');
define('TEMPLATE_PATH', 'admin');
include 'include.php';
function del_item($databaseid = 0) {
global $db, $me;
if ($databaseid) {
// Make sure we are going after a valid record
$itemexists = $db->getOne('select count(*) from '.TBL_DATABASE.
" where database_id = $databaseid");
// Are there any bugs tied to this one?
$bugcount = $db->getOne('select count(*) from '.TBL_BUG.
" where database_id = $databaseid");
if ($itemexists and !$bugcount) {
$db->query('delete from '.TBL_DATABASE." where database_id = $databaseid");
}
}
header("Location: $me?");
}
function do_form($databaseid = 0) {
global $db, $me, $_pv, $STRING, $t;
extract($_pv);
$error = '';
// Validation
if (!$database_name = trim($database_name))
$error = $STRING['givename'];
elseif (!$database_desc = trim($database_version))
$error = $STRING['giveversion'];
if ($error) { show_form($databaseid, $error); return; }
if (!$databaseid) {
$db->query("insert into ".TBL_DATABASE.
" (database_id, database_name, database_version, sort_order)
values (".$db->nextId(TBL_DATABASE).', '.
$db->quote(stripslashes($database_name)).', '.
$db->quote(stripslashes($database_desc)).", $sort_order)");
} else {
$db->query("update ".TBL_DATABASE.
" set database_name = ".$db->quote(stripslashes($database_name)).
', database_version = '.$db->quote(stripslashes($database_version)).
", sort_order = $sort_order where database_id = $database_id");
}
if ($use_js) {
$t->display('admin/edit-submit.html');
} else {
header("Location: $me?");
}
}
function show_form($databaseid = 0, $error = '') {
global $db, $me, $t, $_pv, $STRING;
if ($databaseid && !$error) {
$t->assign($db->getRow("select * from ".TBL_DATABASE.
" where database_id = '$databaseid'"));
} else {
$t->assign($_pv);
}
$t->assign('error', $error);
$t->wrap('admin/database-edit.html', ($databaseid ? 'editdatabase' : 'adddatabase'));
}
function list_items($databaseid = 0, $error = '') {
global $me, $db, $t, $_gv, $STRING, $TITLE, $QUERY;
if (empty($_gv['order'])) {
$order = 'sort_order';
$sort = 'asc';
} else {
$order = $_gv['order'];
$sort = $_gv['sort'];
}
$page = isset($_gv['page']) ? $_gv['page'] : 0;
$nr = $db->getOne("select count(*) from ".TBL_DATABASE);
list($selrange, $llimit) = multipages($nr, $page, "order=$order&sort=$sort");
$t->assign('databases', $db->getAll($db->modifyLimitQuery(
sprintf($QUERY['admin-list-databases'], $order, $sort), $llimit, $selrange)));
$headers = array(
'databaseid' => 'database_id',
'name' => 'database_name',
'version' => 'database_version',
'sortorder' => 'sort_order');
sorting_headers($me, $headers, $order, $sort);
$t->wrap('admin/databaselist.html', 'database');
}
$perm->check('Admin');
if (isset($_gv['op'])) switch($_gv['op']) {
case 'add' : list_items(); break;
case 'edit' : show_form($_gv['database_id']); break;
case 'del' : del_item($_gv['database_id']); break;
} elseif(isset($_pv['submit'])) {
do_form($_pv['database_id']);
} else list_items();
?>
|
|
From: Jirka P. <fi...@us...> - 2002-05-20 07:14:33
|
> This sounds like a great start to a good idea. It would definitely be > nice to enable the admin to choose which options will be used (and yes, > by component makes sense to me -- especially when considering large > projects/products). The only thing I didn't understand clearly from > your email was if there was a way to avoid having to add columns to the > bug table for each link (database_id, os_id, etc.). Did I just miss it, > or do we need to come up with a way? There is a way to avoid having to add columns. It's described in an e-mail = you are responding to. I tryied to explain, what I'm prepared to do (create= some tables and so) and I've requested comments and ideas before I will st= art. John wrote it's a good idea, but with lot of template work. I know it and I= asked if you are ready for this work, because I'm not 100% able to underst= and the smarty templates logic now. I will need your helping hand when I wi= ll start. And I will never start before everything will be 100% understood. Is it clearer now? Jirka |
|
From: Jirka P. <fi...@us...> - 2002-05-20 07:04:48
|
> The templates were moved from admin/templates to templates/default/admin > a while ago. The scripts are looking in the correct location (the > latter one) for the templates so there's not a problem there. Sorry. I did it again and it works fine. |
|
From: Jirka P. <fi...@us...> - 2002-05-20 06:58:04
|
> Do we really need to track the database version in a separate field from > the database name, or can we lump all that into a single text field? > Are there advantages/disadvantages to either approach? Maybe it seems more readable for me and there will be smaller indexes and w= ith use of Oracle DB, there can be a bitmap index on name, which is incredi= bly fast compared to B-tree index. But there is no singificant disadvantage= , when using single field for name and version. Jirka |
|
From: Ben C. <php...@be...> - 2002-05-19 23:53:53
|
Do we really need to track the database version in a separate field from the database name, or can we lump all that into a single text field? Are there advantages/disadvantages to either approach? |
|
From: Ben C. <php...@be...> - 2002-05-19 23:51:55
|
This sounds like a great start to a good idea. It would definitely be nice to enable the admin to choose which options will be used (and yes, by component makes sense to me -- especially when considering large projects/products). The only thing I didn't understand clearly from your email was if there was a way to avoid having to add columns to the bug table for each link (database_id, os_id, etc.). Did I just miss it, or do we need to come up with a way? On Sun, May 19, 2002 at 02:39:29PM -0000, Jirka Pech wrote: > I want to add table for modules, where will stay project_id as primary key and columns for use_oses, use_databases, use_environments. These columns will stay as options when creating a project. [snip] |
|
From: Ben C. <php...@be...> - 2002-05-19 23:22:34
|
The templates were moved from admin/templates to templates/default/admin a while ago. The scripts are looking in the correct location (the latter one) for the templates so there's not a problem there. On Sun, May 19, 2002 at 12:12:54PM -0000, Jirka Pech wrote: > Ben, what's new with admin templates? I installed phpbt from a scratch to test everything and I see that place for admin templates changed in scripts but not in CVS. They are not under admin/templates (which is the place scripts looking at), but under templates/default/admin. Will you move them to right place in CVS or is it a mistake or something? I'm a bit confused by it. > > Jirka > > _______________________________________________________________ > Hundreds of nodes, one monster rendering program. > Now that's a super model! Visit http://clustering.foundries.sf.net/ > > _______________________________________________ > phpbt-dev mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpbt-dev |
|
From: Jirka P. <fi...@us...> - 2002-05-19 17:03:17
|
> The new option is fine for me, we just need to remember to actually > check for it when sending mail. :) I did not changed bug.php, but added check to function itself. Now, nobody = needs to care about the option, OK? Jirka |
|
From: Jirka P. <fi...@us...> - 2002-05-19 16:59:19
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv32165/phpbt
Modified Files:
include.php newaccount.php
Log Message:
Wrapped to qp_mail.
Index: include.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/include.php,v
retrieving revision 1.117
retrieving revision 1.118
diff -u -r1.117 -r1.118
--- include.php 18 May 2002 02:59:32 -0000 1.117
+++ include.php 19 May 2002 16:59:16 -0000 1.118
@@ -172,8 +172,8 @@
$mpassword = md5($password);
$db->query("update ".TBL_AUTH_USER." set password = '$mpassword' where login = '$username'");
}
- mail($email, $STRING['newacctsubject'], sprintf($STRING['newacctmessage'],
- $password), sprintf("From: %s\nContent-Type: text/plain; charset=%s\nContent-Transfer-Encoding: 8bit\n",ADMIN_EMAIL, $STRING['lang_charset']));
+ qp_mail($email, $STRING['newacctsubject'], sprintf($STRING['newacctmessage'], $password),
+ sprintf("From: %s",ADMIN_EMAIL));
$t->assign('loginerror',
'<div class="result">Your password has been emailed to you</div>');
$emailsuccess = true;
Index: newaccount.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/newaccount.php,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- newaccount.php 18 May 2002 02:59:32 -0000 1.31
+++ newaccount.php 19 May 2002 16:59:16 -0000 1.32
@@ -70,8 +70,8 @@
" where group_name = 'User'");
$db->query("insert into ".TBL_USER_PREF." (user_id) values ($user_id)");
- mail($_pv['email'], $STRING['newacctsubject'], sprintf($STRING['newacctmessage'],
- $password), sprintf("From: %s\nContent-Type: text/plain; charset=%s\nContent-Transfer-Encoding: 8bit\n",ADMIN_EMAIL, $STRING['lang_charset']));
+ qp_mail($_pv['email'], $STRING['newacctsubject'], sprintf($STRING['newacctmessage'], $password),
+ sprintf("From: %s",ADMIN_EMAIL));
$t->wrap('newaccountsuccess.html', 'accountcreated');
}
|
|
From: Jirka P. <fi...@us...> - 2002-05-19 16:15:52
|
> I've been thinking the same about adding the user selection of > templates - adding a column for each item is 'quick' to develop but not > as flexible as the 'row' method that I think you are talking of. Yes, that's what I'm talking about. I don't like 'Microsoft like' 'easy to = develop but hard to work with' solutions. > The point about not having to take the db off line is a good one - > adding a row to an existing table is really easy because you are simply > manipulating data in the table whilst adding a column to an existing > table is slightly more 'risky' as you're altering the structure. > I can't see there's much difference for a new installation, but where an > existing install is being upgraded the row 'method' has to be better... Of course. And next thing, I haven't talked about yet is scalability. When = we will use 'row' method we can scale it much easier (think about e.g. inde= xes) and faster. > From the work I've been doing on the user-based template selection, the > 'row' method requires significantly more coding & logic than the > 'column' method but once that's done I think it's a more elegant > solution. Mhmm, this is the worst part of it. I can't promise I will be 100% able to = do all template coding, because it's (I don't know why) hard for me to unde= rstand the logic. It seems to me, that there are same things on different p= laces and sometimes one thing is duplicated in another script. > Hey, no need to apologise... Your English is far far better than my > Czech.... (or any other European language other than English) Czech is much more complicated. Be happy you have not to learn it. For example (this is not as 'off topic' as it looks) we say "Odstranit data= b=E1ze" for "Delete databases" and "Seznam datab=E1z=ED" for "Database list= ". English differs to czech in flexibility of the words. English words are = not inflectable, but ours are (as you can see from my example). Czech localization is often the thing which really complicates the work, be= cause we have 7 different cases for singular and another 7 for plural, whil= e english has only two (one for singular and one for plural). And of course= we have not one, but instantly 7+ different binary codepages for only one = language (I'm really glad that only two of them are frequently used, but I = will be more glad when the mainstream will switch to unicode). - I want to read Ben's comments before I will start, John, but tell me if you= are able to help with tepmlates. Jirka P.S.: There is no need to list me in CC when sending reply to dev-list, I'm= already a subscriber. |
2 messages has been excluded from this view by a project administrator.
