phpbt-dev — Developer's mailing list and cvs commits

[phpBT-dev] CVS: phpbt/admin configure.php,1.8,1.9 group.php,1.9,1.10 os.php,1.26,1.27 project.php,1.41,1.42 resolution.php,1.28,1.29 severity.php,1.23,1.24 status.php,1.27,1.28 user.php,1.48,1.49

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt/admin
In directory usw-pr-cvs1:/tmp/cvs-serv28289

Modified Files:
	configure.php group.php os.php project.php resolution.php 
	severity.php status.php user.php 
Log Message:
Moving back to wrap.html from header/footer.html

Index: configure.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/configure.php,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- configure.php	9 Apr 2002 20:44:52 -0000	1.8
+++ configure.php	18 May 2002 03:00:00 -0000	1.9
@@ -40,7 +40,7 @@
 } 
 
 $t->assign('vars',  $db->getAll('select * from '.TBL_CONFIGURATION));
-$t->display('admin/configure.html');
+$t->wrap('admin/configure.html', 'configuration');
 
 ?>
 

Index: group.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/group.php,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- group.php	9 Apr 2002 20:44:52 -0000	1.9
+++ group.php	18 May 2002 03:00:00 -0000	1.10
@@ -76,7 +76,7 @@
 		$t->assign($_pv);
 	}
 	$t->assign('error', $error);
-	$t->display('admin/group-edit.html');
+	$t->wrap('admin/group-edit.html', ($groupid ? 'editgroup' : 'addgroup'));
 }
 
 
@@ -107,7 +107,7 @@
 
 	sorting_headers($me, $headers, $order, $sort, "page=$page");
 
-	$t->display('admin/grouplist.html');
+	$t->wrap('admin/grouplist.html', 'group');
 }
 
 $perm->check('Admin');

Index: os.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/os.php,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- os.php	9 Apr 2002 20:44:52 -0000	1.26
+++ os.php	18 May 2002 03:00:00 -0000	1.27
@@ -78,7 +78,7 @@
 		$t->assign($_pv);
 	}
 	$t->assign('error', $error);
-	$t->display('admin/os-edit.html');
+	$t->wrap('admin/os-edit.html', ($osid ? 'editos' : 'addos'));
 }
 
 
@@ -110,7 +110,7 @@
 
 	sorting_headers($me, $headers, $order, $sort, "page=$page");
 
-	$t->display('admin/oslist.html');
+	$t->wrap('admin/oslist.html', 'os');
 }
 
 $perm->check('Admin');

Index: project.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/project.php,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -r1.41 -r1.42
--- project.php	13 Apr 2002 14:51:57 -0000	1.41
+++ project.php	18 May 2002 03:00:00 -0000	1.42
@@ -82,7 +82,7 @@
 		}
 	}
 	$t->assign('error', $error);
-	$t->display('admin/version-edit.html');
+	$t->wrap('admin/version-edit.html', ($versionid ? 'editversion' : 'addversion'));
 }
 
 function del_component($componentid, $projectid) {
@@ -146,7 +146,7 @@
 		}
 	}
 	$t->assign('error', $error);
-	$t->display('admin/component-edit.html');
+	$t->wrap('admin/component-edit.html', ($componentid ? 'editcomponent' : 'addcomponent'));
 }
 
 function save_project($projectid = 0) {
@@ -255,14 +255,14 @@
 				$projectid))
 			));
 
-		$t->display('admin/project-edit.html');
+		$t->wrap('admin/project-edit.html', 'editproject');
   } else {
 		if (!empty($_pv)) {
 		    $t->assign($_pv);
 		} else {
 		    $t->assign('active', 1);
 		}
-		$t->display('admin/project-add.html');
+		$t->wrap('admin/project-add.html', 'addproject');
   }
 	
 }
@@ -292,7 +292,7 @@
 
   sorting_headers($me, $headers, $order, $sort);
 	
-	$t->display('admin/projectlist.html');
+	$t->wrap('admin/projectlist.html', 'project');
 }
 
 $perm->check('Admin');

Index: resolution.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/resolution.php,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- resolution.php	9 Apr 2002 20:44:52 -0000	1.28
+++ resolution.php	18 May 2002 03:00:00 -0000	1.29
@@ -85,7 +85,7 @@
  		$t->assign($_pv);
 	}
 	$t->assign('error', $error);
-	$t->display('admin/resolution-edit.html');
+	$t->wrap('admin/resolution-edit.html', ($resolutionid ? 'editresolution' : 'addresolution'));
 }
 
 
@@ -117,7 +117,7 @@
 
 	sorting_headers($me, $headers, $order, $sort, "page=$page");
 
-	$t->display('admin/resolutionlist.html');
+	$t->wrap('admin/resolutionlist.html', 'resolution');
 }
 
 $perm->check('Admin');

Index: severity.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/severity.php,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- severity.php	9 Apr 2002 20:44:52 -0000	1.23
+++ severity.php	18 May 2002 03:00:00 -0000	1.24
@@ -86,7 +86,7 @@
  		$t->assign($_pv);
 	}
 	$t->assign('error', $error);
-	$t->display('admin/severity-edit.html');
+	$t->wrap('admin/severity-edit.html', ($severityid ? 'editseverity' : 'addseverity'));
 }
 
 
@@ -120,7 +120,7 @@
 
 	sorting_headers($me, $headers, $order, $sort);
 
-	$t->display('admin/severitylist.html');
+	$t->wrap('admin/severitylist.html', 'severity');
 }
 
 $perm->check('Admin');

Index: status.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/status.php,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -r1.27 -r1.28
--- status.php	9 Apr 2002 20:44:52 -0000	1.27
+++ status.php	18 May 2002 03:00:00 -0000	1.28
@@ -85,7 +85,7 @@
  		$t->assign($_pv);
 	}
 	$t->assign('error', $error);
-	$t->display('admin/status-edit.html');
+	$t->wrap('admin/status-edit.html', ($statusid ? 'editstatus' : 'addstatus'));
 }
 
 
@@ -117,7 +117,7 @@
 
 	sorting_headers($me, $headers, $order, $sort);
 
-	$t->display('admin/statuslist.html');
+	$t->wrap('admin/statuslist.html', 'status');
 }
 
 $perm->check('Admin');

Index: user.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/admin/user.php,v
retrieving revision 1.48
retrieving revision 1.49
diff -u -r1.48 -r1.49
--- user.php	12 Apr 2002 12:01:22 -0000	1.48
+++ user.php	18 May 2002 03:00:00 -0000	1.49
@@ -169,7 +169,7 @@
 	// The number of admins in the system
 	$t->assign('numadmins', $db->getOne('select count(*) from '.TBL_USER_GROUP.
 		' where group_id = 1'));
-	$t->display('admin/user-edit.html');
+	$t->wrap('admin/user-edit.html', ($userid ? 'edituser' : 'adduser'));
 }
 
 function list_items($userid = 0, $error = '') {
@@ -214,7 +214,7 @@
 	sorting_headers($me, $headers, $order, $sort, "page=$page&filter=$user_filter");
 
 	$t->assign('filter', $user_filter);
-	$t->display('admin/userlist.html');
+	$t->wrap('admin/userlist.html', 'user');
 }
 
 $perm->check('Admin');

[phpBT-dev] CVS: phpbt attachment.php,1.18,1.19 bug.php,1.105,1.106 include.php,1.116,1.117 index.php,1.31,1.32 newaccount.php,1.30,1.31 query.php,1.72,1.73 report.php,1.25,1.26 user.php,1.25,1.26

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv28161

Modified Files:
	attachment.php bug.php include.php index.php newaccount.php 
	query.php report.php user.php 
Log Message:
Moving back to wrap.html from header/footer.html

Index: attachment.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/attachment.php,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- attachment.php	11 Apr 2002 15:49:58 -0000	1.18
+++ attachment.php	18 May 2002 02:59:32 -0000	1.19
@@ -153,7 +153,7 @@
 			? number_format(ini_get('upload_max_filesize'))
 			: number_format(ATTACHMENT_MAX_SIZE)
 		));
-	$t->display('bugattachmentform.html');
+	$t->wrap('bugattachmentform.html', 'addattachment');
 }		
 
 if (isset($_gv['del'])) {

Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.105
retrieving revision 1.106
diff -u -r1.105 -r1.106
--- bug.php	16 May 2002 11:01:02 -0000	1.105
+++ bug.php	18 May 2002 02:59:32 -0000	1.106
@@ -33,7 +33,7 @@
 		'from '.TBL_AUTH_USER.' u, '.TBL_BUG_VOTE." v ".
 		"where u.user_id = v.user_id and bug_id = $bug_id ".
 		'order by v.created_date'));
-	$t->display('bugvotes.html');
+	$t->wrap('bugvotes.html', 'bugvotes');
 }
 
 ///
@@ -113,7 +113,7 @@
   }
 
   $t->assign('history', $db->getAll(sprintf($QUERY['bug-history'], $bugid)));
-  $t->display('bughistory.html');
+  $t->wrap('bughistory.html', 'bughistory');
 }
 
 ///
@@ -278,10 +278,10 @@
 
         if (($v == 'http://') || ($v == 'https://')) {
           $v = '';
-	} elseif (($v) && (strtolower(substr($v,0,7)) != 'http://') && (strtolower(substr($v,0,8)) != 'https://') && (strtolower(substr($v,0,6)) != 'ftp://')) {
-	  $v = 'http://'.$v;
-	}
-	$url = $v;
+        } elseif (($v) && (strtolower(substr($v,0,7)) != 'http://') && (strtolower(substr($v,0,8)) != 'https://') && (strtolower(substr($v,0,6)) != 'ftp://')) {
+          $v = 'http://'.$v;
+        }
+        $url = $v;
       }
 						
       if (isset($buginfo[$k]) && stripslashes($buginfo[$k]) != stripslashes($v)) {
@@ -470,7 +470,7 @@
 			'projectname' => $projectname
 			));
   }
-  $t->display('bugform.html');
+  $t->wrap('bugform.html', 'enterbug');
 }
 
 function show_bug_printable($bugid) {
@@ -496,7 +496,7 @@
     .' from '.TBL_COMMENT.' c, '.TBL_AUTH_USER
     ." where bug_id = $bugid and c.created_by = user_id order by c.created_date"));
 	
-	$t->display('bugdisplay-printable.html');
+	$t->wrap('bugdisplay-printable.html', 'viewbug');
 }
 
 ///
@@ -587,7 +587,7 @@
     	." where bug_id = $bugid and c.created_by = user_id order by c.created_date")
 		));
 	
-	$t->display('bugdisplay.html');
+	$t->wrap('bugdisplay.html', 'viewbug');
 }
 
 function show_projects() {
@@ -616,7 +616,7 @@
       break;
     default :
 			$t->assign('projects', $projects);
-			$t->display('projectlist.html');
+			$t->wrap('projectlist.html', 'enterbug');
   }
 }
 

Index: include.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/include.php,v
retrieving revision 1.116
retrieving revision 1.117
diff -u -r1.116 -r1.117
--- include.php	9 May 2002 02:53:14 -0000	1.116
+++ include.php	18 May 2002 02:59:32 -0000	1.117
@@ -107,12 +107,12 @@
 		return Smarty::fetch($_smarty_tpl_file, $_smarty_cache_id, $_smarty_compile_id, $_smarty_display);
 	}
 	
-	function wrap($template, $title = '', $dir = '') {
+	function wrap($template, $title = '') {
 		global $TITLE, $_gv, $_pv;
 		
 		$this->assign(array(
 			'content_template' => $template,
-			'page_title' => isset($TITLE[$title]) ? $TITLE[$title] : ''
+			'page_title' => isset($TITLE[$title]) ? $TITLE[$title] : $title
 			));
 			
 		// Use a popup wrap?
@@ -122,8 +122,11 @@
 		} else {
 			$wrap = 'wrap.html';
 		}
-		
-		$this->display($dir . $wrap);
+		if (($dir = dirname($template)) != '.') {
+			$this->display("$dir/$wrap");
+		} else {
+			$this->display($wrap);
+		}
 	}
 }
 

Index: index.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/index.php,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- index.php	5 May 2002 16:33:12 -0000	1.31
+++ index.php	18 May 2002 02:59:32 -0000	1.32
@@ -137,6 +137,6 @@
 		" and changed_field = 'status' and new_value = 'Closed'".
 		' and b.project_id = p.project_id order by h.created_date desc', 0, 5)));
 
-$t->display('index.html');
+$t->wrap('index.html', 'home');
 
 ?>

Index: newaccount.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/newaccount.php,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -r1.30 -r1.31
--- newaccount.php	11 Apr 2002 07:32:25 -0000	1.30
+++ newaccount.php	18 May 2002 02:59:32 -0000	1.31
@@ -29,7 +29,7 @@
 	global $db, $t, $_pv, $STRING, $now, $u;
 	
 	if (NEW_ACCOUNTS_DISABLED) {
-		$t->display('newaccount-disabled.html');
+		$t->wrap('newaccount-disabled.html');
 		return;
 	}
 
@@ -73,16 +73,16 @@
 	mail($_pv['email'], $STRING['newacctsubject'], sprintf($STRING['newacctmessage'], 
 		$password),	sprintf("From: %s\nContent-Type: text/plain; charset=%s\nContent-Transfer-Encoding: 8bit\n",ADMIN_EMAIL, $STRING['lang_charset']));
 
-	$t->display('newaccountsuccess.html');
+	$t->wrap('newaccountsuccess.html', 'accountcreated');
 }
 
 function show_form($error = '') {
 	global $t, $_pv;
 	
 	if (NEW_ACCOUNTS_DISABLED) {
-		$t->display('newaccount-disabled.html');
+		$t->wrap('newaccount-disabled.html');
 	} else {
-		$t->display('newaccount.html');
+		$t->wrap('newaccount.html', 'newaccount');
 	}
 }
 

Index: query.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/query.php,v
retrieving revision 1.72
retrieving revision 1.73
diff -u -r1.72 -r1.73
--- query.php	8 May 2002 12:59:13 -0000	1.72
+++ query.php	18 May 2002 02:59:32 -0000	1.73
@@ -42,9 +42,9 @@
 			$t->assign('queries', 
 				$db->getAll("select * from ".TBL_SAVED_QUERY." where user_id = '$u'"));
 		}
-		$t->display('queryform.html');
+		$t->wrap('queryform.html', 'bugquery');
 	} else { // or show the simple one
-		$t->display('queryform-simple.html');
+		$t->wrap('queryform-simple.html', 'bugquery');
 	}
 }
 
@@ -275,7 +275,7 @@
 		$order, $sort), $llimit, $selrange)));
 				
 	sorting_headers($me, $headers, $order, $sort, "page=$page");
-	$t->display('buglist.html');
+	$t->wrap('buglist.html', 'buglist');
 }
 
 $reportedby = !empty($_gv['reportedby']) ? $_gv['reportedby'] : 0;

Index: report.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/report.php,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- report.php	3 Apr 2002 19:08:47 -0000	1.25
+++ report.php	18 May 2002 02:59:32 -0000	1.26
@@ -59,7 +59,7 @@
 		));
 	$db->setOption('optimize', 'portability'); 
 
-	$t->display('report.html');
+	$t->wrap('report.html', 'reporting');
 }
 
 function new_bugs_by_date($date_range) {

Index: user.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/user.php,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- user.php	24 Apr 2002 07:06:23 -0000	1.25
+++ user.php	18 May 2002 02:59:32 -0000	1.26
@@ -63,7 +63,8 @@
 	}
 	
 	$db->query("update ".TBL_AUTH_USER." set password = '$mpassword' where user_id = $u");
-	$t->display('passwordchanged.html');
+	$t->assign('changetext', $STRING['password_changed']);
+	$t->wrap('changessaved.html', 'changessaved');
 }
 
 // Save changes to a user's preferences
@@ -86,7 +87,8 @@
 		$db->query("update ".TBL_USER_PREF.' '.@join(', ', $updates).
 			" where user_id = $u");
 	}
-	$t->display('preferenceschanged.html');
+	$t->assign('changetext', $STRING['prefs_changed']);
+	$t->wrap('changessaved.html', 'changessaved');
 }
 
 
@@ -117,7 +119,7 @@
 		'preferences' => $preferences
 		));
 		
-	$t->display('user.html');
+	$t->wrap('user.html', 'preferences');
 }
 
 $perm->check_group('User');

Re: [phpBT-dev] CVS: phpbt config-dist.php,1.15,1.16 config.php,1.29,1.30

[Ben C. <php...@be...>]

The schema change is fine, and yes, please update config.php along with
config-dist.php.  Even though it is distributed empty, it is much easier
for those keeping up with cvs (i.e., us) to keep current with database
changes.  Thanks for the work!

On Fri, May 17, 2002 at 08:23:49AM -0700, Jirka Pech wrote:
> Update of /cvsroot/phpbt/phpbt
> In directory usw-pr-cvs1:/tmp/cvs-serv9422/phpbt
> 
> Modified Files:
> 	config-dist.php config.php 
> Log Message:
> mysql.in:
>  - Added TBL_DATABASE for database provider/version tracking and filled in some example lines - "to be replaced" lines. I don't actually know if we want to distribute this table as empty or filled with something.
>  - Added closed_in_version_id and to_be_closed_in_version_id columns to TBL_BUG.
> config-dist.php (and config.php):
>  - Added TBL_DATABASE to config.
> 
> QUESTIONS:
>  - Is it correct to change cofig.php (which is distibuted empty), when changed config-dist.php?
>  - Is it a good practice to change schemas like I did or we prefer some other way?
> 
> 
> Index: config-dist.php
> ===================================================================
> RCS file: /cvsroot/phpbt/phpbt/config-dist.php,v
> retrieving revision 1.15
> retrieving revision 1.16
> diff -u -r1.15 -r1.16
> --- config-dist.php	11 Apr 2002 22:03:57 -0000	1.15
> +++ config-dist.php	17 May 2002 15:23:47 -0000	1.16
> @@ -63,6 +63,7 @@
>  define ('TBL_USER_PREF',       TBL_PREFIX.'user_pref');
>  define ('TBL_VERSION',         TBL_PREFIX.'version');
>  define ('TBL_PROJECT_GROUP',   TBL_PREFIX.'project_group');
> +define ('TBL_DATABASE',	       TBL_PREFIX.'database');
>  
>  define ('ONEDAY', 86400);
>  
> 
> Index: config.php
> ===================================================================
> RCS file: /cvsroot/phpbt/phpbt/config.php,v
> retrieving revision 1.29
> retrieving revision 1.30
> diff -u -r1.29 -r1.30
> --- config.php	9 Apr 2002 20:53:07 -0000	1.29
> +++ config.php	17 May 2002 15:23:47 -0000	1.30
> @@ -65,6 +65,7 @@
>  define ('TBL_USER_PREF',       TBL_PREFIX.'user_pref');
>  define ('TBL_VERSION',         TBL_PREFIX.'version');
>  define ('TBL_PROJECT_GROUP',   TBL_PREFIX.'project_group');
> +define ('TBL_DATABASE',        TBL_PREFIX.'database');
>  
>  define ('ONEDAY', 86400);
>  
> 
> 
> _______________________________________________________________
> 
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: ban...@so...
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev

Re: [phpBT-dev] CVS: phpbt/inc functions.php,1.24,1.25

[Ben C. <php...@be...>]

Heheh, well, I didn't mean you had to comment every line of code. :)

On Fri, May 17, 2002 at 07:35:12AM -0700, Jirka Pech wrote:
> Update of /cvsroot/phpbt/phpbt/inc
> In directory usw-pr-cvs1:/tmp/cvs-serv28544/phpbt/inc
> 
> Modified Files:
> 	functions.php 
> Log Message:
> Added comments to qp_enc functions. I hope this will satisfy Ben's request for walking through qp_enc function. Do you think it's know usable in PHPBT? If so, I will modify bug.php for using qp_mail function replacing PHP's original mail function, which does no conversion. I thought about new configuration switch, which can tell us if to use MIME e-mail or not. If yes, we will use qp_mail, otherwise we can use original mail function. Do you agree?
> 
> 
> Index: functions.php
> ===================================================================
> RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
> retrieving revision 1.24
> retrieving revision 1.25
> diff -u -r1.24 -r1.25
> --- functions.php	16 May 2002 12:52:02 -0000	1.24
> +++ functions.php	17 May 2002 14:35:09 -0000	1.25
> @@ -427,35 +427,59 @@
>  	return date($format, $string);
>  }
>  
> -// quoted-printable encoder function
> +/* quoted-printable encoder function
> +    This encoding has all non-ascii (say >127, <32 and =61 chracters)
> +    encoded as "=" and it's hexadecimal value. Special case is space
> +    (32 decimal) at the end of line, which is converted to =20, other-
> +    wise it's not converted and it's returned as space (32 decimal). */
> +
>  function qp_enc($input, $line_max = 76) {
> +    // Initialize variables
>      $hex = array('0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F');
> -    $lines = split("\n", str_replace("\r\n", "\n", $input));
>      $eol = "\n";
>      $escape = "=";
>      $output = "";
> +    // Do "dos2unix" and split $input into $lines by end of line
> +    $lines = split("\n", str_replace("\r\n", "\n", $input));
> +    // Loop throught $lines
>      while( list(, $line) = each($lines) ) { 
> -        $line = rtrim($line);
> -        $linlen = strlen($line);
> -        $newline = ""; 
> -        for($i = 0; $i < $linlen; $i++) {
> -            $c = substr($line, $i, 1);
> -            $dec = ord($c);
> -            if ( ($dec == 32) && ($i == ($linlen - 1)) ) {
> -                $c = "=20";
> -            } elseif ( ($dec == 61) || ($dec < 32 ) || ($dec > 126) ) {
> -                $h2 = floor($dec/16); $h1 = floor($dec%16);
> -                $c = $escape.$hex["$h2"].$hex["$h1"];
> -            } 
> -            if ( (strlen($newline) + strlen($c)) >= $line_max ) {
> -                $output .= $newline.$escape.$eol;
> -                $newline = "";
> -            } 
> -            $newline .= $c;
> -        }
> -        $output .= $newline.$eol;
> +	// Trim each line from right side
> +	$line = rtrim($line);
> +	// Place line length to $linlen
> +	$linlen = strlen($line);
> +	// Initialize $newline
> +	$newline = "";
> +	// Loop throught each line and process each character of the line
> +	for($i = 0; $i < $linlen; $i++) {
> +	    // Place each character of $line to $c
> +	    $c = substr($line, $i, 1);
> +	    // Place decimal value of $c to $dec
> +	    $dec = ord($c);
> +	    // If $c equals to space (" ") and we are at the end of line place
> +	    // space (" ") to $c
> +	    if (($dec == 32) && ($i == ($linlen - 1))) {
> +		$c = "=20";
> +	    } elseif ( ($dec == 61) || ($dec < 32 ) || ($dec > 126) ) {
> +		// Or if $c is not printable character in ascii, convert the
> +		// character to it's quoted-printable value
> +		$h2 = floor($dec/16); $h1 = floor($dec%16);
> +        	$c = $escape.$hex["$h2"].$hex["$h1"];
> +	    }
> +	    // If we are at the maximum line length, add whole line (converted)
> +	    // with end of line character to $output
> +	    if ( (strlen($newline) + strlen($c)) >= $line_max ) {
> +		$output .= $newline.$escape.$eol;
> +		// And initialize $newline as empty
> +		$newline = "";
> +	    }
> +	    // Add converted (or ascii) character to $newline
> +	    $newline .= $c;
> +	}
> +	// Add $newline with end of line character to output
> +	$output .= $newline.$eol;
>      }
> -    return (trim($output)); 
> +    // Return trimmed output
> +    return (trim($output));
>  }
>  
>  // mailer with use of quoted-printable encoding
> @@ -466,9 +490,9 @@
>          $headers .= "\n";
>          // There have to be no newline at the end of $headers
>      }
> -    $headers .= "Content-type: text/plain; charset=\"".$STRING['lang_charset']."\"\n";
> +    $headers .= "Content-type: Text/plain; charset=\"".$STRING['lang_charset']."\"\n";
>      $headers .= "Content-Transfer-Encoding: quoted-printable\nMIME-Version: 1.0";
>      mail ($to, $subject, qp_enc($body), $headers);
> -} 
> +}
>  
>  ?>
> 
> 
> _______________________________________________________________
> 
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: ban...@so...
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev

[phpBT-dev] CVS: phpbt/schemas mysql.in,1.26,1.27

[Jirka P. <fi...@us...>]

Update of /cvsroot/phpbt/phpbt/schemas
In directory usw-pr-cvs1:/tmp/cvs-serv13369/phpbt/schemas

Modified Files:
	mysql.in 
Log Message:
Fixed my mistake from previous version.


Index: mysql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/mysql.in,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- mysql.in	17 May 2002 15:23:47 -0000	1.26
+++ mysql.in	17 May 2002 15:31:11 -0000	1.27
@@ -386,7 +386,6 @@
 
 INSERT INTO TBL_DATABASE VALUES (1,'Oracle','8.1.7',1);
 INSERT INTO TBL_DATABASE VALUES (2,'MySQL','3.23.49',2);
-INSERT INTO TBL_DATABASE VALUES (2,'PostgreSQL','7.1.3',3);
+INSERT INTO TBL_DATABASE VALUES (3,'PostgreSQL','7.1.3',3);
 create table TBL_DATABASE_seq (id int unsigned auto_increment not null primary key);
-insert into TBL_DATABASE_seq values (2);
-
+insert into TBL_DATABASE_seq values (3);

[phpBT-dev] CVS: phpbt config-dist.php,1.15,1.16 config.php,1.29,1.30

[Jirka P. <fi...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv9422/phpbt

Modified Files:
	config-dist.php config.php 
Log Message:
mysql.in:
 - Added TBL_DATABASE for database provider/version tracking and filled in some example lines - "to be replaced" lines. I don't actually know if we want to distribute this table as empty or filled with something.
 - Added closed_in_version_id and to_be_closed_in_version_id columns to TBL_BUG.
config-dist.php (and config.php):
 - Added TBL_DATABASE to config.

QUESTIONS:
 - Is it correct to change cofig.php (which is distibuted empty), when changed config-dist.php?
 - Is it a good practice to change schemas like I did or we prefer some other way?


Index: config-dist.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/config-dist.php,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- config-dist.php	11 Apr 2002 22:03:57 -0000	1.15
+++ config-dist.php	17 May 2002 15:23:47 -0000	1.16
@@ -63,6 +63,7 @@
 define ('TBL_USER_PREF',       TBL_PREFIX.'user_pref');
 define ('TBL_VERSION',         TBL_PREFIX.'version');
 define ('TBL_PROJECT_GROUP',   TBL_PREFIX.'project_group');
+define ('TBL_DATABASE',	       TBL_PREFIX.'database');
 
 define ('ONEDAY', 86400);
 

Index: config.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/config.php,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- config.php	9 Apr 2002 20:53:07 -0000	1.29
+++ config.php	17 May 2002 15:23:47 -0000	1.30
@@ -65,6 +65,7 @@
 define ('TBL_USER_PREF',       TBL_PREFIX.'user_pref');
 define ('TBL_VERSION',         TBL_PREFIX.'version');
 define ('TBL_PROJECT_GROUP',   TBL_PREFIX.'project_group');
+define ('TBL_DATABASE',        TBL_PREFIX.'database');
 
 define ('ONEDAY', 86400);
 

[phpBT-dev] CVS: phpbt/schemas mysql.in,1.25,1.26

[Jirka P. <fi...@us...>]

Update of /cvsroot/phpbt/phpbt/schemas
In directory usw-pr-cvs1:/tmp/cvs-serv9422/phpbt/schemas

Modified Files:
	mysql.in 
Log Message:
mysql.in:
 - Added TBL_DATABASE for database provider/version tracking and filled in some example lines - "to be replaced" lines. I don't actually know if we want to distribute this table as empty or filled with something.
 - Added closed_in_version_id and to_be_closed_in_version_id columns to TBL_BUG.
config-dist.php (and config.php):
 - Added TBL_DATABASE to config.

QUESTIONS:
 - Is it correct to change cofig.php (which is distibuted empty), when changed config-dist.php?
 - Is it a good practice to change schemas like I did or we prefer some other way?


Index: mysql.in
===================================================================
RCS file: /cvsroot/phpbt/phpbt/schemas/mysql.in,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- mysql.in	1 May 2002 12:20:55 -0000	1.25
+++ mysql.in	17 May 2002 15:23:47 -0000	1.26
@@ -62,6 +62,7 @@
   priority tinyint(3) unsigned NOT NULL default '0',
   status_id tinyint(3) unsigned NOT NULL default '0',
   resolution_id tinyint(3) unsigned NOT NULL default '0',
+  database_id tinyint(3) unsigned NOT NULL default '0',
   assigned_to int(10) unsigned NOT NULL default '0',
   created_by int(10) unsigned NOT NULL default '0',
   created_date bigint(20) unsigned NOT NULL default '0',
@@ -69,11 +70,15 @@
   last_modified_date bigint(20) unsigned NOT NULL default '0',
   project_id int(10) unsigned NOT NULL default '0',
   version_id int(10) unsigned NOT NULL default '0',
+  closed_in_version_id int(10) unsigned NOT NULL default '0',
+  to_be_closed_in_version_id int(10) unsigned NOT NULL default '0',
   component_id int(10) unsigned NOT NULL default '0',
   os_id tinyint(3) unsigned NOT NULL default '0',
   browser_string varchar(255) NOT NULL default '',
   close_date bigint(20) unsigned NOT NULL default '0',
-  PRIMARY KEY  (bug_id)
+  closed_in_version_id int(10) unsigned NOT NULL default '0',
+  to_be_closed_in_version_id int(10) unsigned NOT NULL default '0',
+  PRIMARY KEY (bug_id)
 ) TYPE=MyISAM;
 
 CREATE TABLE TBL_BUG_CC (
@@ -250,6 +255,14 @@
   PRIMARY KEY  (version_id)
 ) TYPE=MyISAM;
 
+CREATE TABLE TBL_DATABASE (
+  database_id int(10) unsigned NOT NULL default '0',
+  database_name varchar(30) NOT NULL default '',
+  database_version varchar(10) NOT NULL default '',
+  sort_order tinyint(3) unsigned NOT NULL default '0',
+  PRIMARY KEY (database_id)
+) TYPE=MyISAM;
+
 #
 # -- Insert initial data --
 #
@@ -370,4 +383,10 @@
 INSERT INTO TBL_STATUS VALUES (7,'Closed','The bug is officially squashed (QA)',7);
 create table TBL_STATUS_seq (id int unsigned auto_increment not null primary key);
 insert into TBL_STATUS_seq values (7);
+
+INSERT INTO TBL_DATABASE VALUES (1,'Oracle','8.1.7',1);
+INSERT INTO TBL_DATABASE VALUES (2,'MySQL','3.23.49',2);
+INSERT INTO TBL_DATABASE VALUES (2,'PostgreSQL','7.1.3',3);
+create table TBL_DATABASE_seq (id int unsigned auto_increment not null primary key);
+insert into TBL_DATABASE_seq values (2);
 

[phpBT-dev] CVS: phpbt/inc functions.php,1.24,1.25

[Jirka P. <fi...@us...>]

Update of /cvsroot/phpbt/phpbt/inc
In directory usw-pr-cvs1:/tmp/cvs-serv28544/phpbt/inc

Modified Files:
	functions.php 
Log Message:
Added comments to qp_enc functions. I hope this will satisfy Ben's request for walking through qp_enc function. Do you think it's know usable in PHPBT? If so, I will modify bug.php for using qp_mail function replacing PHP's original mail function, which does no conversion. I thought about new configuration switch, which can tell us if to use MIME e-mail or not. If yes, we will use qp_mail, otherwise we can use original mail function. Do you agree?


Index: functions.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- functions.php	16 May 2002 12:52:02 -0000	1.24
+++ functions.php	17 May 2002 14:35:09 -0000	1.25
@@ -427,35 +427,59 @@
 	return date($format, $string);
 }
 
-// quoted-printable encoder function
+/* quoted-printable encoder function
+    This encoding has all non-ascii (say >127, <32 and =61 chracters)
+    encoded as "=" and it's hexadecimal value. Special case is space
+    (32 decimal) at the end of line, which is converted to =20, other-
+    wise it's not converted and it's returned as space (32 decimal). */
+
 function qp_enc($input, $line_max = 76) {
+    // Initialize variables
     $hex = array('0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F');
-    $lines = split("\n", str_replace("\r\n", "\n", $input));
     $eol = "\n";
     $escape = "=";
     $output = "";
+    // Do "dos2unix" and split $input into $lines by end of line
+    $lines = split("\n", str_replace("\r\n", "\n", $input));
+    // Loop throught $lines
     while( list(, $line) = each($lines) ) { 
-        $line = rtrim($line);
-        $linlen = strlen($line);
-        $newline = ""; 
-        for($i = 0; $i < $linlen; $i++) {
-            $c = substr($line, $i, 1);
-            $dec = ord($c);
-            if ( ($dec == 32) && ($i == ($linlen - 1)) ) {
-                $c = "=20";
-            } elseif ( ($dec == 61) || ($dec < 32 ) || ($dec > 126) ) {
-                $h2 = floor($dec/16); $h1 = floor($dec%16);
-                $c = $escape.$hex["$h2"].$hex["$h1"];
-            } 
-            if ( (strlen($newline) + strlen($c)) >= $line_max ) {
-                $output .= $newline.$escape.$eol;
-                $newline = "";
-            } 
-            $newline .= $c;
-        }
-        $output .= $newline.$eol;
+	// Trim each line from right side
+	$line = rtrim($line);
+	// Place line length to $linlen
+	$linlen = strlen($line);
+	// Initialize $newline
+	$newline = "";
+	// Loop throught each line and process each character of the line
+	for($i = 0; $i < $linlen; $i++) {
+	    // Place each character of $line to $c
+	    $c = substr($line, $i, 1);
+	    // Place decimal value of $c to $dec
+	    $dec = ord($c);
+	    // If $c equals to space (" ") and we are at the end of line place
+	    // space (" ") to $c
+	    if (($dec == 32) && ($i == ($linlen - 1))) {
+		$c = "=20";
+	    } elseif ( ($dec == 61) || ($dec < 32 ) || ($dec > 126) ) {
+		// Or if $c is not printable character in ascii, convert the
+		// character to it's quoted-printable value
+		$h2 = floor($dec/16); $h1 = floor($dec%16);
+        	$c = $escape.$hex["$h2"].$hex["$h1"];
+	    }
+	    // If we are at the maximum line length, add whole line (converted)
+	    // with end of line character to $output
+	    if ( (strlen($newline) + strlen($c)) >= $line_max ) {
+		$output .= $newline.$escape.$eol;
+		// And initialize $newline as empty
+		$newline = "";
+	    }
+	    // Add converted (or ascii) character to $newline
+	    $newline .= $c;
+	}
+	// Add $newline with end of line character to output
+	$output .= $newline.$eol;
     }
-    return (trim($output)); 
+    // Return trimmed output
+    return (trim($output));
 }
 
 // mailer with use of quoted-printable encoding
@@ -466,9 +490,9 @@
         $headers .= "\n";
         // There have to be no newline at the end of $headers
     }
-    $headers .= "Content-type: text/plain; charset=\"".$STRING['lang_charset']."\"\n";
+    $headers .= "Content-type: Text/plain; charset=\"".$STRING['lang_charset']."\"\n";
     $headers .= "Content-Transfer-Encoding: quoted-printable\nMIME-Version: 1.0";
     mail ($to, $subject, qp_enc($body), $headers);
-} 
+}
 
 ?>

Re: [phpBT-dev] for 0.9.0

[Ben C. <php...@be...>]

The request has been made to be able to delete users that haven't had
any bug activity.

On Thu, May 16, 2002 at 02:27:52PM -0000, Jirka Pech wrote:
> > Integration of the cache_clean() function into the Admin Menu is needed
> > along with possibility to delete users.
> >
> > Bye,
> > Alessandro
> 
> I thought users are not deleted but deactivated, aren't they?
> 
> Jirka
> 
> _______________________________________________________________
> 
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: ban...@so...
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev

Re: [phpBT-dev] for 0.9.0

[Jirka P. <fi...@us...>]

> Integration of the cache_clean() function into the Admin Menu is needed
> along with possibility to delete users.
>
> Bye,
> Alessandro

I thought users are not deleted but deactivated, aren't they?

Jirka

[phpBT-dev] for 0.9.0

[Alessandro P. (T. / J578) <al...@ti...>]

Integration of the cache_clean() function into the Admin Menu is needed
along with possibility to delete users.

Bye,
Alessandro

-- 
Alessandro "TXM" Pisani - alextxm at tin dot it - ICQ: #2209087

"I will carry you through, kicking and screaming,
 and in the end you will thank me"
 - Tyler Durden [from "Fight Club"]

Re: [phpBT-dev] CVS: phpbt/inc functions.php,1.22,1.23

[Jirka P. <fi...@us...>]

> Would this cause issues with people who don't have mime-capable email
> clients?

Are there any? When they view quoted-printable in plain text viewer, they
will see national characters converted(unreadable) and other text
unchanged. I don't actually know anyone, who is using national characters
with mime-not-capable client.

In our country everyone(plus minus), who is not able to read mime e-mails
with his client, uses ascii text only. And ascii text is left unchanged by
qp_enc. We can add wordwrap (because quoted-printable has one "=3D" at the
end of each line) for mime-not-capable clients, but I think it's not
necessary. What do you think about it?

> -} ?>
> \ No newline at end of file
> +}
> +
> +?>

Eh, sorry. :-(

Jirka

Re: [phpBT-dev] CVS: phpbt/inc functions.php,1.22,1.23

[Ben C. <php...@be...>]

And could you walk me through qp_enc()?  Thanks!

On Thu, May 16, 2002 at 03:37:39AM -0700, Jirka Pech wrote:
> Update of /cvsroot/phpbt/phpbt/inc
> In directory usw-pr-cvs1:/tmp/cvs-serv4123/phpbt/inc
> 
> Modified Files:
> 	functions.php 
> Log Message:
> Added qp_mail function (and one function, which helps with encoding) for outgoing mail handling. I will add some error handling for it later. Please, look on it and send your comments to dev-list.
> 
> 
> Index: functions.php
> ===================================================================
> RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
> retrieving revision 1.22
> retrieving revision 1.23
> diff -u -r1.22 -r1.23
> --- functions.php	2 May 2002 13:17:57 -0000	1.22
> +++ functions.php	16 May 2002 10:37:37 -0000	1.23
> @@ -427,4 +427,46 @@
>  	return date($format, $string);
>  }
>  
> -?>
> +// quoted-printable encoder function
> +function qp_enc($input, $line_max = 76) {
> +    $hex = array('0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F');
> +    $lines = split("\n", str_replace("\r\n", "\n", $input));
> +    $eol = "\n";
> +    $escape = "=";
> +    $output = "";
> +    while( list(, $line) = each($lines) ) { 
> +        $line = rtrim($line);
> +        $linlen = strlen($line);
> +        $newline = ""; 
> +        for($i = 0; $i < $linlen; $i++) {
> +            $c = substr($line, $i, 1);
> +            $dec = ord($c);
> +            if ( ($dec == 32) && ($i == ($linlen - 1)) ) {
> +                $c = "=20";
> +            } elseif ( ($dec == 61) || ($dec < 32 ) || ($dec > 126) ) {
> +                $h2 = floor($dec/16); $h1 = floor($dec%16);
> +                $c = $escape.$hex["$h2"].$hex["$h1"];
> +            } 
> +            if ( (strlen($newline) + strlen($c)) >= $line_max ) {
> +                $output .= $newline.$escape.$eol;
> +                $newline = "";
> +            } 
> +            $newline .= $c;
> +        }
> +        $output .= $newline.$eol;
> +    }
> +    return (trim($output)); 
> +}
> +
> +// mailer with use of quoted-printable encoding
> +function qp_mail($to, $subject = 'No subject', $body, $headers = '') {
> +    global $STRING;
> +
> +    if ($headers != '') {
> +        $headers .= "\n";
> +        // There have to be no newline at the end of $headers
> +    }
> +    $headers .= "Content-type: text/plain; charset=\"".$STRING['lang_charset']."\"\n";
> +    $headers .= "Content-Transfer-Encoding: quoted-printable\nMIME-Version: 1.0";
> +    mail ($to, $subject, qp_enc($body), $headers);
> +} ?>    
> \ No newline at end of file
> 
> 
> _______________________________________________________________
> 
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: ban...@so...
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev

[phpBT-dev] CVS: phpbt/inc functions.php,1.23,1.24

[Benjamin C. <bc...@us...>]

Update of /cvsroot/phpbt/phpbt/inc
In directory usw-pr-cvs1:/tmp/cvs-serv10260/inc

Modified Files:
	functions.php 
Log Message:
Removed trailing white space

Index: functions.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- functions.php	16 May 2002 10:37:37 -0000	1.23
+++ functions.php	16 May 2002 12:52:02 -0000	1.24
@@ -469,4 +469,6 @@
     $headers .= "Content-type: text/plain; charset=\"".$STRING['lang_charset']."\"\n";
     $headers .= "Content-Transfer-Encoding: quoted-printable\nMIME-Version: 1.0";
     mail ($to, $subject, qp_enc($body), $headers);
-} ?>    
\ No newline at end of file
+} 
+
+?>

Re: [phpBT-dev] CVS: phpbt/inc functions.php,1.22,1.23

[Ben C. <php...@be...>]

Would this cause issues with people who don't have mime-capable email
clients?

On Thu, May 16, 2002 at 03:37:39AM -0700, Jirka Pech wrote:
> Update of /cvsroot/phpbt/phpbt/inc
> In directory usw-pr-cvs1:/tmp/cvs-serv4123/phpbt/inc
> 
> Modified Files:
> 	functions.php 
> Log Message:
> Added qp_mail function (and one function, which helps with encoding) for outgoing mail handling. I will add some error handling for it later. Please, look on it and send your comments to dev-list.
> 
> 
> Index: functions.php
> ===================================================================
> RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
> retrieving revision 1.22
> retrieving revision 1.23
> diff -u -r1.22 -r1.23
> --- functions.php	2 May 2002 13:17:57 -0000	1.22
> +++ functions.php	16 May 2002 10:37:37 -0000	1.23
> @@ -427,4 +427,46 @@
>  	return date($format, $string);
>  }
>  
> -?>
> +// quoted-printable encoder function
> +function qp_enc($input, $line_max = 76) {
> +    $hex = array('0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F');
> +    $lines = split("\n", str_replace("\r\n", "\n", $input));
> +    $eol = "\n";
> +    $escape = "=";
> +    $output = "";
> +    while( list(, $line) = each($lines) ) { 
> +        $line = rtrim($line);
> +        $linlen = strlen($line);
> +        $newline = ""; 
> +        for($i = 0; $i < $linlen; $i++) {
> +            $c = substr($line, $i, 1);
> +            $dec = ord($c);
> +            if ( ($dec == 32) && ($i == ($linlen - 1)) ) {
> +                $c = "=20";
> +            } elseif ( ($dec == 61) || ($dec < 32 ) || ($dec > 126) ) {
> +                $h2 = floor($dec/16); $h1 = floor($dec%16);
> +                $c = $escape.$hex["$h2"].$hex["$h1"];
> +            } 
> +            if ( (strlen($newline) + strlen($c)) >= $line_max ) {
> +                $output .= $newline.$escape.$eol;
> +                $newline = "";
> +            } 
> +            $newline .= $c;
> +        }
> +        $output .= $newline.$eol;
> +    }
> +    return (trim($output)); 
> +}
> +
> +// mailer with use of quoted-printable encoding
> +function qp_mail($to, $subject = 'No subject', $body, $headers = '') {
> +    global $STRING;
> +
> +    if ($headers != '') {
> +        $headers .= "\n";
> +        // There have to be no newline at the end of $headers
> +    }
> +    $headers .= "Content-type: text/plain; charset=\"".$STRING['lang_charset']."\"\n";
> +    $headers .= "Content-Transfer-Encoding: quoted-printable\nMIME-Version: 1.0";
> +    mail ($to, $subject, qp_enc($body), $headers);
> +} ?>    
> \ No newline at end of file
> 
> 
> _______________________________________________________________
> 
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: ban...@so...
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev

[phpBT-dev] Formatting

[Ben C. <php...@be...>]

Just a gentle reminder that indents should be done with tabs, not
spaces, though there are large portions of space indents in the code
because of that guideline not always being followed.

[phpBT-dev] CVS: phpbt bug.php,1.104,1.105

[Jirka P. <fi...@us...>]

Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv9307/phpbt

Modified Files:
	bug.php 
Log Message:
Replaced original mail function with qp_mail and did some cleanup. It's tested by me only, so feel free to test it.


Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.104
retrieving revision 1.105
diff -u -r1.104 -r1.105
--- bug.php	8 May 2002 12:57:18 -0000	1.104
+++ bug.php	16 May 2002 11:01:02 -0000	1.105
@@ -239,32 +239,29 @@
 
   // Collect the CCs
   if ($ccs = $db->getCol(sprintf($QUERY['bug-cc-list'], $buginfo['bug_id']))) {
-		$maillist = array_merge($maillist, $ccs);
-	}
+    $maillist = array_merge($maillist, $ccs);
+  }
 
   // Later add a watcher (such as QA person) check here
-	if (count($maillist)) {
-  	if ($toemail = delimit_list(', ',$maillist)) {
-
-  		$t->assign(array(
-    		'bugid' => $buginfo['bug_id'],
-    		'bugurl' => INSTALL_URL."/bug.php?op=show&bugid={$buginfo['bug_id']}",
-    		'priority' => $select['priority'][(!empty($cf['priority']) ? $cf['priority'] : $buginfo['priority'])],
-    		'priority_stat' => !empty($cf['priority']) ? '!' : ' ',
-    		'reporter' => $reporter,
-    		'reporter_stat' => $reporterstat,
-    		'assignedto' => $assignedto,
-    		'assignedto_stat' => $assignedtostat
-    		));
-
-    	mail($toemail,
-				"[Bug {$buginfo['bug_id']}] ".($newbug ? 'New' : 'Changed').' - '.
-					stripslashes((!empty($cf['title']) ? $cf['title'] : $buginfo['title'])), 
-				$t->fetch($template),
-      	sprintf("From: %s\nReply-To: %s\nErrors-To: %s\nContent-Type: text/plain; charset=%s\nContent-Transfer-Encoding: 8bit\n", ADMIN_EMAIL, ADMIN_EMAIL,
-        	ADMIN_EMAIL, $STRING['lang_charset']));
-  	}
-	}
+  if (count($maillist)) {
+    if ($toemail = delimit_list(', ',$maillist)) {
+      $t->assign(array(
+	'bugid' => $buginfo['bug_id'],
+	'bugurl' => INSTALL_URL."/bug.php?op=show&bugid={$buginfo['bug_id']}",
+	'priority' => $select['priority'][(!empty($cf['priority']) ? $cf['priority'] : $buginfo['priority'])],
+	'priority_stat' => !empty($cf['priority']) ? '!' : ' ',
+	'reporter' => $reporter,
+	'reporter_stat' => $reporterstat,
+	'assignedto' => $assignedto,
+	'assignedto_stat' => $assignedtostat
+      ));
+      
+      qp_mail($toemail,"[Bug {$buginfo['bug_id']}] ".($newbug ? 'New' : 'Changed').' - '.
+	  stripslashes((!empty($cf['title']) ? $cf['title'] : $buginfo['title'])),
+	$t->fetch($template),
+      	sprintf("From: %s\nReply-To: %s\nErrors-To: %s", ADMIN_EMAIL, ADMIN_EMAIL, ADMIN_EMAIL));
+    }
+  }
 }
 
 function update_bug($bugid = 0) {

[phpBT-dev] CVS: phpbt/inc functions.php,1.22,1.23

[Jirka P. <fi...@us...>]

Update of /cvsroot/phpbt/phpbt/inc
In directory usw-pr-cvs1:/tmp/cvs-serv4123/phpbt/inc

Modified Files:
	functions.php 
Log Message:
Added qp_mail function (and one function, which helps with encoding) for outgoing mail handling. I will add some error handling for it later. Please, look on it and send your comments to dev-list.


Index: functions.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/inc/functions.php,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- functions.php	2 May 2002 13:17:57 -0000	1.22
+++ functions.php	16 May 2002 10:37:37 -0000	1.23
@@ -427,4 +427,46 @@
 	return date($format, $string);
 }
 
-?>
+// quoted-printable encoder function
+function qp_enc($input, $line_max = 76) {
+    $hex = array('0','1','2','3','4','5','6','7','8','9','A','B','C','D','E','F');
+    $lines = split("\n", str_replace("\r\n", "\n", $input));
+    $eol = "\n";
+    $escape = "=";
+    $output = "";
+    while( list(, $line) = each($lines) ) { 
+        $line = rtrim($line);
+        $linlen = strlen($line);
+        $newline = ""; 
+        for($i = 0; $i < $linlen; $i++) {
+            $c = substr($line, $i, 1);
+            $dec = ord($c);
+            if ( ($dec == 32) && ($i == ($linlen - 1)) ) {
+                $c = "=20";
+            } elseif ( ($dec == 61) || ($dec < 32 ) || ($dec > 126) ) {
+                $h2 = floor($dec/16); $h1 = floor($dec%16);
+                $c = $escape.$hex["$h2"].$hex["$h1"];
+            } 
+            if ( (strlen($newline) + strlen($c)) >= $line_max ) {
+                $output .= $newline.$escape.$eol;
+                $newline = "";
+            } 
+            $newline .= $c;
+        }
+        $output .= $newline.$eol;
+    }
+    return (trim($output)); 
+}
+
+// mailer with use of quoted-printable encoding
+function qp_mail($to, $subject = 'No subject', $body, $headers = '') {
+    global $STRING;
+
+    if ($headers != '') {
+        $headers .= "\n";
+        // There have to be no newline at the end of $headers
+    }
+    $headers .= "Content-type: text/plain; charset=\"".$STRING['lang_charset']."\"\n";
+    $headers .= "Content-Transfer-Encoding: quoted-printable\nMIME-Version: 1.0";
+    mail ($to, $subject, qp_enc($body), $headers);
+} ?>    
\ No newline at end of file

Re: [phpBT-dev] PEAR::DB

[Jirka P. <fi...@us...>]

> Does anyone have anything against including PEAR::DB in the phpBT
> distribution?  It would be helpful to avoid the bug reports like "It's
> broken -- DB.php can't be included!".  If nobody objects, I'll add it
> for the 0.9.0 release.

That was only describing comment, I have nothing against PEAR or DB.php in
spite of it does not use sequences (ORACLE) or auto increment columns
(MySQL). :-)

Jirka

[phpBT-dev] PEAR::DB

[Ben C. <php...@be...>]

Does anyone have anything against including PEAR::DB in the phpBT
distribution?  It would be helpful to avoid the bug reports like "It's
broken -- DB.php can't be included!".  If nobody objects, I'll add it
for the 0.9.0 release.

Re: [phpBT-dev] Plans for 0.9.0

[John W. <jp...@us...>]

Ben Curtis wrote:
> I'd like to start the thread to discuss the plans for the next version.
> The items currently in the wiki
> (http://phpbt.sourceforge.net/wiki/index.php/RoadMap) look like a
> manageable chunk of work.  I'd like to get this version released by the
> end of June, and I'm thinking that should give us enough time to
> implement the following:
> 
> 1. Full i18n of templates and database field names.
> 2. Additional bug tracking info, such as to-be-closed version, closed
> version, and a free-form field for tracking anything.
> 3. Template selection by user.
> 4. A modular approach for more lookup tables to track things like
> database version, testing environment, etc.
> 
> Based on the wiki, I think the responsibility break-down would look like
> this for the above items:
> 
> 1. Ben
> 2. Jirka
> 3. John
> 4. Ben/Jirka
> 
> This email isn't the final say on the matter -- just a starting point
> for discussion.  What are your thoughts on the tasks, responsibilites,
> and timeline?

Sounds good to me...  I've already been looking at the template 
selection thing and hope to mail out something for comments quite soon.

Re: [phpBT-dev] Plans for 0.9.0

[Ben C. <php...@be...>]

Sounds reasonable to me.

On Tue, May 14, 2002 at 10:49:21AM -0000, Jirka Pech wrote:
> Of course, I will make some changes to mail handling soon, if it will be
> agreed. I think the best way for sending mail is to convert it to
> quoted-printable with proper character encoding and then send it. I don't
> know any mail client, which can not handle quoted-printable and national
> characters (when sending it 8bit-encoded) are really problematic.
> 
> Do you agree?
> 
> Jirka
> 
> _______________________________________________________________
> 
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: ban...@so...
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev

Re: [phpBT-dev] Plans for 0.9.0

[Jirka P. <fi...@us...>]

Of course, I will make some changes to mail handling soon, if it will be
agreed. I think the best way for sending mail is to convert it to
quoted-printable with proper character encoding and then send it. I don't
know any mail client, which can not handle quoted-printable and national
characters (when sending it 8bit-encoded) are really problematic.

Do you agree?

Jirka

Re: [phpBT-dev] Plans for 0.9.0

[Jirka P. <fi...@us...>]

My participation described below:

> 1. Full i18n of templates and database field names.

I will maintain Czech Language files (both encodings). Translation will be
done by me, after en.php will be complete.

> 2. Additional bug tracking info, such as to-be-closed version, closed
> version, and a free-form field for tracking anything.

"to_be_closed_version" and "closed_version" is only adding it to DB schema
files and some change to some script. Will be done before Monday. Then I
will start with free-form field and helping Ben with modular approach.

> 3. Template selection by user.

Can't do anything on my own, but my helping hand is available.

> 4. A modular approach for more lookup tables to track things like
> database version, testing environment, etc.

I will send my conception (don't know it's a good word) before Monday or I
will comment Ben's, if he will send it first.

> Based on the wiki, I think the responsibility break-down would look like
> this for the above items:
>
> 1. Ben
> 2. Jirka
> 3. John
> 4. Ben/Jirka

OK.

Jirka

[phpBT-dev] Plans for 0.9.0

[Ben C. <php...@be...>]

I'd like to start the thread to discuss the plans for the next version.
The items currently in the wiki
(http://phpbt.sourceforge.net/wiki/index.php/RoadMap) look like a
manageable chunk of work.  I'd like to get this version released by the
end of June, and I'm thinking that should give us enough time to
implement the following:

1. Full i18n of templates and database field names.
2. Additional bug tracking info, such as to-be-closed version, closed
version, and a free-form field for tracking anything.
3. Template selection by user.
4. A modular approach for more lookup tables to track things like
database version, testing environment, etc.

Based on the wiki, I think the responsibility break-down would look like
this for the above items:

1. Ben
2. Jirka
3. John
4. Ben/Jirka

This email isn't the final say on the matter -- just a starting point
for discussion.  What are your thoughts on the tasks, responsibilites,
and timeline?