Menu
▾
▴
phpbt-dev — Developer's mailing list and cvs commits
You can subscribe to this list here.
| 2001 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(34) |
Aug
(215) |
Sep
(180) |
Oct
(135) |
Nov
(105) |
Dec
(81) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2002 |
Jan
(76) |
Feb
(22) |
Mar
(154) |
Apr
(149) |
May
(128) |
Jun
(94) |
Jul
(14) |
Aug
(24) |
Sep
(77) |
Oct
(52) |
Nov
(22) |
Dec
(6) |
| 2003 |
Jan
(4) |
Feb
(10) |
Mar
(6) |
Apr
(29) |
May
(10) |
Jun
(37) |
Jul
(39) |
Aug
(13) |
Sep
(23) |
Oct
(3) |
Nov
(7) |
Dec
(2) |
| 2004 |
Jan
|
Feb
(10) |
Mar
(4) |
Apr
|
May
(35) |
Jun
(4) |
Jul
(17) |
Aug
(6) |
Sep
(14) |
Oct
(18) |
Nov
(2) |
Dec
(14) |
| 2005 |
Jan
(9) |
Feb
(30) |
Mar
(6) |
Apr
|
May
(38) |
Jun
(23) |
Jul
(21) |
Aug
(76) |
Sep
(50) |
Oct
(51) |
Nov
(13) |
Dec
|
|
From: Ben C. <php...@be...> - 2002-05-09 04:01:37
|
Well, I'm sure someone will discover a glaring bug within the next 10 minutes, but 0.8.2 is released. :) Feel free to hack away at changes for 0.9.0. If another 0.8.x release is necessary I'll just branch from the tag. Thanks for all the help in squashing bugs! |
|
From: Benjamin C. <bc...@us...> - 2002-05-09 03:04:44
|
Update of /cvsroot/phpbt/phpbt In directory usw-pr-cvs1:/tmp/cvs-serv17205 Modified Files: CHANGELOG Log Message: Updated for 0.8.2 Index: CHANGELOG =================================================================== RCS file: /cvsroot/phpbt/phpbt/CHANGELOG,v retrieving revision 1.56 retrieving revision 1.57 diff -u -r1.56 -r1.57 --- CHANGELOG 13 Apr 2002 15:04:12 -0000 1.56 +++ CHANGELOG 9 May 2002 03:04:42 -0000 1.57 @@ -1,3 +1,12 @@ +-- 0.8.2 -- 8 May 2002 +: Fixed bugs with ordering by dates in the bug list, self-referencing URLs + pointing to php.exe on windows, errors with the attachment list when not + logged in, forming the CC list when mailing bug changes, listing CCs on the + bug form, scrollbars on the popup pages, logging in from the account creation + page, and resetting the project id when editing a bug of an inactive project. +: Fixed session problems with PHP 4.0.6. +: Added some database connection error handling. + -- 0.8.1 -- 13 Apr 2002 : Fixed bugs with version and component creation. : Bug fixed with displaying both created date and last modified date in the bug |
|
From: Benjamin C. <bc...@us...> - 2002-05-09 02:53:17
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv14836
Modified Files:
include.php
Log Message:
Removed $me2 (no longer used) and added a wrap function for smarty (not complete yet)
Index: include.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/include.php,v
retrieving revision 1.115
retrieving revision 1.116
diff -u -r1.115 -r1.116
--- include.php 14 Apr 2002 23:51:26 -0000 1.115
+++ include.php 9 May 2002 02:53:14 -0000 1.116
@@ -63,8 +63,6 @@
include 'languages/'.LANGUAGE.'.php';
$me = $HTTP_SERVER_VARS['PHP_SELF'];
-$me2 = !empty($HTTP_SERVER_VARS['REQUEST_URI']) ? $HTTP_SERVER_VARS['REQUEST_URI'] :
- $HTTP_SERVER_VARS['SCRIPT_NAME'].'?'.$HTTP_SERVER_VARS['QUERY_STRING'];
$selrange = 30;
$now = time();
$_gv =& $HTTP_GET_VARS;
@@ -108,7 +106,25 @@
error_reporting(E_ALL ^ E_NOTICE); // Clobber Smarty warnings
return Smarty::fetch($_smarty_tpl_file, $_smarty_cache_id, $_smarty_compile_id, $_smarty_display);
}
-
+
+ function wrap($template, $title = '', $dir = '') {
+ global $TITLE, $_gv, $_pv;
+
+ $this->assign(array(
+ 'content_template' => $template,
+ 'page_title' => isset($TITLE[$title]) ? $TITLE[$title] : ''
+ ));
+
+ // Use a popup wrap?
+ if ((isset($_gv['use_js']) and $_gv['use_js']) or
+ (isset($_pv['use_js']) and $_pv['use_js'])) {
+ $wrap = 'wrap-popup.html';
+ } else {
+ $wrap = 'wrap.html';
+ }
+
+ $this->display($dir . $wrap);
+ }
}
$t = new extSmarty;
|
|
From: Benjamin C. <bc...@us...> - 2002-05-08 12:59:15
|
Update of /cvsroot/phpbt/phpbt In directory usw-pr-cvs1:/tmp/cvs-serv31758 Modified Files: query.php Log Message: Fixes bug #545546 - Non-unique column names in the order by clause Index: query.php =================================================================== RCS file: /cvsroot/phpbt/phpbt/query.php,v retrieving revision 1.71 retrieving revision 1.72 diff -u -r1.71 -r1.72 --- query.php 13 Apr 2002 12:32:17 -0000 1.71 +++ query.php 8 May 2002 12:59:13 -0000 1.72 @@ -200,8 +200,8 @@ 'owner' => 'owner', 'reporter' => 'reporter', 'lastmodifier' => 'last_modifier', - 'created_date' => 'created_date', - 'last_modified_date' => 'last_modified_date', + 'created_date' => 'b.created_date', + 'last_modified_date' => 'b.last_modified_date', 'project_name' => 'project_name', 'component_name' => 'component_name', 'version_name' => 'version_name', |
|
From: Benjamin C. <bc...@us...> - 2002-05-08 12:57:22
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv30935
Modified Files:
bug.php
Log Message:
Added some error handling for the database object
Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.103
retrieving revision 1.104
diff -u -r1.103 -r1.104
--- bug.php 7 May 2002 15:34:03 -0000 1.103
+++ bug.php 8 May 2002 12:57:18 -0000 1.104
@@ -509,7 +509,11 @@
// Create a new db connection because of the limit query affecting later queries
$db = DB::Connect($dsn);
+ if (DB::isError($db)) {
+ die($db->message.'<br>'.$db->userinfo);
+ }
$db->setOption('optimize', 'portability');
+ $db->setErrorHandling(PEAR_ERROR_CALLBACK, "handle_db_error");
if (!isset($_sv['queryinfo']['query']) || !$_sv['queryinfo']['query']) {
return array('', '');
|
|
From: Ben C. <php...@be...> - 2002-05-08 12:41:06
|
Let's address this after 0.8.2. On Tue, May 07, 2002 at 03:13:15PM -0000, Jirka Pech wrote: > > Greater than and less than signs should be translated to their html > > entity equivalents on output. If this isn't happening in the bug > > comments or elsewhere then it should be fixed. > > There is line #360 in bug.php, where it is fixed for comments, but > commented now. I think, it'll be better to have configuration option for > it. But there are other scipts/templates, which are displaying something. > The question is: "To fix it before or after release 0.8.2?" > > Jirka > > _______________________________________________________________ > > Have big pipes? SourceForge.net is looking for download mirrors. We supply > the hardware. You get the recognition. Email Us: ban...@so... > _______________________________________________ > phpbt-dev mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpbt-dev |
|
From: Benjamin C. <bc...@us...> - 2002-05-08 01:10:03
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory usw-pr-cvs1:/tmp/cvs-serv23782/default/admin
Modified Files:
component-edit.html configure.html group-edit.html
grouplist.html os-edit.html oslist.html project-edit.html
projectlist.html resolution-edit.html resolutionlist.html
severity-edit.html severitylist.html status-edit.html
statuslist.html userlist.html version-edit.html
Log Message:
Fixes bug #553239 - Use PHP_SELF instead of SCRIPT_NAME
Index: component-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/component-edit.html,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- component-edit.html 11 Apr 2002 16:08:05 -0000 1.2
+++ component-edit.html 8 May 2002 01:10:00 -0000 1.3
@@ -11,7 +11,7 @@
<b>{$page_title}</b>
<hr size="1">
{if $error}<div class="error">{$error}</div>{/if}
- <form action="{$SCRIPT_NAME}" method="post">
+ <form action="{$smarty.server.PHP_SELF}" method="post">
<table border="0">
<input type="hidden" name="do" value="component">
<input type="hidden" name="componentid" value="{$component_id}">
Index: configure.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/configure.html,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- configure.html 3 Apr 2002 00:57:10 -0000 1.3
+++ configure.html 8 May 2002 01:10:00 -0000 1.4
@@ -1,5 +1,5 @@
{include file="admin/header.html" page_title="Configuration"}
-<form action="{$SCRIPT_NAME}" method="post">
+<form action="{$smarty.server.PHP_SELF}" method="post">
<table border="0" width="640">
<tr>
<td valign="top">
Index: group-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/group-edit.html,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- group-edit.html 3 Apr 2002 00:57:10 -0000 1.1
+++ group-edit.html 8 May 2002 01:10:00 -0000 1.2
@@ -10,7 +10,7 @@
{/if}
<b>{$action} Group </b>
<hr size="1">
-<form action="{$SCRIPT_NAME}" method="post">
+<form action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="group_id" value="{$group_id}">
<input type="hidden" name="use_js" value="{$smarty.request.use_js}">
<table border='0'>
Index: grouplist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/grouplist.html,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- grouplist.html 7 May 2002 11:36:06 -0000 1.4
+++ grouplist.html 8 May 2002 01:10:00 -0000 1.5
@@ -2,7 +2,7 @@
<script language="JavaScript">
<!--
- var me = '{$SCRIPT_NAME}';
+ var me = '{$smarty.server.PHP_SELF}';
{literal}
function popupGroup(id) {
@@ -14,7 +14,7 @@
<table border="0" width="100%">
<tr>
<td valign="top">
- <b> Group List</b> - <a href="{$SCRIPT_NAME}?op=edit&group_id=0" onClick="popupGroup(0); return false;">{$STRING.addnew} Group</a>
+ <b> Group List</b> - <a href="{$smarty.server.PHP_SELF}?op=edit&group_id=0" onClick="popupGroup(0); return false;">{$STRING.addnew} Group</a>
<hr size="1">
<table border="0" width="100%">
<tr>
@@ -24,14 +24,14 @@
</tr>
{section name=group loop=$groups}
<tr{if $smarty.section.group.iteration is even} class="alt"{/if}>
- <td><a href="{$SCRIPT_NAME}?op=edit&group_id={$groups[group].group_id}" onClick="popupGroup({$groups[group].group_id}); return false;">{$groups[group].group_name|stripslashes}</a></td>
+ <td><a href="{$smarty.server.PHP_SELF}?op=edit&group_id={$groups[group].group_id}" onClick="popupGroup({$groups[group].group_id}); return false;">{$groups[group].group_name|stripslashes}</a></td>
<td align="center">{$groups[group].count}</td>
<td align="center">
{if $groups[group].locked}
Locked
{else}
- <a href="{$SCRIPT_NAME}?op=del&group_id={$groups[group].group_id}" onClick="return confirm('This will remove all user assignments to this group and the group itself. Continue?')">Delete</a> |
- <a href="{$SCRIPT_NAME}?op=purge&group_id={$groups[group].group_id}" onClick="return confirm('This will remove all user assignments to this group. Continue?')">Purge</a>
+ <a href="{$smarty.server.PHP_SELF}?op=del&group_id={$groups[group].group_id}" onClick="return confirm('This will remove all user assignments to this group and the group itself. Continue?')">Delete</a> |
+ <a href="{$smarty.server.PHP_SELF}?op=purge&group_id={$groups[group].group_id}" onClick="return confirm('This will remove all user assignments to this group. Continue?')">Purge</a>
{/if}
</td>
</tr>
Index: os-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/os-edit.html,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- os-edit.html 3 Apr 2002 18:24:48 -0000 1.2
+++ os-edit.html 8 May 2002 01:10:00 -0000 1.3
@@ -10,7 +10,7 @@
{/if}
<b>{$action} OS </b>
<hr size="1">
-<form action="{$SCRIPT_NAME}" method="post">
+<form action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="os_id" value="{$os_id}">
<input type="hidden" name="use_js" value="{$smarty.request.use_js}">
<table border='0'>
Index: oslist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/oslist.html,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- oslist.html 7 May 2002 11:37:29 -0000 1.7
+++ oslist.html 8 May 2002 01:10:00 -0000 1.8
@@ -2,7 +2,7 @@
<script language="JavaScript">
<!--
- var me = '{$SCRIPT_NAME}';
+ var me = '{$smarty.server.PHP_SELF}';
{literal}
function popupOS(id) {
@@ -14,7 +14,7 @@
<table border="0" width="100%">
<tr>
<td valign="top">
- <b> OS List</b> - <a href="{$SCRIPT_NAME}?op=edit&os_id=0" onClick="popupOS(0); return false;">{$STRING.addnew} OS</a>
+ <b> OS List</b> - <a href="{$smarty.server.PHP_SELF}?op=edit&os_id=0" onClick="popupOS(0); return false;">{$STRING.addnew} OS</a>
<hr size="1">
<table border="0" cellpadding="2" cellspacing="1" width="100%">
<tr>
@@ -25,12 +25,12 @@
</tr>
{section name=os loop=$oses}
<tr{if $smarty.section.os.iteration is even} class="alt"{/if}>
- <td><a href="{$SCRIPT_NAME}?op=edit&os_id={$oses[os].os_id}" onClick="popupOS({$oses[os].os_id}); return false;">{$oses[os].os_name|stripslashes}</a></td>
+ <td><a href="{$smarty.server.PHP_SELF}?op=edit&os_id={$oses[os].os_id}" onClick="popupOS({$oses[os].os_id}); return false;">{$oses[os].os_name|stripslashes}</a></td>
<td> {$oses[os].regex}</td>
<td align="center">{$oses[os].sort_order}</td>
<td align="center">
{if not $oses[os].bug_count}
- <a href="{$SCRIPT_NAME}?op=del&os_id={$oses[os].os_id}" onClick="return confirm('Are you sure you want to delete this OS?')">Delete</a>
+ <a href="{$smarty.server.PHP_SELF}?op=del&os_id={$oses[os].os_id}" onClick="return confirm('Are you sure you want to delete this OS?')">Delete</a>
{/if}
</td>
</tr>
Index: project-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/project-edit.html,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- project-edit.html 7 May 2002 11:44:11 -0000 1.8
+++ project-edit.html 8 May 2002 01:10:00 -0000 1.9
@@ -2,7 +2,7 @@
<script language="JavaScript">
<!--
- var me = '{$SCRIPT_NAME}';
+ var me = '{$smarty.server.PHP_SELF}';
var projectId = '{$project_id}';
{literal}
@@ -19,7 +19,7 @@
// -->
</script>
-<form action="{$SCRIPT_NAME}" method="post">
+<form action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="id" value="{$project_id}">
<input type="hidden" name="do" value="project">
<table border="0" cellpadding="2" cellspacing="2" width="100%">
@@ -64,7 +64,7 @@
<tr>
<td width="50%" valign="top">
<br>
- <b>Versions</b> - <a href="{$SCRIPT_NAME}?op=edit_version&project_id={$project_id}&id=0" onClick="return popupVersion(0);">{$STRING.addnew} Version</a>
+ <b>Versions</b> - <a href="{$smarty.server.PHP_SELF}?op=edit_version&project_id={$project_id}&id=0" onClick="return popupVersion(0);">{$STRING.addnew} Version</a>
<hr size="1">
<table border="0" cellpadding="2" width="100%">
<tr>
@@ -75,10 +75,10 @@
</tr>
{section name=version loop=$versions}
<tr{if $smarty.section.version.iteration is even} class="alt"{/if}>
- <td><a href="{$SCRIPT_NAME}?op=edit_version&id={$versions[version].version_id}" onClick="popupVersion({$versions[version].version_id}); return false;">{$versions[version].version_name|stripslashes}</a></td>
+ <td><a href="{$smarty.server.PHP_SELF}?op=edit_version&id={$versions[version].version_id}" onClick="popupVersion({$versions[version].version_id}); return false;">{$versions[version].version_name|stripslashes}</a></td>
<td align="center">{$versions[version].created_date|date:DATE_FORMAT}</td>
<td align="center">{if $versions[version].active}Yes{else}No{/if}</td>
- <td align="center">{if not $versions[version].bug_count}<a href="{$SCRIPT_NAME}?op=del_version&id={$versions[version].version_id}&project_id={$project_id}">Delete</a>{/if}</td>
+ <td align="center">{if not $versions[version].bug_count}<a href="{$smarty.server.PHP_SELF}?op=del_version&id={$versions[version].version_id}&project_id={$project_id}">Delete</a>{/if}</td>
</tr>
{sectionelse}
<tr>
@@ -89,7 +89,7 @@
</td>
<td width="50%" valign="top">
<br>
- <b>Components</b> - <a href="{$SCRIPT_NAME}?op=edit_component&project_id={$project_id}&id=0" onClick="return popupComponent(0);">{$STRING.addnew} Component</a>
+ <b>Components</b> - <a href="{$smarty.server.PHP_SELF}?op=edit_component&project_id={$project_id}&id=0" onClick="return popupComponent(0);">{$STRING.addnew} Component</a>
<hr size="1">
<table border="0" cellpadding="2" width="100%">
<tr>
@@ -100,10 +100,10 @@
</tr>
{section name=component loop=$components}
<tr{if $smarty.section.component.iteration is even} class="alt"{/if}>
- <td><a href="{$SCRIPT_NAME}?op=edit_component&id={$components[component].component_id}" onClick="popupComponent({$components[component].component_id}); return false;">{$components[component].component_name|stripslashes}</a></td>
+ <td><a href="{$smarty.server.PHP_SELF}?op=edit_component&id={$components[component].component_id}" onClick="popupComponent({$components[component].component_id}); return false;">{$components[component].component_name|stripslashes}</a></td>
<td align="center">{$components[component].created_date|date:DATE_FORMAT}</td>
<td align="center">{if $components[component].active}Yes{else}No{/if}</td>
- <td align="center">{if not $components[component].bug_count}<a href="{$SCRIPT_NAME}?op=del_component&id={$components[component].component_id}&project_id={$project_id}">Delete</a>{/if}</td>
+ <td align="center">{if not $components[component].bug_count}<a href="{$smarty.server.PHP_SELF}?op=del_component&id={$components[component].component_id}&project_id={$project_id}">Delete</a>{/if}</td>
</tr>
{sectionelse}
<tr>
Index: projectlist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/projectlist.html,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- projectlist.html 11 Apr 2002 16:08:05 -0000 1.5
+++ projectlist.html 8 May 2002 01:10:00 -0000 1.6
@@ -3,7 +3,7 @@
<table border="0" width="100%">
<tr>
<td valign="top">
- <b> Project List</b> - <a href="{$SCRIPT_NAME}?op=add">{$STRING.addnew} Project</a>
+ <b> Project List</b> - <a href="{$smarty.server.PHP_SELF}?op=add">{$STRING.addnew} Project</a>
<hr size="1">
<table border="0" cellpadding="2" cellspacing="1" width="100%">
<tr>
@@ -13,7 +13,7 @@
</tr>
{section name=project loop=$projects}
<tr{if $smarty.section.project.iteration is even} class="alt"{/if}>
- <td><a href="{$SCRIPT_NAME}?op=edit&id={$projects[project].project_id}">{$projects[project].project_name|stripslashes}</a></td>
+ <td><a href="{$smarty.server.PHP_SELF}?op=edit&id={$projects[project].project_id}">{$projects[project].project_name|stripslashes}</a></td>
<td align="center">{$projects[project].created_date|date:DATE_FORMAT}</td>
<td align="center">{if $projects[project].active}Yes{else}No{/if}</td>
</tr>
Index: resolution-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/resolution-edit.html,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- resolution-edit.html 3 Apr 2002 18:24:48 -0000 1.1
+++ resolution-edit.html 8 May 2002 01:10:00 -0000 1.2
@@ -10,7 +10,7 @@
{/if}
<b>{$action} Resolution </b>
<hr size="1">
-<form action="{$SCRIPT_NAME}" method="post">
+<form action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="resolution_id" value="{$resolution_id}">
<input type="hidden" name="use_js" value="{$smarty.request.use_js}">
<table border='0'>
Index: resolutionlist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/resolutionlist.html,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- resolutionlist.html 7 May 2002 11:44:11 -0000 1.9
+++ resolutionlist.html 8 May 2002 01:10:00 -0000 1.10
@@ -2,7 +2,7 @@
<script language="JavaScript">
<!--
- var me = '{$SCRIPT_NAME}';
+ var me = '{$smarty.server.PHP_SELF}';
{literal}
function popupResolution(id) {
@@ -14,7 +14,7 @@
<table border="0" width="100%">
<tr>
<td valign="top">
- <b> Resolution List</b> - <a href="{$SCRIPT_NAME}?op=edit&resolution_id=0" onClick="popupResolution(0); return false;">{$STRING.addnew} Resolution</a>
+ <b> Resolution List</b> - <a href="{$smarty.server.PHP_SELF}?op=edit&resolution_id=0" onClick="popupResolution(0); return false;">{$STRING.addnew} Resolution</a>
<hr size="1">
<table border="0" cellpadding="2" cellspacing="1">
<tr>
@@ -25,12 +25,12 @@
</tr>
{section name=resolution loop=$resolutions}
<tr{if $smarty.section.resolution.iteration is even} class="alt"{/if}>
- <td><a href="{$SCRIPT_NAME}?op=edit&resolution_id={$resolutions[resolution].resolution_id}" onClick="popupResolution({$resolutions[resolution].resolution_id}); return false;">{$resolutions[resolution].resolution_name|stripslashes}</a></td>
+ <td><a href="{$smarty.server.PHP_SELF}?op=edit&resolution_id={$resolutions[resolution].resolution_id}" onClick="popupResolution({$resolutions[resolution].resolution_id}); return false;">{$resolutions[resolution].resolution_name|stripslashes}</a></td>
<td> {$resolutions[resolution].resolution_desc}</td>
<td align="center">{$resolutions[resolution].sort_order}</td>
<td align="center">
{if not $resolutions[resolution].bug_count}
- <a href="{$SCRIPT_NAME}?op=del&resolution_id={$resolutions[resolution].resolution_id}" onClick="return confirm('Are you sure you want to delete this resolution?')">Delete</a>
+ <a href="{$smarty.server.PHP_SELF}?op=del&resolution_id={$resolutions[resolution].resolution_id}" onClick="return confirm('Are you sure you want to delete this resolution?')">Delete</a>
{/if}
</td>
</tr>
Index: severity-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/severity-edit.html,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- severity-edit.html 3 Apr 2002 00:57:10 -0000 1.1
+++ severity-edit.html 8 May 2002 01:10:00 -0000 1.2
@@ -10,7 +10,7 @@
{/if}
<b>{$action} Severity </b>
<hr size="1">
-<form action="{$SCRIPT_NAME}" method="post">
+<form action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="severity_id" value="{$severity_id}">
<input type="hidden" name="use_js" value="{$smarty.request.use_js}">
<table border='0'>
Index: severitylist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/severitylist.html,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- severitylist.html 7 May 2002 11:44:11 -0000 1.7
+++ severitylist.html 8 May 2002 01:10:00 -0000 1.8
@@ -2,7 +2,7 @@
<script language="JavaScript">
<!--
- var me = '{$SCRIPT_NAME}';
+ var me = '{$smarty.server.PHP_SELF}';
{literal}
function popupSeverity(id) {
@@ -14,7 +14,7 @@
<table border="0" width="100%">
<tr>
<td valign="top">
- <b> Severity List</b> - <a href="{$SCRIPT_NAME}?op=edit&severity_id=0" onClick="popupSeverity(0); return false;">{$STRING.addnew} Severity</a>
+ <b> Severity List</b> - <a href="{$smarty.server.PHP_SELF}?op=edit&severity_id=0" onClick="popupSeverity(0); return false;">{$STRING.addnew} Severity</a>
<hr size="1">
<table border="0" cellpadding="2" cellspacing="1" width="100%">
<tr>
@@ -25,12 +25,12 @@
</tr>
{section name=severity loop=$severities}
<tr{if $smarty.section.severity.iteration is even} class="alt"{/if}>
- <td><a href="{$SCRIPT_NAME}?op=edit&severity_id={$severities[severity].severity_id}" onClick="popupSeverity({$severities[severity].severity_id}); return false;">{$severities[severity].severity_name|stripslashes}</a></td>
+ <td><a href="{$smarty.server.PHP_SELF}?op=edit&severity_id={$severities[severity].severity_id}" onClick="popupSeverity({$severities[severity].severity_id}); return false;">{$severities[severity].severity_name|stripslashes}</a></td>
<td> {$severities[severity].severity_desc}</td>
<td align="center">{$severities[severity].sort_order}</td>
<td align="center">
{if not $severities[severity].bug_count}
- <a href="{$SCRIPT_NAME}?op=del&severity_id={$severities[severity].severity_id}" onClick="return confirm('Are you sure you want to delete this severity?')">Delete</a>
+ <a href="{$smarty.server.PHP_SELF}?op=del&severity_id={$severities[severity].severity_id}" onClick="return confirm('Are you sure you want to delete this severity?')">Delete</a>
{/if}
</td>
</tr>
Index: status-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/status-edit.html,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- status-edit.html 3 Apr 2002 00:57:10 -0000 1.1
+++ status-edit.html 8 May 2002 01:10:00 -0000 1.2
@@ -10,7 +10,7 @@
{/if}
<b>{$action} Status </b>
<hr size="1">
-<form action="{$SCRIPT_NAME}" method="post">
+<form action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="status_id" value="{$status_id}">
<input type="hidden" name="use_js" value="{$smarty.request.use_js}">
<table border='0'>
Index: statuslist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/statuslist.html,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- statuslist.html 7 May 2002 11:44:11 -0000 1.7
+++ statuslist.html 8 May 2002 01:10:00 -0000 1.8
@@ -2,7 +2,7 @@
<script language="JavaScript">
<!--
- var me = '{$SCRIPT_NAME}';
+ var me = '{$smarty.server.PHP_SELF}';
{literal}
function popupStatus(id) {
@@ -14,7 +14,7 @@
<table border="0" width="100%">
<tr>
<td valign="top">
- <b> Status List</b> - <a href="{$SCRIPT_NAME}?op=edit&status_id=0" onClick="popupStatus(0); return false;">{$STRING.addnew} Status</a>
+ <b> Status List</b> - <a href="{$smarty.server.PHP_SELF}?op=edit&status_id=0" onClick="popupStatus(0); return false;">{$STRING.addnew} Status</a>
<hr size="1">
<table border="0" cellpadding="2" cellspacing="1" width="100%">
<tr>
@@ -25,12 +25,12 @@
</tr>
{section name=status loop=$statuses}
<tr{if $smarty.section.status.iteration is even} class="alt"{/if}>
- <td><a href="{$SCRIPT_NAME}?op=edit&status_id={$statuses[status].status_id}" onClick="popupStatus({$statuses[status].status_id}); return false;">{$statuses[status].status_name|stripslashes}</a></td>
+ <td><a href="{$smarty.server.PHP_SELF}?op=edit&status_id={$statuses[status].status_id}" onClick="popupStatus({$statuses[status].status_id}); return false;">{$statuses[status].status_name|stripslashes}</a></td>
<td> {$statuses[status].status_desc}</td>
<td align="center">{$statuses[status].sort_order}</td>
<td align="center">
{if not $statuses[status].bug_count}
- <a href="{$SCRIPT_NAME}?op=del&status_id={$statuses[status].status_id}" onClick="return confirm('Are you sure you want to delete this status?')">Delete</a>
+ <a href="{$smarty.server.PHP_SELF}?op=del&status_id={$statuses[status].status_id}" onClick="return confirm('Are you sure you want to delete this status?')">Delete</a>
{/if}
</td>
</tr>
Index: userlist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/userlist.html,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- userlist.html 2 May 2002 08:35:38 -0000 1.9
+++ userlist.html 8 May 2002 01:10:00 -0000 1.10
@@ -2,7 +2,7 @@
<script language="JavaScript">
<!--
- var me = '{$SCRIPT_NAME}';
+ var me = '{$smarty.server.PHP_SELF}';
{literal}
function popupUser(id) {
@@ -14,11 +14,11 @@
<table border="0" width="100%">
<tr>
<td valign="top">
- <b> User List</b> - <a href="{$SCRIPT_NAME}?op=edit&user_id=0&filter={$filter}" onClick="popupUser(0); return false;">{$STRING.addnew} User</a>
+ <b> User List</b> - <a href="{$smarty.server.PHP_SELF}?op=edit&user_id=0&filter={$filter}" onClick="popupUser(0); return false;">{$STRING.addnew} User</a>
<hr size="1">
<form>
<div align="center">
- <select name="filter" onChange="document.location.href='{$SCRIPT_NAME}?filter=' + this.options[this.selectedIndex].value">{build_select box=user_filter selected=$filter}</select>
+ <select name="filter" onChange="document.location.href='{$smarty.server.PHP_SELF}?filter=' + this.options[this.selectedIndex].value">{build_select box=user_filter selected=$filter}</select>
<input type="submit" value="Filter">
</div>
</form>
@@ -31,7 +31,7 @@
</tr>
{section name=user loop=$users}
<tr{if $smarty.section.user.iteration is even} class="alt"{/if}>
- <td><a href="{$SCRIPT_NAME}?op=edit&user_id={$users[user].user_id}&filter={$filter}" onClick="popupUser({$users[user].user_id}); return false;">{$users[user].login|stripslashes}</a></td>
+ <td><a href="{$smarty.server.PHP_SELF}?op=edit&user_id={$users[user].user_id}&filter={$filter}" onClick="popupUser({$users[user].user_id}); return false;">{$users[user].login|stripslashes}</a></td>
<td align="center">{$users[user].first_name|stripslashes} {$users[user].last_name|stripslashes}</td>
<td align="center">{$users[user].created_date|date:DATE_FORMAT}</td>
<td align="center">{if $users[user].active}Yes{else}No{/if}</td>
Index: version-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/version-edit.html,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- version-edit.html 11 Apr 2002 16:08:05 -0000 1.2
+++ version-edit.html 8 May 2002 01:10:00 -0000 1.3
@@ -11,7 +11,7 @@
<b>{$page_title}</b>
<hr size="1">
{if $error}<div class="error">{$error}</div>{/if}
- <form action="{$SCRIPT_NAME}" method="post">
+ <form action="{$smarty.server.PHP_SELF}" method="post">
<table border="0">
<input type="hidden" name="do" value="version">
<input type="hidden" name="versionid" value="{$version_id}">
|
|
From: Benjamin C. <bc...@us...> - 2002-05-08 01:10:03
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv23782/default
Modified Files:
bugattachmentform.html bugdisplay-printable.html
bugdisplay.html bughistory.html bugvotes.html install.html
newaccount.html queryform-simple.html queryform.html
report.html user.html
Log Message:
Fixes bug #553239 - Use PHP_SELF instead of SCRIPT_NAME
Index: bugattachmentform.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugattachmentform.html,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- bugattachmentform.html 11 Apr 2002 15:49:58 -0000 1.5
+++ bugattachmentform.html 8 May 2002 01:10:00 -0000 1.6
@@ -2,8 +2,8 @@
{include file="header-popup.html" page_title="Add Attachment"}
{else}
{include file="header.html" page_title="Add Attachment"}
-{/if}
-<form enctype="multipart/form-data" action="{$SCRIPT_NAME}" method="post">
+{/if}
+<form enctype="multipart/form-data" action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="bugid" value="{$bugid}">
<input type="hidden" name="use_js" value="{$smarty.request.use_js}">
<table border="0" align="center">
@@ -48,4 +48,4 @@
{include file="admin/footer-popup.html"}
{else}
{include file="admin/footer.html"}
-{/if}
+{/if}
Index: bugdisplay-printable.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugdisplay-printable.html,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- bugdisplay-printable.html 6 Apr 2002 23:47:59 -0000 1.5
+++ bugdisplay-printable.html 8 May 2002 01:10:00 -0000 1.6
@@ -129,8 +129,7 @@
{/section}
</table>
<br>
-<a href="{$SCRIPT_NAME}?op=show&bugid={$bug_id}">Back to bug #{$bug_id}</a>
+<a href="{$smarty.server.PHP_SELF}?op=show&bugid={$bug_id}">Back to bug #{$bug_id}</a>
<br>
<br>
-
{include file="footer.html"}
Index: bugdisplay.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugdisplay.html,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- bugdisplay.html 8 May 2002 00:46:06 -0000 1.29
+++ bugdisplay.html 8 May 2002 01:10:00 -0000 1.30
@@ -219,10 +219,10 @@
</form>
<div align="center">
{if !empty($error.vote)}<div class="error">{$error.vote}</div>{/if}
-<b><a href="{$SCRIPT_NAME}?op=vote&bugid={$bug_id}" onClick="if ({$already_voted}) {literal}{ alert ('{/literal}{$STRING.already_voted}{literal}'); return false; }{/literal}">Vote for this bug</a></b> |
-<b><a href="{$SCRIPT_NAME}?op=viewvotes&bugid={$bug_id}">View votes ({$num_votes}) for this bug</a></b> |
-<b><a href="{$SCRIPT_NAME}?op=history&bugid={$bug_id}">View bug activity</a></b> |
-<b><a href="{$SCRIPT_NAME}?op=print&bugid={$bug_id}">Printable view</a></b>
+<b><a href="{$smarty.server.PHP_SELF}?op=vote&bugid={$bug_id}" onClick="if ({$already_voted}) {literal}{ alert ('{/literal}{$STRING.already_voted}{literal}'); return false; }{/literal}">Vote for this bug</a></b> |
+<b><a href="{$smarty.server.PHP_SELF}?op=viewvotes&bugid={$bug_id}">View votes ({$num_votes}) for this bug</a></b> |
+<b><a href="{$smarty.server.PHP_SELF}?op=history&bugid={$bug_id}">View bug activity</a></b> |
+<b><a href="{$smarty.server.PHP_SELF}?op=print&bugid={$bug_id}">Printable view</a></b>
</div>
<br>
<br>
Index: bughistory.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bughistory.html,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- bughistory.html 3 Apr 2002 00:57:51 -0000 1.2
+++ bughistory.html 8 May 2002 01:10:00 -0000 1.3
@@ -22,7 +22,7 @@
{/section}
</table>
<br>
-<a href="{$SCRIPT_NAME}?op=show&bugid={$smarty.get.bugid}">Back to bug #{$smarty.get.bugid}</a>
+<a href="{$smarty.server.PHP_SELF}?op=show&bugid={$smarty.get.bugid}">Back to bug #{$smarty.get.bugid}</a>
<br>
<br>
{include file="footer.html"}
Index: bugvotes.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugvotes.html,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- bugvotes.html 3 Apr 2002 00:57:51 -0000 1.2
+++ bugvotes.html 8 May 2002 01:10:00 -0000 1.3
@@ -16,7 +16,7 @@
{/section}
</table>
<br>
-<a href="{$SCRIPT_NAME}?op=show&bugid={$smarty.get.bugid}">Back to bug #{$smarty.get.bugid}</a>
+<a href="{$smarty.server.PHP_SELF}?op=show&bugid={$smarty.get.bugid}">Back to bug #{$smarty.get.bugid}</a>
<br>
<br>
{include file="footer.html"}
Index: install.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/install.html,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- install.html 11 Apr 2002 20:29:34 -0000 1.6
+++ install.html 8 May 2002 01:10:00 -0000 1.7
@@ -3,7 +3,7 @@
<link rel="StyleSheet" href="styles/default.css" type="text/css">
</head>
<body bgcolor="#ffffff" link="#006699" vlink="#006699" alink="#006699">
-<form action="{$SCRIPT_NAME}" method="post">
+<form action="{$smarty.server.PHP_SELF}" method="post">
<table border="0" cellpadding="0" cellspacing="0" width="640">
<tr>
<td width="200" valign="top"><br><img src="logo.jpg"></td>
Index: newaccount.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/newaccount.html,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- newaccount.html 3 Apr 2002 18:54:08 -0000 1.4
+++ newaccount.html 8 May 2002 01:10:00 -0000 1.5
@@ -1,6 +1,6 @@
{include file="header.html" page_title="Create a New Account"}
<h2>Create a new account</h2>
-<form action="{$SCRIPT_NAME}" method="post">
+<form action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="createaccount" value="1">
<table border="0">
{if $error}
Index: queryform-simple.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/queryform-simple.html,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- queryform-simple.html 3 Apr 2002 00:57:51 -0000 1.2
+++ queryform-simple.html 8 May 2002 01:10:00 -0000 1.3
@@ -87,6 +87,6 @@
<input type="submit" value="Submit query">
</form>
<br>
- Go to the <a href="{$SCRIPT_NAME}?op=query&form=advanced">advanced query page</a>
+ Go to the <a href="{$smarty.server.PHP_SELF}?op=query&form=advanced">advanced query page</a>
{include file="footer.html"}
Index: queryform.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/queryform.html,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- queryform.html 3 Apr 2002 00:57:51 -0000 1.8
+++ queryform.html 8 May 2002 01:10:00 -0000 1.9
@@ -224,12 +224,12 @@
<b>Saved Queries</b>
<br>
{section name=query loop=$queries}
- <a href="{$SCRIPT_NAME}?{$queries[query].saved_query_string}">{$queries[query].saved_query_name}</a> (<a href="{$SCRIPT_NAME}?op=delquery&queryid={$queries[query].saved_query_id}" onClick="return confirm('Are you sure you want to delete this saved query?');">Delete</a>)<br>
+ <a href="{$smarty.server.PHP_SELF}?{$queries[query].saved_query_string}">{$queries[query].saved_query_name}</a> (<a href="{$smarty.server.PHP_SELF}?op=delquery&queryid={$queries[query].saved_query_id}" onClick="return confirm('Are you sure you want to delete this saved query?');">Delete</a>)<br>
{/section}
{/if}
</form>
<br>
- Go to the <a href="{$SCRIPT_NAME}?op=query">simple query page</a>
+ Go to the <a href="{$smarty.server.PHP_SELF}?op=query">simple query page</a>
{include file="footer.html"}
Index: report.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/report.html,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- report.html 3 Apr 2002 00:57:51 -0000 1.6
+++ report.html 8 May 2002 01:10:00 -0000 1.7
@@ -1,7 +1,7 @@
{include file="header.html" page_title="Home"}
-<form action="{$SCRIPT_NAME}">
+<form action="{$smarty.server.PHP_SELF}">
Bug statistics for
-<select name="projectid" onChange="document.location.href='{$SCRIPT_NAME}?projectid='+this.options[this.selectedIndex].value">
+<select name="projectid" onChange="document.location.href='{$smarty.server.PHP_SELF}?projectid='+this.options[this.selectedIndex].value">
<option value="0">All projects</option>
{build_select box=project selected=$smarty.get.projectid}
</select>
Index: user.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/user.html,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- user.html 3 Apr 2002 19:01:04 -0000 1.6
+++ user.html 8 May 2002 01:10:00 -0000 1.7
@@ -1,7 +1,7 @@
{include file="header.html" page_title="User Page"}
<table border="0" cellpadding="0" cellspacing="0" width="600">
<td width="300" valign="top">
- <form action="{$SCRIPT_NAME}" method="post">
+ <form action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="do" value="changepassword">
<table border="0" cellpadding="0" cellspacing="0" width="300">
<tr>
@@ -34,7 +34,7 @@
</form>
</td>
<td width="300" valign="top">
- <form action="{$SCRIPT_NAME}" method="post">
+ <form action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="do" value="changeprefs">
<table border="0" cellpadding="0" cellspacing="0" width="300">
<tr>
@@ -61,7 +61,7 @@
</td>
</table>
<br>
-<form action="{$SCRIPT_NAME}" method="post">
+<form action="{$smarty.server.PHP_SELF}" method="post">
<input type="hidden" name="do" value="changecolumnlist">
<table border="0" cellpadding="0" cellspacing="0" width="300">
<td width="300">
@@ -102,7 +102,7 @@
<tr{if $smarty.section.vote.iteration is even} class="alt"{/if}>
<td align="center"><a href="bug.php?op=show&bugid={$votes[vote].bug_id}">#{$votes[vote].bug_id}</a></td>
<td align="center">{$votes[vote].created_date|date:DATE_FORMAT}</td>
- <td align="center"><a href="{$SCRIPT_NAME}?op=delvote&bugid={$votes[vote].bug_id}" onClick="return confirm('Are you sure you want to delete this vote?');">Delete</a></td>
+ <td align="center"><a href="{$smarty.server.PHP_SELF}?op=delvote&bugid={$votes[vote].bug_id}" onClick="return confirm('Are you sure you want to delete this vote?');">Delete</a></td>
</tr>
{/section}
</table>
|
|
From: Benjamin C. <bc...@us...> - 2002-05-08 00:46:08
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv18784/templates/default
Modified Files:
bugdisplay.html
Log Message:
Fixes bug #553285 - Permission check for attachment delete link was throwing an error when not logged in
Index: bugdisplay.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugdisplay.html,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- bugdisplay.html 7 May 2002 11:44:11 -0000 1.28
+++ bugdisplay.html 8 May 2002 00:46:06 -0000 1.29
@@ -194,7 +194,7 @@
<td align="center">{$attachments[attachment].created_date|date:DATE_FORMAT}</td>
<td align="center">
<a href='attachment.php?attachid={$attachments[attachment].attachment_id}'>View</a>
- {if $perm->have_perm('Administrator')}
+ {if isset($perm) and $perm->have_perm('Administrator')}
| <a href='attachment.php?del={$attachments[attachment].attachment_id}' onClick="return confirm('Are you sure you want to delete this attachment?');">Delete</a>
{/if}
</td>
|
|
From: Jirka P. <fi...@us...> - 2002-05-07 16:30:12
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv23976/phpbt
Modified Files:
bug.php
Log Message:
Added URI protocols.
Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.102
retrieving revision 1.103
diff -u -r1.102 -r1.103
--- bug.php 7 May 2002 12:54:50 -0000 1.102
+++ bug.php 7 May 2002 15:34:03 -0000 1.103
@@ -278,10 +278,15 @@
foreach ($_pv as $k => $v) {
$$k = $v;
if ($k == 'url') {
- if ($v == 'http://') $v = '';
- elseif ($v and substr($v,0,7) != 'http://') $v = 'http://'.$v;
- $url = $v;
+
+ if (($v == 'http://') || ($v == 'https://')) {
+ $v = '';
+ } elseif (($v) && (strtolower(substr($v,0,7)) != 'http://') && (strtolower(substr($v,0,8)) != 'https://') && (strtolower(substr($v,0,6)) != 'ftp://')) {
+ $v = 'http://'.$v;
+ }
+ $url = $v;
}
+
if (isset($buginfo[$k]) && stripslashes($buginfo[$k]) != stripslashes($v)) {
$changedfields[$k] = $v;
}
@@ -400,7 +405,9 @@
while (list($k,$v) = each($_pv)) $$k = $v;
- if ($url == 'http://') $url = '';
+ if ($url == 'http://') {
+ $url = '';
+ }
// Allow for removing of some items from the bug page
$priority = $priority ? $priority : 0;
|
|
From: Jirka P. <fi...@us...> - 2002-05-07 15:13:20
|
> Greater than and less than signs should be translated to their html > entity equivalents on output. If this isn't happening in the bug > comments or elsewhere then it should be fixed. There is line #360 in bug.php, where it is fixed for comments, but commented now. I think, it'll be better to have configuration option for it. But there are other scipts/templates, which are displaying something. The question is: "To fix it before or after release 0.8.2?" Jirka |
|
From: Ben C. <php...@be...> - 2002-05-07 15:05:01
|
Greater than and less than signs should be translated to their html entity equivalents on output. If this isn't happening in the bug comments or elsewhere then it should be fixed. On Tue, May 07, 2002 at 02:31:37PM -0000, Jirka Pech wrote: > > My goal is to have it out by the end of the week. When it is released > I'll > > tag it so that we can branch it properly for patches vs. new > developments. > > Thanks for asking! > > There may be a problem with special characters like "greater than" ">" and > "lesser than" "<". You probably know, what I'm talking about. When you add > a comment to bug with javascript in proper tag, it's executed on client > side. When you submit something with unclosed "lesser than", the tag will > begin and one tag after it will be lost. > > If you want it to be repaired/fixed (sorry for my english) before release > 0.8.2, please, tell me, because it's security related and I'm too young to > be sure if it is clever to release software with holes. > > I'm planning one cosmetic change, before release 0.8.2. I'll do it later > today. Then I'll stop changing anything until release 0.8.2. > > Jirka > > _______________________________________________________________ > > Have big pipes? SourceForge.net is looking for download mirrors. We supply > the hardware. You get the recognition. Email Us: ban...@so... > _______________________________________________ > phpbt-dev mailing list > php...@li... > https://lists.sourceforge.net/lists/listinfo/phpbt-dev |
|
From: Jirka P. <ben...@ya...> - 2002-05-07 14:31:40
|
> My goal is to have it out by the end of the week. When it is released I'll > tag it so that we can branch it properly for patches vs. new developments. > Thanks for asking! There may be a problem with special characters like "greater than" ">" and "lesser than" "<". You probably know, what I'm talking about. When you add a comment to bug with javascript in proper tag, it's executed on client side. When you submit something with unclosed "lesser than", the tag will begin and one tag after it will be lost. If you want it to be repaired/fixed (sorry for my english) before release 0.8.2, please, tell me, because it's security related and I'm too young to be sure if it is clever to release software with holes. I'm planning one cosmetic change, before release 0.8.2. I'll do it later today. Then I'll stop changing anything until release 0.8.2. Jirka |
|
From: Jirka P. <fi...@us...> - 2002-05-07 13:43:42
|
Update of /cvsroot/phpbt/phpbt/languages In directory usw-pr-cvs1:/tmp/cvs-serv10071/phpbt/languages Modified Files: cz_iso-8859-2.php cz.php Log Message: Made some translations and corrections. Also updated copyright. Index: cz_iso-8859-2.php =================================================================== RCS file: /cvsroot/phpbt/phpbt/languages/cz_iso-8859-2.php,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- cz_iso-8859-2.php 7 May 2002 12:56:04 -0000 1.1 +++ cz_iso-8859-2.php 7 May 2002 13:43:38 -0000 1.2 @@ -1,6 +1,6 @@ <?php -// cz.php - Czech strings and titles +// cz.php - Czech strings and titles encoded in iso-8859-2 codepage // ------------------------------------------------------------------------ // Copyright (c) 2002 The phpBugTracker Group // ------------------------------------------------------------------------ @@ -32,16 +32,16 @@ 'noprojects' => 'Projekt nebyl nalezen', 'totalbugs' => 'Celkovì chyb', 'giveemail' => 'Prosím vlo¾te správnou e-mailovou adresu', - 'givelogin' => 'prosím vlo¾te login (u¾ivatelské jméno)', + 'givelogin' => 'Prosím vlo¾te login (u¾ivatelské jméno)', 'loginused' => 'Tento login ji¾ u¾ívá nìkdo jiný', 'newacctsubject' => 'phpBugTracker Pøihlá¹ení', - 'newacctmessage' => "Vá¹e phpBugTracker heslo je %s", + 'newacctmessage' => "Va¹e phpBugTracker heslo je %s", 'nobugs' => 'Nenalezeny ¾ádné chyby', 'givename' => 'Prosím vlo¾te jméno', 'edit' => 'Upravit', 'addnew' => 'Pøidat', 'nooses' => 'Nenalezen OS', - 'giveinitversion' => 'Prosím vlo¾te poèáteèní verzi projektu ', + 'giveinitversion' => 'Prosím vlo¾te poèáteèní verzi projektu', 'giveversion' => 'Prosím vlo¾te verzi', 'noversions' => 'Verze nenalezena', 'nocomponents' => 'Komponenta nenalezena', @@ -50,11 +50,11 @@ 'givepassword' => 'Prosím vlo¾te heslo', 'nousers' => 'U¾ivatel(é) nenalezen(i)', 'bugbadperm' => 'Nemù¾ete zmìnit BUG', - 'bugbadnum' => 'Tenhle BUG neexistuje', - 'datecollision' => 'Nìkdo aktualizoval BUG od Va¹í poslední náv¹tìvy. Do informací o BUGu byli zaneseny nejnovìj¹í zmìny', - 'passwordmatch' => 'Hesla nesouhlasí --prosím zadejte je znova', + 'bugbadnum' => 'Tento BUG neexistuje', + 'datecollision' => 'Nìkdo aktualizoval BUG od Va¹í poslední náv¹tìvy. Do informací o BUGu byli zaneseny nejnovìj¹í zmìny.', + 'passwordmatch' => 'Hesla nesouhlasí --prosím zadejte je znovu', 'nobughistory' => 'Tento BUG nemá hystorii', - 'logintomodify' => 'Musíte být zalogován pro upravu tohoto BUGu', + 'logintomodify' => 'Musíte být pøihlá¹en(a) pro upravu tohoto BUGu', 'dupe_attachment' => 'Pøíloha pro tento BUG je ji¾ nahrána', 'give_attachment' => 'Prosím vyberte soubor pro upload', 'no_attachment_save_path' => 'Cesta k ulo¾enému souboru nenalezena', @@ -62,19 +62,19 @@ 'attachment_move_error' => 'Nastala chyba pøi pøesouvání nahraného souboru', 'bad_attachment' => 'Tato pøíloha neexistuje', 'attachment_too_large' => 'Vámi specifikovaný soubor je vìt¹í ne¾ '.number_format(ATTACHMENT_MAX_SIZE).' bytù', - 'bad_permission' => 'Nemáte práva na po¾adovanou funkci', - 'project_only_all_groups' => 'Nelze vybrat specifickou skupoinu kdy¾ jsou vybrány v¹echny skupiny', + 'bad_permission' => 'Nemáte potøebná práva na po¾adovanou funkci', + 'project_only_all_groups' => 'Nelze vybrat specifickou skupinu kdy¾ jsou vybrány v¹echny skupiny', 'previous_bug' => 'Pøedchozí', 'next_bug' => 'Následující', - 'already_voted' => 'Ji¾ jste hlasoval k tomuto BUGu', + 'already_voted' => 'Ji¾ jste hlasoval(a) k tomuto BUGu', 'too_many_votes' => 'Dosáhl jste maximálního poètu hlasù na jednoho u¾ivatele', 'no_votes' => 'Nikdo je¹tì nehlasoval', 'user_filter' => array( 0 => 'V¹ichni u¾ivatelé', 1 => 'Aktivní u¾ivatelé', 2 => 'Neaktivní u¾ivatelé'), - 'dupe_dependency' => 'That bug dependency has already been added', - 'image_path_not_writeable' => 'The subdirectory "jpgimages" is not writeable by the web process, so the summary image can not be rendered' + 'dupe_dependency' => 'Tato závislost ji¾ byla pøidána', + 'image_path_not_writeable' => 'Webprocess nemù¾e zapisovat do podadresáøe "jpgimages", pøehledový obrázek nemù¾e být vygenerován.' ); // Page titles @@ -100,5 +100,4 @@ 'reporting' => 'Hlá¹ení', 'group' => 'Skupiny' ); - ?> Index: cz.php =================================================================== RCS file: /cvsroot/phpbt/phpbt/languages/cz.php,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- cz.php 12 Apr 2002 13:48:17 -0000 1.5 +++ cz.php 7 May 2002 13:43:38 -0000 1.6 @@ -1,8 +1,8 @@ <?php -// cz.php - Czech strings and titles +// cz.php - Czech strings and titles encoded in Windows-1250 codepage // ------------------------------------------------------------------------ -// Copyright (c) 2001 The phpBugTracker Group +// Copyright (c) 2001, 2002 The phpBugTracker Group // ------------------------------------------------------------------------ // This file is part of phpBugTracker // @@ -32,16 +32,16 @@ 'noprojects' => 'Projekt nebyl nalezen', 'totalbugs' => 'Celkovì chyb', 'giveemail' => 'Prosím vlote správnou e-mailovou adresu', - 'givelogin' => 'prosím vlote login (uivatelské jméno)', + 'givelogin' => 'Prosím vlote login (uivatelské jméno)', 'loginused' => 'Tento login ji uívá nìkdo jiný', 'newacctsubject' => 'phpBugTracker Pøihláení', - 'newacctmessage' => "Váe phpBugTracker heslo je %s", + 'newacctmessage' => "Vae phpBugTracker heslo je %s", 'nobugs' => 'Nenalezeny ádné chyby', 'givename' => 'Prosím vlote jméno', 'edit' => 'Upravit', 'addnew' => 'Pøidat', 'nooses' => 'Nenalezen OS', - 'giveinitversion' => 'Prosím vlote poèáteèní verzi projektu ', + 'giveinitversion' => 'Prosím vlote poèáteèní verzi projektu', 'giveversion' => 'Prosím vlote verzi', 'noversions' => 'Verze nenalezena', 'nocomponents' => 'Komponenta nenalezena', @@ -50,11 +50,11 @@ 'givepassword' => 'Prosím vlote heslo', 'nousers' => 'Uivatel(é) nenalezen(i)', 'bugbadperm' => 'Nemùete zmìnit BUG', - 'bugbadnum' => 'Tenhle BUG neexistuje', - 'datecollision' => 'Nìkdo aktualizoval BUG od Vaí poslední návtìvy. Do informací o BUGu byli zaneseny nejnovìjí zmìny', - 'passwordmatch' => 'Hesla nesouhlasí --prosím zadejte je znova', + 'bugbadnum' => 'Tento BUG neexistuje', + 'datecollision' => 'Nìkdo aktualizoval BUG od Vaí poslední návtìvy. Do informací o BUGu byli zaneseny nejnovìjí zmìny.', + 'passwordmatch' => 'Hesla nesouhlasí --prosím zadejte je znovu', 'nobughistory' => 'Tento BUG nemá hystorii', - 'logintomodify' => 'Musíte být zalogován pro upravu tohoto BUGu', + 'logintomodify' => 'Musíte být pøihláen(a) pro upravu tohoto BUGu', 'dupe_attachment' => 'Pøíloha pro tento BUG je ji nahrána', 'give_attachment' => 'Prosím vyberte soubor pro upload', 'no_attachment_save_path' => 'Cesta k uloenému souboru nenalezena', @@ -62,19 +62,19 @@ 'attachment_move_error' => 'Nastala chyba pøi pøesouvání nahraného souboru', 'bad_attachment' => 'Tato pøíloha neexistuje', 'attachment_too_large' => 'Vámi specifikovaný soubor je vìtí ne '.number_format(ATTACHMENT_MAX_SIZE).' bytù', - 'bad_permission' => 'Nemáte práva na poadovanou funkci', - 'project_only_all_groups' => 'Nelze vybrat specifickou skupoinu kdy jsou vybrány vechny skupiny', + 'bad_permission' => 'Nemáte potøebná práva na poadovanou funkci', + 'project_only_all_groups' => 'Nelze vybrat specifickou skupinu kdy jsou vybrány vechny skupiny', 'previous_bug' => 'Pøedchozí', 'next_bug' => 'Následující', - 'already_voted' => 'Ji jste hlasoval k tomuto BUGu', + 'already_voted' => 'Ji jste hlasoval(a) k tomuto BUGu', 'too_many_votes' => 'Dosáhl jste maximálního poètu hlasù na jednoho uivatele', 'no_votes' => 'Nikdo jetì nehlasoval', 'user_filter' => array( 0 => 'Vichni uivatelé', 1 => 'Aktivní uivatelé', 2 => 'Neaktivní uivatelé'), - 'dupe_dependency' => 'That bug dependency has already been added', - 'image_path_not_writeable' => 'The subdirectory "jpgimages" is not writeable by the web process, so the summary image can not be rendered' + 'dupe_dependency' => 'Tato závislost ji byla pøidána', + 'image_path_not_writeable' => 'Webprocess nemùe zapisovat do podadresáøe "jpgimages", pøehledový obrázek nemùe být vygenerován.' ); // Page titles @@ -100,5 +100,4 @@ 'reporting' => 'Hláení', 'group' => 'Skupiny' ); - ?> |
|
From: Jirka P. <fi...@us...> - 2002-05-07 12:56:13
|
Update of /cvsroot/phpbt/phpbt/languages In directory usw-pr-cvs1:/tmp/cvs-serv21320/phpbt/languages Added Files: cz_iso-8859-2.php Log Message: Czech language strings encoded in ISO-8859-2, which is international standart for Central Europe. Windows-1250 encoding (used in file cz.php) is only the standart on Microsoft compatible platforms. ISO-8859-2 encoding works with all major browsers/platforms and there are many fonts encoded in iso-8859-2 for UNIX/LINUX based systems. Nobody knows, why Microsoft is still using obsoleted Windows-1250 encoding. And I personaly don't know, why anybody is using anything else than unicode. :-) --- NEW FILE: cz_iso-8859-2.php --- <?php // cz.php - Czech strings and titles // ------------------------------------------------------------------------ // Copyright (c) 2002 The phpBugTracker Group // ------------------------------------------------------------------------ // This file is part of phpBugTracker // // phpBugTracker is free software; you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation; either version 2 of the License, or // (at your option) any later version. // // phpBugTracker is distributed in the hope that it will be useful, // but WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the // GNU General Public License for more details. // // You should have received a copy of the GNU General Public License // along with phpBugTracker; if not, write to the Free Software Foundation, // Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. // ------------------------------------------------------------------------ // $Id: cz_iso-8859-2.php,v 1.1 2002/05/07 12:56:04 firma Exp $ $STRING = array( 'lang_charset' => 'iso-8859-2', 'nouser' => 'Tento u¾ivatel neexistuje', 'dupeofself' => 'BUG nemù¾e být shodný se sám se sebou', 'nobug' => 'Tento BUG neexistuje', 'givesummary' => 'Prosím vlo¾te souhrn', 'givedesc' => 'Prosím vlo¾te popis', 'noprojects' => 'Projekt nebyl nalezen', 'totalbugs' => 'Celkovì chyb', 'giveemail' => 'Prosím vlo¾te správnou e-mailovou adresu', 'givelogin' => 'prosím vlo¾te login (u¾ivatelské jméno)', 'loginused' => 'Tento login ji¾ u¾ívá nìkdo jiný', 'newacctsubject' => 'phpBugTracker Pøihlá¹ení', 'newacctmessage' => "Vá¹e phpBugTracker heslo je %s", 'nobugs' => 'Nenalezeny ¾ádné chyby', 'givename' => 'Prosím vlo¾te jméno', 'edit' => 'Upravit', 'addnew' => 'Pøidat', 'nooses' => 'Nenalezen OS', 'giveinitversion' => 'Prosím vlo¾te poèáteèní verzi projektu ', 'giveversion' => 'Prosím vlo¾te verzi', 'noversions' => 'Verze nenalezena', 'nocomponents' => 'Komponenta nenalezena', 'nostatuses' => 'Status nebyl nalezen', 'noseverities' => 'Dùle¾itost nenalezena', 'givepassword' => 'Prosím vlo¾te heslo', 'nousers' => 'U¾ivatel(é) nenalezen(i)', 'bugbadperm' => 'Nemù¾ete zmìnit BUG', 'bugbadnum' => 'Tenhle BUG neexistuje', 'datecollision' => 'Nìkdo aktualizoval BUG od Va¹í poslední náv¹tìvy. Do informací o BUGu byli zaneseny nejnovìj¹í zmìny', 'passwordmatch' => 'Hesla nesouhlasí --prosím zadejte je znova', 'nobughistory' => 'Tento BUG nemá hystorii', 'logintomodify' => 'Musíte být zalogován pro upravu tohoto BUGu', 'dupe_attachment' => 'Pøíloha pro tento BUG je ji¾ nahrána', 'give_attachment' => 'Prosím vyberte soubor pro upload', 'no_attachment_save_path' => 'Cesta k ulo¾enému souboru nenalezena', 'attachment_path_not_writeable' => 'Nelze vytvoøit soubor na zadané cestì', 'attachment_move_error' => 'Nastala chyba pøi pøesouvání nahraného souboru', 'bad_attachment' => 'Tato pøíloha neexistuje', 'attachment_too_large' => 'Vámi specifikovaný soubor je vìt¹í ne¾ '.number_format(ATTACHMENT_MAX_SIZE).' bytù', 'bad_permission' => 'Nemáte práva na po¾adovanou funkci', 'project_only_all_groups' => 'Nelze vybrat specifickou skupoinu kdy¾ jsou vybrány v¹echny skupiny', 'previous_bug' => 'Pøedchozí', 'next_bug' => 'Následující', 'already_voted' => 'Ji¾ jste hlasoval k tomuto BUGu', 'too_many_votes' => 'Dosáhl jste maximálního poètu hlasù na jednoho u¾ivatele', 'no_votes' => 'Nikdo je¹tì nehlasoval', 'user_filter' => array( 0 => 'V¹ichni u¾ivatelé', 1 => 'Aktivní u¾ivatelé', 2 => 'Neaktivní u¾ivatelé'), 'dupe_dependency' => 'That bug dependency has already been added', 'image_path_not_writeable' => 'The subdirectory "jpgimages" is not writeable by the web process, so the summary image can not be rendered' ); // Page titles $TITLE = array( 'enterbug' => 'Vlo¾te BUG', 'editbug' => 'Upravte BUG', 'newaccount' => 'Vytvoøit nový úèet', 'bugquery' => 'BUG dotaz', 'buglist' => 'Seznam BUGù', 'addcomponent' => 'Pøidat komponentu', 'editcomponent' => 'Editovat komponentu', 'addproject' => 'Pøidat projekt', 'editproject' => 'Editovat projekt', 'addversion' => 'Pøidat verzi', 'editversion' => 'Upravit verzi', 'project' => 'Projekty', 'os' => 'Operaèní systémy', 'resolution' => 'Rozli¹ení', 'status' => 'Statusy', 'severity' => 'Dùle¾itosti', 'user' => 'U¾ivatelé', 'home' => 'Domù', 'reporting' => 'Hlá¹ení', 'group' => 'Skupiny' ); ?> |
|
From: Benjamin C. <bc...@us...> - 2002-05-07 12:54:55
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv24658
Modified Files:
bug.php
Log Message:
Complete the CC address fix and make CC selection opera friendly
Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.101
retrieving revision 1.102
diff -u -r1.101 -r1.102
--- bug.php 6 May 2002 13:17:29 -0000 1.101
+++ bug.php 7 May 2002 12:54:50 -0000 1.102
@@ -239,7 +239,7 @@
// Collect the CCs
if ($ccs = $db->getCol(sprintf($QUERY['bug-cc-list'], $buginfo['bug_id']))) {
- array_merge($maillist, $ccs);
+ $maillist = array_merge($maillist, $ccs);
}
// Later add a watcher (such as QA person) check here
@@ -317,7 +317,7 @@
}
// Remove CCs if requested
- if (isset($remove_cc) and count($remove_cc)) {
+ if (isset($remove_cc) and $remove_cc[0]) {
$db->query('delete from '.TBL_BUG_CC." where bug_id = $bugid
and user_id in (".delimit_list(',', $remove_cc).')');
}
|
|
From: Jirka P. <fi...@us...> - 2002-05-07 11:44:14
|
Update of /cvsroot/phpbt/phpbt/templates/default
In directory usw-pr-cvs1:/tmp/cvs-serv7308/phpbt/templates/default
Modified Files:
bugdisplay.html
Log Message:
Scrollbars.
Index: bugdisplay.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/bugdisplay.html,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -r1.27 -r1.28
--- bugdisplay.html 5 May 2002 16:24:47 -0000 1.27
+++ bugdisplay.html 7 May 2002 11:44:11 -0000 1.28
@@ -23,7 +23,7 @@
}
function popupAtt(id) {
- window.open('attachment.php?use_js=1&bugid='+id, 'ewin', 'dependent=yes, width=350, height=200, scrollbars=auto');
+ window.open('attachment.php?use_js=1&bugid='+id, 'ewin', 'dependent=yes,width=350,height=200,scrollbars=1');
return false;
}
{/literal}
|
|
From: Jirka P. <fi...@us...> - 2002-05-07 11:44:14
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory usw-pr-cvs1:/tmp/cvs-serv7308/phpbt/templates/default/admin
Modified Files:
project-edit.html resolutionlist.html severitylist.html
statuslist.html
Log Message:
Scrollbars.
Index: project-edit.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/project-edit.html,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- project-edit.html 13 Apr 2002 14:51:57 -0000 1.7
+++ project-edit.html 7 May 2002 11:44:11 -0000 1.8
@@ -7,12 +7,12 @@
{literal}
function popupComponent(id) {
- window.open(me + '?op=edit_component&project_id='+projectId+'&use_js=1&id='+id, 'ewin', 'dependent=yes, width=450, height=300, scrollbars=auto');
+ window.open(me + '?op=edit_component&project_id='+projectId+'&use_js=1&id='+id, 'ewin', 'dependent=yes,width=450,height=300,scrollbars=1');
return false;
}
function popupVersion(id) {
- window.open(me + '?op=edit_version&project_id='+projectId+'&use_js=1&id='+id, 'ewin', 'dependent=yes, width=250, height=150, scrollbars=auto');
+ window.open(me + '?op=edit_version&project_id='+projectId+'&use_js=1&id='+id, 'ewin', 'dependent=yes,width=250,height=150,scrollbars=1');
return false;
}
{/literal}
Index: resolutionlist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/resolutionlist.html,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- resolutionlist.html 11 Apr 2002 22:03:57 -0000 1.8
+++ resolutionlist.html 7 May 2002 11:44:11 -0000 1.9
@@ -6,7 +6,7 @@
{literal}
function popupResolution(id) {
- window.open(me + '?op=edit&use_js=1&resolution_id='+id, 'ewin', 'dependent=yes, width=350, height=300, scrollbars=auto');
+ window.open(me + '?op=edit&use_js=1&resolution_id='+id, 'ewin', 'dependent=yes,width=350,height=300,scrollbars=1');
}
{/literal}
// -->
Index: severitylist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/severitylist.html,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- severitylist.html 11 Apr 2002 16:08:05 -0000 1.6
+++ severitylist.html 7 May 2002 11:44:11 -0000 1.7
@@ -6,7 +6,7 @@
{literal}
function popupSeverity(id) {
- window.open(me + '?op=edit&use_js=1&severity_id='+id, 'ewin', 'dependent=yes, width=350, height=300, scrollbars=auto');
+ window.open(me + '?op=edit&use_js=1&severity_id='+id, 'ewin', 'dependent=yes,width=350,height=300,scrollbars=1');
}
{/literal}
// -->
Index: statuslist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/statuslist.html,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- statuslist.html 11 Apr 2002 16:08:05 -0000 1.6
+++ statuslist.html 7 May 2002 11:44:11 -0000 1.7
@@ -6,7 +6,7 @@
{literal}
function popupStatus(id) {
- window.open(me + '?op=edit&use_js=1&status_id='+id, 'ewin', 'dependent=yes, width=350, height=300, scrollbars=auto');
+ window.open(me + '?op=edit&use_js=1&status_id='+id, 'ewin', 'dependent=yes,width=350,height=300,scrollbars=1');
}
{/literal}
// -->
|
|
From: Jirka P. <fi...@us...> - 2002-05-07 11:37:31
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory usw-pr-cvs1:/tmp/cvs-serv2876/phpbt/templates/default/admin
Modified Files:
oslist.html
Log Message:
Scrollbars.
Index: oslist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/oslist.html,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- oslist.html 11 Apr 2002 16:08:05 -0000 1.6
+++ oslist.html 7 May 2002 11:37:29 -0000 1.7
@@ -6,7 +6,7 @@
{literal}
function popupOS(id) {
- window.open(me + '?op=edit&use_js=1&os_id='+id, 'ewin', 'dependent=yes, width=350, height=300, scrollbars=auto');
+ window.open(me + '?op=edit&use_js=1&os_id='+id, 'ewin', 'dependent=yes,width=350,height=300,scrollbars=1');
}
{/literal}
// -->
|
|
From: Jirka P. <fi...@us...> - 2002-05-07 11:36:09
|
Update of /cvsroot/phpbt/phpbt/templates/default/admin
In directory usw-pr-cvs1:/tmp/cvs-serv1658/phpbt/templates/default/admin
Modified Files:
grouplist.html
Log Message:
Scrollbars.
Index: grouplist.html
===================================================================
RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/grouplist.html,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- grouplist.html 11 Apr 2002 16:08:05 -0000 1.3
+++ grouplist.html 7 May 2002 11:36:06 -0000 1.4
@@ -6,7 +6,7 @@
{literal}
function popupGroup(id) {
- window.open(me + '?op=edit&use_js=1&group_id='+id, 'ewin', 'dependent=yes, width=250, height=150, scrollbars=auto');
+ window.open(me + '?op=edit&use_js=1&group_id='+id, 'ewin', 'dependent=yes,width=250,height=150,scrollbars=1');
}
{/literal}
// -->
|
|
From: Jirka P. <fi...@us...> - 2002-05-07 11:27:44
|
> Ok, I've gone through another round of bug squashing, so I think I'm > actually going to release a bug fix version this time. :) Let me know > soon if anything needs to be addressed! Let's change the scrollbars=3Dauto -> scrollbars=3D1 (see my e-mail from today's morning) in all scripts opening new windows before releasing 0.8.2. Jirka |
|
From: Jirka P. <fi...@us...> - 2002-05-07 07:38:23
|
> Does scrollbars=3Dauto work without the spaces between the height, width, > etc.? All of the popups will need to be changed and I can't remember if > that works or not. No, it does not. It's not documented, but some clients (e.g. old versions of NN and IE) don't like spaces. Value 'auto' is NN specific, there are only possible values of 0 or 1 and always working parameters are: location, toolbar, status, menubar, scrollbars, resizable, top, left, width and height. Others are browser specific (including 'dependent'). Jirka |
|
From: Ben C. <php...@be...> - 2002-05-07 03:39:16
|
Ok, I've gone through another round of bug squashing, so I think I'm actually going to release a bug fix version this time. :) Let me know soon if anything needs to be addressed! |
|
From: Ben C. <php...@be...> - 2002-05-07 02:47:20
|
Does scrollbars=auto work without the spaces between the height, width,
etc.? All of the popups will need to be changed and I can't remember if
that works or not.
On Thu, May 02, 2002 at 01:35:40AM -0700, Jirka Pech wrote:
> Update of /cvsroot/phpbt/phpbt/templates/default/admin
> In directory usw-pr-cvs1:/tmp/cvs-serv22133/phpbt/templates/default/admin
>
> Modified Files:
> userlist.html
> Log Message:
> Scrollbars=auto not working (bug 551262). It's browser specific.
>
>
> Index: userlist.html
> ===================================================================
> RCS file: /cvsroot/phpbt/phpbt/templates/default/admin/userlist.html,v
> retrieving revision 1.8
> retrieving revision 1.9
> diff -u -r1.8 -r1.9
> --- userlist.html 11 Apr 2002 16:08:05 -0000 1.8
> +++ userlist.html 2 May 2002 08:35:38 -0000 1.9
> @@ -6,7 +6,7 @@
> {literal}
>
> function popupUser(id) {
> - window.open(me + '?op=edit&use_js=1&user_id='+id, 'ewin', 'dependent=yes, width=350, height=300, scrollbars=auto');
> + window.open(me + '?op=edit&use_js=1&user_id='+id, 'ewin', 'dependent=yes,width=350,height=300,scrollbars=1');
> }
> {/literal}
> // -->
>
>
> _______________________________________________________________
>
> Have big pipes? SourceForge.net is looking for download mirrors. We supply
> the hardware. You get the recognition. Email Us: ban...@so...
> _______________________________________________
> phpbt-dev mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpbt-dev
|
|
From: Jirka P. <fi...@us...> - 2002-05-06 13:29:52
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv5166/phpbt
Modified Files:
bug.php
Log Message:
Project ID missing due to using "get vars" in show_form vs. "post vars" in do_form. Repaired bug 551256.
Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.100
retrieving revision 1.101
diff -u -r1.100 -r1.101
--- bug.php 5 May 2002 16:24:46 -0000 1.100
+++ bug.php 6 May 2002 13:17:29 -0000 1.101
@@ -383,15 +383,20 @@
}
function do_form($bugid = 0) {
- global $db, $me, $u, $_pv, $STRING, $now, $HTTP_SERVER_VARS;
+ global $db, $me, $u, $_pv, $_gv, $STRING, $now, $HTTP_SERVER_VARS;
$error = '';
// Validation
- if (!$_pv['title'] = htmlspecialchars(trim($_pv['title'])))
+ if (!$_pv['title'] = htmlspecialchars(trim($_pv['title']))) {
$error = $STRING['givesummary'];
- elseif (!$_pv['description'] = htmlspecialchars(trim($_pv['description'])))
+ } elseif (!$_pv['description'] = htmlspecialchars(trim($_pv['description']))) {
$error = $STRING['givedesc'];
- if ($error) { show_form($bugid, $error); return; }
+ }
+ if ($error) {
+ $_gv['project'] = $_pv['project'];
+ show_form($bugid, $error);
+ return;
+ }
while (list($k,$v) = each($_pv)) $$k = $v;
|
2 messages has been excluded from this view by a project administrator.
