Menu
▾
▴
openocd-commit — OpenOCD commit maling list - read only
You can subscribe to this list here.
| 2008 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(75) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2009 |
Jan
(70) |
Feb
(20) |
Mar
(52) |
Apr
(149) |
May
(387) |
Jun
(466) |
Jul
(133) |
Aug
(87) |
Sep
(122) |
Oct
(140) |
Nov
(185) |
Dec
(105) |
| 2010 |
Jan
(85) |
Feb
(45) |
Mar
(75) |
Apr
(17) |
May
(41) |
Jun
(52) |
Jul
(33) |
Aug
(29) |
Sep
(36) |
Oct
(15) |
Nov
(26) |
Dec
(34) |
| 2011 |
Jan
(26) |
Feb
(25) |
Mar
(26) |
Apr
(29) |
May
(20) |
Jun
(27) |
Jul
(15) |
Aug
(32) |
Sep
(13) |
Oct
(64) |
Nov
(60) |
Dec
(10) |
| 2012 |
Jan
(64) |
Feb
(63) |
Mar
(39) |
Apr
(43) |
May
(54) |
Jun
(11) |
Jul
(30) |
Aug
(45) |
Sep
(11) |
Oct
(70) |
Nov
(24) |
Dec
(23) |
| 2013 |
Jan
(17) |
Feb
(8) |
Mar
(35) |
Apr
(40) |
May
(20) |
Jun
(24) |
Jul
(36) |
Aug
(25) |
Sep
(42) |
Oct
(40) |
Nov
(9) |
Dec
(21) |
| 2014 |
Jan
(29) |
Feb
(24) |
Mar
(60) |
Apr
(22) |
May
(22) |
Jun
(46) |
Jul
(11) |
Aug
(23) |
Sep
(26) |
Oct
(10) |
Nov
(14) |
Dec
(2) |
| 2015 |
Jan
(28) |
Feb
(47) |
Mar
(33) |
Apr
(58) |
May
(5) |
Jun
(1) |
Jul
|
Aug
(8) |
Sep
(12) |
Oct
(25) |
Nov
(58) |
Dec
(21) |
| 2016 |
Jan
(12) |
Feb
(40) |
Mar
(2) |
Apr
(1) |
May
(67) |
Jun
(2) |
Jul
(5) |
Aug
(36) |
Sep
|
Oct
(24) |
Nov
(17) |
Dec
(50) |
| 2017 |
Jan
(14) |
Feb
(16) |
Mar
(2) |
Apr
(35) |
May
(14) |
Jun
(16) |
Jul
(3) |
Aug
(3) |
Sep
|
Oct
(19) |
Nov
|
Dec
(16) |
| 2018 |
Jan
(55) |
Feb
(11) |
Mar
(34) |
Apr
(14) |
May
(4) |
Jun
(20) |
Jul
(39) |
Aug
(16) |
Sep
(17) |
Oct
(16) |
Nov
(20) |
Dec
(30) |
| 2019 |
Jan
(29) |
Feb
(24) |
Mar
(37) |
Apr
(26) |
May
(19) |
Jun
(21) |
Jul
(2) |
Aug
(3) |
Sep
(9) |
Oct
(12) |
Nov
(12) |
Dec
(12) |
| 2020 |
Jan
(47) |
Feb
(36) |
Mar
(54) |
Apr
(44) |
May
(37) |
Jun
(19) |
Jul
(32) |
Aug
(13) |
Sep
(16) |
Oct
(24) |
Nov
(32) |
Dec
(11) |
| 2021 |
Jan
(14) |
Feb
(5) |
Mar
(40) |
Apr
(32) |
May
(42) |
Jun
(31) |
Jul
(29) |
Aug
(47) |
Sep
(38) |
Oct
(17) |
Nov
(74) |
Dec
(33) |
| 2022 |
Jan
(11) |
Feb
(15) |
Mar
(40) |
Apr
(21) |
May
(39) |
Jun
(44) |
Jul
(19) |
Aug
(46) |
Sep
(79) |
Oct
(35) |
Nov
(21) |
Dec
(15) |
| 2023 |
Jan
(56) |
Feb
(13) |
Mar
(43) |
Apr
(28) |
May
(60) |
Jun
(15) |
Jul
(29) |
Aug
(28) |
Sep
(32) |
Oct
(21) |
Nov
(42) |
Dec
(39) |
| 2024 |
Jan
(35) |
Feb
(17) |
Mar
(28) |
Apr
(7) |
May
(14) |
Jun
(35) |
Jul
(30) |
Aug
(35) |
Sep
(30) |
Oct
(28) |
Nov
(38) |
Dec
(18) |
| 2025 |
Jan
(21) |
Feb
(28) |
Mar
(36) |
Apr
(35) |
May
(34) |
Jun
(58) |
Jul
(9) |
Aug
(16) |
Sep
|
Oct
|
Nov
|
Dec
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-10-08 07:50:40
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 1d77fc74e11d8eed87111216dd01e94d900c00c0 (commit)
from 48507e3b1044eee218a6ba207269d33e51ae6040 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 1d77fc74e11d8eed87111216dd01e94d900c00c0
Author: Tomas Vanek <va...@fb...>
Date: Wed Sep 21 09:47:05 2022 +0200
jtag/drivers/cmsis_dap: add LOG_DEBUG_IO to cmsis_dap_metacmd_targetsel
Make write to DP_TARGETSEL is logged the similar way as other DP register
read/writes.
While on it fix checkpatch message
'Concatenated strings should use spaces between elements'
Change-Id: I98f724c984e8c4610cc461340f4c4a7cc9627ed9
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7219
Reviewed-by: Antonio Borneo <bor...@gm...>
Reviewed-by: Jonathan Bell <jon...@ra...>
Tested-by: jenkins
diff --git a/src/jtag/drivers/cmsis_dap.c b/src/jtag/drivers/cmsis_dap.c
index e708d5252..2f5f9c907 100644
--- a/src/jtag/drivers/cmsis_dap.c
+++ b/src/jtag/drivers/cmsis_dap.c
@@ -573,6 +573,8 @@ static int cmsis_dap_metacmd_targetsel(uint32_t instance_id)
The purpose of this operation is to select the target
corresponding to the instance_id that is written */
+ LOG_DEBUG_IO("DP write reg TARGETSEL %" PRIx32, instance_id);
+
size_t idx = 0;
command[idx++] = CMD_DAP_SWD_SEQUENCE;
command[idx++] = 3; /* sequence count */
@@ -783,7 +785,7 @@ static void cmsis_dap_swd_write_from_queue(struct cmsis_dap *dap)
uint8_t cmd = transfer->cmd;
uint32_t data = transfer->data;
- LOG_DEBUG_IO("%s %s reg %x %"PRIx32,
+ LOG_DEBUG_IO("%s %s reg %x %" PRIx32,
cmd & SWD_CMD_APNDP ? "AP" : "DP",
cmd & SWD_CMD_RNW ? "read" : "write",
(cmd & SWD_CMD_A32) >> 1, data);
@@ -889,7 +891,7 @@ static void cmsis_dap_swd_read_process(struct cmsis_dap *dap, int timeout_ms)
uint32_t tmp = data;
idx += 4;
- LOG_DEBUG_IO("Read result: %"PRIx32, data);
+ LOG_DEBUG_IO("Read result: %" PRIx32, data);
/* Imitate posted AP reads */
if ((transfer->cmd & SWD_CMD_APNDP) ||
-----------------------------------------------------------------------
Summary of changes:
src/jtag/drivers/cmsis_dap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-10-08 07:47:43
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 48507e3b1044eee218a6ba207269d33e51ae6040 (commit)
from bced97cce95a31987f18674bb022e6d263b4f29c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 48507e3b1044eee218a6ba207269d33e51ae6040
Author: Tomas Vanek <va...@fb...>
Date: Fri Sep 30 13:56:59 2022 +0200
target/armv7m: show target name in 'halted' message
Change-Id: I13e9a33677632d52122585203252fc4ef0c52a2a
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7237
Tested-by: jenkins
Reviewed-by: Antonio Borneo <bor...@gm...>
diff --git a/src/target/armv7m.c b/src/target/armv7m.c
index 6f6a170b7..d9d01923a 100644
--- a/src/target/armv7m.c
+++ b/src/target/armv7m.c
@@ -729,8 +729,9 @@ int armv7m_arch_state(struct target *target)
ctrl = buf_get_u32(arm->core_cache->reg_list[ARMV7M_CONTROL].value, 0, 32);
sp = buf_get_u32(arm->core_cache->reg_list[ARMV7M_R13].value, 0, 32);
- LOG_USER("target halted due to %s, current mode: %s %s\n"
+ LOG_USER("[%s] halted due to %s, current mode: %s %s\n"
"xPSR: %#8.8" PRIx32 " pc: %#8.8" PRIx32 " %csp: %#8.8" PRIx32 "%s%s",
+ target_name(target),
debug_reason_name(target),
arm_mode_name(arm->core_mode),
armv7m_exception_string(armv7m->exception_number),
-----------------------------------------------------------------------
Summary of changes:
src/target/armv7m.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-10-08 07:47:25
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via bced97cce95a31987f18674bb022e6d263b4f29c (commit)
from dce9a03cb2c50ef6c3f084c7d13325369559ebce (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit bced97cce95a31987f18674bb022e6d263b4f29c
Author: Tomas Vanek <va...@fb...>
Date: Sun Oct 2 09:30:50 2022 +0200
target/armv7m: prevent storing invalid register
armv7m_start_algorithm() stored all non-debug execution
registers from register cache without checking validity.
Check if the register cache is valid.
Try to read from CPU if not valid.
Issue a warning if register read fails.
Change-Id: I365f86d65243230cf521b13909575e5986a87a50
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7240
Tested-by: jenkins
Reviewed-by: Antonio Borneo <bor...@gm...>
Reviewed-by: Jonathan Bell <jon...@ra...>
diff --git a/src/target/armv7m.c b/src/target/armv7m.c
index 2db2ce2dd..6f6a170b7 100644
--- a/src/target/armv7m.c
+++ b/src/target/armv7m.c
@@ -528,11 +528,14 @@ int armv7m_start_algorithm(struct target *target,
/* Store all non-debug execution registers to armv7m_algorithm_info context */
for (unsigned i = 0; i < armv7m->arm.core_cache->num_regs; i++) {
+ struct reg *reg = &armv7m->arm.core_cache->reg_list[i];
+ if (!reg->valid)
+ armv7m_get_core_reg(reg);
- armv7m_algorithm_info->context[i] = buf_get_u32(
- armv7m->arm.core_cache->reg_list[i].value,
- 0,
- 32);
+ if (!reg->valid)
+ LOG_TARGET_WARNING(target, "Storing invalid register %s", reg->name);
+
+ armv7m_algorithm_info->context[i] = buf_get_u32(reg->value, 0, 32);
}
for (int i = 0; i < num_mem_params; i++) {
-----------------------------------------------------------------------
Summary of changes:
src/target/armv7m.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-10-08 07:47:06
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via dce9a03cb2c50ef6c3f084c7d13325369559ebce (commit)
from ae937791d35b0820e0bc9bf0ab134c2bebd113e4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit dce9a03cb2c50ef6c3f084c7d13325369559ebce
Author: Tomas Vanek <va...@fb...>
Date: Tue Sep 27 10:13:18 2022 +0200
flash/nor/rp2040: fix setting sp
The num_reg_params parameter of target_run_algorithm() was not
updated when setting "sp" was introduced. Therefore "sp" as the last
register parameter was not passed to a target algo.
Introduce a new helper variable with correct count of register parameters
and use it everywhere needed.
Change-Id: I934a71380783d98917167f1569145808ef23540f
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7225
Tested-by: jenkins
Reviewed-by: Antonio Borneo <bor...@gm...>
Reviewed-by: Jonathan Bell <jon...@ra...>
diff --git a/src/flash/nor/rp2040.c b/src/flash/nor/rp2040.c
index be86bb81e..feff9a6f9 100644
--- a/src/flash/nor/rp2040.c
+++ b/src/flash/nor/rp2040.c
@@ -111,11 +111,12 @@ static int rp2040_call_rom_func(struct target *target, struct rp2040_flash_bank
/* Pass function pointer in r7 */
init_reg_param(&args[n_args], "r7", 32, PARAM_OUT);
buf_set_u32(args[n_args].value, 0, 32, func_offset);
+ /* Setup stack */
init_reg_param(&args[n_args + 1], "sp", 32, PARAM_OUT);
buf_set_u32(args[n_args + 1].value, 0, 32, stacktop);
+ unsigned int n_reg_params = n_args + 2; /* User arguments + r7 + sp */
-
- for (unsigned int i = 0; i < n_args + 2; ++i)
+ for (unsigned int i = 0; i < n_reg_params; ++i)
LOG_DEBUG("Set %s = 0x%" PRIx32, args[i].reg_name, buf_get_u32(args[i].value, 0, 32));
/* Actually call the function */
@@ -124,17 +125,19 @@ static int rp2040_call_rom_func(struct target *target, struct rp2040_flash_bank
int err = target_run_algorithm(
target,
0, NULL, /* No memory arguments */
- n_args + 1, args, /* User arguments + r7 */
+ n_reg_params, args, /* User arguments + r7 + sp */
priv->jump_debug_trampoline, priv->jump_debug_trampoline_end,
timeout_ms,
&alg_info
);
- for (unsigned int i = 0; i < n_args + 2; ++i)
+
+ for (unsigned int i = 0; i < n_reg_params; ++i)
destroy_reg_param(&args[i]);
+
if (err != ERROR_OK)
LOG_ERROR("Failed to invoke ROM function @0x%" PRIx16, func_offset);
- return err;
+ return err;
}
/* Finalize flash write/erase/read ID
-----------------------------------------------------------------------
Summary of changes:
src/flash/nor/rp2040.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-27 08:50:06
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via ae937791d35b0820e0bc9bf0ab134c2bebd113e4 (commit)
from 3fdd3249b56419ccf45f0859461fe4858cfb8da3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ae937791d35b0820e0bc9bf0ab134c2bebd113e4
Author: Tomas Vanek <va...@fb...>
Date: Wed Sep 21 07:49:00 2022 +0200
flash/nor/rp2040: remove new line from error message
Change-Id: Idf3bce842b4507c1f12692b5fbcd6730637de9db
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7216
Reviewed-by: Antonio Borneo <bor...@gm...>
Reviewed-by: Jonathan Bell <jon...@ra...>
Tested-by: jenkins
diff --git a/src/flash/nor/rp2040.c b/src/flash/nor/rp2040.c
index 675f431b1..be86bb81e 100644
--- a/src/flash/nor/rp2040.c
+++ b/src/flash/nor/rp2040.c
@@ -132,7 +132,7 @@ static int rp2040_call_rom_func(struct target *target, struct rp2040_flash_bank
for (unsigned int i = 0; i < n_args + 2; ++i)
destroy_reg_param(&args[i]);
if (err != ERROR_OK)
- LOG_ERROR("Failed to invoke ROM function @0x%" PRIx16 "\n", func_offset);
+ LOG_ERROR("Failed to invoke ROM function @0x%" PRIx16, func_offset);
return err;
}
-----------------------------------------------------------------------
Summary of changes:
src/flash/nor/rp2040.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-27 08:49:40
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 3fdd3249b56419ccf45f0859461fe4858cfb8da3 (commit)
from 931b357466ba029d9984ade1f1598371e20871f4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3fdd3249b56419ccf45f0859461fe4858cfb8da3
Author: Tomas Vanek <va...@fb...>
Date: Sun Sep 11 16:35:54 2022 +0200
flash/nor/rp2040: use LOG_TARGET_xxx to show core name
Change-Id: Ic76e1c6306ece18b3590beaad4d5b224d4449aa0
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7188
Reviewed-by: Antonio Borneo <bor...@gm...>
Tested-by: jenkins
diff --git a/src/flash/nor/rp2040.c b/src/flash/nor/rp2040.c
index f131a3039..675f431b1 100644
--- a/src/flash/nor/rp2040.c
+++ b/src/flash/nor/rp2040.c
@@ -99,8 +99,7 @@ static int rp2040_call_rom_func(struct target *target, struct rp2040_flash_bank
}
target_addr_t stacktop = priv->stack->address + priv->stack->size;
- LOG_DEBUG("Calling ROM func @0x%" PRIx16 " with %d arguments", func_offset, n_args);
- LOG_DEBUG("Calling on core \"%s\"", target->cmd_name);
+ LOG_TARGET_DEBUG(target, "Calling ROM func @0x%" PRIx16 " with %u arguments", func_offset, n_args);
struct reg_param args[ARRAY_SIZE(regnames) + 2];
struct armv7m_algorithm alg_info;
-----------------------------------------------------------------------
Summary of changes:
src/flash/nor/rp2040.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-27 08:48:32
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 931b357466ba029d9984ade1f1598371e20871f4 (commit)
from 53611d8055d1130a925010b3feb39c7c8fa20a14 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 931b357466ba029d9984ade1f1598371e20871f4
Author: Tomas Vanek <va...@fb...>
Date: Wed Sep 21 07:46:15 2022 +0200
flash/nor/rp2040: check target halted before flash operation
Flash read_id/erase/write operation on running target failed
in target_run_algorithm() anyway. It generated lot of error messages.
Check the target state and bail out early if target is running.
Change-Id: I903f5f38c8e61016e5002b235e5f07803bd2ec4e
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7215
Tested-by: jenkins
Reviewed-by: Antonio Borneo <bor...@gm...>
Reviewed-by: Jonathan Bell <jon...@ra...>
diff --git a/src/flash/nor/rp2040.c b/src/flash/nor/rp2040.c
index 7cc6434ff..f131a3039 100644
--- a/src/flash/nor/rp2040.c
+++ b/src/flash/nor/rp2040.c
@@ -211,6 +211,12 @@ static int rp2040_flash_write(struct flash_bank *bank, const uint8_t *buffer, ui
struct rp2040_flash_bank *priv = bank->driver_priv;
struct target *target = bank->target;
+
+ if (target->state != TARGET_HALTED) {
+ LOG_ERROR("Target not halted");
+ return ERROR_TARGET_NOT_HALTED;
+ }
+
struct working_area *bounce = NULL;
int err = rp2040_stack_grab_and_prep(bank);
@@ -266,6 +272,13 @@ cleanup:
static int rp2040_flash_erase(struct flash_bank *bank, unsigned int first, unsigned int last)
{
struct rp2040_flash_bank *priv = bank->driver_priv;
+ struct target *target = bank->target;
+
+ if (target->state != TARGET_HALTED) {
+ LOG_ERROR("Target not halted");
+ return ERROR_TARGET_NOT_HALTED;
+ }
+
uint32_t start_addr = bank->sectors[first].offset;
uint32_t length = bank->sectors[last].offset + bank->sectors[last].size - start_addr;
LOG_DEBUG("RP2040 erase %d bytes starting at 0x%" PRIx32, length, start_addr);
@@ -294,7 +307,7 @@ static int rp2040_flash_erase(struct flash_bank *bank, unsigned int first, unsig
*/
int timeout_ms = 2000 * (last - first) + 1000;
- err = rp2040_call_rom_func(bank->target, priv, priv->jump_flash_range_erase,
+ err = rp2040_call_rom_func(target, priv, priv->jump_flash_range_erase,
args, ARRAY_SIZE(args), timeout_ms);
cleanup:
@@ -362,6 +375,11 @@ static int rp2040_flash_probe(struct flash_bank *bank)
struct rp2040_flash_bank *priv = bank->driver_priv;
struct target *target = bank->target;
+ if (target->state != TARGET_HALTED) {
+ LOG_ERROR("Target not halted");
+ return ERROR_TARGET_NOT_HALTED;
+ }
+
int err = rp2040_lookup_symbol(target, FUNC_DEBUG_TRAMPOLINE, &priv->jump_debug_trampoline);
if (err != ERROR_OK) {
LOG_ERROR("Debug trampoline not found in RP2040 ROM.");
-----------------------------------------------------------------------
Summary of changes:
src/flash/nor/rp2040.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-27 08:42:24
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 53611d8055d1130a925010b3feb39c7c8fa20a14 (commit)
from 84d73d0225407594ed9cf646fa3dd8a5752df7ad (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 53611d8055d1130a925010b3feb39c7c8fa20a14
Author: Tomas Vanek <va...@fb...>
Date: Wed Sep 21 06:32:21 2022 +0200
flash/nor/rp2040: fix flash erase timeout
SPI flash erase often takes longer than the fixed timeout 3 seconds.
Introduce a configurable timeout_ms parameter to rp2040_call_rom_func().
Compute the erase timeout from the number of blocks to be erased.
While on it make the timeouts shorter for connect flash, flush cache and
enter/exit xip (1 second is enough).
Change-Id: I552bfa317ee17064de3a54ec2f0c63e84ba87222
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7214
Tested-by: jenkins
Reviewed-by: Antonio Borneo <bor...@gm...>
Reviewed-by: Jonathan Bell <jon...@ra...>
diff --git a/src/flash/nor/rp2040.c b/src/flash/nor/rp2040.c
index ce09fea08..7cc6434ff 100644
--- a/src/flash/nor/rp2040.c
+++ b/src/flash/nor/rp2040.c
@@ -87,7 +87,7 @@ static uint32_t rp2040_lookup_symbol(struct target *target, uint32_t tag, uint16
}
static int rp2040_call_rom_func(struct target *target, struct rp2040_flash_bank *priv,
- uint16_t func_offset, uint32_t argdata[], unsigned int n_args)
+ uint16_t func_offset, uint32_t argdata[], unsigned int n_args, int timeout_ms)
{
char *regnames[4] = { "r0", "r1", "r2", "r3" };
@@ -127,7 +127,7 @@ static int rp2040_call_rom_func(struct target *target, struct rp2040_flash_bank
0, NULL, /* No memory arguments */
n_args + 1, args, /* User arguments + r7 */
priv->jump_debug_trampoline, priv->jump_debug_trampoline_end,
- 3000, /* 3s timeout */
+ timeout_ms,
&alg_info
);
for (unsigned int i = 0; i < n_args + 2; ++i)
@@ -153,14 +153,14 @@ static int rp2040_finalize_stack_free(struct flash_bank *bank)
* chip select following a rp2040_flash_exit_xip().
*/
LOG_DEBUG("Flushing flash cache after write behind");
- int err = rp2040_call_rom_func(target, priv, priv->jump_flush_cache, NULL, 0);
+ int err = rp2040_call_rom_func(target, priv, priv->jump_flush_cache, NULL, 0, 1000);
if (err != ERROR_OK) {
LOG_ERROR("Failed to flush flash cache");
/* Intentionally continue after error and try to setup xip anyway */
}
LOG_DEBUG("Configuring SSI for execute-in-place");
- err = rp2040_call_rom_func(target, priv, priv->jump_enter_cmd_xip, NULL, 0);
+ err = rp2040_call_rom_func(target, priv, priv->jump_enter_cmd_xip, NULL, 0, 1000);
if (err != ERROR_OK)
LOG_ERROR("Failed to set SSI to XIP mode");
@@ -189,14 +189,14 @@ static int rp2040_stack_grab_and_prep(struct flash_bank *bank)
}
LOG_DEBUG("Connecting internal flash");
- err = rp2040_call_rom_func(target, priv, priv->jump_connect_internal_flash, NULL, 0);
+ err = rp2040_call_rom_func(target, priv, priv->jump_connect_internal_flash, NULL, 0, 1000);
if (err != ERROR_OK) {
LOG_ERROR("Failed to connect internal flash");
return err;
}
LOG_DEBUG("Kicking flash out of XIP mode");
- err = rp2040_call_rom_func(target, priv, priv->jump_flash_exit_xip, NULL, 0);
+ err = rp2040_call_rom_func(target, priv, priv->jump_flash_exit_xip, NULL, 0, 1000);
if (err != ERROR_OK) {
LOG_ERROR("Failed to exit flash XIP mode");
return err;
@@ -243,7 +243,8 @@ static int rp2040_flash_write(struct flash_bank *bank, const uint8_t *buffer, ui
bounce->address, /* data */
write_size /* count */
};
- err = rp2040_call_rom_func(target, priv, priv->jump_flash_range_program, args, ARRAY_SIZE(args));
+ err = rp2040_call_rom_func(target, priv, priv->jump_flash_range_program,
+ args, ARRAY_SIZE(args), 3000);
if (err != ERROR_OK) {
LOG_ERROR("Failed to invoke flash programming code on target");
break;
@@ -292,7 +293,9 @@ static int rp2040_flash_erase(struct flash_bank *bank, unsigned int first, unsig
an optional larger "block" (size and command provided in args).
*/
- err = rp2040_call_rom_func(bank->target, priv, priv->jump_flash_range_erase, args, ARRAY_SIZE(args));
+ int timeout_ms = 2000 * (last - first) + 1000;
+ err = rp2040_call_rom_func(bank->target, priv, priv->jump_flash_range_erase,
+ args, ARRAY_SIZE(args), timeout_ms);
cleanup:
rp2040_finalize_stack_free(bank);
-----------------------------------------------------------------------
Summary of changes:
src/flash/nor/rp2040.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-27 08:40:33
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 84d73d0225407594ed9cf646fa3dd8a5752df7ad (commit)
from 47ed1c1eab82ee329915e04ea61f857dae89fc6a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 84d73d0225407594ed9cf646fa3dd8a5752df7ad
Author: Tomas Vanek <va...@fb...>
Date: Sun Sep 11 12:11:31 2022 +0200
flash/nor/rp2040: fix size of flash write buffer
The size of the flash write buffer should be rounded
down to the multiply of flash page size.
Using write chunks of unadjusted size results in write of chunks
unaligned to flash pages.
Change-Id: If7931362ee193dff4dc2df7ec78f13530658cf08
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7187
Tested-by: jenkins
Reviewed-by: Antonio Borneo <bor...@gm...>
diff --git a/src/flash/nor/rp2040.c b/src/flash/nor/rp2040.c
index 1c57424f9..ce09fea08 100644
--- a/src/flash/nor/rp2040.c
+++ b/src/flash/nor/rp2040.c
@@ -217,7 +217,11 @@ static int rp2040_flash_write(struct flash_bank *bank, const uint8_t *buffer, ui
if (err != ERROR_OK)
goto cleanup;
- const unsigned int chunk_size = target_get_working_area_avail(target);
+ unsigned int avail_pages = target_get_working_area_avail(target) / priv->dev->pagesize;
+ /* We try to allocate working area rounded down to device page size,
+ * al least 1 page, at most the write data size
+ */
+ unsigned int chunk_size = MIN(MAX(avail_pages, 1) * priv->dev->pagesize, count);
err = target_alloc_working_area(target, chunk_size, &bounce);
if (err != ERROR_OK) {
LOG_ERROR("Could not allocate bounce buffer for flash programming. Can't continue");
-----------------------------------------------------------------------
Summary of changes:
src/flash/nor/rp2040.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-27 08:39:21
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 47ed1c1eab82ee329915e04ea61f857dae89fc6a (commit)
from d25f0ae263f89a362f35b316a11a48428312344c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 47ed1c1eab82ee329915e04ea61f857dae89fc6a
Author: Tomas Vanek <va...@fb...>
Date: Sun Sep 11 11:18:29 2022 +0200
flash/nor/rp2040: fix memory leak of target stack workarea
While on it restore memory-mapped mode also after flash erase
(originally was restored after flash write only).
Change-Id: I5e153b79ac27a8439f57239ce90ce8a79c0bb8a1
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7186
Tested-by: jenkins
Reviewed-by: Antonio Borneo <bor...@gm...>
diff --git a/src/flash/nor/rp2040.c b/src/flash/nor/rp2040.c
index ba21d1c0f..1c57424f9 100644
--- a/src/flash/nor/rp2040.c
+++ b/src/flash/nor/rp2040.c
@@ -138,6 +138,43 @@ static int rp2040_call_rom_func(struct target *target, struct rp2040_flash_bank
}
+/* Finalize flash write/erase/read ID
+ * - flush cache
+ * - enters memory-mapped (XIP) mode to make flash data visible
+ * - deallocates target ROM func stack if previously allocated
+ */
+static int rp2040_finalize_stack_free(struct flash_bank *bank)
+{
+ struct rp2040_flash_bank *priv = bank->driver_priv;
+ struct target *target = bank->target;
+
+ /* Always flush before returning to execute-in-place, to invalidate stale
+ * cache contents. The flush call also restores regular hardware-controlled
+ * chip select following a rp2040_flash_exit_xip().
+ */
+ LOG_DEBUG("Flushing flash cache after write behind");
+ int err = rp2040_call_rom_func(target, priv, priv->jump_flush_cache, NULL, 0);
+ if (err != ERROR_OK) {
+ LOG_ERROR("Failed to flush flash cache");
+ /* Intentionally continue after error and try to setup xip anyway */
+ }
+
+ LOG_DEBUG("Configuring SSI for execute-in-place");
+ err = rp2040_call_rom_func(target, priv, priv->jump_enter_cmd_xip, NULL, 0);
+ if (err != ERROR_OK)
+ LOG_ERROR("Failed to set SSI to XIP mode");
+
+ target_free_working_area(target, priv->stack);
+ priv->stack = NULL;
+ return err;
+}
+
+/* Prepare flash write/erase/read ID
+ * - allocates a stack for target ROM func
+ * - switches the SPI interface from memory-mapped mode to direct command mode
+ * Always pair with a call of rp2040_finalize_stack_free()
+ * after flash operation finishes or fails.
+ */
static int rp2040_stack_grab_and_prep(struct flash_bank *bank)
{
struct rp2040_flash_bank *priv = bank->driver_priv;
@@ -154,14 +191,14 @@ static int rp2040_stack_grab_and_prep(struct flash_bank *bank)
LOG_DEBUG("Connecting internal flash");
err = rp2040_call_rom_func(target, priv, priv->jump_connect_internal_flash, NULL, 0);
if (err != ERROR_OK) {
- LOG_ERROR("RP2040 erase: failed to connect internal flash");
+ LOG_ERROR("Failed to connect internal flash");
return err;
}
LOG_DEBUG("Kicking flash out of XIP mode");
err = rp2040_call_rom_func(target, priv, priv->jump_flash_exit_xip, NULL, 0);
if (err != ERROR_OK) {
- LOG_ERROR("RP2040 erase: failed to exit flash XIP mode");
+ LOG_ERROR("Failed to exit flash XIP mode");
return err;
}
@@ -174,16 +211,17 @@ static int rp2040_flash_write(struct flash_bank *bank, const uint8_t *buffer, ui
struct rp2040_flash_bank *priv = bank->driver_priv;
struct target *target = bank->target;
- struct working_area *bounce;
+ struct working_area *bounce = NULL;
int err = rp2040_stack_grab_and_prep(bank);
if (err != ERROR_OK)
- return err;
+ goto cleanup;
const unsigned int chunk_size = target_get_working_area_avail(target);
- if (target_alloc_working_area(target, chunk_size, &bounce) != ERROR_OK) {
+ err = target_alloc_working_area(target, chunk_size, &bounce);
+ if (err != ERROR_OK) {
LOG_ERROR("Could not allocate bounce buffer for flash programming. Can't continue");
- return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
+ goto cleanup;
}
LOG_DEBUG("Allocated flash bounce buffer @" TARGET_ADDR_FMT, bounce->address);
@@ -211,23 +249,12 @@ static int rp2040_flash_write(struct flash_bank *bank, const uint8_t *buffer, ui
offset += write_size;
count -= write_size;
}
+
+cleanup:
target_free_working_area(target, bounce);
- if (err != ERROR_OK)
- return err;
+ rp2040_finalize_stack_free(bank);
- /* Flash is successfully programmed. We can now do a bit of poking to make the flash
- contents visible to us via memory-mapped (XIP) interface in the 0x1... memory region */
- LOG_DEBUG("Flushing flash cache after write behind");
- err = rp2040_call_rom_func(bank->target, priv, priv->jump_flush_cache, NULL, 0);
- if (err != ERROR_OK) {
- LOG_ERROR("RP2040 write: failed to flush flash cache");
- return err;
- }
- LOG_DEBUG("Configuring SSI for execute-in-place");
- err = rp2040_call_rom_func(bank->target, priv, priv->jump_enter_cmd_xip, NULL, 0);
- if (err != ERROR_OK)
- LOG_ERROR("RP2040 write: failed to flush flash cache");
return err;
}
@@ -240,7 +267,7 @@ static int rp2040_flash_erase(struct flash_bank *bank, unsigned int first, unsig
int err = rp2040_stack_grab_and_prep(bank);
if (err != ERROR_OK)
- return err;
+ goto cleanup;
LOG_DEBUG("Remote call flash_range_erase");
@@ -258,11 +285,14 @@ static int rp2040_flash_erase(struct flash_bank *bank, unsigned int first, unsig
https://github.com/raspberrypi/pico-bootrom/blob/master/bootrom/program_flash_generic.c
In theory, the function algorithm provides for erasing both a smaller "sector" (4096 bytes) and
- an optional larger "block" (size and command provided in args). OpenOCD's spi.c only uses "block" sizes.
+ an optional larger "block" (size and command provided in args).
*/
err = rp2040_call_rom_func(bank->target, priv, priv->jump_flash_range_erase, args, ARRAY_SIZE(args));
+cleanup:
+ rp2040_finalize_stack_free(bank);
+
return err;
}
@@ -376,11 +406,13 @@ static int rp2040_flash_probe(struct flash_bank *bank)
}
err = rp2040_stack_grab_and_prep(bank);
- if (err != ERROR_OK)
- return err;
uint32_t device_id = 0;
- err = rp2040_spi_read_flash_id(target, &device_id);
+ if (err == ERROR_OK)
+ err = rp2040_spi_read_flash_id(target, &device_id);
+
+ rp2040_finalize_stack_free(bank);
+
if (err != ERROR_OK)
return err;
-----------------------------------------------------------------------
Summary of changes:
src/flash/nor/rp2040.c | 82 +++++++++++++++++++++++++++++++++++---------------
1 file changed, 57 insertions(+), 25 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-27 08:34:15
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via d25f0ae263f89a362f35b316a11a48428312344c (commit)
from 5f14140953ebf94dafa1150f8c7d3aeeff769bb7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d25f0ae263f89a362f35b316a11a48428312344c
Author: Tomas Vanek <va...@fb...>
Date: Sun Sep 11 10:47:03 2022 +0200
flash/nor/rp2040: preparatory refactoring
Prepend stack_grab_and_prep() function name by rp2040_ prefix.
Introduce target helper variable in rp2040_stack_grab_and_prep()
and use it instead of dereferencing bank->target several times.
Move flash ID reading code to the new rp2040_spi_read_flash_id()
function.
Change-Id: I9d6e51e17e36e6230155a586065499f2f260089a
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7185
Tested-by: jenkins
Reviewed-by: Antonio Borneo <bor...@gm...>
diff --git a/src/flash/nor/rp2040.c b/src/flash/nor/rp2040.c
index 667498ca3..ba21d1c0f 100644
--- a/src/flash/nor/rp2040.c
+++ b/src/flash/nor/rp2040.c
@@ -138,27 +138,28 @@ static int rp2040_call_rom_func(struct target *target, struct rp2040_flash_bank
}
-static int stack_grab_and_prep(struct flash_bank *bank)
+static int rp2040_stack_grab_and_prep(struct flash_bank *bank)
{
struct rp2040_flash_bank *priv = bank->driver_priv;
+ struct target *target = bank->target;
/* target_alloc_working_area always allocates multiples of 4 bytes, so no worry about alignment */
const int STACK_SIZE = 256;
- int err = target_alloc_working_area(bank->target, STACK_SIZE, &priv->stack);
+ int err = target_alloc_working_area(target, STACK_SIZE, &priv->stack);
if (err != ERROR_OK) {
LOG_ERROR("Could not allocate stack for flash programming code");
return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
}
LOG_DEBUG("Connecting internal flash");
- err = rp2040_call_rom_func(bank->target, priv, priv->jump_connect_internal_flash, NULL, 0);
+ err = rp2040_call_rom_func(target, priv, priv->jump_connect_internal_flash, NULL, 0);
if (err != ERROR_OK) {
LOG_ERROR("RP2040 erase: failed to connect internal flash");
return err;
}
LOG_DEBUG("Kicking flash out of XIP mode");
- err = rp2040_call_rom_func(bank->target, priv, priv->jump_flash_exit_xip, NULL, 0);
+ err = rp2040_call_rom_func(target, priv, priv->jump_flash_exit_xip, NULL, 0);
if (err != ERROR_OK) {
LOG_ERROR("RP2040 erase: failed to exit flash XIP mode");
return err;
@@ -175,7 +176,7 @@ static int rp2040_flash_write(struct flash_bank *bank, const uint8_t *buffer, ui
struct target *target = bank->target;
struct working_area *bounce;
- int err = stack_grab_and_prep(bank);
+ int err = rp2040_stack_grab_and_prep(bank);
if (err != ERROR_OK)
return err;
@@ -237,7 +238,7 @@ static int rp2040_flash_erase(struct flash_bank *bank, unsigned int first, unsig
uint32_t length = bank->sectors[last].offset + bank->sectors[last].size - start_addr;
LOG_DEBUG("RP2040 erase %d bytes starting at 0x%" PRIx32, length, start_addr);
- int err = stack_grab_and_prep(bank);
+ int err = rp2040_stack_grab_and_prep(bank);
if (err != ERROR_OK)
return err;
@@ -289,6 +290,36 @@ static int rp2040_ssel_active(struct target *target, bool active)
return ERROR_OK;
}
+static int rp2040_spi_read_flash_id(struct target *target, uint32_t *devid)
+{
+ uint32_t device_id = 0;
+ const target_addr_t ssi_dr0 = 0x18000060;
+
+ int err = rp2040_ssel_active(target, true);
+
+ /* write RDID request into SPI peripheral's FIFO */
+ for (int count = 0; (count < 4) && (err == ERROR_OK); count++)
+ err = target_write_u32(target, ssi_dr0, SPIFLASH_READ_ID);
+
+ /* by this time, there is a receive FIFO entry for every write */
+ for (int count = 0; (count < 4) && (err == ERROR_OK); count++) {
+ uint32_t status;
+ err = target_read_u32(target, ssi_dr0, &status);
+
+ device_id >>= 8;
+ device_id |= (status & 0xFF) << 24;
+ }
+
+ if (err == ERROR_OK)
+ *devid = device_id >> 8;
+
+ int err2 = rp2040_ssel_active(target, false);
+ if (err2 != ERROR_OK)
+ LOG_ERROR("SSEL inactive failed");
+
+ return err;
+}
+
static int rp2040_flash_probe(struct flash_bank *bank)
{
struct rp2040_flash_bank *priv = bank->driver_priv;
@@ -344,34 +375,14 @@ static int rp2040_flash_probe(struct flash_bank *bank)
return err;
}
- err = stack_grab_and_prep(bank);
+ err = rp2040_stack_grab_and_prep(bank);
if (err != ERROR_OK)
return err;
uint32_t device_id = 0;
- const target_addr_t ssi_dr0 = 0x18000060;
-
- err = rp2040_ssel_active(target, true);
-
- /* write RDID request into SPI peripheral's FIFO */
- for (int count = 0; (count < 4) && (err == ERROR_OK); count++)
- err = target_write_u32(target, ssi_dr0, SPIFLASH_READ_ID);
-
- /* by this time, there is a receive FIFO entry for every write */
- for (int count = 0; (count < 4) && (err == ERROR_OK); count++) {
- uint32_t status;
- err = target_read_u32(target, ssi_dr0, &status);
-
- device_id >>= 8;
- device_id |= (status & 0xFF) << 24;
- }
- device_id >>= 8;
-
- err = rp2040_ssel_active(target, false);
- if (err != ERROR_OK) {
- LOG_ERROR("SSEL inactive failed");
+ err = rp2040_spi_read_flash_id(target, &device_id);
+ if (err != ERROR_OK)
return err;
- }
/* search for a SPI flash Device ID match */
priv->dev = NULL;
-----------------------------------------------------------------------
Summary of changes:
src/flash/nor/rp2040.c | 69 +++++++++++++++++++++++++++++---------------------
1 file changed, 40 insertions(+), 29 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-27 08:29:23
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 5f14140953ebf94dafa1150f8c7d3aeeff769bb7 (commit)
via b2f6b231177240af6693340e4e00d16c1e512692 (commit)
from 60abbda8bcb19e26e073605ec43fdd0f42416567 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 5f14140953ebf94dafa1150f8c7d3aeeff769bb7
Author: Tomas Vanek <va...@fb...>
Date: Wed Sep 21 13:54:01 2022 +0200
target/adi_v5_swd: suppress reconnect in swd_multidrop_select()
swd_multidrop_select() uses its own retry loop.
If select fails, do_reconnect flag remains set on exit and causes
useless reconnect.
Clear do_reconnect flag in retry loop.
Change-Id: Ie06d6967d7f4a977774c8530bb8d4b3e5ab4f62c
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7217
Reviewed-by: Antonio Borneo <bor...@gm...>
Reviewed-by: Jonathan Bell <jon...@ra...>
Tested-by: jenkins
diff --git a/src/target/adi_v5_swd.c b/src/target/adi_v5_swd.c
index bd85eb217..aea730d4d 100644
--- a/src/target/adi_v5_swd.c
+++ b/src/target/adi_v5_swd.c
@@ -272,6 +272,8 @@ static int swd_multidrop_select(struct adiv5_dap *dap)
LOG_DEBUG("Failed to select multidrop %s, retrying...",
adiv5_dap_name(dap));
+ /* we going to retry localy, do not ask for full reconnect */
+ dap->do_reconnect = false;
}
return retval;
commit b2f6b231177240af6693340e4e00d16c1e512692
Author: Tomas Vanek <va...@fb...>
Date: Tue Sep 20 18:55:51 2022 +0200
target/adi_v5_swd: fix SWD multidrop
Implementation of ADI v6 introduced banking of DP reg 0.
The accompanying change preventing DP SELECT write before
DP IDR read during connect was added to swd_connect_single() only.
Unchanged swd_connect_multidrop() / swd_multidrop_select_inner()
was broken as it emited DP SELECT and put DP to protocol error state.
Copy dap->select handling to swd_multidrop_select_inner().
Fixes: 72fb88613f02 (adiv6: add low level swd transport)
Change-Id: I514cd6d9ae2ba97ce3657b459df22638c278a0b1
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7213
Tested-by: jenkins
Reviewed-by: Antonio Borneo <bor...@gm...>
Reviewed-by: Jonathan Bell <jon...@ra...>
diff --git a/src/target/adi_v5_swd.c b/src/target/adi_v5_swd.c
index 979c643e9..bd85eb217 100644
--- a/src/target/adi_v5_swd.c
+++ b/src/target/adi_v5_swd.c
@@ -177,6 +177,19 @@ static int swd_multidrop_select_inner(struct adiv5_dap *dap, uint32_t *dpidr_ptr
assert(dap_is_multidrop(dap));
swd_send_sequence(dap, LINE_RESET);
+ /* From ARM IHI 0074C ADIv6.0, chapter B4.3.3 "Connection and line reset
+ * sequence":
+ * - line reset sets DP_SELECT_DPBANK to zero;
+ * - read of DP_DPIDR takes the connection out of reset;
+ * - write of DP_TARGETSEL keeps the connection in reset;
+ * - other accesses return protocol error (SWDIO not driven by target).
+ *
+ * Read DP_DPIDR to get out of reset. Initialize dap->select to zero to
+ * skip the write to DP_SELECT, avoiding the protocol error. Set again
+ * dap->select to DP_SELECT_INVALID because the rest of the register is
+ * unknown after line reset.
+ */
+ dap->select = 0;
retval = swd_queue_dp_write_inner(dap, DP_TARGETSEL, dap->multidrop_targetsel);
if (retval != ERROR_OK)
@@ -196,6 +209,8 @@ static int swd_multidrop_select_inner(struct adiv5_dap *dap, uint32_t *dpidr_ptr
return retval;
}
+ dap->select = DP_SELECT_INVALID;
+
retval = swd_queue_dp_read_inner(dap, DP_DLPIDR, &dlpidr);
if (retval != ERROR_OK)
return retval;
@@ -342,6 +357,7 @@ static int swd_connect_single(struct adiv5_dap *dap)
dap->switch_through_dormant = !dap->switch_through_dormant;
} while (timeval_ms() < timeout);
+
dap->select = DP_SELECT_INVALID;
if (retval != ERROR_OK) {
-----------------------------------------------------------------------
Summary of changes:
src/target/adi_v5_swd.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-23 21:27:59
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 60abbda8bcb19e26e073605ec43fdd0f42416567 (commit)
from 1293ddd65713d6551775b67169387622ada477c1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 60abbda8bcb19e26e073605ec43fdd0f42416567
Author: Tomas Vanek <va...@fb...>
Date: Mon Aug 15 11:15:43 2022 +0200
target/stm32l5x,stm32u5x: fix trace settings
The STM32L5 and U5 devices have DBGMCU_CR trace related bits changed
wrt other STM32 devices.
Fix the setting in configuration script.
Change-Id: I0bbc48e7b1290b603c6966cf5ddd42df389e6ede
Signed-off-by: Tomas Vanek <va...@fb...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7117
Tested-by: jenkins
Reviewed-by: Tarek BOCHKATI <tar...@gm...>
Reviewed-by: Antonio Borneo <bor...@gm...>
diff --git a/tcl/target/stm32x5x_common.cfg b/tcl/target/stm32x5x_common.cfg
index c506e224b..321abff80 100644
--- a/tcl/target/stm32x5x_common.cfg
+++ b/tcl/target/stm32x5x_common.cfg
@@ -152,10 +152,11 @@ lappend _telnet_autocomplete_skip _proc_pre_enable_$_CHIPNAME.tpiu
proc _proc_pre_enable_$_CHIPNAME.tpiu {_targetname} {
targets $_targetname
- # Set TRACE_IOEN; TRACE_MODE is set to async; when using sync
- # change this value accordingly to configure trace pins
+ # Set TRACE_EN and TRACE_IOEN in DBGMCU_CR
+ # Leave TRACE_MODE untouched (defaults to async).
+ # When using sync change this value accordingly to configure trace pins
# assignment
- mmw 0xE0044004 0x00000020 0
+ mmw 0xE0044004 0x00000030 0
}
$_CHIPNAME.tpiu configure -event pre-enable "_proc_pre_enable_$_CHIPNAME.tpiu $_TARGETNAME"
-----------------------------------------------------------------------
Summary of changes:
tcl/target/stm32x5x_common.cfg | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-23 21:27:20
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 1293ddd65713d6551775b67169387622ada477c1 (commit)
from 53d17e790128803a0fed453c4945c07b3377c4d3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 1293ddd65713d6551775b67169387622ada477c1
Author: Daniel Goehring <dgo...@os...>
Date: Wed Sep 21 17:17:04 2022 -0600
target/target: read_memory 64-bit bugfix
Increase "value_buf" size so it can hold a 64-bit number represented
as a string. Previous size could only hold a 32-bit number string.
Signed-off-by: Daniel Goehring <dgo...@os...>
Change-Id: If6fbc875236e6ddc59522fbc25db0129eb60ee27
Reviewed-on: https://review.openocd.org/c/openocd/+/7221
Tested-by: jenkins
Reviewed-by: Tomas Vanek <va...@fb...>
Reviewed-by: Antonio Borneo <bor...@gm...>
diff --git a/src/target/target.c b/src/target/target.c
index 794ee2f01..783159fec 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -4717,7 +4717,7 @@ static int target_jim_read_memory(Jim_Interp *interp, int argc,
break;
}
- char value_buf[11];
+ char value_buf[19];
snprintf(value_buf, sizeof(value_buf), "0x%" PRIx64, v);
Jim_ListAppendElement(interp, result_list,
-----------------------------------------------------------------------
Summary of changes:
src/target/target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-23 21:26:02
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 53d17e790128803a0fed453c4945c07b3377c4d3 (commit)
from 44ed26a1db3b9e0ca9dc1000e967533b1c371ee3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 53d17e790128803a0fed453c4945c07b3377c4d3
Author: Ian Thompson <ia...@ca...>
Date: Mon Sep 19 12:39:50 2022 -0700
target/xtensa: fix final clang analyzer warning
Reworked xtensa_read_memory() logic to always allocate
and initialize working buffer with sufficient padding.
Signed-off-by: Ian Thompson <ia...@ca...>
Change-Id: Ia9ab53336537adebf99f8156f481ca8279a7cd5d
Reviewed-on: https://review.openocd.org/c/openocd/+/7211
Tested-by: jenkins
Reviewed-by: Antonio Borneo <bor...@gm...>
Reviewed-by: Erhan Kurubas <erh...@es...>
diff --git a/src/target/xtensa/xtensa.c b/src/target/xtensa/xtensa.c
index 1691deeeb..4dfff6ab4 100644
--- a/src/target/xtensa/xtensa.c
+++ b/src/target/xtensa/xtensa.c
@@ -1738,15 +1738,12 @@ int xtensa_read_memory(struct target *target, target_addr_t address, uint32_t si
}
}
- if (addrstart_al == address && addrend_al == address + (size * count)) {
- albuff = buffer;
- } else {
- albuff = malloc(addrend_al - addrstart_al);
- if (!albuff) {
- LOG_TARGET_ERROR(target, "Out of memory allocating %" TARGET_PRIdADDR " bytes!",
- addrend_al - addrstart_al);
- return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
- }
+ unsigned int alloc_bytes = ALIGN_UP(addrend_al - addrstart_al, sizeof(uint32_t));
+ albuff = calloc(alloc_bytes, 1);
+ if (!albuff) {
+ LOG_TARGET_ERROR(target, "Out of memory allocating %" PRId64 " bytes!",
+ addrend_al - addrstart_al);
+ return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
}
/* We're going to use A3 here */
@@ -1795,11 +1792,8 @@ int xtensa_read_memory(struct target *target, target_addr_t address, uint32_t si
if (bswap)
buf_bswap32(albuff, albuff, addrend_al - addrstart_al);
- if (albuff != buffer) {
- memcpy(buffer, albuff + (address & 3), (size * count));
- free(albuff);
- }
-
+ memcpy(buffer, albuff + (address & 3), (size * count));
+ free(albuff);
return res;
}
@@ -1855,7 +1849,7 @@ int xtensa_write_memory(struct target *target,
albuff = malloc(addrend_al - addrstart_al);
}
if (!albuff) {
- LOG_TARGET_ERROR(target, "Out of memory allocating %" TARGET_PRIdADDR " bytes!",
+ LOG_TARGET_ERROR(target, "Out of memory allocating %" PRId64 " bytes!",
addrend_al - addrstart_al);
return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
}
-----------------------------------------------------------------------
Summary of changes:
src/target/xtensa/xtensa.c | 24 +++++++++---------------
1 file changed, 9 insertions(+), 15 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-23 21:25:34
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 44ed26a1db3b9e0ca9dc1000e967533b1c371ee3 (commit)
from fd2a44ab55e7c54ee9e594717aba72d04e85e716 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 44ed26a1db3b9e0ca9dc1000e967533b1c371ee3
Author: Antonio Borneo <bor...@gm...>
Date: Mon Sep 19 15:39:50 2022 +0200
target/riscv: fix use of uninitialized value
Scan-build reports:
Logic error: Uninitialized argument value
riscv.c:2688 2nd function call argument is an uninitialized value
This is a real error cause by running the command "riscv
authdata_write" without arguments. In such case 'value' is not
initialized and is passed to and used by r->authdata_write().
Reorganize the code to:
- detect the correct amount or command's arguments;
- drop the LOG_ERROR() on ERROR_COMMAND_SYNTAX_ERROR;
- drop the 'else' after 'return'.
Change-Id: I62e031220593b8308bc674b753e15d16d4c5c9ac
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7210
Tested-by: jenkins
Reviewed-by: Jan Matyas <ma...@co...>
Reviewed-by: Tim Newsome <ti...@si...>
diff --git a/src/target/riscv/riscv.c b/src/target/riscv/riscv.c
index dfd6a3e3d..ae0a7375d 100644
--- a/src/target/riscv/riscv.c
+++ b/src/target/riscv/riscv.c
@@ -2666,27 +2666,25 @@ COMMAND_HANDLER(riscv_authdata_write)
uint32_t value;
unsigned int index = 0;
- if (CMD_ARGC == 0) {
- /* nop */
- } else if (CMD_ARGC == 1) {
+ if (CMD_ARGC == 0 || CMD_ARGC > 2)
+ return ERROR_COMMAND_SYNTAX_ERROR;
+
+ if (CMD_ARGC == 1) {
COMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], value);
- } else if (CMD_ARGC == 2) {
+ } else {
COMMAND_PARSE_NUMBER(uint, CMD_ARGV[0], index);
COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], value);
- } else {
- LOG_ERROR("Command takes at most 2 arguments");
- return ERROR_COMMAND_SYNTAX_ERROR;
}
struct target *target = get_current_target(CMD_CTX);
RISCV_INFO(r);
- if (r->authdata_write) {
- return r->authdata_write(target, value, index);
- } else {
+ if (!r->authdata_write) {
LOG_ERROR("authdata_write is not implemented for this target.");
return ERROR_FAIL;
}
+
+ return r->authdata_write(target, value, index);
}
COMMAND_HANDLER(riscv_dmi_read)
-----------------------------------------------------------------------
Summary of changes:
src/target/riscv/riscv.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-23 21:25:16
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via fd2a44ab55e7c54ee9e594717aba72d04e85e716 (commit)
from aff48a6a31019af17959a7da33909d1cea6de61a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit fd2a44ab55e7c54ee9e594717aba72d04e85e716
Author: Antonio Borneo <bor...@gm...>
Date: Mon Sep 19 15:28:15 2022 +0200
target/riscv: fix undefined operation
Scan-build reports:
Logic error: Result of operation is garbage or undefined
riscv.c:1614 The result of the left shift is undefined due
to shifting by '4294967281', which is greater or
equal to the width of type 'target_addr_t'
This is a false warning due to clang that considers the impossible
case of 32 bits hart (xlen = 32) in SATP_MODE_SV48 mode
(info->va_bits = 48).
Under such case:
riscv.c:1614 ... ((target_addr_t)1 << (xlen - (info->va_bits - 1))) ...
the shift amount wraps around the unsigned type and assumes the
value 4294967281 (0xfffffff1).
Use assert() to prevent clang from complaining.
Change-Id: I08fdd2a806c350d061641e28cf15a51b397db099
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7209
Reviewed-by: Tim Newsome <ti...@si...>
Reviewed-by: Jan Matyas <ma...@co...>
Tested-by: jenkins
diff --git a/src/target/riscv/riscv.c b/src/target/riscv/riscv.c
index 5444fca01..dfd6a3e3d 100644
--- a/src/target/riscv/riscv.c
+++ b/src/target/riscv/riscv.c
@@ -1607,6 +1607,7 @@ static int riscv_address_translate(struct target *target,
LOG_DEBUG("virtual=0x%" TARGET_PRIxADDR "; mode=%s", virtual, info->name);
/* verify bits xlen-1:va_bits-1 are all equal */
+ assert(xlen >= info->va_bits);
target_addr_t mask = ((target_addr_t)1 << (xlen - (info->va_bits - 1))) - 1;
target_addr_t masked_msbs = (virtual >> (info->va_bits - 1)) & mask;
if (masked_msbs != 0 && masked_msbs != mask) {
-----------------------------------------------------------------------
Summary of changes:
src/target/riscv/riscv.c | 1 +
1 file changed, 1 insertion(+)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-23 21:25:02
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via aff48a6a31019af17959a7da33909d1cea6de61a (commit)
via ea9089944e509ba301f5a2ca14b30eb5d7a90f44 (commit)
from aa57890554cb4f8b4ccf35a69598238a12a79069 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit aff48a6a31019af17959a7da33909d1cea6de61a
Author: Antonio Borneo <bor...@gm...>
Date: Mon Sep 19 15:02:36 2022 +0200
target/riscv: fix dead assignment
Scan-build reports:
Unused code: Dead nested assignment
riscv.c:459 Although the value stored to 'ir_user4_raw' is
used in the enclosing expression, the value is
never actually read from 'ir_user4_raw'
This is caused by the value reassigned in 'ir_user4_raw':
riscv.c:459 ir_user4[3] = (uint8_t)(ir_user4_raw >>= 8);
but never used.
Drop the DIY conversion in favor of h_u32_to_le() that does not
reassign the input value.
Change-Id: Ifad29f4c46d4a2d0a2f5a5c4104d768cc3db2794
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7208
Reviewed-by: Tim Newsome <ti...@si...>
Reviewed-by: Jan Matyas <ma...@co...>
Tested-by: jenkins
diff --git a/src/target/riscv/riscv.c b/src/target/riscv/riscv.c
index c25efcde9..5444fca01 100644
--- a/src/target/riscv/riscv.c
+++ b/src/target/riscv/riscv.c
@@ -453,10 +453,7 @@ static int riscv_init_target(struct command_context *cmd_ctx,
if (bscan_tunnel_ir_width != 0) {
assert(target->tap->ir_length >= 6);
uint32_t ir_user4_raw = 0x23 << (target->tap->ir_length - 6);
- ir_user4[0] = (uint8_t)ir_user4_raw;
- ir_user4[1] = (uint8_t)(ir_user4_raw >>= 8);
- ir_user4[2] = (uint8_t)(ir_user4_raw >>= 8);
- ir_user4[3] = (uint8_t)(ir_user4_raw >>= 8);
+ h_u32_to_le(ir_user4, ir_user4_raw);
select_user4.num_bits = target->tap->ir_length;
bscan_tunneled_ir_width[0] = bscan_tunnel_ir_width;
if (bscan_tunnel_type == BSCAN_TUNNEL_DATA_REGISTER)
commit ea9089944e509ba301f5a2ca14b30eb5d7a90f44
Author: Antonio Borneo <bor...@gm...>
Date: Mon Sep 19 14:55:55 2022 +0200
target/riscv: fix unused initialization
Scan-build reports:
Unused code: Dead assignment
riscv.c:716 Value stored to 'result' is never read
Remove the initialization of variable 'result'.
Change-Id: Ied67bb4fcfa5bace186522074247ead43a5d5cd5
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7207
Reviewed-by: Tim Newsome <ti...@si...>
Reviewed-by: Jan Matyas <ma...@co...>
Tested-by: jenkins
diff --git a/src/target/riscv/riscv.c b/src/target/riscv/riscv.c
index dde3d7e69..c25efcde9 100644
--- a/src/target/riscv/riscv.c
+++ b/src/target/riscv/riscv.c
@@ -713,7 +713,6 @@ static int add_trigger(struct target *target, struct trigger *trigger)
return result;
int type = get_field(tdata1, MCONTROL_TYPE(riscv_xlen(target)));
- result = ERROR_OK;
switch (type) {
case 1:
result = maybe_add_trigger_t1(target, trigger, tdata1);
-----------------------------------------------------------------------
Summary of changes:
src/target/riscv/riscv.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-23 21:23:11
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via aa57890554cb4f8b4ccf35a69598238a12a79069 (commit)
via 8db6dff333c2803d339086c7d5694eac4da11d0a (commit)
from 8683526af7a9ca23115d26deb5b4835cd6be05d8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit aa57890554cb4f8b4ccf35a69598238a12a79069
Author: Antonio Borneo <bor...@gm...>
Date: Mon Sep 19 14:50:26 2022 +0200
target/riscv-013: fix unused initialization
Scan-build reports:
Unused code: Dead initialization
riscv-013.c:2362 Value stored to 'control' during its
initialization is never read
Remove the initialization of variable 'control'.
Change-Id: I548f8175530b9a2aa4c1788549d6467bf9824584
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7206
Reviewed-by: Tim Newsome <ti...@si...>
Reviewed-by: Jan Matyas <ma...@co...>
Tested-by: jenkins
diff --git a/src/target/riscv/riscv-013.c b/src/target/riscv/riscv-013.c
index 1f4c34346..99d3873de 100644
--- a/src/target/riscv/riscv-013.c
+++ b/src/target/riscv/riscv-013.c
@@ -2359,9 +2359,7 @@ static int assert_reset(struct target *target)
/* TODO: Try to use hasel in dmcontrol */
/* Set haltreq for each hart. */
- uint32_t control = control_base;
-
- control = set_hartsel(control_base, target->coreid);
+ uint32_t control = set_hartsel(control_base, target->coreid);
control = set_field(control, DM_DMCONTROL_HALTREQ,
target->reset_halt ? 1 : 0);
dmi_write(target, DM_DMCONTROL, control);
commit 8db6dff333c2803d339086c7d5694eac4da11d0a
Author: Antonio Borneo <bor...@gm...>
Date: Mon Sep 19 14:37:24 2022 +0200
target/riscv-013: fix unchecked return code
Scan-build complains about variable 'sbcs_orig' that can be used
not initialized.
Logic error: Assigned value is garbage or undefined
riscv-013.c:4468 Assigned value is garbage or undefined
This is caused by not checking the return value of the call
riscv-013.c:4466 dmi_read(target, &sbcs_orig, DM_SBCS);
In fact when dmi_read() returns error, the variable 'sbcs_orig' is
not assigned.
Check the returned value.
Change-Id: Ia9032a0229aa243138f95f4e13f765726a4ceae9
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7205
Reviewed-by: Tim Newsome <ti...@si...>
Reviewed-by: Jan Matyas <ma...@co...>
Tested-by: jenkins
diff --git a/src/target/riscv/riscv-013.c b/src/target/riscv/riscv-013.c
index 2c762e337..1f4c34346 100644
--- a/src/target/riscv/riscv-013.c
+++ b/src/target/riscv/riscv-013.c
@@ -4463,7 +4463,9 @@ static int riscv013_test_sba_config_reg(struct target *target,
uint32_t rd_val;
uint32_t sbcs_orig;
- dmi_read(target, &sbcs_orig, DM_SBCS);
+ int retval = dmi_read(target, &sbcs_orig, DM_SBCS);
+ if (retval != ERROR_OK)
+ return retval;
uint32_t sbcs = sbcs_orig;
bool test_passed;
-----------------------------------------------------------------------
Summary of changes:
src/target/riscv/riscv-013.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-23 21:22:41
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 8683526af7a9ca23115d26deb5b4835cd6be05d8 (commit)
from cde944fd8b9cd5eb67617aa3b68dc13eb49b1d10 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 8683526af7a9ca23115d26deb5b4835cd6be05d8
Author: Antonio Borneo <bor...@gm...>
Date: Mon Sep 19 11:36:06 2022 +0200
target/dsp563xx: fix scan-build warning
Scan-build triggers a warning:
Unix API: Allocator sizeof operand mismatch
dsp563xx.c:2143 Result of 'calloc' is converted to a pointer
of type 'uint8_t', which is incompatible with sizeof
operand type 'uint32_t'
It's a false positive because calloc() is properly used in this
case, as the uint8_t array is used in blocks of 4 elements to read
or write uint32_t values.
Either
calloc(sizeof(uint32_t), count);
and
malloc(count * sizeof(uint32_t));
keep triggering the same warning.
Drop the warning by using the constant '4' as size of uint32_t, as
already used few lines below.
Change-Id: I5bb1ece177774eefdc5d9cd049338f8f2be87cd7
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7203
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <and...@gm...>
diff --git a/src/target/dsp563xx.c b/src/target/dsp563xx.c
index 3702cfb4c..36ee85371 100644
--- a/src/target/dsp563xx.c
+++ b/src/target/dsp563xx.c
@@ -2140,7 +2140,7 @@ COMMAND_HANDLER(dsp563xx_mem_command)
COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], count);
}
- buffer = calloc(count, sizeof(uint32_t));
+ buffer = calloc(count, 4);
if (read_mem == 1) {
err = dsp563xx_read_memory(target, mem_type, address, sizeof(uint32_t),
-----------------------------------------------------------------------
Summary of changes:
src/target/dsp563xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-23 21:21:03
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via cde944fd8b9cd5eb67617aa3b68dc13eb49b1d10 (commit)
via eb3d5c1a945fb09a76d9d4cb20aba903fc6e53c2 (commit)
from bb8d37ddf12a2ad76ede129b63522bfa2940d34e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit cde944fd8b9cd5eb67617aa3b68dc13eb49b1d10
Author: Antonio Borneo <bor...@gm...>
Date: Mon Sep 19 10:31:30 2022 +0200
jtag/adapter: fix doxygen warning
Doxygen complains about:
adapter.h:120: warning: Unsupported xml/html tag <signal_name> found
Move the text in double quote to remove the warning.
Change-Id: Ia4ead5caa83c84e10ee2b2359048c282892170b0
Signed-off-by: Antonio Borneo <bor...@gm...>
Fixes: 82fd4005427b ("jtag/adapter: Add command 'adapter gpio'")
Reviewed-on: https://review.openocd.org/c/openocd/+/7202
Tested-by: jenkins
diff --git a/src/jtag/adapter.h b/src/jtag/adapter.h
index 625a0b269..682fc10ae 100644
--- a/src/jtag/adapter.h
+++ b/src/jtag/adapter.h
@@ -117,7 +117,7 @@ const char *adapter_get_required_serial(void);
const char *adapter_gpio_get_name(enum adapter_gpio_config_index idx);
/**
- * Retrieves gpio configuration set with command 'adapter gpio <signal_name>'
+ * Retrieves gpio configuration set with command "adapter gpio <signal_name>"
*/
const struct adapter_gpio_config *adapter_gpio_get_config(void);
commit eb3d5c1a945fb09a76d9d4cb20aba903fc6e53c2
Author: Antonio Borneo <bor...@gm...>
Date: Mon Sep 19 10:29:20 2022 +0200
doc: fix copyright dates
The copyright date for OpenOCD project has never been updated.
Add the range till current year.
Change-Id: I42c7e3b2bf2e3a486bf836d063460dfa7b40d24d
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7201
Tested-by: jenkins
diff --git a/doc/openocd.texi b/doc/openocd.texi
index fc86429d1..2a8626b80 100644
--- a/doc/openocd.texi
+++ b/doc/openocd.texi
@@ -19,7 +19,7 @@ dated @value{UPDATED},
of the Open On-Chip Debugger (OpenOCD).
@itemize @bullet
-@item Copyright @copyright{} 2008 The OpenOCD Project
+@item Copyright @copyright{} 2008-2022 The OpenOCD Project
@item Copyright @copyright{} 2007-2008 Spencer Oliver @email{spen@@spen-soft.co.uk}
@item Copyright @copyright{} 2008-2010 Oyvind Harboe @email{oyvind.harboe@@zylin.com}
@item Copyright @copyright{} 2008 Duane Ellis @email{openocd@@duaneellis.com}
-----------------------------------------------------------------------
Summary of changes:
doc/openocd.texi | 2 +-
src/jtag/adapter.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-23 21:20:56
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via bb8d37ddf12a2ad76ede129b63522bfa2940d34e (commit)
from b89cf71e2b5e4dc2c31cf085aec7a19515e2a9d6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit bb8d37ddf12a2ad76ede129b63522bfa2940d34e
Author: Antonio Borneo <bor...@gm...>
Date: Tue Sep 20 12:08:55 2022 +0200
checkpatch: fix for flag --no-tree
When checkpatch is run with command line flag --no-tree, it cannot
find local 'companion' files and has to skip loading them.
This has caused issues with change https://review.openocd.org/7211
on jenkins.
Skip loading 'tools/scripts/camelcase.txt' with flag --no-tree.
While there, rewrite the associated error message.
Change-Id: I6ede7b16f9ccd77b9118fd9be7ada07a1ac96952
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7212
Tested-by: jenkins
diff --git a/tools/scripts/checkpatch.pl b/tools/scripts/checkpatch.pl
index 10b0b8c25..9dda61cde 100755
--- a/tools/scripts/checkpatch.pl
+++ b/tools/scripts/checkpatch.pl
@@ -995,8 +995,10 @@ sub read_words {
# OpenOCD specific: Begin: Load list of allowed CamelCase symbols
if (show_type("CAMELCASE")) {
- my $allowed_camelcase_file = "$root/tools/scripts/camelcase.txt";
- if (open(my $words, '<', $allowed_camelcase_file)) {
+ my $allowed_camelcase_file = "tools/scripts/camelcase.txt";
+ if (!$root) {
+ warn "Ignore list of allowed camelcase symbols.\n";
+ } elsif (open(my $words, '<', "$root/$allowed_camelcase_file")) {
while (<$words>) {
my $line = $_;
@@ -1012,9 +1014,9 @@ if (show_type("CAMELCASE")) {
$camelcase{$line} = 1;
}
- close($allowed_camelcase_file);
+ close("$root/$allowed_camelcase_file");
} else {
- warn "No camelcase symbols to ignore - file '$allowed_camelcase_file': $!\n";
+ warn "Failed opening file '$root/$allowed_camelcase_file': $!\n";
}
}
# OpenOCD specific: End
-----------------------------------------------------------------------
Summary of changes:
tools/scripts/checkpatch.pl | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-18 17:54:23
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The annotated tag, v0.12.0-rc1 has been created
at f3624a23da875fbdc9acb3c968103aae1f914a91 (tag)
tagging 5e7612eb4c87e8e7a7000b42ff5d0f7e5c70fc42 (commit)
replaces v0.11.0
tagged by Paul Fertser
on Sun Sep 18 16:55:46 2022 +0300
- Log -----------------------------------------------------------------
The openocd-0.12.0-rc1 release.
Adrian Negreanu (4):
cmsis_dap: remove DAP_MAX_CLOCK
armv7m_trace_itm_config: wait for ITMBusy to be cleared
cmsis-dap: don't update the packet size across backends.
cmsis_dap: add support for swo commands
Adrien Grassein (2):
jtag: Add an option to ignore the bypass bit
tcl: ngultra: add target config file
Alex Crawford (2):
driver/linuxgpiod: add support for opendrain srst
drivers/linuxgpiod: add support for opendrain trst
Alvin Å ipraga (1):
tcl/target/imx8m: use hwthread rtos
Andreas Bolsch (1):
Update jtagspi driver for 1-, 2- and 4-byte addresses
Andreas Fritiofson (4):
contrib: add an example of using list.h
config/ftdi: Add tristate capability to sheevaplug config
Remove remaining references to FTD2XX driver
cortex_m: Restore fast register reads if no polling is needed
Andreas Sandberg (2):
hla: Increase HLA_MAX_USB_IDS
stlink: Add PID for V3 device without MSD
Andrew Wesie (2):
tcl/interface/ftdi: Add miniWiggler debugger config
tcl/interface/ftdi: Add PLS SPC5 debugger config
Anthony Ferranti (1):
eMAG: Add Ampere eMAG config files
Antonio Borneo (373):
drivers/rlink: switch to libusb1
stlink: fix execution order in stlink_config_trace()
itm: rework itm commands before 'init'
arm_tpiu_swo: add support for independent TPIU and SWO
tcl/target: start using the new TPIU/SWO support
armv7m_trace: get rid of the old tpiu code
server: revert commit 7e6556b3cad8
jtag/nulink: add a space after PRIx32
stlink: swo: use completely the available buffer
jimtcl: update to version 0.80 (2020-10-29)
configure.ac: switch to autoconf 2.69
target/arm720t: remove command 'arm720t cp15' deprecated in v0.4.0
target/arm920t: remove command 'arm920t cp15i' deprecated in v0.4.0
openocd: remove command line flag -p/--pipe deprecated in v0.5.0
startup.tcl: remove commands already deprecated in v0.7.0
target: remove target names already deprecated in v0.8.0
target: remove handling of target's deprecated_name
oocd_trace: drop the code, deprecated in v0.10.0
ioutil: drop the code, deprecated in v0.10.0
zy1000: drop the code, deprecated in v0.10.0
jtag: remove minidriver code and minidriver-dummy
README: update requested autoconf version 2.69
jimtcl: add temporary workaround for memory leak in jimtcl 0.80
udev rules: add missing ftdi USB VID/PID
udev rules: add missing Altera USB Blaster devices
drivers/usbprog: switch to libusb1
drivers/arm-jtag-ew: switch to libusb1
openocd: drop dependency from libusb0
LICENSES: move the GPL-2.0 license as required by checkpatch
LICENSES: add the GPL-3.0 license for stand-alone code
LICENSES: add the GFDL-1.2 license
LICENSES: add the BSD 1-clause license
LICENSES: add 'license-rules.txt'
mem_ap: allow GDB connections
doc: [1/3] uniform the texinfo syntax for commands definition
doc: [2/3] uniform the texinfo syntax for commands definition
doc: [3/3] uniform the texinfo syntax for commands definition
helper/command: always pass struct command as jim private data
helper/command: use one single handler for all the commands
helper/command: get current target from dedicated API
helper/command: override target only on target prefixed cmds
helper/command: pass command prefix to command registration
command mode: return "any" for tcl proc
help: re-implement 'help' independent from tree of struct command
helper/command: register full-name commands in jim
helper/command: simplify run_command()
helper/command: simplify jim_command_mode()
helper/command: unregister commands through their full-name
helper/command: get rid of the tree of struct command
helper/command: make script_debug() static
helper/command: rename s/command_unknown/jim_command_dispatch/
smp: move command deprecation to startup.tcl
doc: annotate configuration commands
doc: do not document commands that are already deprecated
doc: command 'ftdi_layout_signal' can run after config
board: imx53: fix l2 cache initialization
tcl/at91/sam9_smc: fix syntax errors
helper/command: fix build with jimtcl 0.79 or older
libusb: don't use typedef's
helper/replacements: remove unused typedef's
helper/types: remove type '_Bool'
helper/jim-nvp: remove unused function Jim_nvpInit()
helper/command: fix memory leak on malloc() fail
helper/command: drop the TCL variable 'ocd_HOSTOS'
jtag: simplify the calls to Jim_SetResultFormatted()
telnet: allow hiding selected commands during auto-completion
telnet/auto-complete: hide deprecated and internal commands
startup.tcl: prepare for jimtcl 0.81 'expr' syntax change
tcl: [1/3] prepare for jimtcl 0.81 'expr' syntax change
tcl: [2/3] prepare for jimtcl 0.81 'expr' syntax change
tcl: [3/3] prepare for jimtcl 0.81 'expr' syntax change
coding-style: additional style for C code
jimtcl: restrict memory leak workaround on Linux only
cmsis_dap: fix build on macOS
target/arm_dpm: rename 'wp_pc' as 'wp_addr'
target/aarch64: fix watchpoint management
tcl/rp2040: remove empty line at end of file
tcl: fix some minor typo
flash: fix some minor typo
jtag: fix some minor typo
target: fix some minor typo
openocd: fix some minor typo
helper/command: silent debug msg on command register/unregister
mem_ap: fix target arch_info type
riscv: drop unused variable
riscv: replace macro DIM() with ARRAY_SIZE()
drivers/versaloon: use ARRAY_SIZE()
openocd: use macro ARRAY_SIZE()
rtos: use ARRAY_SIZE() and simplify rtos_type.create()
tcl: remove remaining deprecated commands
help text: remove trailing space
help: fix line size in 'usage' output
stlink: add comment of firmware version for each flag bit
stlink: reorder the flag macro by firmware release
target/cortex_a: fix number of watchpoints
target/cortex_a: add support for watchpoint length of 1, 2 and 4 bytes
target/cortex_a: fix memory leak on watchpoints
helper/jim-nvp: comply with coding style [1/2]
helper/jim-nvp: comply with coding style [2/2]
server/telnet: fix autocomplete for jimtcl commands
helper/list.h: align file to Linux v5.12
helper/list.h: add mention to the example in contrib
armv7m: replace flag 'stlink' with 'is_hla_target'
stlink: fix SIGSEGV with libusb v1.0.24-33-g32a2206 (11618)
flash/nor/cfi: fix CamelCase symbols in cfi_spansion_pri_ext
flash: rename CamelCase symbols
helper: rename camelcase symbols
jtag: rename CamelCase symbols
jtag/swd: rename CamelCase macros
server: rename CamelCase symbols
rtos: convert CamelCase enum in uppercase
rtos: rename CamelCase symbols
rtos/eCos: rename CamelCase symbols
target/arm: rename CamelCase symbols
target/cortex_m: rename CamelCase symbol
target/arm: opcodes: rename CamelCase symbols and uppercase variables
target/mips: rename CamelCase symbols
target/nds32: rename CamelCase symbols
svf: rename CamelCase label
jtag/aice: use macros in place of const variables
drivers/buspirate: use macros in place of const variables
flash: use lowercase for C variables
target/nds32: use lowercase for C variables
flash/nor: convert enum in uppercase
openocd: fix simple cases of Yoda condition
openocd: manually fix Yoda conditions
target: rename CamelCase symbols
openocd: fix simple cases of NULL comparison
openocd: remove NULL comparisons with checkpatch [1/2]
openocd: remove NULL comparisons with checkpatch [2/2]
openocd: manually remove NULL comparisons
openocd: fix Yoda conditions with checkpatch
jtag/aice: fix build with clang on MacOS
helper: add align.h
helper/align.h: use it
arm_adi_v5: fix signed offset in Class 0x1 ROM tables
arm_adi_v5: fix access to 64-bit MEM-AP
openocd: fix cleanup order: cti before dap
arm_adi_v5: use macro DP_APSEL_MAX in place of magic number
jtag/mpsse: fix SIGSEGV for use after free
stlink: fix SWIM mode on stlink-v3
cortex_m: fix command 'step address'
command: log the command only when it is executed
arm_adi_v5: update coresight class names
jep106: use packed jedec manufacturer code
cortex_a: use the ap number specified at target create
helper: remove fix for libusb pre-v1.0.9
Makefile: drop warning suppression on win build
openocd: prepare for jimtcl 0.81 'expr' syntax change
jimtcl: update to master branch 20210715
openocd: remove last NULL comparisons
target: do not cast NULL in assignment
armv7m.h: relax dependency from 'arm_adi_v5.h'
arm_coresight: add include file and use it
arm_adi_v5: simplify handling of AP type
arm_adi_v5: add helper to search for part number
arm_adi_v5: add arm SoC-600 part numbers
arm_adi_v5: add arm Cortex-R52 part numbers
arm_adi_v5: add arm Neoverse N2 part numbers
arm_adi_v5: drop ANY_ID from table dap_part_nums
arm_tpiu_swo: fix support for deprecated 'tpiu' command before 'init'
openocd: prevent jimtcl error message while testing commands
udev: add ASIX Presto programmer
stlink-dap: add 'cmd' to send arbitrary commands
jtag/core: fix unused assignment
arm_tpiu_swo: fix two dead assignments
arm_semihosting: fix two dead assignments
armv8: fix five dead assignments
target/lakemont: fix dead assignment
mips64_pracc: fix three dead assignments
command: document enum command_mode
flash/nor/psoc6: fix doxygen comment
tcl/stm32mp15x: freeze watchdog, recover SWD after power cycle
openocd: remove 'src' prefix from #include path
riscv: use relative path to include contrib's data
hla: improve readability of struct hl_interface_s initialization
jtag/aice: remove unused exported struct aice_interface_param_s
jtag/core: remove unused variable
stlink: check buffer size on 16 and 32 bit memory transfer
stlink: add queue in dap-direct mode
stlink: expose ap number and csw in memory r/w
stlink: detect mem_ap R/W and dequeue set TAR and CSW
stlink: collapse consecutive mem AP r/w in a single command
stlink: add support for native no_addr_incr commands
stlink: dequeue CSW write only if it doesn't change csw_default
stlink: add support for rw-misc commands
stlink: skip rw-misc commands with TCP server
Makefile: remove workaround for jimtcl 0.80
jimtcl: revert temporary workaround for memory leak in jimtcl 0.80
jtag/core: get rid of variable 'jtag'
jtag/adapter: move 'usb location' code in adapter.c
jtag: move adapter init/quit and speed to adapter.c
jtag/adapter: move config vars in struct adapter_config
jtag: move prototype of adapter init/quit and speed to adapter.h
jtag: align adapter speed code to new structure
jtag: remove file driver.h
jtag/adapter: fix memory leak on usb location
jtagspi: fix build on MacOS
cortex_m: poll S_REGRDY on register r/w
arm_adi_v5: add missing enum DORMANT_TO_JTAG
cmsis_dap: add support for dormant-to-jtag
drivers/bitbang: add support to switch to/from dormant state
jlink: add support to switch to/from dormant state
ftdi: add support to switch to/from dormant state
adi_v5_swd: add comment to describe debug flag 'do_sync'
jimtcl: update to master branch 20211108
openocd: use single line for register_commands*()
openocd: use unique name for struct command_registration
openocd: declare struct command_registration in a single line
flash/rp2040: don't initialize to NULL fields in struct
flash/psoc6: initialize usage field
doc: remove non-existing command riscv set_scratch_ram
doc: remove non-existing command swd wcr
doc: remove non-existing command readgroup
doc: fix typos in commands definition
jtag/adapter: add command 'adapter serial'
jtag/aice: switch to command 'adapter serial'
jtag/cmsis_dap: switch to command 'adapter serial'
jtag/ft232r: switch to command 'adapter serial'
jtag/ftdi: switch to command 'adapter serial'
jtag/kitprog: switch to command 'adapter serial'
jtag/presto: switch to command 'adapter serial'
jtag/vsllink: switch to command 'adapter serial'
jtag/xds110: switch to command 'adapter serial'
jtag/jlink: switch to command 'adapter serial'
jtag/hla, jtag/stlink: switch to command 'adapter serial'
drivers: call adapter_get_required_serial() in jtag_libusb_open()
jimtcl: update to version 0.81 (2021-11-28)
tcl: stm32mp13x: add target and board config files
cortex_m: remove last references to debugport_init()
adi_v5_swd: add jtag-to-swd through dormant
openocd: add keep_alive during command sleep
gdb_server: fix a comment in gdb_new_connection()
semihosting: use macro COMMAND_HANDLER
doc: use the new jimtcl syntax for 'expr'
aarch64: dump a message when CTI is missing
log: fix memory leak when log to file is enabled
target: use target_event_name()
target/smp: use a struct list_head to hold the smp targets
helper/list: add list_for_each_entry_direction()
doxygen: fix some function prototype description
server: remove remaining crust from dropped eCos code
.gitmodules: switch away from repo.or.cz
gdb_server: fix double free
gdb_server: check target examined while combining reg list
tcl: don't use 'set' to retrieve the value of a variable
jimtcl: add configure flag for build maintainer mode
server: fix: remove kept_alive() from server loop
log: drop global current_time
server: change prototype of add_service()
gdb_server: simplify logic to enable/disable gdb_log_callback()
keep-alive: drop link with log framework
breakpoints: fix build on -fno-inline
semihosting: fix mode flags for local host open()
arm_tpiu_swo: fix autodetection of SWO pin frequency
openocd: include config.h in every file .c
helper/bits: add BIT_ULL and GENMASK macros
nds32: deprecate it, together with aice adapter driver
server/gdb: fix return of gdb remote monitor command
smp: deprecate legacy SMP core switching support
server/gdb: fix gdb remote monitor cmd on multi-target
target: fix build with jimtcl 0.79
arm_coresight: define ARM_CS_CIDR_CLASS()
adi_v5_jtag: reduce verbosity on persistent WAIT
arm_adi_v5: describe Class 0x9 Device Architecture register
arm_adi_v5: rework dap_read_part_id()
arm_adi_v5: split ROM table loop from generic coresight
arm_adi_v5: report sysmem on class 0x9 ROM tables
arm_adi_v5: handle faulting entry in ROM table
arm_adi_v5: separate ROM table parsing from command output [1/3]
arm_adi_v5: separate ROM table parsing from command output [2/3]
arm_adi_v5: separate ROM table parsing from command output [3/3]
arm_adi_v5: abstract actions during ROM table parsing
arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase
arm_adi_v5: replace dap_lookup_cs_component()
arm_adi_v5: add support for 64bit Class 0x9 ROM tables
aarch64: don't wait for smp targets halted in deassert reset
openocd: add post-init and pre-shutdown helpers
.gitignore: add cross-compile *-libtool
arm_adi_v5: fix scan-build warning [1/3]
arm_adi_v5: fix scan-build warning [2/3]
arm_adi_v5: fix scan-build warning [3/3]
drivers/bitbang: silence scan-build warning
arm_adi_v5: check for calloc() return value
arm_adi_v5: add ap refcount and add get/put around ap use
adi_v5_jtag: clear sticky overrun error
adiv6: add low level swd transport
adiv6: use struct adiv5_ap->ap_num to contain the AP base address
arm_adi_v5: add option 'root' to 'dap info' command
adiv6: prepare for AP level ROM tables
adiv6: add support for ROM tables in AP
adiv6: stay in same AP during dap_lookup_cs_component()
arm_adi_v5: parse ROM tables behind SoC-600 APv1 adapter
aarch64: fix handling of 'reset halt'
drivers/linuxgpiod: release gpio at exit
drivers/linuxgpiod: simplify gpio release
semihosting: remove comparison with NULL
tcl/interface/vdebug: add newline to file's last line
tcl/board/steval-idb012v1: fix SPDX tag
tcl: replace FSF boilerplate with SPDX tag
tcl: move SPDX tag as first line
tcl/target: add SPDX tag
tcl/board: add SPDX tag
tcl/interface: add SPDX tag
tcl: add SPDX tag
helper: fix build with mingw gcc 12.1.0
target: esp_xtensa_smp: fix clang report
openocd: build: add SPDX tag
openocd: src: remove duplicated GPL license tag
openocd: src: add GPL license tag on files that miss it
openocd: src: replace the BSD-3-Clause license tag
openocd: src: replace the BSD-2-Clause-Views license tag
openocd: src: replace the GPL with eCos exception 2.0 license tag
openocd: src: replace the GPL and BSD-Source-Code license tags
openocd: src: replace the incomplete GPL-2.0-or-later license tag
openocd: src: replace the GPL-2.0-only license tag
openocd: src: fix incorrect GPL license tag
openocd: src: fix incorrect SPDX tags
openocd: src/flash: replace the GPL-2.0-or-later license tag
openocd: src/helper: replace the GPL-2.0-or-later license tag
openocd: src/jtag: replace the GPL-2.0-or-later license tag
openocd: src/rtos: replace the GPL-2.0-or-later license tag
openocd: src/target: replace the GPL-2.0-or-later license tag
openocd: src: replace the GPL-2.0-or-later license tag
openocd: src: replace SPDX to remaining files
helper/jim-nvp: avoid camelcase error by deprecated API
target: add API to temporarily mask target polling
openocd: prevent target polling during 'init'
tcl/target: replace event trace-config
tcl/target: stm32[fl]4x: document the settings for trace
doc: how to use QEMU to test big-endian build
flash/nor: remove empty command definitions
jtag/vdebug: remove BSD-2-Clause boilerplate
jep106: add SPDX tag and JEDEC copyright
jep106: update to revision JEP106BE Jan 2022
openocd: remove recently added CamelCase symbols
openocd: remove CamelCase symbols *xPSR*
openocd: fix syntax of SPDX tags
contrib: replace the GPLv3-or-later license tag
contrib: replace the BSD-3-Clause license tag
contrib: replace the GPLv2-or-later license tag
contrib: add GPL license tag on files that miss it
.gitignore: remove cross-compile *-libtool
log: remove unused set_log_output()
jtag: make local symbols static
riscv: make local symbols static
xtensa: make local symbols static
target: make local symbols static
flash/nor/npcx: make local symbols static
riscv: don't export local symbols
usbprog: remove unused variable
flash/nor: move variable's declaration in C file
target: don't export local symbols
openocd: fix for polling during "expr" computation
configure.ac: drop unneeded dependency check
src/jtag/drivers/ep93xx: fix GCC 12 warning
tcl/interface: replace last deprecated commands
mips64: remove empty mips_mips64_soft_reset_halt()
checkpatch: import new script version from kernel v6.0-rc3
checkpatch: add OpenOCD specific config flags
checkpatch: add variable $OpenOCD
checkpatch: don't spell-check the spelling file
checkpatch: add list of typedef used in OpenOCD
checkpatch: check for SPDX tags of licenses in use
checkpatch: adapt shell script to the tool's new version
checkpatch: increase the max indentation level
checkpatch: add commit-message field to ignore some check
checkpatch: enable CAMELCASE test
checkpatch: extend check for camel[0-9_]*CASE
checkpatch: fix path of documentation
HACKING: add chapter on checkpatch
openocd: fix SPDX tag format for files .c
The openocd-0.12.0-rc1 release candidate
Antony Pavlov (1):
checkpatch: check for OpenOCD tree, not for kernel tree
Asier Llano (1):
rtos: Support for "none" rtos
Ben Bender (1):
arm_adi_v5: Adding Nuvoton NPCX quirk
Ben McMorran (2):
gdb_server: Include thread name as XML attribute
rtos: threadx: Add hla_target support for ThreadX
Bohdan Tymkiv (1):
target/arm_jtag.h: fix wrong comparison in arm_jtag_set_instr
Cheng-Shiun Tsai (1):
Aarch64:Switch to EL1 from EL0 before manipulate MMU
Chengyu Zheng (1):
target/cortex_a: add support for watchpoints
Christian Hoff (2):
aarch64: add support for "reset halt"
target/image: report error if ELF file contains no loadable sections
Daniel Anselmi (1):
Add IPDBG JtagHost functionality to OpenOCD
Daniel Goehring (2):
target: add 64-bit address array command support
target/board: Add Ampere QS|MQ config files
Diego Herranz (1):
contrib/itmdump.c: fix implicit declaration warning
Doug Brunner (2):
flash/nor/efm32: fixed BG1x identification
flash/nor/efr32: fixed lockbits and user data
Erhan Kurubas (26):
flash: fix clang static analyzer build errors
semihosting: add semihosting_basedir command
configure: build jimtcl with json extension
target: add Espressif ESP32-S2 basic support
telnet_server: fix valgrind error
tcl: add get_bit & get_bitfield memory helper functions
semihosting: fix accessing memory outside the bounds of the fn array
target: add Espressif ESP32 basic support
target: add Espressif ESP32-S3 basic support
esp32s2: convert counted timeout to timeval_ms
semihosting: add custom user command handler
jtag: add esp_usb_jtag driver
tcl/esp32s2: check memory protection on gdb attach
tcl/esp32s3: check memory protection on gdb attach
semihosting: move semihosting_result_t from riscv.h to the semihosting_common.h
target/semihosting: export semihosting_common_handlers[] from header file
adapter: run at default speed when clock speed not specified
loaders/reset/espressif: replace the GPL-2.0-or-later license tag
target/espressif: remove author lines from esp32xx and xtensa files
target/semihosting: drop type casting from semihosting->result
target/xtensa: fix clang analyzer warnings and gcc12 build errors
flash/nor/kinetis: fix clang scan-build error format-truncation
target/espressif: add semihosting support
server: add function to get openocd shutdown status
tcl/board: add ESP32 config for ESP USB Bridge board
tcl/board: add ESP32-S3 config for ESP USB Bridge board
Evgeniy Didin (2):
target/arc: refactor ARC register numbers defines
rtos: Add support for Zephyr RTOS
Felipe Balbi (1):
Add configuration file for Olimex H405
Florian Fainelli (4):
tcl: Update Flyswatter product links
arm_adi_v5: Provide Brahma-B53 identifiers
arm_adi_v5: Added Cortex-A76 identifiers
arm_adi_v5: add support for display Class 0x9 ROM tables
Florian Meister (1):
target/image: allow loading of 64-bit ELF files
Florian Zaruba (1):
jep106.inc: Update to revision JEP106BC
Frank Dischner (3):
FreeRTOS: Fix current thread ID when no threads are active
FreeRTOS: Always show current execution before scheduler is started
FreeRTOS: Fix thread reg list for Cortex-M7
Gabor Csapo (1):
libusb_helper.h: Increase USB timeout
Hans-Erik Floryd (2):
flash/nor/atsame5: add LAN9255 devices
tcl/board: Add EVB-LAN9255 config
Ian Thompson (14):
gdb_server: add "not supported" Z-packet reply
gdb_server: support sparse register maps
gdb_server: custom target-specific GDB queries
target: add generic Xtensa LX support
Generic Xtensa target config files
target/xtensa: fix clang analyzer warnings
target/xtensa: virtualize XDM registers
target/xtensa: enable DAP/SWD for generic xtensa
target/xtensa: DAP-based Xtensa config files
target/xtensa: fix step state transition
target/xtensa: fully initialize buffers for PWRSTAT read
target/xtensa: populate PS correctly during fetch
target/xtensa: fix clang analyzer warning
target/xtensa: invalidate register cache on reset
Jacek Wuwer (2):
Cadence virtual debug interface (vdebug) integration
drivers/vdebug: add support for DAP level interface
Jae Hyun Yoo (2):
tcl/fpga: add Lattice MachXO3 family support
tcl/interface: add linuxgpiod cfg for Aspeed AST2600
Jaehoon Park (1):
flash/nor/spi: add micron MT25QU01G
Jan Matyas (18):
gdb_server: Log both incoming and outgoing GDB packets
flash/nor: improved API of flash_driver.info & fixed buffer overruns
target: check return value of register get/set callbacks
target/semihosting: Capture errno in SEMIHOSTING_SYS_ISTTY
target/semihosting: Fix of close(): Never close standard streams
target: add support for 64bit data in mem2array and array2mem
.github/workflows: Add missing 'apt-get update' to the snapshot workflow
flash/nor/atsamv: fixed "maybe uninitialized" compiler warning
rtos: add debug prints for qSymbol lookup
helper/log: Add macros for target-related errors/warnings/...
riscv: Regenerated debug_defines.h and encoding.h
drivers/jtag_vpi: Added "jtag_vpi:" prefixes to log messages
gdb_server: added and improved several debug prints
doc: Update doc for commands "riscv expose_csrs" and "riscv expose_custom"
doc: Updated RISC-V memory-related cmds in documentation
jtag_vpi: Minor cleanup in jtag_vpi driver
gdb_server: Improve logging of GDB-remote packets
target/image: fix - p_flags field in ELF64 segment headers is 64 bits wide
Janco Kock (1):
flash/nor/at91samd: Add SAMR35J18B support
Jesse Sheridan (1):
target/riscv: Implement get_gdb_arch()
Jian-Hong Pan (2):
tcl/board: Add Raspberry Pi 3 board
tcl/board: Add Raspberry Pi 4 model B board
Jimmy (1):
flash/nor/stm32lx: fixed writes at high adapter speeds
Jiri Kastner (2):
tcl/target: add Rockchip RK3399 target
udev rules: add OSBDM device
Joerg Wunsch (1):
Add Microchip SAME51 Curiosity Nano board
Julien Massot (3):
rtos: zephyr: add zephyr_params for cortex r4
aarch64: support for aarch32 ARM_MODE_UND
rtos: zephyr: do not use deprecated symbols name
Kevin Burke (8):
target/adiv5: Large Physical Address Extension
arm_adi_v5: move in a separate function devtype decode/display
arm_adi_v5: add arm Neoverse N1 part numbers
adiv6: add dap flags -adiv5 and -adiv6
adiv6: re-organize mem_ap registers definition
adiv6: read ROM Table address size
adiv6: add low level jtag transport
adi_v5_jtag: extend memaccess_tck to every AP access
Laszlo Sitzer (1):
linuxgpiod: Allow using multiple GPIO chips.
Leonard Crestez (1):
target/imx8qm: Initial support
Liming Sun (1):
target/aarch64: Add watchpoint support
Luis de Arquer (1):
drivers/ftdi: drscan: Skip DR-PAUSE when endstate == IDLE
MadSquirrel (1):
server/gdb_server: Add support for default thread, use by IDA debugger
Marc Schink (75):
rtos: Remove typedef'd struct
flash/nand/lpc32xx: Remove typedef'd struct
target/mips: Remove typedef'd struct
flash/nor/stmqspi: Replace macros with static inline functions
doc/manual/style: Do not use 'Yoda conditions'
doc/manual/style: Fix comments
flash/nor/numicro: Use 'bool' data type
flash/nor/nrf5: Fix data types and const correctness
target/stm8: Make 'stm8_command_handlers' static
target/riscv: Change 'authdata_read' output
flash/nor/xcf: Do not use 'Yoda conditions'
tcl/board: Add ST NUCLEO-8S208RB
drivers/jlink: Remove trailing dots
target: Use 'bool' for 'reset_halt'
target/startup.tcl: Do not use 'Yoda conditions'
target/cortex_a: Use bool data type
target: Rename 'linked_BRP' to 'linked_brp'
target/register: Minor code cleanup
Use boolean argument for register_get_by_name()
doc/openocd: Fix typo
target/dsp563xx: Handle return values
target/dsp563xx: Use bool data type for 'hardware_breakpoints_cleared'
target/breakpoints: Remove dead code and cleanup
flash/nor/stm32l4: Fix stm32l4_probe()
target/stm8: Remove unused member 'stm8_common'
target/mips64: Replace printf() with LOG_ERROR()
target/aarch64: Replace printf() with LOG_DEBUG()
target/cortex_a: Replace printf() with LOG_DEBUG()
drivers/ftdi: Group adapter commands
tcl: Adapt config files to new ftdi command syntax
flash/nor: Do not update 'is_erased'
drivers/parport: Group adapter commands
tcl/interface: Adapt config files to new parport command syntax
drivers/openjtag: Group adapter commands
tcl/interface/openjtag: Adapt to new openjtag command syntax
drivers/remote_bitbang: Group adapter commands
drivers/presto: Group adapter commands
drivers/xlnx-pcie-xvc: Group adapter commands
drivers/ulink: Group adapter commands
drivers/vsllink: Group adapter commands
drivers/jtag_dpi: Group adapter commands
tcl/interface/jtag_dpi: Adapt to new jtag_dpi command syntax
drivers/bcm2835gpio: Group adapter commands
tcl/interface: Adapt config files to new bcm2835gpio command syntax
drivers/jtag_vpi: Group adapter commands
tcl/interface/jtag_vpi: Adapt to new jtag_vpi command syntax
drivers/linuxgpiod: Group adapter commands
tcl/interface/dln-2-gpiod: Adapt to new linuxgpiod command syntax
drivers/sysfsgpio: Group adapter commands
tcl/interface: Adapt config files to new sysfsgpio command syntax
drivers/buspirate: Group adapter commands
tcl/interface/buspirate: Adapt to new buspirate command syntax
doc/openocd: Fix buspirate example
drivers/usb_blaster: Group adapter commands
tcl: Adapt config files to new usb_blaster command syntax
drivers/ft232r: Group adapter commands
tcl/board/arty_s7: Fix proc and chip name
contrib/udev: Add missing J-Link USB PID
target/tcl: Add set_reg function
target/tcl: Add get_reg function
target/arm_tpiu: Make error message easier to understand
target/arm_tpiu: Fix 'tpiu create' parameter check
target/arm_tpiu: Fix usage of 'tpiu create'
flash/nor/sim3x: Fix typo
flash/nor/efm32: Use Cortex-M 'core_info' field
target/tcl: Add 'read_memory' and 'write_memory'
target: Deprecate 'array2mem' and 'mem2array''
Remove all occurrences of 'mem2array' and 'array2mem'
target: Rework 'set' variable of break-/watchpoints
tcl/tools: Add function to measure the speed of ARM Cortex-M devices
drivers/cmsis-dap: Remove stray whitespace
tcl/board: Add NXP FRDM-K64F
target/arm_cti: Fix error handling in 'cti create'
libjaylink: Update to 0.3.1 release
flash/nor/stm32lx: Add revision 'X' for Cat.4/3 devices
Marek Vasut (3):
tcl/target: Select default boot core on Renesas R-Car Gen2/Gen3
tcl/target: Add support for Renesas R8A779A0 V3U SoC
tcl/board: Add Renesas Falcon board
Markus Reiter (4):
tcl/target/stm32f4x: fix name
tcl/target/stm32l4x: set default WORKAREASIZE to smallest device
tcl/target/stm32l4x: switch to new TPIU/SWO support
tcl/target/stm32l4x: align format/order/comments with stm32f4x
Martin Hierholzer (1):
fix Kinetis 100 MHz rev 1.x programming
Matthew Mets (3):
drivers/bcm2835: Add support for SWDIO direction control pin
interface/jtag_hat: Add interface configuration for the JTAG HAT
doc/openocd.texi: Add documentation for bcm2835 interface
Mischa Studer (1):
flash/nor/cfi: fix uninitialized write-mem pointer
Nishanth Menon (16):
tcl/target: Add K3 basic support
tcl/board: Add AM654 EVM basic support
tcl/board: Add J721E EVM basic support
tcl/board: Add J7200 EVM basic support
tcl/board: Add AM642 EVM basic support
tcl/target/ti_k3: Remove args from m3 and m4_up
tcl/target/ti_k3: Add a gdb-attach event hook for m3 and m4
tcl/target/ti_k3: Rename m3 target as sysctrl
tcl/target/ti_k3: Rename m4 target as general purpose mcu
tcl/target/ti_k3: Rename R5 targets to be more descriptive
tcl/target/ti_k3: Add a gdb-attach event hook for r5 and simplify startup function
tcl/target/ti_k3: Add a gdb-attach event hook for armv8 and simplify startup function
tcl/target/ti_k3: Add J721S2 SoC
tcl/board: Add J721s2 EVM basic support
tcl/target/ti_k3: Add AM625 SoC
tcl/board: Add AM625 EVM basic support
Oleksij Rempel (5):
drivers: USB Blaster II: claim interface before using it
drivers: USB Blaster II: close file and release USB device if firmware handling failed
add config for Microchip SAMA5D27 SOM1 Kit1
tcl: add lattice ECP5 family support
Partially Revert "flash/stm32l4x: introduce flash programming without loader"
Olivier DANET (1):
target/zynqmp : Add AXI AP access port
Patrick Stewart (1):
tcl/interface/ftdi: Fix Digilent JTAG-SMT2 config
Paul Fertser (9):
Restore normal development cycle
doc: move the official channel to Libera.Chat
jtag: drivers: bcm2835gpio: don't allow GPIOs > 31
flash: nor: use binary prefixes consistently
tcl: board: mini2440: fix to work with the current version
checkpatch: add logging functions
checkpatch: treat jenkins as valid email
checkpatch: correct false positives reporting instructions
checkpatch: fix check for the FSF address
Pavel Kirienko (2):
semihosting: use open mode flags from GDB, not from sys/stat.h
semihosting: fix return value of SYS_READ and SYS_WRITE
Peter Lawrence (2):
drivers/cmsis-dap: add multidrop capability
tcl/board: add pico-debug support
Piotr Kasprzyk (1):
doc: fix typo s/Not/Note/
PoroCYon (1):
drivers/cmsis-dap: update for newest protocol version
R. Diez (9):
Enable adapter "Bus Pirate" by default.
Document the buspirate interface driver.
Warn on undefined preprocessor symbols
Remove compatibility macros m4_ifblank and m4_ifnblank
configure.ac: use a separate folder for Autoconf-generated files
Makefile: add special target .DELETE_ON_ERROR
Avoid non-standard conditionals with omitted operands.
Doc fix: echo writes to the log, and not to stdout
configure: provide advice if PKG_PROG_PKG_CONFIG unavailable
Ranjith Chandran (1):
tcl/interface: add Ashling Opella-LD FTDI config files
Raúl Sanchez Siles (1):
flash/stm32l4x: zero init stm32l4_flash_bank struct on flash bank initialization
Raúl Sánchez Siles (1):
build: Fix out-of-tree with --disable-dependency-tracking configure flag
Rene Kita (1):
build: remove warnings with gcc 11
Rohit Singh (1):
tcl: Add support for the Digilent Nexys Video board
Salvatore Giorgio PECORINO (1):
bluenrg: add support for bluenrg-lps device and board
Sean Anderson (10):
cpld: altera-epm240: Add additional IDCODEs
cpld: altera-epm240: Increase adapter speed
target: Add support for ls1088a
target: ls1088a: Add service processor
board: Add NXP LS1088ARDB
target: Add LS1046A
board: Add LS1046ARDB
tcl/target/ls1088: Break out common configuration
target: Add LS1028A
tcl: Add support for Kontron SMARC-sAL28
Sebastiaan de Schaetzen (3):
rtos/riot: fix out-of-bounds read of optional symbols array
rtos/riot: fix out-of-bounds writes when target is corrupted
flash/stm32l4x: prevent undefined behavior warnings caused by signed integer operations
Simon Johansson (1):
flash/nor/stm32f2x: Fix erase of bank 2 sectors
Steve Marple (13):
linuxgpiod: add SWDIO buffer
bcm2835gpio: Make buffer an output before the GPIO connected to it
bcm2835gpio: Fix incorrect GPIO validation
drivers/am335xgpio: Add AM335x driver for bitbang support on BeagleBones
doc: Document linuxgpiod driver commands
jtag/adapter: Add command 'adapter gpio'
drivers/am335xgpio: Migrate to adapter gpio commands
drivers/am335xgpio: Release resources on error and when quitting
drivers/linuxgpiod: Migrate to adapter gpio commands
drivers/bcm2835gpio: Release resources on error and when quitting
drivers/bcm2835gpio: Migrate to adapter gpio commands
drivers/bcm2835gpio: Add support for activity LED
drivers/bcm2835gpio: Fully restore GPIOs after use
Tarek BOCHKATI (95):
stlink: separate stlink core from USB functions
stlink: support of ST-LINK TCP server using stlink-dap and hla
cortex_m: avoid reading and writing non-existent registers
tcl/target: add BCM2835 configuration file
tcl/target: add BCM2836 configuration file
tcl/target: add BCM2837 configuration file
tcl/target: add BCM2711 configuration file
telnet: support end and home keys
aarch64: handle semihosting in aarch32 state
stm32l4x: add OTP support for STM32 G0/G4/L4/L4+/L5/WB/WL devices
flash/stm32l4x: enhance protect handler to use efficiently all WRP areas
flash/stm32l4x: introduce stm32l4_part_info.flags for devices features
flash/stm32l4x: probe tzen and rdp values
doc/openocd.texi: fix warning
doc/openocd.texi: fix warning
cortex_m: mark FPU register as non-existent instead of playing with num_regs
telnet: auto-completion of "registered" commands
cortex_m: implement hit_watchpoint function
cortex_m: use unsigned int for FPB and DWT quantifiers
cortex_m: add armv8m special registers
target/armv7m.h: [style] replace tab with space between variable type and name
cortex_m: do not perform soft_reset_halt on targets without VECTRESET
cortex_m: fix VECTRESET detection for ARMv6-M cores
flash/stm32l4x: add missing break statement
github/action: create a permanent 'latest' release
tcl/target/stm32f4x: fix hardcoded chip name
armv8_dpm: do not read/write non-existent registers
arm_dpm: do not read/write non-existent registers
armv4_5: do not read/write non-existent registers
target/arm: optimize architecture flags
cortex_m: enhance core and arch detection
flash/stm32fxx.c: do not read CPUID as this info is stored in cortex_m_common
github/workflow: upgrade libraries in windows build to latest versions
github/workflow: disable libusb static link for windows build
flash/stm32l4x: use COMMAND_PARSE_NUMBER in command handlers
jtag/cmcis_dap: use COMMAND_PARSE_NUMBER in command handlers
flash/at91samd: use COMMAND_PARSE_NUMBER in command handlers
flash/xmc4xxx: use COMMAND_PARSE_NUMBER in command handlers
flash/kinetis: use COMMAND_PARSE_NUMBER in command handlers
flash/atsame5: use COMMAND_PARSE_NUMBER in command handlers
flash/stm32l4x: do not report bank mode before probing [FIX]
flash/stm32l4x: introduce 'stm32l4x trustzone [enable|disable]' command
flash/stm32l4x: introduce auto-probe when OPTR is changed
flash/stm32l4x: STM32L5 support programming when TZEN=1 and RDP=0xAA
flash/stm32l4x: STM32L5 support programming when TZEN=1 and RDP=0x55
flash/stm32l4x: introduce flash programming without loader
flash/stm32l4x: remove stm32l4_part_info.default_flash_regs
flash/stm32l4x: add support of STM32G0Bx/G0Cx devices
flash/stm32l4x: add support of STM32WL5x dual core
flash/stm32l4x: add support of STM32U57x/U58x
flash/stm32l4x: free write_algorithm work area if no space left for the buffer
server/telnet: cleanup the if statement mixed style
server/telnet: support 'CTRL+C'
server/telnet: enhance telnet_move_cursor
server/telnet: simplify telnet_input function
server/telnet: add variables auto-completion
flash/stm32l4x: switch to to c loader instead of assembly loader
flash/stm32l4x: add support of STM32G05/G06x
flash/stm32l4x: add support of STM32WB1x
flash/stm32l4x: avoid using magic numbers for device ids
tcl/board: add st_nucleo_g0.cfg to cover known STM32G0 NUCLEO boards
tcl/board: add st_nucleo_g4.cfg to cover known STM32G4 NUCLEO boards
flash/nor/tcl: fix the flash name returned by 'flash list' command
flash/nor/tcl: 'flash list' command: add the flash bank target
flash/stm32l4x: fix segmentation fault with HLA adapters and STM32WLx devices
flash/stm32l4x: introduce is_max_flash_size and use it
flash/stm32l4x: do not use magic number for dual bank option bits
flash/stm32l4x: fix flash programming in 64-bit hosts
tcl/target/stm32(f7/h7)x: do not assume presence of the reset
doc: add a note to use 'stm32l4x option_load' after changing option bytes
gerrit url: update the gerrit server address to https://review.openocd.org
helper/command: fix echo return values
flash/stm32l4x: fix dual bank support for STM32L552xC devices
tcl/stm32wlx.cfg: comply with new jimtcl expr syntax
target/cortex_m: enhance multi-core examine logs
target: reset target examined flag if target::examine() fails
stlink (tcp): manage scattered stlink-server responses
flash/stm32h7x: avoid using magic numbers for device ids
flash/stm32h7x: don't read flash size using the H74/H75x CPU2
jtag/hla_layout: add #include <target/arm_tpiu_swo.h>
flash/stm32l4x: fix maybe-uninitialized compiler error
tcl/stm32l5x|u5x: refactor common tcl code
cortex_m: use LOG_TARGET_XXX
flash/stm32h7x: fix FLASH_WPSN_PRG mask used for protection
semihosting: permit redirection of semihosting I/O to TCP
stlink: enable queuing with stlink-server API v3
tcl/stm32u5x: fix clock config used at 'reset init'
flash/stm32l4x: fix auto-probe when RDP is promoted from 0 to 0.5
cross-build.sh: fix build with capstone
github workflow: use libusb 1.0.26 and hidapi 0.11.2
github/workflow: enable libftdi based adapters
cortex_a: get rid of not needed log messages
stlink: manage TCP_BUSY status code when using RW MISC
flash/stm32l4x: fix scan-build warnings
telnet_server: fix scan-build warning
Thomas Gleixner (3):
LICENSES: add the BSD 2-clause "Simplified" license
LICENSES: add the BSD 3-clause "New" or "Revised" License
LICENSES: Add the MIT license
Thomas Hebb (1):
tcl/interface/ftdi: Add config for Tigard board
Tim Newsome (22):
Implement CRC32 algorithm for RISC-V.
Cleanup of config/includes.
Add target_data_bits().
Add remote bitbang write buffer.
Add RTOS memory read/write functions.
Call poll at a fixed interval.
In SMP config, replicate watchpoints on each core
Speed up remote bitbang.
uint64_t->target_addr_t for stack pointers.
Upstream a whole host of RISC-V changes.
rtos: use struct member names instead of comments
riscv: Clear type 6 triggers on connecting.
target: Use target_addr_t for algorithm addresses.
flash/nor/fespi: algorithm, large address, errors
target/riscv: calloc() memory per register.
Document how vector registers are exposed to gdb.
Combine register lists of smp targets.
target/riscv: revive 'riscv resume_order'
Fix small memory leak.
Give each SMP group a unique number.
target/riscv: Update debug_defines.h.
target/riscv: Update with latest encoding from riscv-opcodes
Tim Nordell (3):
rtos: Create a new helper function find_symbol(...)
rtos: Fold is_symbol_mandatory into rtos_qsymbol(..)
rtos: Support looking up .lto_priv.0 appended to symbol name
Tomas Vanek (74):
flash/nor/atsame5: add SAME51G18A and SAME51G19A devices
drivers/cmsis-dap: tidy up buffer access
drivers/cmsis-dap: improve error checking
drivers/cmsis-dap: flush read
target/arm_adi_v5: add JTAG_TO_DORMANT sequence
target/adi_v5_swd: remove double space from swd_cmd() parameters
target/arm_adi_v5: move DP register definitions to one block
target/armv7m: change FPv4_SP and FPv5_SP/DP identifiers to uppercase
target/armv7m: fix static analyzer warning
cortex_m: use cortex_m_write_debug_halt_mask() in cortex_m_single_step_core()
target/cortex_m: use cortex_m->dcb_dhcsr in cortex_m_soft_reset_halt()
target/cortex_m: cumulate DHCSR sticky bits
target/cortex_m: faster reading of all CPU registers
target/arm_dap: fix memory leak in error path of dap_create()
drivers/swd: add support for SWD multidrop
drivers/ftdi: add support for SWD multidrop
drivers/bitbang: add support for SWD multidrop
target/adi_v5_swd: introduce swd_queue_dp_read/write_inner()
target/arm_dap: clean up dap_configure code
target/arm_adi_v5,arm_dap: introduce multidrop_targetsel and its configuration
target/adi_v5_swd: add support for SWD multidrop
target/arm_dap: check SWD DAP configuration
target/hla_target: set cortex_m->common_magic
doc: mention SWD multidrop
flash/nor/kinetis_ke: add .help fields for tcl commands
flash/nor/kinetis_ke: remove 'kinetis mdm test_securing' cmd
doc: document 'atsamv gpnvm' command
flash/nor/at91samd: remove 'at91samd info' command
doc: fix list of supported nRF52 devices
doc: document 'cmsis-dap cmd' command
target,flash: allow target_free_working_area on NULL area pointer
doc: list internal commands called by init
doc: document noinit command
jtag/drivers/vsllink: fix memory leak
target/cortex_m: minor refactoring in cortex_m_store_core_reg_u32()
target/cortex_m: fix target_to_cm() helper
target/armv7m,cortex_m: introduce checked arch_info cast routines
target/cortex_m: add Cortex-M part number getter
flash/nor/stm32xx: fix segfault accessing Cortex-M part number
flash/stm32f1x,f2x: fix endianess in slow fallback flash write
flash/nor/stm32f1x: allow write fallback for flash options
flash/nor/stm32f1x: remove write alignment code
flash/nor/stm32f1x: tidy up async algo supporting code
flash/nor/stm32f1x: unify flash error reporting
flash/nor/stm32f1x: lock flash in case of error
flash/stm32f1x: add support for RISC-V GigaDevice GD32VF103
tcl/target/gd32vf103: add flash bank
flash/nor/stm32f1x: add can_load_options flag for GD32F1x0, F3x0 and E23x
target: document possibly unreachable target in deinit_target()
doc: prevent writing "topic:" to commit message
target/riscv: fix 'reset run' after 'reset halt'
target: fix clang static analyzer warning
flash/nor/core, target: don't ask for working mem if no target algo
target/riscv: drop unused variable registers_initialized
flash/nor/numicro: remove useless architecture check
target/riscv: use struct riscv_info instead of typedef riscv_info_t
target/riscv: add common magic
flash/nor/fespi: check target type
target/cortex_a: remove unused CORTEX_A15_COMMON_MAGIC
target: fix unaligned return of target_get_working_area_avail()
flash/nor: remove useless setting of bus_width and chip_width
target: consolidate existing target/algo common_magic
target/aarch64: fix duplicate common magic
target: move parent target structs just after common_magic
target/cortex_m: prevent segmentation fault in cortex_m_poll()
target/arm: make 'arm core_state' command compatible with Cortex-M
target/arm: do not expose 'arm reg', 'arm mcr/mrc' commands on Cortex-M
target/cortex_m: supress historical reset detection
jtag/drivers/kitprog: use HID read timeout
jtag/drivers/kitprog: workaround serious firmware problem
server/server: fix target timer timing
flash/nor/core: remove unused define
flash/nor/nrf5: don't misuse uint32_t for refcount
flash/nor/bluenrg-x: clarify target algo stack usage
Toms Stūrmanis (2):
src/flash/nor: flash driver for RSL10
flash/nor/rsl10: Check return value
Wealian Liao (1):
flash/nor: add support for Nuvoton NPCX series flash
Yasushi SHOJI (11):
target: Remove redundant initialization of endianness
doc: Group adapter sub-commands
server: gdb_server: Add colon for target extended-remote
target: cortex_m: Fix a typo VECTRESET
helper: Remove src/helper from include dirs
gitignore: Add GNU Global tag files
doc/openocd.texi: Document add_help_text and add_usage_text
doc/openocd.texi: Document usage command
target/target: Check checksum_memory before call
doc/openocd.texi: Document command mode command
doc/openocd.texi: Document find and ocd_find command
Yun Liu (1):
remote_bitbang: Add Windows support
Zoltán Dudás (1):
semihosting: User defined operation, Tcl command exec on host
asier70 (2):
flash/nor/stm32f1x: Add support for GD32F1x0/3x0
flash/nor/stm32f1x: Add support for GD32E23x
fatalc (1):
target/disassembler: update capstone include path to <capstone.h>
iysheng (1):
target/arm: Add support with identify STAR-MC1
jihongbin (1):
drivers/cmsis-dap: Correct the DAP protocol parameter parsing error
micbis (4):
target/arm_adi_v5: Fix clear sticky overrun flag during replay of commands
target/renesas_rz_g2: Introduce tcl config file for RZ/G2 devices
tcl/target/renesas_rz_g2: Added RZ/G2LC and RZ/G2UL
tcl/target/renesas_rz_five: Added RZ/Five
root (1):
target/adi_v5_jtag: Add support for 8-bit IR JTAG-DP
-----------------------------------------------------------------------
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-18 17:43:33
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via b89cf71e2b5e4dc2c31cf085aec7a19515e2a9d6 (commit)
via 5e7612eb4c87e8e7a7000b42ff5d0f7e5c70fc42 (commit)
from 382148e4dd437978997d668f6ec715ddcec1c46e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b89cf71e2b5e4dc2c31cf085aec7a19515e2a9d6
Author: Paul Fertser <fer...@gm...>
Date: Sun Sep 18 20:40:13 2022 +0300
Restore +dev suffix
Signed-off-by: Paul Fertser <fer...@gm...>
diff --git a/configure.ac b/configure.ac
index 29a94d409..cfd23846b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-or-later
AC_PREREQ([2.69])
-AC_INIT([openocd], [0.12.0-rc1],
+AC_INIT([openocd], [0.12.0-rc1+dev],
[OpenOCD Mailing List <ope...@li...>])
AC_CONFIG_SRCDIR([src/openocd.c])
AC_CONFIG_AUX_DIR([build-aux])
commit 5e7612eb4c87e8e7a7000b42ff5d0f7e5c70fc42
Author: Antonio Borneo <bor...@gm...>
Date: Wed Mar 10 23:10:51 2021 +0100
The openocd-0.12.0-rc1 release candidate
Change-Id: I790a6b13962649037c97e32d562dffd58d3daf3c
Signed-off-by: Antonio Borneo <bor...@gm...>
diff --git a/NEWS b/NEWS
index 9db6c5fee..50cb98439 100644
--- a/NEWS
+++ b/NEWS
@@ -2,29 +2,126 @@ This file includes highlights of the changes made in the OpenOCD
source archive release.
JTAG Layer:
+ * add default to adapter speed when unspecified (100 kHz)
+ * AM335X gpio (BeagleBones) adapter driver
+ * BCM2835 support for SWD
+ * Cadence Virtual Debug (vdebug) adapter driver
+ * CMSIS-DAP support for SWO and SWD multidrop
+ * Espressif USB JTAG Programmer adapter driver
+ * Remote bitbang support for Windows host
+ * ST-LINK add TCP server support to adapter driver
+ * SWD multidrop support
Boundary Scan:
Target Layer:
+ * aarch64: support watchpoints
+ * arm: support independent TPIU and SWO for trace
+ * arm adi v5: support Large Physical Address Extension
+ * arm adi v6: support added, for jtag and swd transport
+ * cortex_a: support watchpoints
+ * elf 64bit load support
+ * Espressif: support ESP32, ESP32-S2 and ESP32-S3 cores
+ * semihosting: support user defined operations
+ * Xtensa: support Xtensa LX architecture via JTAG and ADIv5 DAP
Flash Layer:
+ * Atmel/Microchip SAM E51G18A, E51G19A, R35J18B, LAN9255 support
+ * GigaDevice GD32E23x, GD32F1x0/3x0, GD32VF103 support
+ * Nuvoton NPCX series support
+ * onsemi RSL10 support
+ * Raspberry Pi Pico RP2040 support
+ * ST BlueNRG-LPS support
+ * ST STM32 G05x, G06x, G0Bx, G0Cx, U57x, U58x, WB1x, WL5x support
+ * ST STM32 G0, G4, L4, L4+, L5, WB, WL OTP support
Board, Target, and Interface Configuration Scripts:
+ * Ampere Computing eMAG8180, Altra ("Quicksilver") and Altra Max ("Mystique") board config
+ * Cadence KC705 FPGA (Xtensa Development Platform) via JTAG and ADIv5 DAP board config
+ * Digilent Nexys Video board config
+ * Espressif ESP32 ETHERNET-KIT and WROVER-KIT board config
+ * Espressif ESP32 via ESP USB Bridge generic board config
+ * Espressif ESP32-S2 Kaluga 1 board config
+ * Espressif ESP32-S2 with ESP USB Bridge board config
+ * Espressif ESP32-S3 example board config
+ * Kontron SMARC-sAL28 board config
+ * LambdaConcept ECPIX-5 board config
+ * Microchip ATSAMA5D27-SOM1-EK1 board config
+ * Microchip EVB-LAN9255 board config
+ * Microchip SAME51 Curiosity Nano board config
+ * NXP FRDM-K64F, LS1046ARDB and LS1088ARDB board config
+ * NXP RT6XX board config
+ * Olimex H405 board config
+ * Radiona ULX3S board config
+ * Raspberry Pi 3 and Raspberry Pi 4 model B board config
+ * Raspberry Pi Pico-Debug board config
+ * Renesas R-Car V3U Falcon board config
+ * ST BlueNRG-LPS steval-idb012v1 board config
+ * ST NUCLEO-8S208RB board config
+ * ST NUCLEO-G031K8, NUCLEO-G070RB, NUCLEO-G071RB board config
+ * ST NUCLEO-G431KB, NUCLEO-G431RB, NUCLEO-G474RE board config
+ * ST STM32MP13x-DK board config
+ * TI AM625 EVM, AM642 EVM and AM654 EVM board config
+ * TI J721E EVM, J721S2 EVM and J7200 EVM board config
+ * Ampere Computing eMAG, Altra ("Quicksilver") and Altra Max ("Mystique") target config
+ * Cadence Xtensa generic and Xtensa VDebug target config
+ * Broadcom BCM2711, BCM2835, BCM2836 and BCM2837 target config
+ * Espressif ESP32, ESP32-S2 and ESP32-S3 target config
+ * Microchip ATSAMA5D2 series target config
+ * NanoXplore NG-Ultra SoC target config
+ * NXP IMX8QM target config
+ * NXP LS1028A, LS1046A and LS1088A target config
+ * NXP RT600 (Xtensa HiFi DSP) target config
+ * onsemi RSL10 target config
+ * Raspberry Pi Pico RP2040 target config
+ * Renesas R8A779A0 V3U target config
+ * Renesas RZ/Five target config
+ * Renesas RZ/G2 MPU family target config
+ * Rockchip RK3399 target config
+ * ST BlueNRG-LPS target config
+ * ST STM32MP13x target config
+ * TI AM625, AM654, J721E and J721S2 target config
+ * Ashling Opella-LD interface config
+ * Aspeed AST2600 linuxgpiod based interface config
+ * Blinkinlabs JTAG_Hat interface config
+ * Cadence Virtual Debug (vdebug) interface config
+ * Espressif ESP32-S2 Kaluga 1 board's interface config
+ * Espressif USB Bridge jtag interface config
+ * Infineon DAP miniWiggler V3 interface config
+ * PLS SPC5 interface config
+ * Tigard interface config
+ * Lattice MachXO3 family FPGA config
Server Layer:
+ * GDB: add per-target remote protocol extensions
+ * GDB: more 'Z' packets support
+ * IPDBG JtagHost server functionality
+ * semihosting: I/O redirection to TCP server
+ * telnet: support for command's autocomplete
RTOS:
+ * 'none' rtos support
+ * Zephyr rtos support
Documentation:
Build and Release:
+ * Add json extension to jimtcl build
+ * Drop dependency from libusb0
+ * Drop repository repo.or.cz for submodules
+ * Move gerrit to https://review.openocd.org/
+ * Require autoconf 2.69 or newer
+ * Update jep106 to revision JEP106BE
+ * Update jimtcl to version 0.81
+ * Update libjaylink to version 0.3.1
+ * New configure flag '--enable-jimtcl-maintainer' for jimtcl build
This release also contains a number of other important functional and
cosmetic bugfixes. For more details about what has changed since the
last release, see the git repository history:
-http://sourceforge.net/p/openocd/code/ci/v0.x.0/log/?path=
+http://sourceforge.net/p/openocd/code/ci/v0.12.0-rc1/log/?path=
For older NEWS, see the NEWS files associated with each release
diff --git a/README b/README
index 34dac0b1b..3c07d7cfe 100644
--- a/README
+++ b/README
@@ -101,17 +101,18 @@ Supported hardware
JTAG adapters
-------------
-AICE, ARM-JTAG-EW, ARM-USB-OCD, ARM-USB-TINY, AT91RM9200, axm0432, BCM2835,
-Bus Blaster, Buspirate, Cadence DPI, Chameleon, CMSIS-DAP, Cortino,
-Cypress KitProg, DENX, Digilent JTAG-SMT2, DLC 5, DLP-USB1232H,
-embedded projects, eStick, FlashLINK, FlossJTAG, Flyswatter, Flyswatter2,
+AICE, AM335x, ARM-JTAG-EW, ARM-USB-OCD, ARM-USB-TINY, AT91RM9200, axm0432, BCM2835,
+Bus Blaster, Buspirate, Cadence DPI, Cadence vdebug, Chameleon, CMSIS-DAP,
+Cortino, Cypress KitProg, DENX, Digilent JTAG-SMT2, DLC 5, DLP-USB1232H,
+embedded projects, Espressif USB JTAG Programmer,
+eStick, FlashLINK, FlossJTAG, Flyswatter, Flyswatter2,
FTDI FT232R, Gateworks, Hoegl, ICDI, ICEBear, J-Link, JTAG VPI, JTAGkey,
JTAGkey2, JTAG-lock-pick, KT-Link, Linux GPIOD, Lisa/L, LPC1768-Stick,
Mellanox rshim, MiniModule, NGX, Nuvoton Nu-Link, Nu-Link2, NXHX, NXP IMX GPIO,
OOCDLink, Opendous, OpenJTAG, Openmoko, OpenRD, OSBDM, Presto, Redbee,
Remote Bitbang, RLink, SheevaPlug devkit, Stellaris evkits,
ST-LINK (SWO tracing supported), STM32-PerformanceStick, STR9-comStick,
-sysfsgpio, TI XDS110, TUMPA, Turtelizer, ULINK, USB-A9260, USB-Blaster,
+sysfsgpio, Tigard, TI XDS110, TUMPA, Turtelizer, ULINK, USB-A9260, USB-Blaster,
USB-JTAG, USBprog, VPACLink, VSLLink, Wiggler, XDS100v2, Xilinx XVC/PCIe,
Xverve.
@@ -121,16 +122,18 @@ Debug targets
ARM: AArch64, ARM11, ARM7, ARM9, Cortex-A/R (v7-A/R), Cortex-M (ARMv{6/7/8}-M),
FA526, Feroceon/Dragonite, XScale.
ARCv2, AVR32, DSP563xx, DSP5680xx, EnSilica eSi-RISC, EJTAG (MIPS32, MIPS64),
-Intel Quark, LS102x-SAP, NDS32, RISC-V, ST STM8.
+ESP32, ESP32-S2, ESP32-S3, Intel Quark, LS102x-SAP, NDS32, RISC-V, ST STM8,
+Xtensa.
Flash drivers
-------------
ADUC702x, AT91SAM, AT91SAM9 (NAND), ATH79, ATmega128RFA1, Atmel SAM, AVR, CFI,
DSP5680xx, EFM32, EM357, eSi-RISC, eSi-TSMC, EZR32HG, FM3, FM4, Freedom E SPI,
-i.MX31, Kinetis, LPC8xx/LPC1xxx/LPC2xxx/LPC541xx, LPC2900, LPC3180, LPC32xx,
+GD32, i.MX31, Kinetis, LPC8xx/LPC1xxx/LPC2xxx/LPC541xx, LPC2900, LPC3180, LPC32xx,
LPCSPIFI, Marvell QSPI, MAX32, Milandr, MXC, NIIET, nRF51, nRF52 , NuMicro,
-NUC910, Orion/Kirkwood, PIC32mx, PSoC4/5LP/6, Renesas RPC HF and SH QSPI,
+NUC910, Nuvoton NPCX, onsemi RSL10, Orion/Kirkwood, PIC32mx, PSoC4/5LP/6,
+Raspberry RP2040, Renesas RPC HF and SH QSPI,
S3C24xx, S3C6400, SiM3x, SiFive Freedom E, Stellaris, ST BlueNRG, STM32,
STM32 QUAD/OCTO-SPI for Flash/FRAM/EEPROM, STMSMI, STR7x, STR9x, SWM050,
TI CC13xx, TI CC26xx, TI CC32xx, TI MSP432, Winner Micro w600, Xilinx XCF,
diff --git a/configure.ac b/configure.ac
index 8e1f11e2d..29a94d409 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-or-later
AC_PREREQ([2.69])
-AC_INIT([openocd], [0.11.0+dev],
+AC_INIT([openocd], [0.12.0-rc1],
[OpenOCD Mailing List <ope...@li...>])
AC_CONFIG_SRCDIR([src/openocd.c])
AC_CONFIG_AUX_DIR([build-aux])
-----------------------------------------------------------------------
Summary of changes:
NEWS | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
README | 19 +++++++-----
configure.ac | 2 +-
3 files changed, 110 insertions(+), 10 deletions(-)
hooks/post-receive
--
Main OpenOCD repository
|
|
From: OpenOCD-Gerrit <ope...@us...> - 2022-09-18 08:23:11
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".
The branch, master has been updated
via 382148e4dd437978997d668f6ec715ddcec1c46e (commit)
from 5be78fafa9b7c9354956fa72c69dbb82338f6e4a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 382148e4dd437978997d668f6ec715ddcec1c46e
Author: Antonio Borneo <bor...@gm...>
Date: Tue Aug 30 17:01:12 2022 +0200
openocd: fix SPDX tag format for files .c
With the old checkpatch we cannot use the correct format for the
SPDX tags in the file .c, in fact the C99 comments are not allowed
and we had to use the block comment.
With the new checkpatch, let's switch to the correct SPDX format.
Change created automatically through the command:
sed -i \
's,^/\* *\(SPDX-License-Identifier: .*[^ ]\) *\*/$,// \1,' \
$(find src/ contrib/ -name \*.c)
Change-Id: I6da16506baa7af718947562505dd49606d124171
Signed-off-by: Antonio Borneo <bor...@gm...>
Reviewed-on: https://review.openocd.org/c/openocd/+/7153
Tested-by: jenkins
diff --git a/contrib/itmdump.c b/contrib/itmdump.c
index f31e1ff75..e7523d9bc 100644
--- a/contrib/itmdump.c
+++ b/contrib/itmdump.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-3.0-or-later */
+// SPDX-License-Identifier: GPL-3.0-or-later
/* Copyright (C) 2010 by David Brownell */
diff --git a/contrib/libdcc/dcc_stdio.c b/contrib/libdcc/dcc_stdio.c
index eab050eaf..9ad633b61 100644
--- a/contrib/libdcc/dcc_stdio.c
+++ b/contrib/libdcc/dcc_stdio.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2008 by Dominic Rath *
diff --git a/contrib/libdcc/example.c b/contrib/libdcc/example.c
index e8b275a94..7c7d93670 100644
--- a/contrib/libdcc/example.c
+++ b/contrib/libdcc/example.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2008 by Spencer Oliver *
diff --git a/contrib/list_example.c b/contrib/list_example.c
index 0f62b864b..4fcfcdf34 100644
--- a/contrib/list_example.c
+++ b/contrib/list_example.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/* Copyright (C) 2021 by Andreas Fritiofson <and...@gm...> */
/*
diff --git a/contrib/loaders/checksum/riscv_crc.c b/contrib/loaders/checksum/riscv_crc.c
index 70476ad1f..9931af5ff 100644
--- a/contrib/loaders/checksum/riscv_crc.c
+++ b/contrib/loaders/checksum/riscv_crc.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/* Copyright (C) 2009-2021 Free Software Foundation, Inc. */
diff --git a/contrib/loaders/flash/at91sam7x/dcc.c b/contrib/loaders/flash/at91sam7x/dcc.c
index fea88f6a1..ee95a3444 100644
--- a/contrib/loaders/flash/at91sam7x/dcc.c
+++ b/contrib/loaders/flash/at91sam7x/dcc.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007 by Pavel Chromy *
diff --git a/contrib/loaders/flash/at91sam7x/main.c b/contrib/loaders/flash/at91sam7x/main.c
index b896d2bf2..a29c6e605 100644
--- a/contrib/loaders/flash/at91sam7x/main.c
+++ b/contrib/loaders/flash/at91sam7x/main.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007 by Pavel Chromy *
diff --git a/contrib/loaders/flash/at91sam7x/samflash.c b/contrib/loaders/flash/at91sam7x/samflash.c
index 6e4c49575..fcb76fbf9 100644
--- a/contrib/loaders/flash/at91sam7x/samflash.c
+++ b/contrib/loaders/flash/at91sam7x/samflash.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007 by Pavel Chromy *
diff --git a/contrib/loaders/flash/bluenrg-x/bluenrg-x_write.c b/contrib/loaders/flash/bluenrg-x/bluenrg-x_write.c
index f4e43cda1..1bc72d592 100644
--- a/contrib/loaders/flash/bluenrg-x/bluenrg-x_write.c
+++ b/contrib/loaders/flash/bluenrg-x/bluenrg-x_write.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/* To be built with arm-none-eabi-gcc -c -mthumb -mcpu=cortex-m0 -O3 bluenrgx.c */
/* Then postprocess output of command "arm-none-eabi-objdump -d bluenrgx.o" to make a C array of bytes */
diff --git a/contrib/loaders/flash/cc26xx/flash.c b/contrib/loaders/flash/cc26xx/flash.c
index 3aba82cba..affd02955 100644
--- a/contrib/loaders/flash/cc26xx/flash.c
+++ b/contrib/loaders/flash/cc26xx/flash.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
+// SPDX-License-Identifier: BSD-3-Clause
/******************************************************************************
*
diff --git a/contrib/loaders/flash/cc26xx/flashloader.c b/contrib/loaders/flash/cc26xx/flashloader.c
index ef3a4fccf..8e9636d45 100644
--- a/contrib/loaders/flash/cc26xx/flashloader.c
+++ b/contrib/loaders/flash/cc26xx/flashloader.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
+// SPDX-License-Identifier: BSD-3-Clause
/******************************************************************************
*
diff --git a/contrib/loaders/flash/cc26xx/main.c b/contrib/loaders/flash/cc26xx/main.c
index 91fc43ac1..6b626a3b8 100644
--- a/contrib/loaders/flash/cc26xx/main.c
+++ b/contrib/loaders/flash/cc26xx/main.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
+// SPDX-License-Identifier: BSD-3-Clause
/******************************************************************************
*
diff --git a/contrib/loaders/flash/cc26xx/startup.c b/contrib/loaders/flash/cc26xx/startup.c
index 9eb0df8ef..3117eb10a 100644
--- a/contrib/loaders/flash/cc26xx/startup.c
+++ b/contrib/loaders/flash/cc26xx/startup.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
+// SPDX-License-Identifier: BSD-3-Clause
/******************************************************************************
*
diff --git a/contrib/loaders/flash/fespi/riscv_fespi.c b/contrib/loaders/flash/fespi/riscv_fespi.c
index 5323f92bf..17ae2fd22 100644
--- a/contrib/loaders/flash/fespi/riscv_fespi.c
+++ b/contrib/loaders/flash/fespi/riscv_fespi.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
#include <stdbool.h>
#include <stdint.h>
diff --git a/contrib/loaders/flash/gd32vf103/gd32vf103.c b/contrib/loaders/flash/gd32vf103/gd32vf103.c
index 69225a026..927014c74 100644
--- a/contrib/loaders/flash/gd32vf103/gd32vf103.c
+++ b/contrib/loaders/flash/gd32vf103/gd32vf103.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
#include <stdint.h>
diff --git a/contrib/loaders/flash/msp432/driverlib.c b/contrib/loaders/flash/msp432/driverlib.c
index e9058793c..6f483b83d 100644
--- a/contrib/loaders/flash/msp432/driverlib.c
+++ b/contrib/loaders/flash/msp432/driverlib.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
+// SPDX-License-Identifier: BSD-3-Clause
/******************************************************************************
*
diff --git a/contrib/loaders/flash/msp432/main_msp432e4x.c b/contrib/loaders/flash/msp432/main_msp432e4x.c
index db9514a9c..7974f48c7 100644
--- a/contrib/loaders/flash/msp432/main_msp432e4x.c
+++ b/contrib/loaders/flash/msp432/main_msp432e4x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
+// SPDX-License-Identifier: BSD-3-Clause
/******************************************************************************
*
diff --git a/contrib/loaders/flash/msp432/main_msp432p401x.c b/contrib/loaders/flash/msp432/main_msp432p401x.c
index 7d959a741..47fb7fa47 100644
--- a/contrib/loaders/flash/msp432/main_msp432p401x.c
+++ b/contrib/loaders/flash/msp432/main_msp432p401x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
+// SPDX-License-Identifier: BSD-3-Clause
/******************************************************************************
*
diff --git a/contrib/loaders/flash/msp432/main_msp432p411x.c b/contrib/loaders/flash/msp432/main_msp432p411x.c
index d72efed68..efc05a3b7 100644
--- a/contrib/loaders/flash/msp432/main_msp432p411x.c
+++ b/contrib/loaders/flash/msp432/main_msp432p411x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
+// SPDX-License-Identifier: BSD-3-Clause
/******************************************************************************
*
diff --git a/contrib/loaders/flash/msp432/startup_msp432e4.c b/contrib/loaders/flash/msp432/startup_msp432e4.c
index bd8fc2173..49789609f 100644
--- a/contrib/loaders/flash/msp432/startup_msp432e4.c
+++ b/contrib/loaders/flash/msp432/startup_msp432e4.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
+// SPDX-License-Identifier: BSD-3-Clause
/******************************************************************************
*
diff --git a/contrib/loaders/flash/msp432/startup_msp432p4.c b/contrib/loaders/flash/msp432/startup_msp432p4.c
index f8ad811f2..350fd35e8 100644
--- a/contrib/loaders/flash/msp432/startup_msp432p4.c
+++ b/contrib/loaders/flash/msp432/startup_msp432p4.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
+// SPDX-License-Identifier: BSD-3-Clause
/******************************************************************************
*
diff --git a/contrib/loaders/flash/npcx/npcx_flash.c b/contrib/loaders/flash/npcx/npcx_flash.c
index d60624ae8..7d59123aa 100644
--- a/contrib/loaders/flash/npcx/npcx_flash.c
+++ b/contrib/loaders/flash/npcx/npcx_flash.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (C) 2020 by Nuvoton Technology Corporation
diff --git a/contrib/loaders/flash/stm32/stm32l4x.c b/contrib/loaders/flash/stm32/stm32l4x.c
index 54c88a335..b657ec9ae 100644
--- a/contrib/loaders/flash/stm32/stm32l4x.c
+++ b/contrib/loaders/flash/stm32/stm32l4x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/**
* Copyright (C) 2021 Tarek BOCHKATI
diff --git a/contrib/remote_bitbang/remote_bitbang_sysfsgpio.c b/contrib/remote_bitbang/remote_bitbang_sysfsgpio.c
index 28136a59e..9294837e3 100644
--- a/contrib/remote_bitbang/remote_bitbang_sysfsgpio.c
+++ b/contrib/remote_bitbang/remote_bitbang_sysfsgpio.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2013 Paul Fertser <fer...@gm...> *
diff --git a/contrib/rtos-helpers/FreeRTOS-openocd.c b/contrib/rtos-helpers/FreeRTOS-openocd.c
index 45fc0ce10..000453d5d 100644
--- a/contrib/rtos-helpers/FreeRTOS-openocd.c
+++ b/contrib/rtos-helpers/FreeRTOS-openocd.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Since at least FreeRTOS V7.5.3 uxTopUsedPriority is no longer
diff --git a/contrib/rtos-helpers/uCOS-III-openocd.c b/contrib/rtos-helpers/uCOS-III-openocd.c
index 1e9cba4dc..9869adf7e 100644
--- a/contrib/rtos-helpers/uCOS-III-openocd.c
+++ b/contrib/rtos-helpers/uCOS-III-openocd.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* uC/OS-III does not provide a fixed layout for OS_TCB, which makes it
diff --git a/src/flash/common.c b/src/flash/common.c
index dfd6aca80..ebd9396eb 100644
--- a/src/flash/common.c
+++ b/src/flash/common.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2009 by Zachary T Welch <zw...@su...> *
diff --git a/src/flash/nand/arm_io.c b/src/flash/nand/arm_io.c
index cc6a880a0..80bd0cf25 100644
--- a/src/flash/nand/arm_io.c
+++ b/src/flash/nand/arm_io.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (C) 2009 by Marvell Semiconductors, Inc.
diff --git a/src/flash/nand/at91sam9.c b/src/flash/nand/at91sam9.c
index 59345ee34..bfbba67c4 100644
--- a/src/flash/nand/at91sam9.c
+++ b/src/flash/nand/at91sam9.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (C) 2009 by Dean Glazeski
diff --git a/src/flash/nand/core.c b/src/flash/nand/core.c
index 2720bc67d..37e1d12e0 100644
--- a/src/flash/nand/core.c
+++ b/src/flash/nand/core.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007 by Dominic Rath <Dom...@gm...> *
diff --git a/src/flash/nand/davinci.c b/src/flash/nand/davinci.c
index 28e31f2a4..b7169feeb 100644
--- a/src/flash/nand/davinci.c
+++ b/src/flash/nand/davinci.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2009 by David Brownell *
diff --git a/src/flash/nand/driver.c b/src/flash/nand/driver.c
index 4655606b7..02e5c09a2 100644
--- a/src/flash/nand/driver.c
+++ b/src/flash/nand/driver.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath <Dom...@gm...> *
diff --git a/src/flash/nand/ecc.c b/src/flash/nand/ecc.c
index c6ef20b4c..20b8ba85d 100644
--- a/src/flash/nand/ecc.c
+++ b/src/flash/nand/ecc.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later WITH eCos-exception-2.0 */
+// SPDX-License-Identifier: GPL-2.0-or-later WITH eCos-exception-2.0
/*
* This file contains an ECC algorithm from Toshiba that allows for detection
diff --git a/src/flash/nand/ecc_kw.c b/src/flash/nand/ecc_kw.c
index beaeb121b..cea1a5a0a 100644
--- a/src/flash/nand/ecc_kw.c
+++ b/src/flash/nand/ecc_kw.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Reed-Solomon ECC handling for the Marvell Kirkwood SOC
diff --git a/src/flash/nand/fileio.c b/src/flash/nand/fileio.c
index 2bfbd6983..ca618b375 100644
--- a/src/flash/nand/fileio.c
+++ b/src/flash/nand/fileio.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007 by Dominic Rath <Dom...@gm...> *
diff --git a/src/flash/nand/lpc3180.c b/src/flash/nand/lpc3180.c
index 5b7cc1a9a..c1af1d737 100644
--- a/src/flash/nand/lpc3180.c
+++ b/src/flash/nand/lpc3180.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007 by Dominic Rath *
diff --git a/src/flash/nand/lpc32xx.c b/src/flash/nand/lpc32xx.c
index ea282ba2b..2c578d1b4 100644
--- a/src/flash/nand/lpc32xx.c
+++ b/src/flash/nand/lpc32xx.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007 by Dominic Rath *
diff --git a/src/flash/nand/mx3.c b/src/flash/nand/mx3.c
index d2670bd5d..86e94685b 100644
--- a/src/flash/nand/mx3.c
+++ b/src/flash/nand/mx3.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
diff --git a/src/flash/nand/mxc.c b/src/flash/nand/mxc.c
index 715e1cbbb..845a3bb9a 100644
--- a/src/flash/nand/mxc.c
+++ b/src/flash/nand/mxc.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2009 by Alexei Babich *
diff --git a/src/flash/nand/nonce.c b/src/flash/nand/nonce.c
index db908686d..bce4ed0f9 100644
--- a/src/flash/nand/nonce.c
+++ b/src/flash/nand/nonce.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2009 Zachary T Welch <zw...@su...> *
diff --git a/src/flash/nand/nuc910.c b/src/flash/nand/nuc910.c
index 4ec7f16fc..d7f69e6ae 100644
--- a/src/flash/nand/nuc910.c
+++ b/src/flash/nand/nuc910.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2010 by Spencer Oliver *
diff --git a/src/flash/nand/orion.c b/src/flash/nand/orion.c
index b2710e64c..7b19cbd24 100644
--- a/src/flash/nand/orion.c
+++ b/src/flash/nand/orion.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2009 by Marvell Semiconductors, Inc. *
diff --git a/src/flash/nand/s3c2410.c b/src/flash/nand/s3c2410.c
index 721ed9dd2..98268ebcc 100644
--- a/src/flash/nand/s3c2410.c
+++ b/src/flash/nand/s3c2410.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007, 2008 by Ben Dooks *
diff --git a/src/flash/nand/s3c2412.c b/src/flash/nand/s3c2412.c
index f67368913..0eec35f50 100644
--- a/src/flash/nand/s3c2412.c
+++ b/src/flash/nand/s3c2412.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007, 2008 by Ben Dooks *
diff --git a/src/flash/nand/s3c2440.c b/src/flash/nand/s3c2440.c
index 424d6d241..789144cbd 100644
--- a/src/flash/nand/s3c2440.c
+++ b/src/flash/nand/s3c2440.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007, 2008 by Ben Dooks *
diff --git a/src/flash/nand/s3c2443.c b/src/flash/nand/s3c2443.c
index fcd904011..7166702ab 100644
--- a/src/flash/nand/s3c2443.c
+++ b/src/flash/nand/s3c2443.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007, 2008 by Ben Dooks *
diff --git a/src/flash/nand/s3c24xx.c b/src/flash/nand/s3c24xx.c
index f2311ccaa..5c2f2bc3f 100644
--- a/src/flash/nand/s3c24xx.c
+++ b/src/flash/nand/s3c24xx.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007, 2008 by Ben Dooks *
diff --git a/src/flash/nand/s3c6400.c b/src/flash/nand/s3c6400.c
index bca068e85..aebe0443b 100644
--- a/src/flash/nand/s3c6400.c
+++ b/src/flash/nand/s3c6400.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2010 by Peter Korsgaard <ja...@su...> *
diff --git a/src/flash/nand/tcl.c b/src/flash/nand/tcl.c
index 79a386eed..4bb15faae 100644
--- a/src/flash/nand/tcl.c
+++ b/src/flash/nand/tcl.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007 by Dominic Rath <Dom...@gm...> *
diff --git a/src/flash/nor/aduc702x.c b/src/flash/nor/aduc702x.c
index af846c2b4..ea7f5e373 100644
--- a/src/flash/nor/aduc702x.c
+++ b/src/flash/nor/aduc702x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2008 by Kevin McGuire *
diff --git a/src/flash/nor/aducm360.c b/src/flash/nor/aducm360.c
index ffa1bbaf4..ce9bf2445 100644
--- a/src/flash/nor/aducm360.c
+++ b/src/flash/nor/aducm360.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2015 by Ivan Buliev *
diff --git a/src/flash/nor/ambiqmicro.c b/src/flash/nor/ambiqmicro.c
index 4c4a642d5..2b458bc8f 100644
--- a/src/flash/nor/ambiqmicro.c
+++ b/src/flash/nor/ambiqmicro.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-3-Clause */
+// SPDX-License-Identifier: BSD-3-Clause
/******************************************************************************
*
diff --git a/src/flash/nor/at91sam3.c b/src/flash/nor/at91sam3.c
index 431e2a3a0..fb6d98b56 100644
--- a/src/flash/nor/at91sam3.c
+++ b/src/flash/nor/at91sam3.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-Source-Code) */
+// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-Source-Code)
/*
* Copyright (C) 2009 by Duane Ellis <op...@du...>
diff --git a/src/flash/nor/at91sam4.c b/src/flash/nor/at91sam4.c
index 556484adf..6b9437390 100644
--- a/src/flash/nor/at91sam4.c
+++ b/src/flash/nor/at91sam4.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-Source-Code) */
+// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-Source-Code)
/*
* Copyright (C) 2009 by Duane Ellis <op...@du...>
diff --git a/src/flash/nor/at91sam4l.c b/src/flash/nor/at91sam4l.c
index 99e289f3f..ddf42a8c5 100644
--- a/src/flash/nor/at91sam4l.c
+++ b/src/flash/nor/at91sam4l.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2013 by Andrey Yurovsky *
diff --git a/src/flash/nor/at91sam7.c b/src/flash/nor/at91sam7.c
index e18635b6d..8d8cf2226 100644
--- a/src/flash/nor/at91sam7.c
+++ b/src/flash/nor/at91sam7.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2006 by Magnus Lundin *
diff --git a/src/flash/nor/at91samd.c b/src/flash/nor/at91samd.c
index dd7c5f54f..a0252a276 100644
--- a/src/flash/nor/at91samd.c
+++ b/src/flash/nor/at91samd.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2013 by Andrey Yurovsky *
diff --git a/src/flash/nor/ath79.c b/src/flash/nor/ath79.c
index ff8b1bcd3..1d1ec02b3 100644
--- a/src/flash/nor/ath79.c
+++ b/src/flash/nor/ath79.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2015 by Tobias Diedrich *
diff --git a/src/flash/nor/atsame5.c b/src/flash/nor/atsame5.c
index 163d142e3..fdd610f5f 100644
--- a/src/flash/nor/atsame5.c
+++ b/src/flash/nor/atsame5.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2017 by Tomas Vanek *
diff --git a/src/flash/nor/atsamv.c b/src/flash/nor/atsamv.c
index 857ad584b..67533fc1e 100644
--- a/src/flash/nor/atsamv.c
+++ b/src/flash/nor/atsamv.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-Source-Code) */
+// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-Source-Code)
/*
* Copyright (C) 2009 by Duane Ellis <op...@du...>
diff --git a/src/flash/nor/avrf.c b/src/flash/nor/avrf.c
index 900d8806a..0e2e263ce 100644
--- a/src/flash/nor/avrf.c
+++ b/src/flash/nor/avrf.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2009 by Simon Qian *
diff --git a/src/flash/nor/bluenrg-x.c b/src/flash/nor/bluenrg-x.c
index ec5cae76e..9ced2e971 100644
--- a/src/flash/nor/bluenrg-x.c
+++ b/src/flash/nor/bluenrg-x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2017 by Michele Sardo *
diff --git a/src/flash/nor/cc26xx.c b/src/flash/nor/cc26xx.c
index 9fbb880b4..6256ba6e7 100644
--- a/src/flash/nor/cc26xx.c
+++ b/src/flash/nor/cc26xx.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2017 by Texas Instruments, Inc. *
diff --git a/src/flash/nor/cc3220sf.c b/src/flash/nor/cc3220sf.c
index 6493d6c83..432a393f8 100644
--- a/src/flash/nor/cc3220sf.c
+++ b/src/flash/nor/cc3220sf.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2017 by Texas Instruments, Inc. *
diff --git a/src/flash/nor/cfi.c b/src/flash/nor/cfi.c
index affbcae23..78bc91e7d 100644
--- a/src/flash/nor/cfi.c
+++ b/src/flash/nor/cfi.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005, 2007 by Dominic Rath *
diff --git a/src/flash/nor/core.c b/src/flash/nor/core.c
index ec4ca05db..5e6c97152 100644
--- a/src/flash/nor/core.c
+++ b/src/flash/nor/core.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath <Dom...@gm...> *
diff --git a/src/flash/nor/drivers.c b/src/flash/nor/drivers.c
index ee54ef2d6..b9353d820 100644
--- a/src/flash/nor/drivers.c
+++ b/src/flash/nor/drivers.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2009 Zachary T Welch <zw...@su...> *
diff --git a/src/flash/nor/dsp5680xx_flash.c b/src/flash/nor/dsp5680xx_flash.c
index d04b0d651..b1625f11f 100644
--- a/src/flash/nor/dsp5680xx_flash.c
+++ b/src/flash/nor/dsp5680xx_flash.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2011 by Rodrigo L. Rosa *
diff --git a/src/flash/nor/efm32.c b/src/flash/nor/efm32.c
index 04b03c7d9..3a49afc9c 100644
--- a/src/flash/nor/efm32.c
+++ b/src/flash/nor/efm32.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/em357.c b/src/flash/nor/em357.c
index 63302f68a..043494c78 100644
--- a/src/flash/nor/em357.c
+++ b/src/flash/nor/em357.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/esirisc_flash.c b/src/flash/nor/esirisc_flash.c
index c30eba894..938d0f6af 100644
--- a/src/flash/nor/esirisc_flash.c
+++ b/src/flash/nor/esirisc_flash.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2018 by Square, Inc. *
diff --git a/src/flash/nor/faux.c b/src/flash/nor/faux.c
index 542a57458..e76dc493f 100644
--- a/src/flash/nor/faux.c
+++ b/src/flash/nor/faux.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2009 Ãyvind Harboe *
diff --git a/src/flash/nor/fespi.c b/src/flash/nor/fespi.c
index c61b708b1..9191764a9 100644
--- a/src/flash/nor/fespi.c
+++ b/src/flash/nor/fespi.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2010 by Antonio Borneo <bor...@gm...> *
diff --git a/src/flash/nor/fm3.c b/src/flash/nor/fm3.c
index 99fa02cc3..48f4493ab 100644
--- a/src/flash/nor/fm3.c
+++ b/src/flash/nor/fm3.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2011 by Marc Willam, Holger Wech *
diff --git a/src/flash/nor/fm4.c b/src/flash/nor/fm4.c
index 3a362d888..979ae84d0 100644
--- a/src/flash/nor/fm4.c
+++ b/src/flash/nor/fm4.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Spansion FM4 flash
diff --git a/src/flash/nor/jtagspi.c b/src/flash/nor/jtagspi.c
index ba1160ad5..c176ca810 100644
--- a/src/flash/nor/jtagspi.c
+++ b/src/flash/nor/jtagspi.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2015 Robert Jordens <jo...@gm...> *
diff --git a/src/flash/nor/kinetis.c b/src/flash/nor/kinetis.c
index 239cf4164..7137b4aa0 100644
--- a/src/flash/nor/kinetis.c
+++ b/src/flash/nor/kinetis.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2011 by Mathias Kuester *
diff --git a/src/flash/nor/kinetis_ke.c b/src/flash/nor/kinetis_ke.c
index 14e53f15d..c069f3ac8 100644
--- a/src/flash/nor/kinetis_ke.c
+++ b/src/flash/nor/kinetis_ke.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2015 by Ivan Meleca *
diff --git a/src/flash/nor/lpc2000.c b/src/flash/nor/lpc2000.c
index 473df06ef..f12eef7e4 100644
--- a/src/flash/nor/lpc2000.c
+++ b/src/flash/nor/lpc2000.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/lpc288x.c b/src/flash/nor/lpc288x.c
index e1cc38fb3..3006db1cb 100644
--- a/src/flash/nor/lpc288x.c
+++ b/src/flash/nor/lpc288x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2008 by *
diff --git a/src/flash/nor/lpc2900.c b/src/flash/nor/lpc2900.c
index 494fd66c7..c30fa7637 100644
--- a/src/flash/nor/lpc2900.c
+++ b/src/flash/nor/lpc2900.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2009 by *
diff --git a/src/flash/nor/lpcspifi.c b/src/flash/nor/lpcspifi.c
index 734730484..f950f21db 100644
--- a/src/flash/nor/lpcspifi.c
+++ b/src/flash/nor/lpcspifi.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2012 by George Harris *
diff --git a/src/flash/nor/max32xxx.c b/src/flash/nor/max32xxx.c
index 83eb57e68..51d6ae271 100644
--- a/src/flash/nor/max32xxx.c
+++ b/src/flash/nor/max32xxx.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2016 by Maxim Integrated *
diff --git a/src/flash/nor/mdr.c b/src/flash/nor/mdr.c
index c144b14b6..f6285de5b 100644
--- a/src/flash/nor/mdr.c
+++ b/src/flash/nor/mdr.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/mrvlqspi.c b/src/flash/nor/mrvlqspi.c
index f896c5a3b..4eb6522be 100644
--- a/src/flash/nor/mrvlqspi.c
+++ b/src/flash/nor/mrvlqspi.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2014 by Mahavir Jain <mj...@ma...> *
diff --git a/src/flash/nor/msp432.c b/src/flash/nor/msp432.c
index 6adf6c34b..d9b9695df 100644
--- a/src/flash/nor/msp432.c
+++ b/src/flash/nor/msp432.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2018 by Texas Instruments, Inc. *
diff --git a/src/flash/nor/niietcm4.c b/src/flash/nor/niietcm4.c
index 00a4a1764..0c36e2c96 100644
--- a/src/flash/nor/niietcm4.c
+++ b/src/flash/nor/niietcm4.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2015 by Bogdan Kolbov *
diff --git a/src/flash/nor/non_cfi.c b/src/flash/nor/non_cfi.c
index 5c05fb3b7..f096ba69c 100644
--- a/src/flash/nor/non_cfi.c
+++ b/src/flash/nor/non_cfi.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007 by Dominic Rath *
diff --git a/src/flash/nor/npcx.c b/src/flash/nor/npcx.c
index ec999e24a..bc8475346 100644
--- a/src/flash/nor/npcx.c
+++ b/src/flash/nor/npcx.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (C) 2020 by Nuvoton Technology Corporation
diff --git a/src/flash/nor/nrf5.c b/src/flash/nor/nrf5.c
index 9d2565b01..d5de4a464 100644
--- a/src/flash/nor/nrf5.c
+++ b/src/flash/nor/nrf5.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2013 Synapse Product Development *
diff --git a/src/flash/nor/numicro.c b/src/flash/nor/numicro.c
index a533c4103..1a73eb26d 100644
--- a/src/flash/nor/numicro.c
+++ b/src/flash/nor/numicro.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2011 by James K. Larson *
diff --git a/src/flash/nor/ocl.c b/src/flash/nor/ocl.c
index 4c1de632f..e00c365ed 100644
--- a/src/flash/nor/ocl.c
+++ b/src/flash/nor/ocl.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007 by Pavel Chromy *
diff --git a/src/flash/nor/pic32mx.c b/src/flash/nor/pic32mx.c
index aacafa123..9a1a63412 100644
--- a/src/flash/nor/pic32mx.c
+++ b/src/flash/nor/pic32mx.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/psoc4.c b/src/flash/nor/psoc4.c
index 8ca1a7cfa..c935bd5f2 100644
--- a/src/flash/nor/psoc4.c
+++ b/src/flash/nor/psoc4.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/psoc5lp.c b/src/flash/nor/psoc5lp.c
index b546b0aa0..407efbcab 100644
--- a/src/flash/nor/psoc5lp.c
+++ b/src/flash/nor/psoc5lp.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* PSoC 5LP flash driver
diff --git a/src/flash/nor/psoc6.c b/src/flash/nor/psoc6.c
index da07d8487..b7ba1027e 100644
--- a/src/flash/nor/psoc6.c
+++ b/src/flash/nor/psoc6.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* *
diff --git a/src/flash/nor/renesas_rpchf.c b/src/flash/nor/renesas_rpchf.c
index 145642fbe..6c51b8f67 100644
--- a/src/flash/nor/renesas_rpchf.c
+++ b/src/flash/nor/renesas_rpchf.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Renesas RCar Gen3 RPC Hyperflash driver
diff --git a/src/flash/nor/rp2040.c b/src/flash/nor/rp2040.c
index fb34172d2..667498ca3 100644
--- a/src/flash/nor/rp2040.c
+++ b/src/flash/nor/rp2040.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
#ifdef HAVE_CONFIG_H
#include "config.h"
diff --git a/src/flash/nor/rsl10.c b/src/flash/nor/rsl10.c
index ef501f4ee..d92c4b8b1 100644
--- a/src/flash/nor/rsl10.c
+++ b/src/flash/nor/rsl10.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2022 by Toms Stūrmanis *
diff --git a/src/flash/nor/sfdp.c b/src/flash/nor/sfdp.c
index e177a1945..5bfb54194 100644
--- a/src/flash/nor/sfdp.c
+++ b/src/flash/nor/sfdp.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2019 by Andreas Bolsch <and...@mn... *
diff --git a/src/flash/nor/sh_qspi.c b/src/flash/nor/sh_qspi.c
index 691c137dc..e8ca626df 100644
--- a/src/flash/nor/sh_qspi.c
+++ b/src/flash/nor/sh_qspi.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
+// SPDX-License-Identifier: GPL-2.0-only
/*
* SH QSPI (Quad SPI) driver
diff --git a/src/flash/nor/sim3x.c b/src/flash/nor/sim3x.c
index eede4825f..42550d06b 100644
--- a/src/flash/nor/sim3x.c
+++ b/src/flash/nor/sim3x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2014 by Ladislav Bábel *
diff --git a/src/flash/nor/spi.c b/src/flash/nor/spi.c
index 8f35d8f16..eed747b58 100644
--- a/src/flash/nor/spi.c
+++ b/src/flash/nor/spi.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2018 by Andreas Bolsch *
diff --git a/src/flash/nor/stellaris.c b/src/flash/nor/stellaris.c
index aa323d636..3a78952ef 100644
--- a/src/flash/nor/stellaris.c
+++ b/src/flash/nor/stellaris.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2006 by Magnus Lundin *
diff --git a/src/flash/nor/stm32f1x.c b/src/flash/nor/stm32f1x.c
index b00b70ac2..e882d7f79 100644
--- a/src/flash/nor/stm32f1x.c
+++ b/src/flash/nor/stm32f1x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/stm32f2x.c b/src/flash/nor/stm32f2x.c
index 7b3f9305d..36b7a0da5 100644
--- a/src/flash/nor/stm32f2x.c
+++ b/src/flash/nor/stm32f2x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/stm32h7x.c b/src/flash/nor/stm32h7x.c
index 126caa9cd..8be803728 100644
--- a/src/flash/nor/stm32h7x.c
+++ b/src/flash/nor/stm32h7x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2017 by STMicroelectronics *
diff --git a/src/flash/nor/stm32l4x.c b/src/flash/nor/stm32l4x.c
index a1108b5fd..7a6ec3fd2 100644
--- a/src/flash/nor/stm32l4x.c
+++ b/src/flash/nor/stm32l4x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2015 by Uwe Bonnes *
diff --git a/src/flash/nor/stm32lx.c b/src/flash/nor/stm32lx.c
index 64073c31c..42b52c5c2 100644
--- a/src/flash/nor/stm32lx.c
+++ b/src/flash/nor/stm32lx.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/stmqspi.c b/src/flash/nor/stmqspi.c
index ca4d51338..9c266e91a 100644
--- a/src/flash/nor/stmqspi.c
+++ b/src/flash/nor/stmqspi.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2016 - 2019 by Andreas Bolsch *
diff --git a/src/flash/nor/stmsmi.c b/src/flash/nor/stmsmi.c
index a4339def5..1aa244728 100644
--- a/src/flash/nor/stmsmi.c
+++ b/src/flash/nor/stmsmi.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2010 by Antonio Borneo <bor...@gm...> *
diff --git a/src/flash/nor/str7x.c b/src/flash/nor/str7x.c
index 98e0bbde0..b91e22e04 100644
--- a/src/flash/nor/str7x.c
+++ b/src/flash/nor/str7x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/str9x.c b/src/flash/nor/str9x.c
index 86ec455a1..1a26b839e 100644
--- a/src/flash/nor/str9x.c
+++ b/src/flash/nor/str9x.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/str9xpec.c b/src/flash/nor/str9xpec.c
index 28cfe5d4f..c39eb3aa8 100644
--- a/src/flash/nor/str9xpec.c
+++ b/src/flash/nor/str9xpec.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/flash/nor/swm050.c b/src/flash/nor/swm050.c
index d0cb986a0..89e59ae47 100644
--- a/src/flash/nor/swm050.c
+++ b/src/flash/nor/swm050.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2019 Icenowy Zheng <ic...@ao...> *
diff --git a/src/flash/nor/tcl.c b/src/flash/nor/tcl.c
index c18451364..4ff6d9838 100644
--- a/src/flash/nor/tcl.c
+++ b/src/flash/nor/tcl.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath <Dom...@gm...> *
diff --git a/src/flash/nor/tms470.c b/src/flash/nor/tms470.c
index 9fffae90a..e01d2df0a 100644
--- a/src/flash/nor/tms470.c
+++ b/src/flash/nor/tms470.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007,2008 by Christopher Kilgour *
diff --git a/src/flash/nor/virtual.c b/src/flash/nor/virtual.c
index 212d53a4c..c5e33385e 100644
--- a/src/flash/nor/virtual.c
+++ b/src/flash/nor/virtual.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2010 by Spencer Oliver *
diff --git a/src/flash/nor/w600.c b/src/flash/nor/w600.c
index 98c0f46e5..20968dcaa 100644
--- a/src/flash/nor/w600.c
+++ b/src/flash/nor/w600.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2018 by Simon Qian *
diff --git a/src/flash/nor/xcf.c b/src/flash/nor/xcf.c
index eb1e84223..287072551 100644
--- a/src/flash/nor/xcf.c
+++ b/src/flash/nor/xcf.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2016 by Uladzimir Pylinski aka barthess *
diff --git a/src/flash/nor/xmc1xxx.c b/src/flash/nor/xmc1xxx.c
index 04a39f36e..6e30fc125 100644
--- a/src/flash/nor/xmc1xxx.c
+++ b/src/flash/nor/xmc1xxx.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* XMC1000 flash driver
diff --git a/src/flash/nor/xmc4xxx.c b/src/flash/nor/xmc4xxx.c
index 50ec45f66..54fd5a586 100644
--- a/src/flash/nor/xmc4xxx.c
+++ b/src/flash/nor/xmc4xxx.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/**************************************************************************
* Copyright (C) 2015 Jeff Ciesielski <jef...@gm...> *
diff --git a/src/hello.c b/src/hello.c
index db6774eaa..4a4ce01ca 100644
--- a/src/hello.c
+++ b/src/hello.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2009 Zachary T Welch <zw...@su...> *
diff --git a/src/helper/binarybuffer.c b/src/helper/binarybuffer.c
index 250ca4357..5f38b43ae 100644
--- a/src/helper/binarybuffer.c
+++ b/src/helper/binarybuffer.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2004, 2005 by Dominic Rath *
diff --git a/src/helper/command.c b/src/helper/command.c
index b5c5459a1..6898e2d7c 100644
--- a/src/helper/command.c
+++ b/src/helper/command.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/helper/configuration.c b/src/helper/configuration.c
index b62279c28..16732eb3d 100644
--- a/src/helper/configuration.c
+++ b/src/helper/configuration.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2004, 2005 by Dominic Rath *
diff --git a/src/helper/fileio.c b/src/helper/fileio.c
index a4130b79c..a290a5d2f 100644
--- a/src/helper/fileio.c
+++ b/src/helper/fileio.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2007 by Dominic Rath *
diff --git a/src/helper/jep106.c b/src/helper/jep106.c
index 992452d27..d422561bc 100644
--- a/src/helper/jep106.c
+++ b/src/helper/jep106.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2015 Andreas Fritiofson *
diff --git a/src/helper/jim-nvp.c b/src/helper/jim-nvp.c
index 0e76f96de..e1ab64ae5 100644
--- a/src/helper/jim-nvp.c
+++ b/src/helper/jim-nvp.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: BSD-2-Clause-Views */
+// SPDX-License-Identifier: BSD-2-Clause-Views
/* Jim - A small embeddable Tcl interpreter
*
diff --git a/src/helper/log.c b/src/helper/log.c
index b49c9af94..e6a70a3f5 100644
--- a/src/helper/log.c
+++ b/src/helper/log.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/helper/options.c b/src/helper/options.c
index 205d5e793..327c418d0 100644
--- a/src/helper/options.c
+++ b/src/helper/options.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2004, 2005 by Dominic Rath *
diff --git a/src/helper/replacements.c b/src/helper/replacements.c
index 2cbce7f3b..b30dbd5d6 100644
--- a/src/helper/replacements.c
+++ b/src/helper/replacements.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2006 by Dominic Rath *
diff --git a/src/helper/time_support.c b/src/helper/time_support.c
index 548a71693..dda3cb3e4 100644
--- a/src/helper/time_support.c
+++ b/src/helper/time_support.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2006 by Dominic Rath *
diff --git a/src/helper/time_support_common.c b/src/helper/time_support_common.c
index 8d11602f3..9d17a315b 100644
--- a/src/helper/time_support_common.c
+++ b/src/helper/time_support_common.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2006 by Dominic Rath *
diff --git a/src/helper/util.c b/src/helper/util.c
index 397b8a211..bf18f8e60 100644
--- a/src/helper/util.c
+++ b/src/helper/util.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2010 by Ãyvind Harboe *
diff --git a/src/jtag/adapter.c b/src/jtag/adapter.c
index a0432b692..b7feac575 100644
--- a/src/jtag/adapter.c
+++ b/src/jtag/adapter.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (C) 2005 by Dominic Rath <Dom...@gm...>
* Copyright (C) 2007-2010 Ãyvind Harboe <oyv...@zy...>
diff --git a/src/jtag/aice/aice_interface.c b/src/jtag/aice/aice_interface.c
index 7c57d444d..89f82a0ae 100644
--- a/src/jtag/aice/aice_interface.c
+++ b/src/jtag/aice/aice_interface.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2013 by Andes Technology *
diff --git a/src/jtag/aice/aice_pipe.c b/src/jtag/aice/aice_pipe.c
index 365195238..1ee2d88b4 100644
--- a/src/jtag/aice/aice_pipe.c
+++ b/src/jtag/aice/aice_pipe.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2013 by Andes Technology *
diff --git a/src/jtag/aice/aice_port.c b/src/jtag/aice/aice_port.c
index 29188d843..ac38cec3a 100644
--- a/src/jtag/aice/aice_port.c
+++ b/src/jtag/aice/aice_port.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2013 by Andes Technology *
diff --git a/src/jtag/aice/aice_transport.c b/src/jtag/aice/aice_transport.c
index be853a862..49f899ddc 100644
--- a/src/jtag/aice/aice_transport.c
+++ b/src/jtag/aice/aice_transport.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2013 by Andes Technology *
diff --git a/src/jtag/aice/aice_usb.c b/src/jtag/aice/aice_usb.c
index 66cd07f63..b5d0f0b6e 100644
--- a/src/jtag/aice/aice_usb.c
+++ b/src/jtag/aice/aice_usb.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2013 by Andes Technology *
diff --git a/src/jtag/commands.c b/src/jtag/commands.c
index 8d7875af2..43cda8ad4 100644
--- a/src/jtag/commands.c
+++ b/src/jtag/commands.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2005 by Dominic Rath *
diff --git a/src/jtag/core.c b/src/jtag/core.c
index 806ee8926..574801187 100644
--- a/src/jtag/core.c
+++ b/src/jtag/core.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// SPDX-License-Identifier: GPL-2.0-or-later
/***************************************************************************
* Copyright (C) 2009 Zachary T Welch *
diff --git a/src/jtag/drivers/OpenULINK/src/delay.c b/src/jtag/drivers/OpenULINK/src/delay.c
index d858a8ace..b68e8148a 100644
--- a/src/jtag/drivers/OpenULINK/src/delay.c
+++ b/src/jtag/drivers/OpenULINK/src/delay.c
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+// S...
[truncated message content] |
