#1045 Changes in "Edit Filter"dialog window not reflected when the window is called up again

[Kos Ivantsov]

Any changes in "Edit Filter" dialog don't show when the dialog is closed and then called up again while "File Filters" window remained open.
Steps to reproduce:

1. Select any filter in File Filters list, click Edit...

2. Add a new extension (click Add...) or make any other change (encoding, for instance) in the Edit Filter window

3. Click OK to get back to File Filters.

4. Don’t close the window, but select the same filter as in step 1, click Edit... again.

   The changes made in step 2 are not reflected.
   If no further changes are done at this stage, and then the File Filters window is closed with OK button, changes made in step 2 might be saved and show up next time the user goes to this filter setup: File Filters → Edit... while previously edited filter is selected.
   If further changes were made at step 4, they will be discarded even if the user closes every window with OK button, though it looks as if they are going to be saved.

I'm attaching a few screenshot here that just illustrate the behavior described above. Originally the bug was found when testing Okapi plugin and that is reflected in the screenshots, but this behavior is identical with native filters too, of filters coming from other plugins.

Similar behavior was reported before:
[bugs:#966]
[bugs:#990]

[Hiroshi Miura]

The file filter editor dialog has table which data model hold non-edit filters list.
The filters list is not updated even when edit, but OmegaT hold editableFilters which is to be seaved.

This double list is a cause of a behavior.

Please see org.omegat.gui.filters2.FiltersCustomizerController.java line 200.
It only update editableFilter after click OK in individual filter setting dialog.

[Hiroshi Miura]

https://github.com/omegat-org/omegat/pull/665

[Hiroshi Miura]

merged