jedit-devel

[ jEdit-devel ] [jedit:bugs] #4127 Incorrect FSF address by rpmlint

[Zdeněk <zza...@us...>]

Hi,

yy, this one is correct one from my understanding: 
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA

Actually here is [fsf_wrong_address_regex](
https://github.com/rpm-software-management/rpmlint/blob/78f5077db615c769ff592ed2e30dc97c13ffc432/rpmlint/checks/FilesCheck.py#L210) in rpmlint. :)

List of affected files is in [bugzilla](https://bugzilla.redhat.com/show_bug.cgi?id=2228918#c14) (search for incorrect-fsf-address).













---

**[bugs:#4127] Incorrect FSF address by rpmlint**

**Status:** open
**Group:** minor bug
**Created:** Mon Aug 07, 2023 12:33 PM UTC by Zdeněk
**Last Updated:** Wed Oct 04, 2023 08:16 PM UTC
**Owner:** nobody


Multiple [problems](https://bugzilla.redhat.com/show_bug.cgi?id=2228918#c14) with incorrect address of FSF in files were detected by rpmlint tool. I am reporting this in accordance with fedora [guidelines](https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address).


---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

Re: [ jEdit-devel ] Removing jsr305

[Vampire <Va...@jE...>]

> did you try to add a module-info.java in jEdit ?

Not before, as I don't see any benefits, as described above.
But yes, now I also tried it in jEdit and it works perfectly fine,
though I still don't see why we should do that, so even if it were a problem it would not be for jEdit.

> I tried and got a split package error,

I have no idea how you managed that.

> I am of course not the only one, and it seems the solution for everybody is to replace the lib which is obsolete in my opinion.

"everybody" here just means the ones not managing to just use it and publicly complaining.
The people that manage to use it, don't publicly brag about it, especially as there is not much necessary to use it.
Even if it is a bit outdated, it still serves its purpose well and is supported by all usual tools by default.
Replacing with one of the competitors might be fine, if you find one that is compatible license-wise, but that would then again be a question for someone that knows exactly how you can combine different licenses, or a lawyer.

> https://nipafx.dev/jsr-305-java-9/ for example.

That blog post is pretty irrelevant though.
It describes a problem with Java 9, where there indeed still were annotations in the `javax.annotation` package in the standard JDK in the module `java.xml.ws.annotation`.
So there indeed was a split-package problem, that you would then have to mitigate for example using `--patch-module`, which would also have been ok as it is just a compile dependency, not a runtime dependency.

But the whole module and classes were removed in Java 11 which is even now our minimum version,
so the split-package is gone as long as we do not add a dependency to a second module with that package, which is unlikely.

> I don't like the idea of not being able to test it and maybe see advantages

I'm curious, tell me if you find any.
In the meantime I'd suggest that we revert your commit that inlines those annotations.
I attached for you the changes I did to compile as JPMS module, based on the revision before your changes.

> Do you have in mind some tools you use that could not be configured for that ?

Sure, many tools can be configured.
I don't know whether all.
But the point is, that you then do need to configure them,
while with the supported annotations, it will just work out-of-the-box.

Cheers
Björn

Am 14.10.2023 08:50, schrieb Matthieu Casanova:
> Hey,
> did you try to add a module-info.java in jEdit ?
> I tried and got a split package error, I am of course not the only one, and it seems the solution for everybody is to replace the lib which is obsolete in my opinion.
> https://nipafx.dev/jsr-305-java-9/ for example.
> I have no strong opinion about the fact of making jEdit a JPMS but I don't like the idea of not being able to test it and maybe see advantages.
> About replacing the annotations my intention would have been to use something widely used like jakarta annotations, but there is a different licence.
> About the tools that uses those annotations I think most of them should be configurable as most major projects (Eclipse, Spring and many others define their own similar annotations). At least IntelliJ Idea is configurable for Nullable and Nonnull. Do you have in mind some tools you use that could not be configured for that ?
>
> -- 
>   Matthieu Casanova
>   cho...@gm... <mailto:cho...@gm...>
>
>
> Ven 13 oct 2023, à 23:35, Vampire a écrit :
>> Hi
>>
>> Where did you actually see that problem and what exactly?
>>
>> I checked in Java 11 and Java 21 and in both there are only things within `javax.annotation.processing`.
>> In the jsr350 JAR are only things in `javax.annotation`, `javax.annotation.meta`,  and `javax.annotation.concurrent`, so there should not be a split-package problem there.
>>
>> I also quickly tried in a play project and it works like a charm.
>> jsr305 jar to the module path, a "requires transitive ..." clause to the module info, and all compiles just fine without complaint with both, Java 11 and Java 21.
>>
>> Besides that, it is imho anyway questionable whether jEdit should be made a JPMS module.
>> Which advantages do you see?
>> If we would start from scratch, it would maybe make sense.
>> And if we would have a clear definition of what Plugin API is and what not,
>> it would probably also be great to enforce this restriction by default.
>>
>> So unless we really want to define a clear Plugin API and forbid plugins to use anything else by default, it would maybe make sense.
>>
>> But even then, as I wrote above it should not be much of a problem to continue using the jsr305 annotations.
>> And it would probably even be preferable, as typically tools support these annotations,
>> but will not support the custom copies you made.
>>
>> What do you think?
>>
>> Cheers
>> Björn
>>
>>
>>
>>
>> Am 11.10.2023 21:24, schrieb Matthieu Casanova:
>>> Hey,
>>> years ago I added the google jsr305 library (annotations like Nonnull, Nullable) which is mostly a helper for IDE and documentation.
>>> Unfortunately that JSR was never aprooved which was not a problem until Java released the module system :
>>>
>>> Because those annotations were in javax package it caused problems when activating the module system introduced in Java 9 because javax is of course part of JRE so another library cannot provide the same package.
>>> So basically I created the same annotations in
>>>
>>> org.jedit.annotation package.
>>>
>>>
>>> Matthieu
>>>
>>>
>>>
>>>
>

[ jEdit-devel ] [jedit:bugs] #4118 BeanShell error: module java.base does not "opens java.lang" to unnamed module

[Björn K. <vam...@us...>]

- **status**: open --> closed-fixed
- **assigned_to**: Björn Kautler
- **Group**: Regressive (new to devel) --> normal bug



---

**[bugs:#4118] BeanShell error: module java.base does not "opens java.lang" to unnamed module**

**Status:** closed-fixed
**Group:** normal bug
**Labels:** macro 
**Created:** Fri Apr 22, 2022 04:03 PM UTC by blurredd
**Last Updated:** Sat Oct 14, 2023 11:42 AM UTC
**Owner:** Björn Kautler


I see the following BeanShell error when running a macro that appends to a StringBuilder:

```text
Sourced file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh unknown error: Unable to make public java.lang.AbstractStringBuilder java.lang.AbstractStringBuilder.append(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @7c75222b : at Line: 2 :
 in file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh
 : sb .append ( "test" ) 

	at org.gjt.sp.jedit.bsh.Interpreter.eval(Interpreter.java:696)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:343)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:291)
	at org.gjt.sp.jedit.BeanShell.runScript(BeanShell.java:217)
	at org.gjt.sp.jedit.Macros$BeanShellHandler.runMacro(Macros.java:1108)
	at org.gjt.sp.jedit.Macros$Macro.invoke(Macros.java:530)
	at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:343)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3417)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3399)
	at org.gjt.sp.jedit.EditAction$Wrapper.actionPerformed(EditAction.java:225)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
...
```

StringBuilderTest.bsh:

```java
StringBuilder sb = new StringBuilder():
sb.append("test");
```

I'm using jEdit 5.6.0, java version 17.0.2 on Windows 10 Enterprise.




---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[ jEdit-devel ] [jedit:bugs] #4118 BeanShell error: module java.base does not "opens java.lang" to unnamed module

[Björn K. <vam...@us...>]

Ok, I slept over it and looked through the code again.
I feel confident enough to do it still for 5.7.0, so this should hopefully be fixed now.


---

**[bugs:#4118] BeanShell error: module java.base does not "opens java.lang" to unnamed module**

**Status:** open
**Group:** Regressive (new to devel)
**Labels:** macro 
**Created:** Fri Apr 22, 2022 04:03 PM UTC by blurredd
**Last Updated:** Sat Oct 14, 2023 01:00 AM UTC
**Owner:** nobody


I see the following BeanShell error when running a macro that appends to a StringBuilder:

```text
Sourced file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh unknown error: Unable to make public java.lang.AbstractStringBuilder java.lang.AbstractStringBuilder.append(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @7c75222b : at Line: 2 :
 in file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh
 : sb .append ( "test" ) 

	at org.gjt.sp.jedit.bsh.Interpreter.eval(Interpreter.java:696)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:343)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:291)
	at org.gjt.sp.jedit.BeanShell.runScript(BeanShell.java:217)
	at org.gjt.sp.jedit.Macros$BeanShellHandler.runMacro(Macros.java:1108)
	at org.gjt.sp.jedit.Macros$Macro.invoke(Macros.java:530)
	at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:343)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3417)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3399)
	at org.gjt.sp.jedit.EditAction$Wrapper.actionPerformed(EditAction.java:225)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
...
```

StringBuilderTest.bsh:

```java
StringBuilder sb = new StringBuilder():
sb.append("test");
```

I'm using jEdit 5.6.0, java version 17.0.2 on Windows 10 Enterprise.




---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

Re: [ jEdit-devel ] Removing jsr305

[Matthieu C. <cho...@gm...>]

Hey,
did you try to add a module-info.java in jEdit ?
I tried and got a split package error, I am of course not the only one, and it seems the solution for everybody is to replace the lib which is obsolete in my opinion.
https://nipafx.dev/jsr-305-java-9/ for example.
I have no strong opinion about the fact of making jEdit a JPMS but I don't like the idea of not being able to test it and maybe see advantages.
About replacing the annotations my intention would have been to use something widely used like jakarta annotations, but there is a different licence.
About the tools that uses those annotations I think most of them should be configurable as most major projects (Eclipse, Spring and many others define their own similar annotations). At least IntelliJ Idea is configurable for Nullable and Nonnull. Do you have in mind some tools you use that could not be configured for that ?

-- 
  Matthieu Casanova
  cho...@gm...


Ven 13 oct 2023, à 23:35, Vampire a écrit :
> Hi
> 
> Where did you actually see that problem and what exactly?
> 
> I checked in Java 11 and Java 21 and in both there are only things within `javax.annotation.processing`.
> In the jsr350 JAR are only things in `javax.annotation`, `javax.annotation.meta`,  and `javax.annotation.concurrent`, so there should not be a split-package problem there.
> 
> I also quickly tried in a play project and it works like a charm.
> jsr305 jar to the module path, a "requires transitive ..." clause to the module info, and all compiles just fine without complaint with both, Java 11 and Java 21.
> 
> Besides that, it is imho anyway questionable whether jEdit should be made a JPMS module.
> Which advantages do you see?
> If we would start from scratch, it would maybe make sense.
> And if we would have a clear definition of what Plugin API is and what not,
> it would probably also be great to enforce this restriction by default.
> 
> So unless we really want to define a clear Plugin API and forbid plugins to use anything else by default, it would maybe make sense.
> 
> But even then, as I wrote above it should not be much of a problem to continue using the jsr305 annotations.
> And it would probably even be preferable, as typically tools support these annotations,
> but will not support the custom copies you made.
> 
> What do you think?
> 
> Cheers
> Björn
> 
> 
> 
> 
> Am 11.10.2023 21:24, schrieb Matthieu Casanova:
>> Hey,
>> years ago I added the google jsr305 library (annotations like Nonnull, Nullable) which is mostly a helper for IDE and documentation.
>> Unfortunately that JSR was never aprooved which was not a problem until Java released the module system :
>> 
>> Because those annotations were in javax package it caused problems when activating the module system introduced in Java 9 because javax is of course part of JRE so another library cannot provide the same package.
>> So basically I created the same annotations in
>> 
>> org.jedit.annotation package.
>> 
>> 
>> Matthieu
>> 
>> 
>> 
>> 

[ jEdit-devel ] [jedit:bugs] #4118 BeanShell error: module java.base does not "opens java.lang" to unnamed module

[Björn K. <vam...@us...>]

I had a quick look through the code, and I don't think something should really break by doing this, except accessing inaccessible fields that worked before after a class was defined somewhere. I'll sleep it over and maybe we can even put it in 5.7.0.


---

**[bugs:#4118] BeanShell error: module java.base does not "opens java.lang" to unnamed module**

**Status:** open
**Group:** Regressive (new to devel)
**Labels:** macro 
**Created:** Fri Apr 22, 2022 04:03 PM UTC by blurredd
**Last Updated:** Sat Oct 14, 2023 12:18 AM UTC
**Owner:** nobody


I see the following BeanShell error when running a macro that appends to a StringBuilder:

```text
Sourced file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh unknown error: Unable to make public java.lang.AbstractStringBuilder java.lang.AbstractStringBuilder.append(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @7c75222b : at Line: 2 :
 in file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh
 : sb .append ( "test" ) 

	at org.gjt.sp.jedit.bsh.Interpreter.eval(Interpreter.java:696)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:343)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:291)
	at org.gjt.sp.jedit.BeanShell.runScript(BeanShell.java:217)
	at org.gjt.sp.jedit.Macros$BeanShellHandler.runMacro(Macros.java:1108)
	at org.gjt.sp.jedit.Macros$Macro.invoke(Macros.java:530)
	at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:343)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3417)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3399)
	at org.gjt.sp.jedit.EditAction$Wrapper.actionPerformed(EditAction.java:225)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
...
```

StringBuilderTest.bsh:

```java
StringBuilder sb = new StringBuilder():
sb.append("test");
```

I'm using jEdit 5.6.0, java version 17.0.2 on Windows 10 Enterprise.




---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[ jEdit-devel ] [jedit:bugs] #4118 BeanShell error: module java.base does not "opens java.lang" to unnamed module

[Björn K. <vam...@us...>]

Actually, we might be more lucky than we should be. :-D
You can easily reproduce with this snippet:
```
class Foo { }
StringBuilder sb = new StringBuilder();
sb.append("test");
```

The good thing is, I felt brave and just commented out the `Capabilities.setAccessibility( true );` call.
And what should I say, it worked. :-)
So maybe that comment is not up-to-date anymore actually.

I wouldn't do this change now shortly before the 5.7.0 release,
but after that, we can maybe just do it and see how it works out. :-)


---

**[bugs:#4118] BeanShell error: module java.base does not "opens java.lang" to unnamed module**

**Status:** open
**Group:** Regressive (new to devel)
**Labels:** macro 
**Created:** Fri Apr 22, 2022 04:03 PM UTC by blurredd
**Last Updated:** Fri Oct 13, 2023 11:53 PM UTC
**Owner:** nobody


I see the following BeanShell error when running a macro that appends to a StringBuilder:

```text
Sourced file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh unknown error: Unable to make public java.lang.AbstractStringBuilder java.lang.AbstractStringBuilder.append(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @7c75222b : at Line: 2 :
 in file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh
 : sb .append ( "test" ) 

	at org.gjt.sp.jedit.bsh.Interpreter.eval(Interpreter.java:696)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:343)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:291)
	at org.gjt.sp.jedit.BeanShell.runScript(BeanShell.java:217)
	at org.gjt.sp.jedit.Macros$BeanShellHandler.runMacro(Macros.java:1108)
	at org.gjt.sp.jedit.Macros$Macro.invoke(Macros.java:530)
	at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:343)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3417)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3399)
	at org.gjt.sp.jedit.EditAction$Wrapper.actionPerformed(EditAction.java:225)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
...
```

StringBuilderTest.bsh:

```java
StringBuilder sb = new StringBuilder():
sb.append("test");
```

I'm using jEdit 5.6.0, java version 17.0.2 on Windows 10 Enterprise.




---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[ jEdit-devel ] [jedit:bugs] #4118 BeanShell error: module java.base does not "opens java.lang" to unnamed module

[Björn K. <vam...@us...>]

The point why the snippet first works and then not anymore, is the usage of classes in a macro suddenly changes configuration.

By default `Capabilities#accessibility` is `false`.
This means BeanShell does not try to do `setAccessible` and alike.
There is exactly one place where this is set to `true`, which is when a class (named or anonymous) is found in a BeanShell code that is executed.
The current implementation in `ClassGeneratorImpl#generateClassImpl`  has the comment
> // Scripting classes currently requires accessibility
> // This can be eliminated with a bit more work.

and then calls `Capabilities.setAccessibility( true );`.
This call succeeds if the classes `AccessibleObject` and `ReflectManagerImpl` are found and the security manager does not object to the call `String.class.getDeclaredMethods();` which is meant as basic reflection check call.

We could easily add a check whether an actual `isAccessible` call on some private field or method succeeds, or with updating to Java 17 or 21 we could just hard-code the value to `false` or remove the `ReflectManagerImpl` class which should have the same effect.

On the one hand this would maybe not be bad, as it adds consistency to the behavior.
Currently, things work one way unless some BeanShell snippet with a class definition is invoked and then suddenly start to behave differently, which could mean they start to fail while worked before, start to work while failed before or continue working but change behavior.

On the other hand, only that change would mean that no BeanShell snippets that define classes are supported anymore and things that maybe worked before after executing such a snippet might not work anymore. The latter is maybe not so tragic, but I'm not sure how bad it would be to not support classes anymore.

On the other hand, someone could have a look at what the comment means with "This can be eliminated with a bit more work." and maybe do that more work ourselves, then it might be better acceptable to disable the accessibility capability permanently.


---

**[bugs:#4118] BeanShell error: module java.base does not "opens java.lang" to unnamed module**

**Status:** open
**Group:** Regressive (new to devel)
**Labels:** macro 
**Created:** Fri Apr 22, 2022 04:03 PM UTC by blurredd
**Last Updated:** Fri Oct 13, 2023 10:33 PM UTC
**Owner:** nobody


I see the following BeanShell error when running a macro that appends to a StringBuilder:

```text
Sourced file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh unknown error: Unable to make public java.lang.AbstractStringBuilder java.lang.AbstractStringBuilder.append(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @7c75222b : at Line: 2 :
 in file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh
 : sb .append ( "test" ) 

	at org.gjt.sp.jedit.bsh.Interpreter.eval(Interpreter.java:696)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:343)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:291)
	at org.gjt.sp.jedit.BeanShell.runScript(BeanShell.java:217)
	at org.gjt.sp.jedit.Macros$BeanShellHandler.runMacro(Macros.java:1108)
	at org.gjt.sp.jedit.Macros$Macro.invoke(Macros.java:530)
	at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:343)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3417)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3399)
	at org.gjt.sp.jedit.EditAction$Wrapper.actionPerformed(EditAction.java:225)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
...
```

StringBuilderTest.bsh:

```java
StringBuilder sb = new StringBuilder():
sb.append("test");
```

I'm using jEdit 5.6.0, java version 17.0.2 on Windows 10 Enterprise.




---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[ jEdit-devel ] [jedit:bugs] #4118 BeanShell error: module java.base does not "opens java.lang" to unnamed module

[Björn K. <vam...@us...>]

Besides that jsr305 would not be any problem as I wrote on the mailing list, how do you think would making jEdit a JPMS module change anything? That would not magically make BeanShell be able to do that reflection. You would still need the `--add-opens` either way. And you can also use the `--add-opens` fine without making jEdit a JPMS module. As we build the `jedit.jar` as executable jar and only start it like that, we can even put those as `Add-Opens` attribute to the manifest of `jedit.jar` and it would work, without jEdit being a JPMS module.

But the bigger problem probably is, that those two are not exhaustive. They might fix this specific BeanShell snippet. But there are probably others? Potentially ever package in the JDK? I doubt we should or could add `Add-Opens` for the whole JDK world.


---

**[bugs:#4118] BeanShell error: module java.base does not "opens java.lang" to unnamed module**

**Status:** open
**Group:** Regressive (new to devel)
**Labels:** macro 
**Created:** Fri Apr 22, 2022 04:03 PM UTC by blurredd
**Last Updated:** Sun Oct 08, 2023 07:56 PM UTC
**Owner:** nobody


I see the following BeanShell error when running a macro that appends to a StringBuilder:

```text
Sourced file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh unknown error: Unable to make public java.lang.AbstractStringBuilder java.lang.AbstractStringBuilder.append(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @7c75222b : at Line: 2 :
 in file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh
 : sb .append ( "test" ) 

	at org.gjt.sp.jedit.bsh.Interpreter.eval(Interpreter.java:696)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:343)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:291)
	at org.gjt.sp.jedit.BeanShell.runScript(BeanShell.java:217)
	at org.gjt.sp.jedit.Macros$BeanShellHandler.runMacro(Macros.java:1108)
	at org.gjt.sp.jedit.Macros$Macro.invoke(Macros.java:530)
	at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:343)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3417)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3399)
	at org.gjt.sp.jedit.EditAction$Wrapper.actionPerformed(EditAction.java:225)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
...
```

StringBuilderTest.bsh:

```java
StringBuilder sb = new StringBuilder():
sb.append("test");
```

I'm using jEdit 5.6.0, java version 17.0.2 on Windows 10 Enterprise.




---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

Re: [ jEdit-devel ] Java 21 for jEdit ?

[Vampire <Va...@jE...>]

You understood a bit wrong then.

I'm sorry, I just found that my last answer to that license thread two years ago was somehow not sent, but still hung as draft here, though I was sure I sent it.
Anyway, I'll incorporate it here.

If jEdit would be under GPLv2, there were no way whatsover to upgrade to GPL3,
other than asking each and every contributor for permission to do so, or rewriting all code so that no other contributor's code is present anymore, which both are pretty impossible tasks. Someone could get the idea to ask for example on the devel mailing list for objections and just do it if no objections come in, but that would **not** be legally sufficient.

Luckily, jEdit is **not** under GPLv2. It is under GPLv2+ with plugin exception.
The plugin exception makes it possible to have plugins with other licenses or to create Isabelle as long as the conditions are met.
The "+" in GPLv2+ means, that you can update to a newer GPL version any time.
You cannot simply "commit one GPLv3 class and magically have everything GPLv3". But you also don't need to. You can simply update all mentions, documentation, copyright headers in files, and so on to have the new header for GPLv3+ instead of the current GPLv2+ (copied from the GPLv3+ usage instructions, not just exchanging 2 by 3 in case something changed there).

That would be enough to make the GPLv2+ code GPLv3+ code in the future. I'll second that change, wouldn't be a problem to me.

It is also correct, that once we switched to GPLv3+, we could **theoretically** incorporate ASLv2 code as these two licenses were specifically designed to be compatible.

But compatible does **not** mean that you can simply copy in the ASLv2 code and release it as GPLv3+ code and be done.
For that code you would need to then follow all terms of GPLv3+ AND ASLv2, like prominent notices of what was changed in each file and so on and so forth.

I am not a lawyer and I never did this.
So I cannot tell you what we exactly would need to do to make this legally correct.
So even if we switch to GPLv3+, before you stuff in any ASLv2 code, I would recommend you ask a lawyer that is specialized to open source licenses about what is necessary to make this legally correct so that none of us can get into trouble for copyright infringement.

Cheers
Björn

Am 04.10.2023 23:48, schrieb Dale Anson:
> Yes, that's what I understand. There was a conversation about this some time ago and that was the consensus at the time. The newer beanshell code is licensed under Apache license, where the version in jEdit right now is GPL, and GPL3 would let us include the newer beanshell code even though it's using the Apache license. I'd be happy to update the beanshell code to the newer version, but not for this release since it would need some pretty good testing to make sure we don't break existing macros.
>
> On Wed, Oct 4, 2023 at 3:05 PM Matthieu Casanova <cho...@gm... <mailto:cho...@gm...>> wrote:
>
>     I am not sure I understand well (but I am not a licence expert).
>     But today jEdit is GPL 2. And you say that adding some GPL 3 code would change all jEdit to GPL 3 automatically ?
>     Any new code or it has to be specific ?
>     Because if it is any new code I committed a few weeks ago that new class which comes with no dependencies to any other part of jEdit and since I am the only committer I suppose I can change it's licence to any licence right ?
>     https://sourceforge.net/p/jedit/svn/25686/tree//jEdit/trunk/org/jedit/util/SystemManager.java
>
>     Matthieu
>
>     Mer 04 oct 2023, à 22:47, Dale Anson a écrit :
>>     The license issue shouldn't be hard to resolve, GPL 3 would allow Apache licensed code to be mixed in. We just need some new code with a GPL 3 license committed to the project, then the rest is automatic.
>>
>>     On Wed, Oct 4, 2023 at 2:10 PM Matthieu Casanova <kp...@fa... <mailto:kp...@fa...>> wrote:
>>
>>
>>         Hey,
>>         are you able to reproduce it today ?
>>         I tried with a macro
>>
>>         sb.bsh containing
>>
>>         StringBuilder sb = new StringBuilder();
>>         sb.append("test");
>>         System.out.println(sb.toString());
>>
>>         I run it with Java 17.0.8.1 (Adoptium) and it works.
>>         I tried to recompile jEdit with that same JDK and ran jEdit and the test and it also worked.
>>         Did I miss something or maybe someone fixed the bug already?
>>
>>         As Dale told it seems we will not be able to upgrade Beanshell because of their licence change so we have the choice to find another alternative that would be compatible with GPL (I don't know any), otherwise we might try to solve the problem ourselves in our version of Beanshell.
>>
>>         -- 
>>           Matthieu Casanova
>>           cho...@gm... <mailto:cho...@gm...>
>>
>>
>>         Mer 04 oct 2023, à 22:03, Dale Anson a écrit :
>>>         I believe it's in the same place it was last year. It isn't hard to upgrade the integrated beanshell to a newer, java 17+ compatible version, but there is still the GPL vs Apache license issue which hasn't been worked out.
>>>
>>>         On Wed, Oct 4, 2023 at 1:40 PM Robert Schwenn <Rob...@ka... <mailto:Rob...@ka...>> wrote:
>>>
>>>
>>>             Hi,
>>>
>>>             do You have in mind that there's a issue with integrated beanshell (https://sourceforge.net/p/jedit/bugs/4118/) not being compatible with java 17 (and presumably later)? Or is it fixed already (or a mistake)?
>>>
>>>             Robert
>>>
>>>
>>>
>>>             Am 02.10.2023 um 23:27 schrieb Matthieu Casanova:
>>>>             Hey,
>>>>             we missed java 17 and are still on java 11. Java 21 arrived and it is LTS, I think it would be nice that the next version of jEdit (after 5.7 release) would be java 21 which brings a lot of nice features especially virtual threads.
>>>>             Anyone against it ?
>>>>
>>>>             Matthieu
>>>>
>>>
>>>             --
>>>             -----------------------------------------------
>>>             jEdit Developers' List
>>>             jEd...@li... <mailto:jEd...@li...>
>>>             https://lists.sourceforge.net/lists/listinfo/jedit-devel
>>>
>>>
>>>         -- 
>>>         -----------------------------------------------
>>>         jEdit Developers' List
>>>         jEd...@li... <mailto:jEd...@li...>
>>>         https://lists.sourceforge.net/lists/listinfo/jedit-devel
>>>
>>
>>
>>     -- 
>>     -----------------------------------------------
>>     jEdit Developers' List
>>     jEd...@li... <mailto:jEd...@li...>
>>     https://lists.sourceforge.net/lists/listinfo/jedit-devel
>>
>
>
>
>
>

Re: [ jEdit-devel ] Removing jsr305

[Vampire <Va...@jE...>]

Hi

Where did you actually see that problem and what exactly?

I checked in Java 11 and Java 21 and in both there are only things within `javax.annotation.processing`.
In the jsr350 JAR are only things in `javax.annotation`, `javax.annotation.meta`,  and `javax.annotation.concurrent`, so there should not be a split-package problem there.

I also quickly tried in a play project and it works like a charm.
jsr305 jar to the module path, a "requires transitive ..." clause to the module info, and all compiles just fine without complaint with both, Java 11 and Java 21.

Besides that, it is imho anyway questionable whether jEdit should be made a JPMS module.
Which advantages do you see?
If we would start from scratch, it would maybe make sense.
And if we would have a clear definition of what Plugin API is and what not,
it would probably also be great to enforce this restriction by default.

So unless we really want to define a clear Plugin API and forbid plugins to use anything else by default, it would maybe make sense.

But even then, as I wrote above it should not be much of a problem to continue using the jsr305 annotations.
And it would probably even be preferable, as typically tools support these annotations,
but will not support the custom copies you made.

What do you think?

Cheers
Björn




Am 11.10.2023 21:24, schrieb Matthieu Casanova:
> Hey,
> years ago I added the google jsr305 library (annotations like Nonnull, Nullable) which is mostly a helper for IDE and documentation.
> Unfortunately that JSR was never aprooved which was not a problem until Java released the module system :
>
> Because those annotations were in javax package it caused problems when activating the module system introduced in Java 9 because javax is of course part of JRE so another library cannot provide the same package.
> So basically I created the same annotations in
>
> org.jedit.annotation package.
>
> Matthieu
>
>
>
>
>

Re: [ jEdit-devel ] jEdit 5.7.0 release?

[Vampire <Va...@jE...>]

Hey folks

Sorry, I got a bad flu after starting this thread.

> I did not update the CHANGES, but it looks like you did it yesterday? Would you like me to double check?

@Dale
No, I just fixed the formatting of the current state.
I did not add any additional entries.
So yes, would still be great if you could add the entries you think are missing
and have a look over the "What's new" docs.

> the delete at end of line issue on java 20+ on Linux issue seems blocking to me.

@Eric
I see you have committed for it, so is that sufficiently fixed now?

> I'm having a bit of trouble. First, there are 119 warnings when compiling, mostly unchecked or deprecations.

@Dale
I'm not sure what you mean.
When I do `ant compile` with deprecations and unchecked enabled, I get exactly 8 warnings.
I fixed those 8 now.
Actually, mostly by suppressing unchecked cast as the casts were appropriate as far as I could see.
But I have no idea what other 111 warnings you mean.

> Second, my "ant dist" build fails with a no class definition found error for org.apache.bsf.util.BSFEngineImpl. I can see the jar is in the right place, but it's not clear to me why it's not found. Anyone else having this problem?
> If I change the "manager" parameter in the <script> tag to "javax", the build runs to completion. If I set the "manager" to "bsf" or "auto", the build fails as I mentioned before. Weird. No one else sees this?

@Dale
Hm, very strange.
Maybe the bsf.jar on your disk is there but corrupt?
You could try deleting it and see whether it works then.
Actually, I'm not sure why I used BSF in the first place, maybe I was not aware that BSH also provides a javax.script engine.
But as it works with that, I now removed BSF from the dependencies, so it should also work for you out of the box again.

> Oh, and there are hundreds of javadoc warnings and errors.

@Dale
Don't complain, fix them. ;-)
But honestly.
I agree that they should be fixed, but probably not for 5.7.0.
There are 1,192 warnings currently and no errors when I build the JavaDoc.
Or do you want to "quickly take care"? :-)

Cheers
Björn

Re: [ jEdit-devel ] Java 21 for jEdit ?

[Dale A. <da...@da...>]

I ran the macro several ways:

java 11.0.20.1 openjdk, jEdit 5.7 25689, beanshell original, PASSED
java 11.0.20.1 jedit 5.7 25689, beanshell 2.1, PASSED
java 20.0.2 openjdk, jedit 5.7 25689, beanshell original PASSED
java 20.0.2 openjdk, jedit 5.7 25689, beanshell 2.1, PASSED

I'm not quite at the latest code for jEdit and have been dealing with
crappy internet for a couple of days and can't seem to update, but I can't
seem to get this test to fail.

StringBuilder sb = new StringBuilder();
sb.append("test");
System.out.println(sb);

I put the above into a buffer, selected the lines, then Utilities -
Beanshell - Evaluate Selection, and "test" appears in the activity.log
every time.

uname -a shows:
Linux dev-one 6.5.3-arch1-1 #1 SMP PREEMPT_DYNAMIC Wed, 13 Sep 2023
08:37:40 +0000 x86_64 GNU/Linux

On Fri, Oct 6, 2023 at 2:16 PM Robert Schwenn <Rob...@ka...>
wrote:

> Hi,
> forget my last answer. Now I have steps to reproduce - see
> https://sourceforge.net/p/jedit/bugs/4118/.
>
> @Dale:
> Could You please try these steps with "Your" Beanshell?
>
> Robert
>
>
> Am 04.10.2023 um 22:10 schrieb Matthieu Casanova:
>
> Hey,
> are you able to reproduce it today ?
> I tried with a macro
>
> sb.bsh containing
>
> StringBuilder sb = new StringBuilder();
> sb.append("test");
> System.out.println(sb.toString());
>
> I run it with Java 17.0.8.1 (Adoptium) and it works.
> I tried to recompile jEdit with that same JDK and ran jEdit and the test
> and it also worked.
> Did I miss something or maybe someone fixed the bug already?
>
> As Dale told it seems we will not be able to upgrade Beanshell because of
> their licence change so we have the choice to find another alternative that
> would be compatible with GPL (I don't know any), otherwise we might try to
> solve the problem ourselves in our version of Beanshell.
>
> --
>   Matthieu Casanova
>   cho...@gm...
>
>
> Mer 04 oct 2023, à 22:03, Dale Anson a écrit :
>
> I believe it's in the same place it was last year. It isn't hard to
> upgrade the integrated beanshell to a newer, java 17+ compatible version,
> but there is still the GPL vs Apache license issue which hasn't been worked
> out.
>
> On Wed, Oct 4, 2023 at 1:40 PM Robert Schwenn <Rob...@ka...>
> wrote:
>
>
> Hi,
>
> do You have in mind that there's a issue with integrated beanshell (
> https://sourceforge.net/p/jedit/bugs/4118/) not being compatible with
> java 17 (and presumably later)? Or is it fixed already (or a mistake)?
>
> Robert
>
>
>
> Am 02.10.2023 um 23:27 schrieb Matthieu Casanova:
>
> Hey,
> we missed java 17 and are still on java 11. Java 21 arrived and it is LTS,
> I think it would be nice that the next version of jEdit (after 5.7 release)
> would be java 21 which brings a lot of nice features especially virtual
> threads.
> Anyone against it ?
>
> Matthieu
>
>
> --
> -----------------------------------------------
> jEdit Developers' List
> jEd...@li...
> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>
>
> --
> -----------------------------------------------
> jEdit Developers' List
> jEd...@li...
> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>
>
>
> --
> Mit freundlichen Grüßen
> Robert Schwenn
> Augustusweg 10a
> 01445 Radebeul
> 0152 / 26 24 25 97
>
>

[ jEdit-devel ] Removing jsr305

[Matthieu C. <cho...@gm...>]

Hey,
years ago I added the google jsr305 library (annotations like Nonnull, Nullable) which is mostly a helper for IDE and documentation.
Unfortunately that JSR was never aprooved which was not a problem until Java released the module system :

Because those annotations were in javax package it caused problems when activating the module system introduced in Java 9 because javax is of course part of JRE so another library cannot provide the same package.
So basically I created the same annotations in 

org.jedit.annotation package.

Matthieu

[ jEdit-devel ] [jedit:bugs] #4125 Delete at the end of the line does not delete newline (java20, java21)

[Alan E. <ez...@us...>]

I deleted my previous comment. I was still running an older build. The issue seems to be fixed to me, but I will test it some more.



---

**[bugs:#4125] Delete at the end of the line does not delete newline (java20, java21)**

**Status:** open
**Group:** normal bug
**Created:** Sun Jun 04, 2023 12:51 PM UTC by Alan Ezust
**Last Updated:** Tue Oct 10, 2023 05:31 PM UTC
**Owner:** Matthieu Casanova


If I am at the end of a line and I hit delete, the newline char is not deleted anymore.
Using jedit 5.6.0, openjdk 20 or 21 on kubuntu linux 22.04.

Switching to openjdk 19 makes the problem go away.



---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[ jEdit-devel ] [jedit:bugs] #4125 Delete at the end of the line does not delete newline (java20, java21)

[Alan E. <ez...@us...>]

Testing svn revision # 25690with openjdk 21 on Linux.
Deleting newlines works if I am on a line with no printable characters on it. 00
If there are printable characters to the left of the cursor, then I still can't delete the end of the line. 


---

**[bugs:#4125] Delete at the end of the line does not delete newline (java20, java21)**

**Status:** open
**Group:** normal bug
**Created:** Sun Jun 04, 2023 12:51 PM UTC by Alan Ezust
**Last Updated:** Tue Oct 03, 2023 06:22 AM UTC
**Owner:** Matthieu Casanova


If I am at the end of a line and I hit delete, the newline char is not deleted anymore.
Using jedit 5.6.0, openjdk 20 or 21 on kubuntu linux 22.04.

Switching to openjdk 19 makes the problem go away.



---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[ jEdit-devel ] [jedit:bugs] #4118 BeanShell error: module java.base does not "opens java.lang" to unnamed module

[Matthieu C. <kp...@us...>]

Ok, maybe if we start using modules in jEdit we could fix that, however to do that we have to remove the jsr305 lib as it was never confirmed it uses packages of JRE which is forbidden


---

**[bugs:#4118] BeanShell error: module java.base does not "opens java.lang" to unnamed module**

**Status:** open
**Group:** Regressive (new to devel)
**Labels:** macro 
**Created:** Fri Apr 22, 2022 04:03 PM UTC by blurredd
**Last Updated:** Sun Oct 08, 2023 11:58 AM UTC
**Owner:** nobody


I see the following BeanShell error when running a macro that appends to a StringBuilder:

```text
Sourced file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh unknown error: Unable to make public java.lang.AbstractStringBuilder java.lang.AbstractStringBuilder.append(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @7c75222b : at Line: 2 :
 in file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh
 : sb .append ( "test" ) 

	at org.gjt.sp.jedit.bsh.Interpreter.eval(Interpreter.java:696)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:343)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:291)
	at org.gjt.sp.jedit.BeanShell.runScript(BeanShell.java:217)
	at org.gjt.sp.jedit.Macros$BeanShellHandler.runMacro(Macros.java:1108)
	at org.gjt.sp.jedit.Macros$Macro.invoke(Macros.java:530)
	at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:343)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3417)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3399)
	at org.gjt.sp.jedit.EditAction$Wrapper.actionPerformed(EditAction.java:225)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
...
```

StringBuilderTest.bsh:

```java
StringBuilder sb = new StringBuilder():
sb.append("test");
```

I'm using jEdit 5.6.0, java version 17.0.2 on Windows 10 Enterprise.




---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[ jEdit-devel ] [jedit:bugs] #4118 BeanShell error: module java.base does not "opens java.lang" to unnamed module

[Robert S. <rsc...@us...>]

Yes, with these java command line args the StringBuilderTest.bsh runs fine (in my step 5).



---

**[bugs:#4118] BeanShell error: module java.base does not "opens java.lang" to unnamed module**

**Status:** open
**Group:** Regressive (new to devel)
**Labels:** macro 
**Created:** Fri Apr 22, 2022 04:03 PM UTC by blurredd
**Last Updated:** Sat Oct 07, 2023 09:27 PM UTC
**Owner:** nobody


I see the following BeanShell error when running a macro that appends to a StringBuilder:

```text
Sourced file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh unknown error: Unable to make public java.lang.AbstractStringBuilder java.lang.AbstractStringBuilder.append(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @7c75222b : at Line: 2 :
 in file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh
 : sb .append ( "test" ) 

	at org.gjt.sp.jedit.bsh.Interpreter.eval(Interpreter.java:696)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:343)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:291)
	at org.gjt.sp.jedit.BeanShell.runScript(BeanShell.java:217)
	at org.gjt.sp.jedit.Macros$BeanShellHandler.runMacro(Macros.java:1108)
	at org.gjt.sp.jedit.Macros$Macro.invoke(Macros.java:530)
	at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:343)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3417)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3399)
	at org.gjt.sp.jedit.EditAction$Wrapper.actionPerformed(EditAction.java:225)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
...
```

StringBuilderTest.bsh:

```java
StringBuilder sb = new StringBuilder():
sb.append("test");
```

I'm using jEdit 5.6.0, java version 17.0.2 on Windows 10 Enterprise.




---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[ jEdit-devel ] [jedit:bugs] #4118 BeanShell error: module java.base does not "opens java.lang" to unnamed module

[Matthieu C. <kp...@us...>]

Hey Robert,
can you try to add --add-opens java.desktop/java.awt=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED to the java args in your command line ?
I agree even if it works it is not ideal.


---

**[bugs:#4118] BeanShell error: module java.base does not "opens java.lang" to unnamed module**

**Status:** open
**Group:** Regressive (new to devel)
**Labels:** macro 
**Created:** Fri Apr 22, 2022 04:03 PM UTC by blurredd
**Last Updated:** Fri Oct 06, 2023 08:03 PM UTC
**Owner:** nobody


I see the following BeanShell error when running a macro that appends to a StringBuilder:

```text
Sourced file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh unknown error: Unable to make public java.lang.AbstractStringBuilder java.lang.AbstractStringBuilder.append(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @7c75222b : at Line: 2 :
 in file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh
 : sb .append ( "test" ) 

	at org.gjt.sp.jedit.bsh.Interpreter.eval(Interpreter.java:696)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:343)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:291)
	at org.gjt.sp.jedit.BeanShell.runScript(BeanShell.java:217)
	at org.gjt.sp.jedit.Macros$BeanShellHandler.runMacro(Macros.java:1108)
	at org.gjt.sp.jedit.Macros$Macro.invoke(Macros.java:530)
	at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:343)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3417)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3399)
	at org.gjt.sp.jedit.EditAction$Wrapper.actionPerformed(EditAction.java:225)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
...
```

StringBuilderTest.bsh:

```java
StringBuilder sb = new StringBuilder():
sb.append("test");
```

I'm using jEdit 5.6.0, java version 17.0.2 on Windows 10 Enterprise.




---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

Re: [ jEdit-devel ] Java 21 for jEdit ?

[Robert S. <Rob...@ka...>]

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Hi,</div>
    <div class="moz-cite-prefix">forget my last answer. Now I have steps
      to reproduce - see <a class="moz-txt-link-freetext" href="https://sourceforge.net/p/jedit/bugs/4118/">https://sourceforge.net/p/jedit/bugs/4118/</a>.</div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">@Dale:</div>
    <div class="moz-cite-prefix">Could You please try these steps with
      "Your" Beanshell?</div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">Robert</div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix"><br>
    </div>
    <div class="moz-cite-prefix">Am 04.10.2023 um 22:10 schrieb Matthieu
      Casanova:<br>
    </div>
    <blockquote type="cite"
      cite="mid:f0a...@ap...">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <title></title>
      <style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
      <div style="font-family:Arial;">Hey,<br>
      </div>
      <div style="font-family:Arial;">are you able to reproduce it today
        ?<br>
      </div>
      <div style="font-family:Arial;">I tried with a macro<br>
      </div>
      <div style="font-family:Arial;"><br>
      </div>
      <div style="font-family:Arial;">sb.bsh containing<br>
      </div>
      <div style="font-family:Arial;"><br>
      </div>
      <div style="font-family:Arial;">StringBuilder sb = new
        StringBuilder();<br>
      </div>
      <div style="font-family:Arial;">sb.append("test");<br>
      </div>
      <div style="font-family:Arial;">System.out.println(sb.toString());<br>
      </div>
      <div style="font-family:Arial;"><br>
      </div>
      <div style="font-family:Arial;">I run it with Java 17.0.8.1
        (Adoptium) and it works.<br>
      </div>
      <div style="font-family:Arial;">I tried to recompile jEdit with
        that same JDK and ran jEdit and the test and it also worked.<br>
      </div>
      <div style="font-family:Arial;">Did I miss something or maybe
        someone fixed the bug already?<br>
      </div>
      <div style="font-family:Arial;"><br>
      </div>
      <div style="font-family:Arial;">As Dale told it seems we will not
        be able to upgrade Beanshell because of their licence change so
        we have the choice to find another alternative that would be
        compatible with GPL (I don't know any), otherwise we might try
        to solve the problem ourselves in our version of Beanshell.<br>
      </div>
      <div style="font-family:Arial;"><br>
      </div>
      <div id="sig19919453">
        <div class="signature">-- <br>
        </div>
        <div class="signature">  Matthieu Casanova<br>
        </div>
        <div class="signature">  <a href="mailto:cho...@gm..."
            moz-do-not-send="true" class="moz-txt-link-freetext">cho...@gm...</a><br>
        </div>
        <div class="signature"><br>
        </div>
      </div>
      <div style="font-family:Arial;"><br>
      </div>
      <div>Mer 04 oct 2023, à 22:03, Dale Anson a écrit :<br>
      </div>
      <blockquote type="cite" id="qt" style="">
        <div dir="ltr">I believe it's in the same place it was last
          year. It isn't hard to upgrade the integrated beanshell to a
          newer, java 17+ compatible version, but there is still the GPL
          vs Apache license issue which hasn't been worked out.<br>
        </div>
        <div><br>
        </div>
        <div class="qt-gmail_quote">
          <div dir="ltr" class="qt-gmail_attr">On Wed, Oct 4, 2023 at
            1:40 PM Robert Schwenn &lt;<a
              href="mailto:Rob...@ka..."
              moz-do-not-send="true" class="moz-txt-link-freetext">Rob...@ka...</a>&gt;
            wrote:<br>
          </div>
          <blockquote class="qt-gmail_quote"
style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204, 204, 204);padding-left:1ex;">
            <div><br>
            </div>
            <div>
              <div><span class="font" style="font-family:monospace;">Hi,</span><br>
              </div>
              <div><span class="font" style="font-family:monospace;"></span><br>
              </div>
              <div><span class="font" style="font-family:monospace;">do
                  You have in mind that there's a issue with integrated
                  beanshell (<a
                    href="https://sourceforge.net/p/jedit/bugs/4118/"
                    target="_blank" moz-do-not-send="true"
                    class="moz-txt-link-freetext">https://sourceforge.net/p/jedit/bugs/4118/</a>)
                  not being compatible with java 17 (and presumably
                  later)? Or is it fixed already (or a mistake)?</span><br>
              </div>
              <div><span class="font" style="font-family:monospace;"></span><br>
              </div>
              <div><span class="font" style="font-family:monospace;">Robert</span><br>
              </div>
              <div><span class="font" style="font-family:monospace;"></span><br>
              </div>
              <div><span class="font" style="font-family:monospace;"></span><br>
              </div>
              <div><span class="font" style="font-family:monospace;"></span><br>
              </div>
              <div><span class="font" style="font-family:monospace;">Am
                  02.10.2023 um 23:27 schrieb Matthieu Casanova:</span><br>
              </div>
              <blockquote type="cite">
                <div><span class="font" style="font-family:monospace;">Hey,</span><br>
                </div>
                <div><span class="font" style="font-family:monospace;">we
                    missed java 17 and are still on java 11. Java 21
                    arrived and it is LTS, I think it would be nice that
                    the next version of jEdit (after 5.7 release) would
                    be java 21 which brings a lot of nice features
                    especially virtual threads.</span><br>
                </div>
                <div><span class="font" style="font-family:monospace;">Anyone
                    against it ?</span><br>
                </div>
                <div><span class="font" style="font-family:monospace;"></span><br>
                </div>
                <div><span class="font" style="font-family:monospace;">Matthieu</span><br>
                </div>
                <div><span class="font" style="font-family:monospace;"><br>
                  </span><span class="font"
                    style="font-family:monospace;"></span></div>
              </blockquote>
              <div><span class="font" style="font-family:monospace;"></span><br>
              </div>
            </div>
            <div>-- <br>
            </div>
            <div> -----------------------------------------------<br>
            </div>
            <div> jEdit Developers' List<br>
            </div>
            <div> <a href="mailto:jEd...@li..."
                target="_blank" moz-do-not-send="true"
                class="moz-txt-link-freetext">jEd...@li...</a><br>
            </div>
            <div> <a
href="https://lists.sourceforge.net/lists/listinfo/jedit-devel"
                rel="noreferrer" target="_blank" moz-do-not-send="true"
                class="moz-txt-link-freetext">https://lists.sourceforge.net/lists/listinfo/jedit-devel</a><br>
            </div>
          </blockquote>
        </div>
        <div><br>
        </div>
        <div>-- <br>
        </div>
        <div>-----------------------------------------------<br>
        </div>
        <div>jEdit Developers' List<br>
        </div>
        <div><a href="mailto:jEd...@li..."
            moz-do-not-send="true" class="moz-txt-link-freetext">jEd...@li...</a><br>
        </div>
        <div><a
href="https://lists.sourceforge.net/lists/listinfo/jedit-devel"
            moz-do-not-send="true" class="moz-txt-link-freetext">https://lists.sourceforge.net/lists/listinfo/jedit-devel</a><br>
        </div>
        <div><br>
        </div>
      </blockquote>
      <div style="font-family:Arial;"><br>
      </div>
    </blockquote>
    <p><br>
    </p>
    <pre class="moz-signature" cols="80">-- 
Mit freundlichen Grüßen
Robert Schwenn
Augustusweg 10a
01445 Radebeul
0152 / 26 24 25 97</pre>
  </body>
</html>

[ jEdit-devel ] [jedit:bugs] #4118 BeanShell error: module java.base does not "opens java.lang" to unnamed module

[Robert S. <rsc...@us...>]

OK, let's restart with this issue: My system is:
jEdit 5.6 (virgin install and settings)
Adoptium jdk-**20**.0.2+9-jre
Windows 11 Pro 22H2

Steps to reproduce:
1. Startup jEdit
2. Run StringBuilderTest.bsh => works fine.
3. Run one of these bundled macros:
     - Editing/Mode_Switcher
     - Properties/Create_Plugin_Announcement
     - Text/Insert_Tag
     - Misc/Debug_BufferSets
5. Run StringBuilderTest.bsh => Now an error raises as described above

The error will raise with Java 17 and later, but not with Java 11 . I have no clue where the problem is. But I hope, someone can reproduce this now an will have an idea.




---

**[bugs:#4118] BeanShell error: module java.base does not "opens java.lang" to unnamed module**

**Status:** open
**Group:** Regressive (new to devel)
**Labels:** macro 
**Created:** Fri Apr 22, 2022 04:03 PM UTC by blurredd
**Last Updated:** Fri May 06, 2022 05:51 PM UTC
**Owner:** nobody


I see the following BeanShell error when running a macro that appends to a StringBuilder:

```text
Sourced file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh unknown error: Unable to make public java.lang.AbstractStringBuilder java.lang.AbstractStringBuilder.append(java.lang.String) accessible: module java.base does not "opens java.lang" to unnamed module @7c75222b : at Line: 2 :
 in file: C:\Users\User\AppData\Roaming\jEdit\macros\StringBuilderTest.bsh
 : sb .append ( "test" ) 

	at org.gjt.sp.jedit.bsh.Interpreter.eval(Interpreter.java:696)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:343)
	at org.gjt.sp.jedit.BeanShell._runScript(BeanShell.java:291)
	at org.gjt.sp.jedit.BeanShell.runScript(BeanShell.java:217)
	at org.gjt.sp.jedit.Macros$BeanShellHandler.runMacro(Macros.java:1108)
	at org.gjt.sp.jedit.Macros$Macro.invoke(Macros.java:530)
	at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:343)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3417)
	at org.gjt.sp.jedit.jEdit$3.invokeAction(jEdit.java:3399)
	at org.gjt.sp.jedit.EditAction$Wrapper.actionPerformed(EditAction.java:225)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
...
```

StringBuilderTest.bsh:

```java
StringBuilder sb = new StringBuilder():
sb.append("test");
```

I'm using jEdit 5.6.0, java version 17.0.2 on Windows 10 Enterprise.




---

Sent from sourceforge.net because jed...@li... is subscribed to https://sourceforge.net/p/jedit/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/jedit/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

Re: [ jEdit-devel ] Java 21 for jEdit ?

[Matthieu C. <cho...@gm...>]

I am on Windows,
maybe it changes something.

-- 
  Matthieu Casanova
  cho...@gm...


Jeu 05 oct 2023, à 21:30, Robert Schwenn a écrit :
> Hi,
> 
> yes, I just tried with my usual jEdit package and run into the error with Adoptium Java 17.0.8.1 and jdk-20.0.2+9. BUT, if I use a pur jedit 5.6 install without plugins and settings, the test macro runs fine with these jdk's. Obviously I hadn't double checked last year :-(
> 
> Now it seems, that a combination of actual jdk and some plugin or setting is causing the exception. I'll take a deeper look.
> 
> Robert
> 
> 
> 
> Am 04.10.2023 um 22:10 schrieb Matthieu Casanova:
>> Hey,
>> are you able to reproduce it today ?
>> I tried with a macro
>> 
>> sb.bsh containing
>> 
>> StringBuilder sb = new StringBuilder();
>> sb.append("test");
>> System.out.println(sb.toString());
>> 
>> I run it with Java 17.0.8.1 (Adoptium) and it works.
>> I tried to recompile jEdit with that same JDK and ran jEdit and the test and it also worked.
>> Did I miss something or maybe someone fixed the bug already?
>> 
>> As Dale told it seems we will not be able to upgrade Beanshell because of their licence change so we have the choice to find another alternative that would be compatible with GPL (I don't know any), otherwise we might try to solve the problem ourselves in our version of Beanshell.
>> 
>> -- 
>>   Matthieu Casanova
>>   cho...@gm...
>> 
>> 
>> Mer 04 oct 2023, à 22:03, Dale Anson a écrit :
>>> I believe it's in the same place it was last year. It isn't hard to upgrade the integrated beanshell to a newer, java 17+ compatible version, but there is still the GPL vs Apache license issue which hasn't been worked out.
>>> 
>>> On Wed, Oct 4, 2023 at 1:40 PM Robert Schwenn <Rob...@ka...> wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> do You have in mind that there's a issue with integrated beanshell (https://sourceforge.net/p/jedit/bugs/4118/) not being compatible with java 17 (and presumably later)? Or is it fixed already (or a mistake)?
>>>> 
>>>> Robert
>>>> 
>>>> 
>>>> 
>>>> Am 02.10.2023 um 23:27 schrieb Matthieu Casanova:
>>>>> Hey,
>>>>> we missed java 17 and are still on java 11. Java 21 arrived and it is LTS, I think it would be nice that the next version of jEdit (after 5.7 release) would be java 21 which brings a lot of nice features especially virtual threads.
>>>>> Anyone against it ?
>>>>> 
>>>>> Matthieu
>>>>> 
>>>> 
>>>> --
>>>> -----------------------------------------------
>>>> jEdit Developers' List
>>>> jEd...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>>> 
>>> -- 
>>> -----------------------------------------------
>>> jEdit Developers' List
>>> jEd...@li...
>>> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>>> 
>> 
> 
> 
> -- 
> Mit freundlichen Grüßen
> Robert Schwenn
> Augustusweg 10a
> 01445 Radebeul
> 0152 / 26 24 25 97
> 
> -- 
> -----------------------------------------------
> jEdit Developers' List
> jEd...@li...
> https://lists.sourceforge.net/lists/listinfo/jedit-devel
> 

Re: [ jEdit-devel ] Java 21 for jEdit ?

[Robert S. <Rob...@ka...>]

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix"><font face="monospace">Hi,</font></div>
    <div class="moz-cite-prefix"><font face="monospace"><br>
      </font></div>
    <div class="moz-cite-prefix"><font face="monospace">yes, I just
        tried with </font><font face="monospace">my usual jEdit package
      </font><font face="monospace">and run into the error with Adoptium
        Java 17.0.8.1 and jdk-20.0.2+9. BUT, if I use a pur jedit 5.6
        install without plugins and settings, the test macro runs fine
        with these jdk's. Obviously I hadn't double checked last year
        :-(</font></div>
    <div class="moz-cite-prefix"><font face="monospace"><br>
      </font></div>
    <div class="moz-cite-prefix"><font face="monospace">Now it seems,
        that a combination of actual jdk and some plugin or setting is
        causing the exception. I'll take a deeper look. <br>
      </font></div>
    <div class="moz-cite-prefix"><font face="monospace"><br>
      </font></div>
    <div class="moz-cite-prefix"><font face="monospace">Robert<br>
      </font></div>
    <div class="moz-cite-prefix"><font face="monospace"><br>
      </font></div>
    <div class="moz-cite-prefix"><font face="monospace"><br>
      </font></div>
    <div class="moz-cite-prefix"><font face="monospace"><br>
      </font></div>
    <div class="moz-cite-prefix"><font face="monospace">Am 04.10.2023 um
        22:10 schrieb Matthieu Casanova:<br>
      </font></div>
    <blockquote type="cite"
      cite="mid:f0a...@ap...">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <title></title>
      <style type="text/css"></style>
      <div><font face="monospace">Hey,<br>
        </font></div>
      <div><font face="monospace">are you able to reproduce it today ?<br>
        </font></div>
      <div><font face="monospace">I tried with a macro<br>
        </font></div>
      <div><font face="monospace"><br>
        </font></div>
      <div><font face="monospace">sb.bsh containing<br>
        </font></div>
      <div><font face="monospace"><br>
        </font></div>
      <div><font face="monospace">StringBuilder sb = new
          StringBuilder();<br>
        </font></div>
      <div><font face="monospace">sb.append("test");<br>
        </font></div>
      <div><font face="monospace">System.out.println(sb.toString());<br>
        </font></div>
      <div><font face="monospace"><br>
        </font></div>
      <div><font face="monospace">I run it with Java 17.0.8.1 (Adoptium)
          and it works.<br>
        </font></div>
      <div><font face="monospace">I tried to recompile jEdit with that
          same JDK and ran jEdit and the test and it also worked.<br>
        </font></div>
      <div><font face="monospace">Did I miss something or maybe someone
          fixed the bug already?<br>
        </font></div>
      <div><font face="monospace"><br>
        </font></div>
      <div><font face="monospace">As Dale told it seems we will not be
          able to upgrade Beanshell because of their licence change so
          we have the choice to find another alternative that would be
          compatible with GPL (I don't know any), otherwise we might try
          to solve the problem ourselves in our version of Beanshell.<br>
        </font></div>
      <div><font face="monospace"><br>
        </font></div>
      <div id="sig19919453">
        <div class="signature"><font face="monospace">-- <br>
          </font></div>
        <div class="signature"><font face="monospace">  Matthieu
            Casanova<br>
          </font></div>
        <div class="signature"><font face="monospace">  <a
              href="mailto:cho...@gm..."
              moz-do-not-send="true" class="moz-txt-link-freetext">cho...@gm...</a><br>
          </font></div>
        <div class="signature"><font face="monospace"><br>
          </font></div>
      </div>
      <div><font face="monospace"><br>
        </font></div>
      <div><font face="monospace">Mer 04 oct 2023, à 22:03, Dale Anson a
          écrit :<br>
        </font></div>
      <blockquote type="cite" id="qt" style="">
        <div dir="ltr"><font face="monospace">I believe it's in the same
            place it was last year. It isn't hard to upgrade the
            integrated beanshell to a newer, java 17+ compatible
            version, but there is still the GPL vs Apache license issue
            which hasn't been worked out.<br>
          </font></div>
        <div><font face="monospace"><br>
          </font></div>
        <div class="qt-gmail_quote">
          <div dir="ltr" class="qt-gmail_attr"><font face="monospace">On
              Wed, Oct 4, 2023 at 1:40 PM Robert Schwenn &lt;<a
                href="mailto:Rob...@ka..."
                moz-do-not-send="true" class="moz-txt-link-freetext">Rob...@ka...</a>&gt;
              wrote:<br>
            </font></div>
          <blockquote class="qt-gmail_quote"
style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204, 204, 204);padding-left:1ex;">
            <div><font face="monospace"><br>
              </font></div>
            <div>
              <div><font face="monospace"><span class="font">Hi,</span><br>
                </font></div>
              <div><font face="monospace"><span class="font"></span><br>
                </font></div>
              <div><font face="monospace"><span class="font">do You have
                    in mind that there's a issue with integrated
                    beanshell (<a
                      href="https://sourceforge.net/p/jedit/bugs/4118/"
                      target="_blank" moz-do-not-send="true"
                      class="moz-txt-link-freetext">https://sourceforge.net/p/jedit/bugs/4118/</a>)
                    not being compatible with java 17 (and presumably
                    later)? Or is it fixed already (or a mistake)?</span><br>
                </font></div>
              <div><font face="monospace"><span class="font"></span><br>
                </font></div>
              <div><font face="monospace"><span class="font">Robert</span><br>
                </font></div>
              <div><font face="monospace"><span class="font"></span><br>
                </font></div>
              <div><font face="monospace"><span class="font"></span><br>
                </font></div>
              <div><font face="monospace"><span class="font"></span><br>
                </font></div>
              <div><font face="monospace"><span class="font">Am
                    02.10.2023 um 23:27 schrieb Matthieu Casanova:</span><br>
                </font></div>
              <blockquote type="cite">
                <div><font face="monospace"><span class="font">Hey,</span><br>
                  </font></div>
                <div><font face="monospace"><span class="font">we missed
                      java 17 and are still on java 11. Java 21 arrived
                      and it is LTS, I think it would be nice that the
                      next version of jEdit (after 5.7 release) would be
                      java 21 which brings a lot of nice features
                      especially virtual threads.</span><br>
                  </font></div>
                <div><font face="monospace"><span class="font">Anyone
                      against it ?</span><br>
                  </font></div>
                <div><font face="monospace"><span class="font"></span><br>
                  </font></div>
                <div><font face="monospace"><span class="font">Matthieu</span><br>
                  </font></div>
                <div><font face="monospace"><span class="font"><br>
                    </span><span class="font"></span></font></div>
              </blockquote>
              <div><font face="monospace"><span class="font"></span><br>
                </font></div>
            </div>
            <div><font face="monospace">-- <br>
              </font></div>
            <div><font face="monospace">
                -----------------------------------------------<br>
              </font></div>
            <div><font face="monospace"> jEdit Developers' List<br>
              </font></div>
            <div> <font face="monospace"><a
                  href="mailto:jEd...@li..."
                  target="_blank" moz-do-not-send="true"
                  class="moz-txt-link-freetext">jEd...@li...</a><br>
              </font></div>
            <div> <font face="monospace"><a
href="https://lists.sourceforge.net/lists/listinfo/jedit-devel"
                  rel="noreferrer" target="_blank"
                  moz-do-not-send="true" class="moz-txt-link-freetext">https://lists.sourceforge.net/lists/listinfo/jedit-devel</a><br>
              </font></div>
          </blockquote>
        </div>
        <div><font face="monospace"><br>
          </font></div>
        <div><font face="monospace">-- <br>
          </font></div>
        <div><font face="monospace">-----------------------------------------------<br>
          </font></div>
        <div><font face="monospace">jEdit Developers' List<br>
          </font></div>
        <div><font face="monospace"><a
              href="mailto:jEd...@li..."
              moz-do-not-send="true" class="moz-txt-link-freetext">jEd...@li...</a><br>
          </font></div>
        <div><font face="monospace"><a
href="https://lists.sourceforge.net/lists/listinfo/jedit-devel"
              moz-do-not-send="true" class="moz-txt-link-freetext">https://lists.sourceforge.net/lists/listinfo/jedit-devel</a><br>
          </font></div>
        <div><font face="monospace"><br>
          </font></div>
      </blockquote>
      <div><font face="monospace"><br>
        </font></div>
    </blockquote>
    <p><font face="monospace"><br>
      </font></p>
    <pre class="moz-signature" cols="80">-- 
Mit freundlichen Grüßen
Robert Schwenn
Augustusweg 10a
01445 Radebeul
0152 / 26 24 25 97</pre>
  </body>
</html>

Re: [ jEdit-devel ] Java 21 for jEdit ?

[Dale A. <da...@da...>]

Yes, that's what I understand. There was a conversation about this some
time ago and that was the consensus at the time. The newer beanshell code
is licensed under Apache license, where the version in jEdit right now is
GPL, and GPL3 would let us include the newer beanshell code even though
it's using the Apache license. I'd be happy to update the beanshell code to
the newer version, but not for this release since it would need some pretty
good testing to make sure we don't break existing macros.

On Wed, Oct 4, 2023 at 3:05 PM Matthieu Casanova <cho...@gm...>
wrote:

> I am not sure I understand well (but I am not a licence expert).
> But today jEdit is GPL 2. And you say that adding some GPL 3 code would
> change all jEdit to GPL 3 automatically ?
> Any new code or it has to be specific ?
> Because if it is any new code I committed a few weeks ago that new class
> which comes with no dependencies to any other part of jEdit and since I am
> the only committer I suppose I can change it's licence to any licence right
> ?
>
> https://sourceforge.net/p/jedit/svn/25686/tree//jEdit/trunk/org/jedit/util/SystemManager.java
>
> Matthieu
>
> Mer 04 oct 2023, à 22:47, Dale Anson a écrit :
>
> The license issue shouldn't be hard to resolve, GPL 3 would allow Apache
> licensed code to be mixed in. We just need some new code with a GPL 3
> license committed to the project, then the rest is automatic.
>
> On Wed, Oct 4, 2023 at 2:10 PM Matthieu Casanova <kp...@fa...>
> wrote:
>
>
> Hey,
> are you able to reproduce it today ?
> I tried with a macro
>
> sb.bsh containing
>
> StringBuilder sb = new StringBuilder();
> sb.append("test");
> System.out.println(sb.toString());
>
> I run it with Java 17.0.8.1 (Adoptium) and it works.
> I tried to recompile jEdit with that same JDK and ran jEdit and the test
> and it also worked.
> Did I miss something or maybe someone fixed the bug already?
>
> As Dale told it seems we will not be able to upgrade Beanshell because of
> their licence change so we have the choice to find another alternative that
> would be compatible with GPL (I don't know any), otherwise we might try to
> solve the problem ourselves in our version of Beanshell.
>
> --
>   Matthieu Casanova
>   cho...@gm...
>
>
> Mer 04 oct 2023, à 22:03, Dale Anson a écrit :
>
> I believe it's in the same place it was last year. It isn't hard to
> upgrade the integrated beanshell to a newer, java 17+ compatible version,
> but there is still the GPL vs Apache license issue which hasn't been worked
> out.
>
> On Wed, Oct 4, 2023 at 1:40 PM Robert Schwenn <Rob...@ka...>
> wrote:
>
>
> Hi,
>
> do You have in mind that there's a issue with integrated beanshell (
> https://sourceforge.net/p/jedit/bugs/4118/) not being compatible with
> java 17 (and presumably later)? Or is it fixed already (or a mistake)?
>
> Robert
>
>
>
> Am 02.10.2023 um 23:27 schrieb Matthieu Casanova:
>
> Hey,
> we missed java 17 and are still on java 11. Java 21 arrived and it is LTS,
> I think it would be nice that the next version of jEdit (after 5.7 release)
> would be java 21 which brings a lot of nice features especially virtual
> threads.
> Anyone against it ?
>
> Matthieu
>
>
> --
> -----------------------------------------------
> jEdit Developers' List
> jEd...@li...
> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>
>
> --
> -----------------------------------------------
> jEdit Developers' List
> jEd...@li...
> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>
>
>
> --
> -----------------------------------------------
> jEdit Developers' List
> jEd...@li...
> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>
>
>

Re: [ jEdit-devel ] Java 21 for jEdit ?

[Matthieu C. <cho...@gm...>]

I am not sure I understand well (but I am not a licence expert).
But today jEdit is GPL 2. And you say that adding some GPL 3 code would change all jEdit to GPL 3 automatically ?
Any new code or it has to be specific ?
Because if it is any new code I committed a few weeks ago that new class which comes with no dependencies to any other part of jEdit and since I am the only committer I suppose I can change it's licence to any licence right ?
https://sourceforge.net/p/jedit/svn/25686/tree//jEdit/trunk/org/jedit/util/SystemManager.java

Matthieu

Mer 04 oct 2023, à 22:47, Dale Anson a écrit :
> The license issue shouldn't be hard to resolve, GPL 3 would allow Apache licensed code to be mixed in. We just need some new code with a GPL 3 license committed to the project, then the rest is automatic.
> 
> On Wed, Oct 4, 2023 at 2:10 PM Matthieu Casanova <kp...@fa...> wrote:
>> __
>> Hey,
>> are you able to reproduce it today ?
>> I tried with a macro
>> 
>> sb.bsh containing
>> 
>> StringBuilder sb = new StringBuilder();
>> sb.append("test");
>> System.out.println(sb.toString());
>> 
>> I run it with Java 17.0.8.1 (Adoptium) and it works.
>> I tried to recompile jEdit with that same JDK and ran jEdit and the test and it also worked.
>> Did I miss something or maybe someone fixed the bug already?
>> 
>> As Dale told it seems we will not be able to upgrade Beanshell because of their licence change so we have the choice to find another alternative that would be compatible with GPL (I don't know any), otherwise we might try to solve the problem ourselves in our version of Beanshell.
>> 
>> -- 
>>   Matthieu Casanova
>>   cho...@gm...
>> 
>> 
>> Mer 04 oct 2023, à 22:03, Dale Anson a écrit :
>>> I believe it's in the same place it was last year. It isn't hard to upgrade the integrated beanshell to a newer, java 17+ compatible version, but there is still the GPL vs Apache license issue which hasn't been worked out.
>>> 
>>> On Wed, Oct 4, 2023 at 1:40 PM Robert Schwenn <Rob...@ka...> wrote:
>>>> __
>>>> Hi,
>>>> 
>>>> do You have in mind that there's a issue with integrated beanshell (https://sourceforge.net/p/jedit/bugs/4118/) not being compatible with java 17 (and presumably later)? Or is it fixed already (or a mistake)?
>>>> 
>>>> Robert
>>>> 
>>>> 
>>>> 
>>>> Am 02.10.2023 um 23:27 schrieb Matthieu Casanova:
>>>>> Hey,
>>>>> we missed java 17 and are still on java 11. Java 21 arrived and it is LTS, I think it would be nice that the next version of jEdit (after 5.7 release) would be java 21 which brings a lot of nice features especially virtual threads.
>>>>> Anyone against it ?
>>>>> 
>>>>> Matthieu
>>>>> 
>>>> 
>>>> --
>>>> -----------------------------------------------
>>>> jEdit Developers' List
>>>> jEd...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>>> 
>>> -- 
>>> -----------------------------------------------
>>> jEdit Developers' List
>>> jEd...@li...
>>> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>>> 
>> 
> 
> -- 
> -----------------------------------------------
> jEdit Developers' List
> jEd...@li...
> https://lists.sourceforge.net/lists/listinfo/jedit-devel
>