As a follow-up to #3288, Mike Pope has done this:
git.543cfbfa changes the national labels in the places you mention. Unfortunately, the routine that has changed is called in other places, so other things may now break. We shall see.
These "other places" should be tested to make sure that no
Places tested so far:
- Foreign Affairs Advisor (OK)
- Military Advisor (no change, but I found a workaround by using
{{tag:people|%nation%}} instead)
- Navy Advisor (same as for military advisor)
- Unit names (no change, still says something like "Spanish Free Colonist" instead of your chosen people name. I'm afraid this is tricky to fix tho without annoying grammar issues, esp. in translations)
NOT tested:
- Indian settlement window (most hated nation)
- Indian Advisor (most hated nation)
- Various turn messages
- ??? (other windows I forgot ...)
I suggest to take a look at #3303. I am not sure, but maybe a lot of these problems go away if most strings use an explicit {{tag:people / {{tag:country to avoid ambiguity and confusion.