#3281 Game Freezes in End Turn

[Bruno Acosta]

My last save as Portuguese always crash after a certain turn when I press end turn, then the message "The server cannot do it" pops up and the game freezes, although the music keeps playing. I tried to backup from earlier savefiles, but the freez still happens after 2 or 3 turns, I tried to redo or change any orders or decision, yet it still happens.

net.sf.freecol.common.model.Player clientError
WARNING: Illegal move for: unit:37781 type: MOVE_NO_MOVES from: tile:14208 to: tile:14205
Sun Aug 21 02:47:50 BRT 2022
Thread: 776

net.sf.freecol.common.model.Player clientError
WARNING: Illegal move for: unit:37781 type: MOVE_NO_MOVES from: tile:14208 to: tile:14323
Sun Aug 21 02:47:50 BRT 2022
Thread: 777

net.sf.freecol.common.model.Player clientError
WARNING: Illegal move for: unit:37781 type: MOVE_NO_MOVES from: tile:14208 to: tile:14086
Sun Aug 21 02:47:50 BRT 2022
Thread: 778

Save file, Freecol.log and screenshot of the freeze screen below

[Bruno Acosta]

Screenshot of Freeze

[Stian Grenborgen]

I'm able to play for five turns using your savegame without any problem. Can you save the game before every time you press end turn? ...and send me a savegame that always produces the problem?

Please also execute all goto orders before ending the turn using "Orders" > "Execute Go To Orders" (or pressing the hotkey "o") ... as you might have the same problem as described in https://sourceforge.net/p/freecol/bugs/3277/

[g504]

I'm seeing the same. The logfile grows rapidly (more than 1KB per second). The UI is unresponsive and the only thing to do is go to the task manager and end the Java thread. Windows 10 Pro, AMD Ryzen 5 3600, RAM 32GB.

net.sf.freecol.common.model.Player clientError
    WARNING: Illegal move for: unit:9657 type: MOVE_NO_MOVES from: tile:2419 to: tile:2459
    Sat Aug 27 12:29:27 BST 2022
    Thread: 194154
net.sf.freecol.common.model.Player clientError
    WARNING: Illegal move for: unit:9657 type: MOVE_NO_MOVES from: tile:2419 to: tile:2420
    Sat Aug 27 12:29:27 BST 2022
    Thread: 194155
net.sf.freecol.common.model.Player clientError
    WARNING: Illegal move for: unit:9657 type: MOVE_NO_MOVES from: tile:2419 to: tile:2420
    Sat Aug 27 12:29:27 BST 2022
    Thread: 194156
net.sf.freecol.common.model.Player clientError
    WARNING: Illegal move for: unit:9657 type: MOVE_NO_MOVES from: tile:2419 to: tile:2459
    Sat Aug 27 12:29:27 BST 2022
    Thread: 194157

[g504]

Sorry, cannot seem to attach the last save.

[Stian Grenborgen]

@g504: Are you using version 0.13.0 or the latest development build? This might be the same issue as bug 3277 that has already been fixed.

[g504]

It is 0.13.0 (3ece192). Thank you for the link to the development release, I will give that a try.

[g504]

I have installed git-20220828.

Within moments of restarting the current game, the 'cannot do that' panel appeared. The log file is 4,399,660 lines long (199,913,805 bytes) according to Notepad++.

I have reloaded and tried again with this precise sequence of steps:

1. start game
2. select continue existing game
3. press 'o' to do moves
4. press 'enter' to complete my turn
5. AI plays other players
6. my turn starts and before I can do anything it moves my in transit items and fails with the looping log error

Over the period of one minute the log adds 8,532 entries and the tread count increases by 2,073. The AMD 6/12 cpu is running at 45% and as before the only solution was to end the treads foreably.

net.sf.freecol.client.gui.panel.InfoPanel update
    INFO: InfoPanel updated UNIT -> UNIT with unit [unit:11258 english artillery (2/3) /1]
    Mon Aug 29 11:00:19 BST 2022
    Thread: 22
net.sf.freecol.common.model.Player clientError
    WARNING: Illegal move for: unit:11258 type: MOVE_NO_MOVES from: tile:2702 to: tile:2743
    Mon Aug 29 11:00:19 BST 2022
    Thread: 1032388
net.sf.freecol.common.model.Player clientError
    WARNING: Illegal move for: unit:11258 type: MOVE_NO_MOVES from: tile:2702 to: tile:2743
    Mon Aug 29 11:00:19 BST 2022
    Thread: 1032389
net.sf.freecol.common.model.Player clientError
    WARNING: Illegal move for: unit:11258 type: MOVE_NO_MOVES from: tile:2702 to: tile:2743
    Mon Aug 29 11:00:19 BST 2022
    Thread: 1032390

[Stian Grenborgen]

I have found and fixed another problem with execution of goto-orders that only happened for trade routes.

In some cases you will have to end the turn twice (one for executing the goto-orders and the other for actually ending the turn). I might look into this problem later, but right now I'm busy with improving the AI.

Please try the latest development build.

[Stian Grenborgen]

@g504: ...and thanks for the savegame -- I did get it :-)

[g504]

@stiangre Thank you.