Menu

#3217 Colony gains production bonus incorrectly

Fixed_1.0.0
closed-fixed
nobody
None
5
2023-01-03
2020-11-30
No

Before end of turn: the colony has produced 51 bells since its foundation and is currently producing 17 bells per turn. SoL is 45%.

Next turn: the colony has produced 68 bells and now SoL is 54%/46%, thus gained +1 production bonus.

How could have it gained >50% SoL before producing 100 bells?
Maybe it's not a bug and I don't understand SoL calculation, I'm not sure. If so, please explain how is SoL calculated.

3 Attachments

Discussion

  • Calebrw

    Calebrw - 2021-01-28

    I see 51+17=68.

     
    • forgesourcer

      forgesourcer - 2021-01-28

      Yes, but is 68 bells enough to gain +1 bonus?

       
      • Calebrw

        Calebrw - 2021-01-29

        It's based on the percentage of Rebels to Loyalists.

         
        • forgesourcer

          forgesourcer - 2021-01-30

          OK, how is this percentage calculated?

          As I understand it, it takes 200 bells to get one rebel. So, a colony with only one colonist must produce 200 bells to gain 100% SoL and 100 bells to gain 50% SoL. Is it wrong?

           
          • Mike Pope

            Mike Pope - 2021-04-20

            Look at Colony.calculateSoLPercentage if you want the exact details. If you do so you will notice a line where bonuses to SoL are applied. I suspect you have founding fathers that are weighing in here.

            A separate question is whether they should, but that is a What-Would-Col1-Do issue. Just be aware that the SoL calculation has been argued over a lot already, and that there is not a lot of interest in changing it yet again unless you can show us a Col1 game which does something else.

             
  • forgesourcer

    forgesourcer - 2021-02-07

    Here's another example.
    The colony has produced 84 bells total and has 62% SoL. Is it correct?
    Meanwhile, the popup says there are 2 turns remaining to reach 50%. Something is definitely wrong here.

     

    Last edit: forgesourcer 2021-02-07
    • Mike Pope

      Mike Pope - 2022-09-05

      Finally getting back to this. The SoL percentage is correct, you may be missing that Bolivar is present, which boosts SoL by 20%.

      What is broken is the number of turns to reach next bonus change calculations. They are also not accounting for Bolivar.

       
  • Mike Pope

    Mike Pope - 2021-04-20
    • status: open --> open-needs-info
     
  • Mike Pope

    Mike Pope - 2022-09-05
    • status: open-needs-info --> pending-fixed
    • Group: Current --> Fixed_trunk
     
  • Mike Pope

    Mike Pope - 2022-09-05

    Should be fixed in git.6aaa722.

     
  • Stian Grenborgen

    • status: pending-fixed --> closed-fixed
    • Group: Fixed_trunk --> Fixed_1.0.0
     

Log in to post a comment.

MongoDB Logo MongoDB