Menu
▾
▴
#3103 no warning for task-less ship in Europe
Steps to reproduce:
- have a ship moved to Europe
- load-unload stuff so the ship will have a "0" text near it. (Offtopic: what does this "0" mean in Europe, anyway? Implementation leak?)
- try to end turn or try to use "W"/"Next Unit" shortcut
Expected: end of turn warning, possible to find this ship with "Next Unit" action
Actually: this unit is not shown in "Next Unit" action, no warning is being made if you do "End Turn".
Loading/unloading a ship removes its moves except in some special cases. The "0" indicates that it has no moves left. However in Europe you can always "set sail" for new world destinations, but this is (at least internally) quite a different action from normal movement. The warning is only triggered for units that have moves left.
This has probably not come up before as I suspect most people finish messing around with a ship and either deliberately leave it in port (in which case they do not want the warning) or send it back to the new world (in which case the warning does not apply).
What then should we do here? It would be easy enough to cause load/unload in Europe not to remove moves (which are irrelevant anyway in Europe), or to always list ships in Europe on the warning list. However this may annoy people who are deliberately leaving the ship in Europe (I do this regularly when a new colonist is imminent, or I expect to earn enough cash next turn to be able to buy some critical goods/unit). I suspect this is yet another case where we will not be able to please everyone
(and no, I do not want to add a client option for an issue as small is this:-).
Comments welcome from interested parties.
Well I would personally prefer to always have a warning, and explicitely ignore it if you know your ship is waiting for someone. Anyway, you may know user habitats better, so I think it's up for you to decide, I don't mind any solution.
On another topic, from what you tell, the "movements" really have no impact in Europe. So that would indeed mean a minor bug and a leaky abstraction. People might think that these 0/- mean something, yet they don't.
Anyway, I'm in favor of either closing the issue or solving it. Half-open issue feels like a tech debt.
vasya, open-needs-info status does not mean this issue is "half-open" .
It's used when an issue is open but needs additonal information to progress further.
In this specific bug mike wants input from users before deciding what to do.
I often also have ships waiting in europe.
How about showing any ships in europe at end of turn except those on sentry status ?
Agreed. The 0 is misleading. Fixed in git.09dc355.
That should already work (ditto Fortified). Any unit state other than the standard "Active" will fail the filter used to select units for the EndTurnDialog.
Veryified that units sentried in Europe do not appear in the end turn dialog, and if active, they do. This is working as designed. Closing.