Colopedia property strings contain duplicated wrapper HTML tags

Colonize the New World.

Brought to you by: burschik, mpope, pruano, stiangre

#2995 Colopedia property strings contain duplicated wrapper HTML tags

Milestone: Unspecified

Status: closed-wont-fix

Owner: nobody

Labels: I18n (4)

Priority: 5

Updated: 2017-03-09

Created: 2016-10-22

Creator: Calebrw

Private: No

Pointed out by user Siebrand on the TranslateWiki site, a group of property strings contain a duplicated tag wrapper.

colopedia.concepts.education.description
colopedia.concepts.efficiency.description
colopedia.concepts.fortification.description
colopedia.concepts.independence.description
colopedia.concepts.interventionForce.description
colopedia.concepts.ref.description
colopedia.concepts.taxes.description

HTML should either be removed completely and updated like colopedia.foundingFather.description or the tag extracted out the code level.

Discussion

Mike Pope - 2016-10-22

I do not see why this is a problem. What is broken? And why do you want to break the ones with links in them (unlike colopedia.foundingFather.description).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Calebrw - 2016-10-22
  
  After looking at it further, rather than just reporting the bug the way I first did, I agree that HTML should not be stripped, but rather hard-coded in so that Java knows to treat the entire string as HTML, including formatting, links, etc.
  
  This obviously very minor duplication, but it's one less thing for a translater to worry about.
  
  Last edit: Calebrw 2016-10-22
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Mike Pope - 2016-11-01
    
    so that Java knows to treat the entire string as HTML
    
    Again, why is this necessary? AFAICT Java is treating it as HTML.
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    - Calebrw - 2016-11-01
      
      Maybe the issue isn't really an issue. I'm not committed to any specific method (no pun intended) here. I will take a look next time I get a chance.
      
      If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

wintertime - 2017-02-26

I just saw that colopedia.concepts.fortification.description contains only the opening tags, but is missing the closing </p></html> tags.
It seems that JEditorPane is pretty resilient, as ingame its looking alright.
I also tried removing the <html> and </html> tags and it seems they are superfluous, as this does not change the appearance ingame and the code gives a "text/html" parameter already. Should I just remove them or is it safer to add them to the string in code? The fortification message needs editing anyway and it would be better to do both at same time.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mike Pope - 2017-02-26

Should I just remove them or is it safer to add them to the string in code? The fortification message needs editing anyway and it would be better to do both at same time.

It may be redundant, but I think it is better to retain the html tags as they make it very clear what is intended. By all means fix the fortification and any other message that are badly formed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

wintertime - 2017-02-26

Ok, I only added the missing tags now.
I guess, the <html> and </html> tags stay in the message file then and its closed as wont fix?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Mike Pope - 2017-02-26
  
  Agreed. Done.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mike Pope - 2017-02-26

status: open --> closed-wont-fix

Group: Current --> Unspecified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

wintertime - 2017-03-09

I found in FreeColMessages_br that there is text outside the html tags in colopedia.concepts.fortification.description . There was a mistakely translated html tag inside the zh_hant translation, which got corrected recently in git.92907c3d .
I only saw it scrolling through that commit, there might be more.
I'm not so sure if its that good of an idea to have the tags inside the messages, but without the html tags outside other tags like <p> and <em> might be even more likely to be mistranslated?

PS: @Caleb, can you tell the translators about the mistake in br translation and maybe write a bit on their wiki so they know the tags need to be kept untranslated?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.