#2830 Not all battle outcomes reported

[Evgeny]

I have encountered this bug a while ago. This one was a confirmation.

I have 3 cannons to capture a city. I get reports (battle outcomes) if my cannon wins.
But, I am not getting one if it looses. A cannon just gets silently demoted to a damaged cannon.

I will attach an auto-save game shortly (first want to replicate this again from the auto-save the turn before).

[Evgeny]

Yes. I was able to reproduce the behavior from the auto-save.
Square 22:17, pick a cannon, attack New Amsterdam.

[Mike Pope]

No, can not reproduce here. The attack fails, but I get an information panel describing the artillery demotion. However there is an obvious difference between the above log file and what I see here. Yours contains a crash:

java.util.logging.LogManager$RootLogger log
WARNING: Uncaught exception from thread: Thread[AWT-EventQueue-0,6,main]
Sat Mar 28 05:33:40 PDT 2015
Thread: 20
Stack trace:
java.lang.NoSuchMethodError: net.sf.freecol.common.resources.ResourceManager.getSimpleZippedAnimation(Ljava/lang/String;D)Lnet/sf/freecol/common/io/sza/SimpleZippedAnimation;
at net.sf.freecol.client.gui.animation.UnitAttackAnimation.getAnimation(UnitAttackAnimation.java:81)
...

This is pretty bogus. It is complaining that there is no member of ResourceManager with the signature "SimpleZippedAnimation getSimpleZippedAnimation(String)", when called from UnitAttackAnimation at line 81. In my copy of the source, this routine is not called from that location, the two argument version is. This looks like a build problem. When you last built freecol, did you remember to run "ant clean" first? If not, try that, then rebuild, and try to reproduce the problem again.

[Calebrw]

Okay, I just tried this in [656bf6], and could not reproduce either. I got a message stating the demotion. You call it the information panel. I just know it as the one with the guy on top.

"Mixed forest (north of New Amsterdam): Spanish artillery has been damaged by Dutch Scout (Free Colonist)! Further damage will destroy the Damaged piece of Artillery."

Log attached.

Actions: Open said git build (ant clean used), open game attached above, attack. Save. Close.

[Calebrw]

I didn't have any different results with 0.11.3 (stock release version).

I even tried a few more attacks before I finally broke through and captured New Amsterdam. That is reflected in the attached log file.

[Evgeny]

/ This looks like a build problem. When you last built freecol, did you remember to run "ant clean" first?

No. I will rebuild and report later.

[Calebrw]

Have you ever seen battle reports in the Turn Report? I try to avoid any battle at all costs (no pun intended), so I don't often see any battle reports, but I seem to recall them showing up occasionally there. That isn't to indicate that both options are mutually exclusive.

[Evgeny]

I will try to check the Turn Report panel. Though, it does not matter.
If positive outcomes are reported, negative should be reported, too. Without "silent demotions".

[Calebrw]

Agree 100%. I definitely agree there are bugs within the combat system (I think that the developers would agree there), but I've never been focused on testing or looking for them.

You're right, silent demotions are horrible and should always be reported.

[Mike Pope]

Six months on, no sign of a reproducible case, and a strong suspicion of build problems: time to close as out of date.