With git.650636a, I've encountered a vaguely inconvenient situation. It seems the REF has gotten stuck with 60 artillery and a stack of ships sitting around in Europe. It makes it difficult to defeat the REF when it can't get its units out of Europe.
It did manage to arrive initially and attack. It also arrived back with a small number of ships with units aboard later on which I was able to sink. However, since then it hasn't. One interesting point is that at one point, I retook a colony which had a stack of ships parked in it. I wonder if that might have been what got things confused.
Attached save game and log file.
There is a lot of thrashing going on with the AI ATM, especially the EuropeanAIPlayer from which the REFAIPlayer is derived. Breakage is alas to be expected, but thanks for the warning that there has been collateral damage.
The AI and especially the transport code is now significantly improved. If this is still reproducible there is a severe bug, however I have not succeeded in finding it.
It's still reproducible with the savegame in the bug report using git.4c8761c.
I wonder if it's related to the fact that in this specific game, the REF has only artillery units and ships left - nothing else. The log (attached) would seem to indicate that the REF is transporting said artillery from Europe to Europe for some reason.
I let the game run for five turns or so but the REF never delivered more of its artillery to the new world nor did it declare defeat.
As an additional data point, I just replayed the same game from just before declaring independence. This time, the REF didn't leave any units behind in Europe (or fail to disembark them, whichever actually happened). As a result, starting over from the declaration of independence, I was able to defeat the REF. It may be that whatever bug led to the REF units being in Europe in the first place was been corrected and the save game above is just glitched.
I think so.
Well, no, I fear you were playing while the AI was broken. However, the fact that the broken state is not self-correcting is disappointing. So the bug remains valid, and worth fixing.
I saw some updates related to the REF in git.4f239f2 so I tried it out with this save game. This time, the REF picked up the units in Europe and brought them to the new world and was soundly defeated. (That tends to happen when you spam your colonies with artillery.) It seems that adjustment unbroke this particular game.
Thanks for the confirmation. I did add a comment that that commit should have fixed things, but it seems to have failed. Closing.
Even more changes have gone in that may yet again change the behaviour here. I am really hopeful this time that the REF navy may now be less prone to just going home. There are also several combat modifier fixes.