Menu

#472 fix(cli): align log action column

closed
nobody
None
2026-08-28
2026-08-26
Anonymous
No

Originally created by: slegarraga

Closes [#428]

What

  • Derives the log action-column width from ActionType instead of hardcoding 13 characters.
  • Keeps targets aligned for the 15-character enum values (network_request, package_install) while automatically accommodating future members.
  • Leaves the JSONL contract untouched.

Tests

  • Adds a human-output regression test with network_request and git_op rows, asserting both target columns start at the same offset.

Verification

  • .venv/bin/pytest tests/unit -k cli_log — 8 passed, 1 skipped.
  • .venv/bin/ruff check src/doberman/cli/main.py tests/unit/test_cli_log_jsonl.py
  • .venv/bin/ruff format --check src/doberman/cli/main.py tests/unit/test_cli_log_jsonl.py

Related

Tickets: #428
Tickets: #459
Tickets: #463
Tickets: #465
Tickets: #493
Tickets: #494
Tickets: #495
Tickets: #509

Discussion

  • Anonymous

    Anonymous - 2026-08-26

    Originally posted by: slegarraga

    Additional validation: full local unit suite — 2,867 passed, 12 skipped.

     
  • Anonymous

    Anonymous - 2026-08-27

    Ticket changed by: fu351

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2026-08-27

    Ticket changed by: fu351

    • status: closed --> open
     
  • Anonymous

    Anonymous - 2026-08-28

    Ticket changed by: fu351

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2026-08-28

    Originally posted by: fu351

    Merged, thanks @slegarraga! Deriving the width from the enum the way render.py does for verdicts means the next long action type cannot shift the column either, and asserting that both targets start at the same offset is a better test than comparing a padded string.

     

Log in to post a comment.