Menu

#463 fix(cli): align hook dry-run with installed command

closed
nobody
None
2026-08-28
2026-08-26
Anonymous
No

Originally created by: slegarraga

Closes [#429]

What

  • Uses DASHBOARD_COMMAND in both install and uninstall dry-run previews so the displayed SessionStart command is the same one the installer writes.
  • Adds regression coverage asserting the preview contains doberman session-summary and no longer mentions doberman dashboard.

Verification

  • .venv/bin/pytest tests/unit/test_install_hooks.py — 44 passed.
  • .venv/bin/pytest tests/unit -k 'install_hooks or cli_help or cli_encode_safe' — 117 passed, 1 skipped.
  • .venv/bin/ruff check src tests — passed.
  • .venv/bin/ruff format --check src/doberman/cli/main.py tests/unit/test_install_hooks.py — passed.

Related

Tickets: #429
Tickets: #471
Tickets: #493
Tickets: #495
Tickets: #497
Tickets: #509

Discussion

  • Anonymous

    Anonymous - 2026-08-27

    Ticket changed by: fu351

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2026-08-27

    Ticket changed by: fu351

    • status: closed --> open
     
  • Anonymous

    Anonymous - 2026-08-28

    Ticket changed by: fu351

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2026-08-28

    Originally posted by: fu351

    Merged, thanks @slegarraga! Importing DASHBOARD_COMMAND into the preview means the dry run can never drift from what the installer writes again, which was the whole bug. One thing on the landing. Your branch and [#472] both added an import at the same line in cli/main.py, so I merged main into a copy of your branch in our repo (land/pr463, [#493]) and resolved that one line. Your commits and authorship are untouched.

     

    Related

    Tickets: #472
    Tickets: #493

  • Anonymous

    Anonymous - 2026-08-28

    Originally posted by: slegarraga

    Thank you for handling the landing conflict so carefully and for preserving the commits and authorship. The landing branch was a thoughtful way to resolve the shared import anchor without disturbing either change. I really appreciate the detailed review — glad the shared constant now keeps preview and installation behavior aligned by construction!

     

Log in to post a comment.