Menu

#465 fix(cli): align log action column

closed
nobody
duplicate (3)
2026-08-27
2026-08-26
Anonymous
No

Originally created by: slegarraga

Closes [#428]

What

  • Derives the doberman log action-column width from ActionType instead of hardcoding 13 characters.
  • Adds regression coverage proving git_op and network_request keep their target/reason columns aligned.

Verification

  • .venv/bin/pytest tests/unit/test_cli_log_jsonl.py -q
  • .venv/bin/pytest tests/unit -k cli_log -q
  • .venv/bin/pytest tests/unit -k 'cli' -q — 227 passed, 1 skipped.
  • .venv/bin/ruff check src tests
  • .venv/bin/ruff format --check src/doberman/cli/main.py tests/unit/test_cli_log_jsonl.py
  • git diff --check

Related

Tickets: #428

Discussion

  • Anonymous

    Anonymous - 2026-08-27

    Originally posted by: fu351

    Closing this one for [#472], @slegarraga, your later version of the same fix. [#472] keeps _ACTION_WIDTH next to the log command's other constants with a comment, and its test reproduces the real misalignment with network_request and git_op rows, so that's the version I want to merge. This branch has also drifted into a conflict with main, so nothing to do here. Review coming on [#472].

     

    Related

    Tickets: #472

  • Anonymous

    Anonymous - 2026-08-27

    Ticket changed by: fu351

    • status: open --> closed
     

Log in to post a comment.