dcplusplus-devel — Developer's list

Re: [dcplusplus-devel] Hardcoded DC++

[Jacek S. <arn...@gm...>]

Applied, thanks.

/J

Steven Sheehy wrote:
> Hello,
> 
> Submitted a patch to change the away message and a few log messages to
> use APPNAME instead of hardcoding DC++. By the way, if you're going to
> make dcpp into a library, an easier way to specify the APPNAME should
> probably be found. If I want to change the APPNAME string to
> "LinuxDC++", then I have to recompile the core. This is fine now, but
> probably not for a library.
> 
> -Steven

Re: [dcplusplus-devel] patch: links to Launchpad bugs in the changelog

[Jacek S. <arn...@gm...>]

I changed it to something less verbose...

poy wrote:
> changed the gen_changelog script to recognize [Bugzilla bug XXX] and
> [Launchpad bug XXX] instead of previous [bug XXX] (and changed that in
> the changelog itself, too).
> 
> poy
> 

[dcplusplus-devel] patch: links to Launchpad bugs in the changelog

[poy <po...@12...>]

changed the gen_changelog script to recognize [Bugzilla bug XXX] and 
[Launchpad bug XXX] instead of previous [bug XXX] (and changed that in the 
changelog itself, too).

poy 

[dcplusplus-devel] Hardcoded DC++

[Steven S. <ste...@gm...>]

Hello,

Submitted a patch to change the away message and a few log messages to use 
APPNAME instead of hardcoding DC++. By the way, if you're going to make dcpp 
into a library, an easier way to specify the APPNAME should probably be found. 
If I want to change the APPNAME string to "LinuxDC++", then I have to recompile 
the core. This is fine now, but probably not for a library.

-Steven

Re: [dcplusplus-devel] Compile Warnings

[Jacek S. <arn...@gm...>]

It should be size_t, not unsigned int...probably at least, but smartwin needs some love in this area
- windows often uses int and there needs to be a clear policy as to how to handle that, so I'd leave
that warning for now to remind us of this issue...

/J

Michael Jones wrote:
> Please ignore the older patch i sent for this, since some files have been updated since then, and i think in the previous patch i maybe screwed up a little bit :P
> In the rar there are 3 patches.
> 
> 1st sorts "unused variable border" which is in 3 files.  It does this by deleting the "border" variable which never gets used.
> 
> 2nd sorts a few of the signed / unsigned comparisons.  It does 3, all of them in for loops where the  for (int i . .      has just been changed to an unsigned int i
> 
> 3rd fixes two enumerate value 'none' not in switch, by adding it to the switch.
> _________________________________________________________________
> Who's friends with who and co-starred in what?
> http://www.searchgamesbox.com/celebrityseparation.shtml
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel

[dcplusplus-devel] (DC++X == dc++ for OSX)

[itinerants <iti...@ho...>]

I've finally managed to get this up there.

I have NOT managed to test that downloading works, since my internet
connection *down* is currently more unstable than an unstable thing on
unstable pills.

Source Code...
    http://sourceforge.net/projects/dcppx/
Double-clickable (universal) can be found at...
    http://applestore.no-ip.org

I don't know if this list is appropriate for discussions on this software -
the powers that be can decide.
I don't know if a mailing list is worth creating - you decide.

Comments, bugs, questions, nukes whatever can go to...
    dc...@li...

When I have an internet connection, I can sometimes be found as...
    [REG]DC++OnOSX
On...
    dchub://applestore.no-ip.org:1111

Enjoy

[dcplusplus-devel] Compile Warnings

[Michael J. <mrm...@ho...>]

Please ignore the older patch i sent for this, since some files have been updated since then, and i think in the previous patch i maybe screwed up a little bit :P
In the rar there are 3 patches.

1st sorts "unused variable border" which is in 3 files.  It does this by deleting the "border" variable which never gets used.

2nd sorts a few of the signed / unsigned comparisons.  It does 3, all of them in for loops where the  for (int i . .      has just been changed to an unsigned int i

3rd fixes two enumerate value 'none' not in switch, by adding it to the switch.
_________________________________________________________________
Who's friends with who and co-starred in what?
http://www.searchgamesbox.com/celebrityseparation.shtml

[dcplusplus-devel] requesting icons for DC++ menus

[poy <po...@12...>]

menus in DC++ now have a space on their left side, which allows an icon to 
be put there. so if any of you wants to draw some icons for commands like 
"get file list", "download", "move up/down", and so on, please do so and 
submit them here. :)

note about the format being used: icons, actually bitmaps, have to be 16x16 
bmp files that use RGB(255, 0, 255) (full red, no green, full blue) as their 
background color; that color will render as transparent in DC++.

poy 

Re: [dcplusplus-devel] Macosx version of DCplusplus

[Matt P. <404...@gm...>]

On 2/10/08, itinerants <iti...@ho...> wrote:
> The SourceForge project for "DC++X" has been applied for.
> Once (if) it's been approved (3-4 days), the source will be posted there.
> Once that's happened I'll post the URL to this list.
> Email address for thoughts/feedback/comments is currently dc...@li...

Why wait? Just post a tarball/zip on RapidShare or MegaUpload if you
don't currently have any hosting.

Re: [dcplusplus-devel] Macosx version of DCplusplus

[itinerants <iti...@ho...>]

On 7/2/08 5:04 pm, "Jacek Sieka" <arn...@gm...> wrote:

>> It's based on the "client" portion of dc++, with a Carbon Native GUI.
>> I've been busy moving house recently, so all that's available is a universal
>> build based on .699
>> If you're happy to run something for which the source code is not available
>> (but will be very shortly) it can be found at...
>>     http://applestore.no-ip.org
> 
> Consider this email a formal request for source code of the exact release on
> the page (as per the
> dc++ license).
> 
> I thought we'd been through this already.

The SourceForge project for "DC++X" has been applied for.
Once (if) it's been approved (3-4 days), the source will be posted there.
Once that's happened I'll post the URL to this list.
Email address for thoughts/feedback/comments is currently dc...@li...




> 
> /Jacek
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel
> 

Re: [dcplusplus-devel] patch: icons (and more) in the main menu

[poy <po...@12...>]

> Let's hope this is wine compatible =)
you tell me... ^^

> On a more serious note; I wonder what this does to the blind - from what I 
> gather there are actually
> blind people using dc++ and they were more than happy with the new menus 
> since they're better for
> their screen readers...let's hope this patch doesn't interfere...
this still uses standard Windows menus, and adds the text just as in usual 
menus:
info.dwTypeData = const_cast< LPTSTR >( text.c_str() );
on line 802 of WidgetMenuExtended.cpp; only difference is that the menus are 
custom drawn. hopefully that won't be a problem for these programs...

> Also, at some point, for consistency, all right-click menus should 
> probably be moved to this fancy
> stuff as well (commit directly if you feel like doing this...)
i've thought about this, yep. :)

> Would the transparency settings for bitmaps be better off in the seed?
yes, the MenuColorInfo info can now be set through the Seed. also, popup 
menus appended to a WidgetMenuExtended will now use the same default color 
settings as their parent.

> Does it take its default menu colors from the system that it'll blend in?
good question. fortunately, yes, it does (in the MenuItemData and 
MenuColorInfo constructors). :)

> To fix:
> smartwin/source/widgets/../../include/smartwin/widgets/WidgetMenuExtended.h: 
> In constructor
> 'SmartWin::WidgetMenuExtended::WidgetMenuExtended(SmartWin::Widget*)':
> smartwin/source/widgets/../../include/smartwin/widgets/WidgetMenuExtended.h:501: 
> warning:
> 'SmartWin::WidgetMenuExtended::drawSidebar' will be initialized after
> smartwin/source/widgets/../../include/smartwin/widgets/WidgetMenuExtended.h:498: 
> warning:
> 'SmartWin::FontPtr SmartWin::WidgetMenuExtended::itsTitleFont'
> smartwin/source/widgets/WidgetMenuExtended.cpp:872: warning:   when 
> initialized here
fixed. i don't understand why the warning, though; could initializing a 
class member before another be a problem, just because they were declared in 
the reversed order?

poy 

Re: [dcplusplus-devel] patch again

[Matt P. <404...@gm...>]

I wasn't saying we should use dcpp.net, and I wasn't talking about
making things compatible retroactively.  I meant instead of changing
the links whenever addresses change from here on out, we just point
them all to a redirect script on dcplusplus.sourceforge.net.  That
way, if we stop using Launchpad a year from now, people using 0.705
can still find the forum, faq, etc.

(I'd be willing to write the script as I know a little PHP, but I'm
probably not the best choice among people on this list)

On a (slightly) related note, now that the hublists are using Coral,
why not use it for version.xml as well?

On 2/7/08, Eugen <pi...@de...> wrote:
> dcplusplus.sf.net is still up. dcpp.net is dead, and because of that, a
> script cannot be added there.
>
> Matt Pearson wrote:
> > Since these things tend to change a decent amount, maybe it would be a
> > good idea to have a simple redirect script on dcplusplus.sf.net that
> > bounces people to the correct location?  I mean, I don't see
> > sourceforge going away completely, but the others could, and it would
> > be nice for older versions (even the latest stable) to not just start
> > getting 404 errors when trying to open these things up.
> >
> > -Pseudo
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > dcplusplus-devel mailing list
> > dcp...@li...
> > https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel
> >
> >
>
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel
>

Re: [dcplusplus-devel] patch: icons (and more) in the main menu

[Jacek S. <arn...@gm...>]

Let's hope this is wine compatible =)

On a more serious note; I wonder what this does to the blind - from what I gather there are actually
blind people using dc++ and they were more than happy with the new menus since they're better for
their screen readers...let's hope this patch doesn't interfere...

Also, at some point, for consistency, all right-click menus should probably be moved to this fancy
stuff as well (commit directly if you feel like doing this...)

Would the transparency settings for bitmaps be better off in the seed?

Does it take its default menu colors from the system that it'll blend in?

To fix:
smartwin/source/widgets/../../include/smartwin/widgets/WidgetMenuExtended.h: In constructor
'SmartWin::WidgetMenuExtended::WidgetMenuExtended(SmartWin::Widget*)':
smartwin/source/widgets/../../include/smartwin/widgets/WidgetMenuExtended.h:501: warning:
'SmartWin::WidgetMenuExtended::drawSidebar' will be initialized after
smartwin/source/widgets/../../include/smartwin/widgets/WidgetMenuExtended.h:498: warning:
'SmartWin::FontPtr SmartWin::WidgetMenuExtended::itsTitleFont'
smartwin/source/widgets/WidgetMenuExtended.cpp:872: warning:   when initialized here

/J

poy wrote:
> this (big) patch adds icons in the main menu of DC++. "and more": the
> menu has a nice style with borders, shadows, etc. :)
> 
> i used WidgetMenuExtended, which i had to "port" from "vanilla SmartWin"
> to "DC++'s SmartWin", which means i did *a lot* of changes everywhere in
> the class (simplify template args, use seeds, change the way messages
> are dispatched and caught, and many other small fixes to make it compile
> and run fine...).
> the file is huge so there may still be fixes left to be done, but
> overall it's now consistent with the rest of the SmartWin classes used
> in DC++. i pasted most fixes from WidgetMenu; there is, however, one
> important difference between WidgetMenu and WidgetMenuExtended: while
> the former doesn't require any parent, the latter must have one in order
> to catch custom draw messages (and that parent is used for some more
> stuff during painting, too).
> 
> unlike usual command bars that use image lists, WidgetMenuExtended
> requires single bitmaps for each command, so i sliced toolbar.bmp into
> 16pixels parts. all these parts are in the folder res/menu.
> 
> WidgetMenuExtended allows for more than the bitmap to be changed (text
> color, bg color, etc can be changed too), but we only change the bitmap
> in the DC++ main menu so i overloaded the WidgetMenuExtended::appendItem
> function to accept bitmaps directly.
> 
> added files:
> smartwin/source/widgets/WidgetMenuExtended.cpp
> the folder res/menu which contains 16 bitmaps, all included in the rar
> file.
> 
> deleted:
> res/toolbar.bmp
> 
> attached is a screenshot of the result. all previous icons that were in
> the WTL version of DC++ have been added, but there are still some
> commands that are icon-less; new icons are welcome. ;)
> (icons, actually bitmaps, have to be 16x16 bmp files that use RGB(255,
> 0, 255) (full red, no green, full blue) as their background color; that
> color will render as transparent in DC++.)
> 
> poy
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel

Re: [dcplusplus-devel] Disable Auto follow redirects

[Jacek S. <arn...@gm...>]

Hm,

I'm not sure what the best way would be...I keep autofollow off and I guess the main reason for
having it on by default was because nmdc did it that way, but that's not a reason any longer...

Maybe a more prominent forward button that would only become active when there's actually a forward
to follow, along with a no-reconnect policy when a forward is received to keep dc++ from spamming
hubs with attempts that will fail anyway?

/J

Eugen wrote:
> I don't think this is a solution to the bug in question .
> Redirects are meant to be followed. DC++ is user client not operator
> client.
> Most users have no idea what redirect is and they don't care.
> If by default you disable the follow redirects, then the whole redirect
> system may crash.
> Users won't try to find out what's happening. They would be reconnecting
> over and over to all the hubs they were redirected from.
> I don;t think the normal user cares what hub it's in, he/she just want
> to download, so banned users or kicked or whatever have to go somewhere.
> The consequences of this action could be disastrous on long term
> 

Re: [dcplusplus-devel] patch: Filter already shared files in search

[Jacek S. <arn...@gm...>]

Hi,

Sorry for taking a while...I'd like to see this option too, but optional...so could you please add a
boolean setting for it?

Regards
/Jacek

dcp...@sm... wrote:
> Hi,
> 
> I created a patch which will filter files from the search results, if they are
> already in your own share (with same TTH).
> It works well for me and I think others might like it, too.
> 
> Bye,
> Smir

Re: [dcplusplus-devel] Macosx version of DCplusplus

[itinerants <iti...@ho...>]

On 7/2/08 5:04 pm, "Jacek Sieka" <arn...@gm...> wrote:

>> It's based on the "client" portion of dc++, with a Carbon Native GUI.
>> I've been busy moving house recently, so all that's available is a universal
>> build based on .699
>> If you're happy to run something for which the source code is not available
>> (but will be very shortly) it can be found at...
>>     http://applestore.no-ip.org
> 
> Consider this email a formal request for source code of the exact release on
> the page (as per the
> dc++ license).
> 
> I thought we'd been through this already.

We have.
It will appear.
I've been/am moving house - getting hot water and some electricity has been
my priority over the last few weeks.
Where would you like me to put it?



> 
> /Jacek
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel
> 

Re: [dcplusplus-devel] Macosx version of DCplusplus

[Jacek S. <arn...@gm...>]

> It's based on the "client" portion of dc++, with a Carbon Native GUI.
> I've been busy moving house recently, so all that's available is a universal
> build based on .699
> If you're happy to run something for which the source code is not available
> (but will be very shortly) it can be found at...
>     http://applestore.no-ip.org

Consider this email a formal request for source code of the exact release on the page (as per the
dc++ license).

I thought we'd been through this already.

/Jacek

Re: [dcplusplus-devel] patch again

[Eugen <pi...@de...>]

dcplusplus.sf.net is still up. dcpp.net is dead, and because of that, a 
script cannot be added there.

Matt Pearson wrote:
> Since these things tend to change a decent amount, maybe it would be a
> good idea to have a simple redirect script on dcplusplus.sf.net that
> bounces people to the correct location?  I mean, I don't see
> sourceforge going away completely, but the others could, and it would
> be nice for older versions (even the latest stable) to not just start
> getting 404 errors when trying to open these things up.
>
> -Pseudo
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel
>
>   

Re: [dcplusplus-devel] patch again

[Matt P. <404...@gm...>]

Since these things tend to change a decent amount, maybe it would be a
good idea to have a simple redirect script on dcplusplus.sf.net that
bounces people to the correct location?  I mean, I don't see
sourceforge going away completely, but the others could, and it would
be nice for older versions (even the latest stable) to not just start
getting 404 errors when trying to open these things up.

-Pseudo

[dcplusplus-devel] patch: handle the DI flag in QUI

[poy <po...@12...>]

this implements a little todo that was left in AdcHub.cpp where QUI messages 
are handled. when the QUI message contains the DI flag, the user will now be 
disconnected if it's in no other hub.
that doesn't conflict with the AUTO_KICK setting ("Automatically disconnect 
users who leave the hub") because that setting leaves a 1 minute delay 
between the moment the disconnection is detected and when the upload is 
actually stopped. here, we leave no dealy and no setting; if the hub 
included the DI flag, then we obey it.
note that the ADC spec mentions "transfers" and not only "uploads", so 
downloads are disconnected too.

untested, but it's small change and it should work...

poy 

Re: [dcplusplus-devel] Patch

[Eugen <pi...@de...>]

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=windows-1252"
 http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Thanks for explanations. I figured out what was the problem.<br>
<br>
Todd Pederzani wrote:
<blockquote
 cite="mid:9ca...@ma..."
 type="cite">On Feb 6, 2008 11:52 AM, Eugen &lt;<a
 moz-do-not-send="true" href="mailto:pi...@de...">pi...@de...</a>&gt;
wrote:<br>
  <div class="gmail_quote">
  <blockquote class="gmail_quote"
 style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
    <div bgcolor="#ffffff" text="#000000">Probably because i modified
the about years on the beggining and the
diff had to include all lines between that and the other modification ?</div>
  </blockquote>
  <div><br>
It included them in the patch because they had changed, otherwise it
would just have collapsed them, just as it did in MainWindow.cpp<br>
 </div>
  <blockquote class="gmail_quote"
 style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
    <div bgcolor="#ffffff" text="#000000">Why everybody is telling me
about a text editor? what does this have to
do with patch ? I made tortoise svn create patch which made the file i
attached. No file editor was used.</div>
  </blockquote>
  <div><br>
The patch deletes all of AboutDlg.cpp and replaces it with new text.  I
can't tell which changes you made, which makes it hard for me to review
the patch (although there's no particular reason why I need to).  In
comparison, see the attached diff, which I created by the command line
diff tool.  I set it to create a minimal patch and ignore whitespace.<br>
  <br>
And it's far from "everybody", it's just me, and Matt Pearson decided
to chime in as well.<br>
  <br>
  </div>
  <blockquote class="gmail_quote"
 style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
    <div bgcolor="#ffffff" text="#000000">Why should line endings
increase the size ? If there are 100 lines
thats 100 bytes to 100x100 bytes that is less than 1 % size.</div>
  </blockquote>
  <div><br>
If you change the line endings, or convert spaces to tabs (or vice
versa), or remove whitespace, that counts as a change, and the diff
includes it (and the whole line on which the change took place).  Based
on the patch, the original file had only 0x0a as line endings, and your
editor converted it to 0x0d 0x0a.  <br>
 </div>
  <blockquote class="gmail_quote"
 style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
    <div bgcolor="#ffffff" text="#000000">If a 10 kb patch instead of a
2kb one is a problem then hell, what else
do i have to say<br>
Has any of you either bothered to open the attached file and see whats
there?<br>
If you dont like the patch say so ... i wont bother again.</div>
  </blockquote>
  <div><br>
  </div>
  </div>
Whoah, don't overreact.  Look at your patch and see if you can keep
track of what is is doing to AboutDlg.cpp, and then look at the one
I've included.  Mine is much easier to read and understand.  When I was
regularly submitting patches, I always kept a clean version, and a
working version, and I used a batch file to create a minimal unified
diff that ignored whitespace.  It was a little awkward at first, but I
got into a rhythm with it.<br>
  <br clear="all">
  <br>
-- <br>
Todd Pederzani<br>
  <a moz-do-not-send="true" href="mailto:tod...@gm...">tod...@gm...</a>
  <pre wrap="">
<hr size="4" width="90%">
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
<a class="moz-txt-link-freetext" href="http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/">http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/</a></pre>
  <pre wrap="">
<hr size="4" width="90%">
_______________________________________________
dcplusplus-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:dcp...@li...">dcp...@li...</a>
<a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel">https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel</a>
  </pre>
</blockquote>
<br>
<br>
</body>
</html>

[dcplusplus-devel] patch again

[Eugen <pi...@de...>]

Sorry for my stupidness. Thanks to Mike i solved the thing :)

Re: [dcplusplus-devel] Patch

[Eugen <pi...@de...>]

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=windows-1252"
 http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Probably because i modified the about years on the beggining and the
diff had to include all lines between that and the other modification ?<br>
The modification is just a few lines...<br>
Why everybody is telling me about a text editor? what does this have to
do with patch ? I made tortoise svn create patch which made the file i
attached. No file editor was used. <br>
Why should line endings increase the size ? If there are 100 lines
thats 100 bytes to 100x100 bytes that is less than 1 % size.<br>
If a 10 kb patch instead of a 2kb one is a problem then hell, what else
do i have to say<br>
Has any of you either bothered to open the attached file and see whats
there?<br>
If you dont like the patch say so ... i wont bother again.<br>
<br>
Matt Pearson wrote:
<blockquote
 cite="mid:706...@ma..."
 type="cite">
  <pre wrap="">On 2/5/08, Eugen <a class="moz-txt-link-rfc2396E" href="mailto:pi...@de...">&lt;pi...@de...&gt;</a> wrote:
  </pre>
  <blockquote type="cite">
    <pre wrap=""> Hmm no idea. I just used tortoise svn to "create patch" after modifying the
things. There is no such option. I dont think its that big, just 10 kb
 Thats a problem ?
    </pre>
  </blockquote>
  <pre wrap=""><!---->
It wouldn't be a problem if it actually contained 10k worth of
changes, instead of a bunch of the exact same stuff, just with (what
I'm assuming is) the line endings changed.  There's only 2k at most of
real changes.  Whatever text editor you used must have messed with
line endings or space/tab stuff.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
<a class="moz-txt-link-freetext" href="http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/">http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/</a>
_______________________________________________
dcplusplus-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:dcp...@li...">dcp...@li...</a>
<a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel">https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel</a>

  </pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">-- 
 [ ЀÆH-§quad ]   ']['][-][€  F‡Ø§']['  ØÕ[¥]Ã]\[‡Ã]\[  ']['€Ã[¥]  ‡]\[  ÐÇ</pre>
</body>
</html>

[dcplusplus-devel] patch: icons (and more) in the main menu

[poy <po...@12...>]

this (big) patch adds icons in the main menu of DC++. "and more": the menu 
has a nice style with borders, shadows, etc. :)

i used WidgetMenuExtended, which i had to "port" from "vanilla SmartWin" to 
"DC++'s SmartWin", which means i did *a lot* of changes everywhere in the 
class (simplify template args, use seeds, change the way messages are 
dispatched and caught, and many other small fixes to make it compile and run 
fine...).
the file is huge so there may still be fixes left to be done, but overall 
it's now consistent with the rest of the SmartWin classes used in DC++. i 
pasted most fixes from WidgetMenu; there is, however, one important 
difference between WidgetMenu and WidgetMenuExtended: while the former 
doesn't require any parent, the latter must have one in order to catch 
custom draw messages (and that parent is used for some more stuff during 
painting, too).

unlike usual command bars that use image lists, WidgetMenuExtended requires 
single bitmaps for each command, so i sliced toolbar.bmp into 16pixels 
parts. all these parts are in the folder res/menu.

WidgetMenuExtended allows for more than the bitmap to be changed (text 
color, bg color, etc can be changed too), but we only change the bitmap in 
the DC++ main menu so i overloaded the WidgetMenuExtended::appendItem 
function to accept bitmaps directly.

added files:
smartwin/source/widgets/WidgetMenuExtended.cpp
the folder res/menu which contains 16 bitmaps, all included in the rar file.

deleted:
res/toolbar.bmp

attached is a screenshot of the result. all previous icons that were in the 
WTL version of DC++ have been added, but there are still some commands that 
are icon-less; new icons are welcome. ;)
(icons, actually bitmaps, have to be 16x16 bmp files that use RGB(255, 0, 
255) (full red, no green, full blue) as their background color; that color 
will render as transparent in DC++.)

poy 

Re: [dcplusplus-devel] Patch

[Matt P. <404...@gm...>]

On 2/5/08, Eugen <pi...@de...> wrote:
>
>  Hmm no idea. I just used tortoise svn to "create patch" after modifying the
> things. There is no such option. I dont think its that big, just 10 kb
>  Thats a problem ?

It wouldn't be a problem if it actually contained 10k worth of
changes, instead of a bunch of the exact same stuff, just with (what
I'm assuming is) the line endings changed.  There's only 2k at most of
real changes.  Whatever text editor you used must have messed with
line endings or space/tab stuff.