dcplusplus-devel — Developer's list

Re: [dcplusplus-devel] Some more translations again

[Michael J. <mrm...@ho...>]

Just a few more queries to finish off most off win32 (excluding the stuff w=
hich may need Keyboard Accelerators)=20

The F_ macro doesn't work in win32.  Somethings in HubFrame.cpp and WinUtil=
.cpp could do with it. e.g.=20
	speak(ADD_STATUS_LINE, STRING(CONNECTING_TO) + client->getHubUrl() + "..."=
);
	LogManager::getInstance()->message(STRING(MAGNET_DLG_TITLE) + ": " + Text:=
:fromT(aUrl));

Should something like this be added to stdafx.h ?

#define F_(String) boost::format(gettext(String))
or
#define F_(String) boost::format(dgettext(PACKAGE, String))

and if so, inside or outside the ifdef unicode thingy ?


I really have no idea of what to do to the two functions which do this
	if (ResourceManager::getInstance()->isRTL())


The Toolbar stuff in MainWindow.cpp, e.g.
	toolbar->appendItem(IDC_RECONNECT, image++, TSTRING(MENU_RECONNECT));

i assume this is for the Tooltips.  But the tooltips don't display accelera=
tors or shortcut keys, so should it keep them ?=20
(not all of them use the right stringdef for the accelerators & shortcuts k=
eys to be displayed, so if keeping, should these be changed to the ones whi=
ch have them ?)


Also is the AWAY string in caps for a reason ? =20
The two places which use it are MainWindow.cpp:294
	statusSizes[STATUS_AWAY] =3D status->getTextSize(TSTRING(AWAY)).x + 12;

and MainWindow.cpp:550
	setStatus(STATUS_AWAY, Util::getAway() ? TSTRING(AWAY) : _T(""));

thanks
MikeJJ
_________________________________________________________________
Get Hotmail on your mobile, text MSN to 63463!
http://mobile.uk.msn.com/pc/mail.aspx=

Re: [dcplusplus-devel] LinuxDC++: Compile fix for GCC 4.3

[Jacek S. <arn...@gm...>]

memory is already included by stdinc.h which should be included first by every .cpp file, so this
shouldn't be needed...

/J

Steven Sheehy wrote:
> See http://www.cyrius.com/journal/2007/05/10#gcc-4.3-include
> 
> 

Re: [dcplusplus-devel] Some more translations again

[Jacek S. <arn...@gm...>]

All three good and committed.

/J

Michael Jones wrote:
> There are 3 patches in this rar.

Re: [dcplusplus-devel] Search Spy crash: debug info

[Michael J. <mrm...@ho...>]

> removing everything in SpyFrame::eachSecond still kept the crash, so it's=
 not a threading issue=20
=20
That fixed it here.  Well in debug build anyway. (Didn't try release build)
Narrowed it down to just this line
 perSecond[cur] =3D 0;
=20
With that commented out, it ran fine for over 2 hours (then i closed it) :)
=20
Wouldn't it just be simplier to have a int for total search results, increm=
ented in handleSpeaker, and a int for total time (in seconds), incremented =
in eachSecond, and just divide by the two ?=20
_________________________________________________________________
Telly addicts unite!
http://www.searchgamesbox.com/tvtown.shtml=

[dcplusplus-devel] Search Spy crash: debug info

[poy <po...@12...>]

here is the debug info i've got from the Search Spy crash for quite a while; 
couldn't (and still can't) find out how to fix it.

important part is #2, where message = 275 = 0x113 = WM_TIMER. the crash 
hence happens because of the timer function called once a second.
removing everything in SpyFrame::eachSecond still kept the crash, so it's 
not a threading issue (and anyway, timer messages are in the same GUI 
thread, right?).

what i don't get is why no crash happens in HubFrame, which uses these timer 
functions the same way.

poy 

Re: [dcplusplus-devel] Some more translations again

[Jacek S. <arn...@gm...>]

> I failed at getting this to work / output the right info, so left as it
> originally was :(
I'll have a look later on then...but I'm suspecting the tstring...maybe if that function returned a
normal string it would be easier...

> On the brightside i did get the 'Normal \ At Least \ At Most' selection
> in SearchFrame to be used again. :)
> These are the relevant lines from the patch
Nice - I never use the modes so I wouldn't know =)

> Found another error though which i couldn't figure out . . . . the
> 'Re-add Source' option in Download Queue displays the contents of the
> 'Remove Source' option.
I'll have a look as well...

If you have something like TSTRING(BLAH) + Text::toT(Util::toString(xxx)), do TF_("xxx %1%") % xxx,
not % Text::toT(Util::toString(xxx))) to avoid a few unneeded function calls...I edited the relevant
parts of the patch, but please check if I missed any...

/J

Re: [dcplusplus-devel] Some more translations again

[Jacek S. <arn...@gm...>]

Michael Jones wrote:
>> > And for STRINGS(BLAH) should the T_ macro be used, or a different one ?
>> STRINGS?
> Sorry my bad, STRING(BLAH), looking though most end up getting converted
> via Text::toT anyway so i've used the T_ macro for them.
> Some don't though mainly in HubFrame.cpp, e.g.
>   speak(ADD_STATUS_LINE, STRING(REDIRECT_ALREADY_CONNECTED));
STRING simply becomes _(BLAH) (the same goes for the others - no T before, no T now...)
Although as you say, if they end up being converted anyway, you might as well use T_...


>> > Also what macro should be used in the dcpp area ?
>> same as win32
> Okay, just that most in dcpp use STRING, only 7 in ADLSearch.h and 1 in
> Util.cpp use either TSTRING or CTSTRING
See above...

> e.g.
>  tstring SourceTypeToDisplayString(SourceType t) {
>   switch(t) {
>   default:
>   case OnlyFile:  return TSTRING(FILENAME);
>   case OnlyDirectory: return TSTRING(DIRECTORY);
>   case FullPath:  return TSTRING(ADLS_FULL_PATH);
>   }
>  }
>  
> So for them wouldn't it be better to use STRING (for now), and let the
> win32 area deal with converting them to a tstring ?
> Since they are getting converted to a "DisplayString" i would have
> thought that's win32's job.
I don't have a strong opinion in either direction...

> As for this from Util.cpp
>   _sntprintf(buf, 128, _T("%s %s"), buf, CTSTRING(B));
>  
> i've changed it to this on my working copy
>   _sntprintf(buf, 128, _T("%s %s"), buf, Text::toT(STRING(B)).c_str());
F_("%1% b") % buf ?

> If that's acceptable, and same as moving the ones in ADLSearch that'll
> leave no TSTRING and CTSTRING in the dcpp area. :)
fine by me..

/J

Re: [dcplusplus-devel] Some more translations again

[Michael J. <mrm...@ho...>]

> > And for STRINGS(BLAH) should the T_ macro be used, or a different one ?=
> STRINGS?Sorry my bad, STRING(BLAH), looking though most end up getting co=
nverted via Text::toT anyway so i've used the T_ macro for them.
Some don't though mainly in HubFrame.cpp, e.g.
  speak(ADD_STATUS_LINE, STRING(REDIRECT_ALREADY_CONNECTED));
=20
> > Also what macro should be used in the dcpp area ?> same as win32
Okay, just that most in dcpp use STRING, only 7 in ADLSearch.h and 1 in Uti=
l.cpp use either TSTRING or CTSTRING
e.g.
 tstring SourceTypeToDisplayString(SourceType t) {  switch(t) {  default:  =
case OnlyFile:  return TSTRING(FILENAME);  case OnlyDirectory: return TSTRI=
NG(DIRECTORY);  case FullPath:  return TSTRING(ADLS_FULL_PATH);  } }
=20
So for them wouldn't it be better to use STRING (for now), and let the win3=
2 area deal with converting them to a tstring ?
Since they are getting converted to a "DisplayString" i would have thought =
that's win32's job.=20
=20
As for this from Util.cpp
  _sntprintf(buf, 128, _T("%s %s"), buf, CTSTRING(B));
=20
i've changed it to this on my working copy
  _sntprintf(buf, 128, _T("%s %s"), buf, Text::toT(STRING(B)).c_str());
=20
If that's acceptable, and same as moving the ones in ADLSearch that'll leav=
e no TSTRING and CTSTRING in the dcpp area. :)
=20
thanks
MikeJJ
_________________________________________________________________
Get Hotmail on your mobile, text MSN to 63463!
http://mobile.uk.msn.com/pc/mail.aspx=

Re: [dcplusplus-devel] Some more translations again

[Jacek S. <arn...@gm...>]

> And for STRINGS(BLAH) should the T_ macro be used, or a different one ?
STRINGS?

> Also what macro should be used in the dcpp area ?
same as win32

> SearchFrame.cpp:1056
> For the search window's title bar which is better ?
> 	setText(T_("Search") + _T(" - ") + T_("Ready to search..."));
> 	setText(T_("Search - Ready to search..."));
Second option

> Also wasn't sure if the Registry Entries (e.g. for Magnet stuff) in WinUtil.cpp should be translatable or not ?  Or just some of them. 
> ( Especially regarding MAGNET_HANDLER_ROOT which is "DC++" )
Those that are STRING's should be translated and the others no?

> This was used in PublicHubFrame, before the cache was introduced.  Since nothing uses it now, can it be removed, or it want to stay ? 
> 
> #ifdef PORT_ME
> double WinUtil::toBytes(TCHAR* aSize) {
> blah
Let it be...

> 
> Also do the "new"s in SettingsFrame need a corresponding "delete"? Because i couldn't see the pages getting deleted anywhere.
Hm, I think smartwin deletes those, but now that you say it, I'm not so sure...I'll check later on...

> There is also a "new" in Util formatTime for non win32 stuff, but i couldn't see any delete for that either.
AutoArray takes care of that...

> And last thing, there seems to be a issue with SpyFrame. Open Spyframe and just put dc++ in the background for a few minutes and it crashes most the time.  If it doesn't after about 5 mins, clicking the Settings button makes it crash.  Never get an exceptioninfo or a call stack when ran in debug build though.  But at least it is reproducible. :)
Yeah, I've heard about that...tell poy =)

/J

Re: [dcplusplus-devel] Some more translations again

[Michael J. <mrm...@ho...>]

> I removed some parts of the patch were there were still strings in the fo=
rm TSTRING(BLAH) + xxx
> which should become TF_("Blah %1%") % xxx so that the parameter can be mo=
ved...
Sorted them now.

> By my count, there are now approximately 290 strings left (more or less 1=
45 in each of win32 and
> dcpp =3D) and about the same number already done which means that we're a=
t 50% !
nice, going well then. :)

>> How should CTSTRING(BLAH) end up ?
>CT_ (which is a new macro: "#define CT_(String) T_(String).c_str()")
i didn't realise that this was so new it needed putting in stdafx.h =3D)
And for STRINGS(BLAH) should the T_ macro be used, or a different one ?

Also what macro should be used in the dcpp area ?

Have a few queries for the ones I working on now (still win32):


SearchFrame.cpp:1056
For the search window's title bar which is better ?
	setText(T_("Search") + _T(" - ") + T_("Ready to search..."));
	setText(T_("Search - Ready to search..."));


Also wasn't sure if the Registry Entries (e.g. for Magnet stuff) in WinUtil=
.cpp should be translatable or not ?  Or just some of them.=20
( Especially regarding MAGNET_HANDLER_ROOT which is "DC++" )


This was used in PublicHubFrame, before the cache was introduced.  Since no=
thing uses it now, can it be removed, or it want to stay ?=20

#ifdef PORT_ME
double WinUtil::toBytes(TCHAR* aSize) {
blah


Also do the "new"s in SettingsFrame need a corresponding "delete"? Because =
i couldn't see the pages getting deleted anywhere.
There is also a "new" in Util formatTime for non win32 stuff, but i couldn'=
t see any delete for that either.


And last thing, there seems to be a issue with SpyFrame. Open Spyframe and =
just put dc++ in the background for a few minutes and it crashes most the t=
ime.  If it doesn't after about 5 mins, clicking the Settings button makes =
it crash.  Never get an exceptioninfo or a call stack when ran in debug bui=
ld though.  But at least it is reproducible. :)

thanks=20
MikeJJ
_________________________________________________________________
Free games, great prizes - get gaming at Gamesbox.=20
http://www.searchgamesbox.com=

Re: [dcplusplus-devel] Some more translations again

[Jacek S. <arn...@gm...>]

> Right, this patch is like the last one, but gets rid of all calls to tformat, and as of which i have removed it from Text.h. I also changed my nick in a couple of places on this one.
Good.

> QueueFrame.cpp
> The reason i have left the if == 1 in here, and used TF_ for the plural part is because off the numbers of arguments after it. Which causes some Boost exceptions to be thrown.  E.g. in the top one, 0 of the arguments are used, but the>1 part uses 2 arguments.
Looks good to me...

> 
> TransferView.cpp
> Heh, these were a nightmare to get working. :(
As long as they work =)

> I also deleted this, because nothing was using it:
>  void TransferView::on(UploadManagerListener::Tick, const UploadList& ul) throw() {
> -	AutoArray buf(TSTRING(UPLOADED_BYTES).size() + 64);
good.

I removed some parts of the patch were there were still strings in the form TSTRING(BLAH) + xxx
which should become TF_("Blah %1%") % xxx so that the parameter can be moved...

By my count, there are now approximately 290 strings left (more or less 145 in each of win32 and
dcpp =) and about the same number already done which means that we're at 50% !

/J

Re: [dcplusplus-devel] Some more translations again

[Michael J. <mrm...@ho...>]

> All plurals should be translated to TFN_("%1% user online", "%1% users on=
line", n) % n...also, all
> other parametrized strings should be translated to TF_("parameter %1% %2%=
") % value1 % value2...
> See boost format for more detailed formatting information (and check the =
mailing list archives for
> this list). This means that all calls to tformat should go away as well..=
.I'll wait with the patch
> until you get this in order.
Right, this patch is like the last one, but gets rid of all calls to tforma=
t, and as of which i have removed it from Text.h. I also changed my nick in=
 a couple of places on this one.

> yes, you need to use the macros based on boost:format. take a look at
> DownloadsFrame.cpp on lines 114 and 116. also i'm not sure about the TFN_
> macro but it seems it's made to handle plurals automatically...
Thanks them examples helped :)

Just want to checking them though, as i not entirely certain of them.

QueueFrame.cpp
-				TCHAR buf[64];
 				if(online> 0) {
 					if(getSources().size() =3D=3D 1) {
-						display->columns[COLUMN_STATUS] =3D TSTRING(WAITING_USER_ONLINE);
+						display->columns[COLUMN_STATUS] =3D T_("Waiting (User online)");
 					} else {
-						_sntprintf(buf, 64, CTSTRING(WAITING_USERS_ONLINE), online, getSourc=
es().size());
-						display->columns[COLUMN_STATUS] =3D buf;
+						display->columns[COLUMN_STATUS] =3D str(TF_("Waiting (%1% of %2% use=
rs online)") % online % getSources().size());
 					}
 				} else {
 					if(getSources().size() =3D=3D 0) {
-						display->columns[COLUMN_STATUS] =3D TSTRING(NO_USERS_TO_DOWNLOAD_FRO=
M);
+						display->columns[COLUMN_STATUS] =3D T_("No users to download from");
 					} else if(getSources().size() =3D=3D 1) {
-						display->columns[COLUMN_STATUS] =3D TSTRING(USER_OFFLINE);
-					} else if(getSources().size() =3D=3D 2) {
-						display->columns[COLUMN_STATUS] =3D TSTRING(BOTH_USERS_OFFLINE);
-					} else if(getSources().size() =3D=3D 3) {
-						display->columns[COLUMN_STATUS] =3D TSTRING(ALL_3_USERS_OFFLINE);
-					} else if(getSources().size() =3D=3D 4) {
-						display->columns[COLUMN_STATUS] =3D TSTRING(ALL_4_USERS_OFFLINE);
+						display->columns[COLUMN_STATUS] =3D T_("User offline");
 					} else {
-						_sntprintf(buf, 64, CTSTRING(ALL_USERS_OFFLINE), getSources().size()=
);
-						display->columns[COLUMN_STATUS] =3D buf;
+						display->columns[COLUMN_STATUS] =3D str(TF_("All %1% users offline")=
 % getSources().size());
 					}

The reason i have left the if =3D=3D 1 in here, and used TF_ for the plural=
 part is because off the numbers of arguments after it. Which causes some B=
oost exceptions to be thrown.  E.g. in the top one, 0 of the arguments are =
used, but the>1 part uses 2 arguments.

TransferView.cpp
-		statusString +=3D Text::tformat(TSTRING(DOWNLOADED_BYTES), pos.c_str(), =
percent, elapsed.c_str());
+		statusString +=3D str(TF_("Downloaded %1% (%|2$.1f|%%) in %3%") % pos % =
percent % elapsed);

-		statusString +=3D Text::tformat(TSTRING(UPLOADED_BYTES), pos.c_str(), pe=
rcent, elapsed.c_str());
+		statusString +=3D str(TF_("Uploaded %1% (%|2$.1f|%%) in %3%") % pos % pe=
rcent % elapsed);
Heh, these were a nightmare to get working. :(

I also deleted this, because nothing was using it:
 void TransferView::on(UploadManagerListener::Tick, const UploadList& ul) t=
hrow() {
-	AutoArray buf(TSTRING(UPLOADED_BYTES).size() + 64);


Directorylistingframe.cpp
-	setStatus(STATUS_STATUS, Text::tformat(TSTRING(MATCHED_FILES), matched));
+	setStatus(STATUS_STATUS, str(TFN_("Matched %1% file", "Matched %1% files"=
, matched) % matched));

Searchframe.cpp
-		tstring msg =3D Text::tformat(TSTRING(SEARCHING_WAIT), waitFor);
+		tstring msg =3D str(TFN_("Searching too soon, next search in %1% second"=
, "Searching too soon, next search in %1% seconds", waitFor) % waitFor);
=20
thanks
MikeJJ
_________________________________________________________________
Who's friends with who and co-starred in what?
http://www.searchgamesbox.com/celebrityseparation.shtml=

Re: [dcplusplus-devel] Some more translations again

[poy <po...@12...>]

> In Search frame, for the "Type" drop down, i left the  _T("TTH") as i 
> didn't think this needs translation, but all the others in that drop down 
> use the T_ type.
> Did this want changing to T_, or is it fine as is ?
it's an acronym for an English expression, so better leave it translatable, 
you never know...

> because i thought that the "else if" for sizes 3 and 4 could be removed, 
> as it will get the same output for that amount of sources, on the "fall 
> through" thingy.
maybe some languages have special expressions for "all 3" or "all 4", the 
same as in English "all 2" would be changed to "both"?

> Also wasn't sure if the whole _sntprintf / buffer part was needed for the 
> last bit, or if a T_("All %d users offline") could be used instead, like 
> in T_("Matched %d files")
yes, you need to use the macros based on boost:format. take a look at 
DownloadsFrame.cpp on lines 114 and 116. also i'm not sure about the TFN_ 
macro but it seems it's made to handle plurals automatically...

poy 

Re: [dcplusplus-devel] Some more translations again

[Jacek S. <arn...@gm...>]

Michael Jones wrote:
> Some more translations.  :)
> 
> Just a few comments with this one.
> 
> In Search frame, for the "Type" drop down, i left the  _T("TTH") as i didn't think this needs translation, but all the others in that drop down use the T_ type.
> Did this want changing to T_, or is it fine as is ?
Change to T_, in case someone wants to put something more descriptive...

> In WinUtil.cpp also added this line:
> 		Util::setManualAway(false);
> 
> a little over site from when i fixed:
> 
> * Manual away setting no longer cleared when un-minimizing (thanks pothead)
> 
> (it got used in the /away command when already away, but i missed adding it to the /back command :S )
Ok

> Also in QueueFrame.cpp i left this part:
> 					} else if(getSources().size() == 3) {
> 						display->columns[COLUMN_STATUS] = TSTRING(ALL_3_USERS_OFFLINE);
> 					} else if(getSources().size() == 4) {
> 						display->columns[COLUMN_STATUS] = TSTRING(ALL_4_USERS_OFFLINE);
> 					} else {
> 						_sntprintf(buf, 64, CTSTRING(ALL_USERS_OFFLINE), getSources().size());
> 						display->columns[COLUMN_STATUS] = buf;
> 					}
> 
> because i thought that the "else if" for sizes 3 and 4 could be removed, as it will get the same output for that amount of sources, on the "fall through" thingy.
> Also wasn't sure if the whole _sntprintf / buffer part was needed for the last bit, or if a T_("All %d users offline") could be used instead, like in T_("Matched %d files")
All plurals should be translated to TFN_("%1% user online", "%1% users online", n) % n...also, all
other parametrized strings should be translated to TF_("parameter %1% %2%") % value1 % value2...
See boost format for more detailed formatting information (and check the mailing list archives for
this list). This means that all calls to tformat should go away as well...I'll wait with the patch
until you get this in order.

> Also is this the right place to mention bugs ?
Generally only if they come with great detail or a proposed fix...

> i.e. the icons on the tabs under Wine kind of screw up.  Top tab row they are fine, but on all other tab rows, the icons are a lot lower than they should be.
That's a wine bug if it doesn't happen on windows...I've noticed it too...

/J

[dcplusplus-devel] Some more translations again

[Michael J. <mrm...@ho...>]

Some more translations.  :)

Just a few comments with this one.

In Search frame, for the "Type" drop down, i left the  _T("TTH") as i didn'=
t think this needs translation, but all the others in that drop down use th=
e T_ type.
Did this want changing to T_, or is it fine as is ?


In WinUtil.cpp also added this line:
		Util::setManualAway(false);

a little over site from when i fixed:

* Manual away setting no longer cleared when un-minimizing (thanks pothead)

(it got used in the /away command when already away, but i missed adding it=
 to the /back command :S )


Also in QueueFrame.cpp i left this part:
					} else if(getSources().size() =3D=3D 3) {
						display->columns[COLUMN_STATUS] =3D TSTRING(ALL_3_USERS_OFFLINE);
					} else if(getSources().size() =3D=3D 4) {
						display->columns[COLUMN_STATUS] =3D TSTRING(ALL_4_USERS_OFFLINE);
					} else {
						_sntprintf(buf, 64, CTSTRING(ALL_USERS_OFFLINE), getSources().size())=
;
						display->columns[COLUMN_STATUS] =3D buf;
					}

because i thought that the "else if" for sizes 3 and 4 could be removed, as=
 it will get the same output for that amount of sources, on the "fall throu=
gh" thingy.
Also wasn't sure if the whole _sntprintf / buffer part was needed for the l=
ast bit, or if a T_("All %d users offline") could be used instead, like in =
T_("Matched %d files")


>> I would prefer MikeJJ please, since i'm trying to ditch the nick Pothead=
.  I've also been meaning to ask if the "Pothead" in the About Box and chan=
gelog could be changed to MikeJJ for a while, but was waiting for the right=
 time to ask ;)
> Getting older? =3D)
hehe, yup.  ain't we all :(


Also is this the right place to mention bugs ?
i.e. the icons on the tabs under Wine kind of screw up.  Top tab row they a=
re fine, but on all other tab rows, the icons are a lot lower than they sho=
uld be.


thanks
MikeJJ
_________________________________________________________________
Telly addicts unite!
http://www.searchgamesbox.com/tvtown.shtml=

Re: [dcplusplus-devel] patch: tooltips on tabs

[poy <po...@12...>]

got it this time. :)
the problem was that WM_NOTIFY messages are sent back to where they came 
from, so i had to check for them directly into the tooltip control.

this patch also fixes a bug with ampersands that don't appear in the tab 
title (a simple way to see that is to open a search window and search for 
'&'); for that i moved WinUtil::escapeMenu into SmartUtil and that function 
is used to escape ampersands in tab titles.

added files:
smartwin/SmartUtil/StringUtils.h
smartwin/SmartUtil/StringUtils.cpp

poy

----- Original Message ----- 
From: "poy" <po...@12...>
To: "Jacek Sieka" <arn...@gm...>; "Patches & development 
discussion" <dcp...@li...>
Sent: Sunday, December 02, 2007 1:59 AM
Subject: Re: [dcplusplus-devel] patch: tooltips on tabs


> yes this looks like a much better way.
> i've tried the attached patch (add TCS_TOOLTIPS to the tabs style and 
> catch
> TTN_GETDISPINFO) but TTN_GETDISPINFO is never received apparently. i don't
> know what's missing...
>
> poy
>
> ----- Original Message ----- 
> From: "Jacek Sieka" <arn...@gm...>
> To: "poy" <po...@12...>; "Patches & development discussion"
> <dcp...@li...>
> Sent: Saturday, December 01, 2007 8:32 PM
> Subject: Re: [dcplusplus-devel] patch: tooltips on tabs
>
>
>> http://msdn2.microsoft.com/en-us/library/bb760550.aspx#tc_tooltips
>> better use those
>>
>> poy wrote:
>>> tooltips on tabs, added using the onMouseMove event as in the WTL
>>> version. it was actually quite easier than i would have thought it would
>>> be. :)
>>> might conflict with my previous patch about tab closing on mid mouse
>>> button click.
>>>
>>> poy
>>>
>>
>>
>


--------------------------------------------------------------------------------


> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4


--------------------------------------------------------------------------------


> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel
> 

[dcplusplus-devel] gettext 0.17 binaries for Windows

[poy <po...@12...>]

Tor Lillqvist provides his own binaries of the gettext tools 0.17 for 
Windows on http://www.gimp.org/~tml/gimp/win32/downloads.html

specifically, for DC++, gettext-runtime-0.17.zip and gettext-tools-0.17.zip 
are required.
direct download links:
http://ftp.gnome.org/pub/gnome/binaries/win32/dependencies/gettext-runtime-0.17.zip
http://ftp.gnome.org/pub/gnome/binaries/win32/dependencies/gettext-tools-0.17.zip

tested with the "package-name" argument that was missing from previous 
versions; worked fine. :)

poy 

Re: [dcplusplus-devel] proposal for new dc++ icons

[Jacek S. <arn...@gm...>]

Hi,

New icons would be nice, also because there will be a few new windows in future versions which will
need new graphics. I generally agree with the previous comments, the search icons need to look
different, accessibility needs to be considered (color blind etc). Perhaps it would also make sense
to look at firefox and other apps to make similar icons to make dc++ easier to use for the first
time user...In any case, dc++ mods often offer the possibility to customize icon sets - so I think
the basic dc++ should have as clear and simple icons as possible.

We'll be needing different sizes for the icons as some of them are reused in menus etc. The user
icons also need some love, and also those come in different sizes. How do you make the icons? Vector
or pixel based? Apart from the icons, I also want the source files used to generate them in case you
don't have time any more (now it's always a mess to add/remove an icon...)

/J

Flip Flop wrote:
> Yes, i'll be available for adding, or changing icons if needed. Greetz,

Re: [dcplusplus-devel] Some more translations

[Jacek S. <arn...@gm...>]

> I would prefer MikeJJ please, since i'm trying to ditch the nick Pothead.  I've also been meaning to ask if the "Pothead" in the About Box and changelog could be changed to MikeJJ for a while, but was waiting for the right time to ask ;)
Getting older? =)

> Also from my notes of current working copy, might as well ask this one now:
> 
> UserInfoBase.h needed #include  adding to get rid of these errors:
> win32\/UserInfoBase.h:96: error: 'Text' has not been declared
> is that the best thing to include ? as it also works including WinUtil.h
Always include the file that declares the class, in this case Text.h...

/J

Re: [dcplusplus-devel] Some more translations

[Michael J. <mrm...@ho...>]

>> In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all o=
thers in that area don't have the ampersand, so should that one or not ? I =
would think not, as "&Remove" is used on buttons and i think it's just been=
 reused, and over looked.  So i left this one unchanged.
> Add & to the other ones as well if it's a menu...
Okay, i'll leave them for the moment, until i can think off good accelerato=
rs for the other ones, as it'll help finding some right click menu's in fut=
ure. :)

> I guess it should wipe both in case it's a directory and not wipe in the =
other cases, but I've never
> used adl so I wouldn't know =3D)
I'll play with Full Path, to see if it uses Filesize then.  If not, might a=
s well be wiped from that one as well.

> I noticed though that CTSTRING is used in the wrong places often - it sho=
uld only be used when a
> LPCTSTR is needed (raw c pointer to string), so first try T_, and if that=
 gives compile errors use
> CT_...in other words, if the method being called takes a tstring, use T_ =
and not CT_...
hehe, now you said that, i'm glad i've not got around to doing any CTSTRING=
S yet.  Compiler errors are a good way to see if it needs it or not.  In my=
 current working copy i used compiler errors to see which files can have th=
e ResouceManager.h include deleted. (i failed at moving the ones from the l=
ast patch to a different directory, so now my working copy has half submitt=
ed and half not submitted changes :P).

> On a separate note; should it be pothead, mikejj or Michael Jones that ge=
ts credited?
I would prefer MikeJJ please, since i'm trying to ditch the nick Pothead.  =
I've also been meaning to ask if the "Pothead" in the About Box and changel=
og could be changed to MikeJJ for a while, but was waiting for the right ti=
me to ask ;)

Also from my notes of current working copy, might as well ask this one now:

UserInfoBase.h needed #include  adding to get rid of these errors:
win32\/UserInfoBase.h:96: error: 'Text' has not been declared
is that the best thing to include ? as it also works including WinUtil.h

thanks MikeJJ

_________________________________________________________________
Telly addicts unite!
http://www.searchgamesbox.com/tvtown.shtml=

Re: [dcplusplus-devel] dcplusplus-devel Digest, Vol 5, Issue 9

[Jacek S. <arn...@gm...>]

>> that's the way to go...
> Well it's up to you, i just cannot guarantee spelling things correctly the American way.  My English spelling isn't perfect, but at least with it, i know when i've spelt a word wrong, and can look it up.  Not really too much off a big issue at the moment, as the only two i've seen spelt "wrong" are Colour and Favourites. 
I've seen spell checkers for source code editors - maybe find one of those? I know eclipse and gedit
has them as plugins at least...in any case, if you get it wrong, I'm sure someone will complain at
some point...

> Okay, i'll try with that one tomorrow.  The _I part of the TSTRING_I isn't anything to worry about then ? (to be honest i have no idea what the _I relates too), since i saw another TSTRING_I in a different file and didn't know what to do with that one either.
See the macro definitions in ResourceManager.h - _I doesn't prefix the string you pass with
ResourceManager:: so it was used whenever the enum name wasn't passed directly...the short answer
would be that both map to T_...

/J

Re: [dcplusplus-devel] Some more translations

[Jacek S. <arn...@gm...>]

> In HubFrame the column uses "Nick" for "User name".  All the other frames use "User".  Not really to sure about this one, because it works "as is" just thought i should mention it.
I think the difference is that in the hub frame, each line is about a user, so nick says which piece
of information about the user we're displaying in that particular column, whereas in the other
places we happen to use the nick as an simple (and ambiguous) way of identification but conceptually
we want to know who the user is...

> In PublicHubsFrame.cpp, the TSTRING(HUBNAME) goes to "Name".  Should this stay as Name, or become Hub Name ?
Name is fine

> Trying to convert the columns in HubFrame.cpp an error came on this line, which i wasn't sure how to fix correctly, so i reverted my changes until a solution comes up (i have got a backup of it though). (Line 120 in svn694).
> filterType->addValue(TSTRING_I(columnNames[j]));
As David says, T_ is fine.

> In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all others in that area don't have the ampersand, so should that one or not ? I would think not, as "&Remove" is used on buttons and i think it's just been reused, and over looked.  So i left this one unchanged.
Add & to the other ones as well if it's a menu...

> In FavHubProperties.cpp the string "Hub address cannot be empty." has a fullstop at the end, as you can see.  But since no other strings have this, should it be dropped for consistency, or left, with the intention of more missing fullstops being added to other strings in the future ?
Without full stops looks better to me if it's a simple one-liner.

> I also noticed weird behaviour in ADLSearch
> When change a entry from File to Directory, it wipes the Min Size, but not the Max Size.
> When change a entry from File to Full path, it leaves both Min Size and Max Size.
> So what is the right behaviour, wiping Min Size in both places, but leaving Max Size.  Wiping both Min Size and Max Size.  Or leaving both ?
I guess it should wipe both in case it's a directory and not wipe in the other cases, but I've never
used adl so I wouldn't know =)


> And one quick last question for further translations.
> TSTRING(BLAH) goes to T_("Blah")
> How should CTSTRING(BLAH) end up ?
CT_ (which is a new macro: "#define CT_(String) T_(String).c_str()")

I noticed though that CTSTRING is used in the wrong places often - it should only be used when a
LPCTSTR is needed (raw c pointer to string), so first try T_, and if that gives compile errors use
CT_...in other words, if the method being called takes a tstring, use T_ and not CT_...

> 
> thanks MikeJJ

On a separate note; should it be pothead, mikejj or Michael Jones that gets credited?


/J

Re: [dcplusplus-devel] dcplusplus-devel Digest, Vol 5, Issue 9

[Michael J. <mrm...@ho...>]

Thanks for the welcome.  I turned the Digest off now, should be a bit easie=
r to use this mailing list now. :)
=20
>> And to clarify, is it meant to be in English or American (they spell thi=
ngs weird) ?
> Well, personally I'd prefer English, but American unfortunately seems to =
be the standard so I guess
> that's the way to go...
Well it's up to you, i just cannot guarantee spelling things correctly the =
American way.  My English spelling isn't perfect, but at least with it, i k=
now when i've spelt a word wrong, and can look it up.  Not really too much =
off a big issue at the moment, as the only two i've seen spelt "wrong" are =
Colour and Favourites.=20

> Feel free to change anything you like...you're the native speaker, not me=
... =3D)
Okay, thanks for the clarification of what to do with that. :)

>> In PublicHubsFrame.cpp, the TSTRING(HUBNAME) goes to "Name".  Should thi=
s stay as Name, or become Hub Name ?
> I say stick with Name. The context makes it clear.
Okay, was just checking because the StringDef name was more detailed than t=
he actual string it went too.

>> Trying to convert the columns in HubFrame.cpp an error came on this line=
, which i wasn't sure how to fix correctly, so i reverted my changes until =
a solution comes up (i have got a backup of it though). (Line 120 in svn694=
).
>> filterType->addValue(TSTRING_I(columnNames[j]));
>>  =20
> TSTRING_I(actual code) is a macro that doesn't take a=20
> ResourceManager::EnumValue...
> Looking at the code, this would probably translate to T_(columnNames[j])

Okay, i'll try with that one tomorrow.  The _I part of the TSTRING_I isn't =
anything to worry about then ? (to be honest i have no idea what the _I rel=
ates too), since i saw another TSTRING_I in a different file and didn't kno=
w what to do with that one either.

>> In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all o=
thers in that area don't have the ampersand, so should that one or not ? I =
would think not, as "&Remove" is used on buttons and i think it's just been=
 reused, and over looked.  So i left this one unchanged.
>>  =20
> In case you didn't know, the ampersand causes mnemonics to appear under c=
haracters, and keyboard accelerators to be activated. On later Windows vers=
ions they are hidden by default on buttons, can be shown by pressing the AL=
T key.
> My guess is that all the items on the popup menu are all supposed to have=
 mnemonics.
Yup, that's an really annoying setting, one of the first i change after a w=
indows install.  I just thought the ampersand was used there because of re-=
using stringdefs, since all the rest off the popup's don't use it.  Leaving=
 it in implies that all the other entries in every popup needs one as well.=
 :S

>> In FavHubProperties.cpp the string "Hub address cannot be empty." has a =
fullstop at the end, as you can see.  But since no other strings have this,=
 should it be dropped for consistency, or left, with the intention of more =
missing fullstops being added to other strings in the future ?
> Consistency.
Okay :)

>> And one quick last question for further translations.
>> TSTRING(BLAH) goes to T_("Blah")
>> How should CTSTRING(BLAH) end up ?
>>  =20
> CTSTRING(BLAH) would technically become T_("Blah").c_str() Can't vouch fo=
r its correctness though.
Right, another one to try tomorrow. :)

> Great work!
Thanks :D
_________________________________________________________________
Share what Santa brought you
https://www.mycooluncool.com=

Re: [dcplusplus-devel] Some more translations

[David G. <c0...@cs...>]

You've been busy :)

Michael Jones skrev:
> In PublicHubsFrame.cpp, the TSTRING(HUBNAME) goes to "Name".  Should this stay as Name, or become Hub Name ?
>   
I say stick with Name. The context makes it clear.
> Trying to convert the columns in HubFrame.cpp an error came on this line, which i wasn't sure how to fix correctly, so i reverted my changes until a solution comes up (i have got a backup of it though). (Line 120 in svn694).
> filterType->addValue(TSTRING_I(columnNames[j]));
>   
TSTRING_I(actual code) is a macro that doesn't take a 
ResourceManager::EnumValue...

Looking at the code, this would probably translate to T_(columnNames[j])
> In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all others in that area don't have the ampersand, so should that one or not ? I would think not, as "&Remove" is used on buttons and i think it's just been reused, and over looked.  So i left this one unchanged.
>   
In case you didn't know, the ampersand causes mnemonics to appear under 
characters, and keyboard accelerators to be activated. On later Windows 
versions they are hidden by default on buttons, can be shown by pressing 
the ALT key.

My guess is that all the items on the popup menu are all supposed to 
have mnemonics.

> In FavHubProperties.cpp the string "Hub address cannot be empty." has a fullstop at the end, as you can see.  But since no other strings have this, should it be dropped for consistency, or left, with the intention of more missing fullstops being added to other strings in the future ?
>   
Consistency.
> And one quick last question for further translations.
> TSTRING(BLAH) goes to T_("Blah")
> How should CTSTRING(BLAH) end up ?
>   
CTSTRING(BLAH) would technically become T_("Blah").c_str() Can't vouch 
for its correctness though.

Great work!

[dcplusplus-devel] Some more translations

[Michael J. <mrm...@ho...>]

Attached are some more translations.
Doing these / checking i noticed a few more things i thought i should bring=
 up to make others aware off.

In HubFrame the column uses "Nick" for "User name".  All the other frames u=
se "User".  Not really to sure about this one, because it works "as is" jus=
t thought i should mention it.

In PublicHubsFrame.cpp, the TSTRING(HUBNAME) goes to "Name".  Should this s=
tay as Name, or become Hub Name ?

Trying to convert the columns in HubFrame.cpp an error came on this line, w=
hich i wasn't sure how to fix correctly, so i reverted my changes until a s=
olution comes up (i have got a backup of it though). (Line 120 in svn694).
filterType->addValue(TSTRING_I(columnNames[j]));

In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all othe=
rs in that area don't have the ampersand, so should that one or not ? I wou=
ld think not, as "&Remove" is used on buttons and i think it's just been re=
used, and over looked.  So i left this one unchanged.

In FavHubProperties.cpp the string "Hub address cannot be empty." has a ful=
lstop at the end, as you can see.  But since no other strings have this, sh=
ould it be dropped for consistency, or left, with the intention of more mis=
sing fullstops being added to other strings in the future ?

I also noticed weird behaviour in ADLSearch
When change a entry from File to Directory, it wipes the Min Size, but not =
the Max Size.
When change a entry from File to Full path, it leaves both Min Size and Max=
 Size.
So what is the right behaviour, wiping Min Size in both places, but leaving=
 Max Size.  Wiping both Min Size and Max Size.  Or leaving both ?

And one quick last question for further translations.
TSTRING(BLAH) goes to T_("Blah")
How should CTSTRING(BLAH) end up ?

thanks MikeJJ

_________________________________________________________________
Free games, great prizes - get gaming at Gamesbox.=20
http://www.searchgamesbox.com=