Menu
▾
▴
dcplusplus-devel — Developer's list
You can subscribe to this list here.
| 2002 |
Jan
|
Feb
(1) |
Mar
|
Apr
|
May
|
Jun
|
Jul
(1) |
Aug
(2) |
Sep
|
Oct
|
Nov
|
Dec
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
|
Feb
(2) |
Mar
(1) |
Apr
|
May
(4) |
Jun
(3) |
Jul
(1) |
Aug
(1) |
Sep
(4) |
Oct
|
Nov
|
Dec
|
| 2007 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(2) |
Oct
(28) |
Nov
(89) |
Dec
(37) |
| 2008 |
Jan
(78) |
Feb
(37) |
Mar
(21) |
Apr
(3) |
May
(10) |
Jun
(3) |
Jul
(13) |
Aug
(7) |
Sep
(9) |
Oct
(3) |
Nov
(4) |
Dec
|
| 2009 |
Jan
(2) |
Feb
(7) |
Mar
(16) |
Apr
(1) |
May
(2) |
Jun
|
Jul
|
Aug
(8) |
Sep
|
Oct
(5) |
Nov
(4) |
Dec
(1) |
| 2010 |
Jan
(4) |
Feb
(1) |
Mar
|
Apr
|
May
(1) |
Jun
(1) |
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2011 |
Jan
(1) |
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(1) |
| 2012 |
Jan
(4) |
Feb
|
Mar
(1) |
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
|
Nov
|
Dec
|
| 2013 |
Jan
(1) |
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
(1) |
Aug
|
Sep
(2) |
Oct
|
Nov
|
Dec
|
| 2014 |
Jan
|
Feb
|
Mar
(4) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2015 |
Jan
(2) |
Feb
(1) |
Mar
(1) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2016 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(2) |
Oct
|
Nov
|
Dec
|
| 2017 |
Jan
|
Feb
(1) |
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2018 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(2) |
Dec
|
| 2022 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
|
Nov
|
Dec
|
|
From: Eugen <pi...@de...> - 2008-02-05 07:50:44
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=windows-1252"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Hmm no idea. I just used tortoise svn to "create patch" after modifying
the things. There is no such option. I dont think its that big, just 10
kb<br>
Thats a problem ?<br>
<br>
<br>
Todd Pederzani wrote:
<blockquote
cite="mid:9ca...@ma..."
type="cite">On Feb 4, 2008 3:12 AM, Eugen <<a moz-do-not-send="true"
href="mailto:pi...@de...">pi...@de...</a>>
wrote:<br>
<div class="gmail_quote">
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">This
patch updates the links to launchpad etc and modifies the about years
to 2008<br>
<br>
I think this should be applied before release so that users have
working links in the menu.<br>
</blockquote>
</div>
<br>
Is there a reason the patch is so big? It looks like you're counting
whitespace or something... Can you force your patch program to generate
a minimal patch, ignoring whitespace?<br>
<br>
-- <br>
Todd Pederzani<br>
<a moz-do-not-send="true" href="mailto:tod...@gm...">tod...@gm...</a>
<pre wrap="">
<hr size="4" width="90%">
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
<a class="moz-txt-link-freetext" href="http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/">http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/</a></pre>
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
dcplusplus-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:dcp...@li...">dcp...@li...</a>
<a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel">https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>
|
|
From: Todd P. <tod...@gm...> - 2008-02-04 18:21:21
|
On Feb 4, 2008 3:12 AM, Eugen <pi...@de...> wrote: > This patch updates the links to launchpad etc and modifies the about years > to 2008 > > I think this should be applied before release so that users have working > links in the menu. > Is there a reason the patch is so big? It looks like you're counting whitespace or something... Can you force your patch program to generate a minimal patch, ignoring whitespace? -- Todd Pederzani tod...@gm... |
|
From: Eugen <pi...@de...> - 2008-02-04 08:13:25
|
This patch updates the links to launchpad etc and modifies the about years to 2008 I think this should be applied before release so that users have working links in the menu. Pietry. |
|
From: Eugen <pi...@de...> - 2008-02-03 07:44:39
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=windows-1252"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
I don't think this is a solution to the bug in question .<br>
Redirects are meant to be followed. DC++ is user client not operator
client. <br>
Most users have no idea what redirect is and they don't care. <br>
If by default you disable the follow redirects, then the whole redirect
system may crash.<br>
Users won't try to find out what's happening. They would be
reconnecting over and over to all the hubs they were redirected from.<br>
I don;t think the normal user cares what hub it's in, he/she just want
to download, so banned users or kicked or whatever have to go somewhere.<br>
The consequences of this action could be disastrous on long term<br>
<br>
<br>
<br>
Michael Jones wrote:
<blockquote cite="mid:BAY...@ph...l"
type="cite">
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
FONT-SIZE: 10pt;
FONT-FAMILY:Tahoma
}
</style>Some script kiddies recently been exploiting a bug in DC++
where main chat messages do something and make DC++ follow redirects to
the spammers hub. Little patch to make 'Auto follow Redirects'
disabled by default.<br>
<hr>Sounds like? How many syllables? <a moz-do-not-send="true"
href="http://www.searchcharades.com" target="_new">Guess and win
prizes with Search Charades!</a>
<pre wrap="">
<hr size="4" width="90%">
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
<a class="moz-txt-link-freetext" href="http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/">http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/</a></pre>
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
dcplusplus-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:dcp...@li...">dcp...@li...</a>
<a class="moz-txt-link-freetext" href="https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel">https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">
</pre>
</body>
</html>
|
|
From: Michael J. <mrm...@ho...> - 2008-02-03 01:52:24
|
> Mike, do you have any more information about this? If the hub is issuing= the redirect, changing the default to off is a decent solution. If indivi= dual users are somehow issuing a direct to DC++, I'd like to understand how= , in case there's a more effective fix.> Do you know of particular hubs, or= specific hub software/client version pairs, or anything that would allow s= omeone to reproduce it? So far not much info. It seems to be Ynhub which is being targeted, but si= nce most hubs run that, no suprise really. But from the sounds of it, it's= going direct to DC++, since for example nothing is mentioned in "feed", it= happens after ascii / unicode or whatever has been pasted into main chat (= by people using proxies). Obviously the target of the redirect it a script= kiddie hub. 0.674 -> onwards it has happened with. Also some 0.401 mods of dc++ are al= l susceptible. Unfortunately no more information at the moment. :( _________________________________________________________________ Telly addicts unite! http://www.searchgamesbox.com/tvtown.shtml= |
|
From: Todd P. <tod...@gm...> - 2008-02-02 22:46:28
|
On Feb 2, 2008 11:10 AM, Michael Jones <mrm...@ho...> wrote: > Some script kiddies recently been exploiting a bug in DC++ where main > chat messages do something and make DC++ follow redirects to the spammers > hub. Little patch to make 'Auto follow Redirects' disabled by default. > Mike, do you have any more information about this? If the hub is issuing the redirect, changing the default to off is a decent solution. If individual users are somehow issuing a direct to DC++, I'd like to understand how, in case there's a more effective fix. Do you know of particular hubs, or specific hub software/client version pairs, or anything that would allow someone to reproduce it? -- Todd Pederzani tod...@gm... |
|
From: jaap <ja...@fp...> - 2008-01-31 19:35:09
|
Already found that problem. The gui is hidding very slow on the Intel. Think I have to build it again to get a working version. Otherwise it should be possible to get an version that works voor both type of processors. When you need some help let me know Regards Jaapio itinerants wrote: > >> I will take a look. I hope the source will be available soon. So it can >> be updated to the latest version of DC++. >> > > It will be. > I myself am running .704, but there's an issue with it running in Intel. > I myself am still running 10.3.9 on RISC. And I did the intel build using > RemoteAccess to the supervisor's machine from Portugal to Sweden. Somewhat > slow. > I hope to be getting a new machine shortly so I can build, debug myself. > > Regards > > Roger > > > >> tnx >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by: Microsoft >> Defy all challenges. Microsoft(R) Visual Studio 2008. >> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >> _______________________________________________ >> dcplusplus-devel mailing list >> dcp...@li... >> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel >> >> > > > > |
|
From: jaap <ja...@fp...> - 2008-01-31 19:17:56
|
I will take a look. I hope the source will be available soon. So it can be updated to the latest version of DC++. tnx |
|
From: itinerants <iti...@ho...> - 2008-01-31 19:09:14
|
On 30/1/08 10:12 pm, "jaap" <ja...@fp...> wrote:
> Hello,
>
> Today i was looking for a version of DC++ that should run on mac osx but
> all projects I found where not based on the origial core. I liked the
> windows version of DC++ very much. So I contacted Jacek with the
> question if he was interested in a OSX version. I think reading his
> reply, he would like to have an other version of DC++.
>
> Because I think there will be many mac users that would like to use an
> offical version of DC++, and not some familiar project that doesn't have
> all features, it will be a good idea to start a project to develop this
> version. Since this project is opensource and I don't have very much
> time to work on it, Only a few hours a week, it would be a nice idea to
> give all the copierights to the existing DC++ project.
>
> I am not experianced with mac osx. But I created many custom C++
> applications for windows. With some help from the developers of the
> windows project and maybe some others that have time to help we can do
> this task. If there are developers that like this idea. and want to join
> this subproject, reply :-)
In fact, there IS a version on dc++ on OSX that is being tested even as we
type.
It's based on the "client" portion of dc++, with a Carbon Native GUI.
I've been busy moving house recently, so all that's available is a universal
build based on .699
If you're happy to run something for which the source code is not available
(but will be very shortly) it can be found at...
http://applestore.no-ip.org
It's being used (by a few people), and sometimes discussed on...
dchub://applestore.no-ip.org:1111
Regards
Roger
>
> regards
> Jaapio
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel
>
|
|
From: Todd P. <tod...@gm...> - 2008-01-31 13:35:21
|
On Jan 31, 2008 4:24 AM, jaap <ja...@fp...> wrote: > Like the implementation of the DC++ protocols, It won't be that hard to > create an application. And I know that there are Linux versions that you can > also compile for mac osx. So why shouldn't I and maybe some others create a > real mac version? If you have the time, go for it! -- Todd Pederzani tod...@gm... |
|
From: jaap <ja...@fp...> - 2008-01-31 09:24:13
|
I found the shakepeer project. But every time I reconnect I have to wait for the hash. It is very annoying/* */to wait for that when you share 500Gb it takes an houre or 2. The macdc project is a dead project. The admins of the project left. Only one developer is "active" if you read the mailing list. But that has no new mailings since december 2004. I alreay sended them an email. but they never respond to it. To the last point of building it from scratch, I don't know what libraries are available from this project. And probely an other opensource project like macdc, if there are some. Like the implementation of the DC++ protocols, It won't be that hard to create an application. And I know that there are Linux versions that you can also compile for mac osx. They are not looking like the other application. So why shouldn't I and maybe some others create a real mac version? I didn't found an opensource project that looks like the original DC++, Only some commercial ones. Jaapio |
|
From: Steven S. <ste...@gm...> - 2008-01-31 03:33:59
|
Todd Pederzani wrote: > On Jan 30, 2008 5:12 PM, jaap <ja...@fp... > <mailto:ja...@fp...>> wrote: > > Today i was looking for a version of DC++ that should run on mac osx but > all projects I found where not based on the origial core. > > > Did you find http://sourceforge.net/projects/macdcpp/ ? It is old, but > adapting it is almost certainly is less work than starting from scratch. > > > > > Because I think there will be many mac users that would like to use an > offical version of DC++, and not some familiar project that doesn't have > all features > > > Shakespeer looks very good. There's nothing inherently wrong with > non-DC++ based clients. > > > > -- > Todd Pederzani > tod...@gm... <mailto:tod...@gm...> > > If you don't mind running a non-Cocoa application on a Mac, the project I maintain called LinuxDC++ (http://linuxdcpp.berlios.de) has been compiled before on Mac OS X. -Steven |
|
From: Todd P. <tod...@gm...> - 2008-01-31 03:13:04
|
On Jan 30, 2008 5:12 PM, jaap <ja...@fp...> wrote: > Today i was looking for a version of DC++ that should run on mac osx but > all projects I found where not based on the origial core. Did you find http://sourceforge.net/projects/macdcpp/ ? It is old, but adapting it is almost certainly is less work than starting from scratch. > Because I think there will be many mac users that would like to use an > offical version of DC++, and not some familiar project that doesn't have > all features Shakespeer looks very good. There's nothing inherently wrong with non-DC++ based clients. -- Todd Pederzani tod...@gm... |
|
From: jaap <ja...@fp...> - 2008-01-30 22:12:15
|
Hello, Today i was looking for a version of DC++ that should run on mac osx but all projects I found where not based on the origial core. I liked the windows version of DC++ very much. So I contacted Jacek with the question if he was interested in a OSX version. I think reading his reply, he would like to have an other version of DC++. Because I think there will be many mac users that would like to use an offical version of DC++, and not some familiar project that doesn't have all features, it will be a good idea to start a project to develop this version. Since this project is opensource and I don't have very much time to work on it, Only a few hours a week, it would be a nice idea to give all the copierights to the existing DC++ project. I am not experianced with mac osx. But I created many custom C++ applications for windows. With some help from the developers of the windows project and maybe some others that have time to help we can do this task. If there are developers that like this idea. and want to join this subproject, reply :-) regards Jaapio |
|
From: Jacek S. <arn...@gm...> - 2008-01-25 20:45:59
|
> Only other ones i did different was in Util.cpp i used F_ removing
> the buffers, and ADLSearch.h
> string szDiscard(_("<<<Discard>>>"));
makes sense...
/J
|
|
From: Jacek S. <arn...@gm...> - 2008-01-25 20:02:05
|
Ok, at some point I will want to kill smartutil an move it to the same directory as the rest of smartwin I think... /J poy wrote: > got it this time. :) > the problem was that WM_NOTIFY messages are sent back to where they came > from, so i had to check for them directly into the tooltip control. > > this patch also fixes a bug with ampersands that don't appear in the tab > title (a simple way to see that is to open a search window and search > for '&'); for that i moved WinUtil::escapeMenu into SmartUtil and that > function is used to escape ampersands in tab titles. > > added files: > smartwin/SmartUtil/StringUtils.h > smartwin/SmartUtil/StringUtils.cpp > > poy |
|
From: Jacek S. <arn...@gm...> - 2008-01-25 18:57:52
|
Ok, the translation script is finished (http://dcplusplus.sf.net/x2po.py), now all that's needed is a volunteer to run it on the files present in the translations tracker (http://sourceforge.net/tracker/?atid=460289&group_id=40287&func=browse). It's really simple to use but requires some manual intervention...here's how it works: 1) download xml file and note the username of the author 2) place file, script and Example.xml from 0.704 in the directory you have the dc++ source in. 3) check if xml file is utf-8, if not convert (using iconv for example) Using Korean.xml by gut...@us... as example (locale ko) 4) run: python x2po.py dcpp/po/dcpp.pot Korean.xml ko gut...@us... dcpp python x2po.py win32/po/dcpp-win32.pot Korean.xml ko gut...@us... win32 This will place two files, dcpp/po/ko.po and win32/po/ko.po which you need to visually inspect and then send them to this list (or commit if you happen to have commit access...) Any volunteers? /Jacek |
|
From: Matt P. <404...@gm...> - 2008-01-24 21:33:59
|
On 1/24/08, dcp...@sm... <dcp...@sm...> wrote: > I created a patch which will filter files from the search results, if they are > already in your own share (with same TTH). > It works well for me and I think others might like it, too. This should definitely be made an option. I often search for alternates on files in my own share to see how many other people have the file---to see if I can safely delete it. |
|
From: Michael J. <mrm...@ho...> - 2008-01-24 14:34:54
|
heh, oops, guess i should have updated svn last night and saved myself a bi=
t of time.
=20
This part of my patch still needs doing:
=20
--- Socket.cpp (revision 976)+++ Socket.cpp (working copy)@@ -52,7 +52,7 @@=
string msg =3D Util::translateError(aError); if(msg.empty()) {- msg =
=3D str(F_("Unknown error: 0x%1%") % aError);+ msg =3D str(F_("Unknown err=
or: 0x%1$x") % aError); } return msg; }
=20
Only other ones i did different was in Util.cpp i used F_ removing the buff=
ers, and ADLSearch.h
string szDiscard(_("<<<Discard>>>"));=20
=20
string szDiscard =3D "<<<" + string(_("Discard")) + ">>>";
since the other places in the cpp which used <<< >>> left them untranslatab=
le.
_________________________________________________________________
Free games, great prizes - get gaming at Gamesbox.=20
http://www.searchgamesbox.com=
|
|
From: <dcp...@sm...> - 2008-01-24 11:50:40
|
Hi, I created a patch which will filter files from the search results, if they are already in your own share (with same TTH). It works well for me and I think others might like it, too. Bye, Smir |
|
From: David G. <c0...@cs...> - 2008-01-24 10:00:58
|
I'm sorry I haven't been of more help. I thought that I would have time for it, but real life demanded more than I'd expected at the end of term. Oh well. Jacek Sieka wrote: > Thanks to mikejj mainly, the transition to gettext is done as far as the source is concerned... > What remains is to make a script that takes an xml file and creates a po file...I've started playing > around with such a script that should be ready tomorrow, then we'll see how to proceed with the > actual translations...nice work and thanks to all who contributed, both code- and discussionwise =) > |
|
From: Jacek S. <arn...@gm...> - 2008-01-24 00:01:10
|
Thanks to mikejj mainly, the transition to gettext is done as far as the source is concerned... What remains is to make a script that takes an xml file and creates a po file...I've started playing around with such a script that should be ready tomorrow, then we'll see how to proceed with the actual translations...nice work and thanks to all who contributed, both code- and discussionwise =) /J |
|
From: Jacek S. <arn...@gm...> - 2008-01-23 20:13:57
|
> Could do with a 'plural' macro for
> MATCHED_FILES used in QueueManager.cpp:982
> any suggestions ? (using dngettext maybe ?)
added
> However these ones, there i couldn't see a way to distinguish them
> between a Singualar or a Plural, so i translated 'as is'
> KICK_USER, // 'Kick user(s)'
> REDIRECT_USER, // 'Redirect user(s)'
> e.g. Before
> addUserCommand(UserCommand::TYPE_RAW_ONCE,UserCommand::CONTEXT_CHAT
> | UserCommand::CONTEXT_SEARCH,UserCommand::FLAG_NOSAVE,
> STRING(KICK_USER), kickstr, 'op');
> After
> addUserCommand(UserCommand::TYPE_RAW_ONCE,UserCommand::CONTEXT_CHAT
> | UserCommand::CONTEXT_SEARCH,UserCommand::FLAG_NOSAVE, _('Kick
> user(s)'), kickstr, 'op');
That's fine (singular or plural is unknown when the strings are added so...)
> In Socket.cpp i changed this
> char tmp[64];
> snprintf(tmp, sizeof(tmp), CSTRING(UNKNOWN_ERROR), aError);
> msg = tmp;
> to
> msg = str(F_('Unknown error: 0x%1%') % aError);
> where
> UNKNOWN_ERROR, // 'Unknown error: 0x%x'
>
> Is that alright ? i was concerned maybe the 0x part was wrong / wouldn't
> work way i done it.
It won't work. It should be 0x%1$x or something like that to display the error in hex...
> In SettingsManager.cpp i left this one for now (there is a similar one
> for Uploads as well),
>
> setDefault(LOG_FORMAT_POST_DOWNLOAD, '%Y-%m-%d %H:%M: %[target]' +
> STRING(DOWNLOADED_FROM) + '%[userNI] (%[userCID]), %[fileSI]
> (%[fileSIchunk]), %[speed], %[time], %[fileTR]');
>
> should a F_ be used, and all the contents put in it ? (the % stuff
> already in it, might play havoc with boost::format ?), or just _ the
> string ?
make it just the STRING for now...
>
> I was also thinking maybe a non-gettext way to access boost format would
> be nice to replace the snprintf 's ?
Most remaining snprintf's I see are for simple conversions - boost would take longer to compile and
create slower code so I'd leave it as is...
/J
|
|
From: Steven S. <ste...@gm...> - 2008-01-23 04:10:23
|
Jacek Sieka wrote: > memory is already included by stdinc.h which should be included first by every .cpp file, so this > shouldn't be needed... > > /J > > Steven Sheehy wrote: >> See http://www.cyrius.com/journal/2007/05/10#gcc-4.3-include >> >> > > Oh, sorry. It wasn't in 0.698 but I guess I forgot to check for it in stdinc.h in latest trunk. -Steven |
|
From: Jacek S. <arn...@gm...> - 2008-01-22 08:50:32
|
Michael Jones wrote:
> Just a few more queries to finish off most off win32 (excluding the stuff which may need Keyboard Accelerators)
>
> The F_ macro doesn't work in win32. Somethings in HubFrame.cpp and WinUtil.cpp could do with it. e.g.
> speak(ADD_STATUS_LINE, STRING(CONNECTING_TO) + client->getHubUrl() + "...");
> LogManager::getInstance()->message(STRING(MAGNET_DLG_TITLE) + ": " + Text::fromT(aUrl));
> Should something like this be added to stdafx.h ?
>
> #define F_(String) boost::format(gettext(String))
This one...
> and if so, inside or outside the ifdef unicode thingy ?
Outside...unicode is for tstrings while strings and wstrings go outside...
> I really have no idea of what to do to the two functions which do this
> if (ResourceManager::getInstance()->isRTL())
Neither do I =) That's supposed to say which languages are right-to-left, but I'll have to find some
smart way of doing that now that it's not part of the xml file...leave the call for now.
> The Toolbar stuff in MainWindow.cpp, e.g.
> toolbar->appendItem(IDC_RECONNECT, image++, TSTRING(MENU_RECONNECT));
>
> i assume this is for the Tooltips. But the tooltips don't display accelerators or shortcut keys, so should it keep them ?
Hm, make it without...I think &'s are stripped automagically but it makes little sense to keep them
there and it'll look more natural...
> (not all of them use the right stringdef for the accelerators & shortcuts keys to be displayed, so if keeping, should these be changed to the ones which have them ?)
In general, it would be good to have unique accels in all the right-click menus and most of the main
menu, so if they're missing, you're welcome to add them...
> Also is the AWAY string in caps for a reason ?
> The two places which use it are MainWindow.cpp:294
> statusSizes[STATUS_AWAY] = status->getTextSize(TSTRING(AWAY)).x + 12;
>
> and MainWindow.cpp:550
> setStatus(STATUS_AWAY, Util::getAway() ? TSTRING(AWAY) : _T(""));
Yeah, usually this kind of on/off indicators in the status bar are allcaps from what I've seen (most
often they refer to INS/OVERWRITE indicators in text editors...)...but if you have evidence that
points in another direction...
/J
|
30 messages has been excluded from this view by a project administrator.
