codestriker-user Mailing List for Codestriker: collaborative code reviewer (Page 11)
Brought to you by:
sits
You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(12) |
Jun
|
Jul
|
Aug
(2) |
Sep
|
Oct
|
Nov
|
Dec
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
|
Feb
|
Mar
(1) |
Apr
(6) |
May
(3) |
Jun
(1) |
Jul
|
Aug
(9) |
Sep
(2) |
Oct
(2) |
Nov
(8) |
Dec
(6) |
| 2004 |
Jan
(12) |
Feb
(19) |
Mar
(2) |
Apr
(2) |
May
(4) |
Jun
(11) |
Jul
|
Aug
(14) |
Sep
(4) |
Oct
(27) |
Nov
(4) |
Dec
(22) |
| 2005 |
Jan
(14) |
Feb
(2) |
Mar
(11) |
Apr
(3) |
May
(14) |
Jun
(60) |
Jul
(58) |
Aug
(76) |
Sep
(72) |
Oct
(59) |
Nov
|
Dec
(4) |
| 2006 |
Jan
(1) |
Feb
(5) |
Mar
(13) |
Apr
(11) |
May
(30) |
Jun
(17) |
Jul
(18) |
Aug
(39) |
Sep
|
Oct
|
Nov
|
Dec
(17) |
| 2007 |
Jan
(18) |
Feb
(5) |
Mar
(20) |
Apr
(2) |
May
(3) |
Jun
(13) |
Jul
(11) |
Aug
(4) |
Sep
(6) |
Oct
(9) |
Nov
(3) |
Dec
|
| 2008 |
Jan
(10) |
Feb
|
Mar
(5) |
Apr
|
May
|
Jun
(9) |
Jul
(10) |
Aug
(10) |
Sep
(13) |
Oct
(34) |
Nov
(12) |
Dec
(8) |
| 2009 |
Jan
(4) |
Feb
(11) |
Mar
(12) |
Apr
(3) |
May
(36) |
Jun
(4) |
Jul
(11) |
Aug
(12) |
Sep
(25) |
Oct
(13) |
Nov
(9) |
Dec
|
| 2010 |
Jan
|
Feb
(12) |
Mar
(6) |
Apr
(10) |
May
(12) |
Jun
|
Jul
(4) |
Aug
(9) |
Sep
(12) |
Oct
(3) |
Nov
(6) |
Dec
(3) |
| 2011 |
Jan
(2) |
Feb
(1) |
Mar
(3) |
Apr
(5) |
May
(3) |
Jun
(8) |
Jul
|
Aug
(14) |
Sep
|
Oct
(3) |
Nov
(1) |
Dec
|
| 2012 |
Jan
(2) |
Feb
(10) |
Mar
(4) |
Apr
(3) |
May
(2) |
Jun
(5) |
Jul
|
Aug
(3) |
Sep
|
Oct
(2) |
Nov
(4) |
Dec
(2) |
| 2013 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(4) |
Jun
|
Jul
|
Aug
|
Sep
(2) |
Oct
(1) |
Nov
|
Dec
(2) |
| 2014 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: Gary Y. <gar...@ya...> - 2009-05-07 00:00:44
|
Hi David,
I do not understand your explaination. From my understanding, the diff text matches the depot path. There is a hyperlinked parallel line. A window popped up after I clicked on the Paraelle. It shows two differen revisons of the file. I tried it again. Still, there is no hyperlink with the line number. Below is the detail.
in codestriker.conf:
'perforce:apache:apache1234@ipcswsvdcp4:1666',
The Perforce client workspace spec:
p4 client -o
View:
//training/... //gary_pc_training/training/...
p4 diff -du
==== //training/main.c#10 - c:\workspace\gary_pc_training\training\main.c ====
@@ -30,7 +30,6 @@
#include <sys\ppc440sp_board.h>
#include <ppclib.h>
-#include <asynclib.h>
#include <stdio.h>
#include <sys\tcpiplib.h>
#include <serial.h>
@@ -41,12 +40,13 @@
/* SDRAM MICRON */
#define SDRAM_MICRON 0x2C
-#define SDRAM_TRUE 1
+#define SDRAM_TRUE 2
#define SDRyAM_FALSE 0
#define SDRAM_DDR1 1
#define SDRAM_DDR2 2
#define SDRAM_NONE 0
#define MAXDIMMS 2
+#define max 3
#define MAXRANKS 2 /* Changes le 12/01/05 pour 1.6*/
#define MAXBANKSPERDIMM 8
#define MAXRANKSPERDIMM 2
==== //training/test_dir/mainTG.c#1 - c:\workspace\gary_pc_training\training\test_dir\mainTG.c ====
@@ -20,8 +20,7 @@
#---------------------------------------------------------------------------*/
/* Perform DQS calibration and test memory */
-#include <sys\ppc440sp_board.h>
-#include <ppclib.h>
+#include <ppc.h>
#include <asynclib.h>
#include <stdio.h>
#include <sys\tcpiplib.h>
@@ -34,6 +33,7 @@
#define SDRAM_MICRON 0x2C
#define SDRAM_TRUE 1
+#define SDRAM_TRUE 9
#define SDRyAM_FALSE 0
#define SDRAM_DDR1 1
#define SDRAM_DDR2 2
Thanks,
Gary
--- On Wed, 5/6/09, David Sitsky <dav...@gm...> wrote:
> From: David Sitsky <dav...@gm...>
> Subject: Re: No new browser window opened up after clicked on the line number.
> To: "Gary Yang" <gar...@ya...>
> Cc: cod...@li...
> Date: Wednesday, May 6, 2009, 3:14 PM
> This happens when the diff you have
> loaded in doesn't match the
> repository associated with the topic. If you have the
> repository set
> to your Perforce depot, and the diff text matches the depot
> path, then
> those links will become active again. You'll need to
> create new
> topics whenever you change the repository string in
> codestriker.conf.
>
> Cheers,
> David
>
> On Thu, May 7, 2009 at 7:56 AM, Gary Yang <gar...@ya...>
> wrote:
> >
> > Hi David,
> >
> >
> > I use Perforce and Codestriker 1.9.6. In the The
> Codestriker Guide 1.9.5 at the section, 3.5.1. Viewing a
> Topic. The last paragraph says below:
> >
> > Each file is broken up into a series of "deltas". At
> the head of each delta block, for both the old and new
> versions of the file, there is an indication of what line
> number the delta started at. In this situation, clicking on
> the "Line 24" link on the left hand side, will open a new
> browser window, which will contain the complete original
> contents of codestriker/codestriker.pl, anchored at line 24.
> Clicking on the "Line 22" link on the right hand side will
> contain the complete contents of codestriker/codestriker.pl
> will all of the proposed changes applied.
> >
> > However, when I clicked on the line number, there is
> no new browser window opened up. Actually, there is no
> hyperlink line under the line number. It is different than
> what I see in the manual. Can you please let me know the
> reason?
> >
> >
> > Thanks,
> >
> >
> > Gary
> >
> >
> >
> >
> >
>
|
|
From: Gary Y. <gar...@ya...> - 2009-05-06 23:36:16
|
Hi David,
I am upgrading Codestriker to 1.9.8. The CHANGELOG says codestriker.pl is auto-generated by the checksetup.pl.
* Codestriker has been modified slightly to support mod_perl under
Apache 2.X. See the README file for more information. To support
Apache 2.X, cgi-bin/codestriker.pl is now auto-generated by the
checksetup.pl script and is no longer included in the distribution.
I cannot find the checksetup.pl. Where is it? The README directed me to the codestriker docs. But, I did not find any checcksetup.pl there. Please help.
Thanks,
Gary
|
|
From: David S. <dav...@gm...> - 2009-05-06 22:15:01
|
This happens when the diff you have loaded in doesn't match the repository associated with the topic. If you have the repository set to your Perforce depot, and the diff text matches the depot path, then those links will become active again. You'll need to create new topics whenever you change the repository string in codestriker.conf. Cheers, David On Thu, May 7, 2009 at 7:56 AM, Gary Yang <gar...@ya...> wrote: > > Hi David, > > > I use Perforce and Codestriker 1.9.6. In the The Codestriker Guide 1.9.5 at the section, 3.5.1. Viewing a Topic. The last paragraph says below: > > Each file is broken up into a series of "deltas". At the head of each delta block, for both the old and new versions of the file, there is an indication of what line number the delta started at. In this situation, clicking on the "Line 24" link on the left hand side, will open a new browser window, which will contain the complete original contents of codestriker/codestriker.pl, anchored at line 24. Clicking on the "Line 22" link on the right hand side will contain the complete contents of codestriker/codestriker.pl will all of the proposed changes applied. > > However, when I clicked on the line number, there is no new browser window opened up. Actually, there is no hyperlink line under the line number. It is different than what I see in the manual. Can you please let me know the reason? > > > Thanks, > > > Gary > > > > > |
|
From: David S. <dav...@gm...> - 2009-05-06 22:12:51
|
Hi Gary, You should be able to accomplish this using topic metrics. Have a look inside codestriker.conf at the bottom, and the metrics definitions in Codestriker.pm. Cheers, David On Thu, May 7, 2009 at 5:20 AM, Gary Yang <gar...@ya...> wrote: > > Hi David, > > Can you please add two columns on the topic? One is Title ID, another is Approved by? > > Here is the reason. > I am going to develop a pre-check in trigger. The user needs to enter the Codestriker title ID and the person’s name who approved this topic when he/she submit the code. The check-in fails if the title ID is not provided in the check-in description, or the title is not approved. Please let me know if you can add those two columns. > > Thanks, > > > Gary > > > > > |
|
From: Gary Y. <gar...@ya...> - 2009-05-06 21:56:26
|
Hi David,
I use Perforce and Codestriker 1.9.6. In the The Codestriker Guide 1.9.5 at the section, 3.5.1. Viewing a Topic. The last paragraph says below:
Each file is broken up into a series of "deltas". At the head of each delta block, for both the old and new versions of the file, there is an indication of what line number the delta started at. In this situation, clicking on the "Line 24" link on the left hand side, will open a new browser window, which will contain the complete original contents of codestriker/codestriker.pl, anchored at line 24. Clicking on the "Line 22" link on the right hand side will contain the complete contents of codestriker/codestriker.pl will all of the proposed changes applied.
However, when I clicked on the line number, there is no new browser window opened up. Actually, there is no hyperlink line under the line number. It is different than what I see in the manual. Can you please let me know the reason?
Thanks,
Gary
|
|
From: Gary Y. <gar...@ya...> - 2009-05-06 19:20:47
|
Hi David,
Can you please add two columns on the topic? One is Title ID, another is Approved by?
Here is the reason.
I am going to develop a pre-check in trigger. The user needs to enter the Codestriker title ID and the person’s name who approved this topic when he/she submit the code. The check-in fails if the title ID is not provided in the check-in description, or the title is not approved. Please let me know if you can add those two columns.
Thanks,
Gary
|
|
From: David S. <dav...@gm...> - 2009-05-05 00:28:45
|
You don't have it since you have only one repository item defined in your codestriker.conf file. Since there is only 1 repository defined, there seems little point in showing it on the create topic page. So basically - its nothing to worry about. Cheers, David On Tue, May 5, 2009 at 10:04 AM, Gary Yang <gar...@ya...> wrote: > > Hi, > > I use Perforce. I configured codestriker.conf below for Perforce. > 'perforce:codestriker:codestriker1234@perforce:1666', > > However, I do not see the repository item when I creating new topic. The Codestriker user’s guide at page 26 (Chapter 3) illustrates that there is repository item I need to enter. Why I do not have it? > > > Thanks, > > > Gary > > > > > > ------------------------------------------------------------------------------ > Register Now & Save for Velocity, the Web Performance & Operations > Conference from O'Reilly Media. Velocity features a full day of > expert-led, hands-on workshops and two days of sessions from industry > leaders in dedicated Performance & Operations tracks. Use code vel09scf > and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > |
|
From: David S. <dav...@gm...> - 2009-05-05 00:27:41
|
It means bug ID 6401 does not exist in that specific Bugzilla database you have connected to (0 rows returned, instead of 1). Is it possible you have more than one Bugzilla instance, and you have connected to the wrong one? That is what seems to be happening. Cheers, David On Tue, May 5, 2009 at 7:54 AM, Gary Yang <gar...@ya...> wrote: > > David, > > I got the output below. But, I do not know what it means. Any idea? > > mysql> SELECT COUNT(*) FROM bugs WHERE bug_id = 6401; > +----------+ > | COUNT(*) | > +----------+ > | 0 | > +----------+ > 1 row in set (0.05 sec) > > > Thanks. > > > --- On Sun, 5/3/09, David Sitsky <dav...@gm...> wrote: > >> From: David Sitsky <dav...@gm...> >> Subject: Re: [Codestriker-user] Problems on integration of CodeStriker and Bugzilla >> To: "Gary Yang" <gar...@ya...> >> Cc: cod...@li... >> Date: Sunday, May 3, 2009, 6:12 PM >> Hi Gary, >> >> For Bugzilla, the check for the existence of a specific bug >> just runs >> the following query, and checks it is not equal to 0: >> >> SELECT COUNT(*) FROM bugs WHERE bug_id = ? >> >> Since you have already reached this part in the code, I >> would assume >> that Codestriker has already connected to your Bugzilla >> database. The >> only thing I can think of is some obscure mysql permissions >> getting in >> the way. >> >> On the same machine that Codestriker runs from, try >> connecting to the >> Bugzilla database using the mysql command-line tool to see >> if you can >> run the query: >> >> SELECT COUNT(*) FROM bugs WHERE bug_id = 6401 >> >> Hopefully that will show what the issue might be? >> >> Cheers, >> David >> >> On Sat, May 2, 2009 at 10:36 AM, Gary Yang <gar...@ya...> >> wrote: >> > >> > Hi, >> > >> > There is a bug ID, 6401 in Bugzilla. However, I got >> errors when I create a topic in CodeStriker. Can someone >> tell me what are the possible reasons? >> > >> > Error: >> > Bug ID 6401 does not exist. >> > For security reasons, please re-enter the file name to >> upload, if required. >> > >> > codestriker.conf: >> > >> > # Bug database connection details. >> > $bug_db = 'bugzilla'; >> > $bug_db_host = 'sdcrevc04'; >> > $bug_db_name = 'bugs'; >> > $bug_db_password = 'bug4adm'; >> > $bug_db_dbname = 'bugs'; >> > >> > $bugtracker = 'http://sdcrevc04.company.com:8080/bugzilla/show_bug.cgi?id='; >> > >> > Thanks, >> > >> > >> > Gary >> > >> > >> > >> > >> > >> > >> ------------------------------------------------------------------------------ >> > Register Now & Save for Velocity, the Web >> Performance & Operations >> > Conference from O'Reilly Media. Velocity features a >> full day of >> > expert-led, hands-on workshops and two days of >> sessions from industry >> > leaders in dedicated Performance & Operations >> tracks. Use code vel09scf >> > and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf >> > _______________________________________________ >> > Codestriker-user mailing list >> > Cod...@li... >> > https://lists.sourceforge.net/lists/listinfo/codestriker-user >> > >> > > > > |
|
From: Gary Y. <gar...@ya...> - 2009-05-05 00:05:01
|
Hi,
I use Perforce. I configured codestriker.conf below for Perforce.
'perforce:codestriker:codestriker1234@perforce:1666',
However, I do not see the repository item when I creating new topic. The Codestriker user’s guide at page 26 (Chapter 3) illustrates that there is repository item I need to enter. Why I do not have it?
Thanks,
Gary
|
|
From: Gary Y. <gar...@ya...> - 2009-05-04 21:58:26
|
Here are more info: mysql> SELECT COUNT(*) FROM bugs; +----------+ | COUNT(*) | +----------+ | 4372 | +----------+ 1 row in set (0.03 sec) mysql> describe bugs; +---------------------+--------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +---------------------+--------------+------+-----+---------+----------------+ | bug_id | mediumint(9) | NO | PRI | NULL | auto_increment | | assigned_to | mediumint(9) | NO | MUL | 0 | | | bug_file_loc | text | YES | | NULL | | | bug_severity | varchar(64) | NO | MUL | NULL | | | bug_status | varchar(64) | NO | MUL | NULL | | | creation_ts | datetime | YES | MUL | NULL | | | delta_ts | datetime | NO | MUL | NULL | | | short_desc | varchar(255) | NO | | NULL | | | op_sys | varchar(64) | NO | MUL | NULL | | | priority | varchar(64) | NO | MUL | NULL | | | product_id | smallint(6) | NO | MUL | 0 | | | rep_platform | varchar(64) | NO | | NULL | | | reporter | mediumint(9) | NO | MUL | 0 | | | version | varchar(64) | NO | MUL | NULL | | | component_id | smallint(6) | NO | MUL | 0 | | | resolution | varchar(64) | NO | MUL | NULL | | | target_milestone | varchar(20) | NO | MUL | --- | | | qa_contact | mediumint(9) | YES | MUL | NULL | | | status_whiteboard | mediumtext | NO | | NULL | | | votes | mediumint(9) | NO | MUL | 0 | | | keywords | mediumtext | NO | | NULL | | | lastdiffed | datetime | YES | | NULL | | | everconfirmed | tinyint(4) | NO | | 0 | | | reporter_accessible | tinyint(4) | NO | | 1 | | | cclist_accessible | tinyint(4) | NO | | 1 | | | estimated_time | decimal(5,2) | NO | | 0.00 | | | remaining_time | decimal(5,2) | NO | | 0.00 | | | alias | varchar(20) | YES | UNI | NULL | | | deadline | datetime | YES | | NULL | | | cf_reflib | varchar(132) | NO | | --- | | | cf_revision | varchar(255) | YES | | NULL | | | cf_version | varchar(255) | YES | | NULL | | +---------------------+--------------+------+-----+---------+----------------+ 32 rows in set (0.99 sec) --- On Mon, 5/4/09, Gary Yang <gar...@ya...> wrote: > From: Gary Yang <gar...@ya...> > Subject: Re: [Codestriker-user] Problems on integration of CodeStriker and Bugzilla > To: "David Sitsky" <dav...@gm...> > Cc: cod...@li... > Date: Monday, May 4, 2009, 2:54 PM > > David, > > I got the output below. But, I do not know what it means. > Any idea? > > mysql> SELECT COUNT(*) FROM bugs WHERE bug_id = 6401; > +----------+ > | COUNT(*) | > +----------+ > | 0 | > +----------+ > 1 row in set (0.05 sec) > > > Thanks. > > > --- On Sun, 5/3/09, David Sitsky <dav...@gm...> > wrote: > > > From: David Sitsky <dav...@gm...> > > Subject: Re: [Codestriker-user] Problems on > integration of CodeStriker and Bugzilla > > To: "Gary Yang" <gar...@ya...> > > Cc: cod...@li... > > Date: Sunday, May 3, 2009, 6:12 PM > > Hi Gary, > > > > For Bugzilla, the check for the existence of a > specific bug > > just runs > > the following query, and checks it is not equal to 0: > > > > SELECT COUNT(*) FROM bugs WHERE bug_id = ? > > > > Since you have already reached this part in the code, > I > > would assume > > that Codestriker has already connected to your > Bugzilla > > database. The > > only thing I can think of is some obscure mysql > permissions > > getting in > > the way. > > > > On the same machine that Codestriker runs from, try > > connecting to the > > Bugzilla database using the mysql command-line tool to > see > > if you can > > run the query: > > > > SELECT COUNT(*) FROM bugs WHERE bug_id = 6401 > > > > Hopefully that will show what the issue might be? > > > > Cheers, > > David > > > > On Sat, May 2, 2009 at 10:36 AM, Gary Yang <gar...@ya...> > > wrote: > > > > > > Hi, > > > > > > There is a bug ID, 6401 in Bugzilla. However, I > got > > errors when I create a topic in CodeStriker. Can > someone > > tell me what are the possible reasons? > > > > > > Error: > > > Bug ID 6401 does not exist. > > > For security reasons, please re-enter the file > name to > > upload, if required. > > > > > > codestriker.conf: > > > > > > # Bug database connection details. > > > $bug_db = 'bugzilla'; > > > $bug_db_host = 'sdcrevc04'; > > > $bug_db_name = 'bugs'; > > > $bug_db_password = 'bug4adm'; > > > $bug_db_dbname = 'bugs'; > > > > > > $bugtracker = 'http://sdcrevc04.company.com:8080/bugzilla/show_bug.cgi?id='; > > > > > > Thanks, > > > > > > > > > Gary > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Register Now & Save for Velocity, the Web > > Performance & Operations > > > Conference from O'Reilly Media. Velocity features > a > > full day of > > > expert-led, hands-on workshops and two days of > > sessions from industry > > > leaders in dedicated Performance & > Operations > > tracks. Use code vel09scf > > > and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf > > > _______________________________________________ > > > Codestriker-user mailing list > > > Cod...@li... > > > https://lists.sourceforge.net/lists/listinfo/codestriker-user > > > > > > > > > > ------------------------------------------------------------------------------ > Register Now & Save for Velocity, the Web Performance > & Operations > Conference from O'Reilly Media. Velocity features a full > day of > expert-led, hands-on workshops and two days of sessions > from industry > leaders in dedicated Performance & Operations tracks. > Use code vel09scf > and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > |
|
From: Gary Y. <gar...@ya...> - 2009-05-04 21:54:11
|
David, I got the output below. But, I do not know what it means. Any idea? mysql> SELECT COUNT(*) FROM bugs WHERE bug_id = 6401; +----------+ | COUNT(*) | +----------+ | 0 | +----------+ 1 row in set (0.05 sec) Thanks. --- On Sun, 5/3/09, David Sitsky <dav...@gm...> wrote: > From: David Sitsky <dav...@gm...> > Subject: Re: [Codestriker-user] Problems on integration of CodeStriker and Bugzilla > To: "Gary Yang" <gar...@ya...> > Cc: cod...@li... > Date: Sunday, May 3, 2009, 6:12 PM > Hi Gary, > > For Bugzilla, the check for the existence of a specific bug > just runs > the following query, and checks it is not equal to 0: > > SELECT COUNT(*) FROM bugs WHERE bug_id = ? > > Since you have already reached this part in the code, I > would assume > that Codestriker has already connected to your Bugzilla > database. The > only thing I can think of is some obscure mysql permissions > getting in > the way. > > On the same machine that Codestriker runs from, try > connecting to the > Bugzilla database using the mysql command-line tool to see > if you can > run the query: > > SELECT COUNT(*) FROM bugs WHERE bug_id = 6401 > > Hopefully that will show what the issue might be? > > Cheers, > David > > On Sat, May 2, 2009 at 10:36 AM, Gary Yang <gar...@ya...> > wrote: > > > > Hi, > > > > There is a bug ID, 6401 in Bugzilla. However, I got > errors when I create a topic in CodeStriker. Can someone > tell me what are the possible reasons? > > > > Error: > > Bug ID 6401 does not exist. > > For security reasons, please re-enter the file name to > upload, if required. > > > > codestriker.conf: > > > > # Bug database connection details. > > $bug_db = 'bugzilla'; > > $bug_db_host = 'sdcrevc04'; > > $bug_db_name = 'bugs'; > > $bug_db_password = 'bug4adm'; > > $bug_db_dbname = 'bugs'; > > > > $bugtracker = 'http://sdcrevc04.company.com:8080/bugzilla/show_bug.cgi?id='; > > > > Thanks, > > > > > > Gary > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > Register Now & Save for Velocity, the Web > Performance & Operations > > Conference from O'Reilly Media. Velocity features a > full day of > > expert-led, hands-on workshops and two days of > sessions from industry > > leaders in dedicated Performance & Operations > tracks. Use code vel09scf > > and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf > > _______________________________________________ > > Codestriker-user mailing list > > Cod...@li... > > https://lists.sourceforge.net/lists/listinfo/codestriker-user > > > |
|
From: Sunil G. <sg...@ma...> - 2009-05-04 12:42:00
|
Ah, I'm using it in a Subversion post-commit hook. I've changed the URL there, and it now works as expected. Many thanks. -- sg David Sitsky wrote: > The URL it is using is whatever was used to access Codestriker in the > first place. If you access it as http://codestriker.myhost.com, then > all should be well.. > > Is that not the case? > > On Fri, May 1, 2009 at 4:18 AM, Sunil Gupta <sg...@ma...> wrote: > >> I've set up codestriker to populate buzilla with comments. >> The problem I'm experiencing is with the topic link URL >> back to codestriker. I get the following: >> >> Codestriker topic: >> http://localhost/codestriker/codestriker.pl?action=view&topic=5522929 >> <http://localhost/codestriker/codestriker.pl?action=view&topic=5522929> >> created. >> >> The host in the URL is being set to "localhost" no matter >> what I do. I'm not sure where codestriker is getting the >> hostname from (it's not the bugzilla hostname). Any clue >> as to how to set this to "codestriker.mydomain.com" would >> be appreciated. >> >> ------------------------------------------------------------------------------ >> Register Now & Save for Velocity, the Web Performance & Operations >> Conference from O'Reilly Media. Velocity features a full day of >> expert-led, hands-on workshops and two days of sessions from industry >> leaders in dedicated Performance & Operations tracks. Use code vel09scf >> and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf >> _______________________________________________ >> Codestriker-user mailing list >> Cod...@li... >> https://lists.sourceforge.net/lists/listinfo/codestriker-user >> >> |
|
From: David S. <dav...@gm...> - 2009-05-04 01:17:15
|
> We use Perforce. We want users to use CodeStriker to review their code before submission. Something like after the topic is reviewed and approved, then the developer is allowed to submit his code. Or, at least there is a CodeStriker ID exist for his code. Then he can submit his code into Perforce. Can someone tell me how to do that? I'm not sure exactly what it is you are asking.. but there is no way you can use Codestriker to prevent users from committing in code, other than through agreements within your team. In theory, you could possibly write an SCM hook pre-commit to check that the topic ID they have entered in the SCM comment is in the appropriate state, but I'm not sure if that's worth the trouble. You can use a system like Codestriker + Bugzilla + ScmBug together to provide more glue - in a sense, the Bugzilla ID becomes the ID you are after. We use ScmBug here at my work. It has issues with moved files under Subversion, but it seems to work reasonably well. Cheers, David |
|
From: David S. <dav...@gm...> - 2009-05-04 01:12:15
|
Hi Gary, For Bugzilla, the check for the existence of a specific bug just runs the following query, and checks it is not equal to 0: SELECT COUNT(*) FROM bugs WHERE bug_id = ? Since you have already reached this part in the code, I would assume that Codestriker has already connected to your Bugzilla database. The only thing I can think of is some obscure mysql permissions getting in the way. On the same machine that Codestriker runs from, try connecting to the Bugzilla database using the mysql command-line tool to see if you can run the query: SELECT COUNT(*) FROM bugs WHERE bug_id = 6401 Hopefully that will show what the issue might be? Cheers, David On Sat, May 2, 2009 at 10:36 AM, Gary Yang <gar...@ya...> wrote: > > Hi, > > There is a bug ID, 6401 in Bugzilla. However, I got errors when I create a topic in CodeStriker. Can someone tell me what are the possible reasons? > > Error: > Bug ID 6401 does not exist. > For security reasons, please re-enter the file name to upload, if required. > > codestriker.conf: > > # Bug database connection details. > $bug_db = 'bugzilla'; > $bug_db_host = 'sdcrevc04'; > $bug_db_name = 'bugs'; > $bug_db_password = 'bug4adm'; > $bug_db_dbname = 'bugs'; > > $bugtracker = 'http://sdcrevc04.company.com:8080/bugzilla/show_bug.cgi?id='; > > Thanks, > > > Gary > > > > > > ------------------------------------------------------------------------------ > Register Now & Save for Velocity, the Web Performance & Operations > Conference from O'Reilly Media. Velocity features a full day of > expert-led, hands-on workshops and two days of sessions from industry > leaders in dedicated Performance & Operations tracks. Use code vel09scf > and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > |
|
From: Gary Y. <gar...@ya...> - 2009-05-02 00:42:31
|
Hi,
We use Perforce. We want users to use CodeStriker to review their code before submission. Something like after the topic is reviewed and approved, then the developer is allowed to submit his code. Or, at least there is a CodeStriker ID exist for his code. Then he can submit his code into Perforce. Can someone tell me how to do that?
Thanks,
Gary
|
|
From: Gary Y. <gar...@ya...> - 2009-05-02 00:36:35
|
Hi, There is a bug ID, 6401 in Bugzilla. However, I got errors when I create a topic in CodeStriker. Can someone tell me what are the possible reasons? Error: Bug ID 6401 does not exist. For security reasons, please re-enter the file name to upload, if required. codestriker.conf: # Bug database connection details. $bug_db = 'bugzilla'; $bug_db_host = 'sdcrevc04'; $bug_db_name = 'bugs'; $bug_db_password = 'bug4adm'; $bug_db_dbname = 'bugs'; $bugtracker = 'http://sdcrevc04.company.com:8080/bugzilla/show_bug.cgi?id='; Thanks, Gary |
|
From: David S. <dav...@gm...> - 2009-04-30 22:51:05
|
The URL it is using is whatever was used to access Codestriker in the first place. If you access it as http://codestriker.myhost.com, then all should be well.. Is that not the case? On Fri, May 1, 2009 at 4:18 AM, Sunil Gupta <sg...@ma...> wrote: > I've set up codestriker to populate buzilla with comments. > The problem I'm experiencing is with the topic link URL > back to codestriker. I get the following: > > Codestriker topic: > http://localhost/codestriker/codestriker.pl?action=view&topic=5522929 > <http://localhost/codestriker/codestriker.pl?action=view&topic=5522929> > created. > > The host in the URL is being set to "localhost" no matter > what I do. I'm not sure where codestriker is getting the > hostname from (it's not the bugzilla hostname). Any clue > as to how to set this to "codestriker.mydomain.com" would > be appreciated. > > ------------------------------------------------------------------------------ > Register Now & Save for Velocity, the Web Performance & Operations > Conference from O'Reilly Media. Velocity features a full day of > expert-led, hands-on workshops and two days of sessions from industry > leaders in dedicated Performance & Operations tracks. Use code vel09scf > and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > |
|
From: Sunil G. <sg...@ma...> - 2009-04-30 18:31:16
|
I've set up codestriker to populate buzilla with comments. The problem I'm experiencing is with the topic link URL back to codestriker. I get the following: Codestriker topic: http://localhost/codestriker/codestriker.pl?action=view&topic=5522929 <http://localhost/codestriker/codestriker.pl?action=view&topic=5522929> created. The host in the URL is being set to "localhost" no matter what I do. I'm not sure where codestriker is getting the hostname from (it's not the bugzilla hostname). Any clue as to how to set this to "codestriker.mydomain.com" would be appreciated. |
|
From: David S. <dav...@gm...> - 2009-04-15 06:28:30
|
This is a limitation of the Perforce diff commands. Unlike most SCM systems, they didn't have any way of included the added file's text to diff. If there is a way of doing it now - please let me know. Cheers, David On Mon, Apr 13, 2009 at 7:54 PM, Raja Gopal Chowdary Nutheti <rgc...@gm...> wrote: > Hi , > How can i create code review for the change list [ perforce ] it contains > some newly added files ? > Thanks & Regards, > Raja. |
|
From: Kenneth W. <ken...@gm...> - 2009-03-23 03:13:31
|
Hi David; Thank you so much for your reply. I will be using this quite a bit from now on. Thanks, Ken Wolcott On Sun, Mar 22, 2009 at 15:27, David Sitsky <dav...@gm...> wrote: > Hi Ken, > > > How should I compose the diff such that Codestriker will recognize and > > display a diff between "a" and "b" just like it does normally? > > Just use the regular diff command on these two files, eg: > > diff a.txt b.txt > output.txt > > You can then load output.txt as your review topic. > > > Secondly how should I concatenate the output of several of such paired > diffs > > such that Codestriker will display each filename and the associated > > differences side-by-side? > > diff a1.txt b1.txt > output1.txt > diff a2.txt b2.txt > output2.txt > diff a3.txt b3.txt > output3.txt > > cat output1.txt output2.txt output3.txt > output.txt > > The output.txt file will then have the concatenation of all diffs in a > single file, which you can then upload to Codestriker as a single > review. > > Cheers, > David > |
|
From: David S. <dav...@gm...> - 2009-03-22 22:27:30
|
Hi Ken, > How should I compose the diff such that Codestriker will recognize and > display a diff between "a" and "b" just like it does normally? Just use the regular diff command on these two files, eg: diff a.txt b.txt > output.txt You can then load output.txt as your review topic. > Secondly how should I concatenate the output of several of such paired diffs > such that Codestriker will display each filename and the associated > differences side-by-side? diff a1.txt b1.txt > output1.txt diff a2.txt b2.txt > output2.txt diff a3.txt b3.txt > output3.txt cat output1.txt output2.txt output3.txt > output.txt The output.txt file will then have the concatenation of all diffs in a single file, which you can then upload to Codestriker as a single review. Cheers, David |
|
From: Kenneth W. <ken...@gm...> - 2009-03-20 22:31:15
|
Hi; We have a situation where file "a" and file "b" differ slightly. Sometimes a very significant and pertinent change also occurs between file "c" and file "d". Normally I see cvs diff between a checked-in version and a modified version being the components of the topic text. How should I compose the diff such that Codestriker will recognize and display a diff between "a" and "b" just like it does normally? Secondly how should I concatenate the output of several of such paired diffs such that Codestriker will display each filename and the associated differences side-by-side? I have tried using "sdiff -s a b" but this doesn't work very well. Suggestions/Advice/Enhancement please. Thanks, Ken Wolcott |
|
From: David S. <dav...@gm...> - 2009-03-18 00:32:13
|
On Wed, Mar 18, 2009 at 11:20 AM, Hernandez, Jim (NSN - US/Boca Raton) <jim...@ns...> wrote: > I'm having a problem with MySQL error that pops up during regular use: > DBD::mysql::st execute failed: The table 'delta' is full > DBD::mysql::st execute failed: The table 'topicfile' is full at > DBD::mysql::st execute failed: The table 'commentstatehistory' is full > There is plenty of space on the server so I'm not out of disk space and the > database is only about 100M. I'm not a MySQL expert so I'm no sure if > configuration is sufficient for CodeStriker. I'm using MySQL 4.1.20 and > Codestriker 1.9.6. Has anyone seen this error before? I haven't seen this before... it does sound like a MySQL configuration issue to me. I can only suggest googling for the issue, unless somebody else knows what it might be? Cheers, David |
|
From: Hernandez, J. (N. - US/B. Raton) <jim...@ns...> - 2009-03-18 00:20:57
|
I'm having a problem with MySQL error that pops up during regular use: DBD::mysql::st execute failed: The table 'delta' is full DBD::mysql::st execute failed: The table 'topicfile' is full at DBD::mysql::st execute failed: The table 'commentstatehistory' is full There is plenty of space on the server so I'm not out of disk space and the database is only about 100M. I'm not a MySQL expert so I'm no sure if configuration is sufficient for CodeStriker. I'm using MySQL 4.1.20 and Codestriker 1.9.6. Has anyone seen this error before? Thanks. __________________________________________________ Jim Hernandez |
|
From: Eugene G. <mi...@ke...> - 2009-03-03 15:24:39
|
Hi.
I took your advice and switched to commit-email-codestriker.pl. However,
I've noticed that there seems to be a bug in it with regard to BUG ids
(ironically enough).
The file contains the following lines
# Check for any matching Bug id text.
my @bugs = ();
$bug_ids =~ s/.*[Bb][Uu][Gg]:?(\d+)\b.*/$1 /g;
while ($bug_ids =~ /\b[Bb][Uu][Gg]:?\s*(\d+)\b/g)
{
push @bugs, $1;
}
The line beginning "$bug_ids=~" seems to break the parsing of the the bug
identifiers. Removing it fixes the problem.
My exposure to the usage of regular expressions is pretty limited (Mastering
Regular Expressions by Jeffrey Friedl is now on order).
I'm using TortoiseSVN and I would like to parse the commit message so that
it could pick out multiple bug identifiers in the format used by Tortoise
when the "bugtraq:number" property is set (i.e. expressions containing comma
separated ids). So I would want ot parse a string like "this fixes
bug:2,34,55". Ultimately, I guess it would be cool if it could parse a
string like "this fixes BUGs 3,44, 55 and bug:99, not forgetting bug11 and
14".
Regards
Eugene
2009/3/1 David Sitsky <dav...@gm...>
> Well I think I just embarrassed myself... pop/push actually do work on
> the end of the list, not the start! My bad.
>
> I must admit, I actually haven't used subversion-post-commit.pl in a
> while. I have been using commit-email-codestriker.pl instead, which
> is based off Subversion's post-commit script. This is why this script
> is currently broken. I actually prefer the other script, as it sends
> an email out with the diff text, and a link to the new topic.
>
> So yes - those "pop" calls should really be "shift". And you are
> right, we need 'topic_state
> > => "Open"' now in the CodestrikerClient call, as that was added recently.
>
> Thanks for the report, I'll fix up this old script.
>
> Cheers,
> David
>
> On Mon, Mar 2, 2009 at 8:26 AM, Eugene Gill <mi...@ke...> wrote:
> > Hi.
> >
> > Far be it for me, to contradict you on this, I'm no perl expert. but I
> can
> > only tell you my experience of trying to set this up earlier today.
> >
> > If I call the script directly, like below, I get the following:
> >
> > sunny-jim bin # ./subversion-post-commit.pl
> > /var/svn/svn.keergill.com/jetbyte 17
> >
> > ...
> > <title>Codestriker error</title>
> > ...
> > <body bgcolor="white">
> > <p /><FONT COLOR='red'>Input parameter email has invalid value:
> > ./subversion-post-commit.pl: `/usr/bin/svnlook info 17 -r
> > /var/svn/svn.keergill.com/jetbyte' failed with this
> > output:@keergill.com <output%3A...@ke...></FONT><p />
> > </body>
> > ...
> >
> > Clearly from the error message its trying to apply the repository value
> to
> > the revision number parameter because its pulling off the parameters in
> the
> > reverse order to that expected by the code.
> >
> > If I then reverse the parameters, I get the following
> >
> > sunny-jim bin # ./subversion-post-commit.pl 17
> > /var/svn/svn.keergill.com/jetbyte
> >
> > ...
> > <title>Codestriker error</title>
> > ...
> > <body bgcolor="white">
> > <p /><FONT COLOR='red'>Topic state unrecognised</FONT><p />
> > </body>
> > ...
> >
> > So now I find that the call to CodestrikerClient::create_topic is failing
> > because the topic_state parameter is not initialised. If I add
> 'topic_state
> > => "Open"' to the parameter list on the call to create_topic everything
> > works hunky dory (at least on first inspection, I haven't tried the
> script
> > in the subversion post-commit hook again yet.
> >
> > Regards
> >
> > Eugene Gill
> >
> >
> >
> > 2009/3/1 David Sitsky <dav...@gm...>
> >>
> >> Hi Eugene,
> >>
> >> I use this scripts at my work, so they work fine.
> >>
> >> The push and pop operators in perl work more in the metaphor of a
> >> stack, not a list. So pop removes the first element from the list, not
> >> the last.
> >>
> >> Cheers,
> >> David
> >>
> >> On Mon, Mar 2, 2009 at 2:10 AM, Eugene Gill <mi...@ke...>
> wrote:
> >> > Hi.
> >> >
> >> > I'm just in the process of trying to set up Codestriker to
> automatically
> >> > generate reviews for SVN commits and am looking at this script. Has it
> >> > actually been tested?
> >> >
> >> > The following lines pop the command line arguments off from the end of
> >> > the
> >> > list and therefore in the opposite order to that suggested in the
> >> > comment
> >> > and the documentation.
> >> >
> >> > # First argument is the repository followed by the revision number.
> >> > my $repository = pop @ARGV;
> >> > my $revision = pop @ARGV;
> >> >
> >> > Apologies if I'm being somehow stupid, but it surprises me that this
> has
> >> > gone unspotted until now.
> >> >
> >> > Eugene
> >> >
> >> >
> >> >
> >> >
> >> >
> >> >
> >> >
> >> >
> ------------------------------------------------------------------------------
> >> > Open Source Business Conference (OSBC), March 24-25, 2009, San
> >> > Francisco, CA
> >> > -OSBC tackles the biggest issue in open source: Open Sourcing the
> >> > Enterprise
> >> > -Strategies to boost innovation and cut costs with open source
> >> > participation
> >> > -Receive a $600 discount off the registration fee with the source
> code:
> >> > SFAD
> >> > http://p.sf.net/sfu/XcvMzF8H
> >> > _______________________________________________
> >> > Codestriker-user mailing list
> >> > Cod...@li...
> >> > https://lists.sourceforge.net/lists/listinfo/codestriker-user
> >> >
> >> >
> >
> >
>
|