codestriker-user Mailing List for Codestriker: collaborative code reviewer (Page 10)
Brought to you by:
sits
Menu
▾
▴
codestriker-user — Discussion of any issue to do with Codestriker
You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(12) |
Jun
|
Jul
|
Aug
(2) |
Sep
|
Oct
|
Nov
|
Dec
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
|
Feb
|
Mar
(1) |
Apr
(6) |
May
(3) |
Jun
(1) |
Jul
|
Aug
(9) |
Sep
(2) |
Oct
(2) |
Nov
(8) |
Dec
(6) |
| 2004 |
Jan
(12) |
Feb
(19) |
Mar
(2) |
Apr
(2) |
May
(4) |
Jun
(11) |
Jul
|
Aug
(14) |
Sep
(4) |
Oct
(27) |
Nov
(4) |
Dec
(22) |
| 2005 |
Jan
(14) |
Feb
(2) |
Mar
(11) |
Apr
(3) |
May
(14) |
Jun
(60) |
Jul
(58) |
Aug
(76) |
Sep
(72) |
Oct
(59) |
Nov
|
Dec
(4) |
| 2006 |
Jan
(1) |
Feb
(5) |
Mar
(13) |
Apr
(11) |
May
(30) |
Jun
(17) |
Jul
(18) |
Aug
(39) |
Sep
|
Oct
|
Nov
|
Dec
(17) |
| 2007 |
Jan
(18) |
Feb
(5) |
Mar
(20) |
Apr
(2) |
May
(3) |
Jun
(13) |
Jul
(11) |
Aug
(4) |
Sep
(6) |
Oct
(9) |
Nov
(3) |
Dec
|
| 2008 |
Jan
(10) |
Feb
|
Mar
(5) |
Apr
|
May
|
Jun
(9) |
Jul
(10) |
Aug
(10) |
Sep
(13) |
Oct
(34) |
Nov
(12) |
Dec
(8) |
| 2009 |
Jan
(4) |
Feb
(11) |
Mar
(12) |
Apr
(3) |
May
(36) |
Jun
(4) |
Jul
(11) |
Aug
(12) |
Sep
(25) |
Oct
(13) |
Nov
(9) |
Dec
|
| 2010 |
Jan
|
Feb
(12) |
Mar
(6) |
Apr
(10) |
May
(12) |
Jun
|
Jul
(4) |
Aug
(9) |
Sep
(12) |
Oct
(3) |
Nov
(6) |
Dec
(3) |
| 2011 |
Jan
(2) |
Feb
(1) |
Mar
(3) |
Apr
(5) |
May
(3) |
Jun
(8) |
Jul
|
Aug
(14) |
Sep
|
Oct
(3) |
Nov
(1) |
Dec
|
| 2012 |
Jan
(2) |
Feb
(10) |
Mar
(4) |
Apr
(3) |
May
(2) |
Jun
(5) |
Jul
|
Aug
(3) |
Sep
|
Oct
(2) |
Nov
(4) |
Dec
(2) |
| 2013 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(4) |
Jun
|
Jul
|
Aug
|
Sep
(2) |
Oct
(1) |
Nov
|
Dec
(2) |
| 2014 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: David C. <dcc...@gm...> - 2009-07-11 04:00:17
|
I've got a strange problem with my new installation. (This is my first attempt at an SVN installation.) The Topic Text window shows no text from the diff in the side-by-side windows. Instead, the only thing there is a link to the main page, something like this: Line 173 | Parallel Line 173 | Parallel 173 173 174 174 Codestriker 1.9.6 - Topic Details 175 Codestriker 1.9.6 - Topic Details 175 176 176 177 177 178 178 Codestriker 1.9.6 - Topic Details And, yes, the links do take you back to the main Topic List page. I've checked: - uploaded text diff in the db, looks good - viewvc URL in conf, looks good - alias in Apache conf, looks good If I view page source, the .css URLs look OK. I don't know what to look for. Any ideas? David |
|
From: David S. <dav...@gm...> - 2009-06-25 09:36:17
|
Hi Nilesh, Please email me (don't bother the list) the topic text that you are uploading and your codestriker.conf file so I can see what you are doing. Cheers, David On Thu, Jun 25, 2009 at 6:32 PM, Kathole, Nilesh<Nil...@li...> wrote: > Hi, > I am able to fix the problem regarding configuration of my e-mail through codestriker. But I am having certain doubts regarding the reviewing of the code by comparing the file differences. Presently as I explained earlier I am not able to get any text highlighting for the code difference. If I change the status of the code to 'Commited' then I am not able to give comment if I want to. The other thing is can I re-upload the file after doing changes to it as mentioned in code review and re-upload that file and submit again the newer version for code review. Is there any option available here. I am getting confused. Please let me know the solution. > > Thanks & Regards, > Nilesh Kathole > Software Engineer > > > -----Original Message----- > From: David Sitsky [mailto:dav...@gm...] > Sent: 24 June 2009 03:42 > To: Kathole, Nilesh > Cc: cod...@li... > Subject: Re: Problem with e-mail and Code Difference in CodeSTriker > > Hi Nilesh, > > Read the manual on how you create topic text. You use your SCM system > to create a diff file, then upload that into Codestriker. It will > handle the "colours" showing changes properly. > > For syntax highlighting.. check the codestriker.conf file for more details. > > Cheers, > David > > On Tue, Jun 23, 2009 at 8:17 PM, Kathole, > Nilesh<Nil...@li...> wrote: >> Hi, >> Thanks for your response. I have attached screenshots of the topics. As seen I am not able to see any highlighting colour for the code in the topic. No hyperlinks colours are displayed. I have tried uploading the CodeStriker.pl as given in the screenshot of the configuration for CodeStriker but it is behaving the same manner. I want to make it clear whether some more configuration is required in order to display the colour highlighting the code change. >> >> Thanks & Regards, >> Nilesh Kathole >> Software Engineer >> >> >> -----Original Message----- >> From: David Sitsky [mailto:dav...@gm...] >> Sent: 23 June 2009 12:06 >> To: Kathole, Nilesh >> Cc: cod...@li... >> Subject: Re: Problem with e-mail and Code Difference in CodeSTriker >> >>> I have configured CodeStriker on my machine. But when I >>> create a new user the mail is not sent. It is giving some error as Bad File >>> at AddUser.pm at line 88.Also when I create a Topic for Review I am not able >> >> This possibly means your web-server can't open a SMTP connection to >> your specified mail server. Check that your $mailhost set in >> codestriker.conf is correct, and that a firewall isn't getting in the >> way, blocking the connection. >> >>> to see the highlighting of changed text nor any colour for the file and text >>> as provided in documentation for CodeStriker. Can you please explain me the >>> problem for both these issues. Its urgent. >> >> Can you send me the example topic text you uploaded, and a screenshot? >> >> Cheers, >> David >> >> > > > |
|
From: David S. <dav...@gm...> - 2009-06-23 22:12:06
|
Hi Nilesh, Read the manual on how you create topic text. You use your SCM system to create a diff file, then upload that into Codestriker. It will handle the "colours" showing changes properly. For syntax highlighting.. check the codestriker.conf file for more details. Cheers, David On Tue, Jun 23, 2009 at 8:17 PM, Kathole, Nilesh<Nil...@li...> wrote: > Hi, > Thanks for your response. I have attached screenshots of the topics. As seen I am not able to see any highlighting colour for the code in the topic. No hyperlinks colours are displayed. I have tried uploading the CodeStriker.pl as given in the screenshot of the configuration for CodeStriker but it is behaving the same manner. I want to make it clear whether some more configuration is required in order to display the colour highlighting the code change. > > Thanks & Regards, > Nilesh Kathole > Software Engineer > > > -----Original Message----- > From: David Sitsky [mailto:dav...@gm...] > Sent: 23 June 2009 12:06 > To: Kathole, Nilesh > Cc: cod...@li... > Subject: Re: Problem with e-mail and Code Difference in CodeSTriker > >> I have configured CodeStriker on my machine. But when I >> create a new user the mail is not sent. It is giving some error as Bad File >> at AddUser.pm at line 88.Also when I create a Topic for Review I am not able > > This possibly means your web-server can't open a SMTP connection to > your specified mail server. Check that your $mailhost set in > codestriker.conf is correct, and that a firewall isn't getting in the > way, blocking the connection. > >> to see the highlighting of changed text nor any colour for the file and text >> as provided in documentation for CodeStriker. Can you please explain me the >> problem for both these issues. Its urgent. > > Can you send me the example topic text you uploaded, and a screenshot? > > Cheers, > David > > |
|
From: David S. <dav...@gm...> - 2009-06-23 06:36:40
|
> I have configured CodeStriker on my machine. But when I > create a new user the mail is not sent. It is giving some error as Bad File > at AddUser.pm at line 88.Also when I create a Topic for Review I am not able This possibly means your web-server can't open a SMTP connection to your specified mail server. Check that your $mailhost set in codestriker.conf is correct, and that a firewall isn't getting in the way, blocking the connection. > to see the highlighting of changed text nor any colour for the file and text > as provided in documentation for CodeStriker. Can you please explain me the > problem for both these issues. Its urgent. Can you send me the example topic text you uploaded, and a screenshot? Cheers, David |
|
From: David S. <dav...@gm...> - 2009-06-20 05:00:05
|
Hi Raghavendra > Code striker is a really helpful tool. It speeds up our review by > bringing in everything with in the same window. > But, while creating a topic if we wish to include more than a single > text file, we can't. I think being able group a set of files in to a > topic will be a nice-to-have feature. This is possible already. If you submit a diff/patch file created from your source control system (ie, CVS, Subversion), Codestriker will automatically render multiple files. See the manual for more information, on how topics are created. Cheers, David |
|
From: David S. <dav...@gm...> - 2009-05-29 07:48:30
|
Hi Chirayu, There is no support for it currently, but with your (or your client's) help, its usually not that difficult to implement. I would need some example diff files generated by MKS, which apart from basic changes, also show new/removed files if it supports showing that. Once we have that, we can work on repository integration. I would need to see some command-line examples as to how to retrieve a specific file with a specific version from a MKS repository. Once we have all that - we can just glue it all together. Cheers, David On Fri, May 29, 2009 at 4:12 PM, Chirayu Tailor <chi...@ne...> wrote: > Hi David, > > My client is using MKS Integrity repository software for version > controlling. Now he wants to integrate MKS repository with Code-striker. > Could you please let me know whether codestriker provides support for MKS > repository for not? > > Also if the support is unable for MKS repository then why changes will I > need to make within the existing code-striker code to make it work for MKS > repository. I believe its possible since codestriker is open source. > > Please help me in achieving this task. > > Looking forward for a positive response. > > Thanks in advance. > > Best regards, > > Chirayu |
|
From: David S. <dav...@gm...> - 2009-05-28 22:04:04
|
I've just put out 1.9.9 which fixes this issue, and the MySQL 5.1 issue too. Cheers, David On Wed, May 27, 2009 at 9:11 AM, David Sitsky <dav...@gm...> wrote: > Yes - I have to fix this one - its a regression which came in after a > huge amount of refactoring. > > On Wed, May 27, 2009 at 12:03 AM, Hadianto, Victor > <vic...@cr...> wrote: >> >> Ah found a bug (I think). If I select "Any" on the State field, it only >> shows the "Open" topics. If I select all of them (highlights all the states) >> then it will return me all the states that I want to see. >> >> Cheers, >> Victor >> >> ________________________________ >> From: Hadianto, Victor >> Sent: 26 May 2009 14:16 >> To: cod...@li... >> Subject: [Codestriker-user] Viewing old topics? >> >> >> Hi David, >> >> How do I show old topics? I did a search with State "Any" and Project "Any" >> and it doesn't list all my "Closed" topics. >> >> Regards, >> Victor >> >> ============================================================================== >> Please access the attached hyperlink for an important electronic >> communications disclaimer: >> http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html >> ============================================================================== >> >> ============================================================================== >> Please access the attached hyperlink for an important electronic >> communications disclaimer: >> http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html >> ============================================================================== >> >> ------------------------------------------------------------------------------ >> Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT >> is a gathering of tech-side developers & brand creativity professionals. >> Meet >> the minds behind Google Creative Lab, Visual Complexity, Processing, & >> iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian >> Group, R/GA, & Big Spaceship. http://www.creativitycat.com >> _______________________________________________ >> Codestriker-user mailing list >> Cod...@li... >> https://lists.sourceforge.net/lists/listinfo/codestriker-user >> >> > |
|
From: David S. <dav...@gm...> - 2009-05-26 23:11:06
|
Yes - I have to fix this one - its a regression which came in after a huge amount of refactoring. On Wed, May 27, 2009 at 12:03 AM, Hadianto, Victor <vic...@cr...> wrote: > > Ah found a bug (I think). If I select "Any" on the State field, it only > shows the "Open" topics. If I select all of them (highlights all the states) > then it will return me all the states that I want to see. > > Cheers, > Victor > > ________________________________ > From: Hadianto, Victor > Sent: 26 May 2009 14:16 > To: cod...@li... > Subject: [Codestriker-user] Viewing old topics? > > > Hi David, > > How do I show old topics? I did a search with State "Any" and Project "Any" > and it doesn't list all my "Closed" topics. > > Regards, > Victor > > ============================================================================== > Please access the attached hyperlink for an important electronic > communications disclaimer: > http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html > ============================================================================== > > ============================================================================== > Please access the attached hyperlink for an important electronic > communications disclaimer: > http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html > ============================================================================== > > ------------------------------------------------------------------------------ > Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT > is a gathering of tech-side developers & brand creativity professionals. > Meet > the minds behind Google Creative Lab, Visual Complexity, Processing, & > iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian > Group, R/GA, & Big Spaceship. http://www.creativitycat.com > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > > |
|
From: Hadianto, V. <vic...@cr...> - 2009-05-26 14:04:15
|
Ah found a bug (I think). If I select "Any" on the State field, it only shows the "Open" topics. If I select all of them (highlights all the states) then it will return me all the states that I want to see. Cheers, Victor ________________________________ From: Hadianto, Victor Sent: 26 May 2009 14:16 To: cod...@li... Subject: [Codestriker-user] Viewing old topics? Hi David, How do I show old topics? I did a search with State "Any" and Project "Any" and it doesn't list all my "Closed" topics. Regards, Victor ======================================================================== ====== Please access the attached hyperlink for an important electronic communications disclaimer: http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html ======================================================================== ====== =============================================================================== Please access the attached hyperlink for an important electronic communications disclaimer: http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html =============================================================================== |
|
From: Hadianto, V. <vic...@cr...> - 2009-05-26 13:16:17
|
Hi David, How do I show old topics? I did a search with State "Any" and Project "Any" and it doesn't list all my "Closed" topics. Regards, Victor =============================================================================== Please access the attached hyperlink for an important electronic communications disclaimer: http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html =============================================================================== |
|
From: Hadianto, V. <vic...@cr...> - 2009-05-26 09:01:02
|
Hi David,
Yes finally using CodeStriker again after all this time :)
Thanks that works. I have to watch out for this maximum allowed packet
in MySQL then.
Cheers,
Victor
-----Original Message-----
From: David Sitsky [mailto:dav...@gm...]
Sent: 26 May 2009 00:17
To: Hadianto, Victor
Cc: cod...@li...
Subject: Re: [Codestriker-user] Installation question: DBD::mysql::db do
failed: SESSION variable 'max_allowed_packet'
Hi Victor,
Nice to hear from you. :)
> DBD::mysql::db do failed: SESSION variable 'max_allowed_packet' is
> read-only. Us e SET GLOBAL to assign the value at C:\Program
> Files\codestriker\codestriker-1.9
> .8/lib/Codestriker/DB/MySQL.pm line 59.
This is the "culprit" line in lib/Codestriker/DB/MySQL.pm:
$dbh->do("SET max_allowed_packet=128000000");
Just comment it out or delete the line. It seems the latest versions of
MySQL doesn't permit this setting anymore. It is there to allow large
topic sizes to be stored in the database, but I believe it has now been
super-seeded by a global setting in the MySQL config file.
Cheers,
David
===============================================================================
Please access the attached hyperlink for an important electronic communications disclaimer:
http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html
===============================================================================
|
|
From: David S. <dav...@gm...> - 2009-05-26 00:06:54
|
Hi Carlo, > one of the things that we need is for the developers to be able to > upload files for review. > This files may not necesarrily come from a code repository but may > come from just plain files. You can do this - just upload the file itself when you create the topic. > If I can upload a file for review, > > Can I upload a bulk file(zip file) for example to be listed for code > review as well. This isn't supported (yet), and probably wouldn't be that hard, however for now you can concatenate several files together using the "cat" command and upload that one file. Supporting zip/tar would be better, since you'd get distinct file entries. Feel free to create a feature request for this. What most users do is they add their new files using their SCM system, then when they run the diff command, it creates a single file, with each file in its own section. > Last is, > > Do you have support for mercurial as our company already has changed > our repository from subversion to mercurial in future projects. Adding a new repository type is actually pretty easy. I am happy to do this if you give me a hand. I don't use mercurial myself, but I'd be keen to support it. Cheers, David |
|
From: David S. <dav...@gm...> - 2009-05-25 23:17:01
|
Hi Victor,
Nice to hear from you. :)
> DBD::mysql::db do failed: SESSION variable 'max_allowed_packet' is
> read-only. Us
> e SET GLOBAL to assign the value at C:\Program
> Files\codestriker\codestriker-1.9
> .8/lib/Codestriker/DB/MySQL.pm line 59.
This is the "culprit" line in lib/Codestriker/DB/MySQL.pm:
$dbh->do("SET max_allowed_packet=128000000");
Just comment it out or delete the line. It seems the latest versions
of MySQL doesn't permit this setting anymore. It is there to allow
large topic sizes to be stored in the database, but I believe it has
now been super-seeded by a global setting in the MySQL config file.
Cheers,
David
|
|
From: Hadianto, V. <vic...@cr...> - 2009-05-25 19:07:13
|
Hi, Trying to install CodeStriker, I've followed all the instructions and using the following: MySql + Apache on a workstation. When I ran install.pl it throws me the following error: C:\Program Files\codestriker\codestriker-1.9.8\bin> C:\Program Files\codestriker\codestriker-1.9.8\bin>install.pl Checking for LWP::UserAgent (any) ok: found v5.814 Checking for CGI (v2.56) ok: found v3.41 Checking for Net::SMTP (any) ok: found v2.31 Checking for MIME::QuotedPrint (v2.14) ok: found v3.07 Checking for DBI (v1.13) ok: found v1.607 Checking for Template (v2.07) ok: found v2.20 Checking for HTML::Entities (any) ok: found v1.35 Checking for File::Temp (any) ok: found v0.18 Checking for XML::RSS (v1.05) ok: not found, optional Checking for Encode::Byte (any) ok: found v2.03 Checking for Encode::Unicode (any) ok: found v2.05 Checking for DBD::mysql (any) ok: found v4.005 DBD::mysql::db do failed: SESSION variable 'max_allowed_packet' is read-only. Us e SET GLOBAL to assign the value at C:\Program Files\codestriker\codestriker-1.9 .8/lib/Codestriker/DB/MySQL.pm line 59. DBD::mysql::db do failed: SESSION variable 'max_allowed_packet' is read-only. Us e SET GLOBAL to assign the value at C:\Program Files\codestriker\codestriker-1.9 .8/lib/Codestriker/DB/MySQL.pm line 59. C:\Program Files\codestriker\codestriker-1.9.8\bin> As you can probably guess, my Perl knowledge is zero to none :) Can someone please let me know what goes wrong here? Thanks, Victor =============================================================================== Please access the attached hyperlink for an important electronic communications disclaimer: http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html =============================================================================== |
|
From: Carlo C. <cmc...@gm...> - 2009-05-25 17:54:24
|
Hi Everyone, I'm evaluating a code review software tool for company. Having gone from several other alternatives, we still haven't found the one we need. one of the things that we need is for the developers to be able to upload files for review. This files may not necesarrily come from a code repository but may come from just plain files. If I can upload a file for review, Can I upload a bulk file(zip file) for example to be listed for code review as well. Last is, Do you have support for mercurial as our company already has changed our repository from subversion to mercurial in future projects. Thanks A lot! Carlo |
|
From: David S. <dav...@gm...> - 2009-05-09 02:09:42
|
If you want to automatically add the topicid to the topic title, just
update this file:
lib/Codestriker/Action/SubmitNewTopic.pm:
go to the line that has this:
# Create the topic in the model.
my $topic = Codestriker::Model::Topic->new($topicid);
$topic->create($topicid, $email, $topic_title, $topic_state,
change it to be:
# Create the topic in the model.
my $topic = Codestriker::Model::Topic->new($topicid);
$topic_title .= "$topicid: $topic_title";
$topic->create($topicid, $email, $topic_title, $topic_state,
This will prepend the topic ID to the title, which will ensure it is unique.
Cheers,
David
On Sat, May 9, 2009 at 2:30 AM, Gary Yang <gar...@ya...> wrote:
>
> Hi David,
>
> I created three same titles. The codestriker did not stop me by creating same title repeatly. This is the primary reason I would like to have a ID auto generated each time when a title created. I will be able to distingush the topics even they have same title. I would like to hack the code to add this function if it is possible. Can you please give me the guidance and tell me where I should start with?
>
> Thanks,
>
>
> Gary
>
>
> --- On Thu, 5/7/09, David Sitsky <dav...@gm...> wrote:
>
>> From: David Sitsky <dav...@gm...>
>> Subject: Re: Can you please add two columns on the topic?
>> To: "Gary Yang" <gar...@ya...>
>> Cc: cod...@li...
>> Date: Thursday, May 7, 2009, 8:21 PM
>> Hi Gary,
>>
>> You'll see this metric in the "Topic Information"
>> tab. It won't be
>> auto-generated though.
>>
>> I'm not sure what you are trying to do from your pre-commit
>> hook, but
>> assuming you might be accessing the Codestriker database
>> directly, can
>> you not just use the topicid field from the topic table
>> directly?
>>
>> Cheers,
>> David
>>
>> On Fri, May 8, 2009 at 7:19 AM, Gary Yang <gar...@ya...>
>> wrote:
>> >
>> > David,
>> >
>> > In Codestriker.pm, I added lines below to
>> @metrics_schema.
>> > {
>> > name=>"Topic ID",
>> > description=>"Topic ID",
>> > scope=>"topic",
>> > enabled=>1,
>> > filter=>"count"
>> > },
>> >
>> > In codestriker.conf:
>> > $metric_config = "Topic ID";
>> >
>> > Restarted apache server:
>> > /usr/sbin/apachectl -k restart
>> >
>> >
>> > However, the "Topic ID" colomn does not show in the
>> "viewing Topic" browswer after I created a new title. What I
>> want is the "Topic ID" colomn shows in the "View Top" and it
>> is auto generated whenever a topic is created. Please let
>> me know how to achieve it.
>> >
>> > Thanks,
>> >
>> >
>> > Gary
>> >
>> >
>> >
>> >
>> >
>> >
>> > --- On Wed, 5/6/09, David Sitsky <dav...@gm...>
>> wrote:
>> >
>> >> From: David Sitsky <dav...@gm...>
>> >> Subject: Re: Can you please add two columns on the
>> topic?
>> >> To: "Gary Yang" <gar...@ya...>
>> >> Cc: cod...@li...
>> >> Date: Wednesday, May 6, 2009, 3:12 PM
>> >> Hi Gary,
>> >>
>> >> You should be able to accomplish this using topic
>> >> metrics. Have a
>> >> look inside codestriker.conf at the bottom, and
>> the
>> >> metrics
>> >> definitions in Codestriker.pm.
>> >>
>> >> Cheers,
>> >> David
>> >>
>> >> On Thu, May 7, 2009 at 5:20 AM, Gary Yang <gar...@ya...>
>> >> wrote:
>> >> >
>> >> > Hi David,
>> >> >
>> >> > Can you please add two columns on the topic?
>> One is
>> >> Title ID, another is Approved by?
>> >> >
>> >> > Here is the reason.
>> >> > I am going to develop a pre-check in trigger.
>> The user
>> >> needs to enter the Codestriker title ID and the
>> person’s
>> >> name who approved this topic when he/she submit
>> the code.
>> >> The check-in fails if the title ID is not provided
>> in the
>> >> check-in description, or the title is not
>> approved. Please
>> >> let me know if you can add those two columns.
>> >> >
>> >> > Thanks,
>> >> >
>> >> >
>> >> > Gary
>> >> >
>> >> >
>> >> >
>> >> >
>> >> >
>> >>
>> >
>> >
>> >
>> >
>>
>
>
>
>
|
|
From: David S. <dav...@gm...> - 2009-05-09 02:04:52
|
Hi Gary,
I'll take this off this list, since most people won't be too interested in this.
Cheers,
David
On Sat, May 9, 2009 at 2:30 AM, Gary Yang <gar...@ya...> wrote:
>
> Hi David,
>
> I created three same titles. The codestriker did not stop me by creating same title repeatly. This is the primary reason I would like to have a ID auto generated each time when a title created. I will be able to distingush the topics even they have same title. I would like to hack the code to add this function if it is possible. Can you please give me the guidance and tell me where I should start with?
>
> Thanks,
>
>
> Gary
>
>
> --- On Thu, 5/7/09, David Sitsky <dav...@gm...> wrote:
>
>> From: David Sitsky <dav...@gm...>
>> Subject: Re: Can you please add two columns on the topic?
>> To: "Gary Yang" <gar...@ya...>
>> Cc: cod...@li...
>> Date: Thursday, May 7, 2009, 8:21 PM
>> Hi Gary,
>>
>> You'll see this metric in the "Topic Information"
>> tab. It won't be
>> auto-generated though.
>>
>> I'm not sure what you are trying to do from your pre-commit
>> hook, but
>> assuming you might be accessing the Codestriker database
>> directly, can
>> you not just use the topicid field from the topic table
>> directly?
>>
>> Cheers,
>> David
>>
>> On Fri, May 8, 2009 at 7:19 AM, Gary Yang <gar...@ya...>
>> wrote:
>> >
>> > David,
>> >
>> > In Codestriker.pm, I added lines below to
>> @metrics_schema.
>> > {
>> > name=>"Topic ID",
>> > description=>"Topic ID",
>> > scope=>"topic",
>> > enabled=>1,
>> > filter=>"count"
>> > },
>> >
>> > In codestriker.conf:
>> > $metric_config = "Topic ID";
>> >
>> > Restarted apache server:
>> > /usr/sbin/apachectl -k restart
>> >
>> >
>> > However, the "Topic ID" colomn does not show in the
>> "viewing Topic" browswer after I created a new title. What I
>> want is the "Topic ID" colomn shows in the "View Top" and it
>> is auto generated whenever a topic is created. Please let
>> me know how to achieve it.
>> >
>> > Thanks,
>> >
>> >
>> > Gary
>> >
>> >
>> >
>> >
>> >
>> >
>> > --- On Wed, 5/6/09, David Sitsky <dav...@gm...>
>> wrote:
>> >
>> >> From: David Sitsky <dav...@gm...>
>> >> Subject: Re: Can you please add two columns on the
>> topic?
>> >> To: "Gary Yang" <gar...@ya...>
>> >> Cc: cod...@li...
>> >> Date: Wednesday, May 6, 2009, 3:12 PM
>> >> Hi Gary,
>> >>
>> >> You should be able to accomplish this using topic
>> >> metrics. Have a
>> >> look inside codestriker.conf at the bottom, and
>> the
>> >> metrics
>> >> definitions in Codestriker.pm.
>> >>
>> >> Cheers,
>> >> David
>> >>
>> >> On Thu, May 7, 2009 at 5:20 AM, Gary Yang <gar...@ya...>
>> >> wrote:
>> >> >
>> >> > Hi David,
>> >> >
>> >> > Can you please add two columns on the topic?
>> One is
>> >> Title ID, another is Approved by?
>> >> >
>> >> > Here is the reason.
>> >> > I am going to develop a pre-check in trigger.
>> The user
>> >> needs to enter the Codestriker title ID and the
>> person’s
>> >> name who approved this topic when he/she submit
>> the code.
>> >> The check-in fails if the title ID is not provided
>> in the
>> >> check-in description, or the title is not
>> approved. Please
>> >> let me know if you can add those two columns.
>> >> >
>> >> > Thanks,
>> >> >
>> >> >
>> >> > Gary
>> >> >
>> >> >
>> >> >
>> >> >
>> >> >
>> >>
>> >
>> >
>> >
>> >
>>
>
>
>
>
|
|
From: Gary Y. <gar...@ya...> - 2009-05-08 16:30:30
|
Hi David,
I created three same titles. The codestriker did not stop me by creating same title repeatly. This is the primary reason I would like to have a ID auto generated each time when a title created. I will be able to distingush the topics even they have same title. I would like to hack the code to add this function if it is possible. Can you please give me the guidance and tell me where I should start with?
Thanks,
Gary
--- On Thu, 5/7/09, David Sitsky <dav...@gm...> wrote:
> From: David Sitsky <dav...@gm...>
> Subject: Re: Can you please add two columns on the topic?
> To: "Gary Yang" <gar...@ya...>
> Cc: cod...@li...
> Date: Thursday, May 7, 2009, 8:21 PM
> Hi Gary,
>
> You'll see this metric in the "Topic Information"
> tab. It won't be
> auto-generated though.
>
> I'm not sure what you are trying to do from your pre-commit
> hook, but
> assuming you might be accessing the Codestriker database
> directly, can
> you not just use the topicid field from the topic table
> directly?
>
> Cheers,
> David
>
> On Fri, May 8, 2009 at 7:19 AM, Gary Yang <gar...@ya...>
> wrote:
> >
> > David,
> >
> > In Codestriker.pm, I added lines below to
> @metrics_schema.
> > {
> > name=>"Topic ID",
> > description=>"Topic ID",
> > scope=>"topic",
> > enabled=>1,
> > filter=>"count"
> > },
> >
> > In codestriker.conf:
> > $metric_config = "Topic ID";
> >
> > Restarted apache server:
> > /usr/sbin/apachectl -k restart
> >
> >
> > However, the "Topic ID" colomn does not show in the
> "viewing Topic" browswer after I created a new title. What I
> want is the "Topic ID" colomn shows in the "View Top" and it
> is auto generated whenever a topic is created. Please let
> me know how to achieve it.
> >
> > Thanks,
> >
> >
> > Gary
> >
> >
> >
> >
> >
> >
> > --- On Wed, 5/6/09, David Sitsky <dav...@gm...>
> wrote:
> >
> >> From: David Sitsky <dav...@gm...>
> >> Subject: Re: Can you please add two columns on the
> topic?
> >> To: "Gary Yang" <gar...@ya...>
> >> Cc: cod...@li...
> >> Date: Wednesday, May 6, 2009, 3:12 PM
> >> Hi Gary,
> >>
> >> You should be able to accomplish this using topic
> >> metrics. Have a
> >> look inside codestriker.conf at the bottom, and
> the
> >> metrics
> >> definitions in Codestriker.pm.
> >>
> >> Cheers,
> >> David
> >>
> >> On Thu, May 7, 2009 at 5:20 AM, Gary Yang <gar...@ya...>
> >> wrote:
> >> >
> >> > Hi David,
> >> >
> >> > Can you please add two columns on the topic?
> One is
> >> Title ID, another is Approved by?
> >> >
> >> > Here is the reason.
> >> > I am going to develop a pre-check in trigger.
> The user
> >> needs to enter the Codestriker title ID and the
> person’s
> >> name who approved this topic when he/she submit
> the code.
> >> The check-in fails if the title ID is not provided
> in the
> >> check-in description, or the title is not
> approved. Please
> >> let me know if you can add those two columns.
> >> >
> >> > Thanks,
> >> >
> >> >
> >> > Gary
> >> >
> >> >
> >> >
> >> >
> >> >
> >>
> >
> >
> >
> >
>
|
|
From: David S. <dav...@gm...> - 2009-05-08 03:21:23
|
Hi Gary,
You'll see this metric in the "Topic Information" tab. It won't be
auto-generated though.
I'm not sure what you are trying to do from your pre-commit hook, but
assuming you might be accessing the Codestriker database directly, can
you not just use the topicid field from the topic table directly?
Cheers,
David
On Fri, May 8, 2009 at 7:19 AM, Gary Yang <gar...@ya...> wrote:
>
> David,
>
> In Codestriker.pm, I added lines below to @metrics_schema.
> {
> name=>"Topic ID",
> description=>"Topic ID",
> scope=>"topic",
> enabled=>1,
> filter=>"count"
> },
>
> In codestriker.conf:
> $metric_config = "Topic ID";
>
> Restarted apache server:
> /usr/sbin/apachectl -k restart
>
>
> However, the "Topic ID" colomn does not show in the "viewing Topic" browswer after I created a new title. What I want is the "Topic ID" colomn shows in the "View Top" and it is auto generated whenever a topic is created. Please let me know how to achieve it.
>
> Thanks,
>
>
> Gary
>
>
>
>
>
>
> --- On Wed, 5/6/09, David Sitsky <dav...@gm...> wrote:
>
>> From: David Sitsky <dav...@gm...>
>> Subject: Re: Can you please add two columns on the topic?
>> To: "Gary Yang" <gar...@ya...>
>> Cc: cod...@li...
>> Date: Wednesday, May 6, 2009, 3:12 PM
>> Hi Gary,
>>
>> You should be able to accomplish this using topic
>> metrics. Have a
>> look inside codestriker.conf at the bottom, and the
>> metrics
>> definitions in Codestriker.pm.
>>
>> Cheers,
>> David
>>
>> On Thu, May 7, 2009 at 5:20 AM, Gary Yang <gar...@ya...>
>> wrote:
>> >
>> > Hi David,
>> >
>> > Can you please add two columns on the topic? One is
>> Title ID, another is Approved by?
>> >
>> > Here is the reason.
>> > I am going to develop a pre-check in trigger. The user
>> needs to enter the Codestriker title ID and the person’s
>> name who approved this topic when he/she submit the code.
>> The check-in fails if the title ID is not provided in the
>> check-in description, or the title is not approved. Please
>> let me know if you can add those two columns.
>> >
>> > Thanks,
>> >
>> >
>> > Gary
>> >
>> >
>> >
>> >
>> >
>>
>
>
>
>
|
|
From: Gary Y. <gar...@ya...> - 2009-05-07 21:19:28
|
David,
In Codestriker.pm, I added lines below to @metrics_schema.
{
name=>"Topic ID",
description=>"Topic ID",
scope=>"topic",
enabled=>1,
filter=>"count"
},
In codestriker.conf:
$metric_config = "Topic ID";
Restarted apache server:
/usr/sbin/apachectl -k restart
However, the "Topic ID" colomn does not show in the "viewing Topic" browswer after I created a new title. What I want is the "Topic ID" colomn shows in the "View Top" and it is auto generated whenever a topic is created. Please let me know how to achieve it.
Thanks,
Gary
--- On Wed, 5/6/09, David Sitsky <dav...@gm...> wrote:
> From: David Sitsky <dav...@gm...>
> Subject: Re: Can you please add two columns on the topic?
> To: "Gary Yang" <gar...@ya...>
> Cc: cod...@li...
> Date: Wednesday, May 6, 2009, 3:12 PM
> Hi Gary,
>
> You should be able to accomplish this using topic
> metrics. Have a
> look inside codestriker.conf at the bottom, and the
> metrics
> definitions in Codestriker.pm.
>
> Cheers,
> David
>
> On Thu, May 7, 2009 at 5:20 AM, Gary Yang <gar...@ya...>
> wrote:
> >
> > Hi David,
> >
> > Can you please add two columns on the topic? One is
> Title ID, another is Approved by?
> >
> > Here is the reason.
> > I am going to develop a pre-check in trigger. The user
> needs to enter the Codestriker title ID and the person’s
> name who approved this topic when he/she submit the code.
> The check-in fails if the title ID is not provided in the
> check-in description, or the title is not approved. Please
> let me know if you can add those two columns.
> >
> > Thanks,
> >
> >
> > Gary
> >
> >
> >
> >
> >
>
|
|
From: David S. <dav...@gm...> - 2009-05-07 19:42:45
|
Ah now I am with you. Yes that link no longer exists since a major refactoring of the view code a few subversions ago. Most people just clicked on "Parallel", then horizontally scrolled the browser window if they wanted to see the old file, or the new file. Because of limited available time I have, the manual has a number of old screenshots in it. Cheers, David On Fri, May 8, 2009 at 4:28 AM, Gary Yang <gar...@ya...> wrote: > > David, > > I am not talking about the line numbers used to add comments. It works fine. I am talking about the Line number next to the "Parallel". > > At the Codestriker Guide, 3.5.3 Viewing Complete old/new Files. It syas: > > As mention in Section 3.5.1, it is possible to view the entire contents of a file in a review in its original form, or in its proposed form, or side-by-side depending on whether the "Line" or "Parallel" link was selected. > ...... > When a "Line" link is clicked, a new browser window will come up with the contents of the file. > > > I am able to click on the Parallel. It pops up a new browser to show me both original and changed revision. However, the Line number next to the Parallel there is no hyperlink with it. Nothing poped up after I clicked on it. Can you please tell me how to fix it? > > Thanks. > > > > --- On Wed, 5/6/09, David Sitsky <dav...@gm...> wrote: > >> From: David Sitsky <dav...@gm...> >> Subject: Re: No new browser window opened up after clicked on the line number. >> To: "Gary Yang" <gar...@ya...> >> Cc: cod...@li... >> Date: Wednesday, May 6, 2009, 5:45 PM >> The more recent versions of >> Codestriker removed the explicit >> underlines form the line numbers. If you click on >> them, a little >> inline popup window should appear, allowing you to enter a >> comment. >> >> If this is not happening, make sure you are at least using >> 1.9.8. >> Also try it with firefox, to make sure its not a browser >> issue. >> >> On Thu, May 7, 2009 at 10:00 AM, Gary Yang <gar...@ya...> >> wrote: >> > >> > >> > Hi David, >> > >> > I do not understand your explaination. From my >> understanding, the diff text matches the depot path. There >> is a hyperlinked parallel line. A window popped up after I >> clicked on the Paraelle. It shows two differen revisons of >> the file. I tried it again. Still, there is no hyperlink >> with the line number. Below is the detail. >> > >> > >> > in codestriker.conf: >> > >> > 'perforce:apache:apache1234@ipcswsvdcp4:1666', >> > >> > The Perforce client workspace spec: >> > p4 client -o >> > View: >> > //training/... >> //gary_pc_training/training/... >> > >> > >> > p4 diff -du >> > ==== //training/main.c#10 - >> c:\workspace\gary_pc_training\training\main.c ==== >> > @@ -30,7 +30,6 @@ >> > >> > #include <sys\ppc440sp_board.h> >> > #include <ppclib.h> >> > -#include <asynclib.h> >> > #include <stdio.h> >> > #include <sys\tcpiplib.h> >> > #include <serial.h> >> > @@ -41,12 +40,13 @@ >> > /* SDRAM MICRON */ >> > #define SDRAM_MICRON 0x2C >> > >> > -#define SDRAM_TRUE 1 >> > +#define SDRAM_TRUE 2 >> > #define SDRyAM_FALSE 0 >> > #define SDRAM_DDR1 1 >> > #define SDRAM_DDR2 2 >> > #define SDRAM_NONE 0 >> > #define MAXDIMMS 2 >> > +#define max 3 >> > #define MAXRANKS 2 /* Changes le 12/01/05 pour >> 1.6*/ >> > #define MAXBANKSPERDIMM 8 >> > #define MAXRANKSPERDIMM 2 >> > ==== //training/test_dir/mainTG.c#1 - >> c:\workspace\gary_pc_training\training\test_dir\mainTG.c >> ==== >> > @@ -20,8 +20,7 @@ >> > >> #---------------------------------------------------------------------------*/ >> > /* Perform DQS calibration and test memory */ >> > >> > -#include <sys\ppc440sp_board.h> >> > -#include <ppclib.h> >> > +#include <ppc.h> >> > #include <asynclib.h> >> > #include <stdio.h> >> > #include <sys\tcpiplib.h> >> > @@ -34,6 +33,7 @@ >> > #define SDRAM_MICRON 0x2C >> > >> > #define SDRAM_TRUE 1 >> > +#define SDRAM_TRUE 9 >> > #define SDRyAM_FALSE 0 >> > #define SDRAM_DDR1 1 >> > #define SDRAM_DDR2 2 >> > >> > >> > Thanks, >> > >> > >> > Gary >> > >> > --- On Wed, 5/6/09, David Sitsky <dav...@gm...> >> wrote: >> > >> >> From: David Sitsky <dav...@gm...> >> >> Subject: Re: No new browser window opened up after >> clicked on the line number. >> >> To: "Gary Yang" <gar...@ya...> >> >> Cc: cod...@li... >> >> Date: Wednesday, May 6, 2009, 3:14 PM >> >> This happens when the diff you have >> >> loaded in doesn't match the >> >> repository associated with the topic. If you >> have the >> >> repository set >> >> to your Perforce depot, and the diff text matches >> the depot >> >> path, then >> >> those links will become active again. You'll >> need to >> >> create new >> >> topics whenever you change the repository string >> in >> >> codestriker.conf. >> >> >> >> Cheers, >> >> David >> >> >> >> On Thu, May 7, 2009 at 7:56 AM, Gary Yang <gar...@ya...> >> >> wrote: >> >> > >> >> > Hi David, >> >> > >> >> > >> >> > I use Perforce and Codestriker 1.9.6. In the >> The >> >> Codestriker Guide 1.9.5 at the section, 3.5.1. >> Viewing a >> >> Topic. The last paragraph says below: >> >> > >> >> > Each file is broken up into a series of >> "deltas". At >> >> the head of each delta block, for both the old and >> new >> >> versions of the file, there is an indication of >> what line >> >> number the delta started at. In this situation, >> clicking on >> >> the "Line 24" link on the left hand side, will >> open a new >> >> browser window, which will contain the complete >> original >> >> contents of codestriker/codestriker.pl, anchored >> at line 24. >> >> Clicking on the "Line 22" link on the right hand >> side will >> >> contain the complete contents of >> codestriker/codestriker.pl >> >> will all of the proposed changes applied. >> >> > >> >> > However, when I clicked on the line number, >> there is >> >> no new browser window opened up. Actually, there >> is no >> >> hyperlink line under the line number. It is >> different than >> >> what I see in the manual. Can you please let me >> know the >> >> reason? >> >> > >> >> > >> >> > Thanks, >> >> > >> >> > >> >> > Gary >> >> > >> >> > >> >> > >> >> > >> >> > >> >> >> > >> > >> > >> > >> > > > > |
|
From: Gary Y. <gar...@ya...> - 2009-05-07 18:57:28
|
David, I upgraded the codestriker to 1.9.8. However, there is no hyperlink with the "Line number" next to "Parallel". I am clueless. Gary --- On Thu, 5/7/09, Gary Yang <gar...@ya...> wrote: > From: Gary Yang <gar...@ya...> > Subject: Re: [Codestriker-user] No new browser window opened up after clicked on the line number. > To: "David Sitsky" <dav...@gm...> > Cc: cod...@li... > Date: Thursday, May 7, 2009, 11:28 AM > > David, > > I am not talking about the line numbers used to add > comments. It works fine. I am talking about the Line number > next to the "Parallel". > > At the Codestriker Guide, 3.5.3 Viewing Complete old/new > Files. It syas: > > As mention in Section 3.5.1, it is possible to view the > entire contents of a file in a review in its original form, > or in its proposed form, or side-by-side depending on > whether the "Line" or "Parallel" link was selected. > ...... > When a "Line" link is clicked, a new browser window will > come up with the contents of the file. > > > I am able to click on the Parallel. It pops up a new > browser to show me both original and changed revision. > However, the Line number next to the Parallel there is no > hyperlink with it. Nothing poped up after I clicked on it. > Can you please tell me how to fix it? > > Thanks. > > > > --- On Wed, 5/6/09, David Sitsky <dav...@gm...> > wrote: > > > From: David Sitsky <dav...@gm...> > > Subject: Re: No new browser window opened up after > clicked on the line number. > > To: "Gary Yang" <gar...@ya...> > > Cc: cod...@li... > > Date: Wednesday, May 6, 2009, 5:45 PM > > The more recent versions of > > Codestriker removed the explicit > > underlines form the line numbers. If you click on > > them, a little > > inline popup window should appear, allowing you to > enter a > > comment. > > > > If this is not happening, make sure you are at least > using > > 1.9.8. > > Also try it with firefox, to make sure its not a > browser > > issue. > > > > On Thu, May 7, 2009 at 10:00 AM, Gary Yang <gar...@ya...> > > wrote: > > > > > > > > > Hi David, > > > > > > I do not understand your explaination. From my > > understanding, the diff text matches the depot path. > There > > is a hyperlinked parallel line. A window popped up > after I > > clicked on the Paraelle. It shows two differen > revisons of > > the file. I tried it again. Still, there is no > hyperlink > > with the line number. Below is the detail. > > > > > > > > > in codestriker.conf: > > > > > > 'perforce:apache:apache1234@ipcswsvdcp4:1666', > > > > > > The Perforce client workspace spec: > > > p4 client -o > > > View: > > > //training/... > > //gary_pc_training/training/... > > > > > > > > > p4 diff -du > > > ==== //training/main.c#10 - > > c:\workspace\gary_pc_training\training\main.c ==== > > > @@ -30,7 +30,6 @@ > > > > > > #include <sys\ppc440sp_board.h> > > > #include <ppclib.h> > > > -#include <asynclib.h> > > > #include <stdio.h> > > > #include <sys\tcpiplib.h> > > > #include <serial.h> > > > @@ -41,12 +40,13 @@ > > > /* SDRAM MICRON */ > > > #define SDRAM_MICRON 0x2C > > > > > > -#define SDRAM_TRUE 1 > > > +#define SDRAM_TRUE 2 > > > #define SDRyAM_FALSE 0 > > > #define SDRAM_DDR1 1 > > > #define SDRAM_DDR2 2 > > > #define SDRAM_NONE 0 > > > #define MAXDIMMS 2 > > > +#define max 3 > > > #define MAXRANKS 2 /* Changes le 12/01/05 > pour > > 1.6*/ > > > #define MAXBANKSPERDIMM 8 > > > #define MAXRANKSPERDIMM 2 > > > ==== //training/test_dir/mainTG.c#1 - > > > c:\workspace\gary_pc_training\training\test_dir\mainTG.c > > ==== > > > @@ -20,8 +20,7 @@ > > > > > > #---------------------------------------------------------------------------*/ > > > /* Perform DQS calibration and test memory */ > > > > > > -#include <sys\ppc440sp_board.h> > > > -#include <ppclib.h> > > > +#include <ppc.h> > > > #include <asynclib.h> > > > #include <stdio.h> > > > #include <sys\tcpiplib.h> > > > @@ -34,6 +33,7 @@ > > > #define SDRAM_MICRON 0x2C > > > > > > #define SDRAM_TRUE 1 > > > +#define SDRAM_TRUE 9 > > > #define SDRyAM_FALSE 0 > > > #define SDRAM_DDR1 1 > > > #define SDRAM_DDR2 2 > > > > > > > > > Thanks, > > > > > > > > > Gary > > > > > > --- On Wed, 5/6/09, David Sitsky <dav...@gm...> > > wrote: > > > > > >> From: David Sitsky <dav...@gm...> > > >> Subject: Re: No new browser window opened up > after > > clicked on the line number. > > >> To: "Gary Yang" <gar...@ya...> > > >> Cc: cod...@li... > > >> Date: Wednesday, May 6, 2009, 3:14 PM > > >> This happens when the diff you have > > >> loaded in doesn't match the > > >> repository associated with the topic. If > you > > have the > > >> repository set > > >> to your Perforce depot, and the diff text > matches > > the depot > > >> path, then > > >> those links will become active again. > You'll > > need to > > >> create new > > >> topics whenever you change the repository > string > > in > > >> codestriker.conf. > > >> > > >> Cheers, > > >> David > > >> > > >> On Thu, May 7, 2009 at 7:56 AM, Gary Yang > <gar...@ya...> > > >> wrote: > > >> > > > >> > Hi David, > > >> > > > >> > > > >> > I use Perforce and Codestriker 1.9.6. In > the > > The > > >> Codestriker Guide 1.9.5 at the section, > 3.5.1. > > Viewing a > > >> Topic. The last paragraph says below: > > >> > > > >> > Each file is broken up into a series of > > "deltas". At > > >> the head of each delta block, for both the > old and > > new > > >> versions of the file, there is an indication > of > > what line > > >> number the delta started at. In this > situation, > > clicking on > > >> the "Line 24" link on the left hand side, > will > > open a new > > >> browser window, which will contain the > complete > > original > > >> contents of codestriker/codestriker.pl, > anchored > > at line 24. > > >> Clicking on the "Line 22" link on the right > hand > > side will > > >> contain the complete contents of > > codestriker/codestriker.pl > > >> will all of the proposed changes applied. > > >> > > > >> > However, when I clicked on the line > number, > > there is > > >> no new browser window opened up. Actually, > there > > is no > > >> hyperlink line under the line number. It is > > different than > > >> what I see in the manual. Can you please let > me > > know the > > >> reason? > > >> > > > >> > > > >> > Thanks, > > >> > > > >> > > > >> > Gary > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > The NEW KODAK i700 Series Scanners deliver under ANY > circumstances! Your > production scanning environment may not be a perfect world > - but thanks to > Kodak, there's a perfect scanner to get the job done! With > the NEW KODAK i700 > Series Scanner you'll get full speed at 300 dpi even with > all image > processing features enabled. http://p.sf.net/sfu/kodak-com > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > |
|
From: Gary Y. <gar...@ya...> - 2009-05-07 18:29:06
|
David,
I am not talking about the line numbers used to add comments. It works fine. I am talking about the Line number next to the "Parallel".
At the Codestriker Guide, 3.5.3 Viewing Complete old/new Files. It syas:
As mention in Section 3.5.1, it is possible to view the entire contents of a file in a review in its original form, or in its proposed form, or side-by-side depending on whether the "Line" or "Parallel" link was selected.
......
When a "Line" link is clicked, a new browser window will come up with the contents of the file.
I am able to click on the Parallel. It pops up a new browser to show me both original and changed revision. However, the Line number next to the Parallel there is no hyperlink with it. Nothing poped up after I clicked on it. Can you please tell me how to fix it?
Thanks.
--- On Wed, 5/6/09, David Sitsky <dav...@gm...> wrote:
> From: David Sitsky <dav...@gm...>
> Subject: Re: No new browser window opened up after clicked on the line number.
> To: "Gary Yang" <gar...@ya...>
> Cc: cod...@li...
> Date: Wednesday, May 6, 2009, 5:45 PM
> The more recent versions of
> Codestriker removed the explicit
> underlines form the line numbers. If you click on
> them, a little
> inline popup window should appear, allowing you to enter a
> comment.
>
> If this is not happening, make sure you are at least using
> 1.9.8.
> Also try it with firefox, to make sure its not a browser
> issue.
>
> On Thu, May 7, 2009 at 10:00 AM, Gary Yang <gar...@ya...>
> wrote:
> >
> >
> > Hi David,
> >
> > I do not understand your explaination. From my
> understanding, the diff text matches the depot path. There
> is a hyperlinked parallel line. A window popped up after I
> clicked on the Paraelle. It shows two differen revisons of
> the file. I tried it again. Still, there is no hyperlink
> with the line number. Below is the detail.
> >
> >
> > in codestriker.conf:
> >
> > 'perforce:apache:apache1234@ipcswsvdcp4:1666',
> >
> > The Perforce client workspace spec:
> > p4 client -o
> > View:
> > //training/...
> //gary_pc_training/training/...
> >
> >
> > p4 diff -du
> > ==== //training/main.c#10 -
> c:\workspace\gary_pc_training\training\main.c ====
> > @@ -30,7 +30,6 @@
> >
> > #include <sys\ppc440sp_board.h>
> > #include <ppclib.h>
> > -#include <asynclib.h>
> > #include <stdio.h>
> > #include <sys\tcpiplib.h>
> > #include <serial.h>
> > @@ -41,12 +40,13 @@
> > /* SDRAM MICRON */
> > #define SDRAM_MICRON 0x2C
> >
> > -#define SDRAM_TRUE 1
> > +#define SDRAM_TRUE 2
> > #define SDRyAM_FALSE 0
> > #define SDRAM_DDR1 1
> > #define SDRAM_DDR2 2
> > #define SDRAM_NONE 0
> > #define MAXDIMMS 2
> > +#define max 3
> > #define MAXRANKS 2 /* Changes le 12/01/05 pour
> 1.6*/
> > #define MAXBANKSPERDIMM 8
> > #define MAXRANKSPERDIMM 2
> > ==== //training/test_dir/mainTG.c#1 -
> c:\workspace\gary_pc_training\training\test_dir\mainTG.c
> ====
> > @@ -20,8 +20,7 @@
> >
> #---------------------------------------------------------------------------*/
> > /* Perform DQS calibration and test memory */
> >
> > -#include <sys\ppc440sp_board.h>
> > -#include <ppclib.h>
> > +#include <ppc.h>
> > #include <asynclib.h>
> > #include <stdio.h>
> > #include <sys\tcpiplib.h>
> > @@ -34,6 +33,7 @@
> > #define SDRAM_MICRON 0x2C
> >
> > #define SDRAM_TRUE 1
> > +#define SDRAM_TRUE 9
> > #define SDRyAM_FALSE 0
> > #define SDRAM_DDR1 1
> > #define SDRAM_DDR2 2
> >
> >
> > Thanks,
> >
> >
> > Gary
> >
> > --- On Wed, 5/6/09, David Sitsky <dav...@gm...>
> wrote:
> >
> >> From: David Sitsky <dav...@gm...>
> >> Subject: Re: No new browser window opened up after
> clicked on the line number.
> >> To: "Gary Yang" <gar...@ya...>
> >> Cc: cod...@li...
> >> Date: Wednesday, May 6, 2009, 3:14 PM
> >> This happens when the diff you have
> >> loaded in doesn't match the
> >> repository associated with the topic. If you
> have the
> >> repository set
> >> to your Perforce depot, and the diff text matches
> the depot
> >> path, then
> >> those links will become active again. You'll
> need to
> >> create new
> >> topics whenever you change the repository string
> in
> >> codestriker.conf.
> >>
> >> Cheers,
> >> David
> >>
> >> On Thu, May 7, 2009 at 7:56 AM, Gary Yang <gar...@ya...>
> >> wrote:
> >> >
> >> > Hi David,
> >> >
> >> >
> >> > I use Perforce and Codestriker 1.9.6. In the
> The
> >> Codestriker Guide 1.9.5 at the section, 3.5.1.
> Viewing a
> >> Topic. The last paragraph says below:
> >> >
> >> > Each file is broken up into a series of
> "deltas". At
> >> the head of each delta block, for both the old and
> new
> >> versions of the file, there is an indication of
> what line
> >> number the delta started at. In this situation,
> clicking on
> >> the "Line 24" link on the left hand side, will
> open a new
> >> browser window, which will contain the complete
> original
> >> contents of codestriker/codestriker.pl, anchored
> at line 24.
> >> Clicking on the "Line 22" link on the right hand
> side will
> >> contain the complete contents of
> codestriker/codestriker.pl
> >> will all of the proposed changes applied.
> >> >
> >> > However, when I clicked on the line number,
> there is
> >> no new browser window opened up. Actually, there
> is no
> >> hyperlink line under the line number. It is
> different than
> >> what I see in the manual. Can you please let me
> know the
> >> reason?
> >> >
> >> >
> >> > Thanks,
> >> >
> >> >
> >> > Gary
> >> >
> >> >
> >> >
> >> >
> >> >
> >>
> >
> >
> >
> >
>
|
|
From: David S. <dav...@gm...> - 2009-05-07 00:45:48
|
The more recent versions of Codestriker removed the explicit underlines form the line numbers. If you click on them, a little inline popup window should appear, allowing you to enter a comment. If this is not happening, make sure you are at least using 1.9.8. Also try it with firefox, to make sure its not a browser issue. On Thu, May 7, 2009 at 10:00 AM, Gary Yang <gar...@ya...> wrote: > > > Hi David, > > I do not understand your explaination. From my understanding, the diff text matches the depot path. There is a hyperlinked parallel line. A window popped up after I clicked on the Paraelle. It shows two differen revisons of the file. I tried it again. Still, there is no hyperlink with the line number. Below is the detail. > > > in codestriker.conf: > > 'perforce:apache:apache1234@ipcswsvdcp4:1666', > > The Perforce client workspace spec: > p4 client -o > View: > //training/... //gary_pc_training/training/... > > > p4 diff -du > ==== //training/main.c#10 - c:\workspace\gary_pc_training\training\main.c ==== > @@ -30,7 +30,6 @@ > > #include <sys\ppc440sp_board.h> > #include <ppclib.h> > -#include <asynclib.h> > #include <stdio.h> > #include <sys\tcpiplib.h> > #include <serial.h> > @@ -41,12 +40,13 @@ > /* SDRAM MICRON */ > #define SDRAM_MICRON 0x2C > > -#define SDRAM_TRUE 1 > +#define SDRAM_TRUE 2 > #define SDRyAM_FALSE 0 > #define SDRAM_DDR1 1 > #define SDRAM_DDR2 2 > #define SDRAM_NONE 0 > #define MAXDIMMS 2 > +#define max 3 > #define MAXRANKS 2 /* Changes le 12/01/05 pour 1.6*/ > #define MAXBANKSPERDIMM 8 > #define MAXRANKSPERDIMM 2 > ==== //training/test_dir/mainTG.c#1 - c:\workspace\gary_pc_training\training\test_dir\mainTG.c ==== > @@ -20,8 +20,7 @@ > #---------------------------------------------------------------------------*/ > /* Perform DQS calibration and test memory */ > > -#include <sys\ppc440sp_board.h> > -#include <ppclib.h> > +#include <ppc.h> > #include <asynclib.h> > #include <stdio.h> > #include <sys\tcpiplib.h> > @@ -34,6 +33,7 @@ > #define SDRAM_MICRON 0x2C > > #define SDRAM_TRUE 1 > +#define SDRAM_TRUE 9 > #define SDRyAM_FALSE 0 > #define SDRAM_DDR1 1 > #define SDRAM_DDR2 2 > > > Thanks, > > > Gary > > --- On Wed, 5/6/09, David Sitsky <dav...@gm...> wrote: > >> From: David Sitsky <dav...@gm...> >> Subject: Re: No new browser window opened up after clicked on the line number. >> To: "Gary Yang" <gar...@ya...> >> Cc: cod...@li... >> Date: Wednesday, May 6, 2009, 3:14 PM >> This happens when the diff you have >> loaded in doesn't match the >> repository associated with the topic. If you have the >> repository set >> to your Perforce depot, and the diff text matches the depot >> path, then >> those links will become active again. You'll need to >> create new >> topics whenever you change the repository string in >> codestriker.conf. >> >> Cheers, >> David >> >> On Thu, May 7, 2009 at 7:56 AM, Gary Yang <gar...@ya...> >> wrote: >> > >> > Hi David, >> > >> > >> > I use Perforce and Codestriker 1.9.6. In the The >> Codestriker Guide 1.9.5 at the section, 3.5.1. Viewing a >> Topic. The last paragraph says below: >> > >> > Each file is broken up into a series of "deltas". At >> the head of each delta block, for both the old and new >> versions of the file, there is an indication of what line >> number the delta started at. In this situation, clicking on >> the "Line 24" link on the left hand side, will open a new >> browser window, which will contain the complete original >> contents of codestriker/codestriker.pl, anchored at line 24. >> Clicking on the "Line 22" link on the right hand side will >> contain the complete contents of codestriker/codestriker.pl >> will all of the proposed changes applied. >> > >> > However, when I clicked on the line number, there is >> no new browser window opened up. Actually, there is no >> hyperlink line under the line number. It is different than >> what I see in the manual. Can you please let me know the >> reason? >> > >> > >> > Thanks, >> > >> > >> > Gary >> > >> > >> > >> > >> > >> > > > > |
|
From: David S. <dav...@gm...> - 2009-05-07 00:42:33
|
You want to run install.pl. checksetup.pl was renamed some time ago to install.pl On Thu, May 7, 2009 at 9:36 AM, Gary Yang <gar...@ya...> wrote: > > Hi David, > > I am upgrading Codestriker to 1.9.8. The CHANGELOG says codestriker.pl is auto-generated by the checksetup.pl. > > * Codestriker has been modified slightly to support mod_perl under > Apache 2.X. See the README file for more information. To support > Apache 2.X, cgi-bin/codestriker.pl is now auto-generated by the > checksetup.pl script and is no longer included in the distribution. > > > I cannot find the checksetup.pl. Where is it? The README directed me to the codestriker docs. But, I did not find any checcksetup.pl there. Please help. > > Thanks, > > > Gary > > > > > |
192 messages has been excluded from this view by a project administrator.
