codestriker-user Mailing List for Codestriker: collaborative code reviewer (Page 41)
Brought to you by:
sits
Menu
▾
▴
codestriker-user — Discussion of any issue to do with Codestriker
You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(12) |
Jun
|
Jul
|
Aug
(2) |
Sep
|
Oct
|
Nov
|
Dec
|
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
|
Feb
|
Mar
(1) |
Apr
(6) |
May
(3) |
Jun
(1) |
Jul
|
Aug
(9) |
Sep
(2) |
Oct
(2) |
Nov
(8) |
Dec
(6) |
| 2004 |
Jan
(12) |
Feb
(19) |
Mar
(2) |
Apr
(2) |
May
(4) |
Jun
(11) |
Jul
|
Aug
(14) |
Sep
(4) |
Oct
(27) |
Nov
(4) |
Dec
(22) |
| 2005 |
Jan
(14) |
Feb
(2) |
Mar
(11) |
Apr
(3) |
May
(14) |
Jun
(60) |
Jul
(58) |
Aug
(76) |
Sep
(72) |
Oct
(59) |
Nov
|
Dec
(4) |
| 2006 |
Jan
(1) |
Feb
(5) |
Mar
(13) |
Apr
(11) |
May
(30) |
Jun
(17) |
Jul
(18) |
Aug
(39) |
Sep
|
Oct
|
Nov
|
Dec
(17) |
| 2007 |
Jan
(18) |
Feb
(5) |
Mar
(20) |
Apr
(2) |
May
(3) |
Jun
(13) |
Jul
(11) |
Aug
(4) |
Sep
(6) |
Oct
(9) |
Nov
(3) |
Dec
|
| 2008 |
Jan
(10) |
Feb
|
Mar
(5) |
Apr
|
May
|
Jun
(9) |
Jul
(10) |
Aug
(10) |
Sep
(13) |
Oct
(34) |
Nov
(12) |
Dec
(8) |
| 2009 |
Jan
(4) |
Feb
(11) |
Mar
(12) |
Apr
(3) |
May
(36) |
Jun
(4) |
Jul
(11) |
Aug
(12) |
Sep
(25) |
Oct
(13) |
Nov
(9) |
Dec
|
| 2010 |
Jan
|
Feb
(12) |
Mar
(6) |
Apr
(10) |
May
(12) |
Jun
|
Jul
(4) |
Aug
(9) |
Sep
(12) |
Oct
(3) |
Nov
(6) |
Dec
(3) |
| 2011 |
Jan
(2) |
Feb
(1) |
Mar
(3) |
Apr
(5) |
May
(3) |
Jun
(8) |
Jul
|
Aug
(14) |
Sep
|
Oct
(3) |
Nov
(1) |
Dec
|
| 2012 |
Jan
(2) |
Feb
(10) |
Mar
(4) |
Apr
(3) |
May
(2) |
Jun
(5) |
Jul
|
Aug
(3) |
Sep
|
Oct
(2) |
Nov
(4) |
Dec
(2) |
| 2013 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(4) |
Jun
|
Jul
|
Aug
|
Sep
(2) |
Oct
(1) |
Nov
|
Dec
(2) |
| 2014 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: Kelly F. H. <kf...@mq...> - 2003-03-05 18:49:49
|
Hi all,
We just found this tool and set it up, it seems pretty nice, but
one question that I have is whether or not there's a way to get the diff
into the topic from CVS/Bonsai (we use both of those and bugzilla and
LXR). It seems like a pain to have to generate the diff by hand when
bonsai has all the info already.....
Also, for the codestriker.conf setting below, what should be
entered for Bonsai? I saw that there's a later setting for LXR, so
maybe that's enough and we should skip this part?
# A mapping of repositories to filename viewers. Examples of such
systems
# would be CVSweb and ViewCVS, for local repositories. Mappings are
# not required for remote CVSweb and ViewCVS repositories, as they are
# viewers themselves.
$file_viewer =3D
{
"/home/sits/cvs" =3D> "http://localhost/cgi-bin/cvsweb.cgi"
};
Thanks,
Kelly F. Hickel
Senior Software Architect
MQSoftware, Inc
952.345.8677
kf...@mq...
|
|
From: <mar...@ca...> - 2002-08-31 01:17:54
|
PEhUTUw+DQo8SEVBRD4NCjxNRVRBIE5BTUU9IkdFTkVSQVRPUiIgQ29udGVudD0iTWljcm9zb2Z0 IERIVE1MIEVkaXRpbmcgQ29udHJvbCI+DQo8VElUTEU+PC9USVRMRT4NCjwvSEVBRD4NCjxCT0RZ Pg0KPFA+PEZPTlQgZmFjZT1BcmlhbD48L0ZPTlQ+SGVsbG8sPC9QPg0KPFA+Jm5ic3A7Jm5ic3A7 Jm5ic3A7IEkmbmJzcDtoYXZlIHZpZXdlZCB5b3VyIHdlYnNpdGUgYW5kIGNvbmNsdWRlZCB0aGF0 IG91ciANCmNvbXBhbnkgaXMgaW50ZXJlc3RlZCBpbiBvYnRhaW5pbmcgYWR2ZXJ0aXNpbmcgc3Bh Y2UuJm5ic3A7IEluIG9yZGVyIHRvIA0KZXN0YWJsaXNoIGEgcHJvZmVzc2lvbmFsIHJlbGF0aW9u c2hpcCB3aXRoIHlvdXIgYnVzaW5lc3Mgd2UgcmVxdWlyZSBkaXJlY3QgDQpjb21tdW5pY2F0aW9u LiZuYnNwOyBVcG9uIHJlcGx5aW5nIHRvIHRoaXMgZW1haWwgcGxlYXNlIHByb3ZpZGUgbWUgd2l0 aCB5b3VyIA0KdGVsZXBob25lIGNvbnRhY3QgaW5mb3JtYXRpb24uJm5ic3A7IFdlIGxvb2sgZm9y d2FyZCB0byBkb2luZyBidXNpbmVzcyB3aXRoIHlvdSANCmluIHRoZSBmdXR1cmUuPC9QPg0KPFA+ UmVnYXJkcyw8QlI+Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IA0KPEVNPkplc3NlPC9FTT48L1A+DQo8 QUREUkVTUz5KZXNzZSBGLiBLZWxsZXI8QlI+VlAgQnVzaW5lc3MgRGV2ZWxvcG1lbnQgDQo8QlI+ Q2FzaW5vcmVzZWxsZXJzLmNvbTxCUj5URUwuICg2MDQpIDY4OC0yMzEwPEJSPkZBWC4gKDYwNCkg Njg4LTIzMTI8QlI+VE9MTCANCkZSRUUgMS04ODgtNjMzLTIyNTk8QlI+PEEgDQpocmVmPSJtYWls dG86bWFya2V0aW5nQGNhc2lub3Jlc2VsbGVycy5jb20iPm1hcmtldGluZ0BjYXNpbm9yZXNlbGxl cnMuY29tPC9BPiA8QlI+DQo8SFIgaWQ9dW5kZWZpbmVkPg0KPC9BRERSRVNTPg0KPC9CT0RZPg0K PC9IVE1MPg0K |
|
From: David S. <si...@us...> - 2002-05-30 23:03:50
|
Something else to consider... Its quite a heavy process to load a big review in coloured diff mode. I wonder if a better process for entering comments might be to bring up a popup window which records your comment, and then once you have finished your review, it could submit all your comments in the one go? I guess this could be a nice optional feature, but I have noticed it is also nice to be able to submit your comments one at a time, as the authors can start addresses the comments straight away while the code is still being reviewed... I guess this feature is more for use Codestriker over the net, and not over a LAN, where it is a pain to have to reload the entire topic screen each time. Any comments? -- Cheers, David |
|
From: David S. <si...@us...> - 2002-05-30 22:56:04
|
Has anyone used cvszilla by any chance? From what I read, it is a CVS checking script which asks for the bugzilla ID youe code is committing against, it takes your commit comments, and updates the associated bug id with your comment, and presumably changes the state to fixed. It would be nice to extend this script to also allow you to enter in the Codestriker topic id, so that bugzilla can also be updated with a comment indicating what codestriker topic corresponds to the bug. The state of the Codestriker topic could also be changed to "committed" by default. Any thoughts/comments? This should provide much nicer integration between Bugzilla / CVS and Codestriker and good cross-referencing. Although - it might be nice if the codestriker ids were actually sequential, and not random as they are now... -- Cheers, David |
|
From: David S. <si...@us...> - 2002-05-30 12:00:24
|
Just a minor note, there was a minor rendering bug in 1.5.0b1. I've fixed it and released 1.5.0b2. I've also attached the patch file for the minor fix, to save people from upgrading, as it is a one-line fix. Cheers, David > I've just uploaded codestriker-1.5.0b1 to SF. > > I'd really appreciate it if you could give this a go and let me know of any > problems. I have used it at my work with PostgreSQL and it works fine. > I've tested it with MySQL at home and it also seems good. I'd love you to > give it a go before releasing it as 1.5.0 officially. > > Cheers, > David |
|
From: David S. <si...@us...> - 2002-05-29 22:16:59
|
Hi John, I've just uploaded codestriker-1.5.0b1 to SF. I'd really appreciate it if you could give this a go and let me know of any problems. I have used it at my work with PostgreSQL and it works fine. I've tested it with MySQL at home and it also seems good. I'd love you to give it a go before releasing it as 1.5.0 officially. Cheers, David |
|
From: David S. <si...@us...> - 2002-05-29 12:06:49
|
Hi John, Yeah - would be nice, probably as little javascript popup windows. FYI - I've got a preliminary Codestriker 1.5.0 running in the office, working nicely off postgres. Interestingly, I think I found a bug in MySQL, but I think there is a simple workaround. I'm hoping to release a preliminary version for you to test in the next couple of days? The main changes (apart from everything being properly modularised), are a list of topics screen, a topic state which can be updated, and a simple topic search screen. There is also an import script to transfer all of your data automatically to your database. Stay tuned! Cheers, David On Wednesday 29 May 2002 02:51, John Goldstone wrote: > It would be great if there was a way to add some simple helptext, links > on the creation page. (And other pages too..) > > -J. |
|
From: John G. <jgo...@mo...> - 2002-05-28 16:51:27
|
It would be great if there was a way to add some simple helptext, links on the creation page. (And other pages too..) =20 -J. |
|
From: John G. <jgo...@mo...> - 2002-05-20 23:45:11
|
The latest version from CVS seems to work great for us. Thanks! -JT. -----Original Message----- From: David Sitsky [mailto:si...@us...] To: John Goldstone; cod...@li... Subject: Re: [Codestriker-user] RE: Bug with TOC when using '-b' with diff Hi John, Yep, the diff parsing code never took binary files into account. In all our reviewing the last few months here, we have never had to worry about it. Anyway, I've checked in some code into CVS which should handle it. Let me know how you go. Cheers, David |
|
From: David S. <si...@us...> - 2002-05-19 23:09:09
|
Hi John, Yep, the diff parsing code never took binary files into account. In all our reviewing the last few months here, we have never had to worry about it. Anyway, I've checked in some code into CVS which should handle it. Let me know how you go. Cheers, David On Saturday 18 May 2002 07:49, John Goldstone wrote: > The "diff -b" without diffs seems to work, now. It seems to not list > files with empty diffs. > > Though we just noticed another problem with the TOC; binary files that > differ. > Sample diff output, assume this is sandwhiched between other diffs. The > TOC ends with the binary file. > > -JT. > In this situation, the binary file was new... > > Index: lib/my.jar > =================================================================== > RCS file: my.jar > diff -N my.jar > Binary files /dev/null and my.jar differ -- Cheers, David |
|
From: John G. <jgo...@mo...> - 2002-05-17 21:49:33
|
The "diff -b" without diffs seems to work, now. It seems to not list files with empty diffs. Though we just noticed another problem with the TOC; binary files that differ. Sample diff output, assume this is sandwhiched between other diffs. The TOC ends with the binary file. -JT. In this situation, the binary file was new... Index: lib/my.jar =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: my.jar diff -N my.jar Binary files /dev/null and my.jar differ -----Original Message----- From: David Sitsky [mailto:si...@us...] Sent: Friday, May 17, 2002 2:13 PM To: cod...@li... Cc: John Goldstone Subject: Re: Bug with TOC when using '-b' with diff Should be fixed now in the latest CVS (as is the cc problem - although I couldn't reproduce it here, but could see where the problem might be). Also=20 fixed some rendering/anchoring bugs in popup parallel mode, here are the CHANGELOG entries: * Fix bug in popup parallel coloured-diff mode where the anchor names weren't being generated properly, resulting in some browsers not centering their view in the correct place. * Fixed bug in pop parallel coloured-diff mode where changes right at the end of the file weren't rendered. * Support for parsing files generated with cvs diff -b. Cheers, David On Friday 17 May 2002 10:52, John Goldstone wrote: > There is a bug with the way the diffs are parsed, if there is an empty > diff (such as may be caused by uinsg the -b flag with diff), the TOC is > not properly created. > Attached is diff showing the problem. > This is output from "cvs diff -uNb" in the codestriker directory. > Whitespace diffs were made to codestriker.pl, the others had additional > changes. > > > > -J. |
|
From: John G. <jgo...@mo...> - 2002-05-17 00:52:08
|
PyAuaW5kZXguaHRtbC5zd3AKSW5kZXg6IFJFQURNRQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zz cm9vdC9jb2Rlc3RyaWtlci9jb2Rlc3RyaWtlci9SRUFETUUsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuMTIKZGlmZiAtdSAtYiAtcjEuMTIgUkVBRE1FCi0tLSBSRUFETUUJMTYgTWF5IDIwMDIgMjE6 NTI6NTIgLTAwMDAJMS4xMgorKysgUkVBRE1FCTE3IE1heSAyMDAyIDAwOjQyOjE2IC0wMDAwCkBA IC0xLDQgKzEsNCBAQAotQ29kZXN0cmlrZXIgdjEuNC40CitDb2Rlc3RyaWtlciBwcmUtdjEuNC40 CiBDb3B5cmlnaHQgKGMpIDIwMDEsIDIwMDIgRGF2aWQgU2l0c2t5LiAgQWxsIHJpZ2h0cyByZXNl cnZlZC4KIHNpdHNAdXNlcnMuc291cmNlZm9yZ2UubmV0CiAoc2VlIHRoZSBDSEFOR0VMT0cgZmls ZSBmb3IgZGV0YWlscyBvbiBjaGFuZ2VzKS4KSW5kZXg6IGNvZGVzdHJpa2VyLnBsCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KUkNTIGZpbGU6IC9jdnNyb290L2NvZGVzdHJpa2VyL2NvZGVzdHJpa2VyL2NvZGVzdHJpa2Vy LnBsLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjM4CmRpZmYgLXUgLWIgLXIxLjM4IGNvZGVzdHJp a2VyLnBsCkluZGV4OiBpbmRleC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L2Nv ZGVzdHJpa2VyL2NvZGVzdHJpa2VyL2luZGV4Lmh0bWwsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu MjEKZGlmZiAtdSAtYiAtcjEuMjEgaW5kZXguaHRtbAotLS0gaW5kZXguaHRtbAkxNiBNYXkgMjAw MiAyMTo1Mjo1MyAtMDAwMAkxLjIxCisrKyBpbmRleC5odG1sCTE3IE1heSAyMDAyIDAwOjQyOjE2 IC0wMDAwCkBAIC0xLDcgKzEsNyBAQAogPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RU RCBIVE1MIDMuMiBGaW5hbC8vRU4iPgogPGh0bWw+CiAgICAgPGhlYWQ+Ci0JPHRpdGxlPkNvZGVz dHJpa2VyPC90aXRsZT4KKwkgPFRJVExFPkNvZGVzdHJpa2VyPC9USVRMRT4KICAgICA8L2hlYWQ+ CiAgICAgPGJvZHkgYmdjb2xvcj0id2hpdGUiPgogCTxoMT5Db2Rlc3RyaWtlcjwvaDE+Cg== |
|
From: John G. <jgo...@mo...> - 2002-05-17 00:18:08
|
If no "cc" is provided, this message is found in the errorlog:
codestriker.pl: Use of uninitialized value in concatenation (.) at
/var/www/cgi-bin/codestriker.pl line 2105.
|
|
From: David S. <si...@us...> - 2002-05-15 23:29:38
|
> I noticed a couple problems with the latest code in CVS. You've > probably already found these... But there is a problem with the links > in the content section. They are missing the query part of the url. > Clicking on them cause the browser to jump to the creation page. Yep - this should be fixed now - check out the latest version. > Also, line numbers are wrong. The line numbers printed seem to be the > actual line number in the topic text file rather than line numbers of > the modified files. Hmmm - I can't reproduce this problem, or I don't understand exactly what you mean. The line numbers in the coloured-diff mode on the main screen refer to the codestriker "offsets" - which match the offset numbers that you see in plain text mode. -- Cheers, David |
192 messages has been excluded from this view by a project administrator.
