Re: [Audacity-devel] Pull Request #252

[Paul L. <pau...@gm...>]

Hello andheh,

This looks like an interesting project, but you propose the changes at an
inopportune time.  Our code is feature-frozen and we are in the process of
releasing.

I know I will give this more attention when we thaw, and perhaps James is
interested too, as one who most lately made improvements for the vertical
rulers of tracks.

PRL



On Sat, Feb 10, 2018 at 8:58 AM, andheh <an...@po...> wrote:

> Hello audacity-developers!
>
> I'm andheh. I submitted this pull request
> https://github.com/audacity/audacity/pull/252
> on github last week.
> It enables to switch the vertical ruler of the spectrogram display of an
> audio track from showing frequencies in Hz to showing musical note names.
>
> The changes include:
> * The new ruler mode.
> * Extended the spectrogram settings to switch between Hz and
>   note display and to set the tuning of "a4" (default: 440Hz).
> * Added a Clamp function.
> * Removed an old, unused "CustomMode" of the Ruler class and added
>   a function to add custom ticks
> * Added generalized versions of FreqToMIDInote() and MIDInoteToFreq()
>   which include the tuning frequency of "a4".
>
> I just read on the wiki that you prefer to discuss larger
> changes/additions on the mailinglist, so I write this mail to get the
> discussion started. :)
>
> Has anyone had a look at my proposed changes already?
> I welcome more feedback on the changes!
>
> Best,
> andheh
>
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> audacity-devel mailing list
> aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>